*** rbrady has quit IRC | 00:24 | |
*** rbrady has joined #openstack-mistral | 00:37 | |
*** rbrady has joined #openstack-mistral | 00:37 | |
*** zhurong has joined #openstack-mistral | 00:38 | |
*** bobh has joined #openstack-mistral | 00:59 | |
*** bobh has quit IRC | 01:07 | |
*** rbrady has quit IRC | 01:23 | |
*** rbrady has joined #openstack-mistral | 01:37 | |
*** rbrady has quit IRC | 01:37 | |
*** rbrady has joined #openstack-mistral | 01:37 | |
*** zhurong has quit IRC | 01:46 | |
daidv | d0ugal, policy-in-code is ready to go, can you review these for me: https://review.openstack.org/#/q/topic:policy-and-docs-in-code+(status:open+OR+status:merged)+project:openstack/mistral | 01:56 |
---|---|---|
*** zhurong has joined #openstack-mistral | 02:00 | |
*** jistr has quit IRC | 03:42 | |
*** jistr has joined #openstack-mistral | 03:43 | |
*** yangyape_ has joined #openstack-mistral | 04:10 | |
*** yangyapeng has quit IRC | 04:10 | |
*** AlexeyAbashkin has joined #openstack-mistral | 04:18 | |
*** gkadam_ has joined #openstack-mistral | 04:21 | |
*** gkadam_ has quit IRC | 04:22 | |
*** gkadam_ has joined #openstack-mistral | 04:22 | |
*** AlexeyAbashkin has quit IRC | 04:22 | |
*** gkadam_ is now known as gkadam | 04:23 | |
*** zhurong has quit IRC | 07:20 | |
*** AlexeyAbashkin has joined #openstack-mistral | 07:58 | |
*** zhurong has joined #openstack-mistral | 07:59 | |
d0ugal | daidv: sure, I'll take a look. I'll need to find some background to read, I'm not sure I understand this work. | 08:04 |
daidv | d0ugal, thanks. | 08:07 |
* d0ugal reads https://governance.openstack.org/tc/goals/queens/policy-in-code.html | 08:07 | |
*** shardy has joined #openstack-mistral | 08:16 | |
*** oidgar has joined #openstack-mistral | 08:21 | |
*** gkadam has quit IRC | 08:34 | |
*** gkadam has joined #openstack-mistral | 08:35 | |
*** jpich has joined #openstack-mistral | 09:02 | |
*** jaosorior has quit IRC | 09:15 | |
*** zhurong has quit IRC | 09:48 | |
jtomasek | d0ugal: hi, it seems that a workflow execution which has not been updated yet does not have updated_at set. Do you think it would make sense to set it the same as created_at when execution is created? | 10:06 |
jtomasek | d0ugal: hmm, actually that is what happens it seems.... | 10:09 |
d0ugal | jtomasek: I feel like it should be empty if it hasn't been updated :) | 10:09 |
d0ugal | jtomasek: https://github.com/openstack/mistral/blob/14c8d807b1c9a1b5f8dc72e19fab0f623ccf9d8e/mistral/db/sqlalchemy/model_base.py#L113-L116 | 10:12 |
d0ugal | jtomasek: it seems intentional and makes sense to me. | 10:12 |
jtomasek | d0ugal: so when I run POST /executions the response I get is http://paste.openstack.org/show/625331/ | 10:14 |
jtomasek | d0ugal: which resembles to the docs https://docs.openstack.org/mistral/latest/api/v2.html#executions | 10:15 |
jtomasek | and thats perfectly fine as that's what I expect | 10:15 |
jtomasek | but | 10:15 |
* d0ugal was waiting for that "but" | 10:15 | |
d0ugal | back in a sec | 10:16 |
jtomasek | when I receive an execution via zaqar message (https://github.com/openstack/tripleo-common/blob/master/workbooks/validations.yaml#L64) | 10:16 |
jtomasek | it is this: | 10:16 |
jtomasek | http://paste.openstack.org/show/625333/ | 10:19 |
jtomasek | d0ugal: the execution (on line 26) does not have updated_at | 10:20 |
jtomasek | d0ugal: which is inconsistent, and I wonder if it ever has that value or why it is not there... when that value clearly is defined at that point | 10:21 |
*** xavierhardy has quit IRC | 10:22 | |
d0ugal | jtomasek: looking | 10:25 |
d0ugal | They are very different interfaces which is why they are inconsistent | 10:25 |
d0ugal | execution() is really designed to be used within workflow logic | 10:26 |
d0ugal | we kind-of abuse it to use it to send that to the end-user. | 10:26 |
d0ugal | jtomasek: https://github.com/openstack/mistral/blob/master/mistral/utils/expression_utils.py#L104-L115 | 10:26 |
d0ugal | That is where it comes from. | 10:26 |
d0ugal | updated_at is there, interesting. | 10:27 |
jtomasek | so upddated_at is defined there but it does not appear in the message.. yeah | 10:27 |
d0ugal | I wonder if it is filtered out somewhere when it is empty? | 10:27 |
* d0ugal digs deeper | 10:28 | |
d0ugal | That is very strange. | 10:30 |
d0ugal | jtomasek: it was added recently. | 10:31 |
jtomasek | aha | 10:31 |
*** xavierhardy has joined #openstack-mistral | 10:31 | |
d0ugal | 1 month ago | 10:31 |
d0ugal | https://github.com/openstack/mistral/commit/2871812788410ecac4298e2888a5460dfcdfa65e | 10:31 |
d0ugal | so fairly recent. | 10:32 |
jtomasek | so that problem might be fixed, I did not update my setup yet, are you able to run the validation to see if the message includes it? | 10:32 |
d0ugal | jtomasek: I am in the process of rebuilding | 10:32 |
jtomasek | ok, never mind | 10:32 |
d0ugal | but I'll confirm soon | 10:33 |
d0ugal | (hopefully!) | 10:33 |
jtomasek | cool! | 10:33 |
jtomasek | :) | 10:33 |
*** zhurong has joined #openstack-mistral | 11:12 | |
*** openstackgerrit has joined #openstack-mistral | 11:38 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Re-raise DB errors when evaluating expressions https://review.openstack.org/517277 | 11:38 |
*** jaosorior has joined #openstack-mistral | 11:42 | |
*** shardy is now known as shardy_lunch | 12:01 | |
d0ugal | rakhmerov: is the output on a workflow called regardless of the workflow state? i.e. on error | 12:01 |
*** jaosorior has quit IRC | 12:08 | |
*** jkilpatr has joined #openstack-mistral | 12:16 | |
*** oidgar has quit IRC | 12:25 | |
*** gkadam has quit IRC | 12:30 | |
*** tung_doan has joined #openstack-mistral | 12:32 | |
tung_doan | Hi d0ugal: I am installing mistral but got a bunch of errors when run mistral-db-manage --config-file /etc/mistral/mistral.conf populate | 12:33 |
tung_doan | d0ugal: this is error: http://paste.openstack.org/show/625343/ | 12:34 |
tung_doan | d0ugal: do you have any suggestion? thanks | 12:34 |
*** jaosorior has joined #openstack-mistral | 12:34 | |
tung_doan | :) | 12:34 |
d0ugal | tung_doan: those errors are expected if you don't have openstack clients installed for some of the projects. | 12:38 |
d0ugal | tung_doan: those particular errors mean you don't have novaclient installed, so you wont get the nova openstack actions. | 12:39 |
d0ugal | if you don't want/need them it is safe to continue. | 12:39 |
d0ugal | Otherwise install the client and run the command again. | 12:39 |
*** zhurong has quit IRC | 12:51 | |
*** toure_biab is now known as toure | 13:14 | |
*** bobh has joined #openstack-mistral | 13:15 | |
*** AlexeyAbashkin has quit IRC | 13:23 | |
*** shardy_lunch is now known as shardy | 13:25 | |
*** thrash is now known as thrash|biab | 13:29 | |
openstackgerrit | Merged openstack/mistral master: 'all' parameter breaks task context https://review.openstack.org/510384 | 13:34 |
*** AlexeyAbashkin has joined #openstack-mistral | 13:45 | |
*** thrash|biab is now known as thrash | 14:01 | |
*** jkilpatr has quit IRC | 14:06 | |
*** xavierhardy has left #openstack-mistral | 14:17 | |
*** jkilpatr has joined #openstack-mistral | 14:24 | |
tung_doan | d0ugal: got it. thanks | 14:32 |
*** thrash is now known as thrash|biab | 14:41 | |
tung_doan | d0ugal: sorry for bothering. Even I install nova client, I still got exact issue like this: https://bugs.launchpad.net/mistral/+bug/1684109 | 14:48 |
openstack | Launchpad bug 1684109 in Mistral "sync_db.py: Failed to create action" [Undecided,New] | 14:48 |
*** thrash|biab is now known as thrash | 14:58 | |
*** gkadam has joined #openstack-mistral | 15:23 | |
*** thrash is now known as thrash|biab | 15:38 | |
*** AlexeyAbashkin has quit IRC | 15:53 | |
*** shardy has quit IRC | 15:59 | |
*** katkapilatova has quit IRC | 16:05 | |
*** katkapilatova has joined #openstack-mistral | 16:07 | |
*** jaosorior has quit IRC | 16:08 | |
*** katkapilatova has quit IRC | 16:09 | |
d0ugal | tung_doan: that error is then for magnum client | 16:09 |
d0ugal | tung_doan: you will get one for each openstack client | 16:09 |
*** katkapilatova has joined #openstack-mistral | 16:10 | |
*** katkapilatova_ has joined #openstack-mistral | 16:10 | |
tung_doan | d0ugal: my point is i still got error even i already installed nova client. anw, I will look deeply into this issue. Thanks | 16:47 |
tung_doan | :) | 16:47 |
d0ugal | tung_doan: okay, there may be a specific bug with the nova actions then - if you can find out more about that it would be good to report it | 16:48 |
tung_doan | d0ugal: sure.. i am willing to make mistral doc better :) hahaa | 16:51 |
d0ugal | tung_doan: http://logs.openstack.org/68/516668/1/check/legacy-tripleo-ci-centos-7-scenario003-multinode-oooq-puppet/8237ac7/logs/undercloud/var/log/mistral/mistral-db-manage.log.txt.gz | 16:51 |
d0ugal | tung_doan: thanks! | 16:51 |
d0ugal | tung_doan: we get lots of those errors too - maybe there is something wrong with the nova actions. | 16:51 |
d0ugal | most of them we expect, because we don't have many clients installed | 16:51 |
tung_doan | d0ugal: yeah.. that is newest log in mistral gerrit? | 16:51 |
d0ugal | tung_doan: that CI run was 2 days ago | 16:52 |
d0ugal | so maybe not newest, but one of the most recent | 16:52 |
tung_doan | okay... firstly, i need to check my local environment. Then figure out whether it is a bug | 16:53 |
d0ugal | thanks | 16:54 |
d0ugal | I'll try and look more into it tomorrow, it does seem strange | 16:54 |
d0ugal | Some of the nova actions do register correctly, but some don't | 16:55 |
tung_doan | d0ugal: nice!!! actually i am also trying to test Tacker manually. Hopefully, I also can help tacker doc better | 16:55 |
tung_doan | d0ugal: that is exact issue I met | 16:55 |
tung_doan | just few nova actions | 16:56 |
*** thrash|biab is now known as thrash | 17:16 | |
*** AlexeyAbashkin has joined #openstack-mistral | 17:31 | |
*** katkapilatova has quit IRC | 17:32 | |
*** katkapilatova_ is now known as katkapilatova | 17:32 | |
*** AlexeyAbashkin has quit IRC | 17:35 | |
*** jpich has quit IRC | 17:57 | |
*** gkadam has quit IRC | 18:08 | |
*** gkadam has joined #openstack-mistral | 18:09 | |
*** AlexeyAbashkin has joined #openstack-mistral | 18:09 | |
*** AlexeyAbashkin has quit IRC | 18:14 | |
*** rakhmerov has quit IRC | 18:23 | |
*** rakhmerov has joined #openstack-mistral | 18:28 | |
*** toure is now known as toure_biab | 18:52 | |
*** vishwanathj has quit IRC | 19:23 | |
*** dprince has joined #openstack-mistral | 19:28 | |
*** gkadam has quit IRC | 19:54 | |
*** dprince has quit IRC | 20:08 | |
*** dprince has joined #openstack-mistral | 20:14 | |
*** dprince has quit IRC | 20:17 | |
*** dprince has joined #openstack-mistral | 20:17 | |
openstackgerrit | Mike Fedosin proposed openstack/mistral master: Do not parse updated_at for task if it was not updated https://review.openstack.org/517427 | 20:29 |
*** dprince has quit IRC | 20:54 | |
*** AlexeyAbashkin has joined #openstack-mistral | 21:08 | |
*** AlexeyAbashkin has quit IRC | 21:13 | |
*** jtomasek has quit IRC | 21:35 | |
*** d0ugal has quit IRC | 21:40 | |
*** d0ugal has joined #openstack-mistral | 21:47 | |
*** bobh has quit IRC | 21:58 | |
*** AlexeyAbashkin has joined #openstack-mistral | 22:08 | |
*** AlexeyAbashkin has quit IRC | 22:13 | |
*** bobh has joined #openstack-mistral | 23:16 | |
*** bobh has quit IRC | 23:16 | |
*** bobh has joined #openstack-mistral | 23:23 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!