| *** bobh has joined #openstack-mistral | 00:13 | |
| *** bobh has quit IRC | 00:33 | |
| *** yangyapeng has quit IRC | 00:51 | |
| *** yangyapeng has joined #openstack-mistral | 00:51 | |
| *** yangyapeng has quit IRC | 00:56 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 01:23 | |
| *** AlexeyAbashkin has quit IRC | 01:27 | |
| *** bobh has joined #openstack-mistral | 01:36 | |
| *** bobh has quit IRC | 01:37 | |
| *** yangyapeng has joined #openstack-mistral | 01:48 | |
| *** yangyape_ has joined #openstack-mistral | 01:49 | |
| *** yangyapeng has quit IRC | 01:52 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 02:23 | |
| *** AlexeyAbashkin has quit IRC | 02:27 | |
| *** chlong has quit IRC | 02:47 | |
| *** openstackgerrit has quit IRC | 03:22 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 03:23 | |
| *** AlexeyAbashkin has quit IRC | 03:27 | |
| *** gkadam has joined #openstack-mistral | 03:55 | |
| *** int32bit has joined #openstack-mistral | 04:15 | |
| *** int32bit has quit IRC | 04:16 | |
| *** int32bit has joined #openstack-mistral | 04:17 | |
| *** int32bit has quit IRC | 04:18 | |
| *** int32bit has joined #openstack-mistral | 04:18 | |
| *** int32bit has quit IRC | 04:19 | |
| *** int32bit has joined #openstack-mistral | 04:20 | |
| *** int32bit has quit IRC | 04:21 | |
| *** int32bit has joined #openstack-mistral | 04:22 | |
| *** int32bit has quit IRC | 04:23 | |
| *** int32bit has joined #openstack-mistral | 04:23 | |
| *** int32bit has quit IRC | 04:24 | |
| *** int32bit has joined #openstack-mistral | 04:25 | |
| *** int32bit has quit IRC | 04:26 | |
| *** int32bit has joined #openstack-mistral | 04:26 | |
| *** int32bit has quit IRC | 04:27 | |
| *** int32bit has joined #openstack-mistral | 05:06 | |
| *** int32bit has quit IRC | 05:07 | |
| *** int32bit has joined #openstack-mistral | 05:08 | |
| *** int32bit has quit IRC | 05:09 | |
| *** int32bit has joined #openstack-mistral | 05:10 | |
| *** int32bit has quit IRC | 05:11 | |
| *** int32bit has joined #openstack-mistral | 05:12 | |
| *** int32bit has quit IRC | 05:13 | |
| *** int32bit has joined #openstack-mistral | 05:13 | |
| *** int32bit has quit IRC | 05:14 | |
| *** int32bit has joined #openstack-mistral | 05:15 | |
| *** int32bit has quit IRC | 05:16 | |
| *** int32bit has joined #openstack-mistral | 05:17 | |
| *** int32bit has quit IRC | 05:18 | |
| *** int32bit has joined #openstack-mistral | 05:18 | |
| *** int32bit has quit IRC | 05:19 | |
| *** int32bit has joined #openstack-mistral | 05:20 | |
| *** int32bit has quit IRC | 05:21 | |
| *** int32bit has joined #openstack-mistral | 05:22 | |
| *** int32bit has quit IRC | 05:23 | |
| *** shardy has quit IRC | 05:23 | |
| *** int32bit has joined #openstack-mistral | 05:23 | |
| *** int32bit has quit IRC | 05:24 | |
| *** int32bit has joined #openstack-mistral | 05:25 | |
| *** shardy has joined #openstack-mistral | 05:25 | |
| *** int32bit has quit IRC | 05:28 | |
| *** int32bit has joined #openstack-mistral | 05:51 | |
| *** int32bit has quit IRC | 05:52 | |
| *** int32bit has joined #openstack-mistral | 05:53 | |
| *** int32bit has quit IRC | 05:54 | |
| *** int32bit has joined #openstack-mistral | 05:55 | |
| *** int32bit has quit IRC | 05:56 | |
| *** jtomasek has joined #openstack-mistral | 06:42 | |
| *** jtomasek has quit IRC | 06:44 | |
| *** jtomasek has joined #openstack-mistral | 06:44 | |
| *** jpich has joined #openstack-mistral | 07:05 | |
| *** shardy is now known as shardy_afk | 07:26 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 07:57 | |
| *** shardy_afk is now known as shardy | 08:00 | |
| *** rook has quit IRC | 08:07 | |
| *** weshay|ruck has quit IRC | 08:07 | |
| *** rook has joined #openstack-mistral | 08:08 | |
| *** rook is now known as Guest83828 | 08:09 | |
| *** weshay has joined #openstack-mistral | 08:09 | |
| *** Qiming_ has joined #openstack-mistral | 08:25 | |
| *** Qiming has quit IRC | 08:28 | |
| *** jrist has quit IRC | 08:30 | |
| *** int32bit has joined #openstack-mistral | 08:39 | |
| *** int32bit has quit IRC | 08:41 | |
| *** int32bit has joined #openstack-mistral | 08:41 | |
| *** int32bit has quit IRC | 08:43 | |
| *** int32bit has joined #openstack-mistral | 08:43 | |
| *** int32bit has quit IRC | 08:44 | |
| *** int32bit has joined #openstack-mistral | 08:45 | |
| *** int32bit has quit IRC | 08:46 | |
| *** int32bit has joined #openstack-mistral | 08:47 | |
| *** int32bit has quit IRC | 08:48 | |
| *** jtomasek has quit IRC | 08:48 | |
| *** int32bit has joined #openstack-mistral | 08:49 | |
| *** jtomasek has joined #openstack-mistral | 08:49 | |
| *** int32bit has quit IRC | 08:51 | |
| *** int32bit has joined #openstack-mistral | 08:52 | |
| *** int32bit has quit IRC | 08:53 | |
| *** int32bit has joined #openstack-mistral | 08:54 | |
| *** int32bit has quit IRC | 08:55 | |
| *** int32bit has joined #openstack-mistral | 08:55 | |
| *** int32bit has quit IRC | 08:57 | |
| *** int32bit has joined #openstack-mistral | 08:57 | |
| *** int32bit has quit IRC | 08:58 | |
| *** int32bit has joined #openstack-mistral | 08:59 | |
| *** int32bit has quit IRC | 09:00 | |
| *** int32bit has joined #openstack-mistral | 09:01 | |
| *** int32bit has quit IRC | 09:02 | |
| *** int32bit has joined #openstack-mistral | 09:02 | |
| *** int32bit has quit IRC | 09:03 | |
| *** int32bit has joined #openstack-mistral | 09:04 | |
| *** int32bit has quit IRC | 09:05 | |
| *** int32bit has joined #openstack-mistral | 09:06 | |
| *** int32bit has quit IRC | 09:07 | |
| *** int32bit has joined #openstack-mistral | 09:07 | |
| *** int32bit has quit IRC | 09:08 | |
| *** openstackgerrit has joined #openstack-mistral | 09:17 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Allow filtering executions by their root_execution_id https://review.openstack.org/490562 | 09:17 |
|---|---|---|
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Add the Ironic wait_for_provision_state action https://review.openstack.org/506268 | 09:23 |
| *** AlexeyAbashkin has quit IRC | 09:49 | |
| xavierhardy | Hi everyone | 10:07 |
| xavierhardy | I have the impression that "openstack_actions_mapping_path" has not been added to the DEFAULT group in the configuration in Mistral pike. | 10:08 |
| *** yangyape_ has quit IRC | 10:09 | |
| d0ugal | xavierhardy: I believe that is because it isn't intended to be used in the config file | 10:10 |
| d0ugal | only on the CLI | 10:10 |
| d0ugal | https://github.com/openstack/mistral/blob/481fb31bd1d75de4d8e44aa9d3f171d9c6f51296/mistral/config.py#L354-L355 | 10:10 |
| *** Guest83828 is now known as rook | 10:18 | |
| rakhmerov | yes, correct | 10:30 |
| rakhmerov | d0ugal: can you please review https://review.openstack.org/#/c/512520/ ? | 10:32 |
| d0ugal | rakhmerov: sure | 10:33 |
| rakhmerov | thanks | 10:33 |
| d0ugal | rakhmerov: "Why do we run cron triggers in the API layer?" - I have wondered this before :) | 10:34 |
| rakhmerov | yeah :) | 10:34 |
| d0ugal | I think I noticed because cron logs end up in the API log file which is strange | 10:34 |
| rakhmerov | yes | 10:34 |
| rakhmerov | so, well it was obviously a bad decision to place it there | 10:35 |
| rakhmerov | but I think the rationale was "it's not part of the core functionality, it's just a triggering mechanism so let's make it outside of engine. Where? API is the only visible choice" | 10:35 |
| rakhmerov | I guess that was our naive logic | 10:36 |
| d0ugal | Right. I guess that makes sense. | 10:36 |
| rakhmerov | we'll move it out | 10:36 |
| d0ugal | so does this mean you don't use cron triggers? | 10:36 |
| rakhmerov | nope | 10:36 |
| rakhmerov | at Nokia, no | 10:36 |
| rakhmerov | btw, there are some other problems with cron triggers that I found 2 days ago | 10:37 |
| rakhmerov | the bottom line is: they can't be used now in HA mode | 10:37 |
| d0ugal | rakhmerov: I'm aware of one problem :) one of my colleagues is going to open a bug | 10:37 |
| d0ugal | oh, that isn't good. | 10:37 |
| rakhmerov | at least with a large number of nodes (API nodes, aah.. sounds crazy) | 10:37 |
| rakhmerov | yeah | 10:37 |
| rakhmerov | it is not | 10:37 |
| rakhmerov | we fixed a number of issues with Scheduler to make it more stable in HA (although we need to change its design still) | 10:38 |
| rakhmerov | but cron triggers are not based on it | 10:38 |
| rakhmerov | it's a completely separate mechanism | 10:38 |
| rakhmerov | => has similar issues | 10:38 |
| d0ugal | The problem we noticed was with cron triggers that run every minute - they stop for a while for no reason. maybe for 5 mins it just wont trigger. | 10:38 |
| rakhmerov | yep | 10:39 |
| rakhmerov | probably because of the load | 10:39 |
| rakhmerov | or its TX hit a DB deadlock | 10:39 |
| d0ugal | maybe, but the workflow was very fast | 10:39 |
| d0ugal | ah, maybe that | 10:39 |
| d0ugal | I need to do some more testing with it | 10:39 |
| rakhmerov | ok | 10:39 |
| rakhmerov | so I have to admit that it's not stable now, with multiple nodes | 10:40 |
| rakhmerov | with 1 node it should work ok | 10:40 |
| d0ugal | Right | 10:40 |
| d0ugal | Now we only use it for a workflow that runs every hour | 10:40 |
| d0ugal | but as we are looking at more cases I'll probably have to try and find time to improve it | 10:41 |
| rakhmerov | ok | 10:41 |
| rakhmerov | just FYI: both Scheduler (which is heavily used in engine) and cron triggers now have a fundamental design problem | 10:41 |
| rakhmerov | they both can't be scaled well | 10:42 |
| d0ugal | uh oh :) | 10:42 |
| rakhmerov | I'm trying to make it work more or less decently for now with the current design but we'll have to fix that in a more fundamental way | 10:42 |
| rakhmerov | d0ugal: sorry that I didn't ask you before and now I have to leave again (will be back in ~3 hours). So, do we know on 100% if making those migrations idempotent is all we need to backport those 2 patches? | 10:44 |
| rakhmerov | if it's that simple, we can do it | 10:44 |
| d0ugal | rakhmerov: I don't know. | 10:44 |
| rakhmerov | :) | 10:44 |
| d0ugal | I actually don't understand why making them idempotent would help | 10:45 |
| d0ugal | Alembic stores the migration state, so it wouldn't normally run them twice | 10:45 |
| rakhmerov | my guess is that in this case it's safe to apply them more than once | 10:45 |
| rakhmerov | well, true | 10:46 |
| rakhmerov | yes | 10:46 |
| rakhmerov | hm... | 10:46 |
| rakhmerov | ok, I'll try to discuss that more with the release team | 10:46 |
| rakhmerov | d0ugal: one more thing, I just noticed that https://review.openstack.org/#/c/506268/ is still not approved | 10:46 |
| rakhmerov | do you need it in Pike? | 10:47 |
| rakhmerov | soon? | 10:47 |
| d0ugal | rakhmerov: no, only queens | 10:47 |
| rakhmerov | ooh, ok | 10:47 |
| d0ugal | There isn't a big rush really, but it would be nice to remove it from my queue | 10:47 |
| rakhmerov | yeah | 10:47 |
| rakhmerov | Andras is on vacation now | 10:47 |
| rakhmerov | I'll ask Nikolay | 10:48 |
| rakhmerov | or someone else | 10:48 |
| d0ugal | rakhmerov: it is okay, we can easily work around it | 10:48 |
| d0ugal | https://github.com/openstack/tripleo-common/blob/master/workbooks/baremetal.yaml#L79-L86 | 10:48 |
| d0ugal | ^ just like we do here :) | 10:48 |
| rakhmerov | :) | 10:48 |
| d0ugal | it would just be more efficient to use the client method | 10:49 |
| rakhmerov | ok | 10:49 |
| rakhmerov | I'm off for now.. | 10:49 |
| d0ugal | okay, cya! | 10:49 |
| d0ugal | rakhmerov: btw, I think the simplest solution would be to reverse the migrations in master and only backport one - I can do this if you want, it would be trivial | 10:50 |
| apetrich | d0ugal, after some thought I think that is a better solution | 10:53 |
| *** int32bit has joined #openstack-mistral | 10:54 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 10:55 | |
| d0ugal | There is only one narrow case where it will break users. If you are running master and have 23 applied but not 24. Then when you upgrade to the latest master it will try and apply 24, but it will be reversed and you will really try to apply the same one twice and be missing the other one | 10:56 |
| d0ugal | ... but I think that is a small risk. | 10:56 |
| *** int32bit has quit IRC | 10:59 | |
| apetrich | aye | 11:00 |
| *** chlong has joined #openstack-mistral | 11:01 | |
| *** jrist has joined #openstack-mistral | 11:09 | |
| *** thrash|g0ne is now known as thrash | 11:15 | |
| d0ugal | thrash: ^ what do you think of that idea (my last 3 msgs). Just seen your email on the list. | 11:26 |
| *** yangyapeng has joined #openstack-mistral | 11:45 | |
| *** oidgar has joined #openstack-mistral | 12:07 | |
| *** Dinesh_Bhor has quit IRC | 12:09 | |
| *** dprince has joined #openstack-mistral | 12:12 | |
| xavierhardy | OK, you register it directly in sync_db.py | 12:21 |
| xavierhardy | OK | 12:21 |
| *** gkadam has quit IRC | 12:34 | |
| *** toure_biab is now known as toure | 12:56 | |
| *** shardy has quit IRC | 13:00 | |
| *** shardy has joined #openstack-mistral | 13:00 | |
| *** oidgar has quit IRC | 13:02 | |
| *** shardy has quit IRC | 13:11 | |
| *** shardy has joined #openstack-mistral | 13:13 | |
| *** oidgar has joined #openstack-mistral | 13:18 | |
| *** oidgar has quit IRC | 13:27 | |
| openstackgerrit | Merged openstack/mistral master: Add the Ironic wait_for_provision_state action https://review.openstack.org/506268 | 13:33 |
| *** oidgar has joined #openstack-mistral | 13:37 | |
| openstackgerrit | Mike Fedosin proposed openstack/python-mistralclient master: Fix several problems in keycloak auth module https://review.openstack.org/507269 | 14:07 |
| *** oidgar has quit IRC | 14:09 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-lib master: Add an empty __init__ method to the base Action class https://review.openstack.org/513060 | 14:52 |
| *** chlong has quit IRC | 14:52 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Use the new action context in MistralHTTPAction https://review.openstack.org/505508 | 14:59 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Remove the __init__ method from the test action https://review.openstack.org/513061 | 14:59 |
| d0ugal | TIL ^ | 15:12 |
| *** catintheroof has joined #openstack-mistral | 15:13 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Pass the new ActionContext to mistral-lib https://review.openstack.org/506185 | 15:29 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Use the new action context in MistralHTTPAction https://review.openstack.org/505508 | 15:29 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Remove the __init__ method from the test action https://review.openstack.org/513061 | 15:29 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Allow filtering executions by their root_execution_id https://review.openstack.org/490562 | 15:31 |
| *** jpich has quit IRC | 15:59 | |
| *** gkadam has joined #openstack-mistral | 16:02 | |
| *** gkadam has quit IRC | 16:22 | |
| *** thrash is now known as thrash|biab | 16:38 | |
| *** AlexeyAbashkin has quit IRC | 16:47 | |
| *** thrash|biab is now known as thrash | 17:08 | |
| *** bobh has joined #openstack-mistral | 17:35 | |
| *** catinthe_ has joined #openstack-mistral | 17:53 | |
| *** catintheroof has quit IRC | 17:53 | |
| *** catintheroof has joined #openstack-mistral | 17:59 | |
| *** catinthe_ has quit IRC | 18:01 | |
| *** catinthe_ has joined #openstack-mistral | 18:05 | |
| *** catintheroof has quit IRC | 18:07 | |
| *** int32bit has joined #openstack-mistral | 18:10 | |
| *** int32bit has quit IRC | 18:12 | |
| *** catintheroof has joined #openstack-mistral | 18:14 | |
| *** catinthe_ has quit IRC | 18:15 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 18:19 | |
| *** AlexeyAbashkin has quit IRC | 18:24 | |
| *** rbrady is now known as rbrady-afk | 18:29 | |
| *** weshay is now known as weshay|ruck|brb | 18:30 | |
| *** dprince has quit IRC | 19:08 | |
| *** weshay|ruck|brb is now known as weshay|ruck | 19:18 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 19:19 | |
| *** katkapilatova has quit IRC | 19:22 | |
| *** katkapilatova has joined #openstack-mistral | 19:23 | |
| *** AlexeyAbashkin has quit IRC | 19:24 | |
| *** katkapilatova has quit IRC | 19:28 | |
| *** katkapilatova has joined #openstack-mistral | 19:29 | |
| *** katkapilatova has quit IRC | 19:33 | |
| *** katkapilatova has joined #openstack-mistral | 19:34 | |
| *** katkapilatova has quit IRC | 19:38 | |
| *** katkapilatova has joined #openstack-mistral | 19:39 | |
| *** katkapilatova has quit IRC | 19:43 | |
| *** katkapilatova has joined #openstack-mistral | 19:44 | |
| *** katkapilatova has quit IRC | 19:49 | |
| *** katkapilatova has joined #openstack-mistral | 19:50 | |
| *** katkapilatova has quit IRC | 19:54 | |
| *** katkapilatova has joined #openstack-mistral | 19:56 | |
| *** katkapilatova has quit IRC | 20:01 | |
| *** katkapilatova has joined #openstack-mistral | 20:01 | |
| *** toure is now known as toure_biab | 20:03 | |
| *** katkapilatova has quit IRC | 20:05 | |
| *** katkapilatova has joined #openstack-mistral | 20:07 | |
| *** jkilpatr has quit IRC | 20:10 | |
| *** katkapilatova has quit IRC | 20:12 | |
| *** katkapilatova has joined #openstack-mistral | 20:13 | |
| *** katkapilatova has quit IRC | 20:17 | |
| *** openstackgerrit has quit IRC | 20:17 | |
| *** katkapilatova has joined #openstack-mistral | 20:18 | |
| *** jkilpatr has joined #openstack-mistral | 20:26 | |
| *** catintheroof has quit IRC | 20:53 | |
| *** catintheroof has joined #openstack-mistral | 20:54 | |
| *** openstackgerrit has joined #openstack-mistral | 20:56 | |
| openstackgerrit | Brad P. Crochet proposed openstack/python-mistralclient master: Migrate python-mistralclient jobs to Zuul v3 https://review.openstack.org/509184 | 20:56 |
| *** catintheroof has quit IRC | 20:58 | |
| *** int32bit has joined #openstack-mistral | 21:09 | |
| *** int32bit has quit IRC | 21:11 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 21:19 | |
| *** AlexeyAbashkin has quit IRC | 21:24 | |
| *** jtomasek has quit IRC | 21:40 | |
| *** openstackgerrit has quit IRC | 21:48 | |
| *** bobh has quit IRC | 22:00 | |
| *** openstackgerrit has joined #openstack-mistral | 23:13 | |
| openstackgerrit | Winson Chan proposed openstack/mistral master: Implement notification of execution events https://review.openstack.org/467799 | 23:13 |
| *** AlexeyAbashkin has joined #openstack-mistral | 23:19 | |
| openstackgerrit | Winson Chan proposed openstack/mistral master: Implement notification of execution events https://review.openstack.org/467799 | 23:19 |
| *** AlexeyAbashkin has quit IRC | 23:23 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!