| *** yangyapeng has quit IRC | 00:04 | |
| *** yangyapeng has joined #openstack-mistral | 00:05 | |
| *** yangyapeng has quit IRC | 00:09 | |
| *** zhurong has joined #openstack-mistral | 00:39 | |
| *** yangyapeng has joined #openstack-mistral | 01:13 | |
| *** yangyapeng has quit IRC | 01:14 | |
| *** yangyapeng has joined #openstack-mistral | 01:14 | |
| *** rbrady has quit IRC | 01:15 | |
| *** rbrady has joined #openstack-mistral | 01:28 | |
| *** rbrady has quit IRC | 01:28 | |
| *** rbrady has joined #openstack-mistral | 01:28 | |
| rakhmerov | mattybrennan: yes, graceful executor shutdown is on our roadmap | 01:35 |
|---|---|---|
| rakhmerov | it's not fully implemented yet | 01:36 |
| *** yangyapeng has quit IRC | 01:38 | |
| *** yangyapeng has joined #openstack-mistral | 01:39 | |
| *** yangyapeng has quit IRC | 01:42 | |
| *** yangyapeng has joined #openstack-mistral | 01:43 | |
| *** yangyape_ has joined #openstack-mistral | 01:45 | |
| *** yangyapeng has quit IRC | 01:47 | |
| *** malcomX527 has joined #openstack-mistral | 01:55 | |
| *** malcomX527 has quit IRC | 01:55 | |
| *** gkadam has quit IRC | 01:59 | |
| *** rbrady has quit IRC | 02:18 | |
| *** gkadam has joined #openstack-mistral | 03:13 | |
| *** bobh has joined #openstack-mistral | 03:31 | |
| *** bobh has quit IRC | 03:43 | |
| *** dougshelley66 has joined #openstack-mistral | 04:00 | |
| *** rbrady has joined #openstack-mistral | 04:08 | |
| *** yangyape_ has quit IRC | 04:29 | |
| *** yangyapeng has joined #openstack-mistral | 04:30 | |
| *** yangyapeng has quit IRC | 04:34 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Replace @loopingcall.RetryDecorator with @tenacity.retry https://review.openstack.org/506523 | 04:46 |
| *** yangyapeng has joined #openstack-mistral | 05:20 | |
| *** zhurong has quit IRC | 06:32 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Add actions for the ironic virtual network interface commands https://review.openstack.org/506264 | 06:55 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Add the Ironic wait_for_provision_state action https://review.openstack.org/506268 | 06:55 |
| d0ugal | rakhmerov: hey, so I didn't manage to make much progress with it yesterday | 07:00 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: [WIP] Pass the new ActionContext to mistral-lib https://review.openstack.org/506185 | 07:03 |
| rakhmerov | d0ugal: hi | 07:09 |
| rakhmerov | sorry, just got to answering your question | 07:10 |
| rakhmerov | in case you still have time today to work on it, here's what I think | 07:10 |
| d0ugal | rakhmerov: I have a bit of time, but I'm feeling less confident about finishing it this week :) | 07:10 |
| rakhmerov | that's ok | 07:11 |
| rakhmerov | so, https://github.com/openstack/mistral/blob/master/mistral/engine/actions.py#L338 | 07:11 |
| d0ugal | I am also trying to figure out another issue, cron triggered workflows seem to have a different context passed to actions. | 07:11 |
| rakhmerov | this is the place where we need to prepare this action context to pass it to executor | 07:11 |
| rakhmerov | wooow | 07:11 |
| rakhmerov | that may be actually | 07:11 |
| rakhmerov | yes | 07:11 |
| rakhmerov | Nikolay seems to have fixed something related to this | 07:12 |
| d0ugal | Yeah, I remeber that but it seems to be back. | 07:12 |
| rakhmerov | hah | 07:12 |
| rakhmerov | bad | 07:12 |
| rakhmerov | so, on that actions thing.. This "rpc_ctx" parameter gets passed implicitly by RPC layer | 07:12 |
| d0ugal | right | 07:13 |
| d0ugal | that is why I couldn't track it down :) | 07:13 |
| *** zhurong has joined #openstack-mistral | 07:13 | |
| rakhmerov | I'm thinking may be we just need to insert our execution context right into our auth context? | 07:13 |
| rakhmerov | taken as mistral.context.ctx() | 07:13 |
| rakhmerov | ? | 07:13 |
| d0ugal | ugh, so we just add more to the context? | 07:13 |
| rakhmerov | kind of | 07:13 |
| rakhmerov | yes | 07:13 |
| d0ugal | seems a bit hacky | 07:13 |
| rakhmerov | we can just use some special key | 07:14 |
| rakhmerov | like __execution_context | 07:14 |
| rakhmerov | yeah, hacky, I agree | 07:14 |
| rakhmerov | but not sure how else we can easily get this | 07:14 |
| rakhmerov | otherwise, I think we'll have to change throughout the code what context.ctx() returns | 07:15 |
| d0ugal | Right | 07:15 |
| rakhmerov | not just what it returns, rather how all the code uses it | 07:15 |
| rakhmerov | yes, we could probably create a more generic context including auth context and, if needed, execution context | 07:16 |
| rakhmerov | (basically what we're planning for mistral-lib) | 07:16 |
| rakhmerov | but it's going to be a big change I think | 07:16 |
| rakhmerov | or somehow alter RPC's behavior | 07:17 |
| rakhmerov | don't know yet how | 07:17 |
| rakhmerov | and we also need to keep in mind that it should be agnostic of oslo.messaging RPC | 07:17 |
| rakhmerov | we can also use direct Kombu RPC | 07:17 |
| rakhmerov | that's what I have in mind | 07:17 |
| d0ugal | right, makes sense | 07:18 |
| d0ugal | I guess a hack for now is enough :) | 07:18 |
| d0ugal | Just reading this code to try and get my head around your suggestion. | 07:18 |
| d0ugal | rakhmerov: any idea why we create an empty context here? https://github.com/openstack/mistral/blob/b8d1e096e4cd5869e868cb7ad7101c52f93ea7d1/mistral/services/periodic.py#L141-L146 | 07:45 |
| d0ugal | rakhmerov: I think having a global context is probably a design flaw, it would be much harder to have bugs like this cron-trigger one otherwise | 07:50 |
| d0ugal | but I realise changing that now would be tricky :) | 07:51 |
| *** jpich has joined #openstack-mistral | 07:53 | |
| rakhmerov | d0ugal: nope, I don't remember why | 08:01 |
| *** weshay_bbiab has quit IRC | 08:05 | |
| *** toure_biab has quit IRC | 08:05 | |
| *** harlowja has quit IRC | 08:06 | |
| *** toure has joined #openstack-mistral | 08:07 | |
| *** weshay has joined #openstack-mistral | 08:11 | |
| rakhmerov | d0ugal: before you leave, could you please look at https://review.openstack.org/#/c/506523/ which is pretty tiny but very important for stability | 08:51 |
| rakhmerov | ? | 08:51 |
| rakhmerov | d0ugal: it fixes that problem with the decorator I found yesterday | 08:51 |
| *** livelace has joined #openstack-mistral | 09:03 | |
| d0ugal | rakhmerov: sure | 09:06 |
| d0ugal | rakhmerov: LGTM | 09:09 |
| rakhmerov | thanks! | 09:10 |
| d0ugal | rakhmerov: Can you look at https://review.openstack.org/#/c/480587/ | 09:10 |
| rakhmerov | yes | 09:10 |
| d0ugal | Thanks :) | 09:11 |
| rakhmerov | ooh, the topic looks interesting ) | 09:12 |
| rakhmerov | and it's already merged ) | 09:12 |
| d0ugal | umm | 09:12 |
| d0ugal | rakhmerov: sorry, I meant https://review.openstack.org/#/c/506264/2 | 09:13 |
| rakhmerov | ooh | 09:13 |
| rakhmerov | :) | 09:13 |
| d0ugal | haha, no idea how I copied that other one. | 09:13 |
| rakhmerov | ok | 09:13 |
| rakhmerov | done | 09:16 |
| d0ugal | rakhmerov: thanks. | 09:17 |
| *** livelace has quit IRC | 09:19 | |
| *** yangyapeng has quit IRC | 10:09 | |
| *** yangyapeng has joined #openstack-mistral | 10:09 | |
| *** yangyapeng has quit IRC | 10:14 | |
| *** chlong has quit IRC | 10:16 | |
| *** zhurong has quit IRC | 10:39 | |
| *** d0ugal has quit IRC | 10:48 | |
| *** d0ugal has joined #openstack-mistral | 10:48 | |
| *** d0ugal has quit IRC | 10:48 | |
| openstackgerrit | Merged openstack/mistral master: Replace @loopingcall.RetryDecorator with @tenacity.retry https://review.openstack.org/506523 | 10:59 |
| *** niraj_singh has quit IRC | 11:34 | |
| *** yangyapeng has joined #openstack-mistral | 11:47 | |
| *** bobh has joined #openstack-mistral | 11:48 | |
| *** thrash|g0ne is now known as thrash | 12:00 | |
| *** bobh has quit IRC | 12:17 | |
| *** dprince has joined #openstack-mistral | 12:24 | |
| *** gkadam has quit IRC | 12:31 | |
| *** jaosorior has quit IRC | 12:40 | |
| *** katkapilatova_ has joined #openstack-mistral | 12:45 | |
| *** katkapilatova has quit IRC | 12:46 | |
| *** katkapilatova_ is now known as katkapilatova | 12:46 | |
| *** bobh has joined #openstack-mistral | 12:48 | |
| *** catintheroof has joined #openstack-mistral | 12:50 | |
| *** katkapilatova has quit IRC | 13:08 | |
| *** katkapilatova has joined #openstack-mistral | 13:10 | |
| openstackgerrit | Toure Dunnon proposed openstack/mistral master: [WIP] Running new workflow based on an existing execution. https://review.openstack.org/506652 | 13:11 |
| *** rbrady has quit IRC | 13:14 | |
| openstackgerrit | Toure Dunnon proposed openstack/python-mistralclient master: [WIP] Running new workflow based on existing execution. https://review.openstack.org/506653 | 13:18 |
| toure | rakhmerov so I gave it an initial try, shouldn't be to difficult to complete, will test it out today. | 13:20 |
| toure | rakhmerov https://review.openstack.org/506652 https://review.openstack.org/506653 | 13:20 |
| *** rbrady has joined #openstack-mistral | 13:35 | |
| *** rbrady has joined #openstack-mistral | 13:35 | |
| *** Dinesh_Bhor has quit IRC | 13:36 | |
| *** jkilpatr has quit IRC | 14:21 | |
| *** chlong has joined #openstack-mistral | 14:38 | |
| *** catintheroof has quit IRC | 14:42 | |
| *** thrash is now known as thrash|biab | 15:29 | |
| *** jpich has quit IRC | 16:14 | |
| *** shardy has quit IRC | 16:17 | |
| *** thrash|biab is now known as thrash | 16:41 | |
| *** weshay is now known as weshay_bbiab | 19:15 | |
| *** dprince has quit IRC | 19:20 | |
| openstackgerrit | Brad P. Crochet proposed openstack/mistral master: Update README with Keystone authtoken config https://review.openstack.org/506761 | 19:42 |
| *** thrash is now known as thrash|bbl | 20:01 | |
| *** dprince has joined #openstack-mistral | 20:25 | |
| *** harlowja has joined #openstack-mistral | 21:23 | |
| *** dprince has quit IRC | 21:44 | |
| *** chlong has quit IRC | 21:51 | |
| *** bobh has quit IRC | 22:14 | |
| *** catintheroof has joined #openstack-mistral | 23:07 | |
| *** catintheroof has quit IRC | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!