| *** bobh has joined #openstack-mistral | 00:20 | |
| *** dixiaoli has joined #openstack-mistral | 00:52 | |
| *** yangyapeng has joined #openstack-mistral | 01:01 | |
| *** yangyape_ has joined #openstack-mistral | 01:03 | |
| *** zhenguo_ has joined #openstack-mistral | 01:07 | |
| *** yangyapeng has quit IRC | 01:07 | |
| *** zhenguo_ is now known as zhenguo | 01:15 | |
| *** jkilpatr has joined #openstack-mistral | 01:27 | |
| *** jkilpatr has quit IRC | 01:34 | |
| *** yangyape_ has quit IRC | 02:04 | |
| *** yangyapeng has joined #openstack-mistral | 02:05 | |
| *** yangyapeng has quit IRC | 02:05 | |
| *** yangyapeng has joined #openstack-mistral | 02:06 | |
| *** gkadam has joined #openstack-mistral | 03:24 | |
| *** bobh has quit IRC | 03:43 | |
| *** bobh has joined #openstack-mistral | 03:47 | |
| *** bobh has quit IRC | 03:52 | |
| *** Dinesh_Bhor has joined #openstack-mistral | 03:56 | |
| *** rakhmerov has quit IRC | 04:17 | |
| *** rakhmerov has joined #openstack-mistral | 04:17 | |
| *** vishwanathj has joined #openstack-mistral | 04:53 | |
| *** igormarnat has quit IRC | 05:32 | |
| *** akuznetsova has quit IRC | 05:32 | |
| *** rakhmerov has quit IRC | 05:32 | |
| *** akuznetsova has joined #openstack-mistral | 05:46 | |
| *** rakhmerov has joined #openstack-mistral | 05:47 | |
| *** bobh has joined #openstack-mistral | 05:48 | |
| *** bobh has quit IRC | 05:53 | |
| *** igormarnat has joined #openstack-mistral | 05:55 | |
| *** gkadam is now known as gkadam-afk | 05:55 | |
| *** ddeja_ is now known as ddeja | 06:06 | |
| *** katkapilatova has quit IRC | 07:30 | |
| *** yangyapeng has quit IRC | 07:35 | |
| *** yangyapeng has joined #openstack-mistral | 07:35 | |
| *** katkapilatova has joined #openstack-mistral | 07:37 | |
| *** gkadam-afk is now known as gkadam | 07:46 | |
| *** bobh has joined #openstack-mistral | 07:50 | |
| *** bobh has quit IRC | 07:55 | |
| *** shardy has joined #openstack-mistral | 08:04 | |
| openstackgerrit | Andras Kovi proposed openstack/mistral master: Cleanup test_std_http_action https://review.openstack.org/502035 | 08:28 |
|---|---|---|
| apetrich | bbl | 08:30 |
| *** apetrich has quit IRC | 08:35 | |
| d0ugal | rakhmerov: btw I am looking into the tripleo failure on https://review.openstack.org/#/c/502366/ | 08:47 |
| d0ugal | rakhmerov: it looks like it is hitting: https://bugs.launchpad.net/tripleo/+bug/1716239 | 08:50 |
| openstack | Launchpad bug 1716239 in tripleo "promotion is failing on tempest.scenario.test_network_basic_ops.TestNetworkBasicOps" [Critical,In progress] - Assigned to Alan Pevec (apevec) | 08:50 |
| d0ugal | http://logs.openstack.org/66/502366/1/check/gate-tripleo-ci-centos-7-scenario003-multinode-oooq-puppet/b397e6a/logs/undercloud/home/jenkins/tempest_output.log.txt.gz#_2017-09-11_06_44_03 | 08:50 |
| d0ugal | it looks like a fix landed 45 mins ago - so I'll recheck it shortly. | 08:51 |
| *** Dinesh_Bhor has quit IRC | 08:58 | |
| *** apetrich has joined #openstack-mistral | 09:47 | |
| *** bobh has joined #openstack-mistral | 09:52 | |
| *** bobh has quit IRC | 09:56 | |
| *** Dinesh_Bhor has joined #openstack-mistral | 10:11 | |
| *** apetrich has quit IRC | 10:28 | |
| Dinesh_Bhor | rakhmerov: Hi, just want to know the status of this blueprint: https://blueprints.launchpad.net/mistral/+spec/mistral-custom-actions-api It will be great if you share what is remaining in this. | 10:29 |
| Dinesh_Bhor | rakhmerov: Is it going to add a user interfacing API for adding custom actions or it is just going to provide base classes for custom actions from which developer has to inherit their own? | 10:30 |
| Dinesh_Bhor | d0ugal: Hi, it will be great if you help me with this ^^ | 10:32 |
| d0ugal | Dinesh_Bhor: see https://github.com/openstack/mistral-lib | 10:57 |
| d0ugal | unfortunately it wasn't documented | 10:57 |
| d0ugal | :( | 10:57 |
| d0ugal | but the work was mostly completed | 10:58 |
| *** dixiaoli has quit IRC | 10:59 | |
| Dinesh_Bhor | d0ugal: Okay, thanks you. There will not be a user interfacing API for adding custom actions right? developer will have to inherit their class from "mistral_lib.actions.Action". | 11:02 |
| d0ugal | Dinesh_Bhor: correct, the API is inheritance. | 11:03 |
| d0ugal | Dinesh_Bhor: I am not sure what other API you would be looking for. Do you mean in the REST API? | 11:03 |
| *** jkilpatr has joined #openstack-mistral | 11:04 | |
| Dinesh_Bhor | d0ugal: yes, I was in that impression by looking at the spec but now it is clear | 11:04 |
| d0ugal | Right | 11:04 |
| d0ugal | API is an overloaded term :) | 11:04 |
| d0ugal | In this case we are talking about the Python API, not a REST API. | 11:05 |
| Dinesh_Bhor | d0ugal: yes, thank you for information and time. | 11:05 |
| d0ugal | np | 11:05 |
| d0ugal | Having a way to add actions via the REST API would be interesting, but quite difficult. | 11:05 |
| Dinesh_Bhor | d0ugal: okay. I think with REST API way we can also eliminate the requirement of calling the "mistral-db-manage populate" after adding custom actions. | 11:09 |
| Dinesh_Bhor | d0ugal: but yes, I agree its difficult to implement | 11:10 |
| d0ugal | I think sandboxing and making it safe is the harder problem | 11:11 |
| *** jkilpatr has quit IRC | 11:11 | |
| Dinesh_Bhor | d0ugal: agree | 11:12 |
| *** jkilpatr has joined #openstack-mistral | 11:23 | |
| *** bobh has joined #openstack-mistral | 11:44 | |
| *** bobh has quit IRC | 11:51 | |
| *** apetrich has joined #openstack-mistral | 12:00 | |
| *** catintheroof has joined #openstack-mistral | 12:35 | |
| *** gkadam has quit IRC | 12:36 | |
| *** apetrich has quit IRC | 12:37 | |
| *** apetrich has joined #openstack-mistral | 12:42 | |
| *** jtomasek has joined #openstack-mistral | 12:52 | |
| *** bobh has joined #openstack-mistral | 13:04 | |
| *** yangyape_ has joined #openstack-mistral | 13:08 | |
| *** yangyapeng has quit IRC | 13:09 | |
| *** katkapilatova has quit IRC | 13:15 | |
| *** katkapilatova has joined #openstack-mistral | 13:17 | |
| *** jtomasek has quit IRC | 13:26 | |
| *** apetrich has quit IRC | 13:57 | |
| *** fultonj has joined #openstack-mistral | 14:53 | |
| *** apetrich has joined #openstack-mistral | 14:57 | |
| *** apetrich has quit IRC | 15:07 | |
| *** apetrich has joined #openstack-mistral | 15:08 | |
| *** catintheroof has quit IRC | 15:08 | |
| *** jtomasek has joined #openstack-mistral | 15:09 | |
| *** catintheroof has joined #openstack-mistral | 15:30 | |
| rakhmerov | d0ugal: ok, thanks | 15:33 |
| rakhmerov | d0ugal: I saw that you already rechecked some time ago and it failed again | 15:33 |
| d0ugal | yeah, I am not sure why | 15:33 |
| rakhmerov | does that issue still exist? | 15:33 |
| d0ugal | I need to look at it again | 15:33 |
| rakhmerov | ok | 15:33 |
| rakhmerov | please, when you have a chance | 15:34 |
| rakhmerov | d0ugal: as far as I understand, pretty much all CI is now blocked? | 15:34 |
| rakhmerov | or it's only about this patch? | 15:34 |
| *** jpich has joined #openstack-mistral | 15:35 | |
| d0ugal | rakhmerov: all of CI | 15:35 |
| d0ugal | I think | 15:35 |
| rakhmerov | Dinesh_Bhor: hi | 15:35 |
| rakhmerov | are you here at the PTG? | 15:35 |
| rakhmerov | Dinesh_Bhor: we're planning to review this BP on Wed and collect all what we think is left on it | 15:36 |
| rakhmerov | yes, as d0ugal said, one obvious thing is documentation. Afaik, it exists but it's definitely not enough | 15:36 |
| rakhmerov | d0ugal: ok | 15:37 |
| *** aspiers has joined #openstack-mistral | 15:38 | |
| rakhmerov | rbrady-gone, thrash|g0ne, toure: hi guys, when are you coming to the PTG? | 15:40 |
| rakhmerov | just curious ) | 15:40 |
| apetrich | n ;;,l==o0][56,l;l;[phj;ylpghj;'; | 15:42 |
| apetrich | u8'7'[tr'[]fht]' | 15:42 |
| d0ugal | apetrich: Interesting :) | 15:42 |
| apetrich | sorry got hacked by the toddler | 15:43 |
| d0ugal | haha | 15:43 |
| d0ugal | He likes semicolons too much | 15:43 |
| apetrich | d0ugal, the baby was hacking my mobile early on also. It is all drooled over | 15:43 |
| apetrich | d0ugal, yeah.. you know how the new generations always try to mess up with the previous one. I tried to get him into python but he likes semicolons too much | 15:47 |
| *** dprince has joined #openstack-mistral | 15:47 | |
| d0ugal | lol | 15:47 |
| d0ugal | :( | 15:47 |
| *** fultonj has quit IRC | 15:58 | |
| *** jtomasek has quit IRC | 16:34 | |
| *** jaosorior has joined #openstack-mistral | 16:37 | |
| *** fultonj has joined #openstack-mistral | 16:39 | |
| *** jtomasek has joined #openstack-mistral | 16:42 | |
| *** bobh has quit IRC | 16:43 | |
| *** bobh has joined #openstack-mistral | 16:43 | |
| *** harlowja has joined #openstack-mistral | 16:54 | |
| *** jpich has quit IRC | 16:59 | |
| *** katkapilatova has quit IRC | 17:01 | |
| *** katkapilatova has joined #openstack-mistral | 17:02 | |
| *** jaosorior has quit IRC | 17:06 | |
| *** jpich has joined #openstack-mistral | 17:06 | |
| *** nkoffman has joined #openstack-mistral | 17:10 | |
| *** jkilpatr_ has joined #openstack-mistral | 17:12 | |
| *** dprince has quit IRC | 17:12 | |
| *** jkilpatr has quit IRC | 17:14 | |
| bobh | rakhmerov: ping | 17:23 |
| rakhmerov | bobh: hi, I'm here | 17:23 |
| bobh | rakhmerov: Hi - I just found an issue with unit tests - there is no __init__.py file in mistral/tests/unit/expressions/ so the Jinja and YAQL tests are not being run | 17:24 |
| rakhmerov | ooh, woow! | 17:25 |
| rakhmerov | it's a nasty thing... | 17:25 |
| bobh | when I add the __init__.py file the tests run but there are three errors | 17:25 |
| rakhmerov | ooh, that's not good | 17:25 |
| bobh | so I'll try to clean it up - just wanted to know if it was a known issue or not | 17:25 |
| rakhmerov | no, it wasn't indeed! | 17:25 |
| rakhmerov | ok, let me know when you send a patch | 17:25 |
| rakhmerov | I'll review it asap and ask others to do so | 17:26 |
| bobh | will do - thanks! | 17:26 |
| *** hrybacki is now known as hrybacki|ptg | 17:26 | |
| rakhmerov | bobh: and should you have any question on the code, I can try to help too | 17:27 |
| bobh | rakhmerov: thanks - I'll check the failures - I know there is one Jinja test failing for '{{ _ }}{{ _ }}' | 17:28 |
| bobh | rakhmerov: I thought that was supposed to work, but it's trying to evaluate '_ }}{{ _' | 17:29 |
| *** jtomasek has quit IRC | 17:29 | |
| rakhmerov | bobh: is this a problem that https://review.openstack.org/#/c/502198/ fixes? | 17:29 |
| rakhmerov | this patch was just sent recently | 17:29 |
| rakhmerov | it already got 2 +2 so it may be a good idea to merge this one first | 17:30 |
| bobh | yes I think that will fix it - I'll add the ? and see if the test passes | 17:30 |
| rakhmerov | ok | 17:31 |
| rakhmerov | but I guess in any case I can approve it, right? | 17:31 |
| rakhmerov | merging it will take a couple of hours at least | 17:31 |
| bobh | probably, but since the test isn't running maybe let me check it first? | 17:31 |
| rakhmerov | ok | 17:32 |
| rakhmerov | sure | 17:32 |
| rakhmerov | I just assumed that the author ran it locally :) | 17:32 |
| rakhmerov | but yes, I agree with you | 17:32 |
| *** jtomasek has joined #openstack-mistral | 17:33 | |
| bobh | rakhmerov: that fixed the unit test - go ahead and merge it | 17:33 |
| rakhmerov | ok | 17:33 |
| bobh | the other two looks like problems with the tests not including the 'created_at' attribute in the reference data - I'll add that and see if it fixes the problem | 17:34 |
| rakhmerov | ok | 17:36 |
| rakhmerov | I also checked them locally, so all the problems are with jinja | 17:36 |
| bobh | yes - I added created_at to the reference data structures but now it complains about it not having .isoformat() at the end of the mocked data structure | 17:37 |
| bobh | never mind - got it | 17:38 |
| bobh | I'll wait for the merge to finish them push my patchset | 17:39 |
| rakhmerov | ok, yes | 17:39 |
| rakhmerov | bobh: what you can actually do is make your patch based on https://review.openstack.org/499235 | 17:40 |
| rakhmerov | so that it we can review it in advance and let it go through "check" queue at least | 17:41 |
| rakhmerov | it would be a little faster | 17:41 |
| rakhmerov | d0ugal: does that CI problem affect only stable/pike branch? | 17:43 |
| rakhmerov | or master too? | 17:43 |
| *** bobh has quit IRC | 17:43 | |
| *** jaosorior has joined #openstack-mistral | 17:46 | |
| *** bobh has joined #openstack-mistral | 17:47 | |
| *** jtomasek has quit IRC | 17:49 | |
| *** jtomasek has joined #openstack-mistral | 17:50 | |
| *** jtomasek has quit IRC | 17:54 | |
| rakhmerov | bobh: our CI might be broken now (lets see the result of merging this patch) | 17:54 |
| bobh | rakhmerov: ok | 17:54 |
| rakhmerov | so I'd suggest you rebase your patch on top of it and send it | 17:54 |
| bobh | will do | 17:54 |
| rakhmerov | so that we could review it earlier | 17:55 |
| rakhmerov | ok, thanks | 17:55 |
| bobh | rakhmerov: in 502198, should the "ANY_JINJA_REGEXP" get the same change to add the '?' ? | 17:58 |
| *** nkoffman has quit IRC | 17:58 | |
| *** jpich has quit IRC | 17:58 | |
| *** jaosorior has quit IRC | 18:14 | |
| *** jkilpatr_ has quit IRC | 18:15 | |
| *** jkilpatr has joined #openstack-mistral | 18:16 | |
| *** jtomasek has joined #openstack-mistral | 18:22 | |
| *** shardy has quit IRC | 18:23 | |
| *** bobh has quit IRC | 18:28 | |
| *** yangyape_ has quit IRC | 18:35 | |
| *** yangyapeng has joined #openstack-mistral | 18:39 | |
| *** jtomasek_ has joined #openstack-mistral | 18:46 | |
| *** jtomasek has quit IRC | 18:47 | |
| *** thrash|g0ne is now known as thrash|ptg | 18:50 | |
| rakhmerov | let me see.. | 18:53 |
| *** yangyapeng has quit IRC | 18:56 | |
| rakhmerov | bobh: so, this constant is not used in jinja_expression.py at all | 18:57 |
| rakhmerov | it's used for parsing only (lang/base.py) | 18:57 |
| rakhmerov | trying to figure out how.. | 18:57 |
| openstackgerrit | Bob Haddleton proposed openstack/mistral master: Add mistral/tests/unit/expressions/__init__.py https://review.openstack.org/502538 | 19:03 |
| *** nkoffman has joined #openstack-mistral | 19:05 | |
| *** jaosorior has joined #openstack-mistral | 19:08 | |
| rakhmerov | bobh: so I think you're right almost I'm not sure on 100% | 19:11 |
| rakhmerov | although these two things are used differently | 19:11 |
| rakhmerov | and I'd like to understand what fails w/o this change | 19:11 |
| *** nkoffman has quit IRC | 19:19 | |
| *** nkoffman has joined #openstack-mistral | 19:25 | |
| *** bobh has joined #openstack-mistral | 19:27 | |
| *** bobh has quit IRC | 19:31 | |
| *** jtomasek_ has quit IRC | 19:40 | |
| *** jpich has joined #openstack-mistral | 19:41 | |
| *** jtomasek has joined #openstack-mistral | 19:51 | |
| *** jkilpatr has quit IRC | 19:56 | |
| *** jpich has quit IRC | 20:12 | |
| *** csatari_ has joined #openstack-mistral | 20:16 | |
| *** csatari has quit IRC | 20:24 | |
| *** portdirect has quit IRC | 20:24 | |
| *** csatari_ is now known as csatari | 20:24 | |
| *** bobh has joined #openstack-mistral | 20:34 | |
| *** portdirect has joined #openstack-mistral | 20:38 | |
| *** openstackgerrit has quit IRC | 20:48 | |
| *** jaosorior has quit IRC | 20:56 | |
| *** openstackgerrit has joined #openstack-mistral | 21:21 | |
| *** fultonj has quit IRC | 21:21 | |
| *** jtomasek has quit IRC | 21:23 | |
| *** jkilpatr has joined #openstack-mistral | 21:25 | |
| *** jtomasek has joined #openstack-mistral | 21:32 | |
| *** jtomasek has quit IRC | 21:39 | |
| *** jtomasek has joined #openstack-mistral | 22:05 | |
| *** catintheroof has quit IRC | 22:05 | |
| *** jtomasek has quit IRC | 22:05 | |
| *** bobh has quit IRC | 22:07 | |
| *** thrash|ptg is now known as thrash|g0ne | 22:07 | |
| *** jtomasek has joined #openstack-mistral | 22:14 | |
| *** harlowja has quit IRC | 22:14 | |
| *** Guest45420 has quit IRC | 22:15 | |
| *** bradjones has joined #openstack-mistral | 22:19 | |
| *** bradjones has quit IRC | 22:19 | |
| *** bradjones has joined #openstack-mistral | 22:19 | |
| *** nkoffman has quit IRC | 22:43 | |
| *** harlowja has joined #openstack-mistral | 22:50 | |
| *** harlowja has quit IRC | 23:06 | |
| *** catintheroof has joined #openstack-mistral | 23:08 | |
| *** jkilpatr has quit IRC | 23:16 | |
| *** harlowja has joined #openstack-mistral | 23:17 | |
| *** jkilpatr has joined #openstack-mistral | 23:29 | |
| *** toure is now known as toure|gone | 23:33 | |
| openstackgerrit | Bob Haddleton proposed openstack/mistral master: Add mistral/tests/unit/expressions/__init__.py https://review.openstack.org/502538 | 23:39 |
| openstackgerrit | Merged openstack/mistral-lib master: Updated from global requirements https://review.openstack.org/502669 | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!