*** catintheroof has quit IRC | 00:25 | |
*** zhurong has joined #openstack-mistral | 00:45 | |
*** thrash is now known as thrash|g0ne | 01:26 | |
*** bobh has quit IRC | 01:32 | |
*** catintheroof has joined #openstack-mistral | 02:30 | |
*** catintheroof has quit IRC | 02:57 | |
*** apetrich has quit IRC | 03:12 | |
*** apetrich has joined #openstack-mistral | 03:17 | |
*** gkadam has joined #openstack-mistral | 03:33 | |
*** livelace has joined #openstack-mistral | 04:26 | |
*** int32bit has joined #openstack-mistral | 06:13 | |
*** shardy has joined #openstack-mistral | 06:27 | |
*** jistr is now known as jistr|trng | 06:53 | |
*** oidgar_ has joined #openstack-mistral | 06:57 | |
openstackgerrit | int32bit proposed openstack/mistral master: Add project_id to API resources https://review.openstack.org/496121 | 06:59 |
---|---|---|
*** int32bit_ has joined #openstack-mistral | 07:00 | |
*** int32bit has quit IRC | 07:03 | |
*** jtomasek has joined #openstack-mistral | 07:18 | |
*** livelace2 has joined #openstack-mistral | 07:21 | |
*** jpich has joined #openstack-mistral | 07:34 | |
openstackgerrit | junbo.li proposed openstack/mistral master: Remove build files before run tox doc builder https://review.openstack.org/496147 | 08:15 |
*** shardy has quit IRC | 08:25 | |
openstackgerrit | int32bit proposed openstack/mistral master: Add get cron-trigger by id support https://review.openstack.org/496157 | 08:49 |
*** int32bit has joined #openstack-mistral | 08:52 | |
*** int32bit_ has quit IRC | 08:52 | |
*** apetrich has quit IRC | 09:13 | |
*** apetrich has joined #openstack-mistral | 09:13 | |
*** shardy has joined #openstack-mistral | 09:18 | |
*** apetrich has quit IRC | 09:23 | |
*** int32bit has quit IRC | 09:28 | |
*** apetrich has joined #openstack-mistral | 09:35 | |
*** zhurong has quit IRC | 10:17 | |
*** apetrich has quit IRC | 10:23 | |
*** shardy has quit IRC | 10:42 | |
*** jkilpatr has quit IRC | 10:48 | |
*** ruhe has quit IRC | 11:00 | |
*** thrash|g0ne has quit IRC | 11:00 | |
*** Dinesh_Bhor has quit IRC | 11:01 | |
*** ruhe has joined #openstack-mistral | 11:01 | |
*** Dinesh_Bhor has joined #openstack-mistral | 11:05 | |
*** thrash has joined #openstack-mistral | 11:06 | |
*** thrash has quit IRC | 11:06 | |
*** thrash has joined #openstack-mistral | 11:06 | |
*** jkilpatr has joined #openstack-mistral | 11:07 | |
*** oidgar_ is now known as oidgar | 11:21 | |
*** apetrich has joined #openstack-mistral | 11:52 | |
*** fultonj has joined #openstack-mistral | 12:13 | |
*** dprince has joined #openstack-mistral | 12:25 | |
openstackgerrit | Mateusz Kowalski proposed openstack/mistral-dashboard master: Expand parameter list for workflow execution https://review.openstack.org/496220 | 12:28 |
openstackgerrit | Mateusz Kowalski proposed openstack/mistral-dashboard master: Expand parameter list for workflow execution https://review.openstack.org/496220 | 12:29 |
openstackgerrit | Mateusz Kowalski proposed openstack/mistral-dashboard master: Expand parameter list for workflow execution https://review.openstack.org/496220 | 12:30 |
openstackgerrit | Mateusz Kowalski proposed openstack/mistral-dashboard master: Expand parameter list for workflow execution https://review.openstack.org/496220 | 12:30 |
*** gkadam has quit IRC | 12:36 | |
*** livelace has quit IRC | 12:39 | |
*** zhurong has joined #openstack-mistral | 12:56 | |
thrash | livelace2: I'm still trying to figure out just what is happening. Any progress on your side? | 12:58 |
*** sharatss has joined #openstack-mistral | 13:24 | |
*** bobh has joined #openstack-mistral | 13:35 | |
*** apetrich has quit IRC | 13:48 | |
*** shardy has joined #openstack-mistral | 13:49 | |
livelace2 | thrash, Hello. I have tried a lot of things, but as a temporary solution I chose a intermediate task https://paste.fedoraproject.org/paste/yPghp77K5W2Kwv9amghmvA | 14:05 |
livelace2 | "fixate" takes all "wrong" things and calls stop correctly | 14:05 |
thrash | livelace2: interesting... | 14:06 |
thrash | d0ugal: you could probably explain that better than I | 14:07 |
d0ugal | I can try | 14:09 |
* d0ugal reads | 14:09 | |
*** sharatss has quit IRC | 14:09 | |
*** zhurong has quit IRC | 14:19 | |
d0ugal | thrash: no, I'm not sure. I've never had a reason to use "join" actually | 14:30 |
d0ugal | I should try it out more sometime. | 14:30 |
thrash | :) | 14:31 |
thrash | d0ugal: I think I meant more about the usage of on-error vs on-complete | 14:31 |
thrash | etc | 14:31 |
d0ugal | oh | 14:31 |
d0ugal | I guess I'm not sure I understand the question then | 14:32 |
*** livelace2 has quit IRC | 14:34 | |
thrash | d0ugal: livelace2 (who is now gone) was having issues with unexpected behavior from his workflow, and I think it stemmed from usage of on-complete vs on-error. | 14:48 |
thrash | d0ugal: and then how the outcome (error status?) of the a workflow would affect a join call... I'm still trying to figure it out. | 14:49 |
thrash | d0ugal: if you're curious, this is the workflow I was testing with... http://paste.openstack.org/show/618946/ | 14:50 |
thrash | d0ugal: you should run it. It does not do what you would expect. | 14:51 |
d0ugal | thrash: okay, you have peaked my interest. | 14:52 |
thrash | d0ugal: especially since none of the workflows should actually error. | 14:52 |
thrash | d0ugal: and this was livelace's solution: https://paste.fedoraproject.org/paste/yPghp77K5W2Kwv9amghmvA | 14:53 |
d0ugal | thrash: interesting, that does seem like a bug | 14:58 |
d0ugal | no idea what is going on :) | 14:58 |
thrash | d0ugal: same! | 14:58 |
d0ugal | I think it must be related to the join mechanic tho' | 14:58 |
thrash | you got 'failed because of task1' right? | 14:58 |
d0ugal | thrash: yup | 14:58 |
thrash | it's consistent. :D | 14:59 |
d0ugal | yay? | 14:59 |
d0ugal | thrash: is it failing because task1 never joins? | 15:01 |
d0ugal | thrash: but it does lead to it, with on-error | 15:01 |
thrash | d0ugal: that shouldn't be an error... | 15:01 |
thrash | d0ugal: if the task is completed, it should just be considered "joined" | 15:01 |
d0ugal | thrash: adding "stop" to on-success of task1 also fixes it | 15:02 |
thrash | d0ugal: oooh... that kinda makes sense... | 15:03 |
d0ugal | thrash: or removing it from on-error also fixes it | 15:03 |
thrash | d0ugal: hmm... It seems though that it would probably break the logic livelace was aiming for... | 15:04 |
thrash | If something errors, then stop | 15:04 |
thrash | Although... | 15:04 |
thrash | I don't know. :| | 15:04 |
d0ugal | lol | 15:07 |
d0ugal | so, it seems that joining works by looking at any tasks that link to the join | 15:07 |
d0ugal | and because it links in an on-error it is considered a potential join | 15:07 |
d0ugal | the other fix would be to change it to "join: 2" | 15:07 |
d0ugal | and thus it would wait for at least two joins | 15:08 |
d0ugal | or maybe "join: 1" if you wanted any error to stop it | 15:08 |
d0ugal | If nothing else, the error could be much better. | 15:08 |
thrash | so, would using on-complete function better? | 15:10 |
thrash | or put another way, do what is expected? | 15:10 |
d0ugal | yeah, on-complete would ensure it joins | 15:10 |
thrash | I just wonder why the workaround (intermediate task) was necessary? | 15:11 |
d0ugal | thrash: the intermediate task didn't help, AFAICT | 15:11 |
d0ugal | it is the change from on-error to on-complete | 15:12 |
thrash | ahh | 15:12 |
d0ugal | but I have not tested this | 15:12 |
thrash | yeah... I'll give it a shot in a few. | 15:12 |
*** oidgar has quit IRC | 15:17 | |
*** thrash is now known as thrash|biab | 15:29 | |
*** apetrich has joined #openstack-mistral | 15:38 | |
*** thrash|biab is now known as thrash | 15:41 | |
*** dixiaoli has joined #openstack-mistral | 15:50 | |
*** dixiaoli has quit IRC | 15:54 | |
apetrich | rbrady, cheers | 15:55 |
*** oidgar has joined #openstack-mistral | 16:01 | |
*** shardy has quit IRC | 16:06 | |
*** catintheroof has joined #openstack-mistral | 16:10 | |
*** oidgar has quit IRC | 16:23 | |
*** apetrich has quit IRC | 17:11 | |
*** apetrich has joined #openstack-mistral | 17:14 | |
openstackgerrit | Bob Haddleton proposed openstack/mistral master: Process input defaults and output transforms for nested AdHoc Actions https://review.openstack.org/494749 | 17:24 |
*** jpich has quit IRC | 17:28 | |
*** dixiaoli has joined #openstack-mistral | 18:21 | |
*** dixiaoli has quit IRC | 18:25 | |
*** bobh has quit IRC | 18:31 | |
*** jkilpatr has quit IRC | 19:55 | |
*** portdirect is now known as tintin | 20:03 | |
*** tintin is now known as portdirect | 20:04 | |
*** dprince has quit IRC | 20:14 | |
*** jkilpatr has joined #openstack-mistral | 20:15 | |
*** rbrady has quit IRC | 20:32 | |
*** catintheroof has quit IRC | 22:01 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!