| *** bobh has joined #openstack-mistral | 00:04 | |
| *** jkilpatr has quit IRC | 00:47 | |
| *** gongysh has joined #openstack-mistral | 02:33 | |
| *** openstackgerrit has joined #openstack-mistral | 03:03 | |
| openstackgerrit | melissaml proposed openstack/python-mistralclient master: Use assertTrue/False(A) instead of assertEqual(True/False, A) https://review.openstack.org/480335 | 03:03 |
|---|---|---|
| *** gkadam has joined #openstack-mistral | 03:24 | |
| *** gkadam has quit IRC | 03:26 | |
| *** gkadam has joined #openstack-mistral | 03:27 | |
| *** gongysh has quit IRC | 03:54 | |
| *** gongysh has joined #openstack-mistral | 04:26 | |
| openstackgerrit | melissaml proposed openstack/python-mistralclient master: Use assertTrue/False(A) instead of assertEqual(True/False, A) https://review.openstack.org/480335 | 04:57 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral master: Switch from oslosphinx to openstackdocstheme https://review.openstack.org/479791 | 05:10 |
| openstackgerrit | Sharat Sharma proposed openstack/python-mistralclient master: Switch from oslosphinx to openstackdocstheme https://review.openstack.org/479804 | 05:10 |
| *** livelace has joined #openstack-mistral | 05:26 | |
| openstackgerrit | Kien Nguyen proposed openstack/mistral master: Update .gitignore https://review.openstack.org/477419 | 06:22 |
| *** sharatss has joined #openstack-mistral | 06:32 | |
| openstackgerrit | Sharat Sharma proposed openstack/python-mistralclient master: Enable warning-is-error in doc build https://review.openstack.org/480368 | 06:41 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral-specs master: Switch from oslosphinx to openstackdocstheme https://review.openstack.org/480372 | 07:00 |
| *** jpich has joined #openstack-mistral | 07:13 | |
| *** shardy has joined #openstack-mistral | 07:16 | |
| rakhmerov | xavierhardy: hi, can you please explain your question in https://review.openstack.org/#/c/476514 more detailed? | 07:31 |
| rakhmerov | I don't quite get it | 07:31 |
| xavierhardy | sync_db is broken because of my changes, how do I fix it? | 07:33 |
| rakhmerov | you wrote "the actions (unlike workflows) are updated and not wiped out". How is it related to app context? | 07:33 |
| xavierhardy | it does | 07:33 |
| xavierhardy | because it tries to edit actions | 07:33 |
| xavierhardy | it does not happen for workflows | 07:34 |
| xavierhardy | in sync_db | 07:34 |
| xavierhardy | because workflows are erased and then created again | 07:34 |
| xavierhardy | so it never meets the permission code in the case of workflows | 07:34 |
| xavierhardy | (so no need for an app context) | 07:38 |
| xavierhardy | (in the case of workflows) | 07:38 |
| rakhmerov | aah, just a sec.. | 07:38 |
| rakhmerov | I think I understood | 07:38 |
| xavierhardy | The question is | 07:38 |
| xavierhardy | do I fix the discrepancy in the way sync_db behaves with workflows and actions ? | 07:38 |
| xavierhardy | or | 07:38 |
| xavierhardy | do I monkey patch/add a fake application context to make it work ? | 07:39 |
| rakhmerov | Yes, I think so | 07:39 |
| rakhmerov | yes | 07:39 |
| rakhmerov | I see no reason why we should have this inconsistency | 07:39 |
| rakhmerov | between how workflows and actions are handled | 07:39 |
| xavierhardy | which would mean: workflows are updated like actions (after the fix) and an application context is added to satisfy the permission code | 07:40 |
| rakhmerov | yes | 07:40 |
| rakhmerov | if my understanding of this all is correct then it looks ok to me | 07:40 |
| rakhmerov | can you propose the fix? | 07:40 |
| rakhmerov | and it'd be cool if you could finish https://review.openstack.org/#/c/477816/ | 07:41 |
| xavierhardy | when I get the time, yes definitely | 07:44 |
| xavierhardy | I don't know if I'll be able to do it this week. | 07:44 |
| *** d0ugal has joined #openstack-mistral | 07:46 | |
| *** d0ugal has quit IRC | 07:46 | |
| *** d0ugal has joined #openstack-mistral | 07:46 | |
| rakhmerov | xavierhardy: no problem | 07:49 |
| rakhmerov | when you have a chance | 07:49 |
| *** shardy is now known as shtab | 08:27 | |
| *** shtab is now known as shardy | 08:27 | |
| *** jtomasek has joined #openstack-mistral | 08:29 | |
| d0ugal | rakhmerov: Hey | 08:54 |
| rakhmerov | hi | 08:54 |
| d0ugal | rakhmerov: I mentioned this before, about getting sub-workflow executions. I would like to add something to the API to make it possible | 08:55 |
| rakhmerov | ok | 08:55 |
| rakhmerov | what exactly? | 08:55 |
| d0ugal | so you could do something like "mistral execution-list EXECUTION_ID" and then mistral action-execution-list EXECUTION_ID --include-sub-workflows" | 08:55 |
| d0ugal | and the same for task-list | 08:56 |
| rakhmerov | btw, just filed today: https://bugs.launchpad.net/mistral/+bug/1702421 | 08:56 |
| openstack | Launchpad bug 1702421 in Mistral "It's impossible to set "equal to None" filter when calling REST API" [High,New] | 08:56 |
| d0ugal | so my quesiton is - what do you think about that idea? and what would you call it or how would you add it? | 08:56 |
| rakhmerov | a little bit related | 08:56 |
| d0ugal | hah | 08:56 |
| d0ugal | Maybe I can look at fixing that too | 08:56 |
| rakhmerov | ok | 08:57 |
| openstackgerrit | Merged openstack/mistral master: Add cron name/id to workflow execution description https://review.openstack.org/458384 | 08:57 |
| rakhmerov | so, 1) mistral execution-list EXECUTION_ID - seems fine because it doesn't conflict with the existing protocol, afaik there aren't positional arguments for this command | 08:58 |
| rakhmerov | 2) action-execution-list EXECUTION_ID --include-sub-workflows - conflicts with the existing positional argument which is "task_execution_id" | 08:58 |
| d0ugal | ah | 08:59 |
| rakhmerov | yeah | 08:59 |
| d0ugal | good point. --include-sub-workflows is also horrible flag name, just an example :) | 08:59 |
| rakhmerov | for 3) task-list - seems fine in conjunction with --include-sub-workflows | 08:59 |
| rakhmerov | yeah, I understand | 09:00 |
| rakhmerov | so maybe we can just add a named argument for all these commands? | 09:00 |
| d0ugal | for example? | 09:00 |
| rakhmerov | mistral execution-list top-level-workflow-execution-id=1111-2222-3333 | 09:01 |
| rakhmerov | (name is horrible too) | 09:01 |
| d0ugal | right | 09:01 |
| rakhmerov | something like this | 09:01 |
| rakhmerov | because positional argument in our case historically means "direct parent" | 09:02 |
| rakhmerov | I mean it was just designed so historically | 09:02 |
| d0ugal | yup | 09:02 |
| rakhmerov | ooh, I didn't put "--" | 09:03 |
| rakhmerov | mistral execution-list --top-level-workflow-execution-id=1111-2222-3333 | 09:03 |
| rakhmerov | but you got it.. | 09:03 |
| d0ugal | yeah, I did | 09:03 |
| rakhmerov | or maybe --root-execution-id | 09:03 |
| rakhmerov | for now | 09:03 |
| d0ugal | I think having these options would solve many of my issues with debugging | 09:03 |
| rakhmerov | until we redesign it all in v3 | 09:04 |
| d0ugal | :) | 09:04 |
| rakhmerov | I understand, yes, it would be useful for lots of people | 09:04 |
| rakhmerov | I mean we could omit "workflow" in naming for now because we don't use it in "mistral execution-list", for example | 09:04 |
| rakhmerov | again, for historical reasons | 09:05 |
| d0ugal | Right | 09:05 |
| rakhmerov | seems ok to you? | 09:06 |
| d0ugal | rakhmerov: yup, I think so - I'll see if I can try and get something working | 09:06 |
| d0ugal | rakhmerov: --root-execution may even be enough - or do we normally explicitly say ID? | 09:06 |
| rakhmerov | yeah, I think --root-execution is ok | 09:10 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral-specs master: Switch from oslosphinx to openstackdocstheme https://review.openstack.org/480372 | 09:13 |
| openstackgerrit | Sharat Sharma proposed openstack/python-mistralclient master: Enable warning-is-error in doc build https://review.openstack.org/480368 | 09:24 |
| *** jtomasek has quit IRC | 09:26 | |
| rakhmerov | d0ugal: as far as https://bugs.launchpad.net/mistral/+bug/1702421, please hold on with it for a little while | 09:28 |
| openstack | Launchpad bug 1702421 in Mistral "It's impossible to set "equal to None" filter when calling REST API" [High,New] | 09:28 |
| d0ugal | rakhmerov: sure | 09:28 |
| rakhmerov | we discussed it internally with my colleagues and what I proposed in the description doesn't look the best option anymore :) | 09:29 |
| rakhmerov | we'll leave our comments and let you know | 09:29 |
| d0ugal | haha, okay :) | 09:29 |
| d0ugal | thanks! | 09:29 |
| rakhmerov | ok | 09:29 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral-specs master: Switch from oslosphinx to openstackdocstheme https://review.openstack.org/480372 | 09:54 |
| openstackgerrit | Merged openstack/python-mistralclient master: Enable some off-by-default checks https://review.openstack.org/477837 | 10:02 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral-specs master: Switch from oslosphinx to openstackdocstheme https://review.openstack.org/480372 | 10:08 |
| openstackgerrit | Merged openstack/mistral master: Switch from oslosphinx to openstackdocstheme https://review.openstack.org/479791 | 10:10 |
| openstackgerrit | Sharat Sharma proposed openstack/python-mistralclient master: Enable warning-is-error in doc build https://review.openstack.org/480368 | 10:10 |
| sharatss | rakhmerov, d0ugal hi | 10:22 |
| rakhmerov | hi Sharat | 10:22 |
| sharatss | for the doc-migration we may have to restructure our doc directory | 10:23 |
| sharatss | rakhmerov, any suggestions on restructuring? | 10:24 |
| rakhmerov | sharatss: it's being taken care of | 10:24 |
| rakhmerov | please don't proceed with it | 10:24 |
| sharatss | rakhmerov, ok | 10:25 |
| rakhmerov | it should be restructured soon | 10:25 |
| rakhmerov | days | 10:25 |
| openstackgerrit | Merged openstack/python-mistralclient master: Switch from oslosphinx to openstackdocstheme https://review.openstack.org/479804 | 10:27 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral master: Turn on warning-is-error for sphinx_build https://review.openstack.org/480504 | 10:27 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral-specs master: Switch from oslosphinx to openstackdocstheme https://review.openstack.org/480372 | 10:30 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral-specs master: Switch from oslosphinx to openstackdocstheme https://review.openstack.org/480372 | 10:39 |
| *** shardy is now known as shardy_lunch | 11:08 | |
| *** gongysh has quit IRC | 11:09 | |
| *** jkilpatr has joined #openstack-mistral | 11:20 | |
| *** Guest7130 is now known as rook | 11:37 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral master: Turn on warning-is-error for sphinx_build https://review.openstack.org/480504 | 11:38 |
| *** vishwanathj has joined #openstack-mistral | 12:03 | |
| *** vishwanathj has quit IRC | 12:04 | |
| *** gongysh has joined #openstack-mistral | 12:11 | |
| *** toure|gone is now known as toure | 12:21 | |
| *** thrash|g0ne is now known as thrash | 12:23 | |
| *** dprince has joined #openstack-mistral | 12:26 | |
| *** gongysh has quit IRC | 12:38 | |
| *** shardy_lunch is now known as shardy | 12:41 | |
| rakhmerov | d0ugal: I left a comment in https://bugs.launchpad.net/mistral/+bug/1702421 | 12:52 |
| openstack | Launchpad bug 1702421 in Mistral "It's impossible to set "equal to None" filter when calling REST API" [High,New] | 12:52 |
| rakhmerov | please read it when you have a chance | 12:52 |
| rakhmerov | maybe you'll have some better ideas | 12:52 |
| *** jkilpatr has quit IRC | 13:11 | |
| *** jkilpatr has joined #openstack-mistral | 13:11 | |
| *** jkilpatr has quit IRC | 13:17 | |
| *** catintheroof has joined #openstack-mistral | 13:18 | |
| d0ugal | rakhmerov: thanks. | 13:27 |
| d0ugal | I'll take a look shortly | 13:27 |
| *** brunograz has joined #openstack-mistral | 13:28 | |
| *** jkilpatr has joined #openstack-mistral | 13:30 | |
| *** gkadam has quit IRC | 13:33 | |
| *** sharatss has quit IRC | 13:37 | |
| *** zhurong has joined #openstack-mistral | 13:44 | |
| *** Guest14421 has joined #openstack-mistral | 13:46 | |
| *** bobh has quit IRC | 13:54 | |
| *** zhurong has quit IRC | 14:09 | |
| openstackgerrit | Merged openstack/mistral master: Remove .testrepository directory from testenv https://review.openstack.org/461683 | 14:31 |
| *** chlong_ has joined #openstack-mistral | 14:31 | |
| *** bobh has joined #openstack-mistral | 14:32 | |
| openstackgerrit | Merged openstack/mistral master: Use recommended function to setup auth middleware in devstack https://review.openstack.org/473796 | 15:00 |
| *** chlong has joined #openstack-mistral | 15:23 | |
| *** chlong has quit IRC | 15:26 | |
| openstackgerrit | Gergely Csatari proposed openstack/mistral master: WIP: Applying Pike document structure https://review.openstack.org/480643 | 15:32 |
| *** chlong_ has quit IRC | 15:58 | |
| *** Guest14421 has quit IRC | 16:06 | |
| *** chlong_ has joined #openstack-mistral | 16:15 | |
| *** livelace has quit IRC | 16:46 | |
| *** jpich has quit IRC | 17:12 | |
| *** chlong_ has quit IRC | 17:21 | |
| *** chlong_ has joined #openstack-mistral | 17:33 | |
| *** gkadam has joined #openstack-mistral | 17:48 | |
| *** gkadam has quit IRC | 18:19 | |
| openstackgerrit | melissaml proposed openstack/python-mistralclient master: Use assertIsNone instead of assertEqual(None, ***) https://review.openstack.org/480705 | 19:05 |
| *** chlong_ has quit IRC | 19:14 | |
| *** chlong_ has joined #openstack-mistral | 19:30 | |
| *** chlong_ has quit IRC | 19:55 | |
| *** shardy has quit IRC | 20:35 | |
| *** chlong_ has joined #openstack-mistral | 20:44 | |
| *** rbrady is now known as rbrady-afk | 21:03 | |
| *** dprince has quit IRC | 21:06 | |
| *** bobh has quit IRC | 21:11 | |
| *** thrash is now known as thrash|g0ne | 21:16 | |
| *** chlong_ has quit IRC | 21:18 | |
| *** bobh has joined #openstack-mistral | 21:45 | |
| *** bobh has quit IRC | 22:02 | |
| *** catintheroof has quit IRC | 23:47 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!