| *** bobh has joined #openstack-mistral | 00:22 | |
| *** bobh has quit IRC | 00:31 | |
| *** bobh has joined #openstack-mistral | 00:50 | |
| *** bobh has quit IRC | 01:04 | |
| *** bobh has joined #openstack-mistral | 01:37 | |
| *** bobh has quit IRC | 02:04 | |
| *** tung_doan has joined #openstack-mistral | 02:05 | |
| *** gkadam has joined #openstack-mistral | 03:02 | |
| *** tung_doan has quit IRC | 03:17 | |
| *** gongysh has joined #openstack-mistral | 03:27 | |
| *** gkadam has quit IRC | 04:01 | |
| *** gkadam has joined #openstack-mistral | 04:03 | |
| *** gkadam has quit IRC | 04:06 | |
| *** gkadam has joined #openstack-mistral | 04:06 | |
| *** gkadam has quit IRC | 04:09 | |
| *** gkadam has joined #openstack-mistral | 04:10 | |
| *** gkadam_ has joined #openstack-mistral | 04:23 | |
| *** gkadam has quit IRC | 04:26 | |
| *** tung_doan has joined #openstack-mistral | 04:32 | |
| *** apetrich has joined #openstack-mistral | 05:06 | |
| *** jtomasek has joined #openstack-mistral | 05:48 | |
| *** jtomasek has quit IRC | 06:12 | |
| *** sharatss has joined #openstack-mistral | 06:17 | |
| *** openstackgerrit has joined #openstack-mistral | 06:17 | |
| openstackgerrit | Tovin Seven proposed openstack/python-mistralclient master: Make --profile load from environment variables https://review.openstack.org/475250 | 06:17 |
|---|---|---|
| openstackgerrit | Tovin Seven proposed openstack/python-mistralclient master: Make --profile load from environment variables https://review.openstack.org/475250 | 06:37 |
| *** gkadam_ is now known as gkadam | 06:44 | |
| *** jtomasek has joined #openstack-mistral | 06:49 | |
| *** shardy has joined #openstack-mistral | 07:12 | |
| *** jpich has joined #openstack-mistral | 07:15 | |
| *** jaosorior has joined #openstack-mistral | 07:26 | |
| d0ugal | rakhmerov: thanks :) | 07:30 |
| rakhmerov | :) | 07:30 |
| *** Dinesh_Bhor has joined #openstack-mistral | 07:31 | |
| rakhmerov | d0ugal: once you have time: https://review.openstack.org/#/c/474195/ | 07:31 |
| d0ugal | Sure | 07:32 |
| rakhmerov | not sure if you are going to agree with the solution but I can elaborate on it | 07:32 |
| rakhmerov | that's seemingly the best what I could do for now | 07:32 |
| d0ugal | :) | 07:36 |
| d0ugal | I'll look in a min | 07:36 |
| d0ugal | rakhmerov: I don't really understand why 32 bytes more helps. | 07:45 |
| rakhmerov | well, some number helps. I just took the closes round number | 07:45 |
| d0ugal | right | 07:46 |
| rakhmerov | closest | 07:46 |
| rakhmerov | because cut_dict is not precise enough | 07:46 |
| rakhmerov | it has a mistake to approximately one string representation of a number | 07:46 |
| d0ugal | ah | 07:46 |
| rakhmerov | yeah | 07:47 |
| d0ugal | I guess I need to read the cut_dict code to understand fully | 07:47 |
| rakhmerov | it's just for how this algo works internally, it's pretty tricky | 07:47 |
| rakhmerov | yeah, good luck ) | 07:47 |
| d0ugal | lol | 07:47 |
| *** openstackgerrit has quit IRC | 07:48 | |
| rakhmerov | my point though is: yes, we can probably fix cut_dict() and we may do it later (although its original intention was to be used for logging where precision is not so critical) | 07:48 |
| d0ugal | makes sense | 07:48 |
| rakhmerov | but that's the simples and practical fix that will help us with "state_info" | 07:48 |
| d0ugal | yeah | 07:48 |
| rakhmerov | yep | 07:49 |
| d0ugal | so cut_dict is usually longer than the length you ask for | 07:49 |
| d0ugal | it is a bit messy, but I guess this will do for now :) | 07:50 |
| rakhmerov | yes, I think I'll get to this algo later and fix it more properly | 07:51 |
| rakhmerov | thanks | 07:51 |
| d0ugal | np | 07:51 |
| d0ugal | Maybe worth opening a bug? | 07:51 |
| *** amoralej|off is now known as amoralej | 07:51 | |
| rakhmerov | yes, just a minute | 07:55 |
| rakhmerov | you're right | 07:55 |
| apetrich | rakhmerov, d0ugal if you folks have a moment I've moved more stuff into mistral lib here https://review.openstack.org/#/c/474895/ I wanted to check with you if you think it is the correct approach | 07:55 |
| rakhmerov | d0ugal: https://bugs.launchpad.net/mistral/+bug/1698754 | 07:58 |
| openstack | Launchpad bug 1698754 in Mistral "Fix utils.cut_dict() so that it trims more accurately" [Medium,Confirmed] | 07:58 |
| rakhmerov | apetrich: yeah, I was gonna look at it shortly | 07:58 |
| apetrich | rakhmerov, cheers | 07:59 |
| gongysh | hi | 08:02 |
| gongysh | | State info | Failed to initialize action tacker.nfvo.workflows.vim_monitor.vim_ping_action.PingVimAction. | | 08:02 |
| gongysh | | | Action init params = ['count', 'targetip', 'vim_id', 'interval', 'timeout']. Actual init params = | | 08:02 |
| gongysh | | | [u'count', u'targetip', u'vim_id', u'interval', u'timeout']. More info: | 08:03 |
| gongysh | what is the problem? | 08:03 |
| gongysh | could anyone help? | 08:03 |
| d0ugal | apetrich: yup, I'll take a look too | 08:08 |
| gongysh | d0ugal, could you help me? | 08:09 |
| d0ugal | gongysh: I don't know what that means, I've not seen it before. The only difference seems to be that one is unicode strings and the other isnt' | 08:11 |
| gongysh | yea | 08:11 |
| *** dtantsur|afk is now known as dtantsur | 08:16 | |
| d0ugal | gongysh: do you have an exception tracebacks in the logs? | 08:17 |
| gongysh | d0ugal, the log is the same: root@ubuntu64:~# journalctl -n 200 -u devstack@mistral-executor.service | grep mistral.executors.default_executor | 08:20 |
| gongysh | Jun 19 16:14:14 ubuntu64 mistral-server[106222]: 2017-06-19 16:14:14.991 WARNING mistral.executors.default_executor [-] Failed to initialize action tacker.nfvo.workflows.vim_monitor.vim_ping_action.PingVimAction. Action init params = ['count', 'targetip', 'vim_id', 'interval', 'timeout']. Actual init params = [u'count', u'targetip', u'vim_id', u'interval', u'timeout']. More info: : AssertionError | 08:20 |
| rakhmerov | apetrich: just reviewed, see my comments | 08:21 |
| rakhmerov | gongysh: please use paste.openstack.org, it'll be more convenient | 08:22 |
| gongysh | rakhmerov, I think it is short, so paste it in place. | 08:22 |
| gongysh | I will use paste later. | 08:22 |
| gongysh | thanks | 08:23 |
| rakhmerov | ok, np | 08:23 |
| rakhmerov | yeah, maybe unicode is the reason, it's hard to tell | 08:23 |
| rakhmerov | need to experiment | 08:23 |
| rakhmerov | is there anything in the engine log? | 08:23 |
| apetrich | rakhmerov, thanks | 08:24 |
| rakhmerov | but I believe it's not unicode, I assume there's an assertion inside this action that checks some preconditions | 08:25 |
| rakhmerov | otherwise, why would we get AssertionError ? | 08:25 |
| rakhmerov | look at the action implementation and see what's happening there, maybe some of the parameter values that you pass are not compliant with preconditions | 08:25 |
| rakhmerov | gongysh: ^ | 08:26 |
| gongysh | hi | 08:26 |
| gongysh | rakhmerov, I am trying to reproduce it, and then I can give you the url of review, thanks | 08:27 |
| rakhmerov | ok, np | 08:27 |
| rakhmerov | share with us what was it | 08:27 |
| rakhmerov | d0ugal: how is that requirement problem going? | 08:28 |
| rakhmerov | has it been solved? | 08:28 |
| d0ugal | rakhmerov: no, not yet. | 08:29 |
| rakhmerov | I see | 08:29 |
| d0ugal | rakhmerov: rbrady-afk was looking into breaking out link on the keystone utils. I am not sure if he made any progress, I'll ask him later | 08:29 |
| d0ugal | I've been tied up with other tasks. | 08:29 |
| rakhmerov | ok | 08:29 |
| rakhmerov | I hate this keystone stuff :) | 08:30 |
| rakhmerov | can't wait to fix it all out | 08:30 |
| d0ugal | haha, yeah | 08:30 |
| rakhmerov | :) | 08:30 |
| d0ugal | I never really understand it | 08:30 |
| rakhmerov | yeah, well, it was mostly OK a couple of years ago | 08:30 |
| rakhmerov | but then tens of people fixed something in it, something has changed in Keystone itself and eventually it turned to a mess | 08:31 |
| d0ugal | yup | 08:31 |
| d0ugal | just keeping up with the OpenStack projects you use is a big task. | 08:31 |
| rakhmerov | yep | 08:35 |
| gongysh | d0ugal, rakhmerov https://review.openstack.org/#/c/475207/5 | 08:40 |
| gongysh | the paste url is at http://paste.openstack.org/show/613075/ | 08:40 |
| gongysh | I have frustrated by it half day. | 08:40 |
| rakhmerov | gongysh: what's the value of "count" for this action? | 08:49 |
| rakhmerov | can you set a breakpoint inside this action and see what happens there? | 08:49 |
| rakhmerov | or log statements, doesn't matter.. | 08:49 |
| rakhmerov | is the problem happening inside action or in Mistral somewhere? | 08:50 |
| rakhmerov | if in Mistral can you point to the line? | 08:51 |
| rakhmerov | try to debug it please | 08:51 |
| rakhmerov | one more question: what version of Mistral are you on? | 08:51 |
| gongysh | you can see via workflow definition. | 08:53 |
| gongysh | just a value, 1 | 08:54 |
| gongysh | I am using the master branch, using devstack. | 08:54 |
| gongysh | rakhmerov | 08:54 |
| rakhmerov | as far as I can see, it's "1", a string, not a number | 08:55 |
| rakhmerov | can this be a problem? | 08:55 |
| rakhmerov | ok, probably not.. | 08:55 |
| rakhmerov | an assumption: you call start_rpc_listeners() from within an initializer | 08:57 |
| rakhmerov | if it fails the action won't be created | 08:57 |
| rakhmerov | may be it fails because some of the actual parameters you pass are not valid | 08:57 |
| rakhmerov | I don't know, you need to debug it | 08:58 |
| gongysh | rakhmerov, do we have a way for action to listen to an event from outside? | 09:22 |
| rakhmerov | built-in? no, it's purely up to a concrete action | 09:22 |
| gongysh | rakhmerov, after removing start_rpc_listeners, it works. | 09:23 |
| rakhmerov | if you need, you can create a class hierarchy for actions that require it | 09:23 |
| rakhmerov | yep, ok | 09:23 |
| gongysh | I am starting a amqp server so that outsider can notify action something | 09:24 |
| rakhmerov | gongysh: btw, be careful about creating RPC endpoints out of action instances. Once the action has completed you need to make sure to reliably clean things up | 09:24 |
| rakhmerov | remove this endpoint etc. | 09:24 |
| rakhmerov | othwerise you'll be creating them endlessly | 09:24 |
| rakhmerov | I think it can be an implicit memory leak | 09:24 |
| *** openstackgerrit has joined #openstack-mistral | 09:25 | |
| openstackgerrit | Merged openstack/mistral master: Make sure that the field "state_info" trimmed as expected https://review.openstack.org/474195 | 09:25 |
| rakhmerov | yes, i saw the code.. I think the approach is ok, but just be careful | 09:25 |
| gongysh | so what is the other choice for it to work? | 09:25 |
| rakhmerov | gongysh: another option, create an asynchronous action but in this case some 3rd party needs to call Mistral API back to notify about the result | 09:26 |
| rakhmerov | well, I think it's ok, just design this RPC code reliably first | 09:26 |
| rakhmerov | it probably just has a mistake somewhere | 09:26 |
| gongysh | rakhmerov, thanks, I will let my colleague to fix the rpc first. | 09:27 |
| rakhmerov | yes, that's the way to go in you case I believe | 09:28 |
| *** mgershen has joined #openstack-mistral | 09:29 | |
| rakhmerov | apetrich: please rebase https://review.openstack.org/#/c/474895/ | 10:09 |
| apetrich | rakhmerov, I will | 10:09 |
| apetrich | I saw that thanks :) | 10:09 |
| rakhmerov | thnx | 10:09 |
| rakhmerov | ) | 10:09 |
| *** gkadam has quit IRC | 10:28 | |
| *** gkadam has joined #openstack-mistral | 10:30 | |
| *** Kevin_Zheng has quit IRC | 10:31 | |
| *** Guest48624 has quit IRC | 10:39 | |
| *** rook has joined #openstack-mistral | 10:41 | |
| *** rook is now known as Guest52034 | 10:42 | |
| rakhmerov | apetrich, d0ugal: do you think we need to backport mistral_lib related changes to Ocata? Do you need it in TripleO maybe? | 10:55 |
| d0ugal | rakhmerov: no, we only need it for Pike | 10:56 |
| apetrich | rakhmerov, I don't think so. but not sure. it will ship with mistral lib 0.2.0 | 10:56 |
| rakhmerov | I'm just trying to backport https://review.openstack.org/#/c/475316/ and it fails because I already changed mistral.actions.base to mistral_lib.actions.base in one tasks | 10:56 |
| rakhmerov | but other changes were not backported | 10:56 |
| rakhmerov | ok | 10:56 |
| rakhmerov | so for now I'll just change this patch in Ocata manually | 10:56 |
| d0ugal | yeah | 10:56 |
| d0ugal | I doubt that mistral_lib would quality for backporting | 10:56 |
| rakhmerov | w/o backporting other changes | 10:56 |
| apetrich | aye | 10:56 |
| rakhmerov | ok | 10:56 |
| rakhmerov | thanks | 10:57 |
| *** jkilpatr has joined #openstack-mistral | 10:57 | |
| rakhmerov | d0ugal: agree on quality | 10:57 |
| d0ugal | oops, except I meant qualify :) | 10:57 |
| *** gongysh has quit IRC | 11:56 | |
| apetrich | rakhmerov, say I want to remove the serialization.register(Result, ResultSerializer) from mistral/workflow/utils.py where would you think would be a good place to register it? | 12:01 |
| *** dprince has joined #openstack-mistral | 12:03 | |
| *** apetrich has quit IRC | 12:05 | |
| *** apetrich has joined #openstack-mistral | 12:08 | |
| *** amoralej is now known as amoralej|lunch | 12:09 | |
| *** jtomasek_ has joined #openstack-mistral | 12:09 | |
| *** fultonj has joined #openstack-mistral | 12:21 | |
| *** jtomasek_ has quit IRC | 12:26 | |
| *** dtantsur is now known as dtantsur|brb | 12:26 | |
| *** gkadam has quit IRC | 12:31 | |
| *** sharatss has quit IRC | 12:33 | |
| *** sharatss has joined #openstack-mistral | 12:33 | |
| *** sharatss has quit IRC | 13:04 | |
| *** amoralej|lunch is now known as amoralej | 13:08 | |
| *** catintheroof has joined #openstack-mistral | 13:09 | |
| *** catintheroof has quit IRC | 13:14 | |
| *** catintheroof has joined #openstack-mistral | 13:14 | |
| *** Guest52034 is now known as rook | 13:30 | |
| *** dtantsur|brb is now known as dtantsur | 13:57 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Add the baremetal_introspection action for aborting https://review.openstack.org/475404 | 14:21 |
| *** gongysh has joined #openstack-mistral | 14:25 | |
| *** gongysh has quit IRC | 14:26 | |
| openstackgerrit | Michal Gershenzon proposed openstack/mistral-specs master: Create and run workflows within a namespace https://review.openstack.org/470996 | 14:31 |
| *** bobh has joined #openstack-mistral | 14:46 | |
| rakhmerov | meeting at #openstack-meeting-3 | 15:02 |
| rakhmerov | apetrich: let me think, good question | 15:02 |
| rakhmerov | maybe something like a launch script | 15:03 |
| *** chlong has joined #openstack-mistral | 15:03 | |
| rakhmerov | or engine initialization | 15:03 |
| rakhmerov | but executor actually needs it too.. | 15:03 |
| rakhmerov | ok, let me think.. | 15:03 |
| apetrich | cheers | 15:03 |
| apetrich | harder question than I thought | 15:04 |
| *** catintheroof has quit IRC | 15:07 | |
| *** catintheroof has joined #openstack-mistral | 15:08 | |
| *** shardy has quit IRC | 15:58 | |
| *** bobh has quit IRC | 15:58 | |
| *** dprince has quit IRC | 16:06 | |
| *** jpich has quit IRC | 16:27 | |
| *** bobh has joined #openstack-mistral | 16:29 | |
| *** dprince has joined #openstack-mistral | 16:33 | |
| *** chlong has quit IRC | 16:56 | |
| *** amoralej is now known as amoralej|off | 17:11 | |
| *** chlong has joined #openstack-mistral | 17:11 | |
| *** MAXIMILIANA has joined #openstack-mistral | 17:32 | |
| MAXIMILIANA | hola | 17:32 |
| MAXIMILIANA | nadie responde | 17:45 |
| *** MAXIMILIANA has left #openstack-mistral | 17:46 | |
| *** zigo has quit IRC | 18:05 | |
| *** zigo has joined #openstack-mistral | 18:09 | |
| *** doriftoshoes__ has joined #openstack-mistral | 18:12 | |
| *** cargonza_ has joined #openstack-mistral | 18:12 | |
| *** histrio_ has joined #openstack-mistral | 18:18 | |
| *** doriftoshoes_ has quit IRC | 18:19 | |
| *** cargonza has quit IRC | 18:19 | |
| *** histrio has quit IRC | 18:19 | |
| *** jamielennox has quit IRC | 18:19 | |
| *** rbrady-afk has quit IRC | 18:19 | |
| *** d0ugal has quit IRC | 18:19 | |
| *** histrio_ is now known as histrio | 18:19 | |
| *** cargonza_ is now known as cargonza | 18:19 | |
| *** dtantsur is now known as dtantsur|afk | 18:19 | |
| *** jamielennox has joined #openstack-mistral | 18:21 | |
| *** rbrady-afk has joined #openstack-mistral | 18:23 | |
| *** d0ugal has joined #openstack-mistral | 18:26 | |
| *** bobh has quit IRC | 18:28 | |
| *** shardy has joined #openstack-mistral | 19:04 | |
| *** bobh has joined #openstack-mistral | 19:28 | |
| *** jtomasek_ has joined #openstack-mistral | 19:59 | |
| *** jtomasek_ has quit IRC | 20:10 | |
| *** mgershen has quit IRC | 20:11 | |
| *** mgershen has joined #openstack-mistral | 20:13 | |
| *** shardy has quit IRC | 20:21 | |
| *** bobh has quit IRC | 20:24 | |
| *** bobh has joined #openstack-mistral | 20:24 | |
| *** chlong has quit IRC | 20:41 | |
| *** chlong has joined #openstack-mistral | 20:55 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral master: Updated from global requirements https://review.openstack.org/475550 | 21:04 |
| *** dprince has quit IRC | 21:10 | |
| *** jkilpatr has quit IRC | 21:45 | |
| *** chlong has quit IRC | 21:46 | |
| *** bobh has quit IRC | 22:13 | |
| *** jkilpatr has joined #openstack-mistral | 22:18 | |
| *** jkilpatr has quit IRC | 22:29 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!