| *** mbrennan has joined #openstack-mistral | 00:19 | |
| *** mbrennan has quit IRC | 00:22 | |
| *** mbrennan has joined #openstack-mistral | 00:22 | |
| *** mbrennan has quit IRC | 00:26 | |
| *** catintheroof has quit IRC | 00:36 | |
| *** mbrennan has joined #openstack-mistral | 00:42 | |
| *** mbrennan has quit IRC | 00:44 | |
| *** mbrennan has joined #openstack-mistral | 00:44 | |
| *** mbrennan has quit IRC | 00:49 | |
| *** mbrennan has joined #openstack-mistral | 00:51 | |
| *** mbrennan has quit IRC | 02:15 | |
| *** mbrennan has joined #openstack-mistral | 02:16 | |
| *** mbrennan has quit IRC | 02:20 | |
| *** gongysh has joined #openstack-mistral | 02:39 | |
| *** gongysh has quit IRC | 02:55 | |
| *** mbrennan has joined #openstack-mistral | 03:03 | |
| *** mbrennan has quit IRC | 03:06 | |
| *** mbrennan has joined #openstack-mistral | 03:07 | |
| *** mbrennan has quit IRC | 03:07 | |
| *** mbrennan has joined #openstack-mistral | 03:08 | |
| *** jaosorior_away has quit IRC | 04:44 | |
| *** rbrady has joined #openstack-mistral | 04:58 | |
| *** rbrady has joined #openstack-mistral | 04:58 | |
| openstackgerrit | Sharat Sharma proposed openstack/mistral master: Removed the deprecated attrs usage in mistral_tempest_plugin https://review.openstack.org/463576 | 05:11 |
|---|---|---|
| *** jaosorior has joined #openstack-mistral | 05:16 | |
| *** sharat has joined #openstack-mistral | 05:23 | |
| openstackgerrit | Merged openstack/python-mistralclient master: Change service type to workflowv2 https://review.openstack.org/462917 | 05:28 |
| openstackgerrit | Sharat Sharma proposed openstack/python-mistralclient master: Use keystoneauth plugins and session instead of keystoneclient https://review.openstack.org/455174 | 05:30 |
| *** sharat has quit IRC | 05:56 | |
| *** sharat has joined #openstack-mistral | 05:57 | |
| openstackgerrit | Merged openstack/mistral master: Revert "Support transition to keystone auth plugin" https://review.openstack.org/463455 | 06:12 |
| *** chlong has quit IRC | 06:23 | |
| *** sharat has quit IRC | 07:35 | |
| *** sharat has joined #openstack-mistral | 07:35 | |
| *** jpich has joined #openstack-mistral | 07:48 | |
| *** jtomasek is now known as jtomasek|bbl | 08:20 | |
| breton | lol @ https://review.openstack.org/#/c/463455/ | 08:39 |
| d0ugal | breton: indeed :( | 08:47 |
| d0ugal | breton: any idea why it was broken? | 08:47 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: WIP Setup logging for the mistral-db-manage commands https://review.openstack.org/463684 | 08:49 |
| therve | d0ugal, I think the answer is again in the non-voting job... | 08:52 |
| therve | http://logs.openstack.org/60/462560/6/check/gate-mistral-devstack-dsvm-ubuntu-xenial-nv/0919b23/logs/screen-mistral-executor.txt.gz#_May_05_04_57_20_779161 for example | 08:53 |
| d0ugal | therve: oh, well spotted. | 08:59 |
| d0ugal | It is almost like we should make these voting :P | 09:00 |
| breton | interesting, keystone_authtoken.username is in mistral.conf | 09:00 |
| breton | maybe option .username is not described as python object and oslo_config knows nothing about it | 09:02 |
| *** jpich has quit IRC | 09:32 | |
| *** jtomasek|bbl is now known as jtomasek | 10:04 | |
| *** tuan_ has joined #openstack-mistral | 10:20 | |
| openstackgerrit | luong tuan proposed openstack/mistral master: Refactor mistral context using oslo_context https://review.openstack.org/455407 | 10:45 |
| *** gongysh has joined #openstack-mistral | 10:49 | |
| *** gongysh has quit IRC | 10:51 | |
| d0ugal | rakhmerov: hey, you around? | 11:30 |
| rakhmerov | d0ugal: yes | 11:30 |
| d0ugal | rakhmerov: I have a quick question about on-success and multiple tasks. | 11:31 |
| rakhmerov | ok | 11:31 |
| d0ugal | rakhmerov: say I have on-success: - A - B - C | 11:31 |
| d0ugal | so it runs three tasks on success | 11:31 |
| d0ugal | will they run concurrently or will B start after A finishes? | 11:31 |
| rakhmerov | concurrently | 11:32 |
| d0ugal | okay, thanks :) | 11:32 |
| rakhmerov | :) | 11:32 |
| d0ugal | oh, I just found in the docs where it says this | 11:32 |
| d0ugal | sorry | 11:32 |
| d0ugal | https://docs.openstack.org/developer/mistral/dsl/dsl_v2.html#fork | 11:32 |
| rakhmerov | np | 11:33 |
| d0ugal | rakhmerov: btw, do you deploy with mysql or postgres? | 11:38 |
| rakhmerov | I personally run with both to test some things. Nokia deploys with mysq | 11:39 |
| rakhmerov | MariaDB | 11:39 |
| rakhmerov | I personally would recommend postgres | 11:40 |
| d0ugal | rakhmerov: thanks, just curious. I was reading the comments on https://review.openstack.org/#/c/427880/ | 11:40 |
| d0ugal | rakhmerov: yeah, I would recommend postgres too :) | 11:40 |
| d0ugal | but we use maria also :( | 11:40 |
| rakhmerov | ooh woow | 11:40 |
| rakhmerov | what is the reason to deprecate postgres? (lazy to read :) ) | 11:41 |
| rakhmerov | I have much better experience with postgres actually | 11:41 |
| rakhmerov | can tell details | 11:41 |
| d0ugal | me too, I think it is a far superior database :) | 11:42 |
| d0ugal | anyway, the reasoning is hard to summarise... maybe just read the first few paragraphs of the rst file. https://review.openstack.org/#/c/427880/3/resolutions/20170201-deprecate-pg.rst | 11:42 |
| d0ugal | but I guess the tl;dr is we are not supporting it as well as mysql (because it isn't tested, people don't use it as much etc.) so we should stop pretending | 11:43 |
| d0ugal | brb | 11:43 |
| rakhmerov | d0ugal: ok, I'll read it. But at first glance it's a crappy decision.. | 11:45 |
| openstackgerrit | luong tuan proposed openstack/mistral master: Add user creds trusts to db https://review.openstack.org/462056 | 11:46 |
| *** chlong has joined #openstack-mistral | 11:59 | |
| d0ugal | rakhmerov: agreed, I think it will change a bit before it is accepted tho' | 12:27 |
| rakhmerov | hopefully | 12:28 |
| d0ugal | rakhmerov: the final comment is a good summary and rebuttal of the reasons | 12:29 |
| rakhmerov | yeah, I was going to write something similar (+ some technical details) but after reading the last one I decided not to ) | 12:29 |
| *** rbrady has quit IRC | 12:30 | |
| openstackgerrit | luong tuan proposed openstack/mistral master: Add user creds trusts to db https://review.openstack.org/462056 | 12:49 |
| *** mbrennan has quit IRC | 12:49 | |
| *** sharat has quit IRC | 12:50 | |
| *** mbrennan has joined #openstack-mistral | 12:50 | |
| *** mbrennan has quit IRC | 12:54 | |
| *** rbrady has joined #openstack-mistral | 12:59 | |
| *** jkilpatr has joined #openstack-mistral | 13:01 | |
| *** toure|gone is now known as toure | 13:10 | |
| *** chlong has quit IRC | 13:10 | |
| *** shardy has joined #openstack-mistral | 13:21 | |
| *** rbrady has quit IRC | 13:27 | |
| *** dprince has joined #openstack-mistral | 13:39 | |
| apetrich_ | d0ugal, can I help with some of those tasks? | 13:45 |
| d0ugal | apetrich_: sure! | 13:45 |
| d0ugal | apetrich_: I have not actually reported bugs for them, maybe I should start with that. | 13:45 |
| *** jkilpatr has quit IRC | 13:48 | |
| *** rbrady has joined #openstack-mistral | 13:48 | |
| d0ugal | apetrich_: https://bugs.launchpad.net/mistral/+bug/1689821 | 13:50 |
| openstack | Launchpad bug 1689821 in Mistral "The mistral-db-manage should log it's output" [High,Confirmed] - Assigned to Adriano Petrich (apetrich) | 13:50 |
| apetrich_ | d0ugal, cool. I will start with that | 13:50 |
| d0ugal | apetrich_: https://bugs.launchpad.net/mistral/+bug/1689823 | 13:50 |
| openstack | Launchpad bug 1689823 in Mistral "mistral-db-manage should have a different return code on partial failure" [Medium,Confirmed] | 13:50 |
| d0ugal | apetrich_: you are welcome to either of those :) | 13:52 |
| d0ugal | apetrich_: this is as far as my experimentation got, but then introspection finished. https://review.openstack.org/463684 | 13:52 |
| apetrich_ | d0ugal, :) I will start with the logging just because | 13:52 |
| apetrich_ | d0ugal, cheers | 13:52 |
| *** mbrennan has joined #openstack-mistral | 13:52 | |
| *** mbrennan has quit IRC | 13:52 | |
| d0ugal | cool | 13:52 |
| *** mbrennan has joined #openstack-mistral | 13:53 | |
| *** jkilpatr has joined #openstack-mistral | 13:55 | |
| openstackgerrit | luong tuan proposed openstack/mistral master: Refactor mistral context using oslo_context https://review.openstack.org/455407 | 13:55 |
| *** catintheroof has joined #openstack-mistral | 13:59 | |
| apetrich_ | d0ugal, btw why not logging.getLogger(__name__)? | 14:03 |
| d0ugal | apetrich_: not sure, I was trying to copy how logging was setup for the api etc. but I didn't get that far. | 14:04 |
| *** rbrady_ has joined #openstack-mistral | 14:04 | |
| *** rbrady_ has joined #openstack-mistral | 14:04 | |
| apetrich_ | d0ugal, ah ok. I was afraid that it was something I wasn't seeing | 14:05 |
| tuan_ | apetrich_: Because we have oslo_log | 14:21 |
| tuan_ | oslo library provides us a common base with a lot of parameters | 14:22 |
| tuan_ | for instance if you want to use the normal python loggin library | 14:22 |
| tuan_ | getLogger(__name__) | 14:22 |
| tuan_ | you have to also provide the configuration for that logging | 14:22 |
| *** chlong has joined #openstack-mistral | 14:23 | |
| tuan_ | but with oslo_log, all the configuration params are controlled under oslo object | 14:23 |
| tuan_ | you just need to provide the config parameters that you want to oslo object | 14:24 |
| tuan_ | and then everything will work like charm | 14:24 |
| tuan_ | :) | 14:24 |
| apetrich_ | tuan_, I had std_actions.py open and it used the use oslo_log as logging and LOG = logging.getLogger(__name__) | 14:25 |
| tuan_ | apetrich_: oh, may be i misunderstand your question | 14:27 |
| tuan_ | :) | 14:27 |
| apetrich_ | tuan_, I'm adding logging to db/migrations/cli and I was looking at d0ugal's review and he used in a different way I was trying to figure out how should I do it | 14:28 |
| apetrich_ | :) | 14:28 |
| apetrich_ | bbiab | 14:28 |
| * d0ugal probably didn't do it right | 14:30 | |
| tuan_ | apetrich_: https://github.com/openstack/oslo.log/blob/master/oslo_log/log.py#L262 | 14:30 |
| tuan_ | you can check the setup logging for service from conf here | 14:30 |
| tuan_ | well, by using logging.setup() as dougal provided | 14:31 |
| tuan_ | we have more options for logging configurations | 14:32 |
| tuan_ | you can check in the link i have sent | 14:32 |
| *** catintheroof has quit IRC | 14:36 | |
| tuan_ | oh, it is the patch dougal did: https://review.openstack.org/#/c/463684/1/mistral/db/sqlalchemy/migration/cli.py | 14:36 |
| tuan_ | now i understand | 14:36 |
| tuan_ | just my personal idea :) | 14:36 |
| tuan_ | as you can see that in the oslo_log when you setup logging, this setup is used for setting logging for an application | 14:37 |
| *** rbrady_ has quit IRC | 14:37 | |
| *** rbrady has quit IRC | 14:37 | |
| tuan_ | it seems that the cli.py with the main() will run as a process in background therefore we treat it as an "application" | 14:38 |
| tuan_ | on another hand, when we set getLogger | 14:38 |
| tuan_ | it will create a logger for the module where the getLogger is called | 14:39 |
| tuan_ | for instance: you have a module like: mistral.actions.my_action | 14:39 |
| *** jkilpatr has quit IRC | 14:40 | |
| tuan_ | then the logger will be create as: getLogger(__name__) = getLogger(mistral.action.my_action) | 14:40 |
| tuan_ | hopefully i can help you in some sense | 14:40 |
| *** jkilpatr has joined #openstack-mistral | 14:47 | |
| *** rbrady_ has joined #openstack-mistral | 14:52 | |
| *** rbrady has joined #openstack-mistral | 14:52 | |
| *** rbrady has quit IRC | 14:52 | |
| *** rbrady has joined #openstack-mistral | 14:52 | |
| *** dprince has quit IRC | 14:56 | |
| *** shardy has quit IRC | 15:00 | |
| *** catintheroof has joined #openstack-mistral | 15:02 | |
| *** shardy has joined #openstack-mistral | 15:03 | |
| d0ugal | tuan_: I think that makes sense | 15:06 |
| d0ugal | tuan_: so is what I done the correct way to setup oslo_log? | 15:06 |
| *** jkilpatr has quit IRC | 15:07 | |
| *** shardy has quit IRC | 15:15 | |
| *** shardy has joined #openstack-mistral | 15:22 | |
| *** jkilpatr has joined #openstack-mistral | 15:33 | |
| *** rbrady has quit IRC | 15:40 | |
| *** rbrady_ has quit IRC | 15:40 | |
| *** jkilpatr has quit IRC | 15:41 | |
| tuan_ | d0ugal: yeap, | 15:41 |
| tuan_ | i think so | 15:41 |
| tuan_ | IMHO | 15:42 |
| tuan_ | :) | 15:42 |
| *** jaosorior is now known as jaosorior_away | 15:42 | |
| *** tuan_ has quit IRC | 15:42 | |
| *** shardy has quit IRC | 15:46 | |
| *** catintheroof has quit IRC | 15:54 | |
| *** shardy has joined #openstack-mistral | 16:47 | |
| *** jkilpatr has joined #openstack-mistral | 17:11 | |
| *** mbrennan has quit IRC | 17:36 | |
| *** shardy has quit IRC | 17:37 | |
| *** jkilpatr has quit IRC | 17:42 | |
| *** mbrennan has joined #openstack-mistral | 17:54 | |
| *** shardy has joined #openstack-mistral | 18:41 | |
| *** jkilpatr has joined #openstack-mistral | 18:41 | |
| *** jkilpatr has quit IRC | 19:12 | |
| *** jkilpatr has joined #openstack-mistral | 19:16 | |
| *** shardy has quit IRC | 19:26 | |
| *** jkilpatr has quit IRC | 19:42 | |
| *** shardy has joined #openstack-mistral | 19:44 | |
| *** shardy has quit IRC | 20:02 | |
| *** catintheroof has joined #openstack-mistral | 20:08 | |
| *** mbrennan has quit IRC | 20:15 | |
| *** mbrennan has joined #openstack-mistral | 20:15 | |
| *** mbrennan has quit IRC | 20:20 | |
| *** mbrennan has joined #openstack-mistral | 20:23 | |
| *** mbrennan has quit IRC | 20:25 | |
| *** jkilpatr has joined #openstack-mistral | 20:29 | |
| *** rbrady has joined #openstack-mistral | 20:30 | |
| *** rbrady_ has joined #openstack-mistral | 20:31 | |
| apetrich_ | Thanks | 20:37 |
| *** catintheroof has quit IRC | 20:41 | |
| *** mbrennan has joined #openstack-mistral | 21:00 | |
| openstackgerrit | Winson Chan proposed openstack/mistral master: Fix WSGI script for gunicorn https://review.openstack.org/463870 | 21:38 |
| *** mbrennan has quit IRC | 21:45 | |
| *** mbrennan has joined #openstack-mistral | 21:46 | |
| *** mbrennan has quit IRC | 21:50 | |
| *** jkilpatr has quit IRC | 22:11 | |
| *** rbrady_ has quit IRC | 22:33 | |
| *** rbrady has quit IRC | 22:35 | |
| *** catintheroof has joined #openstack-mistral | 22:38 | |
| *** catintheroof has quit IRC | 22:56 | |
| *** catintheroof has joined #openstack-mistral | 22:57 | |
| *** catintheroof has quit IRC | 22:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!