Tuesday, 2017-04-18

*** mgershen1 has joined #openstack-mistral00:01
*** mgershen has quit IRC00:02
*** zhurong has joined #openstack-mistral00:42
*** mgershen has joined #openstack-mistral00:46
*** mgershen1 has quit IRC00:47
*** mgershen1 has joined #openstack-mistral01:46
*** mgershen has quit IRC01:47
*** jkilpatr has quit IRC01:53
*** vishwanathj has joined #openstack-mistral01:56
*** vishwanathj has quit IRC01:58
*** vishwanathj has joined #openstack-mistral01:58
*** jkilpatr has joined #openstack-mistral02:01
*** vishwanathj has quit IRC02:03
*** mgershen has joined #openstack-mistral02:03
*** vishwanathj has joined #openstack-mistral02:04
*** mgershen1 has quit IRC02:04
*** bobh has joined #openstack-mistral02:12
*** mgershen1 has joined #openstack-mistral02:17
*** mgershen has quit IRC02:19
*** mgershen has joined #openstack-mistral02:32
*** mgershen1 has quit IRC02:34
*** mgershen1 has joined #openstack-mistral02:49
*** mgershen has quit IRC02:50
*** zhurong has quit IRC03:03
*** zhurong has joined #openstack-mistral03:13
*** zhurong has quit IRC04:00
*** zhurong has joined #openstack-mistral04:17
*** zhurong has quit IRC04:25
*** bobh has quit IRC04:54
*** zhurong has joined #openstack-mistral05:00
*** sharatss has joined #openstack-mistral05:05
*** jamielennox is now known as jamielennox|away05:12
*** jamielennox|away is now known as jamielennox05:17
*** warface has joined #openstack-mistral05:44
*** jtomasek has joined #openstack-mistral06:30
*** jkilpatr has quit IRC06:33
*** vishwanathj has quit IRC06:34
*** vishwana_ has joined #openstack-mistral06:34
*** jkilpatr has joined #openstack-mistral06:39
*** jpich has joined #openstack-mistral07:03
*** shardy has joined #openstack-mistral07:09
*** jamielennox is now known as jamielennox|away07:34
*** mgershen has joined #openstack-mistral07:38
*** mgershen1 has quit IRC07:39
*** mgershen1 has joined #openstack-mistral07:54
*** mgershen has quit IRC07:55
*** warface has quit IRC08:00
*** warface has joined #openstack-mistral08:02
*** jaosorior has joined #openstack-mistral08:03
*** mgershen has joined #openstack-mistral08:08
*** zhurong has quit IRC08:09
*** brunograz has quit IRC08:10
*** mgershen1 has quit IRC08:11
*** brunograz has joined #openstack-mistral08:15
*** tuan_ has joined #openstack-mistral08:22
*** dmk0202 has joined #openstack-mistral08:22
*** mgershen1 has joined #openstack-mistral08:24
*** mgershen has quit IRC08:25
*** zhurong has joined #openstack-mistral08:26
*** jamielennox|away is now known as jamielennox08:28
*** openstackgerrit has quit IRC08:33
*** mgershen has joined #openstack-mistral08:39
*** mgershen1 has quit IRC08:42
*** mgershen1 has joined #openstack-mistral08:56
*** mgershen has quit IRC08:56
*** mgershen has joined #openstack-mistral09:10
*** mgershen1 has quit IRC09:13
*** warface has quit IRC09:25
*** mgershen1 has joined #openstack-mistral09:26
*** warface has joined #openstack-mistral09:27
*** mgershen has quit IRC09:27
*** gongysh has joined #openstack-mistral09:37
*** mgershen has joined #openstack-mistral09:41
*** openstackgerrit has joined #openstack-mistral09:42
openstackgerritJuan Antonio Osorio Robles proposed openstack/python-mistralclient master: Use keystoneauth plugins and session instead of keystoneclient  https://review.openstack.org/45517409:42
*** zhurong has quit IRC09:42
jaosoriorsharatss: This should at least send a proper error message if something is missing ^^09:42
sharatssjaosorior, let me test09:43
*** mgershen1 has quit IRC09:43
sharatssjaosorior, module object has no attribute 'determine_client_version'09:47
jaosorioris that something I touched?09:48
jaosoriorfunky09:49
jaosoriorsharatss: where is that coming from?09:49
jaosoriorwhat else is in that stacktrace?09:49
sharatssits coming from shell.py09:50
jaosoriorsharatss: can you post the full stack trace? (that usually is more helpful for debuggin :) )09:51
sharatssjaosorior, just a sec09:52
*** mgershen1 has joined #openstack-mistral09:57
*** mgershen has quit IRC09:59
*** sharatss has quit IRC09:59
*** sharatss_ has joined #openstack-mistral10:01
sharatss_Traceback (most recent call last):   File "/usr/local/lib/python2.7/dist-packages/cliff/app.py", line 262, in run     self.initialize_app(remainder)   File "/usr/local/lib/python2.7/dist-packages/mistralclient/shell.py", line 497, in initialize_app     ver = client.determine_client_version(self.options.mistral_version) AttributeError: 'module' object has no attribute 'determine_client_version' Traceback (most recent call l10:01
sharatss_jaosorior: ^^10:02
sharatss_sorry problem with my irc client.. so not able to paste it properly10:02
jaosoriorsharatss_: client.determine_client_version is this https://github.com/openstack/python-mistralclient/blob/master/mistralclient/api/client.py any idea why it would be failing?10:03
jaosoriorsharatss_: it's called here https://github.com/openstack/python-mistralclient/blob/master/mistralclient/shell.py#L521 and it could only fail if an invalid version is being given. However, that's not the error you're seeing there10:04
sharatss_jaosorior: yes.. and definitely the version was not changed10:05
jaosoriorsharatss_: you could try to manually import that module and check out what's going on10:05
*** shardy has quit IRC10:06
jaosoriordid you change anything else?10:06
sharatss_jaosorior: nothing else except the changes in the patch10:06
*** mgershen has joined #openstack-mistral10:13
*** mgershen1 has quit IRC10:13
sharatss_jaosorior: File "/home/jenkins/workspace/gate-python-mistralclient-python27-ubuntu-xenial/mistralclient/api/v2/client.py", line 58, in __init__      session = auth_response.pop('session')  KeyError: 'session'10:15
*** tuan_ has quit IRC10:16
*** sharat has joined #openstack-mistral10:17
*** thrash|g0ne is now known as thrash10:19
jaosoriorsharatss_: no errors before that?10:19
sharatss_jaosorior: that's the only error i find now except some testcase fails10:22
sharatss_File "/home/jenkins/workspace/gate-python-mistralclient-python27-ubuntu-xenial/mistralclient/auth/keystone.py", line 99, in authenticate10:23
jaosoriorsharatss_: well, we will need to change the test cases, most likely10:23
sharatss_raise RuntimeError("You must either provide a valid token or "10:23
sharatss_RuntimeError: You must either provide a valid token or a password (api_key) and a user.10:23
sharatss_jaosorior: ^^10:23
jaosoriorsharatss_: yep, exactly. For some reason there is no token getting there, not a password10:23
jaosoriorso it won't be able to build the session10:24
jaosoriorthat raise RuntimeError should have happened before, and it shouldn't have tried to do the pop('session'10:24
jaosorior)10:24
jaosoriorso, why is it not getting a password or a token?10:24
jaosoriorsharatss_: do you have an  environment I could log into?10:26
sharatss_jaosorior: because we have removed keystone.authenticate() from line #96?10:26
sharatss_jaosorior: i am afraid no10:26
sharatss_jaosorior: i use virtualbox10:27
jaosoriorsharatss_: we shouldn't need the authenticate anymore, that will be handled by the session10:27
*** mgershen1 has joined #openstack-mistral10:28
*** mgershen has quit IRC10:29
*** shardy has joined #openstack-mistral10:29
*** gongysh has quit IRC10:31
*** sharat has quit IRC10:34
*** jkilpatr has quit IRC10:40
*** mgershen has joined #openstack-mistral10:43
*** mgershen1 has quit IRC10:44
*** jaosorior has quit IRC10:55
*** mgershen1 has joined #openstack-mistral10:58
*** mgershen has quit IRC11:00
*** jaosorior has joined #openstack-mistral11:01
*** shardy is now known as shardy_lunch11:06
*** zhurong has joined #openstack-mistral11:14
*** jkilpatr has joined #openstack-mistral11:14
*** mgershen has joined #openstack-mistral11:14
*** tuan_ has joined #openstack-mistral11:15
*** mgershen1 has quit IRC11:16
*** sharatss has joined #openstack-mistral11:22
*** mgershen1 has joined #openstack-mistral11:32
*** mgershen has quit IRC11:32
*** tuan_ has quit IRC11:38
*** tuan_ has joined #openstack-mistral11:41
*** mgershen has joined #openstack-mistral11:45
*** mgershen1 has quit IRC11:47
tuan_@jamielennox: I am here11:49
jamielennoxtuan_: so what's up ?11:49
tuan_yep11:49
tuan_when i switch to use context11:50
tuan_some tests failed11:50
tuan_for instance11:50
tuan_let me send you the link11:50
tuan_jamielennox: https://github.com/openstack/mistral/blob/master/mistral/tests/unit/utils/test_keystone_utils.py#L4711:51
tuan_this test failed11:51
jamielennoxso i have no idea how mistral is handling clients11:52
jamielennoxbut if you're using the session stuff correctly you don't need to manually find endpoints11:52
tuan_the point is11:54
tuan_this test will call the authentication of token11:54
tuan_and in this case, through client, the authentication fails since there is no information in CONF.keystone_authtoken11:54
jamielennoxok, so oslo.context doesn't change any of this11:57
tuan_yep11:57
tuan_that is why i do not understand why it fails11:57
tuan_do you have any ideas for it11:58
jamielennoxso that config sets up auth token middleware11:58
jamielennoxi can only guess that there is a mock or something in  mistral that used to bypass it11:58
jamielennoxbut i have never really looked at how mistral works11:59
tuan_https://github.com/openstack/mistral/blob/master/mistral/utils/openstack/keystone.py#L4811:59
tuan_here is where all the thing is empty11:59
tuan_hmm, okay,i will check it again11:59
jamielennoxor maybe it's just not setting it up in testing?11:59
tuan_may be it is bypassed12:00
tuan_well, in master12:00
tuan_all the thing are OK with keystone middleware12:00
tuan_user_id='1-2-3-4',12:01
tuan_            project_id=security.DEFAULT_PROJECT_ID,12:01
tuan_            username='test-user',12:01
tuan_            password='password',12:01
tuan_            project_name='test-project',12:01
tuan_            is_admin=admin12:01
tuan_you see, it is the information passed to context12:01
*** mgershen1 has joined #openstack-mistral12:01
tuan_this test just simply use this information from oslo context12:02
tuan_and then call keystone client to verify12:02
jamielennoxwhere does that come from?12:02
jamielennoxwhy is itcalling keystoneclient?12:02
tuan_this test is about testing keystone utils12:02
*** mgershen has quit IRC12:02
tuan_in order to test it12:03
tuan_we provide the context12:03
tuan_and then call the keystone client to validate the token12:03
jamielennoxi see a bunch of things like @mock.patch('mistral.actions.openstack.actions.keystone_utils.get_keystone_endpoint_v2')12:03
jamielennoxwhich i assume is why this was never hit before12:03
jamielennoxwow, so much mocking12:03
tuan_well, this test fails before going into the logic12:04
tuan_it fails from very beginning when checking the keystone authentication12:05
jamielennoxok, so you used to just fake out the context with a bunch of fake values12:05
tuan_yep, the context is faked12:05
tuan_and provided to the test12:05
tuan_jamielennox: https://github.com/openstack/mistral/blob/master/mistral/tests/unit/utils/test_keystone_utils.py#L4912:05
tuan_here it is12:06
tuan_it get the context from local thread12:06
tuan_that is12:06
jamielennoxok12:06
*** chlong has joined #openstack-mistral12:13
jamielennoxtuan_: i'm not sure what you're asking, the problem seems to be that mistral tests mocks out a lot of stuff and you are changing the order so mocks break12:14
jamielennoxthat's a big problem when your tests are that heavily mocked - but i don't think it's oslo.context's fault12:14
tuan_jamielennox: me neither12:14
tuan_i do not think it is problem of oslo context12:14
tuan_let me check back again12:15
jamielennoxso i can tell you that ideally you can use oslo.context and keystonemiddleware to not have to auth direct to keystone so much12:15
*** shardy_lunch is now known as shardy12:16
tuan_i understand this logic12:16
jamielennoxand there's no reason mistral should be doing service catalog parsing like: https://github.com/openstack/mistral/blob/master/mistral/utils/openstack/keystone.py#L8812:16
jamielennoxbut you're better off asking someone familiar with how mistral tests setup works12:16
jamielennoxbecause from what i saw of the patch you are proposing it doesn't actually change much12:16
tuan_but the test fails before that12:16
tuan_https://github.com/openstack/mistral/blob/master/mistral/utils/openstack/keystone.py#L7912:16
tuan_when it tries to obtain the authen12:17
jamielennoxsure but as far as i can see that will never hit auth_token middleware because the mistral tests create a fake one12:18
*** mgershen has joined #openstack-mistral12:19
*** mgershen1 has quit IRC12:19
jamielennoxfake contex12:19
tuan_can you show me some examples to not use the fake context with middleware12:22
tuan_agree that with the fake one, it fails12:22
tuan_i also tried to override the values inside middleware with fake values12:22
jamielennoxi don't see how this ever worked actually12:22
tuan_and indeed it fails12:22
jamielennoxhttps://github.com/openstack/mistral/blob/master/mistral/tests/unit/utils/test_keystone_utils.py#L49 creates a fake context with no service catalog12:23
jamielennoxoh, mistral will try and reach out to keystone: https://github.com/openstack/mistral/blob/master/mistral/utils/openstack/keystone.py#L14112:24
tuan_but it fails before to reach that point12:25
tuan_https://github.com/openstack/mistral/blob/master/mistral/utils/openstack/keystone.py#L12612:25
tuan_it fails when to check the scope token or not12:25
jamielennoxwhy does mistral go back to keystone to check if it's trust scoped? https://github.com/openstack/mistral/blob/master/mistral/utils/openstack/keystone.py#L17012:27
jamielennoxthat information is provided by auth_token middleware12:27
tuan_well12:28
tuan_before it, keystone tries to verify the token to check it is scoped or not12:28
tuan_and without auth_uri from keystone middleware12:28
tuan_it raises the error12:28
tuan_and all the thing stop when that error is raised12:29
jamielennoxso why did it pass before?12:30
tuan_that is why i do not understand12:30
jamielennoxok - you're going to need someone with mistral expertise for that12:31
jamielennoxi know what oslo.context is doing - and it's not all that much12:31
jamielennoxbut i have no idea how mistral sets this up12:31
tuan_since oslo context and "pure" context have no difference12:31
jamielennoxyep, so the fixture i would suggest you use mocks out the token validation portion of auth_token middlware12:31
jamielennoxbut from what i can see of the tests auth-token middleware is never actually used12:32
tuan_yep12:32
*** mgershen has quit IRC12:33
*** mgershen has joined #openstack-mistral12:33
jamielennoxsorry, i'm not sure - this is something that all the projects do differently and you'll have to talk to someone who knows how mistral authentication works12:35
tuan_yep12:35
tuan_thanks jammie:)12:35
jamielennoxno worries - sorry i couldn't hel;p12:36
tuan_well, i appreciate that12:37
tuan_i will update you later if i have something new12:37
tuan_:)12:37
*** gongysh has joined #openstack-mistral12:37
tuan_another thing is: when i check keystoneclient test with keystone middleware usage12:37
tuan_i mean in heat12:38
tuan_heat also create the fake context12:38
*** gongysh has quit IRC12:38
tuan_and then override the values inside keystone_authtoken12:38
tuan_all the things are ok over there12:38
tuan_:D12:38
*** gongysh has joined #openstack-mistral12:39
*** gongysh has quit IRC12:40
*** zhurong has quit IRC12:45
*** mgershen1 has joined #openstack-mistral12:47
*** toure|gone is now known as toure12:48
*** mgershen has quit IRC12:48
*** fultonj has joined #openstack-mistral13:02
*** mgershen has joined #openstack-mistral13:03
*** mgershen1 has quit IRC13:05
*** dougshelley66 has left #openstack-mistral13:06
*** jaosorior has quit IRC13:06
*** tuan_ has quit IRC13:14
*** jaosorior has joined #openstack-mistral13:14
*** mgershen1 has joined #openstack-mistral13:19
*** mgershen has quit IRC13:21
*** mgershen has joined #openstack-mistral13:35
*** mgershen1 has quit IRC13:36
d0ugalShould we put documentation in mistral-lib?13:47
d0ugalor should the documentation just live in Mistral and reference mistral-lib?13:47
thrashd0ugal: or time to mistral-docs?13:47
d0ugalnaaaah13:48
d0ugal:)13:48
d0ugalI think that just causes the documentation to become more disconnected13:49
d0ugalWe could move everything into the mistral repo ;)13:49
*** mgershen1 has joined #openstack-mistral13:51
*** mgershen has quit IRC13:53
*** dprince has joined #openstack-mistral14:01
*** mgershen has joined #openstack-mistral14:05
*** mgershen1 has quit IRC14:07
openstackgerritSharat Sharma proposed openstack/python-mistralclient master: Switch from keystoneclient to keystoneauth  https://review.openstack.org/45765614:14
*** sharatss has quit IRC14:18
*** warface has quit IRC14:38
*** dprince has quit IRC14:39
*** mgershen1 has joined #openstack-mistral14:42
*** mgershen has quit IRC14:43
*** mgershen has joined #openstack-mistral14:53
*** mgershen1 has quit IRC14:54
*** livelace has joined #openstack-mistral15:11
*** mgershen1 has joined #openstack-mistral15:11
*** mgershen has quit IRC15:13
*** catintheroof has joined #openstack-mistral15:22
*** mgershen has joined #openstack-mistral15:24
*** mgershen1 has quit IRC15:25
*** tuan_ has joined #openstack-mistral15:35
*** mgershen1 has joined #openstack-mistral15:40
*** mgershen has quit IRC15:42
*** mgershen has joined #openstack-mistral15:55
*** vishwana_ has quit IRC15:56
*** mgershen1 has quit IRC15:57
*** Kevin_Zheng has quit IRC15:57
*** mgershen1 has joined #openstack-mistral16:09
*** mgershen has quit IRC16:12
*** jpich has quit IRC16:14
*** mgershen has joined #openstack-mistral16:27
*** mgershen1 has quit IRC16:28
*** bobh has joined #openstack-mistral16:29
*** mgershen1 has joined #openstack-mistral16:41
*** mgershen has quit IRC16:42
*** jaosorior has quit IRC16:43
openstackgerritOpenStack Proposal Bot proposed openstack/mistral-dashboard master: Updated from global requirements  https://review.openstack.org/45772816:49
*** harlowja_ has joined #openstack-mistral16:50
*** harlowja has quit IRC16:52
*** dmk0202 has quit IRC16:52
*** mgershen has joined #openstack-mistral16:56
*** mgershen1 has quit IRC16:58
*** mgershen1 has joined #openstack-mistral17:11
*** mgershen has quit IRC17:13
*** tuan_ has quit IRC17:17
*** jkilpatr has quit IRC17:22
*** mgershen has joined #openstack-mistral17:27
*** mgershen1 has quit IRC17:29
*** shardy has quit IRC17:30
*** jkilpatr has joined #openstack-mistral17:38
*** dougshelley66 has joined #openstack-mistral17:41
*** mgershen1 has joined #openstack-mistral17:45
*** mgershen has quit IRC17:45
*** mgershen has joined #openstack-mistral17:59
*** mgershen1 has quit IRC18:01
*** mgershen1 has joined #openstack-mistral18:15
*** mgershen has quit IRC18:17
*** tung_doan has quit IRC18:23
*** mgershen has joined #openstack-mistral18:31
*** mgershen1 has quit IRC18:33
*** jkilpatr_ has joined #openstack-mistral18:36
*** jkilpatr has quit IRC18:36
*** mgershen1 has joined #openstack-mistral18:44
*** mgershen has quit IRC18:46
*** mgershen has joined #openstack-mistral18:59
*** mgershen1 has quit IRC19:01
*** livelace has quit IRC19:12
*** mgershen1 has joined #openstack-mistral19:16
*** mgershen has quit IRC19:17
*** mgershen has joined #openstack-mistral19:33
*** mgershen1 has quit IRC19:33
*** mgershen1 has joined #openstack-mistral19:47
*** mgershen has quit IRC19:49
*** mgershen has joined #openstack-mistral20:17
*** mgershen1 has quit IRC20:19
*** mgershen1 has joined #openstack-mistral20:32
*** openstackgerrit has quit IRC20:33
*** mgershen has quit IRC20:33
*** jkilpatr_ has quit IRC20:34
*** mgershen has joined #openstack-mistral20:49
*** mgershen1 has quit IRC20:50
*** jkilpatr has joined #openstack-mistral20:55
*** mgershen1 has joined #openstack-mistral21:07
*** mgershen has quit IRC21:08
*** dmk0202 has joined #openstack-mistral21:11
*** mgershen has joined #openstack-mistral21:18
*** mgershen1 has quit IRC21:20
*** mgershen1 has joined #openstack-mistral21:34
*** mgershen has quit IRC21:36
*** mgershen has joined #openstack-mistral21:49
*** mgershen1 has quit IRC21:51
*** dmk0202 has quit IRC21:59
*** catintheroof has quit IRC22:01
*** mgershen1 has joined #openstack-mistral22:16
*** bobh has quit IRC22:17
*** mgershen has quit IRC22:17
*** mgershen has joined #openstack-mistral22:35
*** mgershen1 has quit IRC22:37
*** mgershen1 has joined #openstack-mistral22:50
*** mgershen has quit IRC22:51
*** mgershen has joined #openstack-mistral23:21
*** mgershen1 has quit IRC23:22
*** d0ugal has quit IRC23:32
*** mgershen1 has joined #openstack-mistral23:37
*** mgershen has quit IRC23:39
*** d0ugal has joined #openstack-mistral23:42
*** thrash is now known as thrash|g0ne23:44
*** mgershen has joined #openstack-mistral23:50
*** mgershen1 has quit IRC23:52

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!