| *** catintheroof has joined #openstack-mistral | 00:20 | |
| *** bobh has joined #openstack-mistral | 00:24 | |
| *** catintheroof has quit IRC | 00:26 | |
| *** bobh has quit IRC | 00:27 | |
| *** jamielennox is now known as jamielennox|away | 00:38 | |
| *** gongysh has joined #openstack-mistral | 01:17 | |
| *** bobh has joined #openstack-mistral | 01:28 | |
| *** bobh has quit IRC | 01:32 | |
| *** jamielennox|away is now known as jamielennox | 03:22 | |
| *** zhurong has joined #openstack-mistral | 03:25 | |
| *** zhurong has quit IRC | 04:16 | |
| *** gongysh has quit IRC | 04:18 | |
| *** zhurong has joined #openstack-mistral | 04:59 | |
| *** gongysh has joined #openstack-mistral | 05:04 | |
| *** zhurong has quit IRC | 05:14 | |
| *** bobh has joined #openstack-mistral | 05:31 | |
| *** bobh has quit IRC | 05:36 | |
| *** gongysh has quit IRC | 05:58 | |
| *** jaosorior has joined #openstack-mistral | 06:04 | |
| *** gongysh has joined #openstack-mistral | 06:10 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-mistralclient master: Accept keystone session in client https://review.openstack.org/447046 | 06:13 |
|---|---|---|
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-mistralclient master: Use session from OSC plugin https://review.openstack.org/447380 | 06:23 |
| *** bobh has joined #openstack-mistral | 06:32 | |
| *** bobh has quit IRC | 06:36 | |
| *** jaosorior has quit IRC | 06:53 | |
| *** jaosorior has joined #openstack-mistral | 06:55 | |
| *** jaosorior has quit IRC | 07:14 | |
| *** jaosorior has joined #openstack-mistral | 07:15 | |
| *** jaosorior has quit IRC | 07:16 | |
| *** jaosorior has joined #openstack-mistral | 07:19 | |
| *** mgershen has quit IRC | 07:35 | |
| *** mgershen has joined #openstack-mistral | 07:39 | |
| openstackgerrit | Istvan Imre proposed openstack/mistral master: Centralize session and auth module creation from OS clients https://review.openstack.org/447399 | 07:50 |
| *** shardy has joined #openstack-mistral | 08:04 | |
| *** shardy has quit IRC | 08:04 | |
| *** shardy has joined #openstack-mistral | 08:07 | |
| jaosorior | d0ugal: hey dude, can you revisit this https://review.openstack.org/#/c/447046/ I updated the commit message. And I added this one on top of it https://review.openstack.org/#/c/447380/ | 08:09 |
| d0ugal | jaosorior: sure. | 08:09 |
| d0ugal | jaosorior: any idea what I did wrong here? https://review.openstack.org/#/c/447086/ | 08:10 |
| d0ugal | back in 20 mins | 08:10 |
| jaosorior | d0ugal: no, but I'll check it out. | 08:10 |
| jaosorior | d0ugal: for the client code, is there a reason why a deepcopy is used? isn't a copy enough? | 08:22 |
| jaosorior | for getting the "req" object, from the client's kwargs | 08:23 |
| *** bobh has joined #openstack-mistral | 08:33 | |
| *** bobh has quit IRC | 08:38 | |
| apetrich | jaosorior, if you have a minute would you mind reviewing this https://review.openstack.org/#/c/444220/ please? | 08:38 |
| *** jpich has joined #openstack-mistral | 08:52 | |
| *** jtomasek|afk is now known as jtomasek | 08:57 | |
| d0ugal | apetrich: #tripleo :) | 08:57 |
| d0ugal | apetrich: but it is on my list for this morning FWIW | 08:57 |
| apetrich | d0ugal, yeah he schooled me in that. | 08:58 |
| d0ugal | jaosorior: good question re:deepcopy- I'm not familiar with that bit of code. | 08:58 |
| d0ugal | jaosorior: https://review.openstack.org/#/c/447046 looks pretty good to me, why the -W? | 09:00 |
| jaosorior | d0ugal: so I did this work for the barbicanclient way back, and did pretty much this. And it worked. Now trying it out with the mistralclient osc plugin, there seems to be some issues with auth. for some reason the auth_ref is not being loaded or mistralclient is using an invalid auth_ref for the session. | 09:02 |
| jaosorior | so I'm figuring out where this issue comes from and I'll fix it up | 09:02 |
| jaosorior | it usually should just work | 09:02 |
| *** openstackgerrit has quit IRC | 09:02 | |
| d0ugal | jaosorior: k, thanks! We do auth a little bit differently because we don't only support keystone, maybe that is causing the difference | 09:02 |
| jaosorior | d0ugal: swift has the same requirement and it works :/ | 09:03 |
| d0ugal | oh, weird | 09:03 |
| *** openstackgerrit has joined #openstack-mistral | 09:03 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: WIP Use KeyStone sessions for making the Mistral client https://review.openstack.org/447086 | 09:03 |
| jaosorior | then again, swift has some other bits that are damn weird | 09:04 |
| jaosorior | so who knows | 09:04 |
| jaosorior | anyway | 09:04 |
| d0ugal | jaosorior: if you don't have any luck I should be able to dive in and help tomorrow or wed | 09:04 |
| d0ugal | haha | 09:04 |
| jaosorior | I'm gonna dig into it | 09:04 |
| jaosorior | lets see | 09:04 |
| d0ugal | apetrich: and you schooled me on that patch :) lol | 09:10 |
| apetrich | d0ugal, it was my first review today. I looked at it put my sunglasses on and said today is going to be a day in the park. | 09:11 |
| d0ugal | lol | 09:11 |
| therve | d0ugal, https://review.openstack.org/#/c/447086/ is just a test patch, right? | 09:26 |
| therve | Because it doesn't do the right thing at all :) | 09:26 |
| d0ugal | therve: haha | 10:08 |
| d0ugal | therve: Yeah, a total test - I was wondering if I could try out the depends-on patch this way | 10:09 |
| d0ugal | therve: but honestly I don't even know if it makes sense for Mistral to use it in this bit of code | 10:09 |
| therve | d0ugal, Yeah, heat passes the session for all client creation nowadays | 10:10 |
| d0ugal | therve: oh, maybe I should take a look at the Heat code | 10:10 |
| d0ugal | because I guess/assume Mistral should do the same | 10:10 |
| d0ugal | it doesn't for mistral, yet :) | 10:11 |
| therve | Yeah you need to have it in the context first | 10:11 |
| d0ugal | therve: this is why we need a shared library that creates clients, so I don't need to copy/paste the heat code :( | 10:12 |
| therve | d0ugal, That'd be nice. There is a lot of heat specific quirks when creating clients though | 10:23 |
| d0ugal | yeah, I guess it might be more effort than it is worth. | 10:23 |
| *** bobh has joined #openstack-mistral | 10:35 | |
| *** bobh has quit IRC | 10:39 | |
| *** jkilpatr has quit IRC | 10:41 | |
| jaosorior | d0ugal: in the mistralclient code, what are those target_ parameters? | 10:54 |
| jaosorior | d0ugal: I see there's a separate keystoneclient created just for those, but I'm not entirely sure what those are for | 10:54 |
| *** jkilpatr has joined #openstack-mistral | 10:58 | |
| d0ugal | jaosorior: it allows you to create a workflow that uses an external OpenStack | 11:03 |
| d0ugal | jaosorior: I don't think that explains it very well, doc link incoming... | 11:03 |
| jaosorior | ok | 11:05 |
| d0ugal | jaosorior: https://docs.openstack.org/developer/mistral/guides/mistralclient_guide.html#targeting-non-preconfigured-clouds | 11:06 |
| *** thrash|wknd is now known as thrash | 11:07 | |
| *** zhurong has joined #openstack-mistral | 11:17 | |
| *** bobh has joined #openstack-mistral | 11:35 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-specs master: Added the Expediated Approvals policy for reviews https://review.openstack.org/440363 | 11:37 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-specs master: Don't force policy specs into approved or implemented directories https://review.openstack.org/447454 | 11:37 |
| *** zhurong has quit IRC | 11:37 | |
| *** bobh has quit IRC | 11:40 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-mistralclient master: Use session from OSC plugin https://review.openstack.org/447380 | 12:00 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-mistralclient master: Accept keystone session in client https://review.openstack.org/447046 | 12:00 |
| jaosorior | d0ugal: the change wasn't as trivial as I thought | 12:01 |
| jaosorior | d0ugal: the problem was that I was assuming that mistralclient was using a requests session to do the CRUD operations. And it wasn't. | 12:01 |
| d0ugal | ah | 12:02 |
| d0ugal | damn | 12:02 |
| jaosorior | d0ugal: anyway, I added support for that. And tried to make it so that the old paths are still working. | 12:03 |
| *** gongysh has quit IRC | 12:06 | |
| *** dprince has joined #openstack-mistral | 12:10 | |
| *** bobh has joined #openstack-mistral | 12:15 | |
| *** bobh has quit IRC | 12:20 | |
| *** fultonj has joined #openstack-mistral | 12:32 | |
| *** shardy is now known as shardy_lunch | 12:44 | |
| *** catintheroof has joined #openstack-mistral | 12:57 | |
| *** gongysh has joined #openstack-mistral | 12:58 | |
| *** shardy_lunch is now known as shardy | 13:28 | |
| *** dprince has quit IRC | 13:37 | |
| *** histrio has joined #openstack-mistral | 13:38 | |
| *** dprince has joined #openstack-mistral | 13:39 | |
| *** clenimar has quit IRC | 13:43 | |
| *** rbrady-afk is now known as rbrady | 13:44 | |
| *** dprince has quit IRC | 14:01 | |
| *** dprince has joined #openstack-mistral | 14:03 | |
| *** dprince has quit IRC | 14:12 | |
| *** dprince has joined #openstack-mistral | 14:17 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-mistralclient master: Use session from OSC plugin https://review.openstack.org/447380 | 14:18 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-mistralclient master: Accept keystone session in client https://review.openstack.org/447046 | 14:18 |
| jaosorior | d0ugal: just tested this out in TripleO ^^ | 14:28 |
| d0ugal | jaosorior: great, I'll look shortly. | 14:54 |
| d0ugal | The Mistral meeting is in 5 minutes in #openstack-meeting-3 | 14:54 |
| d0ugal | We are an hour earlier and in a new room than last time. I probably should have sent a reminder email for this :) | 14:55 |
| *** bobh has joined #openstack-mistral | 14:59 | |
| apetrich | d0ugal, thanks. I was in the wrong room | 14:59 |
| d0ugal | rbrady, thrash ^ | 15:01 |
| *** jamielennox has quit IRC | 15:17 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-mistralclient master: Use session from OSC plugin https://review.openstack.org/447380 | 15:19 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-mistralclient master: Accept keystone session in client https://review.openstack.org/447046 | 15:19 |
| *** jkilpatr has quit IRC | 15:27 | |
| *** jkilpatr has joined #openstack-mistral | 15:28 | |
| *** chlong has joined #openstack-mistral | 15:33 | |
| *** jaosorior has quit IRC | 15:45 | |
| *** gongysh has quit IRC | 15:50 | |
| *** jaosorior has joined #openstack-mistral | 15:59 | |
| *** rbrady is now known as rbrady-afk | 16:03 | |
| *** jkilpatr has quit IRC | 16:16 | |
| *** jamielennox has joined #openstack-mistral | 16:19 | |
| *** jamielennox is now known as jamielennox|away | 16:21 | |
| *** jkilpatr has joined #openstack-mistral | 16:30 | |
| *** jaosorior has quit IRC | 16:50 | |
| *** jaosorior has joined #openstack-mistral | 16:52 | |
| *** rbrady-afk is now known as rbrady | 17:31 | |
| *** jaosorior has quit IRC | 17:35 | |
| *** brunograz has quit IRC | 17:37 | |
| *** brunograz has joined #openstack-mistral | 17:39 | |
| *** rbrady has quit IRC | 17:40 | |
| *** fultonj has left #openstack-mistral | 17:41 | |
| *** chlong has quit IRC | 17:42 | |
| *** jmlowe has quit IRC | 17:49 | |
| *** jpich has quit IRC | 17:54 | |
| *** jmlowe has joined #openstack-mistral | 18:06 | |
| *** catintheroof has quit IRC | 18:08 | |
| *** catintheroof has joined #openstack-mistral | 18:08 | |
| *** jamielennox|away is now known as jamielennox | 18:24 | |
| *** thrash is now known as thrash|biab | 19:11 | |
| *** jmlowe has quit IRC | 19:27 | |
| *** jmlowe has joined #openstack-mistral | 19:47 | |
| *** jmlowe has quit IRC | 19:55 | |
| *** dprince has quit IRC | 20:05 | |
| *** rakhmerov has quit IRC | 20:15 | |
| *** rakhmerov__ has joined #openstack-mistral | 20:15 | |
| *** zhenguo_ has joined #openstack-mistral | 20:18 | |
| *** rook has quit IRC | 20:20 | |
| *** rook has joined #openstack-mistral | 20:21 | |
| *** rook is now known as Guest45025 | 20:21 | |
| *** Guest45025 is now known as rook-ugh | 20:27 | |
| *** jkilpatr has quit IRC | 20:29 | |
| *** zhenguo has quit IRC | 20:29 | |
| *** zhenguo_ is now known as zhenguo | 20:30 | |
| *** shardy has quit IRC | 20:32 | |
| *** jkilpatr has joined #openstack-mistral | 20:32 | |
| *** shardy has joined #openstack-mistral | 20:39 | |
| *** thrash|biab is now known as thrash | 21:07 | |
| *** apetrich has quit IRC | 21:14 | |
| *** apetrich has joined #openstack-mistral | 21:15 | |
| *** shardy has quit IRC | 21:37 | |
| *** jkilpatr has quit IRC | 22:03 | |
| *** bobh has quit IRC | 22:10 | |
| *** rook-ugh is now known as rook | 22:30 | |
| *** rook is now known as Guest8383 | 22:31 | |
| *** jkilpatr has joined #openstack-mistral | 22:41 | |
| *** Guest8383 is now known as rook-ugh | 22:47 | |
| *** catintheroof has quit IRC | 23:13 | |
| *** jamielennox is now known as jamielennox|away | 23:36 | |
| *** jamielennox|away is now known as jamielennox | 23:40 | |
| *** gongysh has joined #openstack-mistral | 23:55 | |
| *** thrash is now known as thrash|g0ne | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!