*** thrash is now known as thrash|g0ne | 00:02 | |
*** catintheroof has joined #openstack-mistral | 00:03 | |
*** catintheroof has quit IRC | 00:16 | |
*** catintheroof has joined #openstack-mistral | 01:02 | |
*** catintheroof has quit IRC | 01:02 | |
*** catintheroof has joined #openstack-mistral | 01:02 | |
*** jamielennox is now known as jamielennox|away | 01:56 | |
*** jamielennox|away is now known as jamielennox | 02:01 | |
*** igormarnat has quit IRC | 02:34 | |
*** igormarnat has joined #openstack-mistral | 02:34 | |
*** catintheroof has quit IRC | 02:36 | |
*** bobh has joined #openstack-mistral | 03:09 | |
*** chlong has quit IRC | 03:25 | |
*** bobh has quit IRC | 03:32 | |
*** bobh has joined #openstack-mistral | 03:56 | |
*** bobh has quit IRC | 04:01 | |
*** gongysh has joined #openstack-mistral | 04:27 | |
*** sharatss has joined #openstack-mistral | 05:54 | |
openstackgerrit | Sharat Sharma proposed openstack/mistral master: Added style enfore checks for assert statements https://review.openstack.org/431427 | 06:18 |
---|---|---|
openstackgerrit | Sharat Sharma proposed openstack/mistral master: Added style enfore checks for assert statements https://review.openstack.org/431427 | 06:19 |
*** zhurong has joined #openstack-mistral | 06:21 | |
openstackgerrit | Merged openstack/mistral master: Updated from global requirements https://review.openstack.org/446670 | 06:56 |
openstackgerrit | Sharat Sharma proposed openstack/mistral master: Added style enfore checks for assert statements https://review.openstack.org/431427 | 07:03 |
*** gongysh has quit IRC | 07:07 | |
*** gongysh has joined #openstack-mistral | 07:10 | |
*** jaosorior has joined #openstack-mistral | 07:16 | |
openstackgerrit | Sharat Sharma proposed openstack/mistral master: Added style enfore checks for assert statements https://review.openstack.org/431427 | 07:22 |
rakhmerov | d0ugal, ddeja, rbrady-afk, mgershen1, kong: could you guys take a look (again) at https://review.openstack.org/#/c/414508/? I really want to solve this issue in the current cycle (ideally in Pike-1) but the discussion got stuck some time ago. | 07:31 |
rakhmerov | d0ugal, rbrady-afk: btw, this is also related with actions and we may need to account for that when designing actions api | 07:32 |
d0ugal | rakhmerov: sure, looking. | 07:56 |
*** apetrich has quit IRC | 08:21 | |
*** zhurong has quit IRC | 08:27 | |
*** apetrich has joined #openstack-mistral | 08:33 | |
*** amoralej|off is now known as amoralej | 08:38 | |
*** shardy has joined #openstack-mistral | 09:01 | |
*** tuan_ has joined #openstack-mistral | 10:16 | |
openstackgerrit | Sharat Sharma proposed openstack/mistral-dashboard master: Added test for mistral-dashboard cron_triggers https://review.openstack.org/446945 | 10:26 |
*** sharatss has quit IRC | 10:39 | |
*** sharatss has joined #openstack-mistral | 10:40 | |
*** jkilpatr has quit IRC | 10:53 | |
*** jaosorior has quit IRC | 10:55 | |
*** gongysh has quit IRC | 10:56 | |
*** jaosorior has joined #openstack-mistral | 10:56 | |
d0ugal | rakhmerov: what is params used for now? | 11:01 |
d0ugal | I have only used workflow input | 11:02 |
d0ugal | I don't think there should be any impact on actions | 11:05 |
d0ugal | It could be added to the context so tasks know which region they are being executed in | 11:05 |
*** zhurong has joined #openstack-mistral | 11:12 | |
rakhmerov | d0ugal: 'params' is used to pass additional meta variables as workflow environment ('env') or, for example, 'task_name' in case of reverse workflows | 11:25 |
rakhmerov | well, since this is about actions I thought that we might want to come up with some ideas, for example, on how to pass default action arguments | 11:25 |
rakhmerov | in case if we don't want to specify region=<% ... %> for all actions | 11:26 |
*** jkilpatr has joined #openstack-mistral | 11:26 | |
rakhmerov | d0ugal: anyway, I'm not sure myself, it's just my intuition that said I should attract your attention to that | 11:27 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral-specs master: Add 'Advanced publishing' spec instead of 'Global context' spec https://review.openstack.org/446960 | 11:36 |
d0ugal | rakhmerov: ohhh! so params is how you use the expression function env()!? | 11:36 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral-specs master: Add 'Advanced publishing' spec instead of 'Global context' spec https://review.openstack.org/446960 | 11:36 |
rakhmerov | d0ugal: I'd say not "how" but "where it is specified" | 11:37 |
rakhmerov | I mean not the function itself but rather environment | 11:37 |
rakhmerov | yes, it comes within "params' | 11:38 |
d0ugal | right | 11:39 |
d0ugal | amazing :) | 11:39 |
d0ugal | I had tried to understand that before but failed | 11:39 |
rakhmerov | why? :) | 11:39 |
rakhmerov | ooh | 11:39 |
rakhmerov | our bad.. | 11:39 |
rakhmerov | as usually, it might not be well documented | 11:39 |
rakhmerov | or not documented at all | 11:39 |
rakhmerov | the interesting thing about documenting environments though is that they are not really a part of DSL | 11:40 |
rakhmerov | and not a part of API :) | 11:40 |
d0ugal | yeah, but now I understand more I can try and document it at some point | 11:40 |
rakhmerov | yeah, I'm just thinking about WHERE it should be documented.. | 11:41 |
d0ugal | good question :) | 11:41 |
d0ugal | Not in the dsl docs, that file is huggge | 11:41 |
rakhmerov | I think we're missing some guid that explains how to run workflows, how to pass input and environments etc. Or it's probably in the docs for the client but that's also not sufficient because, for example, there's the function "env()" that is part of DSL | 11:42 |
rakhmerov | yes, right, only function 'env()' I think should be there | 11:42 |
rakhmerov | there rest is somewhere else | 11:42 |
rakhmerov | d0ugal: on a different topic, remember that global workflow context thing? | 11:43 |
rakhmerov | We realized that there's a better alternative to the syntax proposed before (and that was already accepted and approved) | 11:43 |
rakhmerov | take a look at https://review.openstack.org/#/c/446960/ once you have time | 11:43 |
rakhmerov | I hope you should like it :) | 11:44 |
rakhmerov | I've already implemented 70% of it and I and my boss realized that we're taking the wrong path.. | 11:44 |
d0ugal | heh, cool | 11:47 |
d0ugal | it is always better to find out sooner than later :-D | 11:47 |
d0ugal | I'll check it out today, thanks | 11:47 |
rakhmerov | ok | 11:48 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral-specs master: Add 'Advanced publishing' spec instead of 'Global context' spec https://review.openstack.org/446960 | 11:49 |
*** jaosorior is now known as jaosorior_brb | 12:01 | |
*** shardy is now known as shardy_lunch | 12:04 | |
*** dprince has joined #openstack-mistral | 12:12 | |
*** sharatss has quit IRC | 12:39 | |
*** thrash|g0ne is now known as thrash | 12:49 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral-specs master: Add 'Advanced publishing' spec instead of 'Global context' spec https://review.openstack.org/446960 | 12:56 |
*** tuan_ has quit IRC | 13:02 | |
*** tuan_ has joined #openstack-mistral | 13:07 | |
*** catintheroof has joined #openstack-mistral | 13:10 | |
*** catintheroof has quit IRC | 13:10 | |
*** catintheroof has joined #openstack-mistral | 13:10 | |
*** fultonj has joined #openstack-mistral | 13:14 | |
*** rbrady-afk is now known as rbrady | 13:22 | |
openstackgerrit | Dougal Matthews proposed openstack/mistral-specs master: [WIP] Mistral Actions Library https://review.openstack.org/446996 | 13:28 |
*** chlong has joined #openstack-mistral | 13:33 | |
*** weshay_pto is now known as weshay_sick | 13:40 | |
*** jaosorior_brb is now known as jaosorior | 13:50 | |
*** shardy_lunch is now known as shardy | 13:56 | |
*** zhurong has quit IRC | 13:56 | |
*** tuan_ has quit IRC | 13:57 | |
openstackgerrit | Dougal Matthews proposed openstack/mistral-specs master: [WIP] Mistral Actions Library https://review.openstack.org/446996 | 14:01 |
d0ugal | thrash, rbrady, apetrich ^ updated as promised :) | 14:01 |
thrash | d0ugal: ack | 14:01 |
rbrady | d0ugal: ack | 14:02 |
apetrich | d0ugal, ack | 14:02 |
* apetrich is not a combo breaker | 14:02 | |
d0ugal | ack | 14:02 |
d0ugal | apetrich: but you did use "," :P | 14:02 |
* apetrich is a combo breaker | 14:03 | |
*** gongysh has joined #openstack-mistral | 14:06 | |
*** bobh has joined #openstack-mistral | 14:07 | |
*** bobh has quit IRC | 14:07 | |
*** bobh has joined #openstack-mistral | 14:07 | |
thrash | d0ugal: got some comments for you | 14:11 |
d0ugal | thrash: Great. Thanks. | 14:11 |
thrash | d0ugal: and there's a python failure??? :| | 14:11 |
d0ugal | orly | 14:12 |
d0ugal | It worked for me :P | 14:12 |
d0ugal | AssertionError: False is not true : specs/pike/approved/mistral-extra.rst:60: Line limited to a maximum of 79 characters. | 14:12 |
d0ugal | I must have a long ling. | 14:12 |
d0ugal | line | 14:12 |
thrash | d0ugal: the url? | 14:15 |
thrash | that seems to be the only one I see. | 14:15 |
d0ugal | thrash: nah, line 60 | 14:15 |
thrash | ah | 14:15 |
d0ugal | I must have forgotten to re-wrap after an edit | 14:16 |
d0ugal | thrash: should the std.* actions move to mistral-lib? | 14:19 |
thrash | d0ugal: that's a good question. 1) I wasn't sure if that had already been decided 2) I haven't formed an opinion on it yet | 14:20 |
d0ugal | same here :) | 14:20 |
d0ugal | Unless we expect people to inherit from them I don't see a reason to move them | 14:21 |
thrash | I'm thinking no... But I don't know why yet. :D | 14:21 |
thrash | are the std.* actions added automatically by mistral to the db, or do they happen in popuplate? | 14:21 |
d0ugal | I assume they happen via populate | 14:22 |
d0ugal | but I am not sure. | 14:22 |
d0ugal | They are registered in the normal way. https://github.com/openstack/mistral/blob/master/setup.cfg#L59-L71 | 14:22 |
thrash | not that it makes a whole lot of difference... | 14:22 |
d0ugal | OpenStack actions get there by magic :) | 14:22 |
thrash | hehe | 14:22 |
thrash | So... My gut is leave them in mistral proper. | 14:23 |
d0ugal | agreed | 14:23 |
*** chlong has quit IRC | 14:23 | |
openstackgerrit | Dougal Matthews proposed openstack/mistral-specs master: Mistral Actions Library https://review.openstack.org/446996 | 14:27 |
d0ugal | Updated, they were useful. Thanks! | 14:27 |
*** amoralej is now known as amoralej|lunch | 14:34 | |
*** gongysh has quit IRC | 14:39 | |
*** dprince has quit IRC | 14:54 | |
*** dprince has joined #openstack-mistral | 15:12 | |
*** amoralej|lunch is now known as amoralej | 15:13 | |
jaosorior | Hey guys, any chance there's a mistralclient release any time soon? | 15:57 |
*** vishwanathj has joined #openstack-mistral | 16:03 | |
openstackgerrit | Juan Antonio Osorio Robles proposed openstack/python-mistralclient master: Accept keystone session in client https://review.openstack.org/447046 | 16:04 |
*** thrash is now known as thrash|biab | 16:04 | |
*** rbrady is now known as rbrady-food | 16:13 | |
*** vishwanathj has quit IRC | 16:17 | |
*** thrash|biab is now known as thrash | 16:26 | |
*** jaosorior has quit IRC | 16:55 | |
*** bobh has quit IRC | 17:23 | |
*** rbrady-food is now known as rbrady | 17:27 | |
*** tbh has joined #openstack-mistral | 17:47 | |
tbh | Hi, I am trying to instantiate mistral client object using keystoneauth1.session, but it throws "Failed to validate access token" error | 17:49 |
tbh | can we pass session to mistral_client.client()? | 17:50 |
*** toure is now known as toure|biab | 17:51 | |
d0ugal | tbh: can you show me the error or how you are trying to create the instance? | 17:52 |
d0ugal | tbh: is this related? https://review.openstack.org/#/c/447046/ | 17:52 |
d0ugal | It seems there might be a new problem with two people looking at the same thing within an hour :) | 17:52 |
tbh | d0ugal, http://paste.openstack.org/show/603174/ | 17:53 |
tbh | d0ugal, yes I think that's the patch I am looking for | 17:54 |
d0ugal | tbh: is this something new in keystone? | 17:55 |
d0ugal | tbh: unfortunately I don't think any other cores will be around to review that and make a release today | 17:56 |
*** thrash is now known as thrash|brb | 17:57 | |
tbh | d0ugal, not sure, it is easy to have sessions | 17:57 |
tbh | d0ugal, np, thanks for the help | 17:57 |
d0ugal | tbh: I'll make sure there is a new release early next week - it seems like sessions are better and it is easy for us to add it :) | 17:58 |
openstackgerrit | Dougal Matthews proposed openstack/mistral master: WIP Use KeyStone sessions for making the Mistral client https://review.openstack.org/447086 | 18:05 |
tbh | d0ugal, sure, thanks! | 18:07 |
openstackgerrit | Dougal Matthews proposed openstack/mistral master: Use LOG.exception when adding an OpenStack action fails https://review.openstack.org/412430 | 18:08 |
*** bobh has joined #openstack-mistral | 18:23 | |
*** bobh has quit IRC | 18:28 | |
*** bobh has joined #openstack-mistral | 18:38 | |
*** joanna is now known as joanna_lunch | 18:50 | |
*** thrash|brb is now known as thrash | 18:56 | |
*** catintheroof has quit IRC | 18:59 | |
*** toure|biab is now known as toure | 19:04 | |
*** aspiers has quit IRC | 19:06 | |
*** catintheroof has joined #openstack-mistral | 19:06 | |
*** aspiers has joined #openstack-mistral | 19:07 | |
*** amoralej is now known as amoralej|off | 19:09 | |
*** tbh has quit IRC | 19:35 | |
*** joanna_lunch is now known as joanna | 19:41 | |
*** shardy has quit IRC | 19:44 | |
*** rbrady is now known as rbrady-afk | 19:48 | |
*** d0ugal has quit IRC | 19:56 | |
*** d0ugal has joined #openstack-mistral | 20:13 | |
*** dprince has quit IRC | 20:46 | |
openstackgerrit | Toure Dunnon proposed openstack/mistral-specs master: [WIP] Workflow Error Analysis https://review.openstack.org/443217 | 21:04 |
*** thrash is now known as thrash|wknd | 21:06 | |
*** jkilpatr has quit IRC | 21:07 | |
*** catintheroof has quit IRC | 21:16 | |
*** fultonj has quit IRC | 21:47 | |
*** bobh has quit IRC | 22:09 | |
*** gongysh has joined #openstack-mistral | 22:40 | |
*** bobh has joined #openstack-mistral | 23:18 | |
*** bobh has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!