Friday, 2017-03-17

*** thrash is now known as thrash|g0ne00:02
*** catintheroof has joined #openstack-mistral00:03
*** catintheroof has quit IRC00:16
*** catintheroof has joined #openstack-mistral01:02
*** catintheroof has quit IRC01:02
*** catintheroof has joined #openstack-mistral01:02
*** jamielennox is now known as jamielennox|away01:56
*** jamielennox|away is now known as jamielennox02:01
*** igormarnat has quit IRC02:34
*** igormarnat has joined #openstack-mistral02:34
*** catintheroof has quit IRC02:36
*** bobh has joined #openstack-mistral03:09
*** chlong has quit IRC03:25
*** bobh has quit IRC03:32
*** bobh has joined #openstack-mistral03:56
*** bobh has quit IRC04:01
*** gongysh has joined #openstack-mistral04:27
*** sharatss has joined #openstack-mistral05:54
openstackgerritSharat Sharma proposed openstack/mistral master: Added style enfore checks for assert statements  https://review.openstack.org/43142706:18
openstackgerritSharat Sharma proposed openstack/mistral master: Added style enfore checks for assert statements  https://review.openstack.org/43142706:19
*** zhurong has joined #openstack-mistral06:21
openstackgerritMerged openstack/mistral master: Updated from global requirements  https://review.openstack.org/44667006:56
openstackgerritSharat Sharma proposed openstack/mistral master: Added style enfore checks for assert statements  https://review.openstack.org/43142707:03
*** gongysh has quit IRC07:07
*** gongysh has joined #openstack-mistral07:10
*** jaosorior has joined #openstack-mistral07:16
openstackgerritSharat Sharma proposed openstack/mistral master: Added style enfore checks for assert statements  https://review.openstack.org/43142707:22
rakhmerovd0ugal, ddeja, rbrady-afk, mgershen1, kong: could you guys take a look (again) at https://review.openstack.org/#/c/414508/? I really want to solve this issue in the current cycle (ideally in Pike-1) but the discussion got stuck some time ago.07:31
rakhmerovd0ugal, rbrady-afk: btw, this is also related with actions and we may need to account for that when designing actions api07:32
d0ugalrakhmerov: sure, looking.07:56
*** apetrich has quit IRC08:21
*** zhurong has quit IRC08:27
*** apetrich has joined #openstack-mistral08:33
*** amoralej|off is now known as amoralej08:38
*** shardy has joined #openstack-mistral09:01
*** tuan_ has joined #openstack-mistral10:16
openstackgerritSharat Sharma proposed openstack/mistral-dashboard master: Added test for mistral-dashboard cron_triggers  https://review.openstack.org/44694510:26
*** sharatss has quit IRC10:39
*** sharatss has joined #openstack-mistral10:40
*** jkilpatr has quit IRC10:53
*** jaosorior has quit IRC10:55
*** gongysh has quit IRC10:56
*** jaosorior has joined #openstack-mistral10:56
d0ugalrakhmerov: what is params used for now?11:01
d0ugalI have only used workflow input11:02
d0ugalI don't think there should be any impact on actions11:05
d0ugalIt could be added to the context so tasks know which region they are being executed in11:05
*** zhurong has joined #openstack-mistral11:12
rakhmerovd0ugal: 'params' is used to pass additional meta variables as workflow environment ('env') or, for example, 'task_name' in case of reverse workflows11:25
rakhmerovwell, since this is about actions I thought that we might want to come up with some ideas, for example, on how to pass default action arguments11:25
rakhmerovin case if we don't want to specify region=<% ... %> for all actions11:26
*** jkilpatr has joined #openstack-mistral11:26
rakhmerovd0ugal: anyway, I'm not sure myself, it's just my intuition that said I should attract your attention to that11:27
openstackgerritRenat Akhmerov proposed openstack/mistral-specs master: Add 'Advanced publishing' spec instead of 'Global context' spec  https://review.openstack.org/44696011:36
d0ugalrakhmerov: ohhh! so params is how you use the expression function env()!?11:36
openstackgerritRenat Akhmerov proposed openstack/mistral-specs master: Add 'Advanced publishing' spec instead of 'Global context' spec  https://review.openstack.org/44696011:36
rakhmerovd0ugal: I'd say not "how" but "where it is specified"11:37
rakhmerovI mean not the function itself but rather environment11:37
rakhmerovyes, it comes within "params'11:38
d0ugalright11:39
d0ugalamazing :)11:39
d0ugalI had tried to understand that before but failed11:39
rakhmerovwhy? :)11:39
rakhmerovooh11:39
rakhmerovour bad..11:39
rakhmerovas usually, it might not be well documented11:39
rakhmerovor not documented at all11:39
rakhmerovthe interesting thing about documenting environments though is that they are not really a part of DSL11:40
rakhmerovand not a part of API :)11:40
d0ugalyeah, but now I understand more I can try and document it at some point11:40
rakhmerovyeah, I'm just thinking about WHERE it should be documented..11:41
d0ugalgood question :)11:41
d0ugalNot in the dsl docs, that file is huggge11:41
rakhmerovI think we're missing some guid that explains how to run workflows, how to pass input and environments etc. Or it's probably in the docs for the client but that's also not sufficient because, for example, there's the function "env()" that is part of DSL11:42
rakhmerovyes, right, only function 'env()' I think should be there11:42
rakhmerovthere rest is somewhere else11:42
rakhmerovd0ugal: on a different topic, remember that global workflow context thing?11:43
rakhmerovWe realized that there's a better alternative to the syntax proposed before (and that was already accepted and approved)11:43
rakhmerovtake a look at https://review.openstack.org/#/c/446960/ once you have time11:43
rakhmerovI hope you should like it :)11:44
rakhmerovI've already implemented 70% of it and I and my boss realized that we're taking the wrong path..11:44
d0ugalheh, cool11:47
d0ugalit is always better to find out sooner than later :-D11:47
d0ugalI'll check it out today, thanks11:47
rakhmerovok11:48
openstackgerritRenat Akhmerov proposed openstack/mistral-specs master: Add 'Advanced publishing' spec instead of 'Global context' spec  https://review.openstack.org/44696011:49
*** jaosorior is now known as jaosorior_brb12:01
*** shardy is now known as shardy_lunch12:04
*** dprince has joined #openstack-mistral12:12
*** sharatss has quit IRC12:39
*** thrash|g0ne is now known as thrash12:49
openstackgerritRenat Akhmerov proposed openstack/mistral-specs master: Add 'Advanced publishing' spec instead of 'Global context' spec  https://review.openstack.org/44696012:56
*** tuan_ has quit IRC13:02
*** tuan_ has joined #openstack-mistral13:07
*** catintheroof has joined #openstack-mistral13:10
*** catintheroof has quit IRC13:10
*** catintheroof has joined #openstack-mistral13:10
*** fultonj has joined #openstack-mistral13:14
*** rbrady-afk is now known as rbrady13:22
openstackgerritDougal Matthews proposed openstack/mistral-specs master: [WIP] Mistral Actions Library  https://review.openstack.org/44699613:28
*** chlong has joined #openstack-mistral13:33
*** weshay_pto is now known as weshay_sick13:40
*** jaosorior_brb is now known as jaosorior13:50
*** shardy_lunch is now known as shardy13:56
*** zhurong has quit IRC13:56
*** tuan_ has quit IRC13:57
openstackgerritDougal Matthews proposed openstack/mistral-specs master: [WIP] Mistral Actions Library  https://review.openstack.org/44699614:01
d0ugalthrash, rbrady, apetrich ^ updated as promised :)14:01
thrashd0ugal: ack14:01
rbradyd0ugal: ack14:02
apetrichd0ugal, ack14:02
* apetrich is not a combo breaker14:02
d0ugalack14:02
d0ugalapetrich: but you did use "," :P14:02
* apetrich is a combo breaker14:03
*** gongysh has joined #openstack-mistral14:06
*** bobh has joined #openstack-mistral14:07
*** bobh has quit IRC14:07
*** bobh has joined #openstack-mistral14:07
thrashd0ugal: got some comments for you14:11
d0ugalthrash: Great. Thanks.14:11
thrashd0ugal: and there's a python failure??? :|14:11
d0ugalorly14:12
d0ugalIt worked for me :P14:12
d0ugalAssertionError: False is not true : specs/pike/approved/mistral-extra.rst:60: Line limited to a maximum of 79 characters.14:12
d0ugalI must have a long ling.14:12
d0ugalline14:12
thrashd0ugal: the url?14:15
thrashthat seems to be the only one I see.14:15
d0ugalthrash: nah, line 6014:15
thrashah14:15
d0ugalI must have forgotten to re-wrap after an edit14:16
d0ugalthrash: should the std.* actions move to mistral-lib?14:19
thrashd0ugal: that's a good question. 1) I wasn't sure if that had already been decided 2) I haven't formed an opinion on it yet14:20
d0ugalsame here :)14:20
d0ugalUnless we expect people to inherit from them I don't see a reason to move them14:21
thrashI'm thinking no... But I don't know why yet. :D14:21
thrashare the std.* actions added automatically by mistral to the db, or do they happen in popuplate?14:21
d0ugalI assume they happen via populate14:22
d0ugalbut I am not sure.14:22
d0ugalThey are registered in the normal way. https://github.com/openstack/mistral/blob/master/setup.cfg#L59-L7114:22
thrashnot that it makes a whole lot of difference...14:22
d0ugalOpenStack actions get there by magic :)14:22
thrashhehe14:22
thrashSo... My gut is leave them in mistral proper.14:23
d0ugalagreed14:23
*** chlong has quit IRC14:23
openstackgerritDougal Matthews proposed openstack/mistral-specs master: Mistral Actions Library  https://review.openstack.org/44699614:27
d0ugalUpdated, they were useful. Thanks!14:27
*** amoralej is now known as amoralej|lunch14:34
*** gongysh has quit IRC14:39
*** dprince has quit IRC14:54
*** dprince has joined #openstack-mistral15:12
*** amoralej|lunch is now known as amoralej15:13
jaosoriorHey guys, any chance there's a mistralclient release any time soon?15:57
*** vishwanathj has joined #openstack-mistral16:03
openstackgerritJuan Antonio Osorio Robles proposed openstack/python-mistralclient master: Accept keystone session in client  https://review.openstack.org/44704616:04
*** thrash is now known as thrash|biab16:04
*** rbrady is now known as rbrady-food16:13
*** vishwanathj has quit IRC16:17
*** thrash|biab is now known as thrash16:26
*** jaosorior has quit IRC16:55
*** bobh has quit IRC17:23
*** rbrady-food is now known as rbrady17:27
*** tbh has joined #openstack-mistral17:47
tbhHi, I am trying to instantiate mistral client object using keystoneauth1.session, but it throws "Failed to validate access token" error17:49
tbhcan we pass session to mistral_client.client()?17:50
*** toure is now known as toure|biab17:51
d0ugaltbh: can you show me the error or how you are trying to create the instance?17:52
d0ugaltbh: is this related? https://review.openstack.org/#/c/447046/17:52
d0ugalIt seems there might be a new problem with two people looking at the same thing within an hour :)17:52
tbhd0ugal, http://paste.openstack.org/show/603174/17:53
tbhd0ugal, yes I think that's the patch I am looking for17:54
d0ugaltbh: is this something new in keystone?17:55
d0ugaltbh: unfortunately I don't think any other cores will be around to review that and make a release today17:56
*** thrash is now known as thrash|brb17:57
tbhd0ugal, not sure, it is easy to have sessions17:57
tbhd0ugal, np, thanks for the help17:57
d0ugaltbh: I'll make sure there is a new release early next week - it seems like sessions are better and it is easy for us to add it :)17:58
openstackgerritDougal Matthews proposed openstack/mistral master: WIP Use KeyStone sessions for making the Mistral client  https://review.openstack.org/44708618:05
tbhd0ugal, sure, thanks!18:07
openstackgerritDougal Matthews proposed openstack/mistral master: Use LOG.exception when adding an OpenStack action fails  https://review.openstack.org/41243018:08
*** bobh has joined #openstack-mistral18:23
*** bobh has quit IRC18:28
*** bobh has joined #openstack-mistral18:38
*** joanna is now known as joanna_lunch18:50
*** thrash|brb is now known as thrash18:56
*** catintheroof has quit IRC18:59
*** toure|biab is now known as toure19:04
*** aspiers has quit IRC19:06
*** catintheroof has joined #openstack-mistral19:06
*** aspiers has joined #openstack-mistral19:07
*** amoralej is now known as amoralej|off19:09
*** tbh has quit IRC19:35
*** joanna_lunch is now known as joanna19:41
*** shardy has quit IRC19:44
*** rbrady is now known as rbrady-afk19:48
*** d0ugal has quit IRC19:56
*** d0ugal has joined #openstack-mistral20:13
*** dprince has quit IRC20:46
openstackgerritToure Dunnon proposed openstack/mistral-specs master: [WIP] Workflow Error Analysis  https://review.openstack.org/44321721:04
*** thrash is now known as thrash|wknd21:06
*** jkilpatr has quit IRC21:07
*** catintheroof has quit IRC21:16
*** fultonj has quit IRC21:47
*** bobh has quit IRC22:09
*** gongysh has joined #openstack-mistral22:40
*** bobh has joined #openstack-mistral23:18
*** bobh has quit IRC23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!