| *** bobh has quit IRC | 00:00 | |
| *** bobh has joined #openstack-mistral | 00:18 | |
| *** jamielennox is now known as jamielennox|away | 00:24 | |
| *** catintheroof has joined #openstack-mistral | 00:36 | |
| *** catintheroof has quit IRC | 00:37 | |
| *** jkilpatr has quit IRC | 00:45 | |
| *** jamielennox|away is now known as jamielennox | 00:50 | |
| *** toure|gone has quit IRC | 01:20 | |
| *** toure has joined #openstack-mistral | 01:21 | |
| *** ChatSharp has joined #openstack-mistral | 01:36 | |
| *** ChatSharp has quit IRC | 01:38 | |
| *** gongysh has joined #openstack-mistral | 01:41 | |
| *** ChatSharp has joined #openstack-mistral | 01:55 | |
| *** ChatSharp has left #openstack-mistral | 01:58 | |
| *** openstackgerrit has joined #openstack-mistral | 02:31 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mistral-dashboard master: Replace github with git.openstack.org https://review.openstack.org/432816 | 02:31 |
|---|---|---|
| openstackgerrit | Zhenguo Niu proposed openstack/mistral-dashboard master: Fix 'tox -ereleasenotes' Error https://review.openstack.org/432827 | 03:26 |
| *** bobh has quit IRC | 03:28 | |
| *** bobh has joined #openstack-mistral | 03:34 | |
| *** bobh has quit IRC | 03:38 | |
| *** bobh has joined #openstack-mistral | 03:39 | |
| *** gongysh has quit IRC | 03:39 | |
| openstackgerrit | Merged openstack/python-mistralclient master: Updated from global requirements https://review.openstack.org/432676 | 03:39 |
| *** bobh has quit IRC | 03:43 | |
| *** bobh has joined #openstack-mistral | 03:46 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mistral-dashboard master: Fix 'tox -ereleasenotes' Error https://review.openstack.org/432827 | 03:49 |
| *** bobh has quit IRC | 04:07 | |
| *** openstackgerrit has quit IRC | 04:32 | |
| *** openstackgerrit has joined #openstack-mistral | 04:38 | |
| openstackgerrit | Merged openstack/mistral master: Updated from global requirements https://review.openstack.org/432618 | 04:38 |
| rakhmerov | kong: hi | 04:53 |
| rakhmerov | please ping me when you're online | 04:53 |
| *** jaosorior has joined #openstack-mistral | 05:28 | |
| *** jrist has joined #openstack-mistral | 06:04 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mistral-dashboard master: Reorganize docs https://review.openstack.org/432873 | 06:45 |
| openstackgerrit | Zhenguo Niu proposed openstack/mistral-dashboard master: Update .gitignore https://review.openstack.org/432879 | 06:56 |
| rakhmerov | ddeja: hi Dawid | 07:36 |
| rakhmerov | you here? | 07:36 |
| rakhmerov | ddeja: I'd like to ask you to fill info in the PTG etherpad about Kombu RPC | 07:49 |
| rakhmerov | https://etherpad.openstack.org/p/mistral-ptg-pike | 07:49 |
| rakhmerov | #3 Kombu RPC (w/o oslo.messaging) | 07:50 |
| rakhmerov | similar way to the first two | 07:50 |
| ddeja | rakhmerov: Ok, sure | 07:59 |
| rakhmerov | thanks | 07:59 |
| rakhmerov | ddeja: another topic, do you think that our joint patch is now ready for review? | 07:59 |
| ddeja | rakhmerov: I think so | 08:00 |
| ddeja | all the tests but coverage pass | 08:00 |
| ddeja | we can ask for reviews and add tests in the same time | 08:00 |
| ddeja | and it would be good to run gate against kombu 1 or 2 times more before we can merge it | 08:01 |
| ddeja | i needed to recheck twice to get it green | 08:01 |
| rakhmerov | hm.. I see | 08:01 |
| rakhmerov | ok | 08:01 |
| ddeja | the failures looked like random conectivity lost/message lost on rabbit | 08:01 |
| ddeja | but we better be sure | 08:01 |
| rakhmerov | whey do they get lost? | 08:01 |
| rakhmerov | d0ugal: hi | 08:02 |
| rakhmerov | are you back with us? :) | 08:02 |
| *** pcastets has joined #openstack-mistral | 08:02 | |
| ddeja | rabbit doesn't guarantee that the messege would be deliver | 08:02 |
| ddeja | or, ok, it does gauratnee | 08:02 |
| ddeja | but in case of some timeout sets, like in mistral | 08:02 |
| ddeja | we can miss some messages | 08:02 |
| ddeja | and it looks like it's what happend in that case | 08:03 |
| ddeja | rakhmerov: it's 8 a.m. in d0ugal's timezone, he may didn't awake yet ;) | 08:03 |
| rakhmerov | ok :) | 08:04 |
| rakhmerov | ddeja: on timeouts, can we just increase our timouts? | 08:04 |
| ddeja | we can, but I think one minute is OK | 08:05 |
| ddeja | if we change it, it would take too much time in some cases, when we really expect the time-out | 08:05 |
| ddeja | or, we can just change it for this gate | 08:06 |
| ddeja | or maybe I was really un-lucky with those 2 tests :) | 08:06 |
| rakhmerov | I see | 08:21 |
| rakhmerov | we need to experiment with it | 08:21 |
| rakhmerov | ddeja: please try to fill the PTG topic bye the end of the day | 08:22 |
| d0ugal | rakhmerov, ddeja: I am back, and just awake! | 08:22 |
| rakhmerov | by.. | 08:22 |
| rakhmerov | d0ugal: welcome back! | 08:22 |
| d0ugal | Thanks :) | 08:22 |
| rakhmerov | had a good rest? | 08:22 |
| d0ugal | not really, I was skiing :) | 08:22 |
| d0ugal | but I had lots of fun | 08:22 |
| rakhmerov | isn't it a rest? :) | 08:23 |
| rakhmerov | skiing | 08:23 |
| rakhmerov | well, mental rest at least | 08:23 |
| d0ugal | Indeed | 08:23 |
| rakhmerov | ok | 08:23 |
| rakhmerov | good | 08:23 |
| d0ugal | Did I miss anything interesting? | 08:23 |
| rakhmerov | d0ugal: yeah, this patch: https://review.openstack.org/#/c/429643/ | 08:24 |
| rakhmerov | :) | 08:24 |
| rakhmerov | please review it once you have time today | 08:24 |
| d0ugal | ok | 08:24 |
| rakhmerov | we worked on it together with ddeja | 08:24 |
| d0ugal | After coffee I'll take a look | 08:24 |
| rakhmerov | (not sure if we're ok to vote too now) | 08:24 |
| rakhmerov | ddeja, d0ugal: one more patch to look at: https://review.openstack.org/#/c/432215/ | 08:25 |
| rakhmerov | pretty simple but an important one | 08:25 |
| rakhmerov | ddeja: I already filled some info on the topic according with my understanding. Please validate it and fix if needed | 08:29 |
| ddeja | rakhmerov: sure :) | 08:30 |
| *** ChatSharp has joined #openstack-mistral | 08:32 | |
| *** ChatSharp has quit IRC | 08:34 | |
| *** jpich has joined #openstack-mistral | 08:45 | |
| *** shardy has joined #openstack-mistral | 09:00 | |
| *** gongysh has joined #openstack-mistral | 09:10 | |
| rakhmerov | d0ugal: please also take a look at https://etherpad.openstack.org/p/mistral-ptg-pike lines 169-195 | 09:16 |
| rakhmerov | I'm adding more details on Actions API and trying to recall all issues that we discussed before | 09:16 |
| rakhmerov | if you remember more feel free to add | 09:16 |
| *** shardy has quit IRC | 09:24 | |
| *** jamielennox is now known as jamielennox|away | 09:48 | |
| d0ugal | rakhmerov: will do :) | 09:51 |
| * d0ugal is almost awake now | 09:51 | |
| rakhmerov | cool | 09:52 |
| rakhmerov | I envy you ) | 09:52 |
| d0ugal | lol | 09:52 |
| d0ugal | rakhmerov: you wouldn't if you seen my inbox :( | 09:52 |
| rakhmerov | haha :) | 09:53 |
| rakhmerov | np, I have my own | 09:53 |
| rakhmerov | it's also scary | 09:53 |
| *** jamielennox|away is now known as jamielennox | 10:24 | |
| *** ChatSharp has joined #openstack-mistral | 10:35 | |
| *** ChatSharp has quit IRC | 10:38 | |
| *** ChatSharp has joined #openstack-mistral | 10:48 | |
| *** ChatSharp has quit IRC | 10:50 | |
| *** ChatSharp has joined #openstack-mistral | 11:05 | |
| *** ChatSharp has quit IRC | 11:07 | |
| *** shardy has joined #openstack-mistral | 11:16 | |
| *** openstackgerrit has quit IRC | 11:18 | |
| *** ChatSharp has joined #openstack-mistral | 11:18 | |
| *** ChatSharp has quit IRC | 11:21 | |
| *** ChatSharp has joined #openstack-mistral | 11:27 | |
| *** ChatSharp has left #openstack-mistral | 11:30 | |
| *** openstackgerrit has joined #openstack-mistral | 11:43 | |
| openstackgerrit | Merged openstack/mistral master: Remove '__task_execution' from task outbound context https://review.openstack.org/432215 | 11:43 |
| *** jkilpatr has joined #openstack-mistral | 11:51 | |
| *** gongysh has quit IRC | 11:52 | |
| *** pcastets has quit IRC | 11:55 | |
| *** thrash|g0ne is now known as thrash | 11:56 | |
| ddeja | rakhmerov: I've added some piecec to #3 in etherepad | 12:17 |
| ddeja | pieces* | 12:17 |
| rakhmerov | ok, thanks | 12:18 |
| *** catintheroof has joined #openstack-mistral | 12:41 | |
| ddeja | rakhmerov: about the failing coverage job... | 12:59 |
| ddeja | do you know how it is generated? | 12:59 |
| ddeja | for example, this file: mistral/engine/rpc_backend/kombu/kombu_listener.py have a lot of tests | 12:59 |
| ddeja | but the coverage report says it's not tested at all | 13:00 |
| *** pcastets has joined #openstack-mistral | 13:00 | |
| *** bobh has joined #openstack-mistral | 13:05 | |
| *** bobh has quit IRC | 13:05 | |
| *** bobh has joined #openstack-mistral | 13:05 | |
| *** shardy is now known as shardy_lunch | 13:10 | |
| *** dprince has joined #openstack-mistral | 13:15 | |
| *** bobh has quit IRC | 13:31 | |
| *** dprince has quit IRC | 13:42 | |
| *** gongysh has joined #openstack-mistral | 14:00 | |
| *** shardy_lunch is now known as shardy | 14:04 | |
| *** rbrady has joined #openstack-mistral | 14:09 | |
| *** rbrady has quit IRC | 14:09 | |
| *** rbrady has joined #openstack-mistral | 14:09 | |
| *** dprince has joined #openstack-mistral | 14:10 | |
| *** bobh has joined #openstack-mistral | 14:10 | |
| *** bobh has quit IRC | 14:13 | |
| *** bobh has joined #openstack-mistral | 14:13 | |
| openstackgerrit | Dawid Deja proposed openstack/mistral master: Fix for coverage job showing 0% coverage for kombu https://review.openstack.org/433074 | 14:17 |
| *** gongysh has quit IRC | 14:29 | |
| d0ugal | thrash: so it looks like error can be a dict, interesting. | 14:38 |
| thrash | d0ugal: Yep. | 14:38 |
| * d0ugal starts to grep | 14:38 | |
| *** jamielennox is now known as jamielennox|away | 14:39 | |
| *** mgershen1 has joined #openstack-mistral | 14:44 | |
| *** vgnbkr has quit IRC | 14:45 | |
| *** mgershen has quit IRC | 14:48 | |
| *** vgnbkr has joined #openstack-mistral | 14:48 | |
| d0ugal | thrash: https://github.com/openstack/mistral/blob/master/mistral/workflow/utils.py#L66-L68 | 14:50 |
| d0ugal | thrash: that seems to be the key logic. | 14:50 |
| d0ugal | thrash: so the usage I found in tripleo-common is wrong | 14:51 |
| d0ugal | thrash: we should either set error or data. | 14:51 |
| d0ugal | cc rbrady toure | 14:51 |
| rbrady | d0ugal: ack | 14:52 |
| d0ugal | That to_dict method creates the object that is stored in the db AFAICT | 14:52 |
| d0ugal | so when we provide both data and error, only the error is saved :( | 14:52 |
| openstackgerrit | Michal Gershenzon proposed openstack/mistral master: Update docs for tasks function https://review.openstack.org/433096 | 14:52 |
| thrash | d0ugal: Ahh | 14:52 |
| d0ugal | This is something that should be documented once we have a nice new custom actions API :) | 14:56 |
| thrash | lol | 14:57 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral master: Updated from global requirements https://review.openstack.org/433123 | 15:13 |
| rakhmerov | ddeja: if some code ran at least once during tests it's shown in a coverage report | 15:33 |
| rakhmerov | but keep in mind that coverage job runs only unit tests | 15:33 |
| rakhmerov | it has nothing to do with functional tests | 15:33 |
| ddeja | rakhmerov: ok, thanks Renat | 16:00 |
| d0ugal | Meeting time! | 16:00 |
| ddeja | \o/ | 16:01 |
| rakhmerov | yes | 16:01 |
| rakhmerov | just started | 16:01 |
| *** mgershen1 is now known as mgershen | 16:01 | |
| d0ugal | rbrady, thrash, toure ^ :) | 16:01 |
| d0ugal | In #openstack-meeting | 16:01 |
| *** shardy has quit IRC | 16:21 | |
| *** shardy has joined #openstack-mistral | 16:22 | |
| *** toure is now known as toure|food | 17:02 | |
| *** jpich has quit IRC | 17:33 | |
| *** dprince has quit IRC | 17:49 | |
| *** hrybacki has quit IRC | 18:06 | |
| *** jaosorior has quit IRC | 18:08 | |
| *** bobh has quit IRC | 18:12 | |
| *** bobh has joined #openstack-mistral | 18:13 | |
| *** toure|food is now known as toure | 18:17 | |
| *** hrybacki has joined #openstack-mistral | 18:45 | |
| *** shardy has quit IRC | 19:00 | |
| *** toure is now known as toure|biab | 19:12 | |
| *** dprince has joined #openstack-mistral | 19:26 | |
| *** kong has joined #openstack-mistral | 20:27 | |
| *** jamielennox|away is now known as jamielennox | 21:02 | |
| *** jkilpatr has quit IRC | 21:32 | |
| *** dprince has quit IRC | 21:34 | |
| *** jkilpatr has joined #openstack-mistral | 22:13 | |
| *** catintheroof has quit IRC | 22:20 | |
| *** bobh has quit IRC | 22:58 | |
| *** jamielennox is now known as jamielennox|away | 23:15 | |
| *** jamielennox|away is now known as jamielennox | 23:20 | |
| *** jtomasek has quit IRC | 23:31 | |
| *** jtomasek has joined #openstack-mistral | 23:35 | |
| *** thrash is now known as thrash|g0ne | 23:51 | |
| *** catintheroof has joined #openstack-mistral | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!