| *** rbrady-afk has quit IRC | 00:06 | |
| *** bobh has joined #openstack-mistral | 00:07 | |
| *** bobh has quit IRC | 00:24 | |
| *** bobh has joined #openstack-mistral | 00:27 | |
| *** bobh has quit IRC | 00:43 | |
| *** jkilpatr has quit IRC | 01:25 | |
| *** rbrady-afk has joined #openstack-mistral | 02:08 | |
| *** thrash is now known as thrash|g0ne | 02:17 | |
| *** jkilpatr has joined #openstack-mistral | 02:20 | |
| *** gongysh has joined #openstack-mistral | 02:31 | |
| *** jkilpatr has quit IRC | 02:48 | |
| *** jkilpatr has joined #openstack-mistral | 03:05 | |
| *** sharatss has quit IRC | 03:24 | |
| *** sharatss has joined #openstack-mistral | 03:25 | |
| *** sharatss has quit IRC | 03:30 | |
| *** sharatss has joined #openstack-mistral | 03:31 | |
| *** jkilpatr has quit IRC | 03:40 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Refactor RPC serialization: add polymophic serializer https://review.openstack.org/429643 | 04:42 |
|---|---|---|
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Refactor RPC serialization: add polymophic serializer https://review.openstack.org/429643 | 04:45 |
| *** sharatss has quit IRC | 05:09 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Refactor RPC serialization: add polymophic serializer https://review.openstack.org/429643 | 05:18 |
| *** sharatss has joined #openstack-mistral | 05:24 | |
| openstackgerrit | Merged openstack/python-mistralclient master: Add project_id and project_name options https://review.openstack.org/428640 | 05:34 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Refactor RPC serialization: add polymophic serializer https://review.openstack.org/429643 | 05:58 |
| openstackgerrit | Merged openstack/mistral master: Refactor RPC serialization: remove JsonPayloadSerializer class https://review.openstack.org/428591 | 06:16 |
| openstackgerrit | Merged openstack/mistral master: Enforce style check for xrange() https://review.openstack.org/428116 | 06:17 |
| *** sharatss has quit IRC | 06:19 | |
| *** sharatss has joined #openstack-mistral | 06:20 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Refactor RPC serialization: add polymophic serializer https://review.openstack.org/429643 | 06:37 |
| *** sharatss has quit IRC | 06:54 | |
| *** sharatss has joined #openstack-mistral | 06:55 | |
| *** sharatss has quit IRC | 07:15 | |
| *** sharatss has joined #openstack-mistral | 07:16 | |
| *** sharatss has quit IRC | 07:25 | |
| *** sharatss has joined #openstack-mistral | 07:25 | |
| *** sharatss has quit IRC | 07:36 | |
| *** sharatss has joined #openstack-mistral | 07:36 | |
| *** jamielennox is now known as jamielennox|away | 07:59 | |
| *** sharatss has quit IRC | 08:05 | |
| *** jamielennox|away is now known as jamielennox | 08:06 | |
| *** sharatss has joined #openstack-mistral | 08:06 | |
| *** pcastets has joined #openstack-mistral | 08:14 | |
| *** sharatss has quit IRC | 08:25 | |
| *** sharatss has joined #openstack-mistral | 08:25 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Refactor RPC serialization: add polymophic serializer https://review.openstack.org/429643 | 08:32 |
| *** jpich has joined #openstack-mistral | 08:40 | |
| rakhmerov | ddeja: hi | 08:42 |
| *** sharatss has quit IRC | 08:42 | |
| rakhmerov | seems like I'll need your help with my patch | 08:42 |
| rakhmerov | to fix Kombu properly | 08:42 |
| *** sharatss has joined #openstack-mistral | 08:42 | |
| rakhmerov | all is almost fine now but kombu gate fails with a weird behavior | 08:42 |
| rakhmerov | if you look at the logs you'll see that it tries to fetch the same execution again and again | 08:43 |
| rakhmerov | and eventually the entire gate times out | 08:43 |
| rakhmerov | can you pls have a look at it once you have time? | 08:44 |
| rakhmerov | maybe you saw something similar | 08:45 |
| *** sharatss has quit IRC | 08:46 | |
| *** sharatss has joined #openstack-mistral | 08:46 | |
| ddeja | rakhmerov: Hi | 08:53 |
| rakhmerov | hi | 08:54 |
| ddeja | rakhmerov: I'll take a look in a few minutes | 08:54 |
| rakhmerov | ok | 08:54 |
| *** sharatss has quit IRC | 09:18 | |
| *** sharatss has joined #openstack-mistral | 09:19 | |
| rakhmerov | ddeja: when you're looking at it, first of all look at https://review.openstack.org/#/c/429643/12/mistral/engine/rpc_backend/kombu/base.py | 09:22 |
| rakhmerov | this is how I fixed the kombu server | 09:22 |
| *** sharatss has quit IRC | 09:25 | |
| *** sharatss has joined #openstack-mistral | 09:26 | |
| *** gongysh has quit IRC | 09:29 | |
| *** gongysh has joined #openstack-mistral | 09:29 | |
| *** gongysh has quit IRC | 09:30 | |
| ddeja | rakhmerov: OK, sorry, I had an ad-hoc meeting | 09:34 |
| ddeja | but right now I'm looking on your patch | 09:34 |
| *** sharatss has quit IRC | 10:03 | |
| *** sharatss has joined #openstack-mistral | 10:03 | |
| rakhmerov | ddeja: I broke the patch again with something.. | 10:38 |
| rakhmerov | looking | 10:38 |
| ddeja | rakhmerov: I've just refreshed it and... oh my | 10:41 |
| rakhmerov | ? | 10:41 |
| ddeja | everything red ;) | 10:41 |
| rakhmerov | yeah, fixing it now, I made a mistake in the last patchset | 10:41 |
| rakhmerov | please look at the previous patchset | 10:41 |
| ddeja | kinda scary | 10:41 |
| rakhmerov | it's ok, I know where the problem is | 10:42 |
| ddeja | well, I'm going through the kombu code and try to understand if change of behaviour may broke something | 10:42 |
| ddeja | but it seems not, I need to download your patch and test it locally | 10:43 |
| *** szaher has joined #openstack-mistral | 10:43 | |
| rakhmerov | yeah, I read the docs in Kombu serialization module | 10:44 |
| rakhmerov | method 'register' seems to be compatible with what I've done | 10:44 |
| rakhmerov | it's basically object->string->object conversion | 10:44 |
| rakhmerov | unlike serialization in o.m | 10:44 |
| rakhmerov | so I did exactly the same in my implementation | 10:45 |
| rakhmerov | not sure why it's failing that bad | 10:45 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Refactor RPC serialization: add polymophic serializer https://review.openstack.org/429643 | 10:45 |
| rakhmerov | ddeja: sent another patch, should be ok now | 10:46 |
| rakhmerov | (except Kombu) | 10:46 |
| *** ist has quit IRC | 11:01 | |
| *** sharatss has quit IRC | 11:03 | |
| *** sharatss has joined #openstack-mistral | 11:03 | |
| *** sharatss has quit IRC | 11:05 | |
| *** sharatss has joined #openstack-mistral | 11:06 | |
| *** tuan_ has joined #openstack-mistral | 11:08 | |
| *** sharatss has quit IRC | 11:09 | |
| *** sharatss has joined #openstack-mistral | 11:10 | |
| ddeja | rakhmerov: OK, I now what's the problem with kombu | 11:33 |
| rakhmerov | ? | 11:33 |
| ddeja | rakhmerov: you have deleted the creation of Result object from on_message_safe method | 11:33 |
| rakhmerov | in what module? | 11:34 |
| ddeja | https://review.openstack.org/#/c/429643/12/mistral/engine/rpc_backend/rpc.py | 11:34 |
| ddeja | lines 315 | 11:34 |
| ddeja | but kombu driver doesn't return an Result object | 11:35 |
| *** sharatss has quit IRC | 11:38 | |
| ddeja | oh, sorry, line 370 | 11:38 |
| *** sharatss has joined #openstack-mistral | 11:38 | |
| rakhmerov | hm.. | 11:39 |
| rakhmerov | why doesn't it return a Result object? | 11:39 |
| rakhmerov | it should | 11:39 |
| rakhmerov | otherwise it works not interchangibly with o.m | 11:40 |
| rakhmerov | I mean, method return value should also go through serialization/deserialization | 11:42 |
| rakhmerov | not only method parameters | 11:42 |
| ddeja | well, it was compliant before we change the serialization mechanism | 11:43 |
| rakhmerov | ok | 11:44 |
| *** sharatss has quit IRC | 11:44 | |
| ddeja | but it should be easy fix, give me a second | 11:44 |
| *** sharatss has joined #openstack-mistral | 11:44 | |
| rakhmerov | yes, so I guess we just need to push a return value through a serializer | 11:44 |
| ddeja | we need to serialize it manually on the sender side | 11:45 |
| ddeja | and deserialize it on receiver side, yes | 11:46 |
| ddeja | ok, it's not that easy | 11:50 |
| rakhmerov | :) | 11:50 |
| rakhmerov | why not easy? | 11:50 |
| ddeja | we need to add some logic | 11:50 |
| ddeja | that is probably implemented in o.m | 11:50 |
| rakhmerov | logic for what? | 11:51 |
| rakhmerov | serialize and deserialize? | 11:51 |
| rakhmerov | or something else? | 11:51 |
| *** sharatss has quit IRC | 11:52 | |
| *** sharatss has joined #openstack-mistral | 11:52 | |
| ddeja | right now we got such dict to send over rpc: {'action_ex_id':action_ex_id, 'result'=resultObject, 'wf_action'= [True|False]) | 11:52 |
| ddeja | and if we just serialize it as-is, we use the regular dictionary serializer | 11:53 |
| rakhmerov | from executor to engine | 11:53 |
| rakhmerov | ? | 11:53 |
| ddeja | yes | 11:53 |
| ddeja | we need itereate over that dict and serialize every key saparetly | 11:53 |
| ddeja | every value* | 11:53 |
| rakhmerov | yes | 11:53 |
| rakhmerov | I see | 11:53 |
| ddeja | and if value is another dict, we should also serialize/deserialize recursively | 11:53 |
| rakhmerov | aha | 11:54 |
| ddeja | I bet it is somehow implemented in o.m. | 11:54 |
| ddeja | it's the only way how it works right now | 11:54 |
| rakhmerov | hm.. yes, otherwise it wouldn't work | 11:54 |
| ddeja | since input is the same | 11:54 |
| rakhmerov | interesting | 11:54 |
| ddeja | from o.m | 11:55 |
| ddeja | for argname, arg in args.items(): | 11:55 |
| ddeja | msg['args'][argname] = self.serializer.serialize_entity(ctxt, arg) | 11:55 |
| ddeja | where args is a dict I've pasted before | 11:55 |
| rakhmerov | that's the answer | 11:56 |
| ddeja | https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/rpc/client.py#L104-L109 | 11:57 |
| ddeja | you'd like me to add it in your patch or you will do it? | 11:57 |
| ddeja | rakhmerov ^ | 11:57 |
| rakhmerov | ddeja: if you can do it'd be good | 11:58 |
| rakhmerov | I guess you could do it faster | 11:58 |
| rakhmerov | and if you have time, of course | 11:58 |
| ddeja | I have | 11:58 |
| rakhmerov | other than this my patch is ready for review | 11:58 |
| rakhmerov | ddeja: we can actually even merge it :) | 11:58 |
| rakhmerov | as is | 11:58 |
| ddeja | OK, I'll fix it and send a patch in a few minutes | 11:58 |
| rakhmerov | since kombu gate is non-voting | 11:58 |
| rakhmerov | ok, whatever you prefer | 11:59 |
| rakhmerov | I actually still don't understand one thing... | 12:00 |
| rakhmerov | give me a few min | 12:00 |
| *** jkilpatr has joined #openstack-mistral | 12:00 | |
| rakhmerov | ddeja: question | 12:00 |
| ddeja | ? | 12:01 |
| rakhmerov | ooh, no | 12:01 |
| rakhmerov | clear | 12:01 |
| rakhmerov | so all method arguments eventually become entries in a dict sent over RPC | 12:01 |
| ddeja | yes | 12:01 |
| rakhmerov | I was just trying to understand where this dict came from | 12:01 |
| rakhmerov | got it | 12:01 |
| rakhmerov | ok, so pls add it either in my patch or in a new one following after mine | 12:02 |
| rakhmerov | thanks | 12:02 |
| rakhmerov | sharatss: hi | 12:06 |
| rakhmerov | I see that you keep working on coverage job in the client | 12:07 |
| rakhmerov | is there any serious problem? | 12:07 |
| rakhmerov | for the server it works fine, I saw its result today for the first time. It made the gate fail and I saw where I worsened our coverage | 12:08 |
| rakhmerov | ddeja: Dawid, I'll be back in a couple of hours | 12:09 |
| rakhmerov | write questions here if you have some, I'll read later | 12:09 |
| ddeja | rakhmerov: OK | 12:09 |
| ddeja | rakhmerov: I think I have it working | 12:09 |
| rakhmerov | awesome :) | 12:10 |
| rakhmerov | looking forward to seeing the patch | 12:10 |
| ddeja | just need to test it | 12:10 |
| rakhmerov | ok | 12:10 |
| *** sharat has joined #openstack-mistral | 12:15 | |
| *** sharatss has quit IRC | 12:15 | |
| openstackgerrit | Dawid Deja proposed openstack/mistral master: Refactor RPC serialization: add polymophic serializer https://review.openstack.org/429643 | 12:21 |
| *** sharatss has joined #openstack-mistral | 12:29 | |
| *** sharat has quit IRC | 12:29 | |
| *** ist has joined #openstack-mistral | 12:33 | |
| *** sharatss has quit IRC | 12:40 | |
| *** sharatss has joined #openstack-mistral | 12:41 | |
| *** thrash|g0ne is now known as thrash | 12:47 | |
| *** catintheroof has joined #openstack-mistral | 12:50 | |
| *** sharat has joined #openstack-mistral | 12:53 | |
| *** sharatss has quit IRC | 12:53 | |
| sharat | rakhmerov, there is nothing specific about it | 12:56 |
| sharat | rakhmerov, was just trying to get the open patches merged | 12:56 |
| *** sharatss_ has joined #openstack-mistral | 13:00 | |
| *** sharat has quit IRC | 13:01 | |
| *** bobh has joined #openstack-mistral | 13:02 | |
| *** bobh has quit IRC | 13:02 | |
| *** bobh has joined #openstack-mistral | 13:02 | |
| *** tuan_ has quit IRC | 13:06 | |
| *** pcastets has quit IRC | 13:12 | |
| *** chlong has joined #openstack-mistral | 13:14 | |
| *** pcastets has joined #openstack-mistral | 13:15 | |
| *** sharatss_ has quit IRC | 13:16 | |
| *** sharatss_ has joined #openstack-mistral | 13:17 | |
| *** ist has quit IRC | 13:18 | |
| *** bobh has quit IRC | 13:22 | |
| *** dprince has joined #openstack-mistral | 13:24 | |
| *** sharatss_ has quit IRC | 13:32 | |
| *** rbrady-afk is now known as rbrady | 13:42 | |
| rakhmerov | ok | 14:05 |
| rakhmerov | ddeja: I'm here | 14:05 |
| rakhmerov | btw, if you look at the coverage gate log you'll see that it's failing because coverage became worse :) | 14:06 |
| ddeja | rakhmerov: Oh | 14:07 |
| rakhmerov | yeah :) | 14:07 |
| rakhmerov | not critical though | 14:07 |
| rakhmerov | I'm concerned with kombu | 14:07 |
| ddeja | and kombu is still failing | 14:07 |
| rakhmerov | yes, but for a different reason | 14:07 |
| * ddeja was not looking on the gates | 14:07 | |
| ddeja | rakhmerov: yes, only 3 tests, not 12 | 14:08 |
| ddeja | and log doesn't weight around 100MB | 14:08 |
| ddeja | rakhmerov: I'll look on those 3, but tommorow | 14:09 |
| ddeja | I need to finish my work for today in next 20 minutes | 14:09 |
| *** tuan_ has joined #openstack-mistral | 14:18 | |
| rakhmerov | ddeja: ok, no problem | 14:35 |
| *** pcastets has quit IRC | 14:47 | |
| *** szaher has quit IRC | 14:50 | |
| *** tuan_ has quit IRC | 15:24 | |
| *** tuan has joined #openstack-mistral | 15:27 | |
| *** pcastets has joined #openstack-mistral | 15:33 | |
| openstackgerrit | luong tuan proposed openstack/mistral master: Deleting the expired execution in chunk https://review.openstack.org/424621 | 15:46 |
| *** rbrady is now known as rbrady-afk | 15:46 | |
| *** ist has joined #openstack-mistral | 15:51 | |
| *** ist has quit IRC | 15:52 | |
| *** jaosorior has joined #openstack-mistral | 16:18 | |
| *** szaher has joined #openstack-mistral | 16:25 | |
| *** openstackgerrit has quit IRC | 16:35 | |
| *** rbrady-afk is now known as rbrady | 16:49 | |
| *** rbrady has quit IRC | 16:50 | |
| *** rbrady has joined #openstack-mistral | 16:50 | |
| *** tuan has quit IRC | 17:09 | |
| *** jkilpatr_ has joined #openstack-mistral | 17:17 | |
| *** jkilpatr has quit IRC | 17:19 | |
| *** jaosorior has quit IRC | 17:22 | |
| *** jaosorior has joined #openstack-mistral | 17:23 | |
| *** jaosorior has quit IRC | 17:24 | |
| *** jaosorior has joined #openstack-mistral | 17:24 | |
| *** dprince has quit IRC | 17:34 | |
| *** dprince has joined #openstack-mistral | 17:35 | |
| *** dtturner has joined #openstack-mistral | 17:53 | |
| *** jpich has quit IRC | 17:55 | |
| *** dprince has quit IRC | 18:21 | |
| *** dprince has joined #openstack-mistral | 18:22 | |
| *** thrash is now known as thrash|biab | 18:33 | |
| *** pcastets has quit IRC | 18:42 | |
| *** hrybacki is now known as hrybacki____ | 18:42 | |
| *** bobh has joined #openstack-mistral | 18:57 | |
| *** thrash|biab is now known as thrash | 18:58 | |
| *** bobh has quit IRC | 19:01 | |
| *** dprince has quit IRC | 19:27 | |
| *** toure is now known as toure|biab | 20:32 | |
| *** dprince has joined #openstack-mistral | 20:33 | |
| *** jaosorior has quit IRC | 20:40 | |
| *** harlowja has quit IRC | 21:09 | |
| *** jkilpatr_ has quit IRC | 21:26 | |
| *** harlowja has joined #openstack-mistral | 21:35 | |
| *** jamielennox is now known as jamielennox|away | 21:42 | |
| *** jkilpatr has joined #openstack-mistral | 21:43 | |
| *** catintheroof has quit IRC | 21:48 | |
| *** catintheroof has joined #openstack-mistral | 21:49 | |
| *** catintheroof has quit IRC | 21:54 | |
| *** fultonj has joined #openstack-mistral | 22:10 | |
| *** jamielennox|away is now known as jamielennox | 22:42 | |
| *** dprince has quit IRC | 22:43 | |
| *** fultonj has quit IRC | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!