*** gongysh has joined #openstack-mistral | 00:37 | |
*** gongysh has quit IRC | 00:52 | |
*** bradjones has quit IRC | 00:55 | |
*** openstackgerrit has joined #openstack-mistral | 01:09 | |
openstackgerrit | Merged openstack/mistral-specs: Adding workflow global context spec https://review.openstack.org/420650 | 01:09 |
---|---|---|
*** gyee has quit IRC | 01:23 | |
*** bobh has joined #openstack-mistral | 01:39 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral-dashboard: Updated from global requirements https://review.openstack.org/422961 | 01:48 |
*** gongysh has joined #openstack-mistral | 02:11 | |
*** dprince has quit IRC | 02:19 | |
*** ChatSharp has joined #openstack-mistral | 02:33 | |
*** ChatSharp has left #openstack-mistral | 02:33 | |
*** bobh has quit IRC | 03:32 | |
*** bobh has joined #openstack-mistral | 04:16 | |
*** bobh has quit IRC | 04:26 | |
*** sharatss has joined #openstack-mistral | 04:42 | |
*** catinthe_ has quit IRC | 04:54 | |
*** catintheroof has joined #openstack-mistral | 05:02 | |
*** catintheroof has quit IRC | 05:14 | |
sharatss | rakhmerov: hi | 05:15 |
*** rbrady has joined #openstack-mistral | 05:20 | |
*** rbrady has joined #openstack-mistral | 05:20 | |
*** catintheroof has joined #openstack-mistral | 05:46 | |
*** sharatss has quit IRC | 06:29 | |
*** sharatss has joined #openstack-mistral | 07:28 | |
*** shardy has joined #openstack-mistral | 08:14 | |
*** shardy is now known as shardy_afk | 08:26 | |
*** jpich has joined #openstack-mistral | 08:43 | |
*** shardy_afk is now known as shardy | 08:52 | |
*** openstackgerrit has quit IRC | 09:02 | |
*** sharatss has quit IRC | 09:47 | |
*** sharatss has joined #openstack-mistral | 09:48 | |
*** gongysh has quit IRC | 10:22 | |
*** gongysh has joined #openstack-mistral | 10:28 | |
*** gongysh has quit IRC | 10:37 | |
*** sharatss has quit IRC | 11:05 | |
*** sharatss has joined #openstack-mistral | 11:05 | |
*** thrash|g0ne is now known as thrash | 11:18 | |
*** sharatss has quit IRC | 11:26 | |
*** sharatss has joined #openstack-mistral | 11:27 | |
*** openstackgerrit has joined #openstack-mistral | 11:27 | |
openstackgerrit | Istvan Imre proposed openstack/mistral: External OpenStack action mapping file support added https://review.openstack.org/418761 | 11:27 |
*** catinthe_ has joined #openstack-mistral | 12:32 | |
*** catintheroof has quit IRC | 12:33 | |
*** shardy is now known as shardy_lunch | 12:36 | |
*** ist has joined #openstack-mistral | 12:52 | |
*** dprince has joined #openstack-mistral | 12:59 | |
*** shardy_lunch is now known as shardy | 13:14 | |
*** endre_ has joined #openstack-mistral | 13:17 | |
*** sharatss has quit IRC | 13:17 | |
*** sharatss has joined #openstack-mistral | 13:18 | |
*** bobh has joined #openstack-mistral | 13:19 | |
*** bobh has quit IRC | 13:19 | |
*** clenimar has quit IRC | 13:23 | |
*** sharatss has quit IRC | 13:25 | |
*** shardy has quit IRC | 13:27 | |
*** shardy has joined #openstack-mistral | 13:27 | |
endre_ | Hi, I'm Endre from the Nokia CBAM team. At least one of our customers already uses workflow names containing hyphens, eg. "post-install". Names like this used to work fine until the commit below restricted the allowed set of characters to \w as a side effect: https://github.com/openstack/mistral/commit/ba67b3aff8bdcf1ce951d1f61e69ba19799a09fc | 13:33 |
endre_ | Apparently this had been intended but was never enforced (until now). Would allowing hyphens in the pattern cause any issues? | 13:34 |
ddeja | Hi endre_ I don't think this would be a problem | 13:34 |
ddeja | I guess it's unintended side-effect, am I right, d0ugal? | 13:35 |
*** bradjones has joined #openstack-mistral | 13:38 | |
*** bradjones has quit IRC | 13:38 | |
*** bradjones has joined #openstack-mistral | 13:38 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral: Updated from global requirements https://review.openstack.org/423273 | 13:48 |
*** bobh has joined #openstack-mistral | 14:02 | |
d0ugal | endre_, ddeja: yeah, that wasn't intended. | 14:03 |
d0ugal | endre_, ddeja: the previous regex also used \w, so I'm not really sure how they were accepted previously. | 14:04 |
d0ugal | I'll write a patch. | 14:04 |
ddeja | thanks, d0ugal | 14:05 |
endre_ | thanks, d0ugal. The commit in question actually fixed validation, basically everything was accepted until that point because additionalProperties defaulted to True. Now it is explicitly set to False, so names are validated using the pattern. | 14:08 |
d0ugal | endre_: ah, of course. | 14:08 |
openstackgerrit | Dougal Matthews proposed openstack/mistral: Allow hyphens in Workflow and ad-hoc action names https://review.openstack.org/423299 | 14:21 |
d0ugal | ddeja, endre_ ^ | 14:23 |
*** weshay_afk is now known as weshay | 14:23 | |
ddeja | d0ugal: looking | 14:24 |
ddeja | looks good, thanks! | 14:25 |
*** catintheroof has joined #openstack-mistral | 14:33 | |
*** catinthe_ has quit IRC | 14:36 | |
*** clenimar has joined #openstack-mistral | 14:51 | |
openstackgerrit | Dougal Matthews proposed openstack/mistral: In Python 3.7 "async" and "await" will become reserved keywords https://review.openstack.org/423323 | 15:07 |
*** endre_ has quit IRC | 15:26 | |
*** ist has quit IRC | 15:32 | |
*** jaosorior has joined #openstack-mistral | 15:39 | |
*** shardy has quit IRC | 15:48 | |
*** shardy has joined #openstack-mistral | 15:49 | |
*** bobh has quit IRC | 16:22 | |
*** bobh has joined #openstack-mistral | 16:42 | |
*** jaosorior has quit IRC | 16:48 | |
*** jaosorior has joined #openstack-mistral | 16:49 | |
*** jaosorior has quit IRC | 16:51 | |
*** bobh has quit IRC | 17:10 | |
*** dprince has quit IRC | 17:23 | |
*** jaosorior has joined #openstack-mistral | 17:32 | |
*** jpich has quit IRC | 17:36 | |
*** dturner has quit IRC | 17:48 | |
*** dprince has joined #openstack-mistral | 18:01 | |
*** jaosorior has quit IRC | 18:35 | |
*** bobh has joined #openstack-mistral | 18:42 | |
*** bobh has quit IRC | 19:00 | |
*** catinthe_ has joined #openstack-mistral | 19:50 | |
*** jaosorior has joined #openstack-mistral | 19:52 | |
*** catintheroof has quit IRC | 19:53 | |
*** bobh has joined #openstack-mistral | 20:23 | |
*** bobh has quit IRC | 20:26 | |
*** bobh has joined #openstack-mistral | 20:27 | |
*** bobh has quit IRC | 20:31 | |
*** jaosorior has quit IRC | 20:57 | |
*** catinthe_ has quit IRC | 21:02 | |
*** catintheroof has joined #openstack-mistral | 21:03 | |
*** catintheroof has quit IRC | 21:07 | |
*** jamielennox is now known as jamielennox|away | 21:28 | |
*** shardy has quit IRC | 22:22 | |
*** dprince has quit IRC | 22:52 | |
*** thrash is now known as thrash|g0ne | 23:21 | |
*** rbrady has quit IRC | 23:39 | |
*** rbrady has joined #openstack-mistral | 23:52 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!