Monday, 2016-11-28

*** catinthe_ has quit IRC01:16
*** catintheroof has joined #openstack-mistral01:17
*** catintheroof has quit IRC01:21
*** jamielennox is now known as jamielennox|away01:26
*** jamielennox|away is now known as jamielennox02:15
openstackgerritJizhaoxuan proposed openstack/mistral: Some spelling errors  https://review.openstack.org/40349704:38
*** sharatss has joined #openstack-mistral05:10
sharatssGood Morning!!05:13
*** janki has joined #openstack-mistral05:21
*** jrist has quit IRC05:39
*** jaosorior has joined #openstack-mistral05:57
*** ist has joined #openstack-mistral06:10
rakhmerovsharatss: hi06:22
rakhmerovd0ugal: hm... try to collect all the info about this case06:23
rakhmerovwf text, state of all objects, logs06:23
rakhmerovmaybe you found some bug06:23
rakhmerovddeja: hi, can you please look at https://review.openstack.org/#/c/402057/?06:28
openstackgerritMerged openstack/mistral-extra: Show team and repo badges on README  https://review.openstack.org/40299606:29
openstackgerritMerged openstack/mistral-specs: Show team and repo badges on README  https://review.openstack.org/40299906:32
openstackgerritMerged openstack/mistral-lib: Show team and repo badges on README  https://review.openstack.org/40301406:32
openstackgerritMerged openstack/mistral-dashboard: Show team and repo badges on README  https://review.openstack.org/40301106:34
openstackgerritJizhaoxuan proposed openstack/mistral: Some spelling errors  https://review.openstack.org/40349706:41
rakhmerovddeja: Dawid, please ping me when you're available06:43
rakhmerovI have some questions about RPC06:43
*** sharatss has quit IRC06:54
*** sharatss has joined #openstack-mistral06:54
sharatssrakhmerov: hi06:55
sharatssrakhmerov: any key features that we are keen about discussing in the PTG?06:56
openstackgerritMerged openstack/python-mistralclient: Show team and repo badges on README  https://review.openstack.org/40300406:56
rakhmerovsharatss: I think it's a little bit early to have a list of topics06:56
rakhmerovI was planning to build it not so long before the PTG06:57
rakhmerovof course, I have a list of things in mind that they are pretty high level at this point06:57
sharatssrakhmerov, yes. I know it is too early. Thanks anyway06:58
*** jaosorior has quit IRC07:04
*** jaosorior has joined #openstack-mistral07:05
*** hparekh has joined #openstack-mistral07:08
openstackgerritRenat Akhmerov proposed openstack/mistral: WIP: Fixing launch process of Mistral components  https://review.openstack.org/40239207:48
*** janki is now known as janki|lunch07:49
*** jpich has joined #openstack-mistral08:03
*** shardy has joined #openstack-mistral08:11
openstackgerritMerged openstack/mistral: Add timestamp at the bottom of every page  https://review.openstack.org/39776108:22
openstackgerritMerged openstack/mistral: Add Ironic RAID actions  https://review.openstack.org/40083808:22
openstackgerritRenat Akhmerov proposed openstack/mistral: WIP: Fixing launch process of Mistral components  https://review.openstack.org/40239208:32
openstackgerritRenat Akhmerov proposed openstack/mistral: WIP: Fixing launch process of Mistral components  https://review.openstack.org/40239209:07
*** dtantsur|afk is now known as dtantsur09:13
openstackgerritRenat Akhmerov proposed openstack/mistral: WIP: Fixing launch process of Mistral components  https://review.openstack.org/40239209:14
*** janki|lunch is now known as janki09:24
openstackgerritMerged openstack/mistral: Mock the HTTP action in the with_items tests  https://review.openstack.org/40205709:26
openstackgerritRenat Akhmerov proposed openstack/mistral: WIP: Fixing launch process of Mistral components  https://review.openstack.org/40239209:39
rakhmerovd0ugal: hi, you here?09:39
d0ugalrakhmerov: Hi, yes, I am :)09:40
rakhmerovcool09:40
rakhmerovhow have you been?09:40
d0ugalrakhmerov: Mostly good, had a horrible cold for a while now.09:40
d0ugalHow are you?09:40
rakhmerovooh, sorry to hear09:40
rakhmerovI'm alright09:40
d0ugalIt's fine, just makes me a bit more tired than normal!09:41
rakhmerovI see09:41
rakhmerovget better09:41
d0ugalThanks :)09:41
rakhmerovjust wanted to sync up with you quickly09:41
d0ugalI really need to speak to you about the tests this week.09:41
rakhmerovdo you have any updates on actions or anything else?09:41
rakhmerovyes, let's do09:41
rakhmerovany time09:41
d0ugalNot really. I also need to look into the stackstorm actions09:42
rakhmerovok09:42
d0ugalMaybe we can talk about some of this in the meeting if there is time09:42
rakhmerovsure09:42
rakhmerovwould you be able to talk about issues that you and rbrady found in the summer with actions (something was wrong with decomposition into modules) ?09:43
rakhmerovI remember something but not sure that it's all you found09:43
d0ugalYeah, I can't remember it all. rbrady done most of that work, I will speak with him when he is awake and see if we can get a summary for the meeting09:44
d0ugalbtw, I have managed to reproduce the issue I hit on Friday09:45
d0ugalI just now need to try and reproduce it with less code so I can figure out where it goes wrong.09:45
ddejarakhmerov: ping ^09:53
rakhmerovd0ugal: this is very good, share it as a bug09:54
d0ugalrakhmerov: I will :)09:54
rakhmerovddeja: hi! I actually found what I wanted09:54
rakhmerovgood for now )09:54
ddejarakhmerov: oh, that's good09:54
d0ugalrakhmerov: I am just trying to figure out what is happening, some sql error.09:54
sharatssrakhmerov, how about this? https://blueprints.launchpad.net/mistral/+spec/mistral-i18n09:55
rakhmerovddeja: I may have some other questions later09:55
* ddeja should not play Civilization V and sleep till 8.30...09:55
ddejarakhmerov: sure :)09:55
rakhmerovsharatss: what do you mean?09:55
rakhmerovhow can I help you?09:55
d0ugalddeja: civ is great :)09:55
sharatssrakhmerov, i wanted you to look into that BP09:55
sharatssrakhmerov, whenever free09:55
ddejad0ugal: yup, but you play only few turns and *poof* end of weekend ;)09:56
rakhmerovddeja: haha :)) Same to me but I played "Call of Duty: Infinite Warfare" yesterday )09:56
rakhmerovvery cool stuff09:56
rakhmerovsharatss: ok09:56
rakhmerovI thought I did :)09:56
sharatssrakhmerov, thanks. I had logged it in wrong place. (client :P)09:57
rakhmerovok09:57
d0ugalrakhmerov: This is the error I have in my engine log. http://paste.openstack.org/show/590626/09:58
rakhmerovd0ugal: ooh woow10:02
rakhmeroverror in SQL syntax10:02
rakhmerovhow come10:02
d0ugalYeah, scary :)10:02
d0ugalI have no idea, yet10:02
d0ugalstill digging through the logs10:02
d0ugalrakhmerov: the action failed with a ValueError. http://paste.openstack.org/show/590627/10:03
d0ugalbut the workflow never finishes10:03
rakhmerovyes, because it's a critical error10:03
d0ugalso I guess there is a potential issue when marking the workflow as errored10:03
d0ugalYeah10:03
rakhmerovhm.. weird10:06
openstackgerritMichal Gershenzon proposed openstack/mistral: Yaql Tasks Function  https://review.openstack.org/40136010:07
rakhmerovd0ugal: at first glance, everything looks good, I don't see any syntax errors10:11
d0ugalrakhmerov: the value for state_info looks weird.10:12
d0ugalrakhmerov: 'state_info': {}10:12
d0ugalan empty dict?10:12
d0ugalI am trying to see where this comes from10:12
rakhmerovooh, yes10:13
rakhmerovyou're 100% right10:13
rakhmerovit's a problem10:13
rakhmerovit should be a string10:13
d0ugalokay, cool, glad I am going in the right direction :)10:14
rakhmerovyes, try to see where it becomes a dict10:14
*** sharatss has quit IRC10:21
*** sharatss has joined #openstack-mistral10:21
openstackgerritRenat Akhmerov proposed openstack/mistral: Fix launch process of Mistral components  https://review.openstack.org/40239210:28
d0ugalrakhmerov: I found the issue.10:30
d0ugalIt is partly our fault, but I guess Mistral should error in a more sensible way :)10:30
d0ugalrakhmerov: https://github.com/openstack/tripleo-common/blob/master/tripleo_common/actions/baremetal.py#L7010:30
rakhmerov?10:30
d0ugalwe return error as an actual exception instance (I don't know how it turns into a dict?)10:30
d0ugalbut when I change that line to str(err) the problem goes away10:31
rakhmerovhm..10:31
d0ugalso the bug I am going to open for Mistral is to either reject non-strings, or convert to a string.10:31
rakhmerovI think it gets converted into dict in the serializer10:31
rakhmerovsec10:32
d0ugalright, that would make sense10:32
rakhmerovI think it's easy to fix10:32
rakhmerovhttps://github.com/openstack/mistral/blob/master/mistral/workflow/utils.py#L5910:33
rakhmerovand I believe the base class just takes an object and puts all its attributes into a dict10:33
rakhmerovif it's not a primitive type10:33
d0ugalThe base class doesn't do anythin :)10:34
rakhmerovactually no, base class doesn't do that10:34
rakhmerovyes ;)10:34
rakhmerovyeah, I guess it happens inside oslo.messaging somewhere10:35
d0ugalok10:36
rakhmerovwhere it prepares the object for sending over the network10:36
d0ugalYup10:36
d0ugalrakhmerov: What do you think the best fix would be?10:36
d0ugalI'll also do a fix in our action to pass a string, but I want to make sure the error is more obvious10:36
rakhmerovwell, ideally Result class should take care of this10:36
d0ugalSome validation in __init__?10:37
rakhmerovwhen we create an instance with Result(error=err) we need to check the precondition10:37
rakhmerovyes10:37
d0ugalokay10:37
rakhmerovand make sure it's one of the valid types10:37
d0ugalso it should raise an error if it isn't a string?10:37
d0ugalI wans't sure if you would prefer an error, or prefer it automatically converted it to a string.10:37
d0ugalwasn't10:37
rakhmerovwell, it can also be a dict10:37
rakhmerovno-no, let me think...10:38
d0ugalI think error must be a string.10:38
rakhmerovit can be not only a string10:38
rakhmerovthat's the point..10:38
rakhmerovgive me a sec...10:38
d0ugalk10:38
d0ugalbrb, going to get a coffee10:39
rakhmerovd0ugal: https://github.com/openstack/mistral/blob/master/mistral/actions/std_actions.py#L22110:40
rakhmerovin this case we send back a dict10:40
rakhmerovwhich allows us to make some conditions in "on-error" clause10:41
rakhmerovwe need to make sure it works too10:41
openstackgerritRenat Akhmerov proposed openstack/mistral: Fix launch process of Mistral components  https://review.openstack.org/40239210:44
d0ugalrakhmerov: oh, cool. I didn't know about that.10:48
rakhmerovyes, so please experiment with this10:51
rakhmerovd0ugal: I would recommend to find where this conversion happens exactly10:52
rakhmerovto make sure we understand it right10:52
d0ugalYup, good idea.10:52
d0ugalrakhmerov: unlreated question, how do we get a new release of mistralclient?10:53
d0ugalit hasn't been released on PyPI since August.10:53
rakhmerovwe need to send a patch to openstack/release10:54
d0ugalOkay, I can do that I think.10:54
* d0ugal looks into it10:54
rakhmerovyes, you just need to specify a hash of the needed patch that should be tagged10:54
d0ugalokay, I'll do that first and then go back to the result issue10:55
d0ugalthanks10:55
d0ugalrakhmerov: What version should it be?10:57
rakhmerovlet me see10:58
rakhmerovwe can also write to Lingxian(kong) to do this10:58
rakhmerovbecause he is our release liaison10:58
d0ugalokay, maybe I should do that and juggle one less thing :)10:59
rakhmerovyes10:59
d0ugal90 commits since the last release10:59
rakhmerovyou want a release out of stable/newton, right?10:59
d0ugal(including merge commits I guess)10:59
d0ugalhmm, good point11:00
rakhmerov:))11:00
d0ugalrakhmerov: Yeah, I guess so11:00
d0ugalbut I need to backport a fix first11:00
rakhmerovif so, we need to see if something needs to be backported11:01
rakhmerovyes11:01
d0ugalhttps://review.openstack.org/#/c/403614/11:01
d0ugalrakhmerov: that is the specific fix that is missing from the latest release and somebody asked me about11:01
rakhmerovok11:01
d0ugaland since that is a small change, I'll request 2.1.211:02
rakhmerovyes11:02
rakhmerovI agree11:02
d0ugaland the highlights will almost be the same, because 2.1.1 claimed to fix this :P11:02
rakhmerovnewton is stil 2.x.x11:03
rakhmerovocata will be 3.x.x11:03
d0ugalOcata is going so fast.11:07
*** thrash|g0bble is now known as thrash11:09
*** jaosorior has quit IRC11:30
openstackgerritRenat Akhmerov proposed openstack/mistral: Fix launch process of Mistral components  https://review.openstack.org/40239211:30
openstackgerritSharat Sharma proposed openstack/mistral: Initial commit for mistral-i18n support  https://review.openstack.org/40363911:45
*** janki has quit IRC11:50
*** janki has joined #openstack-mistral12:03
openstackgerritRenat Akhmerov proposed openstack/mistral: Fix launch process of Mistral components  https://review.openstack.org/40239212:05
d0ugalrakhmerov: FYI https://review.openstack.org/#/c/403656/12:10
*** hparekh has quit IRC12:11
*** jaosorior has joined #openstack-mistral12:29
*** ist has quit IRC12:32
openstackgerritJizhaoxuan proposed openstack/mistral: Some spelling errors  https://review.openstack.org/40349712:34
openstackgerritJizhaoxuan proposed openstack/mistral: Some spelling errors  https://review.openstack.org/40349712:39
openstackgerritJizhaoxuan proposed openstack/mistral: changes get next execution time from local time zone to UTC timezone  https://review.openstack.org/40367112:39
*** dprince has joined #openstack-mistral12:41
*** ist has joined #openstack-mistral12:46
*** janki has quit IRC12:52
*** bobh has joined #openstack-mistral12:53
*** bobh has quit IRC12:54
*** bobh has joined #openstack-mistral12:55
openstackgerritJizhaoxuan proposed openstack/mistral: Some spelling errors  https://review.openstack.org/40349712:59
*** bobh has quit IRC12:59
openstackgerritGal Margalit proposed openstack/mistral-dashboard: mistral-dashboard: added action executions screens  https://review.openstack.org/40118813:12
*** jaosorior is now known as jaosorior_brb13:16
*** bobh has joined #openstack-mistral13:19
*** bobh has quit IRC13:34
*** clenimar has joined #openstack-mistral14:18
*** dtantsur is now known as dtantsur|mtg14:20
*** vishwana_ has quit IRC14:44
*** vishwanathj has joined #openstack-mistral14:44
d0ugalIs "version" not allowed in a workflow name?14:45
d0ugalI can't seem to make a workflow with version in the name14:46
d0ugalDoes anyone know what this regex is for? https://github.com/openstack/mistral/blob/master/mistral/workbook/v2/workbook.py#L3714:49
d0ugaland on like 4514:49
d0ugalline*14:55
ddejad0ugal: here's the patchset that introduced it, but I don't see the explenation why version is forbidden https://review.openstack.org/#/c/163197/14:59
d0ugalddeja: Yeah, I looked at that and the comments but it didn't really help15:00
openstackgerritMichal Gershenzon proposed openstack/mistral: Yaql Tasks Function  https://review.openstack.org/40136015:00
d0ugalddeja: I don't think it is intentionally forbidden - the error you get is strange and not useful15:00
ddejayeah, I also don't see any reason why 'version' should be forbidden as a wf name15:00
d0ugalddeja: nothing containing version is allowed either15:01
d0ugalhttp://paste.openstack.org/show/590678/15:01
*** dtantsur|mtg is now known as dtantsur15:03
*** jaosorior_brb has quit IRC15:05
*** clenimar has quit IRC15:05
d0ugalBug for this: https://bugs.launchpad.net/mistral/+bug/164535415:05
openstackLaunchpad bug 1645354 in Mistral "It is impossible to create a workflow with "version" in the name" [Medium,Confirmed] - Assigned to Dougal Matthews (d0ugal)15:05
*** jaosorior_brb has joined #openstack-mistral15:05
ddejad0ugal: oh, it looks like 'version' is parsed as a string15:06
ddejainstead of fristly parse yaml to json and then look for keys...15:06
ddejayup, it's defenitely a bug15:06
d0ugalddeja: so the regex is matching the full yamk document?15:06
d0ugalyaml15:06
ddejad0ugal: I'm not sure, but it looks like it does15:07
*** clenimar has joined #openstack-mistral15:07
d0ugalwow, I didn't know Mistral contained an implementation of json-schema15:09
openstackgerritGal Margalit proposed openstack/mistral-dashboard: mistral-dashboard: added action executions screens  https://review.openstack.org/40118815:13
*** bobh has joined #openstack-mistral15:16
ddejad0ugal: hm, that's all weird15:21
ddejathere's a meeting in 40 minutes, we should bring this topic15:22
d0ugalSure15:22
d0ugalGood idea.15:22
*** ist has quit IRC15:28
*** jaosorior_brb is now known as jaosorior15:37
rakhmerovddeja, d0ugal: it's weird that it's forbidden15:39
rakhmerovI think it's a bug15:40
rakhmerovthere shouldn't be any problems with having "version" in names15:40
rakhmerovexcept exactly "version"15:41
rakhmerovI'm sure it's a bug15:41
d0ugalhttps://bugs.launchpad.net/mistral/+bug/164535415:41
openstackLaunchpad bug 1645354 in Mistral "It is impossible to create a workflow with "version" in the name" [Medium,Confirmed] - Assigned to Dougal Matthews (d0ugal)15:41
d0ugalrakhmerov: Why can't I have a version called exactly "version"?15:41
rakhmerovcan't have a name?15:41
d0ugalYeah15:42
rakhmerovbecause 'version' is a necessary keyword in a yaml document15:42
d0ugalSorry15:42
d0ugalbut it shouldn't be necessary under the "workflows" key15:42
rakhmerovand it may be on the same level as workflow names15:42
d0ugalunless you can have multiple versions in one workbook?15:42
rakhmerovif you don't use workbooks15:42
rakhmerovno15:42
rakhmerovit's for the case you don't use workbooks15:42
rakhmerovonly workflows15:42
d0ugalSo can I just delete this? https://github.com/openstack/mistral/blob/master/mistral/workbook/v2/workbook.py#L35-L3815:43
d0ugalit seems the error is that version is included in multiple places in the spec15:43
d0ugalit seems the error is that version is included in multiple places in the schema15:43
rakhmerovthere are two (actually three) types of YAML: workbook, workflows (multiple WFs in a single doc)15:43
rakhmerovand action15:43
rakhmerovactions15:43
d0ugalYeah15:43
rakhmerovd0ugal: no, it's not an error15:43
d0ugalthis bug is specific to workbooks15:43
rakhmerovit's needed because every execution object needs to have it's portion of the yaml (represented as json) in DB15:44
rakhmerovand it needs to have a version15:44
rakhmerovd0ugal: well, I would say it is reasonable to forbid it just for all use case15:45
rakhmerovso that we don't confuse users15:45
rakhmerovnot only for worbooks15:45
rakhmerovsorry, not only for workflows15:45
rakhmerovotherwise it may not be transparent why it's allowed in one case and not allowed in another case15:46
rakhmerovbtw, this is something to mention in the docs15:46
rakhmerovI don't think it's in there15:46
d0ugalk15:46
d0ugalI'll add a note to the bug that it needs to be documented too15:46
rakhmerovyes15:46
d0ugalrakhmerov: https://bugs.launchpad.net/mistral/+bug/1645354/comments/215:47
openstackLaunchpad bug 1645354 in Mistral "It is impossible to create a workflow with "version" in the name" [Medium,Confirmed] - Assigned to Dougal Matthews (d0ugal)15:47
d0ugaldoes that seem correct?15:47
rakhmerovcorrect15:47
rakhmerovyes15:47
d0ugalgreat15:48
*** dtantsur has quit IRC16:01
*** zigo has quit IRC16:01
*** vgnbkr has quit IRC16:01
*** zigo has joined #openstack-mistral16:01
*** dtantsur has joined #openstack-mistral16:02
*** vgnbkr has joined #openstack-mistral16:02
*** shardy has quit IRC16:10
openstackgerritMichal Gershenzon proposed openstack/python-mistralclient: Make python mistralclient readme better  https://review.openstack.org/40379816:37
*** hrybacki is now known as hrybacki|moving17:14
*** thrash is now known as thrash|f00dz17:29
*** jpich has quit IRC17:37
*** weshay is now known as weshay_pto17:52
*** catintheroof has joined #openstack-mistral18:04
*** dtantsur is now known as dtantsur|afk18:05
*** jaosorior has quit IRC18:08
*** hrybacki|moving is now known as hrybacki18:17
*** thrash|f00dz is now known as thrash18:21
openstackgerritMichal Gershenzon proposed openstack/python-mistralclient: Filter workflow executions by creating task execution id  https://review.openstack.org/40384418:27
*** chlong has joined #openstack-mistral18:42
*** bobh has quit IRC19:15
*** bobh has joined #openstack-mistral19:16
*** bobh has quit IRC19:20
*** rbrady is now known as rbrady-errand19:30
*** rbrady-errand is now known as rbrady-afk19:30
*** thrash is now known as thrash|biab19:33
*** rbrady-afk is now known as rbrady20:00
*** chlong has quit IRC20:02
*** chlong has joined #openstack-mistral20:18
*** bobh has joined #openstack-mistral20:30
*** dprince has quit IRC20:48
*** vishwana_ has joined #openstack-mistral21:04
*** vishwanathj has quit IRC21:08
*** chlong has quit IRC21:16
*** chlong has joined #openstack-mistral21:30
*** vishwana_ has quit IRC21:35
*** vishwanathj has joined #openstack-mistral21:35
*** chlong has quit IRC22:09
*** thrash|biab is now known as thrash22:10
*** jrist has joined #openstack-mistral22:20
*** catintheroof has quit IRC22:28
*** zigo has quit IRC22:29
*** zigo has joined #openstack-mistral22:36
*** bobh has quit IRC22:40

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!