Tuesday, 2016-11-15

*** bobh has joined #openstack-mistral00:15
*** bobh has quit IRC00:18
*** bobh has joined #openstack-mistral00:19
*** bobh has quit IRC00:22
*** catintheroof has quit IRC00:47
*** catintheroof has joined #openstack-mistral00:48
*** catintheroof has quit IRC00:52
*** rrecio_ has quit IRC00:53
*** bobh has joined #openstack-mistral01:07
*** bobh has quit IRC01:58
*** bobh has joined #openstack-mistral02:02
*** bobh has quit IRC02:32
*** bobh has joined #openstack-mistral02:37
*** jamielennox is now known as jamielennox|away03:07
*** bobh has quit IRC03:12
*** bobh has joined #openstack-mistral03:18
*** bobh has quit IRC03:19
*** bobh has joined #openstack-mistral03:20
*** jamielennox|away is now known as jamielennox03:21
*** bobh has quit IRC03:23
*** bobh has joined #openstack-mistral03:24
*** thrash is now known as thrash|g0ne03:26
*** bobh has quit IRC04:00
*** jamielennox is now known as jamielennox|away04:15
*** jamielennox|away is now known as jamielennox04:17
*** sharatss has joined #openstack-mistral04:22
*** janki has joined #openstack-mistral04:34
*** jamielennox is now known as jamielennox|away04:40
*** jamielennox|away is now known as jamielennox05:03
*** khamtamtun has joined #openstack-mistral05:04
*** khamtamtun has quit IRC05:21
rakhmerovd0ugal, xavierhardy: hi05:25
rakhmerovyes, we need those patches in stable branch05:25
rakhmerovdefinitely05:25
rakhmerovbut one of them was in conflict05:25
rakhmerovxavierhardy: how did you resolve conflicts in https://review.openstack.org/#/c/397199/ ?05:27
rakhmerovmanually?05:29
*** hparekh has joined #openstack-mistral05:40
*** jaosorior has joined #openstack-mistral06:07
*** khamtamtun has joined #openstack-mistral06:17
*** khamtamtun has quit IRC06:35
*** sharatss has quit IRC06:35
*** sharatss has joined #openstack-mistral06:36
*** jaosorior has quit IRC06:40
*** jaosorior has joined #openstack-mistral06:40
*** khamtamtun has joined #openstack-mistral06:48
openstackgerritSharat Sharma proposed openstack/python-mistralclient: Updated tox.ini to pick up requirements from upper constraints  https://review.openstack.org/39754906:56
*** sharatss has quit IRC07:35
*** sharatss has joined #openstack-mistral07:37
hparekhsharatss: Hi, Can you please add release note for https://review.openstack.org/#/c/395587/7 ?08:09
xavierhardyrakhmerov: manually? Yes08:19
rakhmerovok08:19
rakhmerovnp08:19
xavierhardyI followed this08:19
xavierhardyhttp://docs.openstack.org/project-team-guide/stable-branches.html08:19
rakhmerova approved the backport08:19
rakhmerovyes, ok08:19
rakhmerovI approved08:19
xavierhardyGood, thanks a lot08:20
rakhmerovthanks to you08:20
*** janki has quit IRC08:22
rakhmerovd0ugal: hi08:23
d0ugalrakhmerov: hi08:24
rakhmerovd0ugal: how was the meeting yesterday?08:25
d0ugalrakhmerov: good, it was quick - I have less to say than you I guess08:25
d0ugalso it was a short one, but that was fine :)08:25
rakhmerovok08:25
rakhmerovdid you discuss time slots?08:25
d0ugalrakhmerov: Yeah, briefly.08:26
rakhmerovoutcome?08:26
d0ugalrakhmerov: based on the feedback in the etherpad, most people find the current meeting time okay tbh08:26
d0ugalso it is hard to know what to do08:26
d0ugalbut we could try a doodlepoll08:26
rakhmerovooh, I see08:26
d0ugalhttps://etherpad.openstack.org/p/mistral-meeting-time08:26
rakhmerovI know that, for example, for kong it's not convenient08:27
d0ugalI roughly grouped them by similar times08:27
d0ugalYeah, it is worst for kong08:27
d0ugalbut if we move it to a time for kong it doesn't suit anyone else08:27
d0ugaleven you have very little overlap with kong08:27
rakhmerovyeah08:27
rakhmerovok08:28
d0ugalit might be better for some people if we make it a little earlier08:28
d0ugallike you08:28
rakhmerovI'm ok with it08:28
d0ugalAlright, I guess we will just continue with the current time08:28
rakhmerovI'm just thinking that maybe we should leave this time slot but every 2nd week have it at a different time08:29
d0ugalI had hoped we might find more people that want to attend but can't - but maybe we have already lost those people08:29
rakhmerovmore convenient for StackStorm folks and kong08:29
d0ugalSure, that would be fine08:29
rakhmerovwe definitely didn't loose kong and Winson from StackStorm08:29
d0ugalTrue :)08:30
rakhmerovWinson works almost full time on Mistral08:30
rakhmerovhe is just shy :)08:30
rakhmerovand meeting time is not convenient for him08:30
rakhmerovhe sends patches rarely but they are big08:30
rakhmerovok, I'll have a meeting with him this Friday08:31
d0ugalRight, but if they don't make requests it is hard to know what to do08:31
rakhmerovand I'll discuss it with him08:31
d0ugalrakhmerov: Yeah, too big maybe ;)08:31
rakhmerovyes, I know08:31
rakhmerovwe need to fix communication with them08:31
rakhmerov:))08:31
d0ugalrakhmerov: if Kong or Winston can run the other meeting that would work08:31
rakhmerovtoo big, right08:31
rakhmerovok08:31
rakhmerovd0ugal: thanks for driving this08:31
d0ugalWinson*08:32
d0ugalrakhmerov: but I guess they wont want the meeting if it is just for two maybe with a bit of proption we will get more08:34
d0ugalrakhmerov: but I guess they wont want the meeting if it is just for two of them. Maybe with a bit of proption we will get more people.08:35
*** shardy has joined #openstack-mistral08:35
rakhmerovyes, right08:38
*** jpich has joined #openstack-mistral08:40
sharatsshparekh: sure. i was waiting for the merge08:45
*** jaosorior is now known as jaosorior_lunch08:52
d0ugalHave all the dangling transaction patches landed?08:56
d0ugaloh, two waiting for stable/newton08:56
openstackgerritSharat Sharma proposed openstack/mistral: Added releasenote for Senlin Action Pack  https://review.openstack.org/39759209:02
openstackgerrityushangbin proposed openstack/mistral: Remove unused pylintrc  https://review.openstack.org/39759809:11
*** szaher has joined #openstack-mistral09:18
*** openstackgerrit has quit IRC09:18
*** openstackgerrit has joined #openstack-mistral09:18
*** jaosorior_lunch is now known as jaosorior09:42
openstackgerritSharat Sharma proposed openstack/python-mistralclient: Updated tox.ini to pick up requirements from upper constraints  https://review.openstack.org/39754909:42
openstackgerritGal Margalit proposed openstack/mistral-dashboard: mistral-dashboard: entities name change for system consistency  https://review.openstack.org/39763710:01
openstackgerritSharat Sharma proposed openstack/python-mistralclient: Remove unused pylint  https://review.openstack.org/39764210:08
openstackgerritSharat Sharma proposed openstack/mistral-dashboard: Cleanup unused files  https://review.openstack.org/39764810:15
openstackgerritSharat Sharma proposed openstack/python-mistralclient: Updated tox.ini to pick up requirements from upper constraints  https://review.openstack.org/39754910:20
openstackgerritSharat Sharma proposed openstack/mistral-dashboard: Adding files to .gitignore  https://review.openstack.org/39765610:27
*** khamtamtun has quit IRC10:39
openstackgerritSharat Sharma proposed openstack/mistral-lib: Added the Options for Internationalization output in conf.py  https://review.openstack.org/39767510:58
*** khamtamtun has joined #openstack-mistral11:01
openstackgerritSharat Sharma proposed openstack/python-mistralclient: Removed the extra space from tox.ini  https://review.openstack.org/39768311:03
*** hparekh has quit IRC11:36
*** thrash|g0ne is now known as thrash11:43
*** sharatss has quit IRC11:55
*** sharatss has joined #openstack-mistral11:57
sharatssrakhmerov d0ugal ddeja rbrady: anyone free?12:01
d0ugalsharatss: What's up?12:01
d0ugalThose reviews? :)12:01
sharatsshttp://logs.openstack.org/83/397683/1/check/gate-python-mistralclient-python35-nv/a152aa5/console.html12:02
* d0ugal looks12:02
sharatssI am getting Assertion Error for all mistralclient commits12:02
sharatssam i going wrong somewhere?12:02
d0ugalsharatss: I think you can ignore the python35 check for now.12:03
d0ugalsharatss: (it is non-voting, I assume because it isn't stable)12:03
sharatssd0ugal: ok. this might sound silly now12:03
d0ugalsharatss: but I don't understand what that error means.12:03
sharatssd0ugal: how can i get jenkins to pass that?12:04
d0ugalsharatss: Jenkins will still +1 if it fails12:04
d0ugalsharatss: but if you actually want to fix the check... I'm not sure.12:04
sharatssd0ugal: thanks for the quick response as always12:05
sharatssd0ugal: the devstack-dvsm also often fails12:05
d0ugalsharatss: Yeah, that is a bigger problem :)12:05
d0ugalbecause jenkins will -1 you12:05
d0ugalso lets see what is wrong there..12:06
sharatssd0ugal: unit tests fail there12:06
sharatssd0ugal: the patch i am referring to now is just given as a test patch since it removes only an extra space12:07
d0ugalsharatss: I wonder if this is related to the transaction changes12:07
d0ugalsharatss: because it is related to lazy loading12:07
d0ugali.e. http://logs.openstack.org/83/397683/1/check/gate-python-mistralclient-devstack-dsvm/6a79fa7/console.html#_2016-11-15_11_48_37_16158012:07
sharatssd0ugal: yes. is there a way we can fix it?12:08
* ddeja is reading the conversation12:08
d0ugalsharatss: good question. I am looking for the traceback12:09
d0ugalhttp://logs.openstack.org/83/397683/1/check/gate-python-mistralclient-devstack-dsvm/6a79fa7/logs/screen-mistral-api.txt.gz#_2016-11-15_11_37_24_71712:09
d0ugalThat looks bad12:10
sharatssd0ugal: even i am looking if there is a permanent fix for this12:10
d0ugalIf you grep that link for DetachedInstanceError it happens a few times.12:10
d0ugalsharatss: Yeah, me too now :)12:10
sharatssd0ugal: should find a way to pass this lazy load12:11
sharatssd0ugal: i will spend today on this issue12:12
d0ugalsharatss: okay, I'll keep looking for a bit and let you know if I find anything12:15
sharatssd0ugal: sure. thanks for taking time to help me12:15
d0ugalsharatss: np, I think we might have broken something for everyone12:16
d0ugalso I am helping myself too :-D12:16
sharatssd0ugal: :)12:16
ddejad0ugal, sharatss I think I found the issue12:17
sharatssddeja: great. where is the problem?12:17
ddejastarting from the begging of traceback that d0ugal showed12:18
ddejahttp://logs.openstack.org/83/397683/1/check/gate-python-mistralclient-devstack-dsvm/6a79fa7/logs/screen-mistral-api.txt.gz#_2016-11-15_11_37_24_71712:18
ddejafirstly we call get_all and then _get_action_executions from file /opt/stack/new/mistral/mistral/api/controllers/v2/action_execution.py12:18
ddejathen it calls 'get_all' from /opt/stack/new/mistral/mistral/utils/rest_utils.py12:19
ddejawhich, in line 167 calls the db directly12:19
ddejaaaand this call is not in the transaction12:19
ddejaco then, when we try to load additional data in line 176, there is no sessios so the lazy loading fails12:20
d0ugalI think I just found this too12:20
d0ugalI have replecated the issue in my dev env12:20
* ddeja is wondering why it happens only on the mistrialclient12:20
d0ugalddeja: https://review.openstack.org/#/c/395696/12:21
d0ugaldevstack is non-voting12:21
d0ugalwe need to fix that12:21
ddejaoh12:21
d0ugalYeah, it failed with the same error.12:22
d0ugalhttp://logs.openstack.org/96/395696/22/check/gate-mistral-devstack-dsvm/d43f8f3/console.html.gz#_2016-11-11_13_22_03_86424512:22
ddejawe need this patch in, I guess? https://review.openstack.org/#/c/396128/3/mistral/api/controllers/v2/action_execution.py12:22
ddejad0ugal: ^12:22
ddejait passed the dsvm gate12:22
d0ugalddeja: oh, cool. yeah12:23
d0ugalddeja: that is roughly what I was just testing12:23
d0ugalI missed that patch12:23
d0ugalactually, I already reviewed it, I just forgot about it lol12:23
ddejabut hm, this function that is failin12:24
ddejastill doesn't have any transactions12:24
ddejaoh, it has this12:24
ddejahttps://review.openstack.org/#/c/396128/3/mistral/utils/rest_utils.py12:24
ddejaOK, reviewing briefly12:25
d0ugalthanks12:25
ddejasharatss: thanks for birnging it up!12:25
sharatssddeja: np :) anyway i will also be benifited if this gets fixed12:26
d0ugalddeja, sharatss: https://review.openstack.org/#/c/397717/12:28
*** catintheroof has joined #openstack-mistral12:28
*** dprince has joined #openstack-mistral12:33
*** bobh has joined #openstack-mistral13:09
*** bobh has quit IRC13:09
*** bobh has joined #openstack-mistral13:09
*** khamtamtun has quit IRC13:16
xavierhardyddeja: I have replied to your comments13:17
xavierhardyI agree with them. If there's no opposition, I will modify them the way you want it13:17
* ddeja is looking13:18
ddejaxavierhardy: you mean for this patch? https://review.openstack.org/#/c/396128/313:18
ddejaIf so, I don't see any comments13:18
*** gnuoy has quit IRC13:19
xavierhardythey only appear as drafts...13:19
ddejaoh13:19
ddejabut basically, only the one in file task.py is critical13:20
xavierhardyhow do I publish drafts13:20
xavierhardy?13:20
openstackgerritSharat Sharma proposed openstack/python-mistralclient: Added the reno for stable/mitaka stable/newton and stable/liberty  https://review.openstack.org/39773613:20
ddejayou click 'reply' on the https://review.openstack.org/#/c/396128/3 and post13:20
xavierhardyYeah, found it just now13:20
*** bobh has quit IRC13:26
xavierhardydoing13:26
openstackgerritXavier Hardy proposed openstack/mistral: Fix possible DB race conditions in REST controller  https://review.openstack.org/39612813:27
xavierhardydone13:28
openstackgerritMerged openstack/mistral: Added senlin action pack  https://review.openstack.org/39558713:29
openstackgerritSharat Sharma proposed openstack/mistral-dashboard: Added reno for stable/mitaka, stable/liberty and stable/newton  https://review.openstack.org/39774113:31
*** mgershen has joined #openstack-mistral13:39
openstackgerritSharat Sharma proposed openstack/mistral-lib: Added reno for stable/mitaka, stable/liberty and stable/newton  https://review.openstack.org/39774513:40
openstackgerritSharat Sharma proposed openstack/python-mistralclient: Remove unused pylint  https://review.openstack.org/39764213:42
d0ugalrakhmerov: https://review.openstack.org/#/c/397717/13:45
d0ugalsharatss: Hey, just looking at the i18n blueprint.13:46
d0ugalsharatss: I think it looks good13:46
d0ugalI don't have any other feedback at the moment :)13:46
sharatssd0ugal: thank you :)13:46
d0ugalsharatss: For something a bit related, do you have any idea how we can help users translate strings in Mistral workflows?13:47
sharatssd0ugal: yes. i will start working once it gets approved13:47
sharatssd0ugal: i am not sure about it13:48
sharatssd0ugal: may be i should try to find that out13:48
d0ugalsharatss: I think it is a different problem, because workflows are user content rather than something in Mistral13:49
d0ugalbut I have been thinking about it and I don't have any good ideas.13:49
sharatssd0ugal: that sounds interesting13:50
sharatssd0ugal: i will try to find something if possible on this and let you know if I find something13:50
d0ugalsharatss: Great, thanks!13:52
sharatssd0ugal: My pleasure :) i am happy to be a part of Mistral13:53
ddejaxavierhardy: thanks for the patch. I'll give +2 if jenkins pass13:54
xavierhardyCool, thanks13:55
*** khamtamtun has joined #openstack-mistral13:58
openstackgerritMerged openstack/mistral: Few changes in the doc  https://review.openstack.org/39706714:00
*** mgershen has quit IRC14:16
*** khamtamtun has quit IRC14:16
openstackgerritSharat Sharma proposed openstack/mistral: Add timestamp at the bottom of every page  https://review.openstack.org/39776114:18
*** mgershen has joined #openstack-mistral14:25
*** jaosorior has quit IRC14:36
openstackgerritSharat Sharma proposed openstack/mistral-dashboard: Remove mox and mox3 in test-requirement.txt  https://review.openstack.org/39777014:42
*** khamtamtun has joined #openstack-mistral14:45
*** khamtamtun has quit IRC14:50
d0ugalddeja: when Mistral states something is "RUNNING" does that sometimes mean it is scheduled and waiting to run?14:53
*** jpich has left #openstack-mistral14:54
*** jpich has joined #openstack-mistral14:54
openstackgerritSharat Sharma proposed openstack/mistral-dashboard: Remove mox in test-requirement.txt  https://review.openstack.org/39777014:57
ddejad0ugal: I'm not sure14:58
ddejalet me check14:58
ddejad0ugal: yes, scheduled actions have the state set to 'RUNNING'15:00
d0ugalddeja: that's a shame, we should have a SCHEDULED state IMO15:00
ddejahttps://github.com/openstack/mistral/blob/master/mistral/engine/actions.py#L124-L13615:00
d0ugalddeja: thanks15:00
ddejaI agree that this is misleading15:01
ddejabut right now we don't reallly have a scheduler15:02
ddejasorry15:02
ddejalet me re-phrase15:02
ddejawe don't use scheduler for running actions15:02
sharatssddeja: d0ugal hi15:03
d0ugalddeja: right15:03
d0ugalddeja: but I think it is the same with workflows - they are created as "RUNNING"15:03
ddejaso the requests to run action would be send almost immediately15:03
sharatsspy35 jobs may be failing because https://review.openstack.org/#/c/391025/1/mistralclient/openstack/common/cliutils.py got it fixed15:03
d0ugalddeja: oh, no, workflows are IDLE to start with. hmm15:03
d0ugalddeja: I was testing something and I ended up with hundreds of running actions and workflows - I don't believe they are all running :)15:04
ddejad0ugal: they may not be running15:04
*** bobh has joined #openstack-mistral15:05
d0ugalddeja: right15:05
ddejabut if they are on the RPC call, we can not say what are really the status15:05
d0ugalddeja: and these were all triggered by workflows btw, no direct action calls.15:05
ddejasharatss: thanks, I'll take a look on this15:05
d0ugalddeja: anyway, it isn't important for now, I am just thinking :)15:05
sharatssddeja: and the complete openstack directory has been removed now??15:06
ddejad0ugal: for direct action call is OK, because we create the action in the DB and then send a request to do it to executor15:06
ddejasharatss: which directory?15:06
sharatssddeja: mistralclient/openstack15:07
ddejasharatss: I'm not aware of such change...15:07
ddejaoh, you mean that patch https://review.openstack.org/#/c/391025/1 fixed the gate and then whole directory was deleted?15:08
sharatssddeja: now i dont find the openstack/common folder in the repo15:08
ddejaincluding the fix?15:08
mgershend0ugal: BTW we do have WAITING for tasks that have join on them and waiting for other task executions to finish.15:08
sharatssddeja: yes15:08
ddejasharatss: that patch removed it https://review.openstack.org/#/c/395082/15:09
ddejasharatss: hm, it seems that you are right15:10
d0ugalmgershen: oh yeah, thanks. I guess I need to look into this more.15:11
sharatssddeja: what can be done now?15:11
ddejasharatss: we should check where the inspect.getargspec() was used and change it to signature()15:12
sharatssddeja: i tried grepping it. i will try again and see if i can find some possible solution15:13
ddejasharatss: If I see correctly, only this test fails rght now mistralclient.tests.unit.v2.test_cli_bash_completion.TestCLIBashCompletionV2.test_bash_completion15:14
sharatssddeja: yes. i will try to look into this15:19
sharatssddeja: a minor change should fix this i guess15:19
ddejad0ugal: the alternative is to change the state of task from 'WAITING' to 'RUNNING' once we got the response from RPC, but it would double our db calls15:21
ddejaand to be honest, I'm not sure if we still need the method schedule from /mistral/enigne/actions.py15:23
ddejaIt logically does nearly the same what run does15:24
ddejaoh, wait, there is a difference in what is returned15:24
ddejabut it's the only one15:25
openstackgerritSharat Sharma proposed openstack/mistral: Add timestamp at the bottom of every page  https://review.openstack.org/39776115:27
*** openstackgerrit has quit IRC15:48
*** openstackgerrit has joined #openstack-mistral15:48
openstackgerritMerged openstack/mistral: Fix possible DB race conditions in REST controller  https://review.openstack.org/39612815:50
*** sharatss has quit IRC15:50
*** sharatss has joined #openstack-mistral15:51
*** rrecio_ has joined #openstack-mistral15:53
*** mgershen has quit IRC17:05
*** thrash is now known as thrash|f00dz17:14
*** thrash|f00dz is now known as thrash17:50
*** jpich has quit IRC17:51
*** dprince has quit IRC18:21
*** dprince has joined #openstack-mistral18:21
*** harlowja has quit IRC18:38
*** shardy has quit IRC18:39
*** harlowja has joined #openstack-mistral19:06
*** dprince has quit IRC19:23
openstackgerritOpenStack Proposal Bot proposed openstack/mistral: Updated from global requirements  https://review.openstack.org/39789919:31
*** sharatss has quit IRC21:21
*** sharatss has joined #openstack-mistral21:22
*** harlowja has quit IRC21:55
*** harlowja has joined #openstack-mistral22:13
*** catinthe_ has joined #openstack-mistral22:18
*** catintheroof has quit IRC22:21
*** khamtamtun has joined #openstack-mistral22:29
*** catintheroof has joined #openstack-mistral22:35
*** catinthe_ has quit IRC22:36
*** khamtamtun has quit IRC22:59
*** bobh has quit IRC23:05
*** rrecio_ has quit IRC23:05
*** catintheroof has quit IRC23:52
*** catintheroof has joined #openstack-mistral23:54
*** sharatss has quit IRC23:54
*** sharatss has joined #openstack-mistral23:55
*** catintheroof has quit IRC23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!