| *** lucky_s has joined #openstack-mistral | 00:26 | |
| *** lucky_s has quit IRC | 00:28 | |
| *** lucky_s has joined #openstack-mistral | 00:29 | |
| *** bobh has joined #openstack-mistral | 01:25 | |
| *** bobh has quit IRC | 01:30 | |
| *** bobh has joined #openstack-mistral | 02:01 | |
| openstackgerrit | zhangyanxian proposed openstack/mistral: Adding Variables to Log Messages https://review.openstack.org/393622 | 02:03 |
|---|---|---|
| *** bobh has quit IRC | 02:05 | |
| *** bobh has joined #openstack-mistral | 02:38 | |
| *** bobh has quit IRC | 03:03 | |
| *** bobh has joined #openstack-mistral | 03:05 | |
| *** bobh has quit IRC | 03:06 | |
| *** Pawnesh has joined #openstack-mistral | 03:49 | |
| openstackgerrit | Merged openstack/python-mistralclient: Remove unused openstack/common/apiclient/client https://review.openstack.org/393084 | 04:42 |
| *** chlong has joined #openstack-mistral | 04:47 | |
| *** hparekh has joined #openstack-mistral | 05:14 | |
| *** sharatss has joined #openstack-mistral | 05:26 | |
| openstackgerrit | pawnesh kumar proposed openstack/mistral: Replace oslo_utils.timeutils.isotime https://review.openstack.org/394266 | 05:36 |
| openstackgerrit | Sharat Sharma proposed openstack/mistral: Few changes related to the doc blueprint https://review.openstack.org/392666 | 05:41 |
| *** janki has joined #openstack-mistral | 05:43 | |
| openstackgerrit | Merged openstack/mistral: Fix DB API transaction() https://review.openstack.org/393187 | 06:19 |
| openstackgerrit | Merged openstack/python-mistralclient: Updated from global requirements https://review.openstack.org/394126 | 06:43 |
| openstackgerrit | Merged openstack/mistral: Updated from global requirements https://review.openstack.org/394096 | 07:00 |
| rakhmerov | ddeja: hi Dawid | 07:01 |
| rakhmerov | you here? | 07:01 |
| rakhmerov | I'd like you to take a look at the two bugs: https://bugs.launchpad.net/mistral/+bug/1624284 and https://bugs.launchpad.net/mistral/+bug/1638905 | 07:02 |
| openstack | Launchpad bug 1624284 in Mistral "MessagingTimeout when executing mistral actions" [Critical,In progress] - Assigned to Dawid Deja (dawid-deja-0) | 07:02 |
| openstack | Launchpad bug 1638905 in Mistral "MessagingTimeout in mistral-executor.log causes task to remain RUNNING " [Undecided,New] | 07:02 |
| openstackgerrit | pawnesh kumar proposed openstack/mistral: Replace oslo_utils.timeutils.isotime https://review.openstack.org/394266 | 07:02 |
| rakhmerov | the first one is that patch you were fixing | 07:02 |
| rakhmerov | it's mostly fixed as far as I know | 07:02 |
| rakhmerov | the second one is something we discovered recently | 07:03 |
| rakhmerov | can you please take a look and see if they are related? | 07:03 |
| openstackgerrit | pawnesh kumar proposed openstack/mistral: Add oslo.i18n module in mistral project https://review.openstack.org/393230 | 07:34 |
| ddeja | rakhmerov: sure, I'll take a look today | 07:44 |
| ddeja | and I'll also dig through review emails ;) | 07:45 |
| d0ugal | Morning | 07:46 |
| ddeja | Hi d0ugal | 07:47 |
| d0ugal | Hows everyone doing? | 07:50 |
| openstackgerrit | Istvan Imre proposed openstack/mistral: Handle region_name in openstack actions https://review.openstack.org/389183 | 07:54 |
| openstackgerrit | Istvan Imre proposed openstack/python-mistralclient: Add ragion-name and target-region-name command line argument. https://review.openstack.org/386403 | 07:54 |
| rakhmerov | ddeja: morning :) | 08:00 |
| rakhmerov | d0ugal: morning :) | 08:00 |
| rakhmerov | d0ugal: I'm alright | 08:01 |
| rakhmerov | honestly, I was kind of lazy last week | 08:01 |
| rakhmerov | after the summit | 08:01 |
| rakhmerov | and was a little bit sick | 08:01 |
| rakhmerov | but now I'm ok ) | 08:01 |
| rakhmerov | ready to move mountains | 08:01 |
| d0ugal | rakhmerov: haha, me too | 08:01 |
| d0ugal | I feel a bit better now | 08:01 |
| rakhmerov | yeah | 08:01 |
| d0ugal | Not quite at mountain level yet | 08:01 |
| rakhmerov | it's all due to spanish beer I guess ;)) | 08:02 |
| d0ugal | haha, probably | 08:03 |
| * d0ugal checks out the mistral review queue | 08:03 | |
| rakhmerov | sharatss: Sharat, https://blueprints.launchpad.net/python-mistralclient/+spec/subcommand-parser looks good to me | 08:07 |
| rakhmerov | would you like to work on it? | 08:07 |
| d0ugal | rakhmerov: Why does start_tx need to be outside of the try block? | 08:13 |
| d0ugal | oh | 08:13 |
| d0ugal | rakhmerov: nevermind | 08:13 |
| d0ugal | I read the commit message, it explained it | 08:13 |
| rakhmerov | yes | 08:13 |
| * d0ugal is still waking up | 08:13 | |
| d0ugal | Sorry | 08:13 |
| rakhmerov | it doesn't make sense to handle an exception in start_tx | 08:14 |
| d0ugal | Yeah, it makes sense. | 08:14 |
| rakhmerov | pretty much common pattern | 08:14 |
| rakhmerov | ok | 08:14 |
| d0ugal | I have ran out of coffee - that is my excuse :) | 08:14 |
| rakhmerov | sure, no problem :) | 08:14 |
| rakhmerov | and we all need to recover after the summit :) | 08:15 |
| d0ugal | Indeed | 08:15 |
| d0ugal | I don't even feel like I have had time to recover, busy fixing and backporting to Newton :( | 08:15 |
| d0ugal | (in TripleO) | 08:15 |
| ddeja | rakhmerov: about this bug https://bugs.launchpad.net/mistral/+bug/1638905 do you know how to reproduce it? Since you've changed it to confirmed | 08:16 |
| openstack | Launchpad bug 1638905 in Mistral "MessagingTimeout in mistral-executor.log causes task to remain RUNNING " [Critical,Confirmed] - Assigned to Dawid Deja (dawid-deja-0) | 08:16 |
| rakhmerov | ddeja: we've seen it a number of times but we don't know a reliable way to reproduce it yet | 08:17 |
| rakhmerov | ddeja: we'll try to do it again today | 08:17 |
| rakhmerov | but it definitely happens sometimes | 08:17 |
| rakhmerov | on certain use cases | 08:17 |
| ddeja | rakhmerov: OK. To be honest it looks like the Rabbit is dropping the connection. But I can try to reproduce it | 08:18 |
| ddeja | can you post the wf that couse this somewhere? | 08:18 |
| rakhmerov | ddeja: if you have time | 08:18 |
| rakhmerov | it would be very helpful | 08:18 |
| rakhmerov | ddeja: ooh, this is a difficult part actually :) The wf that we're using is very complex and uses a bunch of custom actions and is tied to our env | 08:19 |
| rakhmerov | we'll try to come up with something simple that reproduces it | 08:19 |
| ddeja | hm, I see | 08:19 |
| rakhmerov | but what we know for now is: | 08:20 |
| rakhmerov | 1) that it happens on a task with 'std.noop' action | 08:20 |
| rakhmerov | 2) this task runs multiple times during WF execution | 08:20 |
| rakhmerov | #1 makes it really weird because it should work very fast | 08:20 |
| ddeja | ok, that's something to start with | 08:20 |
| rakhmerov | yeah | 08:20 |
| rakhmerov | sorry, we'll try to provide you with something more concrete | 08:21 |
| rakhmerov | ddeja: thanks for taking this | 08:21 |
| ddeja | rakhmerov: no problem | 08:23 |
| lucky_s | Hi rakhmerov | 08:33 |
| rakhmerov | lucky_s: hi | 08:34 |
| lucky_s | i have registered one blueprint regarding unit testing coverage | 08:35 |
| lucky_s | https://blueprints.launchpad.net/mistral/+spec/improve-unit-tests-coverage | 08:35 |
| lucky_s | request you to please confirm so that i will start on this blueprint . | 08:35 |
| *** chlong has quit IRC | 08:41 | |
| *** openstackgerrit has quit IRC | 08:48 | |
| *** jpich has joined #openstack-mistral | 08:48 | |
| *** openstackgerrit has joined #openstack-mistral | 08:48 | |
| *** sharatss has quit IRC | 08:52 | |
| *** shardy has joined #openstack-mistral | 09:00 | |
| *** lucky_s has quit IRC | 09:02 | |
| d0ugal | rakhmerov: How long does Mistral plan to support the V2 of the API once 3 is released? | 09:31 |
| d0ugal | designed, implemented and released* :) | 09:32 |
| rakhmerov | lucky_s: ok | 09:32 |
| rakhmerov | d0ugal: well, we'll have to support V2 for a long time | 09:32 |
| rakhmerov | at least several cycles | 09:33 |
| d0ugal | haha, yeah, that is what I hoped :) | 09:33 |
| rakhmerov | sure | 09:33 |
| rakhmerov | in the beginning we had V1 which was completely dropped | 09:33 |
| d0ugal | Yeah, that seemed to happen quickly | 09:33 |
| rakhmerov | and some people blamed us for that, but that was kind of a POC version of the API | 09:33 |
| d0ugal | I see | 09:34 |
| d0ugal | more like a V0 :) | 09:34 |
| rakhmerov | after that we reworked the whole model | 09:34 |
| rakhmerov | and now we don't see that we need to make to many changes in models so V2 won't be really conflicting with V3 too much | 09:34 |
| rakhmerov | yes, like V0 | 09:34 |
| rakhmerov | mostly V3 will be about standardizing everything across multiple endpoints | 09:35 |
| rakhmerov | naming consistency, sorting, filtering etc. | 09:35 |
| rakhmerov | I expect though significant changes in CLI | 09:35 |
| rakhmerov | but that's a different story | 09:35 |
| rakhmerov | I'd like to actually rework it completely | 09:35 |
| rakhmerov | d0ugal: do you still want to help with finding a new time slot for the team meeting? | 09:50 |
| rakhmerov | :) | 09:50 |
| d0ugal | Sure, happy to help with that | 09:51 |
| d0ugal | I look forward to the CLI changes, I have found it a bit strange to use at times | 09:51 |
| d0ugal | Do you have a preference how we find a new time? | 09:51 |
| d0ugal | rakhmerov: the meeting time is actually better for me now because daylight savings has ended here :-D | 09:53 |
| rakhmerov | yeah, I see | 09:54 |
| rakhmerov | d0ugal: so | 09:54 |
| rakhmerov | the problem we would like to address is that we have contributors from North America | 09:54 |
| rakhmerov | and Asia | 09:54 |
| rakhmerov | for example, for people in CA the current time is not convenient | 09:55 |
| rakhmerov | for it's kind of ok | 09:55 |
| *** shardy has quit IRC | 09:55 | |
| rakhmerov | for New Zeland it's not good at all | 09:55 |
| d0ugal | lol | 09:55 |
| d0ugal | well, it is impossible to find a time for everyone | 09:55 |
| rakhmerov | and we have there people too | 09:55 |
| d0ugal | we could do alternating meetings | 09:55 |
| rakhmerov | yes | 09:55 |
| rakhmerov | right | 09:55 |
| d0ugal | I think some teams do that, but I am not sure. | 09:55 |
| rakhmerov | the idea was to make it bi-weekly | 09:56 |
| rakhmerov | yes | 09:56 |
| rakhmerov | one week it should be convenient for us who are more or less close | 09:56 |
| rakhmerov | another week for them who are farther | 09:56 |
| d0ugal | Sure, sounds good. | 09:56 |
| rakhmerov | it's not easy I guess | 09:57 |
| d0ugal | Nope, not really. | 09:57 |
| d0ugal | I think we should find out who wants to come to the meetings and plan it around them. | 09:57 |
| rakhmerov | I remember I found some good time slots (after some quick survey on ML) but then one of them got occupied again | 09:57 |
| *** shardy has joined #openstack-mistral | 09:57 | |
| rakhmerov | d0ugal: ok | 09:57 |
| rakhmerov | anyway, we need to start this process over | 09:57 |
| rakhmerov | because we now have more contributors | 09:58 |
| d0ugal | A simple approach might be to start an etherpad and have everyone add their names and the times they can do. | 09:59 |
| openstackgerrit | pawnesh kumar proposed openstack/mistral: Replace uuid4() with generate_uuid() from oslo_utils https://review.openstack.org/394346 | 10:06 |
| rakhmerov | d0ugal: yes, sounds ok | 10:06 |
| *** shardy_ has joined #openstack-mistral | 10:07 | |
| d0ugal | Pawnesh: Hey | 10:07 |
| d0ugal | rakhmerov: but we can do it any way, I don't mind really :) | 10:07 |
| Pawnesh | d0ugal: Hi | 10:08 |
| d0ugal | Pawnesh: Is there somewhere I can read more about generate_uuid? | 10:08 |
| d0ugal | Pawnesh: I had seen it before in other projects, but didn't know why it was better than uuid | 10:08 |
| d0ugal | Pawnesh: oh, I see it just uses uuid.uuid4 anyway :/ | 10:09 |
| *** shardy has quit IRC | 10:10 | |
| *** shardy_ is now known as shardy | 10:14 | |
| Pawnesh | d0ugal: Thanks for reviewing. For consistency in openstack , we are using generate_uuid. generate_uuid() method returns str and doesn't have 'hex' property so I haven't changed it in some places. | 10:18 |
| d0ugal | Pawnesh: I see, thanks. | 10:32 |
| ddeja | rakhmerov: I've run this http://paste.openstack.org/show/588229/ 100 times, and saw no error. Right now I would say that this is related to rabbitmq configuration/misbehaviour. But I may be wrong of course ;) | 10:34 |
| rakhmerov | ddeja: ok, thanks | 10:35 |
| rakhmerov | Once we have more data we'll share with you | 10:35 |
| ddeja | rakhmerov: do you have some joins in your wf? | 10:36 |
| rakhmerov | yes | 10:36 |
| rakhmerov | but it's very complicated :) | 10:36 |
| ddeja | maybe it is related to join logic and happens on std.noop by coinsidence? | 10:36 |
| rakhmerov | maybe | 10:36 |
| ddeja | ok, I'll add some crazy joins and try one more time :) | 10:36 |
| *** jaosorior has joined #openstack-mistral | 10:38 | |
| ddeja | rakhmerov: oh, I've looked second time on the bug description | 10:43 |
| rakhmerov | ok, so? :) | 10:43 |
| ddeja | and I think this is the same problem as in https://bugs.launchpad.net/mistral/+bug/1624284 | 10:43 |
| openstack | Launchpad bug 1624284 in Mistral "MessagingTimeout when executing mistral actions" [Critical,In progress] - Assigned to Dawid Deja (dawid-deja-0) | 10:43 |
| rakhmerov | ooh, really? | 10:44 |
| ddeja | this call "self._engine_client.on_action_complete(action_ex_id, result)" happens in error on executor side | 10:44 |
| rakhmerov | ok | 10:44 |
| ddeja | but now this call looks like this https://github.com/openstack/mistral/blob/master/mistral/engine/default_executor.py#L110-L114 | 10:44 |
| rakhmerov | honestly, I just don't remember all the details from our discussions around it | 10:44 |
| ddeja | see the missing "async=True" parameter ;) | 10:45 |
| rakhmerov | wait a sec... | 10:45 |
| rakhmerov | ooh, shoot... | 10:47 |
| rakhmerov | you're right | 10:47 |
| rakhmerov | you have a sharp eye :) | 10:47 |
| ddeja | so basically you have not most up-to-date mistral ;) | 10:47 |
| rakhmerov | yes | 10:47 |
| rakhmerov | I actually thought it was more or less new | 10:48 |
| ddeja | I'm pretty sure that applaying this https://review.openstack.org/#/c/377834/ would fix a problem :) | 10:49 |
| d0ugal | Is that change in Newton? | 10:50 |
| ddeja | good question | 10:50 |
| rakhmerov | ddeja: let me clarify that.. | 10:50 |
| rakhmerov | my apologies, it's my fault, I should have checked what version it was | 10:51 |
| d0ugal | It seems it isn't in Newton | 10:51 |
| d0ugal | rakhmerov: maybe you need this backported? | 10:51 |
| rakhmerov | d0ugal: yes | 10:51 |
| rakhmerov | absolutely yes | 10:51 |
| rakhmerov | it's a critical issue | 10:51 |
| d0ugal | https://review.openstack.org/#/c/394358/ | 10:51 |
| rakhmerov | thanks Dougal | 10:52 |
| d0ugal | np | 10:53 |
| openstackgerrit | Istvan Imre proposed openstack/python-mistralclient: Region name related command line arguments are added. https://review.openstack.org/386403 | 10:54 |
| openstackgerrit | Istvan Imre proposed openstack/mistral: Handle region_name in openstack actions https://review.openstack.org/389183 | 10:58 |
| *** sharatss has joined #openstack-mistral | 11:01 | |
| openstackgerrit | Merged openstack/mistral: Added unit tests for workflow executions and task executions filtering https://review.openstack.org/372417 | 11:11 |
| openstackgerrit | Merged openstack/mistral: cors: update default configuration https://review.openstack.org/394046 | 11:13 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Add unit test cases some miss scenario in test_task.py https://review.openstack.org/375792 | 11:13 |
| *** chlong has joined #openstack-mistral | 11:16 | |
| rakhmerov | ddeja: we checked, it was really a pretty old version | 11:19 |
| rakhmerov | 1-1.5 months old | 11:19 |
| rakhmerov | ddeja: sorry for the confusion | 11:19 |
| openstackgerrit | Istvan Imre proposed openstack/python-mistralclient: Region name related command line arguments are added https://review.openstack.org/386403 | 11:55 |
| *** dprince has joined #openstack-mistral | 11:57 | |
| ddeja | rakhmerov: no problem :) | 11:58 |
| *** hparekh has quit IRC | 12:29 | |
| openstackgerrit | Merged openstack/mistral-dashboard: Delete *openstack/common* in flake8 exclude list https://review.openstack.org/394023 | 12:29 |
| *** shardy has quit IRC | 12:41 | |
| *** bobh has joined #openstack-mistral | 12:59 | |
| *** bobh has quit IRC | 12:59 | |
| *** bobh has joined #openstack-mistral | 13:00 | |
| *** janki has quit IRC | 13:02 | |
| openstackgerrit | Merged openstack/mistral: Replace oslo_utils.timeutils.isotime https://review.openstack.org/394266 | 13:17 |
| d0ugal | rakhmerov: https://review.openstack.org/#/c/375792 looks good after I rebased it. | 13:23 |
| *** bobh has quit IRC | 13:26 | |
| *** bobh has joined #openstack-mistral | 13:32 | |
| *** bobh has quit IRC | 13:45 | |
| *** bobh has joined #openstack-mistral | 14:23 | |
| *** shardy has joined #openstack-mistral | 14:27 | |
| *** jaosorior has quit IRC | 14:32 | |
| *** jaosorior has joined #openstack-mistral | 14:33 | |
| *** chlong has quit IRC | 14:34 | |
| *** jaosorior is now known as jaosorior_sick | 15:09 | |
| *** rrecio has joined #openstack-mistral | 15:41 | |
| *** cargonza has quit IRC | 15:42 | |
| *** kozhukalov has quit IRC | 15:42 | |
| *** zhenguo has quit IRC | 15:42 | |
| *** rrecio_ has joined #openstack-mistral | 15:44 | |
| *** rrecio has quit IRC | 15:46 | |
| *** zhenguo has joined #openstack-mistral | 15:46 | |
| *** cargonza has joined #openstack-mistral | 15:46 | |
| *** kozhukalov has joined #openstack-mistral | 15:48 | |
| *** Ravikiran_K has joined #openstack-mistral | 15:54 | |
| d0ugal | Mistral meeting time in #openstack-meeting | 16:03 |
| *** vishwanathj has joined #openstack-mistral | 16:40 | |
| *** vishwanathj has quit IRC | 17:03 | |
| *** jpich has quit IRC | 17:47 | |
| *** shardy has quit IRC | 18:07 | |
| *** jaosorior_sick has quit IRC | 18:14 | |
| *** Ravikiran_K has quit IRC | 18:22 | |
| *** d0ugal has quit IRC | 19:30 | |
| *** d0ugal has joined #openstack-mistral | 19:31 | |
| *** d0ugal has joined #openstack-mistral | 19:31 | |
| *** dprince has quit IRC | 20:00 | |
| *** d0ugal has quit IRC | 20:26 | |
| *** d0ugal has joined #openstack-mistral | 20:27 | |
| *** d0ugal has joined #openstack-mistral | 20:27 | |
| *** jamielennox is now known as jamielennox|away | 21:19 | |
| *** jamielennox|away is now known as jamielennox | 22:02 | |
| openstackgerrit | Winson Chan proposed openstack/mistral: Add cancelled state to action executions https://review.openstack.org/383972 | 22:50 |
| *** rrecio_ has quit IRC | 23:01 | |
| *** rrecio has joined #openstack-mistral | 23:01 | |
| *** bobh has quit IRC | 23:10 | |
| *** rrecio has quit IRC | 23:46 | |
| *** lucky_s has joined #openstack-mistral | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!