| kong | rakhmerov, ddeja, could you please review https://review.openstack.org/#/c/388590/? my colleague was hitting this on his trial for mistral (master branch) | 02:09 |
|---|---|---|
| *** pawnesh has joined #openstack-mistral | 03:52 | |
| openstackgerrit | pawnesh kumar proposed openstack/python-mistralclient: Removed openstack/common/importutils.py https://review.openstack.org/393076 | 04:03 |
| rakhmerov | kong: done | 04:13 |
| kong | rakhmerov: thanks | 04:14 |
| kong | rakhmerov: how was the summit? | 04:14 |
| pawnesh | Can we remove mistralclient/openstack/common/apiclient/client.py , As mistralclient has its own HTTP client (mistralclient/api/httpclient.py) ?? | 04:22 |
| kong | pawnesh: hi, if that file is no longer used, yes, we can remove that | 04:23 |
| pawnesh | kong: thanks | 04:24 |
| rakhmerov | pawnesh: yes, delete it | 04:29 |
| rakhmerov | kong: it was ok in general and pretty good for Mistral | 04:29 |
| rakhmerov | :) | 04:29 |
| kong | rakhmerov: any etherpad i can see for our priorities of next dev cycle | 04:30 |
| kong | ？ | 04:30 |
| rakhmerov | kong: for you there won't be probably anything really new, but yes | 04:31 |
| rakhmerov | give me a sec | 04:31 |
| rakhmerov | https://etherpad.openstack.org/p/mistral-barcelona-summit-topics-2016 | 04:31 |
| kong | rakhmerov: thanks, will take a look | 04:31 |
| rakhmerov | the most important things are captured there | 04:31 |
| rakhmerov | overall, it was a good productive discussion | 04:32 |
| rakhmerov | we'll be fixing our OpenStack integration part (actions, keystone) | 04:32 |
| rakhmerov | it's important for the project face | 04:32 |
| rakhmerov | StackStorm actions will be possible to use with Mistral directly in the future | 04:33 |
| rakhmerov | we'll make them compatible | 04:33 |
| rakhmerov | I think it's not even captured in the etherpad | 04:33 |
| kong | rakhmerov: how many people were involved in the design session? | 04:33 |
| rakhmerov | I think 13-15 | 04:34 |
| kong | wow, awesome | 04:34 |
| rakhmerov | it was less than on the previous summit (in Austin we didn't have enough chairs, 7-8 were standing) but it's good anyway | 04:34 |
| rakhmerov | d0ugal was there too | 04:35 |
| openstackgerrit | pawnesh kumar proposed openstack/python-mistralclient: Remove unused openstack/common/apiclient/client https://review.openstack.org/393084 | 04:35 |
| kong | cool | 04:36 |
| rakhmerov | kong: can you please look at these small patches: https://review.openstack.org/#/c/390938/ and https://review.openstack.org/#/c/391025/ | 04:44 |
| rakhmerov | and this big one (important for me): https://review.openstack.org/#/c/390208/ | 04:45 |
| kong | rakhmerov: sure, will do tonight or tomorrow morning | 04:51 |
| rakhmerov | ok | 04:51 |
| openstackgerrit | Merged openstack/mistral-lib: Updated from global requirements https://review.openstack.org/392742 | 04:54 |
| *** hparekh has joined #openstack-mistral | 04:54 | |
| openstackgerrit | Merged openstack/mistral-dashboard: Updated from global requirements https://review.openstack.org/392741 | 04:55 |
| openstackgerrit | Merged openstack/mistral-lib: Update .coveragerc after the removal of openstack directory https://review.openstack.org/390074 | 04:59 |
| openstackgerrit | Merged openstack/python-mistralclient: Updated from global requirements https://review.openstack.org/392823 | 05:16 |
| openstackgerrit | Merged openstack/python-mistralclient: Fix python35 job failures https://review.openstack.org/391025 | 05:21 |
| openstackgerrit | Merged openstack/python-mistralclient: Removed openstack/common/importutils.py https://review.openstack.org/393076 | 05:44 |
| openstackgerrit | Merged openstack/python-mistralclient: Adding files to .gitignore https://review.openstack.org/390938 | 05:44 |
| *** openstackgerrit has quit IRC | 05:48 | |
| rakhmerov | pawnesh: please rebase https://review.openstack.org/#/c/393084/ | 05:48 |
| *** openstackgerrit has joined #openstack-mistral | 05:48 | |
| openstackgerrit | Merged openstack/mistral: Get correct inbound tasks context for retry policy https://review.openstack.org/388590 | 05:55 |
| pawnesh | rakhmerov: i am not able to rebase https://review.openstack.org/#/c/393084/ ; due to merge conflict | 06:02 |
| rakhmerov | you can't do it in gerrit just by pressing a button but you can resolve the conflict and resend the patch | 06:03 |
| rakhmerov | I also call it "rebase" | 06:04 |
| openstackgerrit | Merged openstack/mistral: Updated from global requirements https://review.openstack.org/392740 | 06:28 |
| *** sharatss has joined #openstack-mistral | 06:57 | |
| openstackgerrit | Hardik Parekh proposed openstack/python-mistralclient: Remove unused openstack/common/apiclient/client https://review.openstack.org/393084 | 07:19 |
| d0ugal | Morning | 07:25 |
| *** jaosorior has joined #openstack-mistral | 07:28 | |
| hparekh | d0ugal: Good Morning | 07:32 |
| *** jtomasek_ has joined #openstack-mistral | 07:41 | |
| *** openstackgerrit has quit IRC | 07:48 | |
| *** openstackgerrit has joined #openstack-mistral | 07:48 | |
| d0ugal | huh, that __actions feature in environments is some black magic :) | 07:50 |
| *** shardy has joined #openstack-mistral | 08:36 | |
| *** jpich has joined #openstack-mistral | 08:54 | |
| *** jtomasek_ is now known as jtomasek | 09:02 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Fix DB API transaction() https://review.openstack.org/393187 | 09:32 |
| *** tuan has joined #openstack-mistral | 09:33 | |
| tuan | Hi guys | 09:34 |
| tuan | i am now looking for some references about implementing TOSCA with Mistral | 09:35 |
| tuan | do we have any short summary/instruction about it | 09:35 |
| tuan | ? | 09:35 |
| tuan | thanks in advanced | 09:35 |
| *** jaosorior is now known as jaosorior_lunch | 09:41 | |
| kong | tuan, for supporting tosca, you need to implement a plugin mechanism for workflow parsing in mistral | 09:42 |
| kong | but i'm not sure, not farmilar with tosca | 09:43 |
| rakhmerov | tuan, kong: yeah, we just discussed it privately | 09:43 |
| rakhmerov | TOSCA is not related to Mistral directly | 09:44 |
| rakhmerov | it's just what we do at Nokia | 09:44 |
| rakhmerov | d0ugal: it is a black magic, yes ;) | 09:44 |
| tuan | yeap, since TOSCA is relevant for cloud app | 09:44 |
| kong | rakhmerov: yeah, i know, another orchestration template specification | 09:44 |
| d0ugal | rakhmerov: :) I only just learned about it when looking at the docs patch. | 09:44 |
| tuan | that is why we decide to go forward with it | 09:44 |
| rakhmerov | it was supposed to be a very cool feature but I believe it's not even documented well | 09:44 |
| *** jpich has quit IRC | 09:45 | |
| kong | tuan: have you already used mistral? | 09:45 |
| rakhmerov | d0ugal: quick question about your comment on decorators | 09:45 |
| d0ugal | rakhmerov: sure | 09:45 |
| kong | or you just want to use mistral unless tosca is supported? | 09:45 |
| rakhmerov | d0ugal: I am not sure what redundant level I have :) | 09:46 |
| rakhmerov | I'm not too good at decorators probably | 09:46 |
| rakhmerov | sorry | 09:46 |
| tuan | kong: yeap, we are directly working with it everyday | 09:46 |
| d0ugal | rakhmerov: np, let me write a quick example... | 09:47 |
| rakhmerov | so, I have too functions there, one takes 'func' which is the decorator | 09:47 |
| tuan | i just wanna know that there is any case study out there about tosca and mistral | 09:47 |
| rakhmerov | and I return it | 09:47 |
| rakhmerov | ok, sure | 09:47 |
| *** jpich has joined #openstack-mistral | 09:49 | |
| d0ugal | rakhmerov: http://paste.openstack.org/show/587731/ | 09:54 |
| d0ugal | rakhmerov: so the first decorator must be called with @process1() - note the "()" | 09:54 |
| d0ugal | rakhmerov: The first approach is only needed if you want to pass args to the decorator itself | 09:54 |
| d0ugal | rakhmerov: so, really, the first one is a function that returns a decorator, the second one is just a decorator. | 09:55 |
| d0ugal | ... I hope that makes sense :) | 09:55 |
| tuan | that really makes sense dOugal:) | 09:56 |
| d0ugal | \o/ | 09:56 |
| tuan | really pythonic way:) | 09:57 |
| kong | d0ugal: if you want to pass arguments to decorator itself, shouldn't it be this way http://paste.openstack.org/show/587732/? | 09:58 |
| d0ugal | kong: Yup, that looks good | 09:59 |
| kong | yeah, it's the same way ... | 09:59 |
| kong | :-) | 09:59 |
| d0ugal | kong: You use @wraps which is better, that was my other comment on the review :-D | 09:59 |
| d0ugal | I skipped that in the example tho' | 09:59 |
| kong | hah, don't know your context, just chime in | 09:59 |
| d0ugal | :) | 10:00 |
| tuan | :D, are you guys going to open a python class here. | 10:05 |
| kong | i still remember pepole were talking about 'if x is None' and 'if not x' in mailing list in 2013 | 10:06 |
| rakhmerov | d0ugal: reading.. | 10:07 |
| d0ugal | kong: haha, I would have enjoyed that one :) | 10:07 |
| rakhmerov | d0ugal: yes, it makes sense | 10:12 |
| rakhmerov | ok | 10:12 |
| rakhmerov | now I need to understand about functools.wraps() :) | 10:13 |
| rakhmerov | d0ugal: ok, I have to admit that I don't understand why to use functools.wraps | 10:23 |
| rakhmerov | can you explain pls? | 10:23 |
| rakhmerov | I removed the extra level like you said and it's look really concise now | 10:24 |
| rakhmerov | not sure what this wraps() will give us | 10:24 |
| kong | rakhmerov: without wraps(), you function metadata will be changed | 10:24 |
| kong | e.g. function name | 10:24 |
| kong | function name will be the decorator's name | 10:25 |
| rakhmerov | yes | 10:25 |
| rakhmerov | true | 10:25 |
| rakhmerov | is it the only reason to use it? | 10:26 |
| rakhmerov | or there's something else | 10:26 |
| kong | rakhmerov: i'm not sure, that's the only reason i know for using that | 10:26 |
| rakhmerov | ok, I see now | 10:27 |
| rakhmerov | that's why we pass the original function as a parameter | 10:27 |
| rakhmerov | it must be copying its metadata or something.. | 10:27 |
| kong | rakhmerov: yes, according to python documentation, besides the function name, will also affect function docstring if not using it | 10:28 |
| tuan | it is nothing else just the wrapper of a function | 10:28 |
| rakhmerov | ok, no problem | 10:28 |
| rakhmerov | I'll use it | 10:28 |
| rakhmerov | thanks for explanations | 10:29 |
| tuan | you can check it on itnernet about its usage | 10:29 |
| tuan | but one simple example like this | 10:29 |
| tuan | imagine if you need to call a function many times | 10:29 |
| * kong will stop teaching and get some sleep | 10:29 | |
| tuan | :D, good sleep Kong | 10:29 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Run actions without Scheduer https://review.openstack.org/390208 | 10:29 |
| kong | tuan: cheers | 10:29 |
| tuan | then you should check the result of that function | 10:30 |
| tuan | that is why we should put that function into decorator | 10:30 |
| tuan | each time you want to call it, jsut call decorator | 10:30 |
| tuan | the decorator will take the function, runs it, returns the result of that function | 10:30 |
| tuan | then you can get the result of that function to be parameter of other functions | 10:31 |
| tuan | it is the use case | 10:31 |
| tuan | :), hope it helps you more imaginable | 10:31 |
| tuan | actually, you can take a look into openstack source code, decorator is used every where | 10:32 |
| rakhmerov | tuan: thanks | 10:33 |
| rakhmerov | I have actually seen it many many times, I just didn't know why it was used | 10:33 |
| tuan | it will make your code shorter, cleaner | 10:33 |
| tuan | you can see in the source code of OpenStack | 10:34 |
| tuan | you will see a decorator will be used multiple times | 10:34 |
| tuan | when you use a decorator for a function | 10:34 |
| tuan | the affect of it is what i explain above | 10:34 |
| tuan | imagine, if you want to call that function 100 times | 10:35 |
| tuan | to get it result to be another parameter of others | 10:35 |
| tuan | it will be messy | 10:35 |
| tuan | put that function under decorator | 10:35 |
| tuan | do not worry, try to run some simple decorator | 10:36 |
| tuan | then you will understand it | 10:36 |
| rakhmerov | tuan: appreciate it, thanks | 10:36 |
| tuan | it is not the hard thing, believe me, :) | 10:36 |
| rakhmerov | I got it | 10:36 |
| rakhmerov | thanks | 10:36 |
| tuan | my pleasure :D | 10:36 |
| d0ugal | rakhmerov: functools.wraps just stops decorators obscuring the real function in tracebacks etc. | 10:38 |
| d0ugal | rakhmerov: that is my understanding at least | 10:38 |
| d0ugal | rakhmerov: but I see kong already said this :) | 10:39 |
| rakhmerov | ok | 10:39 |
| rakhmerov | I sent another patchset | 10:39 |
| rakhmerov | hopefully it looks better :) | 10:39 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Fix DB API transaction() https://review.openstack.org/393187 | 10:41 |
| d0ugal | rakhmerov: LGTM | 10:41 |
| rakhmerov | ok, tests also passed | 10:41 |
| openstackgerrit | pawnesh kumar proposed openstack/mistral: Add oslo.i18n module in mistral project https://review.openstack.org/393230 | 10:42 |
| rakhmerov | (dunno about tripleO gate though) | 10:42 |
| d0ugal | rakhmerov: we are having some CI issues at the moment, I'll take a look. | 10:43 |
| *** dprince has joined #openstack-mistral | 11:16 | |
| *** AlexeyAbashkin has quit IRC | 11:30 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 11:35 | |
| *** tuan has quit IRC | 11:39 | |
| *** jaosorior_lunch is now known as jaosorior | 11:44 | |
| rakhmerov | ddeja: can you look again at https://review.openstack.org/#/c/390208/ ? | 11:44 |
| openstackgerrit | Hardik Parekh proposed openstack/mistral: Added unit tests for workflow executions and task executions filtering https://review.openstack.org/372417 | 11:46 |
| *** AlexeyAbashkin has quit IRC | 11:49 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 11:50 | |
| *** hparekh has quit IRC | 11:52 | |
| ddeja | rakhmerov: looking | 12:16 |
| ddeja | rakhmerov: +2 +W | 12:18 |
| *** shardy is now known as shardy_lunch | 13:05 | |
| *** Kiall_ is now known as Kiall | 13:19 | |
| *** Alexey_Abashkin has joined #openstack-mistral | 13:27 | |
| *** AlexeyAbashkin has quit IRC | 13:30 | |
| *** bobh has joined #openstack-mistral | 14:10 | |
| *** shardy_lunch is now known as shardy | 14:13 | |
| *** jaosorior has quit IRC | 14:17 | |
| openstackgerrit | Merged openstack/mistral: Run actions without Scheduer https://review.openstack.org/390208 | 14:26 |
| *** rrecio has joined #openstack-mistral | 14:42 | |
| *** bobh has quit IRC | 14:44 | |
| *** rrecio has quit IRC | 14:44 | |
| *** rrecio has joined #openstack-mistral | 14:45 | |
| *** d0ugal has quit IRC | 14:57 | |
| rakhmerov | ddeja: thanks! | 15:01 |
| openstackgerrit | Istvan Imre proposed openstack/mistral: Handle region_name in openstack actions https://review.openstack.org/389183 | 15:12 |
| *** d0ugal has joined #openstack-mistral | 15:13 | |
| *** jaosorior has joined #openstack-mistral | 15:17 | |
| *** bobh has joined #openstack-mistral | 15:23 | |
| *** d0ugal has quit IRC | 15:39 | |
| *** bobh_ has joined #openstack-mistral | 15:40 | |
| *** bobh has quit IRC | 15:43 | |
| *** jtomasek has quit IRC | 15:44 | |
| *** jaosorior has quit IRC | 15:54 | |
| *** rrecio_ has joined #openstack-mistral | 16:04 | |
| *** rrecio has quit IRC | 16:07 | |
| *** tuan has joined #openstack-mistral | 16:46 | |
| *** jtomasek has joined #openstack-mistral | 16:52 | |
| *** Alexey_Abashkin_ has joined #openstack-mistral | 16:56 | |
| *** Alexey_Abashkin has quit IRC | 16:59 | |
| *** tuan has quit IRC | 17:10 | |
| *** harlowja has quit IRC | 17:43 | |
| *** harlowja has joined #openstack-mistral | 17:46 | |
| *** dprince has quit IRC | 18:15 | |
| *** jpich has quit IRC | 18:37 | |
| *** dprince has joined #openstack-mistral | 18:41 | |
| *** shardy has quit IRC | 19:11 | |
| *** dprince has quit IRC | 20:26 | |
| *** gyee has joined #openstack-mistral | 20:32 | |
| *** harlowja has quit IRC | 21:56 | |
| *** bobh_ has quit IRC | 22:03 | |
| *** rrecio_ has quit IRC | 22:06 | |
| *** rrecio has joined #openstack-mistral | 22:06 | |
| *** bobh has joined #openstack-mistral | 22:07 | |
| *** rrecio has quit IRC | 22:09 | |
| *** bobh has quit IRC | 22:11 | |
| *** bobh has joined #openstack-mistral | 23:23 | |
| *** bobh has quit IRC | 23:25 | |
| *** bobh has joined #openstack-mistral | 23:28 | |
| *** bobh has quit IRC | 23:30 | |
| *** gyee has quit IRC | 23:49 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!