Thursday, 2016-08-25

*** chlong has quit IRC00:13
*** chlong has joined #openstack-mistral00:26
openstackgerritOpenStack Proposal Bot proposed openstack/python-mistralclient: Updated from global requirements  https://review.openstack.org/36015401:11
*** Ephur has quit IRC02:37
*** bobh has joined #openstack-mistral03:00
*** tonytan4ever has quit IRC03:13
*** Ephur has joined #openstack-mistral03:16
*** chlong has quit IRC03:23
*** vishwanathj has joined #openstack-mistral03:25
*** Ephur has quit IRC03:30
*** vishwanathj is now known as vishwanathj_zzz03:31
*** chlong has joined #openstack-mistral03:35
*** chlong has quit IRC03:38
*** chlong has joined #openstack-mistral03:38
*** tonytan4ever has joined #openstack-mistral04:13
*** tonytan4ever has quit IRC04:18
*** Ravikiran_K has joined #openstack-mistral04:29
*** bobh has quit IRC04:30
*** jaosorior has joined #openstack-mistral05:10
*** janki has joined #openstack-mistral05:23
*** vishwanathj_zzz has quit IRC06:10
*** vishwanathj_zzz has joined #openstack-mistral06:10
*** vishwanathj_zzz has quit IRC06:32
*** vishwanathj_zzz has joined #openstack-mistral06:32
rakhmerovkong: done06:43
openstackgerritMerged openstack/mistral: Updated from global requirements  https://review.openstack.org/36023606:52
openstackgerritRenat Akhmerov proposed openstack/mistral: Change execution mechanism for 'join' tasks  https://review.openstack.org/35634306:57
*** sharatss has joined #openstack-mistral07:01
openstackgerritzhangyanxian proposed openstack/mistral: Some minior code optimization in post_test_hook  https://review.openstack.org/36028607:08
openstackgerritzhangyanxian proposed openstack/mistral: Some minior code optimization in post_test_hook  https://review.openstack.org/36028607:09
openstackgerritzhangyanxian proposed openstack/mistral: Some minior code optimization in post_test_hook  https://review.openstack.org/36028607:09
*** Ravikiran_K has quit IRC07:14
openstackgerritzhangyanxian proposed openstack/mistral: Some minior code optimization in post_test_hook.sh  https://review.openstack.org/36028607:15
*** tonytan4ever has joined #openstack-mistral07:15
*** vishwanathj_zzz has quit IRC07:19
*** vishwanathj_zzz has joined #openstack-mistral07:20
*** tonytan4ever has quit IRC07:20
brunograz_kong: Thx!07:26
*** jpich has joined #openstack-mistral07:41
*** shardy has joined #openstack-mistral07:47
*** mflobo has joined #openstack-mistral07:51
openstackgerritMerged openstack/python-mistralclient: Updated from global requirements  https://review.openstack.org/36015407:58
*** vishwanathj_zzz has quit IRC08:10
*** vishwanathj_zzz has joined #openstack-mistral08:10
openstackgerritzhangyanxian proposed openstack/mistral: Some minor code optimization in post_test_hook.sh  https://review.openstack.org/36028608:25
*** openstackgerrit has quit IRC08:48
*** openstackgerrit has joined #openstack-mistral08:48
rakhmerovddeja: hi, here?09:00
rakhmerovI have some questions on kombu based RPC09:01
rakhmerovwell, first of all, what is the status of your patches? Is https://review.openstack.org/#/c/354091 considered done? I saw that you were discussing something with kong09:02
*** tonytan4ever has joined #openstack-mistral09:16
*** tonytan4ever has quit IRC09:20
rakhmerovddeja: ^09:27
*** vishwanathj_zzz has quit IRC09:52
*** vishwanathj_zzz has joined #openstack-mistral09:53
ddejarakhmerov: hi09:54
rakhmerovhi09:54
ddejarakhmerov: yup, this one is done09:54
openstackgerritRenat Akhmerov proposed openstack/python-mistralclient: Send access info to server  https://review.openstack.org/35480309:55
openstackgerritRenat Akhmerov proposed openstack/mistral: Update documentation for multi-vim-support  https://review.openstack.org/35656709:58
ddejarakhmerov: I'm going for lunch, please write your question, I'll anwser when I got back09:58
rakhmerovok09:58
rakhmerovyeah, I wanted to ask for one more thing in RPC actually09:59
rakhmerovwe need something like 'executor' parameter in o.m09:59
rakhmerovso that we specifically could do something like executor='blocking'09:59
rakhmerovI found some interesting limitations with executor='eventlet' that I don't know how to overcome yet10:00
*** sharatss has quit IRC10:02
openstackgerritMerged openstack/mistral: Fix for not working 'run-action' on kombu driver  https://review.openstack.org/35409110:19
openstackgerritMerged openstack/mistral: Some minor code optimization in post_test_hook.sh  https://review.openstack.org/36028610:20
openstackgerritAndras Kovi proposed openstack/mistral: Accept service catalog from client side  https://review.openstack.org/35536810:25
openstackgerritAndras Kovi proposed openstack/mistral: Accept service catalog from client side  https://review.openstack.org/35536810:30
*** vishwanathj_zzz has quit IRC10:55
*** vishwanathj_zzz has joined #openstack-mistral10:56
openstackgerritAndras Kovi proposed openstack/mistral: Update documentation for multi-vim-support  https://review.openstack.org/35656711:00
ddejarakhmerov: OK, I see11:10
ddejaas far as I can tell in kombu driver we are using something like blocking executor11:11
rakhmerovddeja: what do you think? Is it too hard to do?11:11
rakhmerovreally?11:11
rakhmerovcan you check that somehow?11:11
rakhmerovif it's blocking then it's something that we probably need :)11:11
ddejale me test it to be sure, but i think all the calls would be done 'one-by-one'11:12
*** tonytan4ever has joined #openstack-mistral11:17
*** tonytan4ever has quit IRC11:22
*** nmakhotkin has joined #openstack-mistral11:27
openstackgerritAndras Kovi proposed openstack/mistral: Accept service catalog from client side  https://review.openstack.org/35536811:27
ddejarakhmerov: I've just checked - kombu driver would process all the calls one-by-one11:44
ddejaso it is using 'blocking'11:45
rakhmerovook..11:45
rakhmerovlet me think..11:45
rakhmerovok with me for now, later on we can think about using something else if kombu can somehow allow it11:46
rakhmerovmaybe not11:46
ddejai guess it could be done in Ocata cycle11:46
rakhmerovbasically, I've been struggling with a strange issue for the last week and finally understood why it happened11:46
rakhmerovbecause of executor='eventlet'11:46
rakhmerovddeja: yes11:46
rakhmerovgenerally, what I found is that green threads (used by eventlet) cannot be used if we make blocking calls in them11:47
rakhmerovlike I do in order to synchronize some 'join' related stuff11:47
rakhmerovin this case green threads may get into deadlock11:48
rakhmerov:)11:48
ddejaoh, I see11:48
rakhmerovfor some reason, green threads dispatching doesn't work as I expected11:48
ddejaand you would like to make oslo use blocking?11:48
rakhmerovI don't like this idea but yes, for now yes11:49
rakhmerovuntil we find a different way11:49
rakhmerovI'll give you an example, I reproduced it in a simple form11:49
ddejabut it will have performance impact?11:49
rakhmerovsec11:49
ddejaok\11:49
rakhmerovyes, it's slightly slower (not critically though)11:49
rakhmerovbut it works w/o deadlocks in green threads :)11:50
ddejaok11:50
*** jaosorior has quit IRC11:52
rakhmerovddeja: http://paste.openstack.org/show/563368/11:52
rakhmerovthis deadlocks11:52
*** jaosorior has joined #openstack-mistral11:52
rakhmerovI just run multiple green threads where each of them tries to do something with this named lock (via DB) that I added recently11:52
rakhmerov- the 1st one acquires the lock11:53
rakhmerov- the 1st one (I mean TX) calls sleep() and passes execution to the next green thread11:53
rakhmerov- the 2nd TX starts and tries to acquire the lock and blocks11:54
rakhmerovthat's it11:54
ddejaoh, I see11:54
rakhmerovand it hangs forever because execution is never given back to the 1st TX11:54
rakhmerovwhich needs to release the lock11:54
ddejayup11:55
*** dprince has joined #openstack-mistral11:55
rakhmerovI actually thought that when we do an external IO call it should switch green thread11:55
rakhmerovbtw, it would never happen with real parallel threads11:55
rakhmerovwith real parallelism TX 1 would just continue in parallel and release the lock11:56
rakhmerovthat's why I switched to 'blocking' in https://review.openstack.org/#/c/356343/11:57
rakhmerovand it now works in 100% cases for me, I do some ridiculous tests on my machine like 500 tasks joined by 501st task11:58
rakhmerovso basically this makes transactions run 1-by-1 on the same instance of engine11:58
ddejacan we use 'threading' instead of eventlet?11:59
ddejahttp://docs.openstack.org/developer/oslo.messaging/executors.html11:59
rakhmerovI tried, the same problem11:59
ddejaoh, OK11:59
rakhmerovyeah11:59
rakhmerovthe fundamental reason is that there's no parallelism here11:59
rakhmerovI mean real parallelism11:59
rakhmerovwe can potentially use something like multiprocessing module probably12:00
rakhmerovbut it's not a near future12:00
ddejaagree12:00
rakhmerovthe thing that I don't understand actually yet is why it doesn't switch threads when I call DB12:01
rakhmerovI thought it should12:01
rakhmerovmaybe we need to monkeypatch some additional modules or something12:01
rakhmerovI don't know12:01
rakhmerovso I'm now reading about green threads to understand more about them12:03
rakhmerov:)12:03
*** tonytan4ever has joined #openstack-mistral12:10
ddejaOK. let me know if you need some help with it :)12:14
*** tonytan_brb has joined #openstack-mistral12:17
rakhmerovok12:17
rakhmerovI just really want to understand whether it's our misconfiguration or it's a real limitation12:18
*** bobh has joined #openstack-mistral12:18
*** vishwanathj_zzz has quit IRC12:18
*** vishwanathj_zzz has joined #openstack-mistral12:18
*** tonytan4ever has quit IRC12:19
*** shardy has quit IRC12:21
*** bradjones has quit IRC12:21
*** shardy has joined #openstack-mistral12:22
*** jaosorior is now known as jaosorior_away12:25
*** bradjones has joined #openstack-mistral12:27
*** bradjones has quit IRC12:27
*** bradjones has joined #openstack-mistral12:27
*** bobh has quit IRC12:42
brunograz_hi all, I filed a bug describing the issue we had a couple of days ago - here is the link: https://bugs.launchpad.net/mistral/+bug/1615993.12:59
openstackLaunchpad bug 1615993 in Mistral "Cron trigger does not execute Openstack actions - Cannot Authorize API client" [Undecided,New]12:59
*** vishwanathj_zzz is now known as vishwanathj13:00
brunograz_I'm currently trying to solve this bug but I'm a bit new to Mistral and tbh this is a non trivial error.13:00
brunograz_What I can see is that the trust_id is correct and the context created out of it is also correct.13:01
brunograz_Now what I cannot understand is how the action is executed and how the authentication out of the context is done.13:02
*** janki has quit IRC13:03
*** janki has joined #openstack-mistral13:05
*** vishwanathj has quit IRC13:15
*** vishwanathj has joined #openstack-mistral13:16
*** Ephur has joined #openstack-mistral13:22
ddejarakhmerov: still there?13:23
ddejabrunograz_: Hi, I'm looking on your bug13:26
ddejagood news, I can see the cause, but didn't found the root yet13:27
brunograz_ddeja: great! what is causing this issue btw?13:28
brunograz_We are looking into the code as well trying to understand the mechaniscs of cron triggers13:29
ddejabrunograz_: from what I see now13:32
ddejawrong context information is passed from API layer13:32
ddejait just have auth token, project id and user id13:33
ddejawheras when using API, there is auth url and much much more13:33
ddejawhen using direct call to API*13:34
brunograz_ddeja - we did try adding an auth_url to the context passed by the API. iirc this info is in services/security.py. Not sure though if there are more information missing13:35
brunograz_we are getting a 403 error in keystone which means in keystone terminology - The identity was successfully authenticated but it is not authorized to perform the requested action.13:36
brunograz_the same request has the trust id and the authorization is delegated13:40
ddejabrunograz_: I might have a fix, let me try and test it...13:43
brunograz_ddeja: V cool! thx13:44
*** janki has quit IRC13:45
*** jaosorior_away is now known as jaosorior13:48
ddejabrunograz_: nope, that doesn't help it :/13:50
*** vishwanathj has quit IRC13:55
*** vishwanathj has joined #openstack-mistral13:55
brunograz_ddeja: ooh :O,  what did you try?14:03
ddejaI found out that periodic service is calling our rpc layer direclty rather that using engine client14:05
ddejaI hope that that's the problem, but no14:05
brunograz_ddeja: were you able to reproduce the error?14:07
*** jaosorior has quit IRC14:08
*** mflobo has quit IRC14:08
*** janki has joined #openstack-mistral14:08
brunograz_ddeja: I'm not sure what you mean abt engine client. could you point us what this is located?14:09
ddejabrunograz_: yes, I reproduced it14:11
ddejachanging the engine_client does not help, so it doeasn't matter14:11
brunograz_cool, just wanted to make sure it wasn't only us :)14:11
brunograz_found the root cause of the problem - https://github.com/openstack/mistral/blob/master/mistral/actions/openstack/actions.py#L6014:28
brunograz_the execution of the method _get_client stops at this line14:28
ddejabrunograz_: well, this is not the root problem14:29
*** janki has quit IRC14:29
brunograz_which goes here14:29
brunograz_https://github.com/openstack/mistral/blob/master/mistral/utils/openstack/keystone.py#L6714:29
ddejait starts way before it goes to NovaActions14:29
*** nmakhotkin has quit IRC14:30
brunograz_sorry, it might not be the root of the problem. but we identified an issue with this method14:30
ddejabrunograz_: yup, here is where the exception is throw14:31
ddejabrunograz_: there is a problem with generating auth_ctx at the beggining on the API side14:33
ddejaI think I fixed it, give me a minut14:33
ddejaminute*14:33
brunograz_sure :)14:34
jtomasekrakhmerov: Hi, In recent mistral the workflow executions don't include the 'output' is that a known problem?14:40
*** vishwanathj has quit IRC14:44
*** vishwanathj has joined #openstack-mistral14:44
*** vishwanathj has quit IRC14:46
*** vishwanathj has joined #openstack-mistral14:46
*** openstackgerrit has quit IRC14:48
*** openstackgerrit has joined #openstack-mistral14:49
ddejabrunograz_: OK. I've checked that user_id and project_id used by both cron triggers and directly calling 'execute' are the same15:03
*** tonytan4ever has joined #openstack-mistral15:03
ddejathe only thing that is different is token_id, which is usuall situation15:04
ddejaI'm looking how the token creation difference beetwen these two to find the root cause15:04
*** jpich has quit IRC15:04
brunograz_ddeja: cool ok, will let you know if I find something interesting regarding this error15:06
*** tonytan_brb has quit IRC15:06
*** dprince has quit IRC15:09
*** brian_price has joined #openstack-mistral15:13
*** janki has joined #openstack-mistral15:14
*** vishwanathj has quit IRC15:15
*** brian_price has quit IRC15:15
*** vishwanathj has joined #openstack-mistral15:16
*** mflobo has joined #openstack-mistral15:17
*** brian_price has joined #openstack-mistral15:17
*** vishwanathj has quit IRC15:18
*** vishwanathj has joined #openstack-mistral15:19
*** brian_price has quit IRC15:25
*** brian_price has joined #openstack-mistral15:25
*** brian_price has quit IRC15:37
*** vishwanathj has quit IRC15:44
*** vishwanathj has joined #openstack-mistral15:45
*** jchhatbar has joined #openstack-mistral15:58
*** janki has quit IRC15:59
*** jchhatbar is now known as janki16:00
*** vishwanathj has quit IRC16:04
*** vishwanathj has joined #openstack-mistral16:05
*** tonytan_brb has joined #openstack-mistral16:15
*** tonytan4ever has quit IRC16:17
*** dprince has joined #openstack-mistral16:19
*** vishwanathj has quit IRC16:27
*** vishwanathj has joined #openstack-mistral16:28
*** dprince has quit IRC16:37
*** jpich has joined #openstack-mistral16:40
*** rrecio has joined #openstack-mistral16:50
*** Kiall has quit IRC16:51
*** dprince has joined #openstack-mistral16:53
*** janki has quit IRC17:09
*** mflobo has quit IRC17:14
*** Kiall has joined #openstack-mistral17:36
*** Ephur has quit IRC17:49
*** vishwanathj has quit IRC18:47
*** vishwanathj has joined #openstack-mistral18:48
*** krotscheck has left #openstack-mistral18:51
*** brian_price has joined #openstack-mistral19:00
*** Ephur has joined #openstack-mistral19:23
*** jpich has quit IRC20:00
*** tonytan_brb is now known as tonytan4ever20:02
*** dprince has quit IRC20:07
*** vishwanathj has quit IRC20:19
*** vishwanathj has joined #openstack-mistral20:20
*** vishwanathj has quit IRC20:28
*** vishwanathj has joined #openstack-mistral20:29
*** Ephur has quit IRC20:32
*** gyee has joined #openstack-mistral20:42
*** vishwanathj has quit IRC21:16
*** vishwanathj has joined #openstack-mistral21:16
*** vishwanathj has quit IRC21:26
*** vishwanathj has joined #openstack-mistral21:27
*** shardy has quit IRC21:57
*** vishwanathj has quit IRC22:01
*** vishwanathj has joined #openstack-mistral22:02
*** vishwanathj has quit IRC22:17
*** vishwanathj has joined #openstack-mistral22:18
*** vishwanathj has quit IRC22:23
*** chlong has quit IRC22:58
*** chlong has joined #openstack-mistral23:11
*** chlong has quit IRC23:35
*** rrecio has quit IRC23:39

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!