| *** toddjohn has quit IRC | 00:09 | |
| *** toddjohn has joined #openstack-mistral | 00:15 | |
| *** toddjohn has quit IRC | 00:17 | |
| *** toddjohn has joined #openstack-mistral | 00:17 | |
| *** toddjohn has quit IRC | 00:23 | |
| *** tonytan4ever has joined #openstack-mistral | 00:33 | |
| *** tonytan4ever has quit IRC | 00:38 | |
| *** toddjohn has joined #openstack-mistral | 00:54 | |
| *** toddjohn has quit IRC | 00:55 | |
| *** toddjohn has joined #openstack-mistral | 00:55 | |
| *** bobh has quit IRC | 01:05 | |
| *** toddjohn has quit IRC | 01:17 | |
| *** toddjohn has joined #openstack-mistral | 01:26 | |
| *** toddjohn has quit IRC | 01:49 | |
| *** dmellado has quit IRC | 01:57 | |
| *** dmellado has joined #openstack-mistral | 02:02 | |
| *** toddjohn has joined #openstack-mistral | 02:50 | |
| *** toddjohn has quit IRC | 02:54 | |
| *** toddjohn has joined #openstack-mistral | 03:21 | |
| *** toddjohn has quit IRC | 03:26 | |
| openstackgerrit | Merged openstack/mistral: Towards non-locking model: Add 'unique_key' for delayed calls https://review.openstack.org/349445 | 04:11 |
|---|---|---|
| openstackgerrit | Lucky samadhiya proposed openstack/mistral: changes cron-trigger for show execution times in UTC timezone Closes-Bug: #1592164 https://review.openstack.org/348146 | 04:29 |
| openstack | bug 1592164 in Mistral "cron-trigger shows execution times in local timezone" [Undecided,In progress] https://launchpad.net/bugs/1592164 - Assigned to Lucky samadhiya (lucky-samadhiya) | 04:29 |
| openstackgerrit | Merged openstack/mistral: Updated from global requirements https://review.openstack.org/350670 | 04:46 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: removing env update from WF controller https://review.openstack.org/349466 | 04:51 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: add insert_with_ignore() on DB API https://review.openstack.org/350977 | 04:51 |
| rakhmerov | kong, hparekh, ddeja: guys, can you please review https://review.openstack.org/#/c/349457/ and https://review.openstack.org/#/c/349466/ ? | 04:52 |
| rakhmerov | they remove some crap from workflow controllers | 04:52 |
| rakhmerov | they are simple | 04:52 |
| rakhmerov | hparekh: btw, I didn't understand your comment about env update in the last one | 04:52 |
| rakhmerov | please explain | 04:52 |
| *** janki has joined #openstack-mistral | 05:02 | |
| *** janki has quit IRC | 05:06 | |
| hparekh | rakhmerov, we can check env is none or not in _update_env_ method so that we can eliminate use of "if env" condition everytime we call this method | 05:09 |
| rakhmerov | ooh, I see | 05:10 |
| rakhmerov | ok, I'll fix it | 05:10 |
| *** janki has joined #openstack-mistral | 05:14 | |
| *** toddjohn has joined #openstack-mistral | 05:23 | |
| *** toddjohn has quit IRC | 05:27 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: removing env update from WF controller https://review.openstack.org/349466 | 06:05 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: add insert_with_ignore() on DB API https://review.openstack.org/350977 | 06:05 |
| *** jtomasek has quit IRC | 06:09 | |
| *** Ravikiran_K has joined #openstack-mistral | 06:12 | |
| openstackgerrit | Lucky samadhiya proposed openstack/mistral: changes cron-trigger for show execution times in UTC timezone Closes-Bug: #1592164 https://review.openstack.org/348146 | 06:13 |
| openstack | bug 1592164 in Mistral "cron-trigger shows execution times in local timezone" [Undecided,In progress] https://launchpad.net/bugs/1592164 - Assigned to Lucky samadhiya (lucky-samadhiya) | 06:13 |
| *** toddjohn has joined #openstack-mistral | 06:24 | |
| *** toddjohn has quit IRC | 06:28 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: add insert_or_ignore() on DB API https://review.openstack.org/350977 | 06:39 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: use insert_or_ignore() for delayed calls https://review.openstack.org/351025 | 06:48 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Fix the use of both adhoc actions and "with-items" in workflows https://review.openstack.org/337696 | 06:59 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: use insert_or_ignore() for delayed calls https://review.openstack.org/351025 | 07:05 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: add insert_or_ignore() on DB API https://review.openstack.org/350977 | 07:05 |
| rakhmerov | hparekh: I addressed your comment with env but partially, I left one "if" condition just for efficiency, just not to iterate through commands w/o taking any action | 07:11 |
| rakhmerov | hope it's ok | 07:11 |
| d0ugal | rakhmerov: I replied to your comment on https://review.openstack.org/#/c/337696/ - let me know if that doesn't make sense | 07:14 |
| rakhmerov | d0ugal: yeah, I saw | 07:14 |
| rakhmerov | d0ugal: can you please explain though how exactly this fixes that bug? | 07:15 |
| rakhmerov | seems like I'm still not understanding.. | 07:15 |
| d0ugal | rakhmerov: I wrote the test that demonstrates the bug, ddeja found the fix. I don't fully understand it either (and it makes me feel less stupid that you don't too! :) ) | 07:16 |
| d0ugal | but I think he just looked at the difference between the two tasks and found that the validate wasn't called | 07:16 |
| rakhmerov | hahaha :)))) | 07:16 |
| d0ugal | (two tasks = regular tasks and with items tasks) | 07:17 |
| rakhmerov | oooh, yes | 07:17 |
| rakhmerov | now I see | 07:17 |
| rakhmerov | it's actually a stupid issue that we now have in our code | 07:17 |
| rakhmerov | I'll explain in a minute.. | 07:17 |
| d0ugal | lol | 07:17 |
| d0ugal | Thanks :) | 07:18 |
| rakhmerov | yeah, found it | 07:22 |
| rakhmerov | sec | 07:22 |
| rakhmerov | https://github.com/openstack/mistral/blob/master/mistral/engine/utils.py#L27 | 07:22 |
| rakhmerov | look at my comment :) | 07:22 |
| d0ugal | rakhmerov: aha, but it does? | 07:23 |
| rakhmerov | yes | 07:23 |
| rakhmerov | it's a stupid issue, legacy of our old code base | 07:23 |
| rakhmerov | so I know about it and it will be eliminated pretty soon | 07:24 |
| d0ugal | Great | 07:24 |
| rakhmerov | "side-effect based programming" :) | 07:24 |
| d0ugal | It's the worst :) | 07:24 |
| rakhmerov | but, in fact, this bug helped us reveal another bug | 07:24 |
| rakhmerov | we were missing validation in case of with-items ) | 07:25 |
| d0ugal | haha, true | 07:25 |
| d0ugal | we need more useful bugs :) | 07:25 |
| rakhmerov | yes :) | 07:26 |
| rakhmerov | ok, I voted +2 | 07:26 |
| d0ugal | rakhmerov: Thanks! | 07:26 |
| *** openstackgerrit has quit IRC | 07:33 | |
| *** openstackgerrit has joined #openstack-mistral | 07:33 | |
| *** vishwanathj has quit IRC | 07:44 | |
| *** shardy has joined #openstack-mistral | 07:48 | |
| *** jpich has joined #openstack-mistral | 08:00 | |
| openstackgerrit | Merged openstack/mistral: Fix the use of both adhoc actions and "with-items" in workflows https://review.openstack.org/337696 | 08:22 |
| *** toddjohn has joined #openstack-mistral | 08:25 | |
| *** toddjohn has quit IRC | 08:30 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: use insert_or_ignore() for delayed calls https://review.openstack.org/351025 | 08:41 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: add insert_or_ignore() on DB API https://review.openstack.org/350977 | 08:41 |
| *** mflobo has joined #openstack-mistral | 08:43 | |
| *** wewe1e has joined #openstack-mistral | 08:53 | |
| *** janki has quit IRC | 09:21 | |
| *** wewe1e has quit IRC | 09:22 | |
| *** dulek has quit IRC | 09:25 | |
| *** dulek has joined #openstack-mistral | 09:27 | |
| *** janki has joined #openstack-mistral | 09:30 | |
| *** mflobo has left #openstack-mistral | 09:45 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: decouple WF completion check via scheduler https://review.openstack.org/351098 | 10:07 |
| openstackgerrit | prince_katiyar proposed openstack/python-mistralclient: Add error message when OS_USERNAME or OS_PASSWORD not provided https://review.openstack.org/348142 | 10:11 |
| *** toddjohn has joined #openstack-mistral | 10:27 | |
| *** chlong has quit IRC | 10:28 | |
| *** toddjohn has quit IRC | 10:31 | |
| *** chlong has joined #openstack-mistral | 10:41 | |
| *** janki has quit IRC | 10:46 | |
| *** janki has joined #openstack-mistral | 10:50 | |
| *** jaosorior has joined #openstack-mistral | 10:51 | |
| *** janki has quit IRC | 10:56 | |
| *** Ravikiran_K has quit IRC | 11:04 | |
| *** janki has joined #openstack-mistral | 11:13 | |
| *** chlong has quit IRC | 11:27 | |
| *** chlong has joined #openstack-mistral | 11:28 | |
| *** janki has quit IRC | 11:35 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/mistral: Use actual session for ironic-inspector action population https://review.openstack.org/351134 | 11:40 |
| *** dulek has quit IRC | 11:43 | |
| *** dulek has joined #openstack-mistral | 11:45 | |
| jaosorior | Are there cases were mistral won't use keystone? | 11:47 |
| *** janki has joined #openstack-mistral | 11:47 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/mistral: Use actual session for ironic-inspector action population https://review.openstack.org/351134 | 11:55 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: decouple WF completion check via scheduler https://review.openstack.org/351098 | 11:56 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/mistral: Use actual session for ironic-inspector action population https://review.openstack.org/351134 | 11:56 |
| *** janki has quit IRC | 12:02 | |
| *** janki has joined #openstack-mistral | 12:02 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Towards non-locking model: decouple WF completion check via scheduler https://review.openstack.org/351098 | 12:08 |
| *** janki has quit IRC | 12:09 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/mistral: Use actual session for ironic-inspector action population https://review.openstack.org/351134 | 12:14 |
| jaosorior | d0ugal: should I post the message in the previous exception? | 12:16 |
| jaosorior | d0ugal: And I think it should be a LOG.warning, since it's non-fatal | 12:17 |
| d0ugal | jaosorior: post the message? | 12:17 |
| jaosorior | str(exception) | 12:17 |
| d0ugal | Yeah, warning would probably make more sense (I suggested .exception as it will show the message and traceback in the logs) | 12:17 |
| openstackgerrit | hardik proposed openstack/mistral: Filtering support for actions. https://review.openstack.org/269971 | 12:18 |
| d0ugal | jaosorior: Yeah, so: LOG.warning(str(exception)) | 12:18 |
| d0ugal | jaosorior: The original line is "return cls._get_client_class()(1)" | 12:18 |
| d0ugal | in the except you removed the 1 from "()" | 12:19 |
| d0ugal | Does that matter? I have no idea what it means. | 12:19 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/mistral: Use actual session for ironic-inspector action population https://review.openstack.org/351134 | 12:21 |
| jaosorior | d0ugal: that 1 was attempting to use a specific version for the ironic-inspector client. But that didn't address the original issue in the end. | 12:21 |
| jaosorior | So having the same call without the parenthesis is pretty much the same thing | 12:21 |
| d0ugal | jaosorior: cool, thanks | 12:21 |
| jaosorior | d0ugal: Does that look better? ^^ | 12:22 |
| d0ugal | jaosorior: Yup, I think so. | 12:22 |
| jaosorior | testing it out | 12:23 |
| d0ugal | jaosorior: +1'ed - I wonder if we need to setup the middlewear anywhere else. | 12:23 |
| jaosorior | d0ugal: What do you mean? | 12:24 |
| *** janki has joined #openstack-mistral | 12:24 | |
| d0ugal | jaosorior: You added a few lines to tools/sync_db.py, do we need to do that at other entry points? | 12:25 |
| d0ugal | I guess I just don't understand why it is added there only. | 12:25 |
| jaosorior | d0ugal: Right, so the keystonemiddleware options from the configuration are magically registered when this constructor is called https://github.com/openstack/mistral/blob/master/mistral/api/access_control.py#L41 | 12:25 |
| jaosorior | so for the normal case, where the API is started, it already has those options available thanks to that call | 12:25 |
| jaosorior | which was not the case for the sync_db call. That doesn't use it | 12:26 |
| jaosorior | that's why that register_opts was not necessary elsewhere | 12:26 |
| d0ugal | jaosorior: I see, thanks! | 12:27 |
| *** dprince has joined #openstack-mistral | 12:28 | |
| jaosorior | d0ugal: Yeah dude, I was pretty confused at first | 12:28 |
| *** toddjohn has joined #openstack-mistral | 12:28 | |
| *** toddjohn has quit IRC | 12:33 | |
| openstackgerrit | Merged openstack/mistral: Towards non-locking model: fix obvious workflow controller issues https://review.openstack.org/349457 | 12:34 |
| *** toddjohn has joined #openstack-mistral | 12:39 | |
| openstackgerrit | Merged openstack/mistral: Towards non-locking model: removing env update from WF controller https://review.openstack.org/349466 | 12:40 |
| *** janki has quit IRC | 12:48 | |
| *** toddjohn has quit IRC | 12:55 | |
| openstackgerrit | Merged openstack/mistral: Add state info for synchronous actions run from CLI https://review.openstack.org/349993 | 12:57 |
| *** nmakhotkin has joined #openstack-mistral | 13:00 | |
| *** jpich has quit IRC | 13:03 | |
| openstackgerrit | Merged openstack/mistral: Fixed trivial issue in exception message https://review.openstack.org/348754 | 13:08 |
| *** toddjohn has joined #openstack-mistral | 13:09 | |
| *** toddjohn has quit IRC | 13:13 | |
| *** janki has joined #openstack-mistral | 13:15 | |
| *** janki has quit IRC | 13:18 | |
| *** nmakhotkin has quit IRC | 13:20 | |
| *** bobh has joined #openstack-mistral | 13:24 | |
| *** bobh has quit IRC | 13:30 | |
| *** toddjohn has joined #openstack-mistral | 13:38 | |
| jaosorior | If people have time, this commit could use some reviews :D https://review.openstack.org/#/c/351134/ | 13:40 |
| *** jpich has joined #openstack-mistral | 13:45 | |
| *** bobh has joined #openstack-mistral | 13:51 | |
| openstackgerrit | hardik proposed openstack/mistral: Added support for SSL connection in mistra-api server https://review.openstack.org/344598 | 13:55 |
| openstackgerrit | hardik proposed openstack/mistral: Filtering support for actions. https://review.openstack.org/269971 | 14:02 |
| *** mflobo has joined #openstack-mistral | 14:15 | |
| *** jaosorior has quit IRC | 14:17 | |
| *** vishwanathj has joined #openstack-mistral | 14:32 | |
| *** catintheroof has joined #openstack-mistral | 14:32 | |
| *** rrecio has joined #openstack-mistral | 15:02 | |
| *** catintheroof has quit IRC | 15:25 | |
| d0ugal | rakhmerov, ddeja - if you have a moment, we are having problems in TripleO's CI, this should fix it: https://review.openstack.org/#/c/351134/ | 15:32 |
| *** toddjohn has quit IRC | 16:01 | |
| *** kro_focused is now known as krotscheck | 16:32 | |
| *** toddjohn has joined #openstack-mistral | 16:42 | |
| *** jpich has quit IRC | 16:57 | |
| *** dprince has quit IRC | 17:24 | |
| *** mflobo1 has joined #openstack-mistral | 17:35 | |
| *** mflobo has quit IRC | 17:35 | |
| *** shardy has quit IRC | 17:39 | |
| *** dprince has joined #openstack-mistral | 17:41 | |
| *** vishwanathj has quit IRC | 17:48 | |
| *** mflobo1 has quit IRC | 17:55 | |
| *** toddjohn has quit IRC | 18:16 | |
| *** toddjohn has joined #openstack-mistral | 18:16 | |
| *** tonytan4ever has joined #openstack-mistral | 18:21 | |
| *** toddjohn has quit IRC | 18:59 | |
| *** toddjohn has joined #openstack-mistral | 19:01 | |
| *** vishwanathj has joined #openstack-mistral | 19:19 | |
| *** vishwanathj has quit IRC | 19:21 | |
| *** vishwanathj has joined #openstack-mistral | 19:21 | |
| *** vishwanathj has quit IRC | 19:31 | |
| *** vishwanathj has joined #openstack-mistral | 19:31 | |
| *** vishwanathj has quit IRC | 19:33 | |
| *** vishwanathj has joined #openstack-mistral | 19:33 | |
| *** tonytan_brb has joined #openstack-mistral | 19:36 | |
| *** tonytan4ever has quit IRC | 19:38 | |
| *** rakhmerov has quit IRC | 19:53 | |
| *** rakhmerov has joined #openstack-mistral | 19:57 | |
| *** vishwanathj has quit IRC | 19:59 | |
| *** vishwanathj has joined #openstack-mistral | 19:59 | |
| *** mflobo has joined #openstack-mistral | 20:02 | |
| *** vishwanathj has quit IRC | 20:14 | |
| *** vishwanathj has joined #openstack-mistral | 20:14 | |
| *** toddjohn has quit IRC | 20:16 | |
| *** catintheroof has joined #openstack-mistral | 20:30 | |
| *** vishwanathj has quit IRC | 20:38 | |
| *** vishwanathj has joined #openstack-mistral | 20:39 | |
| *** vishwanathj has quit IRC | 20:40 | |
| *** vishwanathj has joined #openstack-mistral | 20:41 | |
| *** tonytan_brb has quit IRC | 20:48 | |
| *** vishwanathj has quit IRC | 21:05 | |
| *** vishwanathj has joined #openstack-mistral | 21:06 | |
| *** vishwanathj has quit IRC | 21:11 | |
| *** vishwanathj has joined #openstack-mistral | 21:11 | |
| *** vishwanathj has quit IRC | 21:13 | |
| *** vishwanathj has joined #openstack-mistral | 21:13 | |
| *** vishwanathj has quit IRC | 21:16 | |
| *** vishwanathj has joined #openstack-mistral | 21:16 | |
| *** bobh_ has joined #openstack-mistral | 21:17 | |
| *** bobh has quit IRC | 21:18 | |
| *** vishwanathj has quit IRC | 21:24 | |
| *** vishwanathj has joined #openstack-mistral | 21:24 | |
| *** vishwanathj has quit IRC | 21:37 | |
| *** vishwanathj has joined #openstack-mistral | 21:37 | |
| *** vishwanathj has quit IRC | 21:38 | |
| *** vishwanathj has joined #openstack-mistral | 21:39 | |
| *** vishwanathj has quit IRC | 21:44 | |
| *** vishwanathj has joined #openstack-mistral | 21:45 | |
| *** vishwanathj has quit IRC | 21:49 | |
| *** vishwanathj has joined #openstack-mistral | 21:50 | |
| *** vishwanathj has quit IRC | 21:53 | |
| *** vishwanathj has joined #openstack-mistral | 21:54 | |
| *** dprince has quit IRC | 21:59 | |
| *** vishwanathj has quit IRC | 22:14 | |
| *** vishwanathj has joined #openstack-mistral | 22:15 | |
| *** bobh_ has quit IRC | 22:16 | |
| *** rrecio has quit IRC | 22:26 | |
| *** mflobo has quit IRC | 22:59 | |
| *** catintheroof has quit IRC | 23:13 | |
| *** toddjohn has joined #openstack-mistral | 23:34 | |
| *** toddjohn has quit IRC | 23:38 | |
| *** toddjohn has joined #openstack-mistral | 23:38 | |
| *** rrecio_ has joined #openstack-mistral | 23:44 | |
| *** catintheroof has joined #openstack-mistral | 23:46 | |
| *** rrecio_ has quit IRC | 23:49 | |
| *** rrecio has joined #openstack-mistral | 23:50 | |
| *** vishwanathj has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!