*** bobh has joined #openstack-mistral | 00:11 | |
*** bobh has quit IRC | 00:14 | |
*** bobh has joined #openstack-mistral | 00:41 | |
*** tonytan4ever has joined #openstack-mistral | 00:47 | |
*** bobh has quit IRC | 00:50 | |
*** tonytan4ever has quit IRC | 00:53 | |
*** bobh has joined #openstack-mistral | 01:13 | |
*** toddjohn has joined #openstack-mistral | 01:16 | |
*** toddjohn has quit IRC | 01:28 | |
*** toddjohn has joined #openstack-mistral | 01:29 | |
*** toddjohn has quit IRC | 01:33 | |
*** openstackgerrit has quit IRC | 01:33 | |
*** openstackgerrit has joined #openstack-mistral | 01:34 | |
*** tonytan4ever has joined #openstack-mistral | 01:49 | |
*** tonytan4ever has quit IRC | 01:53 | |
*** bobh has quit IRC | 01:57 | |
*** bobh has joined #openstack-mistral | 02:35 | |
*** tonytan4ever has joined #openstack-mistral | 02:35 | |
*** gyee has quit IRC | 03:03 | |
*** bobh has quit IRC | 03:08 | |
*** bobh has joined #openstack-mistral | 03:14 | |
*** bobh has quit IRC | 03:17 | |
*** vishwanathj has quit IRC | 04:32 | |
*** jtomasek has quit IRC | 04:41 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Splitting executions into different tables https://review.openstack.org/347172 | 05:55 |
---|---|---|
*** achatterjee has joined #openstack-mistral | 06:03 | |
*** achatterjee has left #openstack-mistral | 06:11 | |
*** Ravikiran_K has joined #openstack-mistral | 06:30 | |
d0ugal | Morning | 06:54 |
d0ugal | rakhmerov: Where can I find CloudFlow? :) | 06:54 |
rakhmerov | d0ugal: good morning :)) | 06:54 |
rakhmerov | ha-ha | 06:55 |
rakhmerov | d0ugal: it's not available yet | 06:55 |
d0ugal | ah | 06:55 |
rakhmerov | I've it only once myself | 06:55 |
rakhmerov | I've seen.. | 06:55 |
d0ugal | so you are just teasing us with this talk submission :-D | 06:55 |
rakhmerov | no, it should be available soon | 06:55 |
d0ugal | cool | 06:55 |
d0ugal | Sounds interesting! | 06:56 |
rakhmerov | there's someone at Nokia working hard on it | 06:56 |
rakhmerov | yeah | 06:56 |
openstackgerrit | Renat Akhmerov proposed openstack/python-mistralclient: Different formatters for "action-execution-get" and "action-execution-list" https://review.openstack.org/346331 | 06:56 |
openstackgerrit | Renat Akhmerov proposed openstack/python-mistralclient: Add "Task ID" field for "action-execution-get" command output https://review.openstack.org/346330 | 06:56 |
d0ugal | rakhmerov: If/when you have some spare time, could you take a look at 1597640 and see if you know where the issue might be? | 06:59 |
d0ugal | https://bugs.launchpad.net/mistral/+bug/1597640 | 06:59 |
openstack | Launchpad bug 1597640 in Mistral "with-items does not process ad-hoc action default values" [High,In progress] - Assigned to Dougal Matthews (d0ugal) | 06:59 |
d0ugal | Otherwise I should probably remove myself from it, as I got stuck | 06:59 |
rakhmerov | d0ugal: yeah, I know I promised you to look at it but I got some huge urgent issues that I have to fix | 07:02 |
rakhmerov | priorities | 07:02 |
rakhmerov | so, I will definitely look at it but slightly later | 07:02 |
rakhmerov | if it's ok with you | 07:02 |
rakhmerov | no need to remove yourself from it now | 07:02 |
d0ugal | rakhmerov: okay, thanks :) | 07:07 |
d0ugal | I'll have a look for something else small I can pickup now | 07:07 |
rakhmerov | yes | 07:10 |
hparekh | rakhmerov, Hi | 07:24 |
hparekh | rakhmerov, It is regarding your change here in https://review.openstack.org/#/c/345295/3 | 07:25 |
hparekh | rakhmerov, So after this change, we cannot use sorting without marker or limit right ? | 07:25 |
rakhmerov | hparekh: hi | 07:31 |
rakhmerov | why? | 07:31 |
hparekh | rakhmerov, because we don't use paginate query if marker or limit is not set | 07:31 |
hparekh | rakhmerov, So sort will not work if limit or marker is not specified | 07:32 |
hparekh | rakhmerov, That is the reason why python-mistralclient gate is getting fail | 07:32 |
rakhmerov | ooh.. | 07:32 |
rakhmerov | let me think.... | 07:32 |
hparekh | http://logs.openstack.org/52/344052/1/gate/gate-python-mistralclient-devstack-dsvm/ae9aa33/console.html.gz#_2016-07-22_04_47_50_228744 | 07:33 |
*** jpich has joined #openstack-mistral | 07:33 | |
rakhmerov | hparekh: I think you're right.. | 07:33 |
rakhmerov | yes, my fault | 07:34 |
rakhmerov | overlooked it | 07:34 |
hparekh | rakhmerov, Ok no issue I am fixing it | 07:34 |
rakhmerov | hparekh: thanks, but please don't put query.all() back to _paginate_query() | 07:34 |
rakhmerov | :) | 07:34 |
hparekh | :) | 07:35 |
rakhmerov | because I was having hard time to understand why _paginat_query() was called this way | 07:35 |
rakhmerov | by its name, it should just really paginate query object but not return a dataset | 07:36 |
rakhmerov | that was also a reason why I excluded it from try-except | 07:36 |
rakhmerov | so I just suggest we remove this "if marker or limit" condition | 07:36 |
rakhmerov | it's redundant | 07:36 |
rakhmerov | hparekh: agree? | 07:36 |
rakhmerov | or maybe I'm missing something else | 07:37 |
hparekh | rakhmerov, yeah IMO paginate query should return only query object. I agree with you | 07:37 |
rakhmerov | ok | 07:37 |
*** shardy has joined #openstack-mistral | 07:38 | |
rakhmerov | hparekh: btw, thanks a lot for https://review.openstack.org/#/c/346612/ | 07:38 |
rakhmerov | this is a kind of work I'd like to do more | 07:38 |
rakhmerov | to make the code cleaner | 07:38 |
hparekh | rakhmerov, yeah. Also I believe we should also improve our documentation. I am bad at documentation but I will try :) | 07:40 |
* rakhmerov hopefully d0ugal can help with this :)) | 07:41 | |
* d0ugal reads up | 07:41 | |
hparekh | heh | 07:41 |
d0ugal | I can try :) | 07:42 |
d0ugal | I did see some docs fixes by mgould (not here). Maybe I can work on it with him to do more | 07:43 |
*** szaher has quit IRC | 07:53 | |
*** tonytan4ever has quit IRC | 07:58 | |
*** tonytan4ever has joined #openstack-mistral | 07:59 | |
*** tonytan4ever has quit IRC | 08:11 | |
rakhmerov | d0ugal: would be cool but I realize it may not be that kind of work you dream of | 08:12 |
rakhmerov | hparekh: let me know when you send a fix for sorting | 08:13 |
rakhmerov | we'll merge it asap since it blocks dev | 08:13 |
*** toddjohn has joined #openstack-mistral | 08:17 | |
*** toddjohn has quit IRC | 08:21 | |
hparekh | rakhmerov, yeah sure I am on it, was out for lunch | 08:54 |
rakhmerov | ok | 08:54 |
rakhmerov | no you should do it quickly ) | 08:54 |
rakhmerov | after having food | 08:54 |
rakhmerov | now.. | 08:55 |
*** tonytan4ever has joined #openstack-mistral | 09:01 | |
*** tonytan4ever has quit IRC | 09:05 | |
openstackgerrit | hardik proposed openstack/mistral: Use Paginate query even if 'limit'or 'marker' is not set https://review.openstack.org/347710 | 09:19 |
hparekh | rakhmerov, done https://review.openstack.org/#/c/347710/ | 09:19 |
rakhmerov | thanks! | 09:19 |
rakhmerov | hparekh: why did you remove sort_dirs = sort_dirs if sort_dirs else [] ? | 09:20 |
hparekh | rakhmerov, Actually there will be problem in length of sort_dirs and sort_keys when only sort_keys provided. | 09:21 |
rakhmerov | the point was to have sort_keys and sort_dirs initialized in any case | 09:21 |
rakhmerov | hm.. | 09:22 |
hparekh | like in _get_collection_sort_by_name | 09:23 |
rakhmerov | when I was making changes I assumed that sort_keys are always of the same as sort_dirs, no? | 09:23 |
rakhmerov | so you mean, it is allowed to specify only sort_keys? | 09:23 |
rakhmerov | hparekh: ^ | 09:23 |
hparekh | rakhmerov, yeah if we don'e specify sort_dirs then sort_keys and sort_dirs will be same | 09:24 |
rakhmerov | if so, then your change is correct | 09:24 |
rakhmerov | ok | 09:24 |
hparekh | rakhmerov, https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/utils.py#L116 | 09:24 |
rakhmerov | I see the point | 09:24 |
rakhmerov | ok, got it | 09:25 |
openstackgerrit | Dawid Deja proposed openstack/mistral: Use 'rpc_response_timeout' in kombu driver https://review.openstack.org/346005 | 09:51 |
*** chlong_POffice has quit IRC | 09:57 | |
*** chlong_POffice has joined #openstack-mistral | 10:10 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Removing unnecessary workflow specification parsing https://review.openstack.org/347758 | 10:53 |
*** pkatiyar has joined #openstack-mistral | 11:01 | |
rakhmerov | guys, do you know some good caching library for Python? | 11:06 |
rakhmerov | k-v storage (w/o distribution) | 11:07 |
rakhmerov | ddeja, hparekh, d0ugal: ^ | 11:07 |
d0ugal | w/o distribution? | 11:07 |
rakhmerov | so basically, I need to cache items under some keys and be sure that it won't pollute heap (so some expiration for entries must be in place) | 11:08 |
d0ugal | right | 11:08 |
d0ugal | hmm | 11:08 |
rakhmerov | d0ugal: yeah, I mean it should not be a distributed cache | 11:08 |
rakhmerov | and this cache must work with green threads | 11:09 |
d0ugal | hmm, I can't think of anything | 11:09 |
rakhmerov | ok | 11:09 |
ddeja | rakhmerov: calling _gryf, he's python guru ;) ^^ | 11:10 |
rakhmerov | ok :)) | 11:10 |
_gryf | WAT | 11:10 |
rakhmerov | _gryf: may be you could help with my question? | 11:11 |
_gryf | rakhmerov, I sww the question, that 'WAT' was for ddeja for calling me a python guru :) | 11:12 |
rakhmerov | :) | 11:12 |
rakhmerov | anyway, maybe you know | 11:12 |
_gryf | first what comes to my mind is redis | 11:12 |
rakhmerov | redis?? | 11:12 |
rakhmerov | it's a heavy stuff | 11:12 |
_gryf | right | 11:12 |
rakhmerov | I just need a simple Python lib | 11:12 |
rakhmerov | not a heavy-weight caching soluiton | 11:13 |
_gryf | ok, so on the other side of the solution would be a simple implementation of such chaching mechanism | 11:13 |
*** pkatiyar has quit IRC | 11:14 | |
_gryf | so simple class with storing/getting the key | 11:14 |
rakhmerov | yeah, I can implement it relatively quickly but I just thought maybe people in OpenStack already use something | 11:14 |
rakhmerov | so that I don't have to reinvent the wheel | 11:14 |
ddeja | rakhmerov, _gryf how about this https://pythonhosted.org/pickleDB/ | 11:14 |
d0ugal | cachetools? | 11:14 |
rakhmerov | _gryf: yes, this is simple. But I want to make sure such a cache won't devour my memory | 11:14 |
_gryf | I'm not aware of such thing. Maybe Doug Hellman would have some good proposals? | 11:14 |
d0ugal | or there is oslo.cache, but I don't know what it in it | 11:15 |
*** pkatiyar has joined #openstack-mistral | 11:15 | |
rakhmerov | d0ugal: what's that? | 11:15 |
d0ugal | https://pypi.python.org/pypi/cachetools | 11:15 |
d0ugal | https://github.com/openstack/oslo.cache | 11:15 |
rakhmerov | ooh, great! | 11:15 |
rakhmerov | let me look at them.. | 11:15 |
d0ugal | I found them in global requirements | 11:15 |
rakhmerov | thanks | 11:15 |
rakhmerov | yeah | 11:15 |
d0ugal | so I don't know much about them, but they are used in openstack... | 11:15 |
rakhmerov | ok | 11:16 |
d0ugal | oslo.cache looks like just a wrapper for memcache etc. | 11:16 |
rakhmerov | yep | 11:16 |
d0ugal | but I think it supports an in memory option | 11:16 |
d0ugal | Not sure if that is intended for production tho' | 11:16 |
d0ugal | back in a bit - lunch time! | 11:17 |
rakhmerov | ok | 11:17 |
_gryf | rakhmerov, memchache? Ok, the still remaning question would be if it will be acceptable solution in case of memory usage :) | 11:17 |
_gryf | rakhmerov, what I can think of is the simple class with ability tu remove old cache records | 11:18 |
rakhmerov | yeah ) | 11:18 |
_gryf | this also is fairly easy to implement | 11:18 |
rakhmerov | it should be, yes | 11:18 |
rakhmerov | and it needs to be greenthread safe ) | 11:19 |
_gryf | it shouldn't be a real big deal :) | 11:19 |
hparekh | rakhmerov, I have not use any such cache but I heard about http://beaker.readthedocs.io/en/latest/ from one of my colleague. | 11:20 |
rakhmerov | hparekh: ok :)) | 11:20 |
rakhmerov | thanks guys!! | 11:20 |
rakhmerov | seems like I have a lot of options to examine :) | 11:21 |
rakhmerov | great | 11:21 |
rakhmerov | based on the description, https://pypi.python.org/pypi/cachetools should work for me | 11:22 |
hparekh | kong, rakhmerov , akuznetsova Please review https://review.openstack.org/#/c/347710/ It is require to make out mistralclients's gate green | 11:22 |
hparekh | *our | 11:22 |
rakhmerov | hparekh: I was just waiting for the gates | 11:23 |
rakhmerov | I'll approve it with +2 for its importance.. | 11:23 |
hparekh | ok Thanks :) | 11:23 |
openstackgerrit | Merged openstack/mistral: Use Paginate query even if 'limit'or 'marker' is not set https://review.openstack.org/347710 | 11:33 |
*** shardy is now known as shardy_lunch | 11:43 | |
rakhmerov | hparekh: do you know why this happens? http://logs.openstack.org/58/347758/1/check/gate-mistral-python27-ubuntu-xenial/4be9d97/console.html | 11:54 |
rakhmerov | ddeja: did you test https://review.openstack.org/#/c/346005 somehow? | 11:56 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Removing unnecessary workflow specification parsing https://review.openstack.org/347758 | 11:58 |
*** tonytan4ever has joined #openstack-mistral | 12:17 | |
*** chlong_POffice has quit IRC | 12:21 | |
*** tonytan4ever has quit IRC | 12:22 | |
*** chlong has joined #openstack-mistral | 12:29 | |
*** bobh has joined #openstack-mistral | 12:36 | |
*** vishwanathj has joined #openstack-mistral | 12:42 | |
*** shardy_lunch is now known as shardy | 13:01 | |
*** bobh has quit IRC | 13:05 | |
openstackgerrit | Moshe Elisha proposed openstack/mistral: Fix DSLv2 example according to Mistral Neuton https://review.openstack.org/347850 | 13:53 |
ddeja | rakhmerov: yup. Using server and client from mistral/engine/rpc_backend/kombu/examples | 14:11 |
*** toddjohn has joined #openstack-mistral | 14:12 | |
*** tonytan4ever has joined #openstack-mistral | 14:17 | |
*** pkatiyar has quit IRC | 14:26 | |
jpeeler | rbrady: when you have a chance, see if this updated review satisfies https://review.openstack.org/#/c/345069/ | 14:34 |
rbrady | jpeeler: ack. will look today. still debugging mistral/heat undercloud issue | 14:44 |
d0ugal | Anyone seen an error like this when running mistral-db-manage populate? http://paste.openstack.org/show/542605/ | 14:44 |
jpeeler | i haven't run that command in a few weeks, but never have seen it | 14:51 |
openstackgerrit | Dawid Deja proposed openstack/mistral: Fix the use of both adhoc actions and "with-items" in workflows https://review.openstack.org/337696 | 14:52 |
*** Ravikiran_K has quit IRC | 14:53 | |
ddeja | d0ugal: I've found a fix for your patch, made a commit ^ | 14:58 |
*** jistr is now known as jistr|call | 15:00 | |
d0ugal | ddeja: oh, awesome. I'll take a look. | 15:01 |
d0ugal | ddeja: so simple - how did you find that? | 15:01 |
ddeja | I'm familiar with how mistral engine works | 15:02 |
ddeja | so I was looking for differences beetwen RegularTask and WithItemsTasks | 15:02 |
ddeja | oh, and also I've checked that validate_input adds timeout from definition to input dict | 15:03 |
d0ugal | ddeja: neat, thanks again. I'll take a closer look later to make sure I grok it. | 15:04 |
ddeja | d0ugal: OK, sure. Glad I could help | 15:04 |
*** bobh has joined #openstack-mistral | 15:04 | |
openstackgerrit | Merged openstack/python-mistralclient: Fixed ssl options for httpclient https://review.openstack.org/344052 | 15:10 |
*** rrecio has joined #openstack-mistral | 15:11 | |
ddeja | d0ugal: 'I grok it' <- needed to google that, thanks for extanding my vocabulary ;) | 15:32 |
*** jistr|call is now known as jistr | 15:35 | |
*** ninag has joined #openstack-mistral | 15:47 | |
*** ninag has quit IRC | 16:01 | |
*** toddjohn has quit IRC | 16:23 | |
openstackgerrit | Dawid Deja proposed openstack/mistral: Enable user to use transport_url in kombu driver https://review.openstack.org/347935 | 16:25 |
*** toddjohn has joined #openstack-mistral | 16:25 | |
*** toddjohn has quit IRC | 16:30 | |
*** toddjohn has joined #openstack-mistral | 16:31 | |
openstackgerrit | Dawid Deja proposed openstack/mistral: Enable user to use transport_url in kombu driver https://review.openstack.org/347935 | 16:33 |
*** toddjohn has quit IRC | 16:36 | |
*** bobh has quit IRC | 16:40 | |
*** toddjohn has joined #openstack-mistral | 16:40 | |
*** jpich has quit IRC | 16:41 | |
*** bobh has joined #openstack-mistral | 16:42 | |
*** gyee has joined #openstack-mistral | 17:03 | |
*** rbrady is now known as rbrady-food | 17:12 | |
*** shardy has quit IRC | 17:32 | |
*** tonytan_brb has joined #openstack-mistral | 17:36 | |
*** tonytan4ever has quit IRC | 17:38 | |
*** rbrady-food is now known as rbrady | 18:01 | |
*** bobh has quit IRC | 18:34 | |
*** toddjohn has quit IRC | 18:44 | |
*** tonytan_brb has quit IRC | 18:44 | |
*** toddjohn has joined #openstack-mistral | 18:45 | |
*** toddjoh__ has joined #openstack-mistral | 18:49 | |
*** toddjohn has quit IRC | 18:49 | |
*** toddjoh__ has quit IRC | 18:51 | |
*** toddjohn has joined #openstack-mistral | 18:52 | |
*** tonytan4ever has joined #openstack-mistral | 19:17 | |
*** toddjohn has quit IRC | 19:31 | |
*** toddjohn has joined #openstack-mistral | 19:41 | |
*** slagle has joined #openstack-mistral | 20:08 | |
slagle | hi, are there cores around who could take a look at https://review.openstack.org/#/c/347354/ ? | 20:09 |
slagle | it's blocking tripleo from consuming latest openstackclient with mistralclient | 20:10 |
kong | slagle: no problem, I will take a look, thanks for the fixing | 21:30 |
*** tonytan4ever has quit IRC | 21:51 | |
*** toddjohn has quit IRC | 22:45 | |
*** toddjohn has joined #openstack-mistral | 22:46 | |
*** toddjohn has quit IRC | 22:50 | |
*** vishwanathj has quit IRC | 23:02 | |
*** chlong has quit IRC | 23:38 | |
*** rrecio has quit IRC | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!