*** apsarshaik has quit IRC | 00:20 | |
*** apsarshaik has joined #openstack-mistral | 00:23 | |
*** bobh has joined #openstack-mistral | 00:29 | |
*** bobh has quit IRC | 00:43 | |
*** cheneydc has joined #openstack-mistral | 00:58 | |
*** cheneydc has quit IRC | 01:20 | |
*** bobh has joined #openstack-mistral | 01:44 | |
*** bobh has quit IRC | 01:50 | |
*** bobh has joined #openstack-mistral | 02:47 | |
*** bobh has quit IRC | 02:52 | |
rakhmerov | xavierhardy: yes | 04:11 |
---|---|---|
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication https://review.openstack.org/337100 | 04:18 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add authentication options for KeyCloak OIDC https://review.openstack.org/336488 | 04:19 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication https://review.openstack.org/337100 | 04:19 |
rakhmerov | xavierhardy: what is update_commit for? | 04:29 |
rakhmerov | the rest in this patch is fine | 04:30 |
rakhmerov | xavierhardy: I would suggest you move this script from the root folder to tools/ if it's really needed and document it better | 04:32 |
rakhmerov | I also don't understand "git push github $BRANCH --force"? Why github? | 04:33 |
rakhmerov | and I would send it in a separate patch because it's not related with the topic of this patch | 04:33 |
*** bobh has joined #openstack-mistral | 04:49 | |
*** bobh has quit IRC | 04:53 | |
xavierhardy | It's indeed unrelated | 05:49 |
xavierhardy | I added it by mistake | 05:49 |
xavierhardy | this is the script I use to update Gerrit and my github fork at the same time | 05:50 |
openstackgerrit | Xavier Hardy proposed openstack/mistral: Add filters to all collections listing functions (tags included) https://review.openstack.org/334311 | 05:50 |
xavierhardy | done | 05:50 |
*** tonytan4ever has quit IRC | 05:55 | |
*** Ravikiran_K has joined #openstack-mistral | 06:01 | |
*** apsarshaik has quit IRC | 06:33 | |
*** apsarshaik has joined #openstack-mistral | 06:38 | |
*** bobh has joined #openstack-mistral | 06:50 | |
openstackgerrit | Xavier Hardy proposed openstack/mistral: Add support for custom YAQL functions https://review.openstack.org/334804 | 06:55 |
*** tonytan4ever has joined #openstack-mistral | 06:55 | |
*** bobh has quit IRC | 06:55 | |
*** tonytan4ever has quit IRC | 07:00 | |
*** apsarshaik has quit IRC | 07:00 | |
*** apsarshaik has joined #openstack-mistral | 07:00 | |
rakhmerov | xavierhardy: ok, thanks! | 07:09 |
rakhmerov | xavierhardy: https://review.openstack.org/#/c/334804/5, I don't understand again what you do in tutorial :) | 07:14 |
rakhmerov | you chose random_uuid but it still uses wf_utils and finds tasks etc. etc. | 07:14 |
rakhmerov | I really don't understand why | 07:15 |
xavierhardy | because you wanted it to use the DB | 07:15 |
rakhmerov | I wanted? | 07:15 |
xavierhardy | or someone else | 07:15 |
xavierhardy | to show how to use the DB API in YAQL functions | 07:15 |
rakhmerov | ok, let me read through the comments | 07:15 |
*** jpich has joined #openstack-mistral | 07:16 | |
xavierhardy | But if you come up with something more interesting please go ahead. Per my previous comment, I think some interesting functions will be using specific Mistral functions like querying DB. | 07:16 |
xavierhardy | Renat Akhmerov Jun 30 6:52 AM Patch Set 1:Xavier, it's up to you. For example, it could a function that chooses minimal value from iterable of provided values. But if you come up with something more interesting please go ahead. Per my previous comment, I think some interesting functions will be using specific Mistral functions like querying DB. | 07:17 |
rakhmerov | xavierhardy: first of all, let me apologize | 07:18 |
xavierhardy | np | 07:18 |
rakhmerov | I think it's really my fault that we have this confusion | 07:18 |
rakhmerov | yes, you're right, I said that | 07:18 |
rakhmerov | but I said that assuming that we'll work further and establish some stable API that could be treated as public | 07:18 |
xavierhardy | OK | 07:19 |
rakhmerov | later after this comment there was another one where I said that wf_utils should not be used since it's a purely internal thing now | 07:19 |
xavierhardy | but still, it was also said it must use context | 07:19 |
rakhmerov | but people would consider it as something legal and safe to use | 07:19 |
xavierhardy | ok | 07:20 |
rakhmerov | yeah, well | 07:20 |
rakhmerov | as far as context | 07:20 |
rakhmerov | I see two options: 1) just mention that in the docs saying that "ok, you can also use context to extract some data and manipulate with it) | 07:20 |
rakhmerov | 2) come up with something simple as counting variables in the context | 07:21 |
rakhmerov | something that may not be so useful but would be OK for a tutorial | 07:21 |
rakhmerov | we don't have to provide something 100% useful | 07:22 |
xavierhardy | Why not just remove the DB call and use the execution ID as a namespace instead | 07:22 |
xavierhardy | ? | 07:22 |
rakhmerov | ok too | 07:22 |
rakhmerov | yes | 07:22 |
rakhmerov | again: my point is "let's not use anything that can potentially change w/o letting users know" | 07:23 |
rakhmerov | DB API, wf_utils, etc. | 07:23 |
rakhmerov | if it's something that just fetches data from wf context then it's fine | 07:23 |
xavierhardy | Cool | 07:24 |
rakhmerov | :) | 07:25 |
rakhmerov | again, I'm sorry for confusion, I should have been more clear | 07:25 |
xavierhardy | from uuid import uuid5, UUID | 07:25 |
xavierhardy | from time import time | 07:25 |
xavierhardy | def random_uuid_(context): | 07:25 |
xavierhardy | """generate a UUID using the execution ID and the clock""" | 07:25 |
xavierhardy | # fetch the current workflow execution ID found in the context | 07:25 |
xavierhardy | execution_id = context['__execution']['id'] | 07:25 |
xavierhardy | time_str = str(time()) | 07:25 |
xavierhardy | execution_uuid = UUID(execution_id) | 07:26 |
xavierhardy | return uuid5(execution_uuid, time_str) | 07:26 |
xavierhardy | is it OK, like this? | 07:26 |
rakhmerov | thumb up! | 07:27 |
rakhmerov | :) | 07:27 |
xavierhardy | OK | 07:27 |
xavierhardy | I'll push this | 07:27 |
rakhmerov | I'd be satisfied with it | 07:27 |
rakhmerov | thanks, please do, I'll give my +2 | 07:27 |
rakhmerov | xavierhardy: btw, did you see the comment from d0ugal? | 07:27 |
xavierhardy | I need to fix some other stuff in the rst file (task is still mentioned) | 07:27 |
xavierhardy | I have simplified it | 07:28 |
rakhmerov | ok | 07:28 |
xavierhardy | but I think it needs to be complete | 07:28 |
xavierhardy | like a tutorial | 07:28 |
rakhmerov | well, I'm ok with it but he's making a good point actually | 07:28 |
xavierhardy | with this, you can just create a folder and test it right away | 07:28 |
xavierhardy | I removed dependencies to pbr and used a vanilla setup.py | 07:29 |
rakhmerov | instead of explaining in details how to configure all the stuff maybe in tutorials like this we should just provide references to where it's explained | 07:29 |
rakhmerov | xavierhardy: well, yes, I see what you're saying | 07:29 |
rakhmerov | I don't have a too strong opinion here | 07:29 |
rakhmerov | I'm ok with your version too | 07:30 |
xavierhardy | If you find a documentation that is as clear as this one, I agree a reference is fine, but newcomer will definitely have problems with this. | 07:31 |
xavierhardy | *newcomers | 07:31 |
*** mgershen has joined #openstack-mistral | 07:32 | |
rakhmerov | agree | 07:33 |
rakhmerov | as far as the docs, I recently discussed it with some members. Ideally, I would like to do a full revision and get it into order | 07:33 |
openstackgerrit | Xavier Hardy proposed openstack/mistral: Add support for custom YAQL functions https://review.openstack.org/334804 | 07:34 |
rakhmerov | now it's a little bit messed up | 07:34 |
rakhmerov | no clear structure | 07:34 |
rakhmerov | lots of gaps | 07:34 |
rakhmerov | maybe I'll find some time for this in the end of the cycle | 07:34 |
rakhmerov | hparekh: hey, you here? | 07:35 |
rakhmerov | hparekh: would you please look at https://review.openstack.org/#/c/336466/? It is pretty simple | 07:35 |
hparekh | rakhmerov, yeah ok sure | 07:37 |
rakhmerov | thanks | 07:38 |
rakhmerov | it removes the legacy of our tricky rpc that no longer exists | 07:38 |
rakhmerov | xavierhardy: docs gate failed on your latest patchset | 07:42 |
rakhmerov | http://status.openstack.org/zuul/ | 07:42 |
xavierhardy | checking | 07:49 |
*** chlong has quit IRC | 07:52 | |
xavierhardy | it does not seem related to the doc itself | 07:53 |
xavierhardy | 2016-07-05 07:38:03.136877 | git.exc.GitCommandError: 'git remote prune --dry-run origin' returned with exit code 128 | 07:53 |
xavierhardy | 2016-07-05 07:38:03.136925 | stderr: 'fatal: unable to connect to git.openstack.org: | 07:53 |
xavierhardy | 2016-07-05 07:38:03.136980 | git.openstack.org[0: 2001:4800:7819:103:be76:4eff:fe06:63c]: errno=Network is unreachable | 07:53 |
openstackgerrit | Merged openstack/mistral: Remove obsolete config option "use_mistral_rpc" https://review.openstack.org/336466 | 07:53 |
xavierhardy | but I found an error still | 07:56 |
ddeja | Hey rakhmerov, about my comment in https://review.openstack.org/#/c/337100/ | 07:57 |
ddeja | I realised that HTTPError woudl also be raised in case, for example, HTTP error 500 | 07:58 |
ddeja | so even 'except HTTPError' can hidden some errors, that's to bad that there is no 'HTTPError401' exception | 07:58 |
xavierhardy | I'll check that later | 07:59 |
ddeja | so it may be OK to use general Exception in this case | 07:59 |
rakhmerov | ddeja: hi | 08:01 |
rakhmerov | yes | 08:01 |
rakhmerov | I tested it in different cases, client error (bad request), server error and connection error | 08:01 |
rakhmerov | it works in all cases | 08:02 |
ddeja | rakhmerov: yes, I'm sure it works | 08:02 |
ddeja | I was just wondering if this should act differnetly depending the type of error | 08:02 |
rakhmerov | ddeja: I'm trying to get more people review your patches but no big luck yet ) | 08:02 |
rakhmerov | seems like they are scared of your patches | 08:02 |
ddeja | rakhmerov: oh, that's too bad | 08:03 |
*** tonytan4ever has joined #openstack-mistral | 08:03 | |
ddeja | I may try to redefine them | 08:03 |
rakhmerov | ddeja: maybe you should also be pinging core reviewers ) | 08:03 |
ddeja | and make them smaller | 08:03 |
rakhmerov | redefine what? No, your patches are fine | 08:03 |
rakhmerov | no need to rewrite them | 08:03 |
ddeja | I wanted to do so on yesterday meeting ;) | 08:03 |
rakhmerov | we just need to make people review them ) | 08:03 |
rakhmerov | ddeja: what meeting? | 08:04 |
rakhmerov | meeting we were supposed to have but didn't have? :) | 08:04 |
*** chlong has joined #openstack-mistral | 08:04 | |
ddeja | that one | 08:04 |
rakhmerov | ok :) sorry about that | 08:04 |
ddeja | no problem | 08:04 |
rakhmerov | it was July 4th in US and a couple of more people told me that they wouldn't be there | 08:05 |
rakhmerov | so I decided to cancel it, again | 08:05 |
ddeja | I can as kong and hparekh to look on this patch https://review.openstack.org/#/c/194117/ right now :) please guys take a look on it (and other related changes) when you have time :) | 08:06 |
rakhmerov | and nmakhotkin | 08:06 |
ddeja | oh, sure | 08:07 |
rakhmerov | (since he is an original author :) ) | 08:07 |
*** tonytan4ever has quit IRC | 08:08 | |
nmakhotkin | hi guys | 08:09 |
nmakhotkin | I'll review | 08:09 |
openstackgerrit | Xavier Hardy proposed openstack/mistral: Add support for custom YAQL functions https://review.openstack.org/334804 | 08:09 |
nmakhotkin | rakhmerov, ddeja: ^^ | 08:09 |
xavierhardy | there were only warnings, I fixed them | 08:09 |
rakhmerov | ok | 08:10 |
ddeja | nmakhotkin: thanks! | 08:11 |
*** shardy has joined #openstack-mistral | 08:12 | |
*** apsarshaik has quit IRC | 08:13 | |
*** apsarshaik has joined #openstack-mistral | 08:23 | |
nmakhotkin | rakhmerov, I voted +2 | 08:25 |
nmakhotkin | but I'm not sure if it is correct for me to approve | 08:25 |
nmakhotkin | since I am the change-author | 08:26 |
rakhmerov | I think it's ok because you're no longer working on them | 08:31 |
rakhmerov | but I can do this, no problem | 08:32 |
nmakhotkin | thanks :) | 08:34 |
nmakhotkin | rakhmerov: this patch was on review for over a year :) | 08:35 |
rakhmerov | yes | 08:35 |
nmakhotkin | since 17 Jun 2015 | 08:35 |
rakhmerov | and finally got merged :) | 08:35 |
ddeja | rakhmerov, nmakhotkin: thanks! | 08:36 |
nmakhotkin | yes :) | 08:36 |
rakhmerov | nmakhotkin: congrats! Your work was not just a waste ) | 08:36 |
nmakhotkin | hooray! :) | 08:36 |
rakhmerov | :) | 08:36 |
nmakhotkin | ddeja: thank you! | 08:37 |
ddeja | nmakhotkin: no problem. For this patch it was only rebasing :) | 08:38 |
openstackgerrit | Merged openstack/mistral: New RPC layer implementation https://review.openstack.org/194117 | 08:42 |
*** apsarshaik has quit IRC | 08:45 | |
*** apsarshaik has joined #openstack-mistral | 08:46 | |
openstackgerrit | Merged openstack/mistral: Add support for custom YAQL functions https://review.openstack.org/334804 | 08:48 |
*** apsarshaik has quit IRC | 08:51 | |
*** apsarshaik has joined #openstack-mistral | 08:51 | |
*** bobh has joined #openstack-mistral | 08:52 | |
*** bobh has quit IRC | 08:56 | |
rakhmerov | ddeja: you need to rebase other patches | 08:58 |
rakhmerov | they are in conflict now | 08:58 |
*** apsarshaik has quit IRC | 09:03 | |
*** apsarshaik has joined #openstack-mistral | 09:04 | |
ddeja | rakhmerov: yeah, sure | 09:23 |
openstackgerrit | Dawid Deja proposed openstack/mistral: Integrating new RPC layer with Mistral https://review.openstack.org/197563 | 09:42 |
openstackgerrit | Dawid Deja proposed openstack/mistral: Make RPC implementation configurable https://review.openstack.org/197562 | 09:42 |
openstackgerrit | Dawid Deja proposed openstack/mistral: Adding OsloRPC server and client https://review.openstack.org/197561 | 09:42 |
openstackgerrit | Dawid Deja proposed openstack/mistral: Enable 'at-least-once' and 'at-most-once' delivery modes in RPC layer https://review.openstack.org/336548 | 09:42 |
openstackgerrit | Dawid Deja proposed openstack/mistral: Add tests for Kombu driver https://review.openstack.org/330483 | 09:42 |
*** bobh has joined #openstack-mistral | 09:53 | |
*** jpich has quit IRC | 09:54 | |
*** jpich has joined #openstack-mistral | 09:54 | |
*** bobh has quit IRC | 09:57 | |
*** mgershen has quit IRC | 10:00 | |
*** mgershen has joined #openstack-mistral | 10:00 | |
*** mgershen has quit IRC | 10:05 | |
*** apsarshaik has quit IRC | 10:07 | |
*** apsarshaik has joined #openstack-mistral | 10:07 | |
*** Ravikiran_K has quit IRC | 10:10 | |
nmakhotkin | ddeja: be aware of this: https://review.openstack.org/#/c/197561/27/mistral/engine/rpc/oslo/oslo_server.py | 10:10 |
nmakhotkin | I think the code above was written before the oslo created mentioned warnings | 10:11 |
nmakhotkin | anyway, I approved the patch | 10:12 |
openstackgerrit | Merged openstack/mistral: Adding OsloRPC server and client https://review.openstack.org/197561 | 10:21 |
*** mgershen has joined #openstack-mistral | 10:29 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication https://review.openstack.org/337100 | 10:29 |
*** apsarshaik has quit IRC | 10:38 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Release note for KeyCloak OIDC support https://review.openstack.org/337603 | 10:42 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Release note for KeyCloak OIDC support https://review.openstack.org/337603 | 10:46 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication https://review.openstack.org/337100 | 10:46 |
openstackgerrit | Merged openstack/mistral: Add action context to all action executions https://review.openstack.org/334315 | 10:52 |
*** bobh has joined #openstack-mistral | 10:54 | |
*** bobh has quit IRC | 10:58 | |
*** ramishra has joined #openstack-mistral | 11:11 | |
ddeja | nmakhotkin: Hm, I didn't see any warning in logs. But I'll take a look once again, thanks! | 11:11 |
openstackgerrit | Merged openstack/mistral: Make RPC implementation configurable https://review.openstack.org/197562 | 11:13 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Release note for KeyCloak OIDC support https://review.openstack.org/337603 | 11:16 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add authentication options for KeyCloak OIDC https://review.openstack.org/336488 | 11:16 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication https://review.openstack.org/337100 | 11:16 |
*** tonytan4ever has joined #openstack-mistral | 12:04 | |
*** tonytan4ever has quit IRC | 12:09 | |
*** chlong has quit IRC | 12:12 | |
*** openstackgerrit has quit IRC | 12:19 | |
*** openstackgerrit has joined #openstack-mistral | 12:19 | |
*** dprince has joined #openstack-mistral | 12:27 | |
*** chlong has joined #openstack-mistral | 12:43 | |
*** apsarshaik has joined #openstack-mistral | 12:54 | |
*** apsarshaik has quit IRC | 13:02 | |
*** apsarshaik has joined #openstack-mistral | 13:02 | |
*** tonytan4ever has joined #openstack-mistral | 13:05 | |
*** tonytan4ever has quit IRC | 13:10 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Release note for KeyCloak OIDC support https://review.openstack.org/337603 | 13:15 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication https://review.openstack.org/337100 | 13:16 |
*** vishwanathj has joined #openstack-mistral | 13:35 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Release note for KeyCloak OIDC support https://review.openstack.org/337603 | 13:41 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication https://review.openstack.org/337100 | 13:41 |
*** apsarshaik has quit IRC | 13:43 | |
*** tonytan4ever has joined #openstack-mistral | 13:56 | |
nmakhotkin | I noticed there is added a new job for python 3.5 | 14:03 |
nmakhotkin | And it passed in Mistral :) | 14:04 |
*** bobh has joined #openstack-mistral | 14:06 | |
*** apsarshaik has joined #openstack-mistral | 14:09 | |
*** dmellado has quit IRC | 14:21 | |
*** dmellado has joined #openstack-mistral | 14:21 | |
xavierhardy | can someone check https://review.openstack.org/334311 , please? See you tomorrow, have a nice evening | 14:26 |
*** dmellado has quit IRC | 14:29 | |
openstackgerrit | Dougal Matthews proposed openstack/mistral: Fix the use of both adhoc actions and "with-items" in workflows https://review.openstack.org/337696 | 14:30 |
*** dmellado has joined #openstack-mistral | 14:30 | |
*** tonytan4ever has quit IRC | 14:39 | |
*** tonytan4ever has joined #openstack-mistral | 14:39 | |
*** apsarshaik has quit IRC | 14:43 | |
*** apsarshaik has joined #openstack-mistral | 14:44 | |
*** apsarshaik has quit IRC | 14:49 | |
*** dprince has quit IRC | 14:57 | |
*** dprince has joined #openstack-mistral | 14:58 | |
d0ugal | Is mistral-dashboard an active project? | 15:05 |
ddeja | d0ugal: I remmember that there was some on-going work in mistral-dashboard in mitaka cycle. | 15:06 |
ddeja | but I'm not aware of anybody doing anything in Newton | 15:07 |
*** bobh has quit IRC | 15:07 | |
d0ugal | ddeja: Thanks, I was just wondering. It doesn't seem very active :) | 15:08 |
*** bobh has joined #openstack-mistral | 15:17 | |
*** openstackgerrit has quit IRC | 15:33 | |
*** openstackgerrit has joined #openstack-mistral | 15:34 | |
*** dprince has quit IRC | 15:35 | |
*** dprince has joined #openstack-mistral | 15:36 | |
*** harlowja has joined #openstack-mistral | 15:40 | |
*** gyee has joined #openstack-mistral | 15:45 | |
openstackgerrit | Jeff Peeler proposed openstack/mistral: Add configuration option for endpoint type https://review.openstack.org/335637 | 16:05 |
*** jpich has quit IRC | 16:26 | |
*** tonytan_brb has joined #openstack-mistral | 16:44 | |
*** tonytan4ever has quit IRC | 16:46 | |
*** vishwanathj has quit IRC | 17:03 | |
*** shardy has quit IRC | 17:31 | |
*** tonytan_brb has quit IRC | 17:34 | |
*** tonytan4ever has joined #openstack-mistral | 18:15 | |
*** gyee has quit IRC | 19:31 | |
openstackgerrit | Dan Prince proposed openstack/mistral: Lazy load client classes https://review.openstack.org/337837 | 19:40 |
*** dprince has quit IRC | 19:50 | |
*** gyee has joined #openstack-mistral | 20:55 | |
*** tonytan4ever has quit IRC | 21:09 | |
*** tonytan4ever has joined #openstack-mistral | 21:49 | |
*** bobh has quit IRC | 22:08 | |
*** bobh has joined #openstack-mistral | 22:11 | |
*** bobh has quit IRC | 22:16 | |
*** rrecio has joined #openstack-mistral | 22:20 | |
*** rrecio_ has joined #openstack-mistral | 22:21 | |
*** rrecio has quit IRC | 22:24 | |
*** rrecio_ has quit IRC | 22:31 | |
*** bobh has joined #openstack-mistral | 22:56 | |
*** dprince has joined #openstack-mistral | 23:04 | |
*** dprince has quit IRC | 23:22 | |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Add db models for event trigger https://review.openstack.org/320497 | 23:36 |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Add event engine service https://review.openstack.org/320500 | 23:36 |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Add functional tests for event engine functions https://review.openstack.org/336463 | 23:36 |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Add event trigger REST API https://review.openstack.org/320509 | 23:36 |
*** tonytan4ever has quit IRC | 23:41 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!