Tuesday, 2016-07-05

*** apsarshaik has quit IRC00:20
*** apsarshaik has joined #openstack-mistral00:23
*** bobh has joined #openstack-mistral00:29
*** bobh has quit IRC00:43
*** cheneydc has joined #openstack-mistral00:58
*** cheneydc has quit IRC01:20
*** bobh has joined #openstack-mistral01:44
*** bobh has quit IRC01:50
*** bobh has joined #openstack-mistral02:47
*** bobh has quit IRC02:52
rakhmerovxavierhardy: yes04:11
openstackgerritRenat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication  https://review.openstack.org/33710004:18
openstackgerritRenat Akhmerov proposed openstack/mistral: Add authentication options for KeyCloak OIDC  https://review.openstack.org/33648804:19
openstackgerritRenat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication  https://review.openstack.org/33710004:19
rakhmerovxavierhardy: what is update_commit for?04:29
rakhmerovthe rest in this patch is fine04:30
rakhmerovxavierhardy: I would suggest you move this script from the root folder to tools/ if it's really needed and document it better04:32
rakhmerovI also don't understand "git push github $BRANCH --force"? Why github?04:33
rakhmerovand I would send it in a separate patch because it's not related with the topic of this patch04:33
*** bobh has joined #openstack-mistral04:49
*** bobh has quit IRC04:53
xavierhardyIt's indeed unrelated05:49
xavierhardyI added it by mistake05:49
xavierhardythis is the script I use to update Gerrit and my github fork at the same time05:50
openstackgerritXavier Hardy proposed openstack/mistral: Add filters to all collections listing functions (tags included)  https://review.openstack.org/33431105:50
xavierhardydone05:50
*** tonytan4ever has quit IRC05:55
*** Ravikiran_K has joined #openstack-mistral06:01
*** apsarshaik has quit IRC06:33
*** apsarshaik has joined #openstack-mistral06:38
*** bobh has joined #openstack-mistral06:50
openstackgerritXavier Hardy proposed openstack/mistral: Add support for custom YAQL functions  https://review.openstack.org/33480406:55
*** tonytan4ever has joined #openstack-mistral06:55
*** bobh has quit IRC06:55
*** tonytan4ever has quit IRC07:00
*** apsarshaik has quit IRC07:00
*** apsarshaik has joined #openstack-mistral07:00
rakhmerovxavierhardy: ok, thanks!07:09
rakhmerovxavierhardy: https://review.openstack.org/#/c/334804/5, I don't understand again what you do in tutorial :)07:14
rakhmerovyou chose random_uuid but it still uses wf_utils and finds tasks etc. etc.07:14
rakhmerovI really don't understand why07:15
xavierhardybecause you wanted it to use the DB07:15
rakhmerovI wanted?07:15
xavierhardyor someone else07:15
xavierhardyto show how to use the DB API in YAQL functions07:15
rakhmerovok, let me read through the comments07:15
*** jpich has joined #openstack-mistral07:16
xavierhardyBut if you come up with something more interesting please go ahead. Per my previous comment, I think some interesting functions will be using specific Mistral functions like querying DB.07:16
xavierhardyRenat Akhmerov  Jun 30 6:52 AM  Patch Set 1:Xavier, it's up to you. For example, it could a function that chooses minimal value from iterable of provided values. But if you come up with something more interesting please go ahead. Per my previous comment, I think some interesting functions will be using specific Mistral functions like querying DB.07:17
rakhmerovxavierhardy: first of all, let me apologize07:18
xavierhardynp07:18
rakhmerovI think it's really my fault that we have this confusion07:18
rakhmerovyes, you're right, I said that07:18
rakhmerovbut I said that assuming that we'll work further and establish some stable API that could be treated as public07:18
xavierhardyOK07:19
rakhmerovlater after this comment there was another one where I said that wf_utils should not be used since it's a purely internal thing now07:19
xavierhardybut still, it was also said it must use context07:19
rakhmerovbut people would consider it as something legal and safe to use07:19
xavierhardyok07:20
rakhmerovyeah, well07:20
rakhmerovas far as context07:20
rakhmerovI see two options: 1) just mention that in the docs saying that "ok, you can also use context to extract some data and manipulate with it)07:20
rakhmerov2) come up with something simple as counting variables in the context07:21
rakhmerovsomething that may not be so useful but would be OK for a tutorial07:21
rakhmerovwe don't have to provide something 100% useful07:22
xavierhardyWhy not just remove the DB call and use the execution ID as a namespace instead07:22
xavierhardy?07:22
rakhmerovok too07:22
rakhmerovyes07:22
rakhmerovagain: my point is "let's not use anything that can potentially change w/o letting users know"07:23
rakhmerovDB API, wf_utils, etc.07:23
rakhmerovif it's something that just fetches data from wf context then it's fine07:23
xavierhardyCool07:24
rakhmerov:)07:25
rakhmerovagain, I'm sorry for confusion, I should have been more clear07:25
xavierhardyfrom uuid import uuid5, UUID07:25
xavierhardyfrom time import time07:25
xavierhardydef random_uuid_(context):07:25
xavierhardy    """generate a UUID using the execution ID and the clock"""07:25
xavierhardy    # fetch the current workflow execution ID found in the context07:25
xavierhardy    execution_id = context['__execution']['id']07:25
xavierhardy    time_str = str(time())07:25
xavierhardy    execution_uuid = UUID(execution_id)07:26
xavierhardy    return uuid5(execution_uuid, time_str)07:26
xavierhardyis it OK, like this?07:26
rakhmerovthumb up!07:27
rakhmerov:)07:27
xavierhardyOK07:27
xavierhardyI'll push this07:27
rakhmerovI'd be satisfied with it07:27
rakhmerovthanks, please do, I'll give my +207:27
rakhmerovxavierhardy: btw, did you see the comment from d0ugal?07:27
xavierhardyI need to fix some other stuff in the rst file (task is still mentioned)07:27
xavierhardyI have simplified it07:28
rakhmerovok07:28
xavierhardybut I think it needs to be complete07:28
xavierhardylike a tutorial07:28
rakhmerovwell, I'm ok with it but he's making a good point actually07:28
xavierhardywith this, you can just create a folder and test it right away07:28
xavierhardyI removed dependencies to pbr and used a vanilla setup.py07:29
rakhmerovinstead of explaining in details how to configure all the stuff maybe in tutorials like this we should just provide references to where it's explained07:29
rakhmerovxavierhardy: well, yes, I see what you're saying07:29
rakhmerovI don't have a too strong opinion here07:29
rakhmerovI'm ok with your version too07:30
xavierhardyIf you find a documentation that is as clear as this one, I agree a reference is fine, but newcomer will definitely have problems with this.07:31
xavierhardy*newcomers07:31
*** mgershen has joined #openstack-mistral07:32
rakhmerovagree07:33
rakhmerovas far as the docs, I recently discussed it with some members. Ideally, I would like to do a full revision and get it into order07:33
openstackgerritXavier Hardy proposed openstack/mistral: Add support for custom YAQL functions  https://review.openstack.org/33480407:34
rakhmerovnow it's a little bit messed up07:34
rakhmerovno clear structure07:34
rakhmerovlots of gaps07:34
rakhmerovmaybe I'll find some time for this in the end of the cycle07:34
rakhmerovhparekh: hey, you here?07:35
rakhmerovhparekh: would you please look at https://review.openstack.org/#/c/336466/? It is pretty simple07:35
hparekhrakhmerov, yeah ok sure07:37
rakhmerovthanks07:38
rakhmerovit removes the legacy of our tricky rpc that no longer exists07:38
rakhmerovxavierhardy: docs gate failed on your latest patchset07:42
rakhmerovhttp://status.openstack.org/zuul/07:42
xavierhardychecking07:49
*** chlong has quit IRC07:52
xavierhardyit does not seem related to the doc itself07:53
xavierhardy2016-07-05 07:38:03.136877 | git.exc.GitCommandError: 'git remote prune --dry-run origin' returned with exit code 12807:53
xavierhardy2016-07-05 07:38:03.136925 | stderr: 'fatal: unable to connect to git.openstack.org:07:53
xavierhardy2016-07-05 07:38:03.136980 | git.openstack.org[0: 2001:4800:7819:103:be76:4eff:fe06:63c]: errno=Network is unreachable07:53
openstackgerritMerged openstack/mistral: Remove obsolete config option "use_mistral_rpc"  https://review.openstack.org/33646607:53
xavierhardybut I found an error still07:56
ddejaHey rakhmerov, about my comment in https://review.openstack.org/#/c/337100/07:57
ddejaI realised that HTTPError woudl also be raised in case, for example, HTTP error 50007:58
ddejaso even 'except HTTPError' can hidden some errors, that's to bad that there is no 'HTTPError401' exception07:58
xavierhardyI'll check that later07:59
ddejaso it may be OK to use general Exception in this case07:59
rakhmerovddeja: hi08:01
rakhmerovyes08:01
rakhmerovI tested it in different cases, client error (bad request), server error and connection error08:01
rakhmerovit works in all cases08:02
ddejarakhmerov: yes, I'm sure it works08:02
ddejaI was just wondering if this should act differnetly depending the type of error08:02
rakhmerovddeja: I'm trying to get more people review your patches but no big luck yet )08:02
rakhmerovseems like they are scared of your patches08:02
ddejarakhmerov: oh, that's too bad08:03
*** tonytan4ever has joined #openstack-mistral08:03
ddejaI may try to redefine them08:03
rakhmerovddeja: maybe you should also be pinging core reviewers )08:03
ddejaand make them smaller08:03
rakhmerovredefine what? No, your patches are fine08:03
rakhmerovno need to rewrite them08:03
ddejaI wanted to do so on yesterday meeting ;)08:03
rakhmerovwe just need to make people review them )08:03
rakhmerovddeja: what meeting?08:04
rakhmerovmeeting we were supposed to have but didn't have? :)08:04
*** chlong has joined #openstack-mistral08:04
ddejathat one08:04
rakhmerovok :) sorry about that08:04
ddejano problem08:04
rakhmerovit was July 4th in US and a couple of more people told me that they wouldn't be there08:05
rakhmerovso I decided to cancel it, again08:05
ddejaI can as kong and hparekh to look on this patch https://review.openstack.org/#/c/194117/ right now :) please guys take a look on it (and other related changes) when you have time :)08:06
rakhmerovand nmakhotkin08:06
ddejaoh, sure08:07
rakhmerov(since he is an original author :) )08:07
*** tonytan4ever has quit IRC08:08
nmakhotkinhi guys08:09
nmakhotkinI'll review08:09
openstackgerritXavier Hardy proposed openstack/mistral: Add support for custom YAQL functions  https://review.openstack.org/33480408:09
nmakhotkinrakhmerov, ddeja: ^^08:09
xavierhardythere were only warnings, I fixed them08:09
rakhmerovok08:10
ddejanmakhotkin: thanks!08:11
*** shardy has joined #openstack-mistral08:12
*** apsarshaik has quit IRC08:13
*** apsarshaik has joined #openstack-mistral08:23
nmakhotkinrakhmerov, I voted +208:25
nmakhotkinbut I'm not sure if it is correct for me to approve08:25
nmakhotkinsince I am the change-author08:26
rakhmerovI think it's ok because you're no longer working on them08:31
rakhmerovbut I can do this, no problem08:32
nmakhotkinthanks :)08:34
nmakhotkinrakhmerov: this patch was on review for over a year :)08:35
rakhmerovyes08:35
nmakhotkinsince 17 Jun 201508:35
rakhmerovand finally got merged :)08:35
ddejarakhmerov, nmakhotkin: thanks!08:36
nmakhotkinyes :)08:36
rakhmerovnmakhotkin: congrats! Your work was not just a waste )08:36
nmakhotkinhooray! :)08:36
rakhmerov:)08:36
nmakhotkinddeja: thank you!08:37
ddejanmakhotkin: no problem. For this patch it was only rebasing :)08:38
openstackgerritMerged openstack/mistral: New RPC layer implementation  https://review.openstack.org/19411708:42
*** apsarshaik has quit IRC08:45
*** apsarshaik has joined #openstack-mistral08:46
openstackgerritMerged openstack/mistral: Add support for custom YAQL functions  https://review.openstack.org/33480408:48
*** apsarshaik has quit IRC08:51
*** apsarshaik has joined #openstack-mistral08:51
*** bobh has joined #openstack-mistral08:52
*** bobh has quit IRC08:56
rakhmerovddeja: you need to rebase other patches08:58
rakhmerovthey are in conflict now08:58
*** apsarshaik has quit IRC09:03
*** apsarshaik has joined #openstack-mistral09:04
ddejarakhmerov: yeah, sure09:23
openstackgerritDawid Deja proposed openstack/mistral: Integrating new RPC layer with Mistral  https://review.openstack.org/19756309:42
openstackgerritDawid Deja proposed openstack/mistral: Make RPC implementation configurable  https://review.openstack.org/19756209:42
openstackgerritDawid Deja proposed openstack/mistral: Adding OsloRPC server and client  https://review.openstack.org/19756109:42
openstackgerritDawid Deja proposed openstack/mistral: Enable 'at-least-once' and 'at-most-once' delivery modes in RPC layer  https://review.openstack.org/33654809:42
openstackgerritDawid Deja proposed openstack/mistral: Add tests for Kombu driver  https://review.openstack.org/33048309:42
*** bobh has joined #openstack-mistral09:53
*** jpich has quit IRC09:54
*** jpich has joined #openstack-mistral09:54
*** bobh has quit IRC09:57
*** mgershen has quit IRC10:00
*** mgershen has joined #openstack-mistral10:00
*** mgershen has quit IRC10:05
*** apsarshaik has quit IRC10:07
*** apsarshaik has joined #openstack-mistral10:07
*** Ravikiran_K has quit IRC10:10
nmakhotkinddeja: be aware of this: https://review.openstack.org/#/c/197561/27/mistral/engine/rpc/oslo/oslo_server.py10:10
nmakhotkinI think the code above was written before the oslo created mentioned warnings10:11
nmakhotkinanyway, I approved the patch10:12
openstackgerritMerged openstack/mistral: Adding OsloRPC server and client  https://review.openstack.org/19756110:21
*** mgershen has joined #openstack-mistral10:29
openstackgerritRenat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication  https://review.openstack.org/33710010:29
*** apsarshaik has quit IRC10:38
openstackgerritRenat Akhmerov proposed openstack/mistral: Release note for KeyCloak OIDC support  https://review.openstack.org/33760310:42
openstackgerritRenat Akhmerov proposed openstack/mistral: Release note for KeyCloak OIDC support  https://review.openstack.org/33760310:46
openstackgerritRenat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication  https://review.openstack.org/33710010:46
openstackgerritMerged openstack/mistral: Add action context to all action executions  https://review.openstack.org/33431510:52
*** bobh has joined #openstack-mistral10:54
*** bobh has quit IRC10:58
*** ramishra has joined #openstack-mistral11:11
ddejanmakhotkin: Hm, I didn't see any warning in logs. But I'll take a look once again, thanks!11:11
openstackgerritMerged openstack/mistral: Make RPC implementation configurable  https://review.openstack.org/19756211:13
openstackgerritRenat Akhmerov proposed openstack/mistral: Release note for KeyCloak OIDC support  https://review.openstack.org/33760311:16
openstackgerritRenat Akhmerov proposed openstack/mistral: Add authentication options for KeyCloak OIDC  https://review.openstack.org/33648811:16
openstackgerritRenat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication  https://review.openstack.org/33710011:16
*** tonytan4ever has joined #openstack-mistral12:04
*** tonytan4ever has quit IRC12:09
*** chlong has quit IRC12:12
*** openstackgerrit has quit IRC12:19
*** openstackgerrit has joined #openstack-mistral12:19
*** dprince has joined #openstack-mistral12:27
*** chlong has joined #openstack-mistral12:43
*** apsarshaik has joined #openstack-mistral12:54
*** apsarshaik has quit IRC13:02
*** apsarshaik has joined #openstack-mistral13:02
*** tonytan4ever has joined #openstack-mistral13:05
*** tonytan4ever has quit IRC13:10
openstackgerritRenat Akhmerov proposed openstack/mistral: Release note for KeyCloak OIDC support  https://review.openstack.org/33760313:15
openstackgerritRenat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication  https://review.openstack.org/33710013:16
*** vishwanathj has joined #openstack-mistral13:35
openstackgerritRenat Akhmerov proposed openstack/mistral: Release note for KeyCloak OIDC support  https://review.openstack.org/33760313:41
openstackgerritRenat Akhmerov proposed openstack/mistral: Add KeyCloak OpenID Connect server-side authentication  https://review.openstack.org/33710013:41
*** apsarshaik has quit IRC13:43
*** tonytan4ever has joined #openstack-mistral13:56
nmakhotkinI noticed there is added a new job for python 3.514:03
nmakhotkinAnd it passed in Mistral :)14:04
*** bobh has joined #openstack-mistral14:06
*** apsarshaik has joined #openstack-mistral14:09
*** dmellado has quit IRC14:21
*** dmellado has joined #openstack-mistral14:21
xavierhardycan someone check https://review.openstack.org/334311 , please? See you tomorrow, have a nice evening14:26
*** dmellado has quit IRC14:29
openstackgerritDougal Matthews proposed openstack/mistral: Fix the use of both adhoc actions and "with-items" in workflows  https://review.openstack.org/33769614:30
*** dmellado has joined #openstack-mistral14:30
*** tonytan4ever has quit IRC14:39
*** tonytan4ever has joined #openstack-mistral14:39
*** apsarshaik has quit IRC14:43
*** apsarshaik has joined #openstack-mistral14:44
*** apsarshaik has quit IRC14:49
*** dprince has quit IRC14:57
*** dprince has joined #openstack-mistral14:58
d0ugalIs mistral-dashboard an active project?15:05
ddejad0ugal: I remmember that there was some on-going work in mistral-dashboard in mitaka cycle.15:06
ddejabut I'm not aware of anybody doing anything in Newton15:07
*** bobh has quit IRC15:07
d0ugalddeja: Thanks, I was just wondering. It doesn't seem very active :)15:08
*** bobh has joined #openstack-mistral15:17
*** openstackgerrit has quit IRC15:33
*** openstackgerrit has joined #openstack-mistral15:34
*** dprince has quit IRC15:35
*** dprince has joined #openstack-mistral15:36
*** harlowja has joined #openstack-mistral15:40
*** gyee has joined #openstack-mistral15:45
openstackgerritJeff Peeler proposed openstack/mistral: Add configuration option for endpoint type  https://review.openstack.org/33563716:05
*** jpich has quit IRC16:26
*** tonytan_brb has joined #openstack-mistral16:44
*** tonytan4ever has quit IRC16:46
*** vishwanathj has quit IRC17:03
*** shardy has quit IRC17:31
*** tonytan_brb has quit IRC17:34
*** tonytan4ever has joined #openstack-mistral18:15
*** gyee has quit IRC19:31
openstackgerritDan Prince proposed openstack/mistral: Lazy load client classes  https://review.openstack.org/33783719:40
*** dprince has quit IRC19:50
*** gyee has joined #openstack-mistral20:55
*** tonytan4ever has quit IRC21:09
*** tonytan4ever has joined #openstack-mistral21:49
*** bobh has quit IRC22:08
*** bobh has joined #openstack-mistral22:11
*** bobh has quit IRC22:16
*** rrecio has joined #openstack-mistral22:20
*** rrecio_ has joined #openstack-mistral22:21
*** rrecio has quit IRC22:24
*** rrecio_ has quit IRC22:31
*** bobh has joined #openstack-mistral22:56
*** dprince has joined #openstack-mistral23:04
*** dprince has quit IRC23:22
openstackgerritLingxian Kong proposed openstack/mistral: Add db models for event trigger  https://review.openstack.org/32049723:36
openstackgerritLingxian Kong proposed openstack/mistral: Add event engine service  https://review.openstack.org/32050023:36
openstackgerritLingxian Kong proposed openstack/mistral: Add functional tests for event engine functions  https://review.openstack.org/33646323:36
openstackgerritLingxian Kong proposed openstack/mistral: Add event trigger REST API  https://review.openstack.org/32050923:36
*** tonytan4ever has quit IRC23:41

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!