Wednesday, 2016-06-15

*** rrecio has quit IRC00:06
*** cheneydc has joined #openstack-mistral00:59
*** toddjohn has joined #openstack-mistral01:53
*** toddjohn has quit IRC01:58
*** gyee has quit IRC02:59
rakhmerovszaher: hi04:18
*** vishwanathj has joined #openstack-mistral04:27
*** vishwanathj has quit IRC04:36
kongrakhmerov: hi, have you done the refactoring job?04:46
rakhmerovkong: hi!04:47
rakhmerovyes04:47
* kong wants to make sure before get off work04:47
kongrakhmerov: ok, cool04:47
rakhmerovthere's still some places but we'll be fixing them step by step04:47
kongi am planing to continue the event trigger bp04:47
kongrakhmerov: all right04:47
rakhmerovyep, I was going to ask you about it )04:47
konghah04:47
rakhmerovhow it is going04:47
rakhmerov:)04:47
konggood, thanks04:48
konghow abou you04:48
kongI was moving house those days, just finished04:48
kongrakhmerov:  I have to go catch the bug, will be here in the evening04:49
kongs/bug/bus04:49
rakhmerovok04:49
rakhmerovddeja: hi, are your patches ready for review?04:50
rakhmerovI mean RPC stuff04:50
openstackgerrithardik proposed openstack/mistral: Release note for murano actions support  https://review.openstack.org/32976305:09
openstackgerritMerged openstack/mistral: Add magnum certificates and mservices actions  https://review.openstack.org/32904205:09
openstackgerritMerged openstack/mistral: Rename the to_string method to to_json to clarify it's purpose  https://review.openstack.org/32788905:28
openstackgerritMerged openstack/python-mistralclient: Add osprofiler option to trace operations  https://review.openstack.org/32804505:29
*** openstackgerrit has quit IRC06:18
*** openstackgerrit has joined #openstack-mistral06:18
*** toddjohn has joined #openstack-mistral06:31
*** toddjohn has quit IRC06:36
mflobokong, should I add a new relese note here https://github.com/openstack/mistral/tree/master/releasenotes/notes ?06:37
hparekhmflobo, Hi you can use reno tool. make sure you are in root mistral (e.g. /opt/stack/mistral) and use reno new <note name>06:42
hparekhmflobo, It will create note at at releasenotes/notes directory06:43
openstackgerrithardik proposed openstack/mistral: Added doc string for enforce method  https://review.openstack.org/32977606:46
*** toddjohn has joined #openstack-mistral06:59
*** toddjohn has quit IRC07:04
*** FL1SK has quit IRC07:09
openstackgerrithardik proposed openstack/mistral: Added doc string for enforce method  https://review.openstack.org/32977607:12
*** mgershen has joined #openstack-mistral07:24
*** shardy has joined #openstack-mistral07:24
*** openstackgerrit has quit IRC07:33
*** openstackgerrit has joined #openstack-mistral07:33
*** shardy has quit IRC07:43
ddejarakhmerov: Hi - they are working, but I added note to config that using kombu is experimetnal - I'm writing tests for it08:04
ddejaand It would be good for someone else to test it before merging ;)08:04
*** FL1SK has joined #openstack-mistral08:06
*** shardy has joined #openstack-mistral08:10
ddejaIn general - they are ready for review. And I didn't change a lot - rebasing was unexpectedly easy08:12
rakhmerovddeja: ok, I see08:13
rakhmerovddeja: did you validate the logic and everything?08:13
rakhmerovI mean are you ok with the implementation that Nikolay provided?08:14
rakhmerovI'm asking because I remember that there was a lot to discuss on that08:14
rakhmerovand another question: are you planning to work on Pika impl soon?08:15
mflobohparekh, I'm not using reno tool (I don't know it BTW), so I'll create the YAML file and send the review08:15
ddejarakhmerov: generally I'm ok. I may found something while writing tests, but right now I don't see a lot of place for improvements08:17
ddejaabout pika, I was thinking to add it in separate patch when this one is merged08:18
ddejabut I can add it to current patchset if that would be better08:18
rakhmerovddeja: ok08:20
rakhmerovyes, I didn't mean to have it in these patches )08:20
rakhmerovddeja: no, it's definitely a separate patch08:20
rakhmerovmflobo: hi, please use reno08:21
rakhmerovit also creates a unique id for a release note08:21
rakhmerovreno new <note name>08:21
mfloborakhmerov, is there RPM for CentOS? or I must clone the repo08:22
*** dmk0202 has joined #openstack-mistral08:22
rakhmerovRPM for what?08:22
rakhmerovjust clone the repo, sure08:22
*** toddjohn has joined #openstack-mistral08:32
openstackgerritXavier Hardy proposed openstack/mistral: Fix API inconsistencies with GET /v2/workflows  https://review.openstack.org/32101609:14
*** mgershen has quit IRC09:16
*** toddjohn has quit IRC09:16
*** mgershen has joined #openstack-mistral09:16
*** mgershen has quit IRC09:21
kongmflobo: please take a look at http://docs.openstack.org/developer/reno/design.html09:39
dmelladomflobo: you can just install it using pip09:42
kongmflobo: in one word, pip install reno, go to mistral dir, run 'reno new magnum-actions-support'09:43
kongyou can see a new file created under releasenotes/notes/09:43
kongmodify that file. you can see other files as reference09:44
mflobokong, dmellado, thanks for the info, I'll do this today09:44
kongmflobo: thanks for that09:44
*** mgershen has joined #openstack-mistral09:45
kongrakhmerov: the new code looks awesome!09:46
konggood job, man09:46
dmelladokong: now that I got you here I was pinging hparekh the other day about the tempest plugin for mistral09:48
dmelladoIMHO the tests, even if bundled with mistral09:48
dmelladoshould follow the setup steps09:49
dmelladoand have a skip_checks in their base class09:49
dmelladowas there any reason for not having this?09:49
kongdmellado: what's your meaning by 'skip_checks'? what kind of tests do you want to skip?09:50
dmelladokong: as per another projects' tempest tests09:50
dmelladothere's a part on the setup steps09:51
dmelladothat skips the tests if the service isn't availble09:51
kongyeah09:51
dmelladoin this case, mistral xD09:51
dmelladoso as per RDO09:53
kongdo you mean, we should add skip_checks in test_openstack_actions.py?09:54
kongI didn't see other locations we should skip tests09:54
kongcould you please provide me more detail?09:55
openstackgerritMerged openstack/mistral: Added doc string for enforce method  https://review.openstack.org/32977609:57
dmelladokong: sorry, got pulled10:11
kong:-)10:11
rakhmerovkong: thanks :)10:12
dmelladokong: I was thinking about something like having that here maybe https://github.com/openstack/mistral/blob/master/mistral_tempest_tests/services/base.py10:13
dmelladoas the tests class inherits from there10:13
d0ugalSo, I am still learning YAQL, what is wrong with this? <% $.status or 'SUCCESS' %>10:13
kongdmellado: I just want to try to understand what problems you want to fix10:14
dmelladokong: in RDO, we split the package mistral between mistral and mistral-tests10:14
dmelladobut when we install the *test package and not mistral due to dependencies10:15
dmelladoit fails the tests as it tries to run them but the service isn't available10:15
dmelladoa simple skip if CONF.services_availble.mistral10:15
dmelladoshould fix that10:15
kongdmellado: hmm...I may know your problem10:17
dmelladokong: we can always skip that but I think having mistral implement a skip decorator would be cleaner10:18
kongdmellado: I wonder if mistral is the only project we see that problem?10:20
konghow do you deal with others?10:20
dmelladokong: every other project implements that skip decorator10:21
dmelladoso so far, mistral is the only one that I'm having to deal with in this way ;)10:21
* kong is looking at Murano10:21
dmelladokong: let me show you an example10:21
kongdmellado: appreciate10:22
kongI saw that here https://github.com/openstack/murano/blob/master/murano_tempest_tests/tests/api/application_catalog/base.py#L7210:22
dmelladokong: i.e. ceilometer10:22
dmelladohttps://github.com/openstack/ceilometer/blob/master/ceilometer/tests/tempest/api/base.py#L50-L5310:22
dmelladokong: yep, exactly ;)10:23
kongdmellado: ok, that should be easy to fix10:23
dmelladokong: I was checking the simple patch myself but it seems there's some call around I'm not familiar with10:23
kongdmellado: did you raise a ticket for that?10:23
dmelladokong: nope, but I'll do if you want it10:23
kongdmellado: yes, please10:24
kongleave the bug there, and I (or others) will do that10:24
kongdmellado: thanks10:24
kongfeel free to assign it to me if it's convenient for you10:25
dmelladokong: https://bugs.launchpad.net/mistral/+bug/159274810:28
openstackLaunchpad bug 1592748 in Mistral "Mistral tempest tests doesn't implement a skip method" [Undecided,New]10:28
dmelladowill do, thanks!10:28
dmelladokong: I can't assign it to you in launchpad, as I'm 'not related to the project, or so it says' xD10:28
dmelladoso please pick it up ;)10:28
kongdmellado: done10:29
dmelladothanks!10:29
dmelladokong: feel free to reach me when in doubts about this too ;)10:29
openstackgerritXavier Hardy proposed openstack/mistral: API inconsistencies with GET /v2/workflows  https://review.openstack.org/32101610:58
openstackgerritXavier Hardy proposed openstack/mistral: API inconsistencies with GET /v2/workflows  https://review.openstack.org/32101611:03
*** dprince has joined #openstack-mistral11:14
*** hparekh has quit IRC11:16
*** hparekh has joined #openstack-mistral11:19
*** hparekh_ has joined #openstack-mistral11:19
*** hparekh_ has quit IRC11:20
szaherHi guys11:28
szaherI am trying to run the get first image action from glance actions and it's not working and i am getting this error Invalid input [name=glance.images_get, class=NoneType, unexpected=[u'image_id']]11:28
kongsomething wrong when getting glance action input11:36
szaherkong: Yea I know11:36
kongszaher: what's the output of 'mistral action-list | grep glance' in your env?11:36
kongthere is no input param11:36
szaherthere is no input for glance.get_images11:36
szaher| glance.images_get                                                         | True      |                              | None                         | <none> | 2016-06-14 11:25:28 | None       |11:37
kongI saw that. maybe there is lack of testing towards openstack service integrations11:37
kongszaher: please fire a bug11:38
szaherthis is liberty release !11:38
kongi am in master11:39
szaherany idea how can I solve this ?11:40
kongszaher: take a look at sync_db.py in tools/11:42
openstackgerritMerged openstack/mistral: Release note for murano actions support  https://review.openstack.org/32976311:42
kongthat's the place we populate action db11:43
openstackgerritMarcos Fermín Lobo proposed openstack/mistral: Release noe for magnum actions support  https://review.openstack.org/32989412:02
mfloborakhmerov, kong, dmellado ^12:02
openstackgerritLingxian Kong proposed openstack/mistral: Add configuration for Mistral tempest testing  https://review.openstack.org/32989512:02
szaherkong: ./sync_db.sh --config-file /opt/stack/service/mistral/etc/mistral/mistral.conf12:03
szahervenv create: /opt/stack/venv/mistral/mistral/.tox/venv12:03
szaherit stuck here !12:03
dmelladomflobo: ack, I'll have a look later ;)12:03
kongmflobo: please take a look at https://github.com/openstack/mistral/blob/master/releasenotes/notes/new-service-actions-support-47279bd649732632.yaml, I believe adding a new service in Mistral will have some effect to upgrading.12:07
mflobokong, ok, I'll change the patchset, thanks12:08
kongwhen upgrading Mistral, operators need to run 'python tools/sync_db.py' somehow to re-populate the db12:08
* kong needs some sleep...12:09
szaherkong: I tried with sync_db and still glance has no inputs !12:19
mflobokong, should put the same "prelude" https://github.com/openstack/mistral/blob/master/releasenotes/notes/new-service-actions-support-47279bd649732632.yaml in mi patch?12:25
ddejaszaher: if you are facing bug regarding some action in liberty, probably the only way would be to write our own custom action http://docs.openstack.org/developer/mistral/developer/creating_custom_action.html12:27
ddejaszaher: here you can look at my plugin for talking with nova, you could do similar to talk with glance https://github.com/gryf/mistral-evacuate/blob/master/filter_vm_action.py12:28
openstackgerritMarcos Fermín Lobo proposed openstack/mistral: Release noe for magnum actions support  https://review.openstack.org/32989412:29
szaherddeja: there is a problem here. when I tried to install mistral liberty version the installed packages versions were exceeding the upper constraints for liberty !!12:56
szaherthat might be a problem12:56
szaherI tried to add upper.txt and install the max available version for liberty it didn't work !12:57
ddejaszaher: but you do install mistral in liberty version, right?12:58
*** rbrady has joined #openstack-mistral12:59
*** dprince has quit IRC13:02
szaheryes13:03
szaherszaher: and I was checking against upper constraints liberty13:03
mfloborakhmerov, I guess this blueprint can be set as finished https://blueprints.launchpad.net/mistral/+spec/add-policy-file13:09
szaherddeja: after installing with upper constraints actions are not created and I got this error message http://paste.openstack.org/show/516250/13:14
*** bobh has joined #openstack-mistral13:22
d0ugalWhy would you ever want to run this without a transaction? https://github.com/openstack/mistral/blob/master/mistral/services/actions.py#L3913:31
ddejaszaher: hm, thats strange that you have to apply upper-constriants... how did you install mistral?13:42
szahergit clone mistral_url13:43
szahercd mistral13:43
szahergit checkout origin/stable/liberty13:43
szaherpip install -e .13:43
szaherddeja: that's how I install mistral13:45
*** dprince has joined #openstack-mistral13:59
ddejaszaher: On my PC 'git checkout origin/stable/liberty' didn't really checkout me to liberty branch, but rather created new branch (so I am still on master), but this may be some misconfiguration on my side.14:02
ddejaszaher: It looks like installation is ok, so the only thing that I can advise is to write your own action that would connect to glance and do what you want to do14:03
ddejaszaher: BTW. I was able to succesfully launch mitaka mistral to work with kilo openstack, so maybe you can try to use newer version of mistral. Therefore we could fix bugs that hit you14:04
ddejabecouse for Liberty version it is unlikely to fix anything rather than security issue (AFAIC)14:05
*** dprince has quit IRC14:25
*** catintheroof has joined #openstack-mistral14:32
szaherddeja: Thanks! I will try mitaka version if not I will try to write my own workflows14:53
szaher*actions14:53
*** tonytan4ever has joined #openstack-mistral14:58
*** rrecio has joined #openstack-mistral14:58
*** toddjohn has joined #openstack-mistral15:04
*** catintheroof has quit IRC15:08
*** toddjohn has quit IRC15:09
*** rrecio has quit IRC15:11
*** rrecio has joined #openstack-mistral15:15
*** tonytan4ever has quit IRC15:24
*** shardy has quit IRC15:35
szaherddeja: mistral-db-manage is not working mitaka !!!. even sync_db.py !15:45
szaherI don't know what is wrong am I doing15:45
ddejaszaher: you have to provide logs/traceback. Without it I'm helpless15:46
szaherddeja: http://paste.openstack.org/show/516304/15:46
ddejaszaher: that's a bug on our side... I thought that bugfix was merged to mitaka branch. To fix this, go to file mistral/engine/rpc.py and delete lines 38-79. It should fix this15:50
szaherddeja: thanks15:51
*** dmk0202 has quit IRC15:52
szaherddeja: I think this patch needs to be backported !15:54
ddejaszaher: It should be. As I said, I thought it is already done15:55
szaherddeja: /opt/stack/venv/mistral/mistral/.tox/venv/local/lib/python2.7/site-packages/sqlalchemy/sql/default_comparator.py:153: SAWarning: The IN-predicate on "action_definitions_v2.id" was invoked with an empty sequence. This results in a contradiction, which nonetheless can be expensive to evaluate.  Consider alternative strategies for improved performance.15:55
ddejaszaher: it's only a Warning15:56
*** tonytan4ever has joined #openstack-mistral15:56
szaheractions table is empty15:56
szaherthe script takes long time and still waiting ... !!15:56
ddejaszaher: it may take some time. If it's empty after it finishes then there is a problem15:57
*** toddjohn has joined #openstack-mistral15:59
szaherddeja: for how long I should leave this script running ?16:02
*** toddjohn has quit IRC16:04
ddejaszaher: I would say that no longer than 10 minutes... did you use mistral-db-manage or sync-db script?16:04
szaherdb-manage then sync-db16:05
ddejaszaher: if it take too long, try sync_db.py script16:05
szaherddeja: http://paste.openstack.org/show/516311/ any idea why this is happening ?16:05
ddejait's the same, but gives more output, so it's esier to debug16:05
ddejaszaher: you got such traceback while running mistral-db-manage?16:06
szaherNo16:06
ddejaszaher: so when?16:07
*** krotscheck is now known as krotscheck_dcm16:09
szahermistral-server --conf..16:09
szaherglance actions has no input as well !16:09
szaherthe same problem exists16:09
ddejaszaher: OK, but you have used mistral action-list right? So it means that mistral server is working and when you try to launch it second time, which probably coused the tracebacks16:11
ddejacould you remind me what exaclty action you wanted to use?16:11
szaherthe simple get first image16:12
szaherget_image_id [task_ex_id=c5421350-256a-45c9-868e-563a341b736a] -> Failed to run action [action_ex_id=9039a9ae-b502-4643-9a84-a5d1b5b08b55, action_cls='<class 'mistral.actions.action_factory.GlanceAction'>', attributes='{u'client_method_name': u'images.list'}', params='{}'] |16:12
szaher|             |  GlanceAction.images.list failed: <class 'keystoneauth1.exceptions.auth.AuthorizationFailure'>: Cannot authorize API client.16:12
*** tonytan4ever has quit IRC16:14
ddejaszaher: so for now it looks like you need to write your own action16:14
ddejaszaher: and we have to fix a bug in mistral16:15
szaherddeja: do you think this is a problem with the action itself ?16:15
ddejaszaher: I don't know, but if there is no input parameters for actions, that should have some, there is a bug, probably on our side16:15
ddejaszaher: oh, but in this case there is some problem with autentication16:16
ddejaimages.list should just work...16:16
szaherit was working in liberty version !16:17
ddejaszaher: please check with configuration instruction https://github.com/openstack/mistral#configuring-mistral if everything is set16:18
ddejareinstall may overwrite some files16:18
*** tonytan4ever has joined #openstack-mistral16:19
szaherddeja: I am install mistral everytime in a new virtualenv16:19
szaheranyway I can't find any solid documentation and I am not sure about the project stability16:19
ddejaszaher: OK, but after upgrading from liberty to mitaka it may overwrite etc/mistral.conf and lost the keystone authtoken properties16:22
ddejaso mistral couldn't authenticate16:22
szaherddeja: by the way I am keeping the configuration file in a different place16:24
szaherIt's not in a place where oslo config generator will be able to reach16:25
ddejaszaher: oh, OK.16:25
*** tonytan4ever has quit IRC16:26
szaherddeja: Thanks for your help it's really appreciated but I fed up with mistral !16:26
ddejaszaher: I need to drop unfortunately. I'll be reachable tommorow from about 7 UTC.16:27
ddejaszaher: thank you for your feedback16:27
szaherddeja: have a good night16:27
ddejaszaher: thanks, bye16:27
*** dprince has joined #openstack-mistral16:31
*** tonytan4ever has joined #openstack-mistral17:17
*** tonytan4ever has quit IRC18:04
*** tonytan4ever has joined #openstack-mistral18:16
*** tonytan4ever has quit IRC18:19
*** toddjohn has joined #openstack-mistral18:41
*** toddjohn has quit IRC18:46
*** tonytan4ever has joined #openstack-mistral19:09
*** tonytan4ever has quit IRC19:14
*** dprince has quit IRC19:21
*** openstackgerrit has quit IRC19:33
*** openstackgerrit has joined #openstack-mistral19:33
*** krotscheck_dcm is now known as krotscheck20:00
*** toure has joined #openstack-mistral20:06
*** dprince has joined #openstack-mistral20:07
*** toure is now known as toure|biab20:19
*** toddjohn has joined #openstack-mistral20:24
*** toddjohn has quit IRC21:03
*** toddjohn has joined #openstack-mistral21:04
*** toddjohn has quit IRC21:09
*** dprince has quit IRC21:13
*** gyee has joined #openstack-mistral21:42
*** bobh has quit IRC21:58
*** openstackgerrit has quit IRC22:02
*** catintheroof has joined #openstack-mistral22:04
*** openstackgerrit has joined #openstack-mistral22:06
openstackgerritLingxian Kong proposed openstack/mistral: Fix postgresql test failure  https://review.openstack.org/33025022:28
*** catintheroof has quit IRC22:41
*** toddjohn has joined #openstack-mistral22:43
*** toddjohn has quit IRC22:47

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!