*** rena9067_ has quit IRC | 00:12 | |
*** Qiming has quit IRC | 00:24 | |
*** cheneydc has joined #openstack-mistral | 00:58 | |
*** Qiming has joined #openstack-mistral | 01:26 | |
rakhmerov | mflobo: hi, need a concrete example | 02:24 |
---|---|---|
*** gyee has quit IRC | 02:39 | |
*** vishwanathj has joined #openstack-mistral | 02:52 | |
*** vishwanathj has quit IRC | 02:58 | |
*** tonytan_brb has joined #openstack-mistral | 03:26 | |
*** tonytan4ever has quit IRC | 03:29 | |
*** tonytan_brb has quit IRC | 03:35 | |
openstackgerrit | hardik proposed openstack/mistral-specs: Replace deprecated library function os.popen() with subprocess https://review.openstack.org/267506 | 05:14 |
*** Ravikiran_K has joined #openstack-mistral | 05:21 | |
*** ig0r_ has joined #openstack-mistral | 06:00 | |
*** ig0r_ has quit IRC | 06:17 | |
mflobo | rakhmerov, hi, sure no problem. In this example http://paste.openstack.org/show/505243/ | 06:37 |
mflobo | rakhmerov, what happen in mistral if "setup_quota" task fails for whatever reason? | 06:38 |
mflobo | rakhmerov, The others tasks will continue? | 06:38 |
rakhmerov | no | 06:38 |
rakhmerov | the entire workflow will fail | 06:39 |
rakhmerov | however, you use on-complete instead of on-success in "setup_quota" then they will continue | 06:39 |
rakhmerov | more precisely, setup_cinder_quota will run | 06:39 |
rakhmerov | makes sense? | 06:40 |
mflobo | rakhmerov, but if "create_project" is the first task to be execute, and the "setup_quota" fails, the project created, right? | 06:40 |
rakhmerov | it's just like regular exception handling in Python with try-except-finally | 06:40 |
rakhmerov | yes, right | 06:40 |
mflobo | I see | 06:40 |
rakhmerov | so, if a task explicitly defines a handler for errors (on-error or on-complete) then workflow won't fail | 06:41 |
mflobo | rakhmerov, Is it possible to "rollback" in case of error? like SQL transactions concept? | 06:41 |
rakhmerov | if it doesn't then the wf will fail | 06:41 |
*** shardy has joined #openstack-mistral | 06:41 | |
rakhmerov | not yet, we'll start working on rollback I think in ~ a month | 06:41 |
mflobo | ok | 06:41 |
rakhmerov | still need to discuss details of the spec | 06:41 |
mflobo | I see | 06:42 |
rakhmerov | however, in order to do some rollback stuff you can define handlers | 06:42 |
rakhmerov | on-error | 06:42 |
rakhmerov | in conjunction with task-defaults thing it may be enough | 06:42 |
mflobo | rakhmerov, yep, right | 06:42 |
rakhmerov | ok | 06:42 |
rakhmerov | so stay tuned :) | 06:42 |
mflobo | sure ;) | 06:42 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: WIP: engine refactoring https://review.openstack.org/317879 | 06:44 |
openstackgerrit | Merged openstack/mistral-specs: Replace deprecated library function os.popen() with subprocess https://review.openstack.org/267506 | 06:52 |
*** Ravikiran_K has quit IRC | 07:08 | |
*** jtomasek has joined #openstack-mistral | 07:20 | |
rakhmerov | folks, has anyone seen that pep8 gate would fail with timeout? | 07:27 |
rakhmerov | it happens now to my patch: https://review.openstack.org/#/c/317879/ | 07:28 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: WIP: engine refactoring https://review.openstack.org/317879 | 07:32 |
*** chlong has quit IRC | 07:46 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: WIP: engine refactoring https://review.openstack.org/317879 | 08:05 |
*** ak____ has joined #openstack-mistral | 08:19 | |
ak____ | ok | 08:19 |
*** ig0r_ has joined #openstack-mistral | 08:20 | |
*** dmk0202 has joined #openstack-mistral | 08:28 | |
*** _gryf has quit IRC | 08:29 | |
*** dmowrer has joined #openstack-mistral | 08:52 | |
*** dmowrer has quit IRC | 08:56 | |
*** ak____ has quit IRC | 09:29 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: WIP: engine refactoring https://review.openstack.org/317879 | 09:41 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: WIP: engine refactoring https://review.openstack.org/317879 | 09:52 |
*** cheneydc has quit IRC | 09:54 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: WIP: engine refactoring https://review.openstack.org/317879 | 09:58 |
kong | rakhmerov: i'm waiting for the jekins result | 09:59 |
kong | it's successful on my own environment | 09:59 |
rakhmerov | kong: I see that it failed again | 10:00 |
rakhmerov | http://status.openstack.org/zuul/ | 10:00 |
kong | :-( | 10:00 |
kong | i will take a look at the log | 10:00 |
kong | don't know why. there is no error on my local | 10:01 |
rakhmerov | ok | 10:04 |
rakhmerov | it's still the same error | 10:04 |
kong | yeah | 10:05 |
rakhmerov | even though [testenv] config applies to all envs, right? | 10:05 |
kong | seems like that | 10:06 |
kong | i'm trying to modify [testenv:venv] | 10:06 |
kong | but theoretically, install_command in [testenv:docs] will override that in [testenv:venv] | 10:07 |
kong | no error on my local, i saw the right oslo.message version | 10:08 |
rakhmerov | hm.. weird | 10:08 |
kong | i am about to move that into [testenv:venv] and try jekins again | 10:08 |
rakhmerov | why venv? | 10:08 |
rakhmerov | venv is not used anywhere if I remember correctly | 10:09 |
rakhmerov | it's just for running things under virtual environment manually | 10:09 |
rakhmerov | in order to avoid starting tests | 10:09 |
kong | 2016-05-25 09:47:17.265 | + tox -evenv -- python setup.py build_sphinx | 10:09 |
kong | this is what's executed when doing 'tox -e docs' | 10:10 |
rakhmerov | oooh | 10:11 |
rakhmerov | I see | 10:11 |
rakhmerov | ok then | 10:11 |
rakhmerov | yeah, then it needs to be configured too, of course | 10:11 |
kong | just tried | 10:11 |
kong | let's wait to see the ret | 10:11 |
kong | rakhmerov: i have a question about the event trigger bp | 10:12 |
kong | does that mean, only infrastructure operators can use that API for event notification | 10:13 |
kong | after reading what Zane proposed in Zaqar | 10:13 |
kong | it will solve the problem that end user is facing | 10:13 |
rakhmerov | I don't remember exactly what he proposed ) I need to spend more time to get familiar with that | 10:14 |
rakhmerov | different focus now, sorry | 10:14 |
kong | in that mistral bp, 'users' expect to listen to rabbitmq in openstack deployment | 10:15 |
rakhmerov | yes | 10:15 |
kong | but in real world, end users should not know that information | 10:15 |
rakhmerov | yeah, ideally | 10:16 |
kong | so, I see that a limitation for that mistral feature | 10:17 |
rakhmerov | yes, right, you seem to be right about using it only by infrastructure ops | 10:17 |
rakhmerov | of course | 10:17 |
kong | that's the reason I was object to that at the beginning | 10:17 |
rakhmerov | Ceilometer or Zaqar are more user facing | 10:17 |
rakhmerov | kong: I think it's slightly a different use case | 10:18 |
rakhmerov | IMO | 10:18 |
kong | btw, seems jekins passes | 10:18 |
kong | yes, i just want to make sure you know that | 10:18 |
rakhmerov | yes!! | 10:18 |
rakhmerov | it passed | 10:18 |
kong | who is going to be the potentical user of that feature | 10:18 |
rakhmerov | so, getting back to event trigger | 10:18 |
rakhmerov | one way to make it more user friendly is to slightly abstract it out | 10:19 |
rakhmerov | so that we mask real OpenStack events moving in MQ back and forth | 10:19 |
kong | i am not sure i understand you by 'mask real OpenStack events' | 10:20 |
rakhmerov | for example, if I'm configuring an event trigger I don't specify "nova.create_vm" but I do specify something different that's established in Mistral docs | 10:20 |
rakhmerov | I mean we could represent those low level events differently for end users | 10:21 |
rakhmerov | in more user meaningful form | 10:21 |
kong | yes, it's an option | 10:21 |
kong | but we have to maintain so many mappings | 10:21 |
rakhmerov | yeah, I'm actually just thinking loudly | 10:21 |
kong | it's not scalable IMO | 10:21 |
rakhmerov | yes, that's a downside | 10:21 |
rakhmerov | I'm just making a point that it can be improved somehow | 10:22 |
rakhmerov | solved rather.. | 10:22 |
kong | for end user, I tend to agree with Zane's spec | 10:22 |
rakhmerov | I'll read it asap | 10:22 |
rakhmerov | just want to finish my current thing | 10:23 |
kong | but for operator, mistral way will make sense | 10:23 |
*** _gryf has joined #openstack-mistral | 10:23 | |
kong | yeah, sure | 10:23 |
rakhmerov | there's an enormous context in my head, don't wanna lose it.. | 10:23 |
kong | maybe after you reading, we can talk about it if necessary | 10:23 |
rakhmerov | sure, we'll do | 10:23 |
rakhmerov | to be honest, it's all not so clear to me too | 10:24 |
kong | take your time, man | 10:25 |
rakhmerov | ok | 10:26 |
*** Qiming has quit IRC | 10:30 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: WIP: engine refactoring https://review.openstack.org/317879 | 10:36 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: WIP: engine refactoring https://review.openstack.org/317879 | 10:46 |
*** dmowrer has joined #openstack-mistral | 10:52 | |
*** openstackgerrit has quit IRC | 11:18 | |
*** openstackgerrit has joined #openstack-mistral | 11:18 | |
*** Qiming has joined #openstack-mistral | 11:21 | |
*** bobh has joined #openstack-mistral | 11:46 | |
*** rbrady has joined #openstack-mistral | 12:03 | |
*** bobh has quit IRC | 12:19 | |
*** dprince has joined #openstack-mistral | 12:20 | |
openstackgerrit | Michal Gershenzon proposed openstack/python-mistralclient: Validate ad-hoc action via cli https://review.openstack.org/318152 | 12:21 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: WIP: engine refactoring https://review.openstack.org/317879 | 12:33 |
*** rbrady has quit IRC | 13:05 | |
*** ig0r__ has joined #openstack-mistral | 13:06 | |
*** ig0r_ has quit IRC | 13:08 | |
openstackgerrit | Xavier Hardy proposed openstack/mistral: Fix API inconsistencies with GET /v2/workflows https://review.openstack.org/321016 | 14:14 |
*** rena9067 has joined #openstack-mistral | 14:57 | |
*** Qiming has quit IRC | 15:09 | |
*** FL1SK has quit IRC | 15:29 | |
*** rbrady has joined #openstack-mistral | 15:40 | |
*** dmk0202 has quit IRC | 15:49 | |
*** tonytan4ever has joined #openstack-mistral | 16:00 | |
*** tonytan4ever has quit IRC | 16:03 | |
vgnbkr | I have a change to the Mistral Openstack TroveActions that I'd like to put upstream. In trying to get "tox -epep8" running I was missing pecan so I put that directly into the venv. Then, running "tox -epy27" I seem to be missing some yaql module. I'm wondering if I'm missing some dev setup step? | 16:12 |
vgnbkr | Is there something beyond a standard Openstack environment I should be doing to set up a dev environment? | 16:14 |
*** tonytan4ever has joined #openstack-mistral | 16:23 | |
*** gyee has joined #openstack-mistral | 16:23 | |
*** tonytan_brb has joined #openstack-mistral | 17:19 | |
*** tonytan4ever has quit IRC | 17:20 | |
openstackgerrit | Michal Gershenzon proposed openstack/mistral: Return 'Unknown error' when error output is empty https://review.openstack.org/321136 | 17:24 |
*** FL1SK has joined #openstack-mistral | 17:28 | |
*** tonytan_brb is now known as tonytan4ever | 17:28 | |
mgershen | vgnbkr: mistral uses yaql, you can go ahead and install it, if that is the only thing stopping you. If you are working on devstack on master branch you should already have everything is you install mistral like described here: https://github.com/openstack/mistral | 17:30 |
mgershen | vgnbkr: basically all that is needed for an installation is adding a line | 17:31 |
mgershen | vgnbkr: a better link: https://github.com/openstack/mistral/tree/master/devstack | 17:31 |
vgnbkr | mgershen, Yes, I have all that and have successfully made my change, but now I'm trying to get "tox -epy27" to run. Even though I have all of the apt packages listed installed, tox complains about a missing "yaql.language" module. | 17:35 |
vgnbkr | My change is almost trivial and passed pep8 - would it be a major faux-pas to just push it up and let the gate run the tests for me? | 17:39 |
*** dmowrer has quit IRC | 17:39 | |
*** dmowrer has joined #openstack-mistral | 17:40 | |
mgershen | vgnbkr: it's fine by me :) | 17:44 |
*** dmowrer has quit IRC | 17:44 | |
mgershen | vgnbkr: but since you didn't test your change please mark it as work in progress until the test pass | 17:45 |
mgershen | vgnbkr: it is actually recommended and consider good practice to push your code while you are still working on it (and mark it WIP). This gives the community a chance to be involved. | 17:48 |
*** ig0r__ has quit IRC | 17:51 | |
vgnbkr | I have tested my change in devstack, I just can't get py27 to run. I can pretty much guarantee that there is no test for the change I made since it didn't work before my change :-) | 18:01 |
openstackgerrit | Morgan Jones proposed openstack/mistral: WIP: Fix client in TroveActions https://review.openstack.org/321159 | 18:13 |
*** dmowrer has joined #openstack-mistral | 18:15 | |
*** FL1SK has quit IRC | 18:17 | |
*** vishwanathj has joined #openstack-mistral | 18:19 | |
rbrady | vgnbkr: passes pep8, py27 for me | 18:20 |
*** mgershen has quit IRC | 18:26 | |
*** mgershen has joined #openstack-mistral | 18:26 | |
*** mgershen is now known as Guest29129 | 18:27 | |
*** Guest29129 has quit IRC | 18:31 | |
vgnbkr | rbrady, thanks - looking forward to my first non-Trove commit. | 18:38 |
*** dmowrer has quit IRC | 18:59 | |
*** dmowrer has joined #openstack-mistral | 19:00 | |
openstackgerrit | Merged openstack/python-mistralclient: Validate ad-hoc action via cli https://review.openstack.org/318152 | 19:00 |
*** dmowrer_ has joined #openstack-mistral | 19:02 | |
*** dmowrer has quit IRC | 19:04 | |
*** dmowrer_ has quit IRC | 20:15 | |
*** FL1SK has joined #openstack-mistral | 20:27 | |
*** shardy has quit IRC | 20:35 | |
*** dmowrer has joined #openstack-mistral | 20:36 | |
*** dmowrer has quit IRC | 20:39 | |
*** dmowrer has joined #openstack-mistral | 20:40 | |
*** dprince has quit IRC | 20:54 | |
*** gyee has quit IRC | 21:07 | |
*** tonytan4ever has quit IRC | 21:21 | |
openstackgerrit | Morgan Jones proposed openstack/mistral: Fix client in TroveActions https://review.openstack.org/321159 | 21:25 |
*** FL1SK has quit IRC | 21:37 | |
*** dmowrer has quit IRC | 22:34 | |
*** gyee has joined #openstack-mistral | 22:55 | |
*** chlong has joined #openstack-mistral | 23:05 | |
*** harlowja has quit IRC | 23:12 | |
*** vishwana_ has joined #openstack-mistral | 23:21 | |
*** vishwanathj has quit IRC | 23:23 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!