| *** bobh has quit IRC | 00:02 | |
| openstackgerrit | Daryl Mowrer proposed openstack/python-mistralclient: Change the mistralclient for Mistral action pack https://review.openstack.org/284479 | 00:15 |
|---|---|---|
| *** toddjohn_ has joined #openstack-mistral | 00:19 | |
| *** bobh has joined #openstack-mistral | 00:28 | |
| *** toddjohn_ has quit IRC | 00:35 | |
| *** toddjohn_ has joined #openstack-mistral | 00:35 | |
| *** toddjohn_ has quit IRC | 00:38 | |
| *** toddjohn_ has joined #openstack-mistral | 00:38 | |
| *** enykeev has quit IRC | 00:44 | |
| *** enykeev has joined #openstack-mistral | 00:44 | |
| *** gyee has quit IRC | 01:04 | |
| *** toddjohn_ has quit IRC | 01:13 | |
| *** toddjohn_ has joined #openstack-mistral | 01:15 | |
| *** toddjohn_ has quit IRC | 01:19 | |
| openstackgerrit | Lingxian Kong proposed openstack/python-mistralclient: Functional tests for workflow sharing https://review.openstack.org/282649 | 01:23 |
| *** ninag has quit IRC | 01:38 | |
| openstackgerrit | Merged openstack/mistral: Use proper way to initialize nova client https://review.openstack.org/268639 | 02:08 |
| *** toddjohn_ has joined #openstack-mistral | 02:16 | |
| *** toddjohn_ has quit IRC | 02:22 | |
| *** bobh has quit IRC | 02:29 | |
| *** Ephur has quit IRC | 02:36 | |
| *** bobh has joined #openstack-mistral | 02:39 | |
| *** bobh has quit IRC | 02:43 | |
| lane_kong | rakhmerov: nmakhotkin are you here? | 02:47 |
| *** chlong_ has quit IRC | 03:47 | |
| *** chlong_ has joined #openstack-mistral | 03:49 | |
| *** mandre has quit IRC | 03:56 | |
| *** mandre has joined #openstack-mistral | 03:56 | |
| *** toddjohn_ has joined #openstack-mistral | 04:19 | |
| *** toddjohn_ has quit IRC | 04:23 | |
| *** achanda has quit IRC | 04:35 | |
| *** bobh has joined #openstack-mistral | 04:42 | |
| *** bobh has quit IRC | 04:47 | |
| *** achanda has joined #openstack-mistral | 04:55 | |
| *** bobh has joined #openstack-mistral | 05:43 | |
| *** bobh has quit IRC | 05:47 | |
| *** toddjohn_ has joined #openstack-mistral | 06:20 | |
| *** toddjohn_ has quit IRC | 06:25 | |
| *** bobh has joined #openstack-mistral | 06:44 | |
| *** achanda_ has joined #openstack-mistral | 06:45 | |
| *** achanda has quit IRC | 06:46 | |
| *** bobh has quit IRC | 06:48 | |
| *** tshtilma has joined #openstack-mistral | 06:56 | |
| *** [1]tshtilma has joined #openstack-mistral | 07:33 | |
| *** tshtilma has quit IRC | 07:33 | |
| *** [1]tshtilma is now known as tshtilma | 07:33 | |
| *** jtomasek has joined #openstack-mistral | 07:46 | |
| *** LimorStotland has joined #openstack-mistral | 07:54 | |
| *** toddjohn_ has joined #openstack-mistral | 08:00 | |
| *** bobh has joined #openstack-mistral | 08:02 | |
| *** toddjohn_ has quit IRC | 08:04 | |
| *** bobh has quit IRC | 08:07 | |
| *** LimorStotland has quit IRC | 08:10 | |
| *** LimorStotland has joined #openstack-mistral | 08:10 | |
| openstackgerrit | Merged openstack/python-mistralclient: Functional tests for workflow sharing https://review.openstack.org/282649 | 08:29 |
| nmakhotkin | lane_kong: Hi, I'm here | 08:34 |
| *** tshtilma has quit IRC | 08:43 | |
| *** achanda_ has quit IRC | 09:00 | |
| *** achanda has joined #openstack-mistral | 09:04 | |
| *** tshtilma has joined #openstack-mistral | 09:16 | |
| *** achanda has quit IRC | 09:19 | |
| *** achanda has joined #openstack-mistral | 09:24 | |
| rakhmerov | lane_kong: yes, here | 09:24 |
| rakhmerov | I agreee :) | 09:24 |
| rakhmerov | hparekh: hi, you there? | 09:25 |
| akuznetsova | I've prepared patch to openstack-infra https://review.openstack.org/#/c/284608/1 | 09:26 |
| *** achanda has quit IRC | 09:29 | |
| *** bobh has joined #openstack-mistral | 10:03 | |
| *** bobh has quit IRC | 10:08 | |
| *** achanda has joined #openstack-mistral | 10:29 | |
| *** achanda has quit IRC | 10:35 | |
| d0ugal | We are starting to create custom Mistral actions in TripleO. It would be great to get reviews from Mistral devs if they have time. https://review.openstack.org/#/c/282366/ | 11:00 |
| d0ugal | There isn't much code yet, but as this is the base for our work it would be good to get feedback before we get far. | 11:01 |
| *** bobh has joined #openstack-mistral | 11:15 | |
| *** bobh has quit IRC | 11:19 | |
| rakhmerov | d0ugal: Ok, sure | 12:09 |
| openstackgerrit | Daryl Mowrer proposed openstack/python-mistralclient: Change the mistralclient for Mistral action pack https://review.openstack.org/284479 | 12:23 |
| d0ugal | rakhmerov: Thanks! I am concerned about us doing imports like "from mistral.utils.openstack import keystone as keystone_utils" | 12:28 |
| d0ugal | Because I don't know if Mistral considers that a public API and I don't want you to break us later. | 12:28 |
| *** achanda has joined #openstack-mistral | 12:33 | |
| rakhmerov | d0ugal: your concern is valid, it's not a public API | 12:34 |
| rakhmerov | I'd better not do it | 12:35 |
| *** achanda has quit IRC | 12:40 | |
| d0ugal | rakhmerov: as I understand, we need to import mistral.actions - is that the only part we should consider public? | 12:47 |
| rakhmerov | if all you want is creating new actions then yes | 12:47 |
| d0ugal | Yup, specifically subclassing: mistra.actions.base.Action | 12:48 |
| rakhmerov | yep | 12:48 |
| rakhmerov | this is a public interface | 12:48 |
| rakhmerov | for that reason it has lot of docs in it | 12:48 |
| d0ugal | Okay, thanks - makes sense | 12:48 |
| rakhmerov | you're welcome | 12:49 |
| d0ugal | I wonder if it would be a good idea for Mistral to provide a library with the base action, then projects like ours could just depend on that and import that. It would make the public interface much clearer | 12:50 |
| d0ugal | ... but that sounds like quite a bit change. So just an idea :) | 12:50 |
| *** ninag has joined #openstack-mistral | 12:54 | |
| *** dprince has joined #openstack-mistral | 13:09 | |
| *** achanda has joined #openstack-mistral | 13:37 | |
| *** toddjohn_ has joined #openstack-mistral | 13:39 | |
| *** achanda has quit IRC | 13:41 | |
| *** bobh has joined #openstack-mistral | 13:57 | |
| *** toddjohn_ has quit IRC | 13:57 | |
| *** bobh has quit IRC | 14:12 | |
| *** toddjohn_ has joined #openstack-mistral | 14:39 | |
| *** BassT has joined #openstack-mistral | 15:36 | |
| *** xenogear has joined #openstack-mistral | 15:37 | |
| *** achanda has joined #openstack-mistral | 15:39 | |
| *** achanda has quit IRC | 15:45 | |
| *** rbrady has joined #openstack-mistral | 16:34 | |
| *** gyee has joined #openstack-mistral | 16:41 | |
| *** bobh has joined #openstack-mistral | 16:53 | |
| *** [1]tshtilma has joined #openstack-mistral | 17:08 | |
| *** tshtilma has quit IRC | 17:11 | |
| *** [1]tshtilma is now known as tshtilma | 17:11 | |
| *** tshtilma has quit IRC | 17:22 | |
| *** toddjohn_ has quit IRC | 17:23 | |
| *** vgnbkr_ has joined #openstack-mistral | 17:24 | |
| *** achanda has joined #openstack-mistral | 17:36 | |
| *** toddjohn_ has joined #openstack-mistral | 17:44 | |
| *** tshtilma has joined #openstack-mistral | 18:09 | |
| *** gyee has quit IRC | 18:11 | |
| *** Ephur has joined #openstack-mistral | 18:16 | |
| *** Ephur has quit IRC | 18:20 | |
| *** bobh has quit IRC | 18:25 | |
| *** gyee has joined #openstack-mistral | 18:33 | |
| *** gyee has quit IRC | 18:37 | |
| *** jtomasek has quit IRC | 18:49 | |
| *** dprince has quit IRC | 19:16 | |
| *** bobh has joined #openstack-mistral | 19:34 | |
| *** dprince has joined #openstack-mistral | 19:35 | |
| *** [1]tshtilma has joined #openstack-mistral | 19:40 | |
| *** tshtilma has quit IRC | 19:42 | |
| *** [1]tshtilma is now known as tshtilma | 19:42 | |
| *** xenogear has quit IRC | 19:48 | |
| *** krotscheck is now known as krotscheck_dcm | 19:50 | |
| *** bobh has quit IRC | 20:17 | |
| lane_kong | akuznetsova: thanks for the infra patch! | 20:17 |
| *** toddjohn_ has quit IRC | 20:20 | |
| *** toddjohn_ has joined #openstack-mistral | 20:21 | |
| *** toddjohn_ has quit IRC | 20:25 | |
| *** Ephur has joined #openstack-mistral | 20:47 | |
| *** toddjohn_ has joined #openstack-mistral | 20:56 | |
| *** toddjohn_ has quit IRC | 20:56 | |
| *** toddjohn_ has joined #openstack-mistral | 20:56 | |
| *** gyee has joined #openstack-mistral | 21:00 | |
| *** toddjohn_ has quit IRC | 21:04 | |
| *** toddjohn_ has joined #openstack-mistral | 21:05 | |
| *** toddjohn_ has quit IRC | 21:09 | |
| *** dprince has quit IRC | 21:19 | |
| *** achanda has quit IRC | 21:23 | |
| *** achanda has joined #openstack-mistral | 21:31 | |
| *** achanda has quit IRC | 21:33 | |
| *** achanda has joined #openstack-mistral | 21:37 | |
| *** BassT has quit IRC | 21:49 | |
| *** achanda has quit IRC | 22:09 | |
| *** tshtilma has quit IRC | 22:11 | |
| *** vgnbkr_ has quit IRC | 22:17 | |
| *** vgnbkr__ has joined #openstack-mistral | 22:17 | |
| *** vgnbkr__ has quit IRC | 22:22 | |
| dmowrer_ | lane_kong: Hi. Are you there? | 22:54 |
| lane_kong | dmowrer_: pong | 22:55 |
| dmowrer_ | I saw your comment in https://review.openstack.org/#/c/284479/2 | 22:55 |
| dmowrer_ | the imports appear to be in alphabetical order | 22:55 |
| dmowrer_ | were you referring to the blank line after the first import? | 22:55 |
| lane_kong | dmowrer_: | 22:56 |
| lane_kong | Imports should be grouped in the following order: | 22:56 |
| lane_kong | standard library imports | 22:56 |
| lane_kong | related third party imports | 22:56 |
| lane_kong | local application/library specific imports | 22:56 |
| lane_kong | You should put a blank line between each group of imports. | 22:56 |
| lane_kong | e.g. six belongs to related third party imports | 22:57 |
| lane_kong | collections belongs to standard library imports | 22:58 |
| lane_kong | please check your other files also | 22:58 |
| dmowrer_ | is this better? http://paste.openstack.org/show/488289/ | 22:59 |
| lane_kong | dmowrer_: yeah, that's exactly what i mean | 23:00 |
| dmowrer_ | OK. sweet. thanks! | 23:00 |
| dmowrer_ | I will make the change | 23:00 |
| lane_kong | dmowrer_ :-) | 23:00 |
| lane_kong | dmowrer_: i am not sure if pkg_resources is standard python library | 23:01 |
| lane_kong | dmowrer_: maybe it's not | 23:01 |
| lane_kong | i can not fine it in https://docs.python.org/3/library/ | 23:02 |
| lane_kong | sorry, i need to go lunch, please feel free to leave message | 23:02 |
| *** achanda has joined #openstack-mistral | 23:04 | |
| dmowrer_ | pkg_resources appears to be 3rd-party | 23:06 |
| openstackgerrit | Daryl Mowrer proposed openstack/python-mistralclient: Change the mistralclient for Mistral action pack https://review.openstack.org/284479 | 23:19 |
| dmowrer_ | lane_kong: Thanks for the review comments. It's the end of my work day here. I have submitted the patch set with the changes you wanted. I will add functional tests in a different patch set (hopefully tomorrow). | 23:24 |
| hparekh | rakhmerov: Hi. | 23:36 |
| *** achanda has quit IRC | 23:38 | |
| *** achanda has joined #openstack-mistral | 23:49 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!