*** bobh has joined #openstack-mistral | 00:05 | |
*** achanda has quit IRC | 00:12 | |
*** bobh has quit IRC | 00:43 | |
*** bobh has joined #openstack-mistral | 01:05 | |
*** bobh has quit IRC | 01:08 | |
*** achanda has joined #openstack-mistral | 01:13 | |
*** ruhe has quit IRC | 01:38 | |
*** enykeev_ has quit IRC | 01:40 | |
*** enykeev has joined #openstack-mistral | 01:42 | |
*** ruhe has joined #openstack-mistral | 01:42 | |
*** bobh has joined #openstack-mistral | 02:01 | |
*** bobh has quit IRC | 02:09 | |
*** bobh has joined #openstack-mistral | 02:33 | |
*** bobh has quit IRC | 02:33 | |
*** Ephur has quit IRC | 03:06 | |
*** sergmelikyan has joined #openstack-mistral | 03:26 | |
*** achanda has quit IRC | 03:32 | |
*** achanda has joined #openstack-mistral | 03:33 | |
*** hparekh has joined #openstack-mistral | 03:40 | |
*** achanda has quit IRC | 03:41 | |
*** bobh has joined #openstack-mistral | 03:42 | |
*** bobh has quit IRC | 03:44 | |
*** bobh has joined #openstack-mistral | 03:48 | |
*** bobh has quit IRC | 03:52 | |
*** bobh has joined #openstack-mistral | 03:54 | |
*** bobh has quit IRC | 04:00 | |
*** hparekh has quit IRC | 04:18 | |
*** hparekh has joined #openstack-mistral | 04:25 | |
*** sergmelikyan has quit IRC | 04:31 | |
*** sergmelikyan has joined #openstack-mistral | 04:52 | |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Remove usage of expandtabs() in get_workflow_definition https://review.openstack.org/228303 | 05:10 |
---|---|---|
*** sergmelikyan has quit IRC | 05:11 | |
*** achanda has joined #openstack-mistral | 05:12 | |
*** hparekh2 has joined #openstack-mistral | 05:29 | |
*** hparekh has quit IRC | 05:30 | |
openstackgerrit | hardik proposed openstack/python-mistralclient: Output format is corrected for wf-validate and wb-validate https://review.openstack.org/228305 | 05:30 |
*** hparekh has joined #openstack-mistral | 05:35 | |
*** hparekh2 has quit IRC | 05:36 | |
*** achanda has quit IRC | 06:56 | |
*** achanda has joined #openstack-mistral | 06:59 | |
*** achanda has quit IRC | 07:02 | |
*** chlong has quit IRC | 07:17 | |
openstackgerrit | hardik proposed openstack/python-mistralclient: Corrected output when env description is not provided. https://review.openstack.org/228342 | 08:04 |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Remove usage of expandtabs() in get_workflow_definition https://review.openstack.org/228303 | 08:08 |
*** sergmelikyan has joined #openstack-mistral | 08:22 | |
*** sergmelikyan has quit IRC | 08:29 | |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Renaming state DELAYED to RUNNING_DELAYED in doc https://review.openstack.org/228354 | 08:29 |
nmakhotkin | xyaln_kong, hi! | 08:33 |
nmakhotkin | are you here? | 08:33 |
xylan_kong | nmakhotkin: yep | 08:33 |
nmakhotkin | I've left a comment in https://review.openstack.org/228303 | 08:33 |
nmakhotkin | xyaln_kong: there is one question | 08:34 |
nmakhotkin | xylan_kong: | 08:34 |
xylan_kong | nmakhotkin: hmm, I thought about this, things will be complex if we make the definition shift automatically, because comments may don't align with the indentation rules. | 08:37 |
nmakhotkin | xylan_kong, yep, comments should be moved to the left edge then | 08:38 |
xylan_kong | nmakhotkin: let me think it again | 08:39 |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Remove usage of expandtabs() in get_workflow_definition https://review.openstack.org/228303 | 08:54 |
xylan_kong | nmakhotkin: please see it again | 08:55 |
xylan_kong | nmakhotkin: I made some modification | 08:55 |
nmakhotkin | ok, thanks xylan_kong | 08:56 |
xylan_kong | it looks more perfect i think :-) | 08:57 |
akuznetsova | xylan_kong, hi | 08:58 |
xylan_kong | akuznetsova: hi | 08:58 |
akuznetsova | I have a suggestion about this patch https://review.openstack.org/#/c/228303/3 | 08:58 |
akuznetsova | could you fix one more thing here & | 08:58 |
xylan_kong | akuznetsova: what's that? | 08:58 |
akuznetsova | i am talking about python3 compatibility | 08:59 |
akuznetsova | such import "import StringIO" doesn't work in python3 | 09:00 |
xylan_kong | akuznetsova: yes, you're right! | 09:01 |
xylan_kong | akuznetsova: fix it now | 09:01 |
akuznetsova | xylan_kong, thanks! | 09:03 |
*** achanda has joined #openstack-mistral | 09:10 | |
*** sergmelikyan has joined #openstack-mistral | 09:12 | |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Remove usage of expandtabs() in get_workflow_definition https://review.openstack.org/228303 | 09:13 |
*** zhenguo has quit IRC | 09:26 | |
*** sergmelikyan has quit IRC | 09:38 | |
*** sergmelikyan has joined #openstack-mistral | 09:49 | |
*** achanda has quit IRC | 09:55 | |
openstackgerrit | hardik proposed openstack/mistral: Fix order of arguments in assertEqual https://review.openstack.org/228388 | 10:41 |
*** chlong has joined #openstack-mistral | 11:43 | |
*** bobh has joined #openstack-mistral | 11:54 | |
*** bobh_ has joined #openstack-mistral | 11:58 | |
*** bobh has quit IRC | 11:59 | |
*** bobh_ has quit IRC | 12:47 | |
*** bobh has joined #openstack-mistral | 12:51 | |
*** sergmelikyan has quit IRC | 12:53 | |
*** bobh_ has joined #openstack-mistral | 12:59 | |
*** bobh has quit IRC | 13:00 | |
openstackgerrit | hardik proposed openstack/python-mistralclient: Output format is corrected for wf-validate and wb-validate https://review.openstack.org/228305 | 13:21 |
*** sergmelikyan has joined #openstack-mistral | 13:30 | |
*** Piet has quit IRC | 13:40 | |
*** Ephur has joined #openstack-mistral | 13:47 | |
*** achanda has joined #openstack-mistral | 13:49 | |
*** achanda has quit IRC | 13:51 | |
openstackgerrit | hardik proposed openstack/python-mistralclient: Output format is corrected for wf-validate and wb-validate https://review.openstack.org/228305 | 13:56 |
openstackgerrit | hardik proposed openstack/python-mistralclient: Output format is corrected for wf-validate and wb-validate https://review.openstack.org/228305 | 14:01 |
*** sergmelikyan has quit IRC | 14:11 | |
*** achanda has joined #openstack-mistral | 14:22 | |
*** sergmelikyan has joined #openstack-mistral | 14:23 | |
*** tonytan4ever has joined #openstack-mistral | 14:37 | |
*** achanda has quit IRC | 14:40 | |
openstackgerrit | hardik proposed openstack/python-mistralclient: Corrected output when env description is not provided. https://review.openstack.org/228342 | 15:01 |
*** bobh_ has quit IRC | 15:02 | |
*** sergmelikyan has quit IRC | 15:05 | |
*** tonytan4ever has quit IRC | 15:17 | |
*** sergmelikyan has joined #openstack-mistral | 15:23 | |
*** sergmelikyan has quit IRC | 16:25 | |
*** gyee has joined #openstack-mistral | 16:28 | |
*** tonytan4ever has joined #openstack-mistral | 16:32 | |
*** hparekh has quit IRC | 16:39 | |
*** achanda has joined #openstack-mistral | 16:40 | |
*** sergmelikyan has joined #openstack-mistral | 16:42 | |
*** achanda has quit IRC | 16:54 | |
*** gyee has quit IRC | 17:03 | |
*** gyee has joined #openstack-mistral | 17:19 | |
*** Piet has joined #openstack-mistral | 17:28 | |
*** hparekh has joined #openstack-mistral | 17:31 | |
*** sergmelikyan has quit IRC | 17:46 | |
*** achanda has joined #openstack-mistral | 17:54 | |
*** sergmelikyan has joined #openstack-mistral | 17:58 | |
*** achanda has quit IRC | 17:59 | |
*** hparekh has quit IRC | 18:03 | |
*** sergmelikyan has quit IRC | 18:04 | |
*** sergmelikyan has joined #openstack-mistral | 18:10 | |
*** bobh has joined #openstack-mistral | 18:11 | |
*** tonytan4ever has quit IRC | 18:14 | |
*** tonytan4ever has joined #openstack-mistral | 18:14 | |
*** hparekh has joined #openstack-mistral | 18:38 | |
*** achanda has joined #openstack-mistral | 18:56 | |
*** achanda has quit IRC | 19:00 | |
*** Piet has quit IRC | 19:03 | |
*** hparekh has quit IRC | 19:11 | |
*** sergmelikyan has quit IRC | 19:12 | |
*** achanda has joined #openstack-mistral | 19:56 | |
*** achanda has quit IRC | 20:01 | |
*** tonytan4ever has quit IRC | 20:01 | |
*** achanda has joined #openstack-mistral | 20:39 | |
*** hparekh has joined #openstack-mistral | 20:43 | |
*** tonytan4ever has joined #openstack-mistral | 20:52 | |
*** Piet has joined #openstack-mistral | 20:56 | |
*** bobh has quit IRC | 21:10 | |
*** hparekh has quit IRC | 21:26 | |
*** hparekh has joined #openstack-mistral | 21:41 | |
*** Piet has quit IRC | 22:25 | |
*** hparekh has quit IRC | 22:25 | |
*** tonytan4ever has quit IRC | 22:31 | |
*** Piet_ has joined #openstack-mistral | 23:14 | |
*** gyee has quit IRC | 23:14 | |
*** achanda has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!