| *** zhenguo has joined #openstack-mistral | 01:35 | |
| openstackgerrit | Lingxian Kong proposed openstack/python-mistralclient: Remove invalid test case of mistralclient https://review.openstack.org/221138 | 02:08 |
|---|---|---|
| *** LiatFried has joined #openstack-mistral | 03:31 | |
| xylan_kong | rakhmerov, nmakhotkin please review https://review.openstack.org/#/c/221138/, which will fix the devstack failure. | 03:36 |
| xylan_kong | rakhmerov: I have left a comment in your patch https://review.openstack.org/220439, wait for your thoughts :-) | 03:37 |
| openstackgerrit | Zhenguo Niu proposed openstack/mistral: Switch to devstack plugin https://review.openstack.org/216729 | 04:27 |
| openstackgerrit | Zhenguo Niu proposed openstack/mistral: Switch to devstack plugin https://review.openstack.org/216729 | 04:52 |
| *** histrio has joined #openstack-mistral | 04:56 | |
| histrio | Hi everyone! | 04:56 |
| histrio | I'm looking for blueprint about executions table purge/rotation/cleaning. I know it's exists (I saw it) but can't remember where :( | 04:59 |
| xylan_kong | histrio: you must be lookint for this: https://blueprints.launchpad.net/mistral/+spec/expiration-policies-for-executions | 05:16 |
| openstackgerrit | Lingxian Kong proposed openstack/mistral: The Link for plugin samples is added https://review.openstack.org/218596 | 05:21 |
| histrio | xylan_kong: yes! Thanks! | 05:34 |
| openstackgerrit | Zhenguo Niu proposed openstack/mistral: Switch to devstack plugin https://review.openstack.org/216729 | 05:56 |
| openstackgerrit | Merged openstack/python-mistralclient: Remove invalid test case of mistralclient https://review.openstack.org/221138 | 07:03 |
| rakhmerov | xylan_kong: yep, I agree with your comment | 07:06 |
| rakhmerov | I have left it actually to think about it a little bit later and forgot to | 07:06 |
| rakhmerov | so that's fine, let me think how I need to name those methods better | 07:06 |
| xylan_kong | rakhmerov: ok | 07:07 |
| rakhmerov | validate_schema looks good to me, it reflects its meaning | 07:07 |
| *** histrio has quit IRC | 07:20 | |
| *** histrio has joined #openstack-mistral | 07:21 | |
| *** histrio has quit IRC | 07:26 | |
| *** histrio has joined #openstack-mistral | 07:28 | |
| *** achanda has joined #openstack-mistral | 07:43 | |
| akuznetsova | hi there | 07:44 |
| xylan_kong | akuznetsova: hi | 07:53 |
| openstackgerrit | Zhenguo Niu proposed openstack/mistral: Switch to devstack plugin https://review.openstack.org/216729 | 07:53 |
| *** histrio_ has joined #openstack-mistral | 07:55 | |
| *** chlong has quit IRC | 07:56 | |
| *** histrio has quit IRC | 07:58 | |
| *** histrio_ has quit IRC | 08:12 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mistral: Switch to devstack plugin https://review.openstack.org/216729 | 08:20 |
| *** ^Gal^ has joined #openstack-mistral | 08:21 | |
| *** achanda has quit IRC | 08:25 | |
| openstackgerrit | Merged openstack/mistral: The Link for plugin samples is added https://review.openstack.org/218596 | 08:25 |
| *** achanda has joined #openstack-mistral | 08:28 | |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Mistral docs terminology: executions https://review.openstack.org/219651 | 08:35 |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Mistral terminology: cron-triggers and actions https://review.openstack.org/219677 | 08:35 |
| xylan_kong | nmakhotkin: ping | 08:40 |
| nmakhotkin | hi, xylan_kong | 08:41 |
| xylan_kong | nmakhotkin: for https://review.openstack.org/#/c/219677/4..5/doc/source/terminology/actions.rst,cm, from mistral-executor's perspective, mistral will always wait for the result, whether or not the action is synchronous, right? | 08:42 |
| xylan_kong | I'm a little confused about the description there | 08:43 |
| nmakhotkin | I updated the description | 08:43 |
| nmakhotkin | yes, Mistral is always wait for the result | 08:44 |
| xylan_kong | In case of asynchronous action Mistral will send a signal to third party service and will be waiting for a corresponding action result to be delivered back to Mistral. | 08:44 |
| nmakhotkin | the difference here is where the signal is sended | 08:44 |
| xylan_kong | nmakhotkin: this is your updated version? | 08:44 |
| nmakhotkin | yes, signal should send to third party service | 08:45 |
| xylan_kong | hmm...looks wired. I think we could emphasize 'Users can retrieve action result during the workflow execution for synchronous actions' | 08:48 |
| xylan_kong | if I change your sentence to 'In case of synchronous action...', the logic is also right. | 08:49 |
| xylan_kong | missing something? | 08:50 |
| nmakhotkin | no, in that case the logic is broken here: Mistral sends a signal only to executor in case of synchronous action. | 08:50 |
| nmakhotkin | btw, what does it mean? - 'Users can retrieve action result during the workflow execution' | 08:51 |
| rakhmerov | btw, let me squeeze into your conversation | 08:51 |
| nmakhotkin | Users can retrieve action result for any action | 08:51 |
| *** achanda has quit IRC | 08:52 | |
| rakhmerov | in fact, Mistral doesn't actively wait for action result if it's asynchronous | 08:52 |
| rakhmerov | actively | 08:52 |
| nmakhotkin | I'll update the description and add also for synchronous actions to let see the difference | 08:52 |
| rakhmerov | the result then just comes through API once it's ready | 08:52 |
| rakhmerov | in case of synchronous, executor sends the result immediately after action completion | 08:53 |
| rakhmerov | for asynchronous, it doesn't, it just calls actions and that's it | 08:53 |
| nmakhotkin | one more thing, Mistral never actively waits for the result :) | 08:54 |
| nmakhotkin | just if it comes, Mistral will receive it | 08:54 |
| xylan_kong | I don't know how to express myself more precisely…… | 08:55 |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Mistral terminology: cron-triggers and actions https://review.openstack.org/219677 | 08:55 |
| nmakhotkin | I updated the patch | 08:55 |
| rakhmerov | yes | 08:55 |
| rakhmerov | xylan_kong: so what is your particular question? :) | 08:55 |
| rakhmerov | let's find an answer right now ) | 08:55 |
| xylan_kong | in my understanding, synchronous or asynchronous is just action flag, if an action is marked as 'synchronous', then mistral-executor send the signal, get the result and send it to mistral-engine back | 08:57 |
| xylan_kong | if action is marked as 'asynchronous', then mistral-executor sends the signal, then it's finished for the action | 08:58 |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Mistral documentation: CLI operations https://review.openstack.org/220517 | 08:59 |
| *** ^Gal^ has quit IRC | 08:59 | |
| nmakhotkin | in fact, after executor sends the signal, action is not finished | 09:00 |
| nmakhotkin | third party service should send request to Mistral API with information about corresponding action and its result | 09:01 |
| xylan_kong | yes, but for mistral, it's 'finished', mistral doesn't care about its result | 09:01 |
| xylan_kong | ooh, i get your point | 09:02 |
| xylan_kong | but how third party service will do is not in scope of mistral | 09:03 |
| xylan_kong | we could recommend that | 09:03 |
| nmakhotkin | yes, correct | 09:04 |
| nmakhotkin | I'll add more info | 09:04 |
| xylan_kong | so, that's what I mean. Let the user or developer get more detailed info about mistral mechanism | 09:05 |
| xylan_kong | thanks nmakhotkin | 09:05 |
| *** ^Gal^ has joined #openstack-mistral | 09:21 | |
| ^Gal^ | Yo hommies | 09:25 |
| ^Gal^ | I'm refactoring our dashboard debug instructions - and have some pretty screenshots. what should I do with the pictures? throw em in the repo or upload somewhere? | 09:25 |
| akuznetsova | ^Gal^, we have such folder https://github.com/openstack/mistral/tree/master/doc/source/img, maybe we can store all needed images here | 09:51 |
| ^Gal^ | akuznetsova: sounds good to me :) | 09:52 |
| ^Gal^ | akuznetsova: thanks! | 09:52 |
| akuznetsova | ^Gal^, it will allow us to use them in end user dashboard guide | 09:53 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Raising exception if there aren't start tasks in direct workflow https://review.openstack.org/220439 | 10:03 |
| rakhmerov | xylan_kong, nmakhotkin: Ideally we need to draw a good diagram to explain sync/async | 10:05 |
| rakhmerov | it would be very helpful | 10:05 |
| rakhmerov | xylan_kong, nmakhotkin: please see another version of my patch https://review.openstack.org/220439 | 10:06 |
| rakhmerov | I refactored validation a little bit per Lingxian's request | 10:07 |
| openstackgerrit | Merged openstack/mistral: Mistral docs terminology: executions https://review.openstack.org/219651 | 10:13 |
| nmakhotkin | rakhmerov, yes, agree | 10:13 |
| nmakhotkin | I try to draw this diagram | 10:13 |
| rakhmerov | ok | 10:27 |
| rakhmerov | zhenguo: can you please investigate what's wrong with https://review.openstack.org/#/c/220673/ ? | 10:27 |
| zhenguo | rakhmerov: sure, will check that :) | 10:28 |
| rakhmerov | ok, thanks | 10:28 |
| zhenguo | rakhmerov: I update the requirement in my local env, not see the errors, | 10:58 |
| rakhmerov | hm.. | 10:58 |
| zhenguo | rakhmerov: seems django_openstack_auth doesn't affect that | 10:58 |
| rakhmerov | so what's your suggestion? What do we do next? | 10:59 |
| zhenguo | rakhmerov: will investigate more to see the reason | 10:59 |
| rakhmerov | ok | 11:01 |
| openstackgerrit | Zhenguo Niu proposed openstack/mistral-dashboard: Updated from global requirements https://review.openstack.org/220673 | 11:09 |
| gpaz | Hi guys, how are you ? there is a CLI command for WFs : workflow-get-definition that return the WF.. I m seeing that it is working when I m loading workflow via ‘workflow-create’ but when I m loading it from ‘workbook-create’ (the WB contain few WFs) the ‘workflow-get-definition’ returned empty. Is it by design ? am I missing here something ? | 11:14 |
| gpaz | (working with latest mistral code) | 11:15 |
| rakhmerov | gpaz: yes, currently this is how it's made | 11:24 |
| rakhmerov | it's sort of a bug if you will | 11:24 |
| rakhmerov | the problem is that it's not so easy to solve it IMO | 11:25 |
| gpaz | I thought that wfs are independent after wb create done | 11:25 |
| rakhmerov | yes | 11:26 |
| rakhmerov | they are | 11:26 |
| rakhmerov | but it's not easy to get their initial YAML definitions | 11:26 |
| gpaz | for example when I m deleting the WB it doesnt delete the WFs that under it | 11:26 |
| rakhmerov | right | 11:26 |
| rakhmerov | let me explain | 11:26 |
| rakhmerov | imagine you have a single YAML document where you have multiple workflows and actions | 11:27 |
| gpaz | ok | 11:27 |
| rakhmerov | it's easy to just upload this doc into Mistral and preserve it in the exact same form (as a text actually) | 11:27 |
| rakhmerov | but in order to get a definition for an individual wf we'd have to cut it out from the YAML document | 11:28 |
| rakhmerov | somehow | 11:28 |
| gpaz | oh .. ok | 11:28 |
| rakhmerov | and keep in mind that YAML is equivalent to dictionary | 11:28 |
| rakhmerov | it's a text | 11:28 |
| rakhmerov | because it may have comments, special YAML instructions etc. | 11:28 |
| gpaz | yes you are right .. but still .. | 11:29 |
| rakhmerov | I'm not saying it's impossible to do but we have to write some special pretty smart text parser that would be able to do this | 11:29 |
| rakhmerov | and nobody has gotten so far to working on it | 11:30 |
| gpaz | Its understood .. I think we need a bug so will have it in realse note or something .. minor snd some day may be will fix .. what do you say ? | 11:30 |
| gpaz | If its ok with you ? | 11:31 |
| rakhmerov | yes, we definitely need a bug and I thought we had it | 11:31 |
| gpaz | my approach is to file any issue that we are seeing | 11:31 |
| rakhmerov | please try to search a list of bugs and BPs, we might already have it | 11:31 |
| gpaz | ah ok .. if we have so we are good | 11:31 |
| gpaz | Ok. thanks I will | 11:31 |
| rakhmerov | gpaz: 100% agree with you and support you, it's better to file 10 bugs on the same problem than none | 11:31 |
| gpaz | rakhmerov, Thanks | 11:35 |
| xylan_kong | rakhmerov: hi, https://review.openstack.org/#/c/220439/ looks good to me now | 11:38 |
| xylan_kong | thanks for taking consideration of my suggestion | 11:39 |
| rakhmerov | xylan_kong: yeah, I like it too ) | 11:41 |
| rakhmerov | btw, there's a bunch of places where we could improve specs | 11:41 |
| xylan_kong | rakhmerov: yes, we can improve it during RC1, can we? | 11:42 |
| rakhmerov | yes | 11:42 |
| zhenguo | rakhmerov: now all mistral-dashboard have py27 gate failed. | 11:43 |
| rakhmerov | why? | 11:43 |
| zhenguo | rakhmerov: seems we get some global requirement updated to high. | 11:44 |
| rakhmerov | what do you mean by "high" and where it is updated? | 11:45 |
| zhenguo | I mean we merged a patch from global requiremnt | 11:46 |
| zhenguo | but not fixed the issue for that in our codes first | 11:46 |
| rakhmerov | ooh, I see | 11:46 |
| rakhmerov | then we have to fix it | 11:46 |
| zhenguo | yeah, | 11:46 |
| zhenguo | will find the codes and adress that | 11:47 |
| rakhmerov | ok | 11:48 |
| openstackgerrit | Merged openstack/mistral: Raising exception if there aren't start tasks in direct workflow https://review.openstack.org/220439 | 11:54 |
| xylan_kong | rakhmerov: https://bugs.launchpad.net/mistral/+bug/1484804 is lost in https://launchpad.net/mistral/+milestone/liberty-3, please set 'milestone' for it | 12:00 |
| openstack | Launchpad bug 1484804 in Mistral "Unexpected error when get services after zookeeper connection shutdown" [Undecided,Fix committed] - Assigned to Lingxian Kong (kong) | 12:00 |
| rakhmerov | done | 12:01 |
| xylan_kong | thanks | 12:01 |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Mistral terminology: cron-triggers and actions https://review.openstack.org/219677 | 12:17 |
| openstackgerrit | Zhenguo Niu proposed openstack/mistral-dashboard: Remove the test cases for handle_errors to fix the py27 gate issue https://review.openstack.org/221275 | 12:22 |
| *** chlong has joined #openstack-mistral | 12:22 | |
| zhenguo | rakhmerov: just send a patch to disable handle_errors test cases as a workaround to fix all py27 gate failed | 12:25 |
| rakhmerov | ok | 12:27 |
| openstackgerrit | Zhenguo Niu proposed openstack/mistral-dashboard: Remove the test cases for handle_errors to fix the py27 gate issue https://review.openstack.org/221275 | 12:28 |
| zhenguo | rakhmerov: as we changed the exception handle method which use the request context, so the test cases for missing request args is failed. | 12:29 |
| rakhmerov | I see | 12:29 |
| akuznetsova | guys, I have an offtop question | 12:39 |
| akuznetsova | what do you think about style of writing guides ? Should it be formal (like "create name, make this")or it is appropriate to make it more friendly ? | 12:44 |
| *** LiatFried has quit IRC | 12:49 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add YAQL function 'task' to extract info about task in DSL https://review.openstack.org/221289 | 12:55 |
| openstackgerrit | Merged openstack/mistral-dashboard: Remove the test cases for handle_errors to fix the py27 gate issue https://review.openstack.org/221275 | 13:03 |
| *** Piet has quit IRC | 13:07 | |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral-dashboard: Updated from global requirements https://review.openstack.org/220673 | 13:09 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral: Add YAQL function 'task' to extract info about task in DSL https://review.openstack.org/221289 | 13:11 |
| rakhmerov | zhenguo: is https://review.openstack.org/#/c/216729/ ok now? | 13:13 |
| zhenguo | rakhmerov: I think it is, | 13:14 |
| zhenguo | rakhmerov: and this https://review.openstack.org/#/c/220673/ can be merged now | 13:18 |
| akuznetsova | xylan_kong, I have a suggestion related to this change https://review.openstack.org/#/c/221138/ | 13:19 |
| openstackgerrit | Merged openstack/mistral-dashboard: Updated from global requirements https://review.openstack.org/220673 | 13:23 |
| akuznetsova | xylan_kong, since such scenario became valid (changing the status from 'running' - > 'error') | 13:27 |
| akuznetsova | we can add test on it (you deleted one) by re-writing deleted one | 13:28 |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Mistral docs: writing workflow https://review.openstack.org/221028 | 13:32 |
| rakhmerov | xylan_kong: are you here? | 13:37 |
| rakhmerov | still available? | 13:37 |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Mistral terminology: cron-triggers and actions https://review.openstack.org/219677 | 13:51 |
| *** bobh has joined #openstack-mistral | 14:06 | |
| openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Mistral docs: Upgrade database guide https://review.openstack.org/221311 | 14:07 |
| *** Piet has joined #openstack-mistral | 15:10 | |
| *** bradjones has joined #openstack-mistral | 15:28 | |
| *** bradjones has quit IRC | 15:28 | |
| *** bradjones has joined #openstack-mistral | 15:28 | |
| *** sergmelikyan has joined #openstack-mistral | 15:59 | |
| *** gyee has joined #openstack-mistral | 16:03 | |
| *** zhenguo has quit IRC | 16:08 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral: Updated from global requirements https://review.openstack.org/221112 | 16:27 |
| *** achanda has joined #openstack-mistral | 16:32 | |
| *** achanda has quit IRC | 16:56 | |
| *** achanda_ has joined #openstack-mistral | 16:56 | |
| *** harlowja has joined #openstack-mistral | 17:03 | |
| *** achanda_ has quit IRC | 17:08 | |
| *** achanda has joined #openstack-mistral | 17:21 | |
| *** openstackgerrit has quit IRC | 18:31 | |
| *** openstackgerrit has joined #openstack-mistral | 18:32 | |
| *** achanda has quit IRC | 18:40 | |
| *** achanda has joined #openstack-mistral | 18:41 | |
| *** sergmelikyan has quit IRC | 18:56 | |
| *** achanda has quit IRC | 18:57 | |
| *** sergmelikyan has joined #openstack-mistral | 18:57 | |
| *** sergmelikyan has quit IRC | 18:58 | |
| *** sergmelikyan has joined #openstack-mistral | 18:59 | |
| *** achanda has joined #openstack-mistral | 19:38 | |
| *** achanda has quit IRC | 19:45 | |
| *** bobh has quit IRC | 20:31 | |
| *** tiny-hands has joined #openstack-mistral | 20:35 | |
| *** sergmelikyan has quit IRC | 20:36 | |
| *** achanda has joined #openstack-mistral | 20:41 | |
| *** achanda has quit IRC | 20:51 | |
| *** achanda has joined #openstack-mistral | 20:54 | |
| *** sergmelikyan has joined #openstack-mistral | 20:55 | |
| *** sergmelikyan has quit IRC | 21:01 | |
| *** sergmelikyan has joined #openstack-mistral | 21:02 | |
| *** sergmelikyan has quit IRC | 21:06 | |
| *** sergmelikyan has joined #openstack-mistral | 21:06 | |
| *** sergmelikyan has quit IRC | 21:10 | |
| *** sergmelikyan has joined #openstack-mistral | 21:13 | |
| *** sergmelikyan has quit IRC | 21:14 | |
| *** tiny-hands has quit IRC | 21:31 | |
| *** achanda has quit IRC | 21:35 | |
| *** achanda has joined #openstack-mistral | 21:35 | |
| *** achanda_ has joined #openstack-mistral | 21:44 | |
| *** achanda has quit IRC | 21:44 | |
| *** sergmelikyan has joined #openstack-mistral | 21:45 | |
| *** sergmelikyan has quit IRC | 21:46 | |
| *** achanda_ has quit IRC | 21:58 | |
| *** Ephur has joined #openstack-mistral | 22:01 | |
| *** achanda has joined #openstack-mistral | 22:02 | |
| *** achanda has quit IRC | 22:09 | |
| *** achanda has joined #openstack-mistral | 22:09 | |
| *** Piet has quit IRC | 22:11 | |
| *** achanda_ has joined #openstack-mistral | 22:13 | |
| *** achanda has quit IRC | 22:13 | |
| *** sergmelikyan has joined #openstack-mistral | 22:19 | |
| *** sergmelikyan has quit IRC | 22:26 | |
| *** achanda has joined #openstack-mistral | 22:55 | |
| *** achanda_ has quit IRC | 22:55 | |
| *** Piet has joined #openstack-mistral | 23:00 | |
| *** achanda_ has joined #openstack-mistral | 23:01 | |
| *** achanda has quit IRC | 23:01 | |
| *** sergmelikyan has joined #openstack-mistral | 23:15 | |
| *** sergmelikyan has quit IRC | 23:20 | |
| *** achanda has joined #openstack-mistral | 23:23 | |
| *** achanda_ has quit IRC | 23:23 | |
| *** chlong has quit IRC | 23:27 | |
| *** chlong has joined #openstack-mistral | 23:28 | |
| *** sergmelikyan has joined #openstack-mistral | 23:37 | |
| *** sergmelikyan has quit IRC | 23:37 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!