Wednesday, 2015-08-26

*** achanda has quit IRC00:01
*** sergmelikyan has quit IRC00:06
*** openstack has joined #openstack-mistral00:34
*** sergmelikyan has joined #openstack-mistral00:38
*** sergmelikyan has quit IRC00:43
*** sergmelikyan has joined #openstack-mistral01:00
*** sergmelikyan has quit IRC01:03
*** ^Gal^ has quit IRC01:07
*** sergmelikyan has joined #openstack-mistral01:08
*** ^Gal^ has joined #openstack-mistral01:10
*** sergmelikyan has quit IRC01:10
*** zhenguo has joined #openstack-mistral01:17
*** achanda has joined #openstack-mistral02:23
*** achanda has quit IRC02:38
*** gyee has quit IRC03:00
*** bobh has joined #openstack-mistral03:22
*** bobh has quit IRC03:30
*** achanda has joined #openstack-mistral03:30
*** achanda has quit IRC03:35
*** Ephur has quit IRC04:57
*** achanda has joined #openstack-mistral05:01
*** sergmelikyan has joined #openstack-mistral05:07
*** sergmelikyan has quit IRC05:09
xylan_kongping nmakhotkin06:40
*** achanda has quit IRC06:40
xylan_kongrakhmerov: I replied in https://review.openstack.org/#/c/216483/3, and according to winson and your opinions, I removed my -106:46
rakhmerovxylan_kong: ok, I'll take a look06:50
openstackgerritRenat Akhmerov proposed openstack/mistral: Switching to six module where it's not used yet  https://review.openstack.org/21700106:50
rakhmerovxylan_kong: just did06:50
rakhmerovhonestly, I don't have a strong opinion about that06:51
rakhmerovand I don't want to push on you at all06:51
rakhmerovif you thing it should be blocked then do it (you have a right to do so)06:51
rakhmerovlet's ask what Nikolay thinks about it06:52
xylan_kongrakhmerov: yeah, it's not a big deal, and I also don't block things that most of people are for it.06:52
rakhmerovso, again, for me it doesn't seem like a big deal but I kinda see your point06:52
rakhmerovok06:52
rakhmerovnmakhotkin: what's your opinion on this?06:52
rakhmerov(he's probably not online yet)06:53
xylan_konghe is 5 hours later than us06:53
rakhmerovyeah06:54
rakhmerovand they usually start their work at around noon :)06:54
rakhmerovtheir time06:54
xylan_kongrakhmerov: ooh, you don't have work time restriction?06:55
rakhmerovyes, it'd kind of flexible06:55
xylan_kongvery humane work environment06:56
rakhmerovbut that's just mostly a culture at a particular place06:56
rakhmerovI'm sitting alone and don't follow that culture06:56
rakhmerovas the rest of the company06:56
xylan_konghaha :-)06:56
rakhmerov:)06:56
rakhmerovsometimes I start at 10am (as today), sometimes later06:57
xylan_kongit's also a little bit later for us.06:57
rakhmerovso I don't have actually a good time overlap with them too06:57
rakhmerovwhen do you usually start your workday?06:58
xylan_kongwe usually start work at 9:0006:58
rakhmerovok06:58
rakhmerovit's good )06:58
xylan_kongwe 'must' start work at 9:0006:58
rakhmerov:)))06:58
rakhmerovyou mean at your company? or it's a china-wide restriction?06:59
xylan_kongat most of chinese company, some even start at 8:0006:59
rakhmerovI see06:59
xylan_kongor you will lost your pay06:59
xylan_kongthat day06:59
rakhmerovhm... interesting06:59
rakhmerovreally???!!06:59
rakhmerovf...ck..06:59
xylan_konghaha -)07:00
xylan_kongwe get used to that07:00
rakhmerovooh gosh, that sounds tough07:00
xylan_kongyes, you're right07:00
rakhmerovwe used to have that kind of thing back in Soviet Union07:01
rakhmerovnow most of the companies moved away from that07:01
rakhmerovmost of them try to embed more flexibility in terms of how their employees work07:01
xylan_kongso, i have a dream, that on day, i can work outside china in a more free country :-)07:02
rakhmerovok, interesting to know :)07:02
rakhmerov:))07:02
xylan_kongyou must have heard of GFW07:02
rakhmerovyou won't believe maybe but some time ago (pretty long) I was seriously thinking about working in China07:02
rakhmerovGFW07:03
xylan_kongooh, you can't07:03
rakhmerovwhat's that?07:03
xylan_kongChinese Great Firewall07:03
rakhmerovaaah, yes, sure07:03
rakhmerovfunny07:03
rakhmerovsimilar to Chinese Great Wall :)07:03
xylan_kongwe could't access to google, facebook or some other website, unless you use VPN07:04
rakhmerovyeah07:04
rakhmerovyour government protects your minds from western type of thinking, hah? :)))07:04
xylan_kongyes, absolutely07:05
rakhmerovdo you think it is changing in any way towards being more liberal? or not really?07:06
rakhmerovok, I guess we shouldn't be even talking about that in an open channel! :))07:07
xylan_kongrakhmerov:  I really told too much about that, I begin to worry I'll be arrested :0(07:08
rakhmerovyeah, sorry man..07:09
xylan_kongrakhmerov: :-)07:09
rakhmerovI'll be sending food and gifts to you if you get into prison :)07:09
xylan_kongrakhmerov: appreciate that07:09
rakhmerovnp07:10
rakhmerov:)07:10
xylan_kongso, welcome to China!07:10
xylan_kongrakhmerov: so, let's talk about technic. could you do me a favor, http://logs.openstack.org/34/204634/18/check/gate-mistral-python27/c91264a/console.html07:11
xylan_kongrakhmerov: what do you think of the possible reason for that?07:12
xylan_kongboth of my patches https://review.openstack.org/#/c/204634/ and https://review.openstack.org/#/c/216509/ are blocked by that problem07:12
rakhmerovok, let me see..07:12
rakhmerovhm.. that's weird07:13
rakhmerovI just pushed a very tiny patch https://review.openstack.org/#/c/217001/ and it stumbled upon the same thing07:13
rakhmeroveven though I just changed basestring to six.string_types07:14
rakhmerovso don't know yet what that means..07:14
rakhmerovand it doesn't get reproduced locally07:14
xylan_kongrakhmerov: yes, it's good in my deployment07:15
xylan_kongall the ut are successful07:15
rakhmerovfrom what I can make a conclusion that either 1) there are differencies between local and gate env or 2) something is broken in gerrit now07:16
rakhmerovdid you try to recheck your patches?07:17
xylan_kongrakhmerov: i have rechecked for a lot of times.07:17
rakhmerovok07:17
xylan_kongrakhmerov: but, it's much more weird that, the failures are different each time07:18
rakhmerovhm..07:18
xylan_kongsometimes, the failure comes from tests of scheduler service07:19
rakhmerovnow I see errors occurring only in API unit tests07:21
rakhmerovmaybe it's related to pagination changes somehow?07:22
rakhmerovit seems like we have a race condition somewhere07:22
xylan_kongbut i ran the tests several times in my environment, everything is ok.07:23
xylan_konglet's find the reason and fix that07:24
rakhmerovyes07:25
rakhmerovsure07:25
rakhmerovI have an assumption: pecan or wsme version could change so they throw slight different exceptions now07:29
rakhmerovI'm trying to recreate my venv07:29
xylan_kongrakhmerov: ooh, i remmeber an email today07:29
rakhmerovhttps://pypi.python.org/pypi/pecan/1.0.207:29
rakhmerovpecan 1.0.2 was uploaded 3 days ago07:30
rakhmerovwhat email?07:30
xylan_kongrakhmerov: [openstack-dev] [wsme] potential issues with WSME 0.8.007:30
rakhmerovyes, it now gets reproduced once I recreated my env07:31
rakhmerovyep07:31
rakhmerovwe found the reason ;)07:31
rakhmerovneed to fix it07:31
xylan_kongyes07:31
rakhmerovdo you want me to do it? or would like to fix yourself?07:32
xylan_kongrakhmerov: i can undertake that, if you don't have time07:32
rakhmerovgo ahead sir07:33
xylan_kongI have time this afternoon :-)07:33
rakhmerovok07:33
xylan_kongyes, sir07:33
rakhmerovhm.. I'm actually thinking if what they did is a valid thing from the community standpoint07:45
rakhmerovthey really broke API backwards compatibility w/o bumping a major version07:46
xylan_kongdo you think they will revert the changes?07:46
rakhmerovooh, someone already replied exactly that07:46
rakhmerovdunno, I'm just trying to understand if they have to07:47
rakhmerovI guess nobody will make them change it back though..07:47
xylan_kongrakhmerov: according to the wsme changes, we might need change our API07:50
rakhmerovseems like we don't need to07:50
xylan_kongwhy07:51
rakhmerovso what we need to do is to move all undeclared HTTP params into REST resources declarations07:51
rakhmerovpurely server side undercurtains change07:51
xylan_kongare you sure you want to put them to resource declaration?07:51
rakhmerovI'm not but we don't have a choice07:52
rakhmerov:)07:52
rakhmerovI think it's not so scary after all07:52
xylan_kongrakhmerov: ok...07:52
xylan_kongi've no other better idea07:52
rakhmerovjust because REST resource doesn't have to reproduce a DB entity on 100%07:52
xylan_kongyes07:52
xylan_kongthis what i replied to you about 'input' and 'spec'07:53
rakhmerovit can either shrink a number of fields or add new ones which make sense for HTTP07:53
xylan_kongin my another patch07:53
rakhmerovok07:53
rakhmerovdidn't see it yet07:53
rakhmerovso let's just move these fields to rest resources, we can eve leave special comments for them, if needed07:54
xylan_kongok07:54
rakhmerovI'll step out for a lunch07:56
xylan_kongrakhmerov: ok07:56
xylan_kongenjoy07:56
rakhmerovthanks07:56
rakhmerovhow soon are you planning to start fixing it?07:56
rakhmerovin an hour or two?07:56
xylan_kongmaybe07:56
xylan_kongi'm working on that07:56
rakhmerovyou mean you already started?07:57
xylan_kongyes07:57
rakhmerovok07:58
nmakhotkinhi, xylan_kong, rakhmerov08:07
nmakhotkinI've read your comments about config samples08:07
nmakhotkinI'm ok with it08:07
nmakhotkinjust voted +2 to that patch :)08:07
*** gpaz has quit IRC08:17
openstackgerritNikolay Mahotkin proposed openstack/mistral: Mistral documentation: adding configuration guide  https://review.openstack.org/21625808:38
openstackgerritNikolay Mahotkin proposed openstack/mistral: Mistral documentation: adding installation guide  https://review.openstack.org/21552808:38
openstackgerritNikolay Mahotkin proposed openstack/mistral: Mistral documentation: dashboard installation guide  https://review.openstack.org/21666308:42
rakhmerovnmakhotkin: ok08:50
*** LimorStotland has quit IRC09:03
*** nmakhotkin has quit IRC09:28
*** LimorStotland has joined #openstack-mistral09:28
*** nmakhotkin has joined #openstack-mistral09:28
openstackgerritLingxian Kong proposed openstack/mistral: Add resource params to reflect WSME 0.8 fixes  https://review.openstack.org/21705909:41
xylan_kongrakhmerov: nmakhotkin please review https://review.openstack.org/21705909:42
xylan_kongI'll leave office, and will come here for a while after dinner, to ensure we fix the problem.09:44
*** LimorStotland has quit IRC09:47
rakhmerovok09:48
rakhmerovlooks good to me09:48
rakhmerovxylan_kong: I actually found an issue10:00
rakhmerovplease fix it10:00
rakhmerovI'm also going to make some changes on top of your patch10:01
*** LimorStotland has joined #openstack-mistral10:18
rakhmerovxylan_kong: let me know when you're back, I'd like to discuss something with you10:41
rakhmerovI'm confused about how these user types work in wsme10:41
*** LimorStotland has quit IRC10:56
*** enykeev has quit IRC11:43
*** enykeev has joined #openstack-mistral11:46
*** LimorStotland has joined #openstack-mistral11:52
xylan_kongrakhmerov: hi, are you here?12:04
rakhmerovyes12:04
rakhmerovI left a comment in your patch12:04
xylan_kongok, i'll see it12:05
rakhmerovI somewhat don't understand how it all works12:05
rakhmerovdo you agree with the comment?12:05
rakhmerovyes, please look at it12:05
xylan_konglet me see12:05
openstackgerritNikolay Mahotkin proposed openstack/mistral: Mistral documentation: main features  https://review.openstack.org/21710712:05
xylan_kongrakhmerov: for 'params' in action_execution creation, it's not a string12:07
xylan_kongrakhmerov: please see https://github.com/openstack/mistral/blob/master/mistral/tests/unit/api/v2/test_action_executions.py#L11112:07
xylan_kongrakhmerov: the JsonType won't convert anything12:08
xylan_kongrakhmerov: it's just for validation12:09
rakhmerovhm... don't understand12:09
rakhmerovlet me think12:09
xylan_kongplease see how 'param' is used in action_execution creation12:10
xylan_konghttps://github.com/openstack/mistral/blob/master/mistral/api/controllers/v2/action_execution.py#L17912:10
rakhmerovyes, I see that12:11
rakhmerovwait a second12:11
rakhmerovlet me clarify that stuff from step-by-step from the very beginning12:11
rakhmerovwhen you declare a WSME user type what is basetype?12:12
rakhmerovxylan_kong: ^12:13
xylan_kongrakhmerov: i don't know what you mean...12:13
rakhmerovin my understanding, this is a type that is used for transferring more complex type over the network12:14
rakhmerovI mean this: basetype = wtypes.text12:14
rakhmerovso it's something that we serialize a custom type into, right?12:15
xylan_kongi don't know, let me look at the wsme source code12:15
rakhmerovok12:15
rakhmerovto me it seems like it's a regular serialization pattern, nothing else12:16
rakhmerovwhere there's always at least two methods: frombasetype and tobasetype12:16
rakhmerovbasetype in our case is obviously string12:16
rakhmerovcustom type is dictionary12:17
rakhmerovso implementation of 'frombasetype' that you're proposing does not convert anything12:18
rakhmerovso my question: why?12:18
rakhmerovhow is it supposed to work?12:18
rakhmerovbecause in controller we now use action_execution.params instead of body.get('params')12:19
rakhmerovhence action_execution.params in turn must be constructed somehow from a string provided via API12:20
rakhmerovdoes that sound reasonable or I'm missing something?12:20
xylan_konghmm...in my understanding, you provide 'params' via API, it's a json object (and it should be)12:23
xylan_kongin the service side, the request is converted into ActionExecution object12:24
xylan_kongsince user could put anything for 'params', so we add a validation for that, but we didn't convert its type12:25
xylan_kongbut i don't know the call trace for that12:25
xylan_kongfinally, in the controller, we can directly use action_execution.params to get the json object12:26
*** sergmelikyan has joined #openstack-mistral12:28
xylan_kongrakhmerov: the stack trace http://dpaste.com/208YZ0M12:29
*** LimorStotland has quit IRC12:30
*** LimorStotland has joined #openstack-mistral12:30
*** bobh has joined #openstack-mistral12:32
rakhmerovok, when you say "you provide 'params' via API, it's a json object (and it should be)" what does it mean? What do you call a json object?12:32
rakhmerovREST API it's just a string in the request body12:33
rakhmerovright?12:33
rakhmeroveventually this is a string12:33
xylan_kongrakhmerov: yes, need serialization12:33
xylan_kongand deserialization12:34
rakhmerovso that's why I'm saying there must be data conversion12:34
rakhmerovfrom one type to another, and vice versa12:34
rakhmerovmaybe your code is correct, I'm just trying to understand why this conversion doesn't happen12:34
xylan_kongbut i think this step is earlier than JsonType.validate12:35
rakhmerovbtw, does validate() get called for basetype or a custom type?12:35
xylan_kongit must be called for custom type, see http://dpaste.com/208YZ0M12:36
xylan_kongfor basetype, i'm not sure...12:36
rakhmerovyeah, I did some debugging and it's called for custom type12:38
rakhmerovok12:38
rakhmerovalthough it is strange because I think there should be validation for both types12:38
rakhmerovtheoretically12:38
rakhmerovok, we could actually merge this patch now (it's really needed) if you think your code is correct12:41
rakhmerovbut i'd like to experiment with all this stuff a little bit12:41
rakhmerovafter this12:41
rakhmerovwhat do you think?12:43
xylan_kongrakhmerov: sorry, i left for a while my baby is crying...12:43
rakhmerovooh, sorry12:43
xylan_kongrakhmerov:  he is good now12:44
rakhmerov:)12:44
xylan_kongrakhmerov: i think we can merge it now. and find the princle as time goes by12:45
rakhmerovok12:45
xylan_kongat least, all the tests are good12:45
rakhmerovyes12:46
rakhmerovbtw, I'm going to adjust some other things in API so I could play with it a little bit more and see how it really works12:46
xylan_kongrakhmerov: yeah, ok, go ahead12:46
xylan_kongi'm not wsme expert, just see its examples and try to look at its source code12:47
rakhmerovok12:47
openstackgerritNikolay Mahotkin proposed openstack/mistral: Fixing working concurrency when value is YAQL  https://review.openstack.org/21712713:05
openstackgerritMerged openstack/mistral: Add resource params to reflect WSME 0.8 fixes  https://review.openstack.org/21705913:11
openstackgerritNikolay Mahotkin proposed openstack/mistral: Mistral documentation: adding configuration guide  https://review.openstack.org/21625813:28
openstackgerritNikolay Mahotkin proposed openstack/mistral: Mistral documentation: main features  https://review.openstack.org/21710713:29
openstackgerritNikolay Mahotkin proposed openstack/mistral: Mistral documentation: adding installation guide  https://review.openstack.org/21552813:29
openstackgerritNikolay Mahotkin proposed openstack/mistral: Mistral documentation: dashboard installation guide  https://review.openstack.org/21666313:29
openstackgerritNikolay Mahotkin proposed openstack/mistral: Mistral documentation: adding configuration guide  https://review.openstack.org/21625813:30
*** Piet has quit IRC13:34
openstackgerritLingxian Kong proposed openstack/mistral: Support action_execution deletion  https://review.openstack.org/21650913:39
openstackgerritLingxian Kong proposed openstack/mistral: Add fields filter for workflow query  https://review.openstack.org/20463413:39
*** Ephur has joined #openstack-mistral13:41
*** Ephur has quit IRC13:46
openstackgerritZhenguo Niu proposed openstack/mistral: Switch to devstack plugin  https://review.openstack.org/21672914:08
*** sergmelikyan has quit IRC14:12
openstackgerritNikolay Mahotkin proposed openstack/mistral: Fixing working concurrency when value is YAQL  https://review.openstack.org/21712714:14
*** sergmelikyan has joined #openstack-mistral14:16
*** Piet has joined #openstack-mistral14:29
openstackgerritZhenguo Niu proposed openstack/mistral-dashboard: Rename Mistral dashboard to Workflow  https://review.openstack.org/21724314:42
openstackgerritZhenguo Niu proposed openstack/mistral-dashboard: Rename Mistral dashboard to Workflow  https://review.openstack.org/21724314:57
*** Ephur has joined #openstack-mistral14:58
*** LimorStotland has quit IRC15:01
*** tonytan4ever has joined #openstack-mistral15:06
*** tonytan_brb has joined #openstack-mistral15:37
*** tonytan4ever has quit IRC15:38
*** gyee has joined #openstack-mistral16:14
*** Piet has quit IRC16:20
*** achanda has joined #openstack-mistral16:52
*** bobh has quit IRC16:58
*** tonytan_brb has quit IRC17:16
*** Piet has joined #openstack-mistral17:26
*** tonytan4ever has joined #openstack-mistral17:37
*** achanda_ has joined #openstack-mistral17:39
*** achanda has quit IRC17:39
*** achanda_ has quit IRC17:48
*** achanda has joined #openstack-mistral17:51
*** tonytan4ever has quit IRC18:02
*** tonytan4ever has joined #openstack-mistral18:09
*** achanda has quit IRC18:16
*** openstackgerrit has quit IRC18:17
*** openstackgerrit has joined #openstack-mistral18:17
*** zhenguo has quit IRC18:23
*** achanda has joined #openstack-mistral19:16
*** tonytan4ever has quit IRC19:18
*** achanda has quit IRC19:25
*** Ephur has quit IRC19:39
*** Ephur has joined #openstack-mistral19:41
*** achanda has joined #openstack-mistral20:02
*** achanda has quit IRC20:08
*** achanda has joined #openstack-mistral20:26
*** openstackgerrit has quit IRC21:01
*** openstackgerrit has joined #openstack-mistral21:02
*** achanda has quit IRC21:07
*** gyee has quit IRC21:17
*** Piet has quit IRC21:19
openstackgerritMerged openstack/mistral: Add config example for rotating logs  https://review.openstack.org/21648321:50
*** achanda has joined #openstack-mistral22:06
*** achanda_ has joined #openstack-mistral22:28
*** achanda has quit IRC22:29
*** Piet has joined #openstack-mistral22:32
*** sergmelikyan has quit IRC23:09
*** achanda has joined #openstack-mistral23:18
*** achanda_ has quit IRC23:18
*** achanda has quit IRC23:38

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!