*** bobh_ has joined #openstack-mistral | 00:00 | |
*** zhenguo has joined #openstack-mistral | 01:01 | |
*** achanda has joined #openstack-mistral | 01:26 | |
xylan_kong | hi, nmakhotkin, all patches are blocked by the new yaql version, right? unless your patch https://review.openstack.org/206944 is merged? | 01:50 |
---|---|---|
*** openstackgerrit has quit IRC | 03:31 | |
*** openstackgerrit has joined #openstack-mistral | 03:32 | |
*** bobh_ has quit IRC | 03:41 | |
*** sergmelikyan has joined #openstack-mistral | 05:02 | |
*** bhaskarduvvuri has joined #openstack-mistral | 05:27 | |
*** bobh_ has joined #openstack-mistral | 05:42 | |
*** bobh_ has quit IRC | 05:46 | |
rakhmerov | xylan_kong: hi, yes | 05:58 |
*** bhaskarduvvuri has quit IRC | 06:00 | |
*** bhaskarduvvuri has joined #openstack-mistral | 06:05 | |
openstackgerrit | Zhenguo Niu proposed openstack/mistral-dashboard: Add unit tests for tasks https://review.openstack.org/216104 | 06:06 |
*** achanda has quit IRC | 06:48 | |
*** sergmelikyan has quit IRC | 06:51 | |
*** ^Gal^ has quit IRC | 07:29 | |
*** ^Gal^ has joined #openstack-mistral | 07:32 | |
*** sergmelikyan has joined #openstack-mistral | 07:36 | |
*** sergmelikyan has quit IRC | 07:39 | |
*** bobh_ has joined #openstack-mistral | 07:43 | |
*** histrio has joined #openstack-mistral | 07:46 | |
histrio | Hi everybody! | 07:46 |
*** bobh_ has quit IRC | 07:47 | |
xylan_kong | hi | 07:47 |
nmakhotkin | histrio: hi! | 07:48 |
histrio | How it's going? :) | 07:49 |
xylan_kong | histrio: hi, everything is good, except yaql issue :-) | 07:50 |
histrio | xylan_kong: I see | 07:53 |
xylan_kong | rakhmerov: hi, altthough the Jenkins fails, I still want to make sure I made the right way in https://review.openstack.org/215493 | 08:20 |
*** bhaskarduvvuri has quit IRC | 08:34 | |
rakhmerov | xylan_kong: yes, sure | 08:45 |
rakhmerov | xylan_kong: how long are you going to be online today? | 08:52 |
openstackgerrit | Zhenguo Niu proposed openstack/mistral-dashboard: Add actions and executions unit tests https://review.openstack.org/216156 | 08:53 |
xylan_kong | rakhmerov: it's 16:53 now, I'll go home at around 19:30 | 08:53 |
rakhmerov | ok, I see | 08:53 |
rakhmerov | thanks | 08:53 |
xylan_kong | rakhmerov: why | 08:53 |
rakhmerov | I need you to review one patch asap once it's ready | 08:53 |
rakhmerov | yaql stuff | 08:53 |
xylan_kong | rakhmerov: you mean this one https://review.openstack.org/206944? | 08:54 |
rakhmerov | Nikolay will make some more changes in it and let us know when it's ready | 08:54 |
rakhmerov | yes | 08:54 |
rakhmerov | it is a f...ing blocker for us | 08:54 |
rakhmerov | sorry.. | 08:54 |
xylan_kong | rakhmerov: ok, np, as long as nmakhotkin is ready for that | 08:55 |
openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Moving to YAQL 1.0 https://review.openstack.org/206944 | 08:55 |
rakhmerov | thank you | 08:55 |
xylan_kong | rakhmerov: my pleasure | 08:55 |
nmakhotkin | xylan_kong, rakhmerov: that patch is ready to go | 08:56 |
xylan_kong | nmakhotkin: great | 08:56 |
rakhmerov | thanks | 08:56 |
xylan_kong | nmakhotkin: thanks for the effort | 08:56 |
xylan_kong | nmakhotkin, rakhmerov: btw, about the pagination, now we already have workflow and action support it, what about other resources? do we need support it for all mistral resources? | 09:00 |
xylan_kong | zhenguo: what do you think? | 09:01 |
rakhmerov | xylan_kong: definitely, at least for executions | 09:01 |
rakhmerov | but executions are on ^Gal^, he should take care of it | 09:01 |
rakhmerov | on the server side though we need to do that ourselves to help him with that | 09:02 |
xylan_kong | rakhmerov: you mean, ^Gal^ will implement executions pagination? | 09:02 |
rakhmerov | he is working on executions screen, yes. So it's part of his task I guess | 09:02 |
rakhmerov | ^Gal^: hi, you there? | 09:02 |
^Gal^ | yeah | 09:02 |
zhenguo | xylan_kong: ? | 09:03 |
rakhmerov | am I right on executions pagination? | 09:03 |
^Gal^ | I would get that sorted | 09:03 |
rakhmerov | what do you mean? | 09:03 |
^Gal^ | yeah | 09:03 |
xylan_kong | ^Gal^: you will cover execution pagination on service side? | 09:03 |
^Gal^ | you're right | 09:03 |
xylan_kong | server side | 09:03 |
zhenguo | xylan_kong: yeah, you need to add server support first. | 09:04 |
xylan_kong | hi all, i mean, do we need pagination support for all(or most of) mistral resources? workflow, action, execution, task_execution, workbook, env, cron_trigger... | 09:05 |
xylan_kong | currently, we already support it for workflow and action | 09:05 |
zhenguo | xylan_kong: it's better to support all, every resource can grow to more than one page(about 25?) | 09:08 |
xylan_kong | i think we could put it at very lower priority on workbook, env, cron_trigger, since they are used not so frequently, am i right? | 09:10 |
zhenguo | xylan_kong: I agree with you | 09:10 |
xylan_kong | rakhmerov, nmakhotkin ^Gal^ , how about you? | 09:11 |
^Gal^ | hmm I could do whatever you guys need | 09:12 |
rakhmerov | ^Gal^: if you need help with server side (REST endpoint) modifications let us know | 09:12 |
^Gal^ | okay sure | 09:12 |
^Gal^ | atm im working on the execution update stuff | 09:12 |
^Gal^ | on mistral-dashboard | 09:12 |
^Gal^ | want me to switch to the pagination? | 09:12 |
rakhmerov | ^Gal^, xylan_kong: here's what I think. I suggest that xylan_kong makes server side changes, I think i'll be simpler | 09:12 |
^Gal^ | sure sounds good | 09:12 |
rakhmerov | ^Gal^: yes, you will just need to consume pagination capabilities properly on a client side (dashboard) similar to how it works in workflows and actions | 09:12 |
^Gal^ | sure np | 09:12 |
rakhmerov | deal :) | 09:12 |
^Gal^ | :) | 09:12 |
^Gal^ | if you need anything further let me know | 09:12 |
rakhmerov | xylan_kong: is that ok for you? Will you find some time for that? | 09:12 |
rakhmerov | :)) | 09:12 |
rakhmerov | ok, if you don't have time we'll assign it to someone else | 09:13 |
rakhmerov | np | 09:13 |
xylan_kong | rakhmerov: yeah, be happy to do that | 09:13 |
xylan_kong | so, i'll continue to do that on execution, task_execution, action_execution | 09:14 |
^Gal^ | xylan_kong: sounds good to me | 09:14 |
xylan_kong | if anyone want to help, please let me know | 09:14 |
zhenguo | ok, want do discuss about the table filter, do we really need server side filter or client filter is enough? | 09:15 |
xylan_kong | zhenguo: i have a query column filter patch for workflow https://review.openstack.org/204634 | 09:16 |
zhenguo | xylan_kong: thanks for that, | 09:17 |
zhenguo | xylan_kong: I mean do we need to support all server side table filter, we only support nova filter now in horizon. | 09:18 |
xylan_kong | but i wonder how will you use column filtering in dash-board | 09:19 |
zhenguo | xylan_kong: specify column name first then input the query string | 09:20 |
zhenguo | xylan_kong: that will pass as a search opts to server side. | 09:20 |
xylan_kong | is that the same usage as Nova? | 09:21 |
zhenguo | yeah, but we need to support filter on server side first. | 09:21 |
xylan_kong | zhenguo: ok, please make sure the filter you mean is indeed the 'column filter' as what i did in https://review.openstack.org/204634 | 09:22 |
zhenguo | xylan_kong: that's only filter needed fields I think. | 09:23 |
xylan_kong | zhenguo: could you clarify that? | 09:25 |
zhenguo | xylan_kong: I mean we need to support search_opts={xx: xx} for list api, if want to use api table filters | 09:33 |
xylan_kong | zhenguo: ok, i know, so it's not what https://review.openstack.org/204634 did, right? | 09:34 |
zhenguo | xylan_kong: yes. | 09:34 |
xylan_kong | zhenguo: ok, got you | 09:34 |
zhenguo | xylan_kong: we don't have that support now, | 09:34 |
xylan_kong | zhenguo: yes. | 09:35 |
rakhmerov | xylan_kong: please review https://review.openstack.org/#/c/216161/ | 09:36 |
zhenguo | xylan_kong: so my patch to add table filters support is client side filter now. | 09:36 |
rakhmerov | ooh, no, wait | 09:36 |
xylan_kong | https://review.openstack.org/#/c/206944/ | 09:36 |
rakhmerov | devstack gate is failing for some reason | 09:37 |
xylan_kong | rakhmerov: yeah, i sea | 09:37 |
rakhmerov | nmakhotkin: please investigate why yaql commit is failing (devstack gate) | 09:38 |
*** bobh_ has joined #openstack-mistral | 09:43 | |
*** bobh_ has quit IRC | 09:48 | |
nmakhotkin | rakhemrov, ok, I'll take a look | 10:02 |
nmakhotkin | it seems just one test is failing | 10:03 |
rakhmerov | xylan_kong: can you please vote for https://review.openstack.org/#/c/206944/ ? | 11:03 |
rakhmerov | the failing devstack gate test is not related with yaql | 11:03 |
rakhmerov | it's a different issue | 11:03 |
rakhmerov | we need this patch in asap | 11:03 |
xylan_kong | rakhmerov: ok | 11:06 |
*** LimorStotland has joined #openstack-mistral | 11:11 | |
openstackgerrit | Merged openstack/mistral: Moving to YAQL 1.0 https://review.openstack.org/206944 | 11:11 |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Add schema for additional properties of BaseListSpec https://review.openstack.org/215493 | 11:12 |
*** ^Gal^ has quit IRC | 11:16 | |
*** gpaz has quit IRC | 11:22 | |
*** ^Gal^ has joined #openstack-mistral | 11:35 | |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Add pagination support for executions query API https://review.openstack.org/216204 | 11:39 |
*** bobh_ has joined #openstack-mistral | 11:44 | |
*** bobh_ has quit IRC | 11:48 | |
openstackgerrit | Merged openstack/mistral-extra: Adjusting examples to YAQL 1.0 https://review.openstack.org/215573 | 12:07 |
openstackgerrit | Merged openstack/mistral-dashboard: Add unit tests for tasks https://review.openstack.org/216104 | 12:09 |
*** sergmelikyan has joined #openstack-mistral | 12:25 | |
*** sergmelikyan has quit IRC | 12:29 | |
*** histrio has quit IRC | 12:30 | |
*** gpaz has joined #openstack-mistral | 12:49 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral: Mistral documentation: adding installation guide https://review.openstack.org/215528 | 13:05 |
openstackgerrit | Merged openstack/mistral: Update the gitingore file and tox.ini https://review.openstack.org/215141 | 13:14 |
*** Ravikiran_K has joined #openstack-mistral | 13:30 | |
*** sergmelikyan has joined #openstack-mistral | 13:39 | |
openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Mistral documentation: adding installation guide https://review.openstack.org/215528 | 13:45 |
openstackgerrit | Nikolay Mahotkin proposed openstack/mistral: Mistral documentation: adding configuration guide https://review.openstack.org/216258 | 13:45 |
*** tonytan4ever has joined #openstack-mistral | 14:13 | |
*** zhenguo has quit IRC | 14:17 | |
^Gal^ | is someone familiar with the following error upon unstack stack? "from yaql import exceptions as yaql_exc | ImportError: cannot import name exceptions" | 14:38 |
xylan_kong | ^Gal^: please upgrade pip packages | 14:40 |
^Gal^ | did that, as well as the YAQL pip | 14:41 |
^Gal^ | hmm | 14:41 |
xylan_kong | what's your yaql version now? | 14:41 |
xylan_kong | please use pip install -U | 14:42 |
^Gal^ | yeah that's the one i used | 14:43 |
^Gal^ | i think im on 1.0 | 14:44 |
xylan_kong | what's the output of 'pip show yaql' | 14:45 |
^Gal^ | Metadata-Version: 2.0 | 14:45 |
^Gal^ | Name: yaql | 14:45 |
^Gal^ | Version: 1.0.0 | 14:45 |
^Gal^ | Summary: YAQL - Yet Another Query Language | 14:45 |
^Gal^ | Home-page: https://launchpad.net/yaql | 14:45 |
^Gal^ | Author: Stan Lagun | 14:45 |
^Gal^ | Author-email: slagun@mirantis.com | 14:45 |
^Gal^ | License: UNKNOWN | 14:45 |
^Gal^ | Location: /usr/local/lib/python2.7/dist-packages | 14:45 |
^Gal^ | Requires: Babel, ply, pbr, six | 14:45 |
xylan_kong | ^Gal^: oh, i see | 14:46 |
*** zhenguo has joined #openstack-mistral | 14:46 | |
xylan_kong | ^Gal^: you're not using the latest code | 14:47 |
xylan_kong | https://review.openstack.org/#/c/206944/7/mistral/expressions.py,cm | 14:47 |
xylan_kong | please see the changes for yaql 1.0 | 14:47 |
xylan_kong | exceptions module is removed | 14:47 |
xylan_kong | ^Gal^: you should use from yaql.language import exceptions as yaql_exc | 14:48 |
*** bobh_ has joined #openstack-mistral | 14:48 | |
^Gal^ | silly me, thought I'm running on the latest commits | 14:49 |
^Gal^ | thanks man! appreciate | 14:49 |
xylan_kong | ^Gal^: np | 14:49 |
*** achanda has joined #openstack-mistral | 14:52 | |
*** bobh__ has joined #openstack-mistral | 14:52 | |
*** bobh_ has quit IRC | 14:53 | |
*** achanda has quit IRC | 15:02 | |
openstackgerrit | Zhenguo Niu proposed openstack/mistral-dashboard: Restrict the pbr version to sync with global requirement https://review.openstack.org/216300 | 15:24 |
*** zhenguo has quit IRC | 15:31 | |
*** gyee has joined #openstack-mistral | 15:54 | |
^Gal^ | #openstack-meeting | 15:59 |
*** gpaz has quit IRC | 16:00 | |
*** gpaz has joined #openstack-mistral | 16:00 | |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Purge executions created during functional testing https://review.openstack.org/216322 | 16:20 |
*** tonytan4ever has quit IRC | 16:45 | |
*** tonytan4ever has joined #openstack-mistral | 16:55 | |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Add pagination support for executions query API https://review.openstack.org/216204 | 17:04 |
openstackgerrit | Lingxian Kong proposed openstack/mistral: Add fields filter for workflow query https://review.openstack.org/204634 | 17:21 |
*** Ravikiran_K___ has joined #openstack-mistral | 17:25 | |
*** Ravikiran_K___ has quit IRC | 17:25 | |
*** Ravikiran_K has quit IRC | 17:28 | |
*** achanda has joined #openstack-mistral | 17:33 | |
*** Ephur has joined #openstack-mistral | 17:53 | |
*** Ephur has quit IRC | 17:54 | |
*** sergmelikyan has quit IRC | 18:30 | |
*** sergmelikyan has joined #openstack-mistral | 18:32 | |
*** sergmelikyan has quit IRC | 18:32 | |
*** sergmelikyan has joined #openstack-mistral | 18:51 | |
*** sergmelikyan has quit IRC | 19:24 | |
*** sergmelikyan has joined #openstack-mistral | 19:32 | |
*** sergmelikyan has quit IRC | 19:32 | |
*** sergmelikyan has joined #openstack-mistral | 19:34 | |
*** Ephur has joined #openstack-mistral | 19:46 | |
*** sergmelikyan has quit IRC | 19:58 | |
*** sergmelikyan has joined #openstack-mistral | 20:00 | |
*** sergmelikyan has quit IRC | 20:02 | |
*** sergmelikyan has joined #openstack-mistral | 20:06 | |
*** sergmelikyan has quit IRC | 20:07 | |
*** achanda has quit IRC | 20:07 | |
*** tonytan4ever has quit IRC | 20:15 | |
*** sergmelikyan has joined #openstack-mistral | 20:20 | |
*** sergmelikyan has quit IRC | 20:36 | |
*** sergmelikyan has joined #openstack-mistral | 20:37 | |
*** sergmelikyan has quit IRC | 20:39 | |
*** sergmelikyan has joined #openstack-mistral | 20:39 | |
*** achanda has joined #openstack-mistral | 20:40 | |
*** achanda has quit IRC | 20:41 | |
*** achanda has joined #openstack-mistral | 20:41 | |
*** sergmelikyan has quit IRC | 20:43 | |
*** sergmelikyan has joined #openstack-mistral | 20:44 | |
*** tonytan4ever has joined #openstack-mistral | 20:45 | |
*** sergmelikyan has quit IRC | 20:51 | |
*** sergmelikyan has joined #openstack-mistral | 20:57 | |
*** sergmelikyan has quit IRC | 20:58 | |
*** Piet has joined #openstack-mistral | 21:20 | |
*** Piet has quit IRC | 21:42 | |
*** sergmelikyan has joined #openstack-mistral | 21:46 | |
*** tonytan4ever has quit IRC | 22:23 | |
*** tsufiev has quit IRC | 22:41 | |
*** bobh__ has quit IRC | 22:45 | |
*** tsufiev has joined #openstack-mistral | 22:46 | |
*** Ephur has quit IRC | 23:22 | |
*** achanda_ has joined #openstack-mistral | 23:31 | |
*** achanda has quit IRC | 23:34 | |
*** achanda_ has quit IRC | 23:35 | |
*** sergmelikyan has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!