| *** matsuhashi has joined #openstack-metering | 00:00 | |
| *** herndon has joined #openstack-metering | 00:04 | |
| *** thomasm has quit IRC | 00:09 | |
| *** nosnos has joined #openstack-metering | 00:23 | |
| *** sdake_ has quit IRC | 00:42 | |
| *** sdake_ has joined #openstack-metering | 00:44 | |
| *** thomasm has joined #openstack-metering | 00:52 | |
| *** raghuvrao has left #openstack-metering | 01:02 | |
| *** raghuvrao has joined #openstack-metering | 01:13 | |
| *** evanjfraser has quit IRC | 01:16 | |
| *** sdake_ has quit IRC | 01:23 | |
| *** thomasm has quit IRC | 01:36 | |
| *** fnaval_ has joined #openstack-metering | 01:51 | |
| openstackgerrit | Guangyu Suo proposed a change to openstack/ceilometer: Add source field to Meter model https://review.openstack.org/46639 | 01:52 |
|---|---|---|
| *** herndon has quit IRC | 01:53 | |
| *** evanjfraser has joined #openstack-metering | 01:57 | |
| *** thomasm has joined #openstack-metering | 01:59 | |
| *** herndon has joined #openstack-metering | 02:05 | |
| *** neumerance has joined #openstack-metering | 02:22 | |
| openstackgerrit | Guangyu Suo proposed a change to openstack/ceilometer: Add source field to Meter model https://review.openstack.org/46639 | 02:28 |
| openstackgerrit | Guangyu Suo proposed a change to openstack/ceilometer: Add source field to Meter model https://review.openstack.org/46639 | 02:31 |
| *** maksimov has joined #openstack-metering | 02:31 | |
| *** thomasm has joined #openstack-metering | 02:34 | |
| *** maksimov has quit IRC | 02:36 | |
| openstackgerrit | Thomas Maddox proposed a change to openstack/ceilometer: Fix for timestamp precision in SQLAlchemy https://review.openstack.org/46100 | 02:38 |
| *** herndon has quit IRC | 02:47 | |
| openstackgerrit | Thomas Maddox proposed a change to openstack/ceilometer: Fix for timestamp precision in SQLAlchemy https://review.openstack.org/46100 | 03:01 |
| *** sandywalsh_ has quit IRC | 03:03 | |
| *** thomasm has quit IRC | 03:03 | |
| *** sandywalsh has joined #openstack-metering | 03:23 | |
| *** Shaan7 has quit IRC | 03:33 | |
| *** Shaan7 has joined #openstack-metering | 03:57 | |
| *** krtaylor has joined #openstack-metering | 04:55 | |
| *** tasdomas_afk is now known as tasdomas | 05:01 | |
| *** evanjfraser has quit IRC | 05:07 | |
| *** tasdomas has left #openstack-metering | 05:25 | |
| openstackgerrit | Jenkins proposed a change to openstack/ceilometer: Imported Translations from Transifex https://review.openstack.org/47083 | 06:02 |
| *** terriyu has quit IRC | 06:10 | |
| *** maksimov has joined #openstack-metering | 06:26 | |
| *** matsuhashi has quit IRC | 06:27 | |
| *** matsuhashi has joined #openstack-metering | 06:28 | |
| *** maksimov has quit IRC | 06:30 | |
| *** shang has quit IRC | 06:31 | |
| eglynn | sileht: good morning | 06:52 |
| sileht | eglynn, good morning, I have catched your message, I actually work on | 06:53 |
| sileht | eglynn, I think dhellmann need to removed its -2 too for https://review.openstack.org/#/c/41971/23 | 06:53 |
| eglynn | sileht: message about https://review.openstack.org/46707 ? ... cool! you're way ahead of me ;) | 06:53 |
| eglynn | sileht: yep, dhellmann's -2 is holding that one back IIUC | 06:54 |
| sileht | eglynn, I have just finished ceilometerclient rebase/rework, I have added required fields and alarm-get-state in cli, too. | 06:55 |
| *** nadya has joined #openstack-metering | 06:55 | |
| eglynn | sileht: excellent! I'll reconcile the partitioning patch with your treshold eval refactor | 06:56 |
| *** zul has quit IRC | 06:56 | |
| *** zul has joined #openstack-metering | 06:57 | |
| * sileht is impatient to retest the whole chain with heat autoscaling :) | 06:57 | |
| eglynn | sileht: yep, that would be a good validation ... | 06:58 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/python-ceilometerclient: Use the new alarm format https://review.openstack.org/46707 | 07:04 |
| eglynn | sileht: I'm still seeing a failure on the state update ... http://paste.openstack.org/show/47296 | 07:14 |
| eglynn | sileht: (maybe because I haven't pulled in the threshold eval refactor patch yet ...) | 07:15 |
| eglynn | sileht: "still seeing" == "after applying https://review.openstack.org/46707" | 07:15 |
| sileht | eglynn, in fact, they is a bug in wsme, that doesn't catch mandatory correctly | 07:16 |
| eglynn | sileht: a-ha, I see | 07:16 |
| sileht | eglynn, the error is catch because alarm creation | 07:16 |
| sileht | eglynn, jd__ works on this issue | 07:16 |
| eglynn | sileht: cool! | 07:16 |
| sileht | eglynn, https://bugs.launchpad.net/wsme/+bug/1227004 | 07:17 |
| sileht | eglynn, but I have just (re)tried autoscaling and wsme 0.5b5 seems have broken my BoundedInt customtype .... | 07:18 |
| sileht | eglynn, the json input is no longer converted into the basetype (int) | 07:18 |
| sileht | eglynn, on stack-update heat seems to pass only the alarm diff instead of the whole alarm ... | 07:21 |
| *** Ruetobas has quit IRC | 07:21 | |
| eglynn | sileht: i.e. Heat still has the old behaviour on PUT? | 07:22 |
| sileht | eglynn, yes | 07:22 |
| eglynn | sileht: that would be expected, no? | 07:22 |
| eglynn | sileht: (pending an update on Heat side ...) | 07:22 |
| sileht | yes | 07:23 |
| eglynn | cool | 07:26 |
| eglynn | right-o, I'm gonna head into the office now ... | 07:27 |
| eglynn | (back online in half an hour ...) | 07:27 |
| eglynn | laters ... | 07:27 |
| *** Ruetobas has joined #openstack-metering | 07:38 | |
| *** eglynn has quit IRC | 07:42 | |
| *** Ruetobas has quit IRC | 07:43 | |
| *** Ruetobas has joined #openstack-metering | 07:48 | |
| *** boris-42 has joined #openstack-metering | 08:00 | |
| *** shang has joined #openstack-metering | 08:01 | |
| *** matsuhas_ has joined #openstack-metering | 08:03 | |
| *** matsuhashi has quit IRC | 08:03 | |
| *** eglynn has joined #openstack-metering | 08:10 | |
| jd__ | dhellmann: you left a -2 on https://review.openstack.org/#/c/41971 that I think is not justified anymore and that's blocking the whole merge process | 08:34 |
| jd__ | and I don't see any kick button | 08:34 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Convert BoundedInt value from json into int https://review.openstack.org/47533 | 08:36 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Implement the combination evaluator https://review.openstack.org/42832 | 08:36 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Add alarm combination API https://review.openstack.org/41971 | 08:36 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Fix the developer documentation of the alarm API https://review.openstack.org/46980 | 08:36 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Provide new API endpoint for alarm state https://review.openstack.org/46724 | 08:36 |
| *** Ruetobas has quit IRC | 08:36 | |
| sileht | jd__, can you review this one: 1668c25c-b11f-4416-a3b5-2d291dc89e3a | 08:37 |
| sileht | oups: https://review.openstack.org/47533 | 08:37 |
| *** matsuhas_ has quit IRC | 08:39 | |
| jd__ | sileht: done :) | 08:42 |
| sileht | jd__, arf I have copy/paste wsme code..., don't edit wsme/types.py, it will blind your eye | 08:45 |
| jd__ | sileht: :/ | 08:45 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Implement the combination evaluator https://review.openstack.org/42832 | 08:47 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Add alarm combination API https://review.openstack.org/41971 | 08:47 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Fix the developer documentation of the alarm API https://review.openstack.org/46980 | 08:47 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Provide new API endpoint for alarm state https://review.openstack.org/46724 | 08:47 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Convert BoundedInt value from json into int https://review.openstack.org/47533 | 08:47 |
| sileht | jd__, fixed | 08:47 |
| *** matsuhashi has joined #openstack-metering | 08:47 | |
| jd__ | sileht: +2 :) | 08:49 |
| sileht | jd__, merci ! | 08:49 |
| *** matsuhashi has quit IRC | 08:49 | |
| sileht | eglynn, can you take a look, too ? (https://review.openstack.org/47533) | 08:49 |
| eglynn | sileht: looking now ... | 08:49 |
| *** matsuhashi has joined #openstack-metering | 08:50 | |
| eglynn | sileht: approved :) | 08:51 |
| *** matsuhas_ has joined #openstack-metering | 08:51 | |
| sileht | eglynn, autoscaling reworks with this one :) | 08:52 |
| eglynn | sileht: nice! | 08:52 |
| * eglynn still reconciling partitioning with the refactored evaluator business ... | 08:53 | |
| *** matsuhashi has quit IRC | 08:55 | |
| *** Ruetobas has joined #openstack-metering | 09:13 | |
| *** neumerance has quit IRC | 09:14 | |
| *** Ruetobas has quit IRC | 09:18 | |
| openstackgerrit | A change was merged to openstack/ceilometer: Convert BoundedInt value from json into int https://review.openstack.org/47533 | 09:22 |
| *** Ruetobas has joined #openstack-metering | 09:24 | |
| *** leizhang has joined #openstack-metering | 09:32 | |
| *** matsuhas_ has quit IRC | 09:43 | |
| openstackgerrit | Julien Danjou proposed a change to openstack/ceilometer: api: allow alarm creation for others project by admins https://review.openstack.org/47542 | 09:48 |
| openstackgerrit | Bartosz Górski proposed a change to openstack/python-ceilometerclient: Pass region_name argument to keystone client https://review.openstack.org/47544 | 09:53 |
| *** leizhang has quit IRC | 09:56 | |
| *** leizhang has joined #openstack-metering | 09:56 | |
| openstackgerrit | Julien Danjou proposed a change to openstack/ceilometer: api: allow alarm creation for others project by admins https://review.openstack.org/47542 | 10:01 |
| *** nosnos has quit IRC | 10:17 | |
| *** nadya has quit IRC | 10:24 | |
| openstackgerrit | Eoghan Glynn proposed a change to openstack/ceilometer: Simple alarm partitioning protocol based on AMQP fanout RPC https://review.openstack.org/44751 | 10:31 |
| eglynn | sileht: could you cast your eye over https://review.openstack.org/44751 ? | 10:37 |
| eglynn | sileht: (in particular the reconciliation of partitioning with your evaluator refactor) | 10:38 |
| openstackgerrit | Bartosz Górski proposed a change to openstack/ceilometer: Adding region name to service credentials https://review.openstack.org/47341 | 10:38 |
| eglynn | sileht: (... but also of course I'd appreciate another pair of eyes on the partitioning logic) | 10:38 |
| sileht | eglynn, of course, I have planned to play with it the afternoon | 10:41 |
| eglynn | sileht: great, thanks! | 10:41 |
| * eglynn busts out the thumb screws ... ;) | 10:43 | |
| eglynn | jd__: if you have time also to give the partitioning stuff another pass? | 10:43 |
| eglynn | jd__: (responses to your last set of comments here https://review.openstack.org/#/c/44751/9 ) | 10:43 |
| *** nadya has joined #openstack-metering | 10:50 | |
| openstackgerrit | Eoghan Glynn proposed a change to openstack/ceilometer: Simple alarm partitioning protocol based on AMQP fanout RPC https://review.openstack.org/44751 | 11:11 |
| openstackgerrit | Eoghan Glynn proposed a change to openstack/ceilometer: Notify with string representation of alarm reason https://review.openstack.org/47379 | 11:23 |
| openstackgerrit | Eoghan Glynn proposed a change to openstack/ceilometer: Simple alarm partitioning protocol based on AMQP fanout RPC https://review.openstack.org/44751 | 11:32 |
| jd__ | sileht: http://lists.openstack.org/pipermail/openstack-dev/2013-September/015354.html rings a bell? | 11:39 |
| jd__ | eglynn: will do :) | 11:39 |
| eglynn | jd__: thank you sir! | 11:39 |
| sileht | jd__, This is related to wsme mandatory issue | 11:40 |
| sileht | jd__, do you want I create a patch with a workaround (manual check of all mandatory fields) to have correct message error ? | 11:42 |
| sileht | jd__, The person needs to use ceilometerclient with https://review.openstack.org/#/c/46707/ | 11:45 |
| *** eglynn is now known as eglynn-lunch | 11:47 | |
| jd__ | sileht: feel free to answer to the mailing list :) but having a patch with correct error returned would be great indeed | 11:47 |
| sileht | jd__, done | 11:52 |
| jd__ | thanks sileht | 12:03 |
| *** sandywalsh has quit IRC | 12:11 | |
| *** thomasm has joined #openstack-metering | 12:11 | |
| openstackgerrit | A change was merged to openstack/ceilometer: Notify with string representation of alarm reason https://review.openstack.org/47379 | 12:20 |
| *** nadya_ has joined #openstack-metering | 12:20 | |
| *** nadya has quit IRC | 12:21 | |
| thomasm | HEy all | 12:25 |
| *** sandywalsh has joined #openstack-metering | 12:26 | |
| *** gordc has joined #openstack-metering | 12:33 | |
| *** bpokorny has joined #openstack-metering | 12:45 | |
| jd__ | eglynn-lunch: around? | 12:47 |
| *** eglynn-lunch is now known as eglynn | 12:47 | |
| eglynn | jd__: yep | 12:47 |
| jd__ | eglynn: I'm reading your comment on https://review.openstack.org/#/c/47542 | 12:48 |
| jd__ | IIUC this project_id restriction is stored in the threshold alarm? | 12:48 |
| eglynn | jd__: not making sense? | 12:48 |
| jd__ | I think it does make sense, I've added tests for PUT too, and I'm hitting it | 12:49 |
| eglynn | jd__: yep, an extra constraint is implicitly added to the statistics query | 12:49 |
| eglynn | jd__: (which is now stored in the threshold rule) | 12:49 |
| eglynn | jd__: so that the alarm owner can only see that stats they can query themselves directly | 12:49 |
| eglynn | jd__: (for non-admin alarm owners) | 12:49 |
| jd__ | I think I get that | 12:50 |
| eglynn | k | 12:50 |
| jd__ | what I don't get is what it is stored? | 12:50 |
| jd__ | what it is returned as part of the alarm object in the REST API? | 12:50 |
| jd__ | this should be the eveluator to read on_behalf_Of and use the field to construct the query | 12:50 |
| jd__ | or do I miss something? | 12:50 |
| eglynn | IIUC the evaluator just uses the query constaints as always | 12:51 |
| eglynn | some of those constraints could be provided by the user creating the alarm | 12:51 |
| eglynn | e.g. resource_id=<instance_id> | 12:51 |
| jd__ | agreed | 12:51 |
| eglynn | but an extra one is added when the alarm is created | 12:51 |
| eglynn | the extra one being project_id=owner_project_id | 12:52 |
| jd__ | but currently, if an admin changes the on_behalf_of field of an alarm, it's likely to break things for example? | 12:52 |
| jd__ | things = the statisticsquery | 12:52 |
| eglynn | on_behalf_of is only an attribute of the alarm history IIUC | 12:52 |
| jd__ | oh | 12:52 |
| jd__ | ok I thought it was used for statitics | 12:52 |
| jd__ | ok so there's only the bug I'm hitting | 12:53 |
| jd__ | and the one you mentionned | 12:53 |
| eglynn | the bug you're hitting? | 12:53 |
| jd__ | yeah I've added the same code for PUT (the current patch only handled POST) | 12:53 |
| jd__ | and my test does not pass because the project_id is not correct on the rule | 12:54 |
| jd__ | for the reason you pointed | 12:54 |
| eglynn | a-ha, OK ... so I guess if the alarm project_id is updated, then so must be the extra implicit query | 12:54 |
| jd__ | yeah | 12:54 |
| eglynn | cool | 12:54 |
| jd__ | so, my point is, why not remove the extra implicit query altogether? | 12:54 |
| jd__ | and build it at run time in the evaluators? | 12:54 |
| jd__ | do we need even to build it an admin can set the correct project_id | 12:55 |
| * jd__ scratches his head | 12:55 | |
| eglynn | well in the evaluator we wouldn't know if the project_id query needs to be added, as we wouldn't know at that point if the alarm owner is admin or not | 12:55 |
| eglynn | unless I'm missing something there ... | 12:56 |
| jd__ | eglynn: the admin can set project_id when creating an alarm | 12:56 |
| jd__ | ok so you're an admin, I'm not | 12:56 |
| eglynn | yep | 12:56 |
| jd__ | you create an alarm for me and you set project_id='jd' | 12:56 |
| eglynn | sure | 12:56 |
| eglynn | then when the evaluator check that alarm | 12:56 |
| eglynn | it wouldn't know that jd is non-admin | 12:56 |
| eglynn | (the extra query bit is only needed in the non-admin case) | 12:57 |
| eglynn | IIUC | 12:57 |
| jd__ | oh I see, I missed the case where you want to evaluate admin alarm not contrained to ONE project? | 12:57 |
| eglynn | sure, it seems like an artificial constraint for non-admin alarm owners | 12:57 |
| jd__ | ok, I was thinking evaluation was always limited to one project | 12:58 |
| eglynn | wouldn't admins be able query stats directly for multiple projects? | 12:58 |
| jd__ | hum | 12:58 |
| eglynn | (in which case, seems logical to allow their alarms do the same thing) | 12:58 |
| jd__ | yeah | 12:59 |
| jd__ | the problem is that our evaluator runs as admin | 13:00 |
| jd__ | i'm drafting something, one sec | 13:00 |
| eglynn | yep it does | 13:00 |
| eglynn | so the point is to avoid the evaluator's admin-ness being inappropriately delegated to non-admin alarm owners when the evaluator is querying on their behalf | 13:01 |
| jd__ | :/ | 13:02 |
| eglynn | but also to avoid admin alarm owners being artificially constrained to only alarming on their own statistics | 13:02 |
| jd__ | makes sense | 13:02 |
| jd__ | I just think it sucks we have to do it this way | 13:02 |
| eglynn | it's a bit indirect all right, I'll grant you that | 13:03 |
| jd__ | well I'll suck it up and will check how Keystone v3 can help :) | 13:08 |
| eglynn | coolio :) | 13:08 |
| *** julim has joined #openstack-metering | 13:09 | |
| *** jergerber has joined #openstack-metering | 13:09 | |
| * sileht read the big backlog | 13:12 | |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Handle manually mandatory field https://review.openstack.org/47563 | 13:12 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Implement the combination evaluator https://review.openstack.org/42832 | 13:12 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Add alarm combination API https://review.openstack.org/41971 | 13:12 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Fix the developer documentation of the alarm API https://review.openstack.org/46980 | 13:12 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Provide new API endpoint for alarm state https://review.openstack.org/46724 | 13:12 |
| sileht | jd__, https://review.openstack.org/47563 | 13:14 |
| *** herndon has joined #openstack-metering | 13:17 | |
| *** raghuvrao has quit IRC | 13:23 | |
| *** rrao has joined #openstack-metering | 13:25 | |
| *** rrao has quit IRC | 13:25 | |
| *** rrao has joined #openstack-metering | 13:25 | |
| *** fnaval_ has quit IRC | 13:25 | |
| jd__ | sileht: will check | 13:29 |
| *** rrao has left #openstack-metering | 13:31 | |
| openstackgerrit | Vladislav Kuzmin proposed a change to openstack/ceilometer: Replace tests.base part4 https://review.openstack.org/47145 | 13:34 |
| openstackgerrit | Vladislav Kuzmin proposed a change to openstack/ceilometer: Replace tests.base part3 https://review.openstack.org/47144 | 13:34 |
| openstackgerrit | Vladislav Kuzmin proposed a change to openstack/ceilometer: Replace tests.base part6 https://review.openstack.org/47147 | 13:34 |
| openstackgerrit | Vladislav Kuzmin proposed a change to openstack/ceilometer: Replace tests.base part5 https://review.openstack.org/47146 | 13:34 |
| openstackgerrit | Vladislav Kuzmin proposed a change to openstack/ceilometer: Update oslo in ceilometer part1 https://review.openstack.org/46476 | 13:34 |
| openstackgerrit | Vladislav Kuzmin proposed a change to openstack/ceilometer: Replace tests.base part1 https://review.openstack.org/46480 | 13:34 |
| openstackgerrit | Vladislav Kuzmin proposed a change to openstack/ceilometer: Replace tests.base part2 https://review.openstack.org/47143 | 13:34 |
| openstackgerrit | Vladislav Kuzmin proposed a change to openstack/ceilometer: Update oslo in ceilometer part2 https://review.openstack.org/47142 | 13:34 |
| *** ruhe has joined #openstack-metering | 13:51 | |
| dhellmann | jd__: good morning! you're on the stable maintenance team, right? | 13:53 |
| *** terriyu has joined #openstack-metering | 13:53 | |
| *** fnaval__ has joined #openstack-metering | 13:53 | |
| jd__ | dhellmann: I don't know :) | 14:01 |
| dhellmann | jd__: I think you are by virtue of being PTL | 14:01 |
| dhellmann | in any case, I approved that notification change :-) | 14:01 |
| eglynn | dhellmann, jd__: here's the stable-maint member list ... https://launchpad.net/~openstack-stable-maint/+members#active | 14:02 |
| dhellmann | eglynn: thanks, I was looking for that in gerrit | 14:03 |
| jd__ | dhellmann: btw if you missed it: | 14:04 |
| jd__ | <jd__> dhellmann: you left a -2 on https://review.openstack.org/#/c/41971 that | 14:04 |
| jd__ | I think is not justified anymore and that's blocking the whole merge | 14:04 |
| jd__ | process | 14:04 |
| dhellmann | jd__: I'll look at that again today, I saw there was progress on that while I was traveling and now that I'm home I should have time to do a proper review | 14:04 |
| jd__ | dhellmann: ok, the patch already has 2 +2 so… :) | 14:05 |
| jd__ | but feel free to review indeed | 14:05 |
| dhellmann | jd__: ok, I see tha tnow | 14:05 |
| *** julim has quit IRC | 14:06 | |
| dhellmann | jd__: approved | 14:07 |
| jd__ | kewl thanks dhellmann | 14:07 |
| *** julim has joined #openstack-metering | 14:07 | |
| dhellmann | jd__: am I blocking us on anything else? :-) | 14:07 |
| jd__ | dhellmann: no it's good :) | 14:08 |
| dhellmann | good | 14:08 |
| *** thomasm has quit IRC | 14:09 | |
| jd__ | dhellmann: there's some WSME patches to review if you are bored | 14:10 |
| dhellmann | jd__: those are on my list for today, too | 14:10 |
| jd__ | cool :) | 14:10 |
| *** neumerance has joined #openstack-metering | 14:11 | |
| *** herndon has quit IRC | 14:11 | |
| neumerance | Hi guys, is there anyone here how to restart ceilometer services in devstack? | 14:11 |
| dhellmann | neumerance: they should restart when you run rejoin-stack.sh | 14:12 |
| dhellmann | just like the other services | 14:12 |
| *** dhellmann is now known as dhellmann_ | 14:16 | |
| sileht | dhellmann, I have made a new improvement for sphinxcontrib-pecanwsme, to get https://review.openstack.org/#/c/46980/8 merged | 14:16 |
| *** litong has joined #openstack-metering | 14:17 | |
| litong | @jd__, ping | 14:18 |
| jd__ | litong: pong | 14:18 |
| litong | @jd__, our test coverage average at around 55%. would like to add some test cases for a higher test code coverage, wondering if you are ok with it? | 14:19 |
| jd__ | litong: sure | 14:19 |
| sileht | +1 | 14:20 |
| litong | I will try to put the new patch sets in a series, so I will just add test cases in each set. | 14:20 |
| *** Ruetobas has quit IRC | 14:29 | |
| openstackgerrit | A change was merged to openstack/ceilometer: Add alarm combination API https://review.openstack.org/41971 | 14:35 |
| *** Ruetobas has joined #openstack-metering | 14:36 | |
| *** thomasm has joined #openstack-metering | 14:37 | |
| *** raghuvrao has joined #openstack-metering | 14:40 | |
| *** julim has quit IRC | 14:40 | |
| *** julim has joined #openstack-metering | 14:41 | |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Fix the developer documentation of the alarm API https://review.openstack.org/46980 | 14:45 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Handle manually mandatory field https://review.openstack.org/47563 | 14:45 |
| *** herndon has joined #openstack-metering | 14:46 | |
| openstackgerrit | Julien Danjou proposed a change to openstack/ceilometer: api: allow alarm creation for others project by admins https://review.openstack.org/47542 | 14:48 |
| *** ruhe has quit IRC | 14:54 | |
| *** ruhe has joined #openstack-metering | 14:57 | |
| *** Ruetobas has quit IRC | 15:12 | |
| *** julim has quit IRC | 15:13 | |
| thomasm | +2's welcomed: https://review.openstack.org/#/c/46100 | 15:27 |
| thomasm | =D | 15:27 |
| thomasm | Ahhh, wait feature freeze. | 15:28 |
| openstackgerrit | A change was merged to openstack/ceilometer: Implement the combination evaluator https://review.openstack.org/42832 | 15:29 |
| eglynn | sileht: hey | 15:32 |
| sileht | eglynn, o/ | 15:32 |
| eglynn | sileht: I need to drop off-line in a few mins ... | 15:32 |
| eglynn | sileht: so just wondering if there's any further feedback from you on the partitioning stuff that I could deal with quickly before I drop off? | 15:32 |
| *** openstackgerrit has quit IRC | 15:33 | |
| *** openstackgerrit has joined #openstack-metering | 15:33 | |
| *** Ruetobas has joined #openstack-metering | 15:33 | |
| sileht | eglynn, I have just read your remarks and I'm OK, but I have not yet play with it | 15:33 |
| sileht | eglynn, I prepare the fix for heat alarm update | 15:33 |
| eglynn | sileht: cool enough | 15:34 |
| eglynn | sileht: I'll be on-line again later this evening if you've any suggested changes to the partitioning stuff as a result of playing with it ... | 15:34 |
| sileht | eglynn, ok | 15:35 |
| eglynn | sileht: (the pressure is on to get this landed today ... ;) | 15:35 |
| sileht | eglynn, oh I will switch one this first, heat can wait a bit | 15:38 |
| eglynn | sileht: thank you sir! | 15:38 |
| *** neumerance has quit IRC | 15:39 | |
| *** nadya_ has quit IRC | 15:58 | |
| *** herndon has quit IRC | 16:00 | |
| *** Ruetobas has quit IRC | 16:01 | |
| *** shang has quit IRC | 16:03 | |
| *** Ruetobas has joined #openstack-metering | 16:03 | |
| jd__ | eglynn: any chance you quickly update from gordc comments? | 16:03 |
| eglynn | jd__: looking now ... | 16:04 |
| *** herndon has joined #openstack-metering | 16:04 | |
| sileht | gordc, Can you take a look to: https://review.openstack.org/#/c/47563/ ? | 16:05 |
| gordc | eglynn: is there a more detailed bp for partitioner work? too be honest i'm not familiar with it but it looks interesting. | 16:07 |
| sileht | eglynn, I have finish my tests, ready to +2 after the gordc remarks are done | 16:07 |
| gordc | sileht: sure. i can have a look. | 16:07 |
| *** dhellmann_ is now known as dhellmann | 16:08 | |
| *** Ruetobas has quit IRC | 16:08 | |
| eglynn | gordc: I've promised several times to do a proper write-up of the idea, but haven't gotten to it yet | 16:08 |
| eglynn | gordc: will definitely do so shortly ... | 16:08 |
| gordc | eglynn: no worries. i probably won't get around to looking at it for a while anyways. | 16:09 |
| *** julim has joined #openstack-metering | 16:11 | |
| *** terriyu has quit IRC | 16:11 | |
| openstackgerrit | A change was merged to openstack/ceilometer: Provide new API endpoint for alarm state https://review.openstack.org/46724 | 16:11 |
| *** julim has quit IRC | 16:12 | |
| *** Ruetobas has joined #openstack-metering | 16:14 | |
| sileht | gordc, thanks | 16:14 |
| gordc | sileht: np | 16:16 |
| *** sdake_ has joined #openstack-metering | 16:19 | |
| *** gordc has quit IRC | 16:24 | |
| *** gordc has joined #openstack-metering | 16:25 | |
| openstackgerrit | Eoghan Glynn proposed a change to openstack/ceilometer: Simple alarm partitioning protocol based on AMQP fanout RPC https://review.openstack.org/44751 | 16:26 |
| eglynn | gordc, jd__: responded ... gotta run now to pick up kids, will be back online in circa 30mins | 16:27 |
| *** eglynn has quit IRC | 16:33 | |
| *** terriyu has joined #openstack-metering | 16:44 | |
| *** shaneduan has left #openstack-metering | 16:47 | |
| *** shardy is now known as shardy_afk | 16:50 | |
| *** nadya has joined #openstack-metering | 16:54 | |
| *** eglynn has joined #openstack-metering | 16:55 | |
| *** nadya has quit IRC | 17:03 | |
| *** ruhe has quit IRC | 17:08 | |
| openstackgerrit | litong01 proposed a change to openstack/ceilometer: add more test cases to improve the test code coverage #1 https://review.openstack.org/47608 | 17:13 |
| *** sandywalsh_ has joined #openstack-metering | 17:14 | |
| *** sandywalsh has quit IRC | 17:18 | |
| terriyu | litong: thanks for the patch. Just curious, you said our test coverage was 55%. I'm wondering, how do you check that? | 17:19 |
| *** ruhe has joined #openstack-metering | 17:19 | |
| *** herndon has quit IRC | 17:27 | |
| *** shakayumi has joined #openstack-metering | 17:41 | |
| *** ruhe has quit IRC | 17:42 | |
| *** maksimov has joined #openstack-metering | 17:44 | |
| *** ruhe has joined #openstack-metering | 17:44 | |
| *** ruhe has quit IRC | 17:51 | |
| litong | @terriyu, run-tests --coverage, then you will see a directory named cover, | 17:56 |
| litong | the reports are there. | 17:57 |
| *** nadya has joined #openstack-metering | 17:58 | |
| *** ruhe has joined #openstack-metering | 18:03 | |
| *** julim has joined #openstack-metering | 18:07 | |
| *** ruhe has quit IRC | 18:07 | |
| *** nadya has quit IRC | 18:11 | |
| openstackgerrit | A change was merged to openstack/ceilometer: Handle manually mandatory field https://review.openstack.org/47563 | 18:20 |
| *** thomasm has quit IRC | 18:35 | |
| *** thomasm has joined #openstack-metering | 18:54 | |
| *** leizhang has quit IRC | 18:55 | |
| *** thomasm has quit IRC | 18:55 | |
| *** thomasm has joined #openstack-metering | 18:55 | |
| terriyu | thanks litong | 19:05 |
| terriyu | unfortunately, that command isn't working for me :( | 19:05 |
| litong | ./run-tests.sh --recoverage should work. | 19:06 |
| *** thomasm has quit IRC | 19:38 | |
| *** thomasm has joined #openstack-metering | 19:39 | |
| *** evanjfraser has joined #openstack-metering | 19:46 | |
| *** gordc has quit IRC | 19:49 | |
| * eglynn hates to deploy the thumbscrews again ... | 19:50 | |
| eglynn | jd__: can you give https://review.openstack.org/44751 another look? | 19:50 |
| * eglynn would love to get it landed today if poss ... | 19:50 | |
| *** julim has quit IRC | 19:55 | |
| *** julim has joined #openstack-metering | 19:59 | |
| *** herndon has joined #openstack-metering | 20:08 | |
| terriyu | litong: I tried that command and it says that "recoverage" is not an option | 20:09 |
| terriyu | well, I should have been more clear | 20:09 |
| litong | --coverage, no recoverage | 20:09 |
| terriyu | when I ran ./run-tests.sh --coverage | 20:09 |
| terriyu | it runs but I get a bunch of test failures | 20:09 |
| terriyu | and I don't see a cover folder | 20:09 |
| terriyu | http://paste.openstack.org/show/47341/ | 20:12 |
| litong | so you have not run the script looks like. | 20:18 |
| litong | probably make sure your env is setup right. | 20:18 |
| litong | normally it is because you either miss dependency or your dependency is out dated. | 20:18 |
| litong | I suggest you run this first. | 20:19 |
| litong | sudo python setup.py install | 20:19 |
| litong | this will basically download all the dependencies | 20:19 |
| litong | if it runs ok, then do sudo python setup.py develop. | 20:19 |
| litong | then run the script again. | 20:19 |
| terriyu | thanks litong | 20:30 |
| terriyu | I ran sudo python setup.py install and sudo python setup.py develop | 20:30 |
| terriyu | and then ran ./run-tests.sh --coverage | 20:30 |
| terriyu | but I'm still getting the same test failures | 20:30 |
| terriyu | I do see some files like .coverage.precise64.12084.974412 | 20:31 |
| litong | if you are seeing errors from nova_test, that is ok, you may not have nova stuff. | 20:31 |
| terriyu | but no cover folder | 20:31 |
| litong | so I normally just remove some nova test. | 20:31 |
| litong | then you should be able to run it again. | 20:31 |
| litong | I mean remove this file nova_tests/test_notifier.py | 20:32 |
| *** shakayumi has quit IRC | 20:36 | |
| *** evanjfraser has quit IRC | 20:37 | |
| openstackgerrit | litong01 proposed a change to openstack/ceilometer: add more test cases to improve the test code coverage #2 https://review.openstack.org/47629 | 20:38 |
| terriyu | litong: I tried removing nova_tests/test_notifier.py and commenting out nova_tests in the run-tests.sh script, but the same test failures occurred | 20:39 |
| litong | what are the errors? | 20:40 |
| terriyu | hold on, I'll get you a paste | 20:40 |
| litong | did sudo python setup.py install finish successfully? | 20:40 |
| terriyu | yes, sudo python setup.py finished successfully | 20:45 |
| *** nadya has joined #openstack-metering | 20:51 | |
| terriyu | litong: here's a paste of the errors http://paste.openstack.org/show/47342/ | 20:53 |
| litong | @terriyu, not sure about the problem. probably try this, backup your /etc/ceilometer/ceilometer.conf file some where, then remove that file. | 20:56 |
| litong | try again. | 20:56 |
| terriyu | I use Devstack, so I don't know if that has something to do with it | 20:56 |
| terriyu | also, I'm using the SQLAlchemy backend | 20:56 |
| litong | @terriyu, right, I use devstack as well, that is why I suggest to try to get rid of your configuration file and just use what ceilometer defaults to run the test. | 21:01 |
| *** thomasm has quit IRC | 21:07 | |
| *** nadya has quit IRC | 21:08 | |
| *** julim has quit IRC | 21:08 | |
| litong | @terriyu, from this error, No module named config, seems to me that you are missing oslo.config module. | 21:09 |
| terriyu | ok | 21:10 |
| litong | you probably want to install the latest oslo.config module. | 21:10 |
| *** thomasm has joined #openstack-metering | 21:11 | |
| terriyu | litong: should I install oslo.config using pip? | 21:11 |
| litong | I do not remember, probably either apt-get or pip. | 21:11 |
| litong | try pip and see how it goes. | 21:12 |
| thomasm | terriyu, litong: I thought that oslo used an update script to mirror to all OS projects? | 21:13 |
| litong | some of the modules are not automatically updated. | 21:13 |
| thomasm | Ohhhh okay | 21:14 |
| litong | I do not think I saw oslo.config being in the requirments.txt. | 21:14 |
| thomasm | litong, Ahhh yeah I see it now. Sorry =] | 21:14 |
| thomasm | https://pypi.python.org/pypi/oslo.config | 21:14 |
| thomasm | hmmmm | 21:14 |
| litong | sometimes, you may have to get rid of the .tox directory to refresh your run-tests. | 21:15 |
| thomasm | tox -r can also be helpful. Though, like litong said, sometimes I just have to blow away my .tox completely. | 21:16 |
| thomasm | It looks like that update script is more specifically for updating from incubator | 21:17 |
| thomasm | =] | 21:17 |
| litong | well, actually oslo.config is in the requirements.txt. | 21:17 |
| litong | it requires 1.2.0a3. | 21:17 |
| litong | make sure your oslo.config is up to that level. | 21:17 |
| terriyu | ok | 21:18 |
| litong | and it is possible that you may have an older version in .tox/_download dir, | 21:18 |
| terriyu | hmm, that's weird | 21:18 |
| terriyu | I did "pip search oslo.config" and it's installed | 21:18 |
| *** thomasm has quit IRC | 21:18 | |
| litong | you may see some thing like this http%3A%2F%2Ftarballs.openstack.org%2Foslo.config%2Foslo.config-1.2.0a3.tar.gz | 21:18 |
| litong | I have the required oslo.config obviously. | 21:19 |
| terriyu | my version of oslo.config is 1.2.0a4.5.gf2be4e8 | 21:19 |
| litong | check the .tox/_download directory. | 21:19 |
| litong | see if you have multiple of oslo.config | 21:20 |
| *** EmilienM has quit IRC | 21:22 | |
| terriyu | in .tox/_download, I have oslo.config-1.2.0a3 | 21:22 |
| terriyu | hmm | 21:23 |
| terriyu | well, I'll try removing .tox | 21:23 |
| *** litong has quit IRC | 21:23 | |
| *** EmilienM has joined #openstack-metering | 21:23 | |
| *** sandywalsh_ has quit IRC | 21:37 | |
| *** sandywalsh_ has joined #openstack-metering | 21:54 | |
| *** bpokorny has quit IRC | 22:03 | |
| *** openstack has quit IRC | 22:35 | |
| *** openstack has joined #openstack-metering | 22:35 | |
| *** fnaval__ has quit IRC | 23:03 | |
| *** herndon has quit IRC | 23:04 | |
| *** maksimov has quit IRC | 23:25 | |
| *** herndon has joined #openstack-metering | 23:50 | |
| *** mgagne has quit IRC | 23:50 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!