| *** dina_belova has joined #openstack-metering | 00:11 | |
| *** dina_belova has quit IRC | 00:15 | |
| *** shang has joined #openstack-metering | 00:29 | |
| *** maksimov has joined #openstack-metering | 01:01 | |
| *** maksimov has quit IRC | 01:06 | |
| *** dina_belova has joined #openstack-metering | 01:11 | |
| *** dina_belova has quit IRC | 01:16 | |
| *** flwang has quit IRC | 01:19 | |
| *** d34dh0r53 has joined #openstack-metering | 01:59 | |
| *** d34dh0r53 has quit IRC | 02:01 | |
| *** d34dh0r53 has joined #openstack-metering | 02:03 | |
| *** dina_belova has joined #openstack-metering | 02:12 | |
| *** zul has quit IRC | 02:16 | |
| *** flwang has joined #openstack-metering | 02:16 | |
| *** dina_belova has quit IRC | 02:16 | |
| *** zul has joined #openstack-metering | 02:20 | |
| *** zul has quit IRC | 02:34 | |
| *** shang has quit IRC | 02:36 | |
| *** zul has joined #openstack-metering | 02:42 | |
| *** dina_belova has joined #openstack-metering | 03:12 | |
| *** shang has joined #openstack-metering | 03:17 | |
| *** dina_belova has quit IRC | 03:17 | |
| *** shang_ has joined #openstack-metering | 03:26 | |
| *** shang has quit IRC | 03:30 | |
| *** dina_belova has joined #openstack-metering | 04:13 | |
| *** dina_belova has quit IRC | 04:17 | |
| *** mberwanger has joined #openstack-metering | 04:41 | |
| *** tasdomas_afk is now known as tasdomas | 04:46 | |
| *** boris-42 has joined #openstack-metering | 04:53 | |
| openstackgerrit | Terri Yu proposed a change to openstack/ceilometer: Add SQLAlchemy implementation of groupby https://review.openstack.org/41597 | 04:57 |
|---|---|---|
| *** mberwanger has quit IRC | 05:10 | |
| *** dina_belova has joined #openstack-metering | 05:13 | |
| *** dina_belova has quit IRC | 05:18 | |
| *** evanjfraser has quit IRC | 05:27 | |
| *** terriyu has joined #openstack-metering | 05:29 | |
| *** SergeyLukjanov has joined #openstack-metering | 05:41 | |
| *** dina_belova has joined #openstack-metering | 05:54 | |
| openstackgerrit | Jenkins proposed a change to openstack/ceilometer: Imported Translations from Transifex https://review.openstack.org/42459 | 06:04 |
| *** dina_belova has quit IRC | 06:24 | |
| *** SergeyLukjanov has quit IRC | 06:25 | |
| *** SergeyLukjanov has joined #openstack-metering | 06:30 | |
| *** SergeyLukjanov has quit IRC | 06:38 | |
| *** SergeyLukjanov has joined #openstack-metering | 06:42 | |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: message_id is not allowed to be submitted via api https://review.openstack.org/39033 | 06:43 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Api V2 post sample refactoring https://review.openstack.org/39031 | 06:43 |
| *** dina_belova has joined #openstack-metering | 06:43 | |
| *** yolanda has joined #openstack-metering | 06:45 | |
| *** SergeyLukjanov has quit IRC | 06:48 | |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Don't call publisher without sample https://review.openstack.org/39510 | 06:52 |
| *** dina_belova has quit IRC | 06:57 | |
| *** flwang has quit IRC | 07:04 | |
| openstackgerrit | Svetlana Shturm proposed a change to openstack/ceilometer: Fix migration with fkeys. https://review.openstack.org/38607 | 07:05 |
| openstackgerrit | Svetlana Shturm proposed a change to openstack/ceilometer: Fix migration with fkeys. https://review.openstack.org/38607 | 07:16 |
| openstackgerrit | A change was merged to openstack/ceilometer: Doc: clearly state that one can filter on metadata https://review.openstack.org/42359 | 07:19 |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Add alarm combination API https://review.openstack.org/41971 | 07:20 |
| *** nsaje1 has joined #openstack-metering | 07:23 | |
| openstackgerrit | Svetlana Shturm proposed a change to openstack/ceilometer: Fix typo in 17738166b91 migration https://review.openstack.org/42576 | 07:39 |
| openstackgerrit | Svetlana Shturm proposed a change to openstack/ceilometer: Fix migration with fkeys https://review.openstack.org/38607 | 07:40 |
| *** yolanda has quit IRC | 07:49 | |
| *** dina_belova has joined #openstack-metering | 08:08 | |
| *** dina_belova has quit IRC | 08:13 | |
| openstackgerrit | Cyril Roelandt proposed a change to openstack/ceilometer: Implement 'reset_on' for mongodb https://review.openstack.org/42355 | 08:17 |
| openstackgerrit | Cyril Roelandt proposed a change to openstack/ceilometer: Statistics: Add a "reset_on" query parameter https://review.openstack.org/41899 | 08:17 |
| *** boris-42 has quit IRC | 08:19 | |
| openstackgerrit | Fengqian.gao proposed a change to openstack/ceilometer: Add pagination parameter to the base class of stroage https://review.openstack.org/42582 | 08:20 |
| openstackgerrit | Fengqian.gao proposed a change to openstack/ceilometer: Adjust some APIs' interface of hbase and logging storage backend https://review.openstack.org/41035 | 08:20 |
| openstackgerrit | Fengqian.gao proposed a change to openstack/ceilometer: Add pagination support for sqlalchemy database https://review.openstack.org/35454 | 08:20 |
| openstackgerrit | Fengqian.gao proposed a change to openstack/ceilometer: Change pagination query method in mongodb https://review.openstack.org/41869 | 08:20 |
| *** shardy_afk is now known as shardy | 08:39 | |
| *** jbuckley has joined #openstack-metering | 08:48 | |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Make RPCPublisher flush method threadsafe https://review.openstack.org/42587 | 08:52 |
| sileht | jd__, I have investigated on https://bugs.launchpad.net/ceilometer/+bug/1211736, I have recreated a test case to catch the bug: https://review.openstack.org/#/c/42587/1/tests/publisher/test_rpc_publisher.py | 08:55 |
| sileht | jd__, but I have used eventlet.sleep and I didn't like that, do you know a trick to control the eventlet spawn calls sequence without using sleep ? | 08:57 |
| jd__ | sileht: fracking awesome you got a test case working | 08:57 |
| jd__ | sileht: nop, I barely know eventlet | 08:57 |
| *** dina_belova has joined #openstack-metering | 09:09 | |
| *** dina_belova has quit IRC | 09:13 | |
| *** evanjfraser has joined #openstack-metering | 09:23 | |
| *** boris-42 has joined #openstack-metering | 09:30 | |
| *** mikedawson has quit IRC | 09:35 | |
| *** yolanda has joined #openstack-metering | 09:38 | |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Make RPCPublisher flush method threadsafe https://review.openstack.org/42587 | 09:44 |
| *** yolanda has quit IRC | 09:46 | |
| *** chuckieb|2 has quit IRC | 09:53 | |
| *** dina_belova has joined #openstack-metering | 10:09 | |
| *** dina_belova has quit IRC | 10:13 | |
| *** shang_ has quit IRC | 10:24 | |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/ceilometer: Make RPCPublisher flush method threadsafe https://review.openstack.org/42587 | 10:30 |
| *** evanjfraser has quit IRC | 10:33 | |
| openstackgerrit | A change was merged to openstack/ceilometer: Reinitialize pipeline manager for service restart https://review.openstack.org/39432 | 10:46 |
| openstackgerrit | A change was merged to openstack/ceilometer: Raise error when period with negative value https://review.openstack.org/41926 | 10:46 |
| *** chuckieb has joined #openstack-metering | 10:49 | |
| *** yolanda has joined #openstack-metering | 10:57 | |
| openstackgerrit | Nejc Saje proposed a change to openstack/ceilometer: Storing events via dispatchers https://review.openstack.org/40867 | 11:05 |
| openstackgerrit | Ladislav Smola proposed a change to openstack/python-ceilometerclient: self.auth_token property called as method https://review.openstack.org/42614 | 11:30 |
| lsmola | hello | 11:30 |
| lsmola | can anybody look at this? https://bugs.launchpad.net/python-ceilometerclient/+bug/1213892 | 11:31 |
| lsmola | it breaks the whole ceilometerclient, so I guess this is High priority bug | 11:31 |
| lsmola | jd__, hello | 11:34 |
| lsmola | jd__, could you please look on ^^, thank you very much | 11:34 |
| openstackgerrit | Svetlana Shturm proposed a change to openstack/ceilometer: Close database connection for alembic env https://review.openstack.org/42618 | 11:53 |
| sileht | lsmola, auth_token must be a callable, if we get a str we have a bug in a other part of the client | 11:56 |
| *** dina_belova has joined #openstack-metering | 11:57 | |
| *** nsaje1 has quit IRC | 11:58 | |
| *** dina_belova has quit IRC | 11:58 | |
| lsmola | sileht, ok | 11:58 |
| lsmola | sileht, is there some blueprint that changed that from str to callable? | 11:58 |
| lsmola | sileht, I will check out then, where is the auth token filled | 11:59 |
| sileht | lsmola, https://github.com/openstack/python-ceilometerclient/commit/1772adf0cce19de9ef151c24c482122f9d18507e | 12:00 |
| sileht | lsmola, https://github.com/openstack/python-ceilometerclient/commit/e4348aa3d28f26b354326e056dc26c293963ea7f | 12:00 |
| lsmola | sileht, ok cool, will check this out | 12:01 |
| sileht | lsmola, these two commit have changed the str to callable | 12:01 |
| lsmola | sileht, ok cool, i thing I found the place that needs to be changed in Client initializer | 12:04 |
| lsmola | sileht, thanks | 12:04 |
| sileht | lsmola, welcome | 12:04 |
| *** dina_belova has joined #openstack-metering | 12:07 | |
| lsmola | sileht, ok cool, it works | 12:10 |
| lsmola | sileht, thank you very much | 12:10 |
| *** dina_belova has quit IRC | 12:11 | |
| lsmola | sileht, ok I have abandoned the review and set invalid state to bug, hope that is right | 12:16 |
| lsmola | sileht, fix is on the Horizon side now | 12:16 |
| sileht | lsmola, oh ok thx | 12:16 |
| *** sandywalsh has quit IRC | 12:17 | |
| *** dina_belova has joined #openstack-metering | 12:26 | |
| *** sandywalsh has joined #openstack-metering | 12:30 | |
| *** gordc has joined #openstack-metering | 12:31 | |
| *** dina_belova has quit IRC | 12:32 | |
| sandywalsh | who are the alembic experts? | 12:33 |
| sandywalsh | I keep getting a duplicate column error in my tests | 12:33 |
| sandywalsh | http://paste.openstack.org/show/44512/ | 12:33 |
| sandywalsh | seems to follow the same pattern as the other migrations, but I must be missing something | 12:34 |
| sandywalsh | happens for nearly every test | 12:34 |
| openstackgerrit | A change was merged to openstack/ceilometer: Don't call publisher without sample https://review.openstack.org/39510 | 12:37 |
| openstackgerrit | A change was merged to openstack/ceilometer: Fix typo in 17738166b91 migration https://review.openstack.org/42576 | 12:43 |
| openstackgerrit | A change was merged to openstack/ceilometer: Sync gettextutils from oslo-incubator https://review.openstack.org/42428 | 12:46 |
| *** fnaval_ has quit IRC | 12:51 | |
| *** anteaya has joined #openstack-metering | 12:53 | |
| *** flwang has joined #openstack-metering | 12:57 | |
| flwang | dhellmann: ping | 12:57 |
| dhellmann | flwang: pong | 13:08 |
| *** bpokorny has joined #openstack-metering | 13:09 | |
| flwang | dhellmann: good to see you there. could u pls take a look at this https://review.openstack.org/#/c/38795/ ? jenkins failed because the doc gate, I'm wondering if there is a bug about wsmeext/sphinxext.py | 13:10 |
| flwang | dhellmann: see this log http://logs.openstack.org/95/38795/17/check/gate-ceilometer-docs/c4cf3b8/console.html.gz | 13:11 |
| dhellmann | flwang: I wonder how a breaking change like that got into the repository in the first place? | 13:14 |
| dhellmann | it doesn't look like it is related to your changes | 13:14 |
| dhellmann | flwang: I wonder if it's a change in sphinx? | 13:15 |
| flwang | dhellmann: yep, it's wired. but if i remove the line 142-150 in v2.py (the comment for my method), the error will be gone | 13:15 |
| dhellmann | oh, interesting | 13:16 |
| *** fnaval_ has joined #openstack-metering | 13:16 | |
| dhellmann | so it is related to your change | 13:16 |
| flwang | so it's really strange. can you pls take a look at the comment I added? | 13:16 |
| flwang | I think so. but I don't know why | 13:16 |
| *** shadower_ has joined #openstack-metering | 13:16 | |
| dhellmann | try changing ":returns:" to just "returns" and see if that fixes it | 13:16 |
| dhellmann | I think the wsmeext code is trying to associate a return type with the method | 13:17 |
| flwang | ok, let me try | 13:17 |
| dhellmann | if that method shows up in the documentat, we'll need to rename it with a _ prefix | 13:17 |
| dhellmann | *documentation | 13:17 |
| *** boris-42_ has joined #openstack-metering | 13:18 | |
| flwang | "returns" also doesn't work :( | 13:18 |
| *** fnaval_ has quit IRC | 13:19 | |
| jd__ | terriyu: around? | 13:20 |
| *** boris-42 has quit IRC | 13:20 | |
| *** boris-42_ is now known as boris-42 | 13:20 | |
| dhellmann | flwang: let me try a few things here, hang on | 13:20 |
| flwang | dhellmann: ok, thank you! | 13:20 |
| *** shadower has quit IRC | 13:22 | |
| *** Guest63475 has quit IRC | 13:22 | |
| *** shaneduan has quit IRC | 13:22 | |
| *** fnaval_ has joined #openstack-metering | 13:22 | |
| dhellmann | flwang: I'm building a virtualenv to build the docs, this may take a few minutes | 13:23 |
| flwang | dhellmann: sure, I will be online in the next 3 hours, thanks for your help | 13:24 |
| *** shaneduan has joined #openstack-metering | 13:24 | |
| dhellmann | flwang: renaming the method with a _ prefix fixes the problem | 13:29 |
| dhellmann | flwang: I think we'll want that anyway, because otherwise the method will show up in the documentation, and we don't want that | 13:29 |
| flwang | dhellmann: ok, but we need call it outside | 13:30 |
| dhellmann | outside what? | 13:30 |
| flwang | dhellmann: I mean call it in another class like: metaquery[i.field] = i._get_value_as_type() | 13:32 |
| *** lillie has joined #openstack-metering | 13:32 | |
| *** lillie is now known as Guest75819 | 13:32 | |
| flwang | outside the Query class | 13:32 |
| dhellmann | flwang: ok, I don't think that's a problem. The "public" side of that class is actually the outside of the API, and the "private" side is the API implementation. The method is only used in the API implementation, so it's OK. | 13:32 |
| dhellmann | flwang: to borrow a C++ term, the API controllers are "friends" of Query and can see its implementation details | 13:32 |
| flwang | dhellmann: ok, it make more sense based on your explaination | 13:32 |
| flwang | dhellmann: yep :) | 13:33 |
| dhellmann | flwang: you may want to add a comment explaining why the name is like that, so other reviewers don't object :-) | 13:33 |
| flwang | good, I will fix it and submit a new patch :) | 13:33 |
| dhellmann | flwang: sounds good | 13:34 |
| openstackgerrit | A change was merged to openstack/ceilometer: Fixes failed notification when deleting instance https://review.openstack.org/40098 | 13:35 |
| *** gdusbabek has joined #openstack-metering | 13:37 | |
| openstackgerrit | John Herndon proposed a change to openstack/ceilometer: Add event/trait type queries https://review.openstack.org/41596 | 13:41 |
| openstackgerrit | John Herndon proposed a change to openstack/ceilometer: Add a specialized Event Type model and db table https://review.openstack.org/41316 | 13:41 |
| openstackgerrit | John Herndon proposed a change to openstack/ceilometer: Add a Trait Type model and db table https://review.openstack.org/42407 | 13:41 |
| *** dina_belova has joined #openstack-metering | 13:43 | |
| openstackgerrit | Fei Long Wang proposed a change to openstack/ceilometer: Fixes non-string metadata query issue https://review.openstack.org/38795 | 13:45 |
| *** dina_belova has quit IRC | 13:47 | |
| *** nsaje1 has joined #openstack-metering | 13:50 | |
| *** nsaje1 has quit IRC | 13:50 | |
| *** shadower_ is now known as shadower | 13:52 | |
| *** tasdomas is now known as tasdomas_afk | 13:56 | |
| *** litong has joined #openstack-metering | 14:05 | |
| openstackgerrit | A change was merged to openstack/ceilometer: Api V2 post sample refactoring https://review.openstack.org/39031 | 14:05 |
| openstackgerrit | A change was merged to openstack/ceilometer: message_id is not allowed to be submitted via api https://review.openstack.org/39033 | 14:08 |
| *** annegentle has joined #openstack-metering | 14:10 | |
| *** changbl has quit IRC | 14:22 | |
| *** yolanda has quit IRC | 14:25 | |
| *** nsaje1 has joined #openstack-metering | 14:26 | |
| nsaje1 | sandywalsh: ping | 14:26 |
| *** yolanda has joined #openstack-metering | 14:30 | |
| sandywalsh | nsaje, sec ... meeting | 14:31 |
| *** shaneduan is now known as shaneduan[afk] | 14:32 | |
| *** openstackgerrit has quit IRC | 15:01 | |
| *** openstackgerrit has joined #openstack-metering | 15:02 | |
| *** SergeyLukjanov has joined #openstack-metering | 15:19 | |
| *** changbl has joined #openstack-metering | 15:19 | |
| *** dina_belova has joined #openstack-metering | 15:21 | |
| *** complexmind has joined #openstack-metering | 15:22 | |
| nsaje1 | sandywalsh: np. Can you please check out https://review.openstack.org/#/c/40867/ when you have time? thanks | 15:22 |
| *** nsaje1 has quit IRC | 15:22 | |
| litong | @jd__, ping. | 15:26 |
| openstackgerrit | litong01 proposed a change to openstack/ceilometer: testr should not run in parallel unless all the testcases get fixed. https://review.openstack.org/42670 | 15:33 |
| *** boris-42 has quit IRC | 15:37 | |
| *** boris-42 has joined #openstack-metering | 15:39 | |
| *** mikedawson has joined #openstack-metering | 15:44 | |
| * lsmola is away: Away | 15:52 | |
| *** SergeyLu_ has joined #openstack-metering | 15:54 | |
| *** SergeyLukjanov has quit IRC | 15:57 | |
| *** shaneduan[afk] is now known as shaneduan | 16:02 | |
| openstackgerrit | Fei Long Wang proposed a change to openstack/ceilometer: Fixes non-string metadata query issue https://review.openstack.org/38795 | 16:03 |
| *** alexb_ has joined #openstack-metering | 16:05 | |
| *** alexb_ has quit IRC | 16:12 | |
| *** SergeyLu_ has quit IRC | 16:14 | |
| *** boris-42 has quit IRC | 16:16 | |
| *** tong|2 has joined #openstack-metering | 16:21 | |
| tong|2 | @jd__, ping | 16:23 |
| *** litong has quit IRC | 16:24 | |
| *** mikedawson has quit IRC | 16:28 | |
| *** mikedawson has joined #openstack-metering | 16:28 | |
| *** tong|2 has quit IRC | 16:32 | |
| *** litong has joined #openstack-metering | 16:32 | |
| *** sdake has joined #openstack-metering | 16:33 | |
| openstackgerrit | Fengqian.gao proposed a change to openstack/ceilometer: Raise NotImplementedError if pagination query be called for Hbase https://review.openstack.org/41035 | 16:49 |
| openstackgerrit | Fengqian.gao proposed a change to openstack/ceilometer: Add pagination support for sqlalchemy database https://review.openstack.org/35454 | 16:49 |
| openstackgerrit | Fengqian.gao proposed a change to openstack/ceilometer: Add pagination parameter to the database backends of storage https://review.openstack.org/42582 | 16:49 |
| openstackgerrit | Fengqian.gao proposed a change to openstack/ceilometer: Change pagination query method in mongodb https://review.openstack.org/41869 | 16:49 |
| openstackgerrit | John Herndon proposed a change to openstack/ceilometer: Add event/trait type queries https://review.openstack.org/41596 | 17:10 |
| openstackgerrit | John Herndon proposed a change to openstack/ceilometer: Add a specialized Event Type model and db table https://review.openstack.org/41316 | 17:10 |
| openstackgerrit | John Herndon proposed a change to openstack/ceilometer: Add a Trait Type model and db table https://review.openstack.org/42407 | 17:10 |
| *** jbuckley has quit IRC | 17:26 | |
| *** shaneduan is now known as shaneduan[afk] | 17:29 | |
| *** shaneduan[afk] is now known as shaneduan | 17:30 | |
| *** flwang has quit IRC | 17:43 | |
| *** flwang has joined #openstack-metering | 17:43 | |
| *** dina_belova has quit IRC | 17:51 | |
| flwang | dhellmann: ping | 17:55 |
| flwang | gordc: ping | 17:56 |
| dhellmann | flwang: pong | 17:56 |
| flwang | dhellmann: could you pls revisit https://review.openstack.org/#/c/38795/ ? | 17:56 |
| dhellmann | it's on my list | 17:57 |
| flwang | cool, thanks | 17:57 |
| *** dina_belova has joined #openstack-metering | 18:00 | |
| *** boris-42 has joined #openstack-metering | 18:02 | |
| *** maksimov has joined #openstack-metering | 18:16 | |
| litong | @dhellmann, doug, ping. | 18:24 |
| dhellmann | litong: ping | 18:25 |
| litong | @dhellmann, doug, I reported this bug. | 18:25 |
| litong | https://bugs.launchpad.net/ceilometer/+bug/1213943 | 18:25 |
| litong | which indicate that some of our database test cases can not run in multiple process(thread) env. | 18:26 |
| litong | I had detailed information and why they would fail. | 18:26 |
| litong | I am wondering if you can take a look especially the test cases in /tests/storage/base.py. | 18:27 |
| litong | and see if you think there is a problem. | 18:27 |
| *** SergeyLukjanov has joined #openstack-metering | 18:28 | |
| *** shaneduan is now known as shaneduan[afk] | 18:28 | |
| dhellmann | litong: the tests don't take that long to run now, do they? could we just run them in serial for now? | 18:30 |
| *** shaneduan[afk] is now known as shaneduan | 18:30 | |
| litong | @dhellmann, that is what I proposed. but Julien does not seem to understand the issue. | 18:31 |
| litong | and red marked the fixes. | 18:31 |
| litong | @dhellmann, the problem is that in some cases, the test will finish ok, in some cases, they fail. | 18:32 |
| dhellmann | litong: what is causing the tests to run in parallel now? | 18:32 |
| dhellmann | I guess we don't have --concurrency set anywhere? | 18:32 |
| litong | @dhellmann, testr, if we do not specify concurrency=1, by default, jenkins uses the number of the processors on the machine as the number of the workers. | 18:33 |
| litong | @dhellmann, that is exactly right. | 18:33 |
| dhellmann | litong: do you want to submit a patch to set the currency to 1? | 18:33 |
| litong | https://review.openstack.org/#/c/42670/ | 18:33 |
| litong | that is the patch, | 18:34 |
| dhellmann | oh, I see | 18:34 |
| dhellmann | litong: do you have a link to a log where the tests failed because of this? | 18:35 |
| dhellmann | I understand the issue you've raised, and I think jd__ does too, but he seems to think the tests should pass as they are currently written | 18:35 |
| dhellmann | I don't know which is right. :-) | 18:35 |
| litong | http://logs.openstack.org/23/41123/7/check/gate-ceilometer-python26/4ec27c7/ | 18:35 |
| litong | http://logs.openstack.org/23/41123/7/check/gate-ceilometer-python26/4ec27c7/testr_results.html.gz | 18:35 |
| litong | actually the second one. | 18:36 |
| dhellmann | you should add those links to the bug report, if they aren't already there | 18:36 |
| jd__ | the log shows a problem with the db2 driver, not with the existing code | 18:36 |
| dhellmann | ah, interesting | 18:37 |
| litong | @jd__, juline, glad you can jump in. | 18:37 |
| dhellmann | so this is only a problem for that driver? | 18:37 |
| jd__ | indeed, I do undertand the problem, I'm just waiting for a proof it exists | 18:37 |
| litong | that was not because of the db2 impl. | 18:37 |
| litong | that code is the same as mongodb. | 18:37 |
| litong | as I stated, these test cases use same database and use same data, but prepare_data insert same data multiple times. | 18:37 |
| jd__ | litong: oh clearly it's not, especially considering MongoDB uses a different database for each test | 18:37 |
| litong | thus the results is not safe. | 18:38 |
| jd__ | and things like AttributeError: 'datetime.timedelta' object has no attribute 'total_seconds' don't seem to indicate a concurrency problem at first sight | 18:38 |
| litong | @jd__, are you saying each test case has its own database instance? | 18:38 |
| jd__ | litong: yes | 18:38 |
| dhellmann | each test case, or each test run? | 18:38 |
| litong | @jd__, timedelta one, that is a different problem. | 18:38 |
| jd__ | dhellmann: each test case | 18:38 |
| *** yolanda has quit IRC | 18:38 | |
| dhellmann | I see run-tests.sh starting mongo, does the base class create the unique db? | 18:39 |
| jd__ | dhellmann: yes | 18:39 |
| jd__ | this has been reworked lately by boris-42 IIRC | 18:39 |
| dhellmann | ok, then I wonder if there's a problem with the way the db2 driver does that? | 18:39 |
| jd__ | that may be indeed | 18:39 |
| jd__ | we have Jenkins ran hundred of times the test so far, and we had 0 concurrency issues like litong describes | 18:39 |
| dhellmann | yeah | 18:39 |
| litong | @jd__, I did not know each test case uses a different database. | 18:40 |
| litong | if that is the case indeed, then probably in my test case, I am missing something, so that one database was shared. | 18:40 |
| dhellmann | litong: I think I'm going to have to side with jd__ on this. If there *is* some sort of issue, it sounds like it is in the db2 driver and should be fixed there. Do you see these test failures reliably? | 18:40 |
| jd__ | :) | 18:40 |
| litong | @jd__, where do we have code to ensure that each test case has its own instance? | 18:41 |
| litong | ah, crap, could be in the fake database connection? | 18:41 |
| litong | I think I saw something fishy. | 18:41 |
| jd__ | litong: grep MongoDBFakeConnectionUrl | 18:41 |
| jd__ | ceilometer.tests.db | 18:41 |
| litong | ok, that should be it, in that case, then it is not a problem. but db2 driver does not use the fakeConnectionurl. so all test cases point to the same database | 18:42 |
| litong | thus concurrency problem. | 18:42 |
| litong | ok, let me change that, thanks for your time and explain. | 18:43 |
| litong | @jd__, @dhellmann, the timedelta problem is a different problem. | 18:44 |
| jd__ | I guessed so :) | 18:45 |
| litong | @jd__, I've marked the bug as invalid. | 18:46 |
| dhellmann | \o/ | 18:46 |
| litong | thanks for your time. | 18:46 |
| gordc | jd__, sent you an email. we can discuss here if it's easier. | 18:46 |
| *** d34dh0r53 has quit IRC | 18:49 | |
| jd__ | I replied, I'm actually taking time off, it's late here :) | 18:49 |
| gordc | jd__: i was going to say :) sync up with you tomorrow | 18:50 |
| *** herndon has joined #openstack-metering | 19:00 | |
| *** maksimov has quit IRC | 19:03 | |
| openstackgerrit | gordon chung proposed a change to stackforge/pycadf: update cadf spec to support new data model https://review.openstack.org/42712 | 19:12 |
| openstackgerrit | gordon chung proposed a change to stackforge/pycadf: add event to CADF_EVENT https://review.openstack.org/42714 | 19:20 |
| openstackgerrit | Svetlana Shturm proposed a change to openstack/ceilometer: Fix wrong UniqueConstraint name https://review.openstack.org/42715 | 19:21 |
| openstackgerrit | Svetlana Shturm proposed a change to openstack/ceilometer: Extra indexes cleanup https://review.openstack.org/42716 | 19:27 |
| *** alexb_ has joined #openstack-metering | 19:27 | |
| openstackgerrit | Svetlana Shturm proposed a change to openstack/ceilometer: Fix wrong UniqueConstraint name https://review.openstack.org/42715 | 19:29 |
| *** evanjfraser has joined #openstack-metering | 19:42 | |
| *** tasdomas_afk is now known as tasdomas | 19:50 | |
| *** evanjfraser has quit IRC | 19:51 | |
| *** sandywalsh has quit IRC | 19:53 | |
| boris-42 | jd__ hi | 19:58 |
| *** complexmind has quit IRC | 20:01 | |
| *** sandywalsh has joined #openstack-metering | 20:06 | |
| *** sandywalsh has quit IRC | 20:23 | |
| *** yjiang5_ is now known as yjiang5 | 20:29 | |
| *** evanjfraser has joined #openstack-metering | 20:29 | |
| openstackgerrit | litong01 proposed a change to openstack/ceilometer: db2 support https://review.openstack.org/41123 | 20:33 |
| *** sandywalsh has joined #openstack-metering | 20:36 | |
| openstackgerrit | A change was merged to stackforge/pycadf: add event to CADF_EVENT https://review.openstack.org/42714 | 20:38 |
| *** evanjfraser has quit IRC | 20:50 | |
| *** evanjfraser has joined #openstack-metering | 20:51 | |
| *** evanjfraser has quit IRC | 20:51 | |
| *** litong has quit IRC | 21:07 | |
| *** SergeyLukjanov has quit IRC | 21:11 | |
| *** gordc has quit IRC | 21:12 | |
| *** boris-42 has quit IRC | 21:18 | |
| *** dina_belova has quit IRC | 21:23 | |
| *** tasdomas is now known as tasdomas_afk | 21:39 | |
| *** evanjfraser has joined #openstack-metering | 21:39 | |
| *** bpokorny has quit IRC | 21:58 | |
| *** maksimov has joined #openstack-metering | 22:08 | |
| *** evanjfraser_ has joined #openstack-metering | 22:20 | |
| *** evanjfraser has quit IRC | 22:20 | |
| *** dina_belova has joined #openstack-metering | 22:24 | |
| *** changbl has quit IRC | 22:24 | |
| *** evanjfraser_ has quit IRC | 22:27 | |
| *** dina_belova has quit IRC | 22:29 | |
| *** dina_belova has joined #openstack-metering | 22:34 | |
| *** chuckieb|2 has joined #openstack-metering | 22:39 | |
| *** dina_belova has quit IRC | 22:39 | |
| *** chuckieb has quit IRC | 22:42 | |
| *** swann has quit IRC | 22:49 | |
| *** swann has joined #openstack-metering | 22:50 | |
| *** fnaval_ has quit IRC | 23:17 | |
| *** sandywalsh has quit IRC | 23:34 | |
| *** dina_belova has joined #openstack-metering | 23:35 | |
| *** changbl has joined #openstack-metering | 23:36 | |
| *** herndon has quit IRC | 23:38 | |
| *** dina_belova has quit IRC | 23:40 | |
| *** sandywalsh has joined #openstack-metering | 23:49 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!