| *** mhen_ is now known as mhen | 01:18 | |
| pdeore | #startmeeting glance | 14:00 |
|---|---|---|
| opendevmeet | Meeting started Thu May 16 14:00:50 2024 UTC and is due to finish in 60 minutes. The chair is pdeore. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'glance' | 14:00 |
| pdeore | #topic roll call | 14:00 |
| pdeore | #link https://etherpad.openstack.org/p/glance-team-meeting-agenda | 14:00 |
| pdeore | o/ | 14:01 |
| dansmith | o/ | 14:01 |
| abhishekk | o/ | 14:01 |
| pdeore | Cyril is on PTO and Mridula is having server connectivity issue | 14:02 |
| pdeore | so let's get started | 14:02 |
| pdeore | #topic release/periodic jobs updates | 14:02 |
| pdeore | We are in m1 week and as we discussed in last meeting , we have tagged m1 today | 14:03 |
| pdeore | #link https://review.opendev.org/c/openstack/releases/+/919813 | 14:03 |
| pdeore | glanceclient 4.6.0 is released | 14:03 |
| pdeore | moving to periodic jobs updates | 14:04 |
| pdeore | all tips jobs failing since we recently shifted those from ubuntu focal to jammy | 14:04 |
| pdeore | #link https://zuul.opendev.org/t/openstack/builds?project=openstack%2Fglance&project=openstack%2Fglance_store&project=openstack%2Fpython-glanceclient&pipeline=periodic | 14:04 |
| pdeore | I have submitted a patch to replace all tips jobs from py38/39 to py310 | 14:05 |
| pdeore | #link https://review.opendev.org/c/openstack/glance/+/919817 | 14:05 |
| pdeore | Kindly please have a look | 14:05 |
| abhishek_ | ack, so does jammy have support for higher version of python? | 14:06 |
| dansmith | we're running 3.12 jobs on bookworm right now with external python | 14:06 |
| pdeore | yes, jammy provides support for 310 & 311 | 14:06 |
| abhishek_ | i mean shall we move it to 311 or is it good to keep it 310 | 14:06 |
| dansmith | glance needs to be working on 3.12 coverage for sure, | 14:07 |
| dansmith | because 3.12 breaks a lot of things and the sooner we know about them the better | 14:07 |
| abhishek_ | that reminds me we have non voting job for 3.12 which is failing | 14:07 |
| dansmith | so I think shooting for that and not worrying about 3.11 is probably best if doable | 14:07 |
| dansmith | abhishek_: right that's why :) | 14:07 |
| abhishek_ | makes sense | 14:07 |
| dansmith | I just fixed nova's unit and functional for 3.12 yesterday and we're making them voting to avoid regressing | 14:07 |
| abhishek_ | agree to go for 312 | 14:07 |
| pdeore | ok, I will update the patch | 14:08 |
| abhishek_ | we need to add functional 312 for glance as well | 14:08 |
| abhishek_ | ack, and please add non voting functional py312 job for glance as well | 14:09 |
| dansmith | abhishek_: are you asking me or pdeore ? | 14:09 |
| pdeore | ack | 14:09 |
| abhishek_ | pdeore | 14:09 |
| dansmith | sweet :) | 14:10 |
| pdeore | :) | 14:10 |
| abhishek_ | I will ask you about NFS :D | 14:10 |
| dansmith | pdeore: https://review.opendev.org/c/openstack/nova/+/919767/6/.zuul.yaml#54 | 14:10 |
| pdeore | dansmith, thanks ! :) | 14:10 |
| dansmith | one other thing about jobs | 14:11 |
| dansmith | we may want to turn on OCaaS for some glance jobs: https://review.opendev.org/c/openstack/nova/+/919738/1 | 14:11 |
| dansmith | it's been proposed against devstack for years, just merged | 14:11 |
| dansmith | saves 5m off a devstack run, which makes the jobs that much quicker | 14:12 |
| dansmith | I would also recommend using it locally :) | 14:12 |
| abhishek_ | ohh so couple of days you were talking about this in nova channel | 14:12 |
| dansmith | yes | 14:12 |
| abhishek_ | ++, will use it in local as well | 14:12 |
| abhishek_ | thank you! | 14:13 |
| pdeore | ack, thanks | 14:13 |
| pdeore | shall we move to next topic? | 14:14 |
| abhishek_ | yep | 14:16 |
| pdeore | ok, moving ahead | 14:16 |
| pdeore | #link Important Review | 14:16 |
| pdeore | so we need one more +2 on deprecate metadata-encryption-key - #link https://review.opendev.org/c/openstack/glance-specs/+/916178 | 14:16 |
| pdeore | there are already active reviews on Image encryption spec #link https://review.opendev.org/c/openstack/glance-specs/+/915726 | 14:17 |
| abhishek_ | I have few questions on NFS improvement part | 14:17 |
| pdeore | abhishek_, you wanted to discuss more on NFS spec ? #link https://review.opendev.org/c/openstack/glance-specs/+/917284 | 14:17 |
| abhishek_ | yes | 14:18 |
| abhishek_ | So question is for dansmith | 14:18 |
| abhishek_ | regarding your marking file suggestion | 14:18 |
| abhishek_ | In glance we have access to local path | 14:18 |
| abhishek_ | and if we provided marker file there, even if mount is not reachable the path will be always accessible right | 14:19 |
| dansmith | well the idea is to put the marker file in/under the mount so you know if it's mounted or not | 14:19 |
| dansmith | and you never auto-create it of course | 14:19 |
| abhishek_ | under the mount means on nfs share path? | 14:20 |
| abhishek_ | ip:/nfs/glance | 14:20 |
| dansmith | right, so: | 14:21 |
| dansmith | if you mount ip:/nfs/glance on /var/lib/glance then you put the marker file in /var/lib/glance/.glance | 14:21 |
| dansmith | if it's mounted then the file will be there, if it's not, it won't | 14:21 |
| abhishek_ | Ok, got it now, I need to test it | 14:21 |
| dansmith | do people usually mount /glance or /glance/images? I was assuming the latter so it would be better under there | 14:22 |
| abhishek_ | over /glance/images | 14:22 |
| abhishek_ | I have provided sample PoC for healthcheck implementation | 14:22 |
| dansmith | right, so I'd actually put it inside images, then since that's the data directory and the one you definitely have to have mounted | 14:22 |
| abhishek_ | https://review.opendev.org/c/openstack/glance/+/919666/1/glance/api/middleware/healthcheck.py | 14:23 |
| dansmith | cool, looks vaguely right from a glance | 14:24 |
| abhishek_ | instead of ismount i think I need to check os.path.exists now | 14:24 |
| dansmith | personally, | 14:24 |
| dansmith | I would make the first case not a warning.. allow them to keep the healthcheck in the paste config all the time, and assume no mount paths means we don't need to check anything and thus -> OK | 14:24 |
| dansmith | i.e. "if you want this to be checked, put path(s) in the list of available_mount_paths" | 14:25 |
| abhishek_ | ack | 14:25 |
| abhishek_ | makes sense | 14:25 |
| abhishek_ | I will test it and modify the spec accordingly | 14:25 |
| dansmith | cool | 14:26 |
| abhishek_ | thank you, we can discuss further once spec is updated | 14:26 |
| abhishek_ | pdeore: we can move ahead | 14:27 |
| pdeore | ack thanks | 14:27 |
| pdeore | so for new location apis patches, we need ack from nova and cinder first, I have requested whoami-rajat as well for reviews | 14:28 |
| pdeore | #link https://review.opendev.org/q/topic:%22New-Location-Apis%22+project:openstack/glance | 14:28 |
| pdeore | dansmith, kindly please have a look on these, specially I wanted your opinion on the new glance-manage : hash calculation command | 14:30 |
| dansmith | pdeore: so to be totally honest, I'm a bit burned out by all the back and forth on this | 14:30 |
| dansmith | lots of "it's totally ready" and then still finding some low-hanging stuff | 14:31 |
| dansmith | I've got a lot of other stuff on my plate, so I think I will wait until some others say it's really ready for review | 14:31 |
| dansmith | hopefully sooner than later, so we don't end up with a crunch at the end | 14:32 |
| dansmith | if there's some specific question I can look at that, | 14:32 |
| dansmith | so if the glance-manage thing is an open question, please point me directly and I'll go look | 14:32 |
| pdeore | yeah i can totally understand this .. | 14:33 |
| abhishek_ | I will have a look, but I think better to re-verify all the comments once again and check for regression | 14:33 |
| pdeore | so regarding glance-manage, I'm using list api to fetch all the active images without hash, | 14:34 |
| pdeore | so will that be ok or there should be new db api ? | 14:35 |
| dansmith | glance-manage needs to work during upgrade when the API might be offline, right? | 14:35 |
| dansmith | since glance-manage has access directly to the DB it can just list the images itself no? | 14:36 |
| pdeore | hmm yeah | 14:36 |
| dansmith | also, people generally need to run those commands without keystone credentials, from scripts and such | 14:37 |
| pdeore | I will update patch accordingly | 14:37 |
| dansmith | there are some times where it's unavoidable (nova-manage sometimes needs to talk to placement, for example) but it's better to avoid it if possible, and I think it is here | 14:38 |
| pdeore | yeah right | 14:39 |
| pdeore | Thanks I will update the patch along with the doc part as well | 14:40 |
| dansmith | cool | 14:40 |
| pdeore | that's it from me for today | 14:41 |
| pdeore | let's move to open discussions | 14:41 |
| pdeore | #topic Open Discussions | 14:41 |
| pdeore | anyone has anything else to highlight ? | 14:42 |
| abhishek_ | Nothing from me, thank you dansmith for suggestions on PoC | 14:42 |
| abhishek_ | So is it better to add it in oslo.middleware or keep it in glance only? | 14:42 |
| dansmith | idk, either way.. probably useful to others | 14:44 |
| dansmith | especially the way you wrote it | 14:44 |
| dansmith | i.e. list of actual paths | 14:44 |
| abhishek_ | ack | 14:44 |
| pdeore | any other comments or we can close the meeting ? | 14:46 |
| abhishek_ | thank you! | 14:46 |
| abhishek_ | o/~ | 14:46 |
| pdeore | Thanks for joining !! | 14:46 |
| pdeore | #endmeeting | 14:47 |
| opendevmeet | Meeting ended Thu May 16 14:47:00 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:47 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/glance/2024/glance.2024-05-16-14.00.html | 14:47 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/glance/2024/glance.2024-05-16-14.00.txt | 14:47 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/glance/2024/glance.2024-05-16-14.00.log.html | 14:47 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!