*** hemna3 is now known as hemna | 07:38 | |
yasufum | Hi team | 08:00 |
---|---|---|
manpreetk | h5 | 08:00 |
ueha | hi | 08:00 |
manpreetk | Hi | 08:01 |
takahashi-tsc | hi | 08:02 |
yasufum | #startmeeting tacker | 08:02 |
opendevmeet | Meeting started Tue Dec 21 08:02:55 2021 UTC and is due to finish in 60 minutes. The chair is yasufum. Information about MeetBot at http://wiki.debian.org/MeetBot. | 08:02 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 08:02 |
opendevmeet | The meeting name has been set to 'tacker' | 08:02 |
esto-aln | hello | 08:04 |
edagawa_kc | hi | 08:04 |
yasufum | there are three topics proposed on the ehterpad today. | 08:05 |
yasufum | #link https://etherpad.opendev.org/p/tacker-meeting | 08:05 |
yasufum | Before going to go to the first topic, I'd like to talk two things. | 08:06 |
yasufum | One is about spec freeze. | 08:06 |
yasufum | I think most of us are going to be off next week. | 08:07 |
yasufum | although several patches are still remained under reviewing. | 08:08 |
yasufum | I think we don't need to hurry for fixing these patches actually. | 08:09 |
yasufum | So, I'd like to suggest to update the date of the deadline which was agreed as "best effort" target at the previous vPTG. | 08:10 |
yasufum | I think mid of the next week is reasonable, but want to here your comment. | 08:11 |
yasufum | What do you think? | 08:11 |
ueha | +1, I think it will be difficult at the end of this month, because there are some specs I have commented that have not been revised. | 08:13 |
takahashi-tsc | mid of next month? (Jan.) | 08:13 |
yasufum | yes, you are correct | 08:13 |
takahashi-tsc | OK, +1. | 08:14 |
manpreetk | +1 | 08:14 |
yasufum | thx | 08:15 |
yasufum | Considering many of us may going to go to return in the second week next month, I think 21th Fri is appropriate for the date. | 08:17 |
ueha | I agree | 08:19 |
yasufum | I'll update the date on etherpad of the previous vPTG. | 08:19 |
yasufum | #link https://etherpad.opendev.org/p/tacker-yoga-ptg | 08:19 |
takahashi-tsc | sure, thanks | 08:19 |
yasufum | Please give your comment if you have any other alternative or comment. Thanks. | 08:19 |
yasufum | thanks | 08:20 |
yasufum | My second topic is just an announcement. I'd skip IRC meeting next week | 08:22 |
yasufum | and have the next one on 11th Jan. | 08:22 |
yasufum | I'll also share it on ML later. Thanks. | 08:22 |
yasufum | If no one has a comment for the schedule, go to the first topic on etherpad. | 08:24 |
yasufum | good | 08:24 |
yasufum | ueha: can you share your topic about the current issue on gate test. | 08:25 |
ueha | Sure, | 08:25 |
ueha | currently, sol-kubernetes job often has another error. | 08:25 |
ueha | An error occurred because the processing of the heal entire did not complete in the time waiting for COMPLETED in test. | 08:26 |
ueha | This error can be resolved by increasing the timeout period during the heal entire test. | 08:26 |
ueha | I have posted the patch, so could you review it? https://review.opendev.org/c/openstack/tacker/+/822285 | 08:27 |
ueha | That's all from my side, any comment? | 08:27 |
yasufum | thanks | 08:30 |
yasufum | We have several unclear timeouts which depend on infra... | 08:31 |
yasufum | It's hard to find such a failure in general | 08:32 |
yasufum | and we cannot this update fixes the issue completely. | 08:33 |
yasufum | But I think it is doable for the current situation. | 08:34 |
yasufum | It has been tested several times and looks OK. | 08:34 |
yasufum | ueha: many thanks for your effort! I'd give +2. | 08:35 |
ueha | Thanks for comments! :) | 08:35 |
takahashi-tsc | I'll also give +2, thanks | 08:36 |
ueha | takahashi-tsc: thanks! | 08:36 |
yasufum | ok, go to the next topic from edagawa_kc. | 08:38 |
edagawa_kc | Sure. | 08:38 |
edagawa_kc | Currently there is one topic I would like to confirm here regarding my spec. | 08:39 |
edagawa_kc | The detail has been described in the etherpad. | 08:39 |
edagawa_kc | The main point is whether we need returning "400 bad request" case or not during an API response. | 08:39 |
edagawa_kc | In my thought, there is no problem to only use paged case, but I would like to ask your opinions. | 08:39 |
edagawa_kc | That's all from my side. | 08:42 |
yasufum | thanks | 08:44 |
yasufum | any comment? | 08:44 |
yasufum | nothing? | 08:49 |
ueha | +1, I think it is better because there is no need to add non-SOL compliant parameter. | 08:50 |
yasufum | I think it depends on usecases although I don't suppose to opposite to your idea. | 08:51 |
yasufum | Anyway, it might be OK as ueha commented. | 08:54 |
takahashi-tsc | I think no usecase which should expect 400 bad error... but I think we should explain that GET API's default behavior is paging in API reference. | 08:54 |
edagawa_kc | I see, I understand your opinions are the same as mine. Also I will add description of this behaviour into API reference. | 08:55 |
edagawa_kc | I will start updating my spec, too. Thanks. | 08:56 |
yasufum | thanks | 08:57 |
yasufum | seems we can go to the next topic. | 08:57 |
yasufum | esto-aln: can you share your topic? | 08:58 |
esto-aln | sure | 08:58 |
esto-aln | Basically, we have a proposal to change the directory structure under: tacker/samples/mgmt_driver | 08:59 |
esto-aln | the proposal details are in the etherpad | 08:59 |
esto-aln | We have some concern points, which I discussed from line 147. | 08:59 |
esto-aln | Firstly, we would like to know whether you agree that we create sub-directory under mgmt_driver? | 09:01 |
esto-aln | Secondly, if there are concerns if we relocate the kubernetes files to "tacker/samples/mgmt_driver/kubernetes" directory.. | 09:01 |
esto-aln | will it work properly if relocated? | 09:02 |
esto-aln | and are there other items which needs to be updated as an effect of the change in directory? | 09:02 |
esto-aln | That's all from my side. | 09:03 |
yasufum | I think this change has no impact other than docs because we don't have any tests for the samples. | 09:03 |
yasufum | ueha: What do you think? | 09:03 |
ueha | The kubernetesMgmtDriver's python file may also need some changes | 09:04 |
yasufum | Is it because for resolving path dependency or so in the code itself? | 09:06 |
ueha | https://opendev.org/openstack/tacker/src/branch/master/samples/mgmt_driver/kubernetes_mgmt.py#L441 | 09:06 |
ueha | https://opendev.org/openstack/tacker/src/branch/master/samples/mgmt_driver/kubespray/kubespray_mgmt.py#L277 | 09:07 |
ueha | It seems that the path hard coded above. | 09:07 |
yasufum | It must be one of bad habits honestly :) | 09:10 |
esto-aln | Yes, I think we have the same recognition.. but is it okay whether Ueha-san can update such source codes? | 09:10 |
ueha | You can fix it with the same patch. | 09:11 |
yasufum | Anyway, I think it is not so critical if we need just to update such a path. | 09:11 |
esto-aln | I understand.. anyway, please support us.. please do check if the changes are enough or need to have more files to update.. | 09:12 |
esto-aln | yasufum: yes, I think so, too... but just in case, there might be some issue.. we would like to consult Ueha-san. | 09:13 |
yasufum | ueha: Do you mean update two thing, for kubernetes and ansible, with a single patch? | 09:13 |
ueha | Sure, when a patch is posted, test it internally. | 09:13 |
esto-aln | you mean, Ueha-san will test internally, right? | 09:15 |
ueha | yasufum: Yes, I think it should be update same patch. | 09:15 |
ueha | esto-aln: yes, may test by me or my colleague | 09:16 |
esto-aln | okay, many thanks, Ueha-san! | 09:16 |
esto-aln | any other comments? | 09:19 |
yasufum | ueha: I don't agree basically because we should make a change topic by topic without any reason should do so. | 09:19 |
yasufum | although it is a tiny change | 09:20 |
yasufum | to minimize if we have some troubles possibly | 09:20 |
yasufum | Could I confirm the reason why it's better to update with one patch? | 09:21 |
takahashi-tsc | Do you mean we should create a patch "change k8s sample directory" and a patch "add ansible driver" separetely? | 09:21 |
yasufum | takahashi-tsc: Yes. I think it's better to test the change of directly without adding ansible driver basically. | 09:23 |
ueha | It doesn't mean much, but I thought it would be bad if the function doesn't work which is hit by one patch. | 09:23 |
ueha | I think it would be good if they could be merged with other patches in order and with no gap in time. | 09:23 |
yasufum | I understand the changes does not affect on gate tests, just want to clarify the reason. | 09:25 |
yasufum | the reason why we should make the changes with one patch. | 09:25 |
ueha | "should" is different. I'm sorry for my poor English expression. | 09:27 |
yasufum | ueha: OK, I understand you just considering about the time to be merged. | 09:27 |
yasufum | In my conclusion, I think one patch is OK if changes for currenrt mgmt driver is just two lines or so, and ueha surely tests the patch from esto-aln. | 09:30 |
esto-aln | okay, I understand the conclusion. | 09:31 |
esto-aln | We will proceed based on community's conclusion. | 09:32 |
yasufum | Thanks for discussion all! | 09:32 |
esto-aln | Thank you | 09:33 |
yasufum | any other comment? | 09:35 |
yasufum | good | 09:36 |
yasufum | done all for today | 09:36 |
yasufum | Thank you all for joining. | 09:37 |
takahashi-tsc | Thanks | 09:37 |
esto-aln | Thank you | 09:37 |
ueha | thanks, bye | 09:37 |
edagawa_kc | Bye | 09:38 |
yasufum | Have a nice holiday! | 09:38 |
manpreetk | Thanks bye | 09:38 |
esto-aln | bye | 09:38 |
yasufum | Bye | 09:38 |
yasufum | #endmeeting | 09:38 |
opendevmeet | Meeting ended Tue Dec 21 09:38:23 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 09:38 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/tacker/2021/tacker.2021-12-21-08.02.html | 09:38 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/tacker/2021/tacker.2021-12-21-08.02.txt | 09:38 |
opendevmeet | Log: https://meetings.opendev.org/meetings/tacker/2021/tacker.2021-12-21-08.02.log.html | 09:38 |
*** gmann is now known as gmann_afk | 19:51 | |
martial | Hello friends, mostly hanging out today, hoping everyone will have/is having pleasant holidays | 21:06 |
b1airo | o/ martial | 21:06 |
b1airo | likewise, lurking | 21:06 |
janders | hey martial b1airo | 21:06 |
janders | Happy Christmas and all the best in the New Year | 21:07 |
b1airo | thanks janders , you too | 21:07 |
martial | same :) | 21:10 |
b1airo | hey janders , you been involved in any Open Innovation Labs Residencies while at Redhat...? | 21:18 |
janders | b1airo no | 21:19 |
janders | do you have any experience with this concept? | 21:21 |
b1airo | just getting the upsell from the local consulting team :-) | 21:23 |
janders | right! :) | 21:23 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!