*** akekane_ is now known as abhishekk | 06:41 | |
*** rpittau|afk is now known as rpittau | 07:47 | |
abhishekk | #startmeeting glance | 14:00 |
---|---|---|
opendevmeet | Meeting started Thu Aug 5 14:00:40 2021 UTC and is due to finish in 60 minutes. The chair is abhishekk. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
opendevmeet | The meeting name has been set to 'glance' | 14:00 |
abhishekk | #topic roll call | 14:00 |
redrobot | \o | 14:00 |
abhishekk | #link https://etherpad.openstack.org/p/glance-team-meeting-agenda | 14:00 |
abhishekk | o/ | 14:00 |
abhishekk | lets wait couple of minutes for others | 14:01 |
rosmaita | o/ | 14:02 |
croelandt | o/ | 14:02 |
dansmith | o./ | 14:02 |
abhishekk | cool, lets start | 14:02 |
jokke_ | o/ | 14:02 |
abhishekk | #topic release/periodic jobs update | 14:02 |
abhishekk | M3 4 weeks from now | 14:02 |
abhishekk | glance_store xena release - 2 weeks from now | 14:02 |
abhishekk | We don't have much from store side now | 14:03 |
abhishekk | Periodic jobs 2 time outs this week, trying to figure out the problem but don't have much time atm | 14:03 |
abhishekk | #topic M3 targets | 14:03 |
abhishekk | Policy refactoring work | 14:04 |
abhishekk | Finally things are rolling | 14:04 |
abhishekk | thanks to croelandt and lbragstad for helping us to move ahead | 14:04 |
abhishekk | You will get total overview of refactoring work from below sheet | 14:04 |
abhishekk | #link https://docs.google.com/spreadsheets/d/1SWBq0CsHw8jofHxmOG8QeZEX6veDE4eU0QHItOu8uQs/edit?pli=1#gid=73773117 | 14:05 |
abhishekk | Still long way to go.. | 14:05 |
abhishekk | Any questions related to policy work? | 14:05 |
dansmith | yep, but a lot of momentum already I think | 14:05 |
abhishekk | ++ | 14:05 |
abhishekk | I take that as know, moving ahead | 14:06 |
abhishekk | Cache API | 14:06 |
abhishekk | we have new revision up for glance side work | 14:06 |
abhishekk | #link https://review.opendev.org/c/openstack/glance/+/792022 | 14:07 |
abhishekk | Need to have close look on this, will do it today after the meeting | 14:07 |
abhishekk | Pending is now client side work | 14:07 |
jokke_ | I have a client patch up as well | 14:08 |
abhishekk | So all reviewers spend some time to review | 14:08 |
abhishekk | That is still PoC but you can refer it | 14:08 |
jokke_ | #link https://review.opendev.org/c/openstack/python-glanceclient/+/800172 | 14:08 |
abhishekk | ack | 14:09 |
jokke_ | yes, please provide feedback and lets move those on | 14:09 |
abhishekk | Noted, will look asap | 14:09 |
abhishekk | Metadef project persona integration | 14:09 |
abhishekk | #link https://review.opendev.org/c/openstack/glance/+/798700/ | 14:10 |
abhishekk | I think these are also in good shape | 14:10 |
abhishekk | Moving to next topic | 14:10 |
abhishekk | #topic Wallaby backports discussion (croelandt) | 14:10 |
abhishekk | 14:10 | |
abhishekk | croelandt, stage is yours | 14:11 |
abhishekk | Ok, let me explain this on his behalf | 14:11 |
croelandt | yeah | 14:11 |
croelandt | sorry | 14:11 |
abhishekk | no problem, do you want me to continue ? | 14:12 |
croelandt | so we have those two patches we want to backport | 14:12 |
croelandt | the first one applies almost cleanly, the second one applies cleanly | 14:12 |
* abhishekk go ahead | 14:12 | |
croelandt | but only the second one is suitable for backport, since the first one is a new feature | 14:12 |
croelandt | *but* if we only apply the second one (a bugfix), then it conflicts like crazy | 14:12 |
croelandt | and to fix the conflicts I'm gonna have to basically rewrite the first one | 14:12 |
croelandt | so I'd be tempted to backport both or none of them | 14:13 |
croelandt | erf, Rajat isn't here, he knows more about the patches content than I do :/ | 14:13 |
jokke_ | What are we talking about? Any references? | 14:13 |
abhishekk | #link https://review.opendev.org/c/openstack/glance_store/+/782200 | 14:13 |
abhishekk | this is 1st one | 14:13 |
abhishekk | #link https://review.opendev.org/c/openstack/glance_store/+/796577 | 14:13 |
abhishekk | this is actual bug fix | 14:13 |
croelandt | yep :) | 14:13 |
rosmaita | so why exactly is 782200 a new feature? | 14:14 |
abhishekk | I think if the bug is important then we can backport supporting patches as well | 14:14 |
dansmith | the first one changes our interaction with cinder quite a bit right? | 14:14 |
croelandt | rosmaita: it uses the new attachment support from Cinder | 14:15 |
croelandt | which is also a required backport in Cinder from what I understand | 14:15 |
rosmaita | "new" == since Pike or something | 14:15 |
abhishekk | dansmith, right | 14:15 |
dansmith | seems a bit risky to me, despite that | 14:16 |
rosmaita | we already merged that change to wallaby, and broke grenade | 14:16 |
dansmith | the microversion it requires is much newer than pike, if I recall | 14:16 |
rosmaita | (grenade is fixed now) | 14:16 |
rosmaita | astually, that was a different break, forget what i said | 14:16 |
jokke_ | I do agree, it's really not something that aligns with our stable policy for backport | 14:16 |
croelandt | jokke_: I'm fine with not doing the backport :;) | 14:17 |
abhishekk | I think I lost the connection | 14:17 |
abhishekk | ? | 14:17 |
croelandt | but keep in mind that if we want ot backport https://review.opendev.org/c/openstack/glance_store/+/796577 | 14:17 |
jokke_ | abhishekk: nope, at least tx happens still ;) | 14:17 |
croelandt | we basically are going to reimplement half of #782200 | 14:17 |
dansmith | well, that patch also seems like you could argue it's too chunky for a backport | 14:18 |
dansmith | if it's something that didn't work before, it's a feature despite having a bug number attached :) | 14:18 |
croelandt | hehe | 14:18 |
abhishekk | :D | 14:18 |
abhishekk | croelandt, I think its better not to backport it upstream | 14:18 |
croelandt | we'll tell the distro maintainers to do their own backports then | 14:18 |
dansmith | ++ | 14:18 |
croelandt | which is fine since I'm the distro maintainer *cough* | 14:19 |
abhishekk | :P | 14:19 |
abhishekk | anything else you have to add here ? | 14:19 |
dansmith | for us downstream, it's fine to take that risk and do the testing to ensure it.. we know what cinder people have, what order they will apply the updates, what their general config can be | 14:19 |
dansmith | but upstream it seems too risky, IMHO | 14:19 |
jokke_ | dansmith: I tend to agree, also if we just want to block writing qcow into cinder nfs, I don't see how that is related with the new attachment API. | 14:19 |
dansmith | jokke_: agree | 14:19 |
croelandt | yeah, I'm fine with not backporting upstream | 14:19 |
jokke_ | Maybe if this is important enought to backport it needs independent fix rather than backport | 14:20 |
dansmith | or some mitigation thing | 14:20 |
croelandt | jokke_: yeah, we need to figure out whether we want it fixed in W | 14:20 |
abhishekk | ack, that we can discuss on ML we already have | 14:20 |
abhishekk | moving ahead | 14:21 |
abhishekk | #topic FIPS CI Jobs (alee/dmendiza) | 14:21 |
redrobot | \o | 14:21 |
* redrobot is aka dmendiza | 14:21 | |
jokke_ | it's kind of one of these things like "It's not gonna work and we can tell the user so early or they can find it out down the line" :P | 14:21 |
abhishekk | redrobot, go ahead | 14:21 |
redrobot | Yeah, so Ade and I are working on an effort to test all of OpenStack on FIPS-enabled systems | 14:22 |
redrobot | to that end we've been adding CI jobs to every project to run existing test suites in nodes which have had FIPS turned on | 14:22 |
redrobot | #link https://review.opendev.org/c/openstack/glance/+/790536 | 14:22 |
redrobot | ^^ is the one for glance | 14:22 |
abhishekk | Can we do it early in next cycle? | 14:22 |
redrobot | Up to you :) Obviously we'd rather do it sooner rather than later. | 14:23 |
abhishekk | Frankly speaking we are just 4 weeks away from 3rd and final milestone and I am not eager to increase gate timeline | 14:23 |
abhishekk | We can start step by step rather adding bunch of jobs at a time | 14:23 |
rosmaita | maybe make it a periodic job | 14:23 |
jokke_ | I think there was patch proposed by Ade already that was green, so it's not like we're gonna need tons of work in Glance side to make it work. I think Brian had some concerns about it 'though | 14:24 |
redrobot | It's the same patch I linked | 14:24 |
abhishekk | jokke_, in latest patch I think Ade has added 4 to 5 jobs | 14:24 |
redrobot | Yeah, I think the initial revisions were not running enough of the test suite to find failures. | 14:25 |
abhishekk | #link https://review.opendev.org/c/openstack/glance/+/790536 | 14:25 |
rosmaita | my concern was that it added code so you could run mysql/postgres in fips mode, but since we weren't actually using either of those, was hard to see that it worked | 14:25 |
jokke_ | But looking the job list we have in the gate, I'd tend to lean towards periodic job too rather than gating job. At least we keep eye on them weekly so it wouldn't be something that gets ignored for years there | 14:25 |
redrobot | yeah, we had to patch mysql/postgres because there's a test script in your repo that installs it and sets up tables and what not. | 14:25 |
rosmaita | yeah, it would unblock ade and redrobot from finishing, and hten we could make it a regular job later | 14:26 |
abhishekk | to start with periodic job sounds better idea | 14:26 |
* redrobot needs to freshen up on periodic jobs | 14:26 | |
redrobot | Yeah, that sounds like a good start for us | 14:26 |
jokke_ | I'm kind of leaning towards Does it ever need to be regular gating job | 14:26 |
jokke_ | ? | 14:26 |
dansmith | periodic seems fine to me for this | 14:27 |
redrobot | jokke_ we would prefer that, yes. It would be better to prevent regressions on every patch once we get it working | 14:27 |
redrobot | to be clear, we would prefer a gating job rather than a periodic | 14:27 |
redrobot | but we're OK with starting with a periodic job until it is passing consistenly | 14:27 |
jokke_ | redrobot: I do undertand the concern, the reality just is, our gate job list is hot mess already consuming incredible amounts of resources | 14:27 |
abhishekk | right and at this moment I don't want to increase that time line | 14:28 |
redrobot | understood. I'll discuss with Ade, but we'll plan for periodic jobs for now for sure | 14:28 |
dansmith | could we make one of our regular jobs fipsified once we get it all fixed? | 14:28 |
dansmith | meaning, is there any harm to other stuff we need to do? | 14:28 |
jokke_ | Obviously if it looks like we're breaking it in weekly basis it would make sense to be gating job, but if it keeps going green month after month in periodic jobs, do we really need that resource hog there | 14:29 |
dansmith | if not, once we get it ready, we can just convert one of our special jobs like the cinder multistore one or something to use fips | 14:29 |
jokke_ | ? | 14:29 |
rosmaita | dansmith: that sounds like a good idea, kill 2 birds with one stone | 14:29 |
abhishekk | I think we can, but early in next cycle ? | 14:29 |
redrobot | dansmith yeah, interesting idea. In theory once we iron out any FIPS issues we find it should be pretty much the same tests. | 14:29 |
rosmaita | abhishekk: ++ | 14:29 |
dansmith | for sure, after it's stable and after we're through any deadlines | 14:29 |
dansmith | redrobot: cool, then let's aim for periodic now, and integrated later | 14:30 |
jokke_ | dansmith: that would make much more sense | 14:30 |
abhishekk | works for me | 14:30 |
redrobot | sounds good, y'all, thanks | 14:30 |
abhishekk | cool | 14:30 |
abhishekk | redrobot, let me know if you need any help in periodic jobs | 14:30 |
redrobot | abhishekk will do, thanks! | 14:30 |
abhishekk | moving to Open discussion | 14:31 |
rosmaita | redrobot: you may want to make it also experimental so you can run it on demand | 14:31 |
rosmaita | at least while you are developing it | 14:31 |
abhishekk | ++ | 14:31 |
abhishekk | #topic Open discussion | 14:31 |
jokke_ | #link https://review.opendev.org/c/openstack/glance/+/802868 | 14:32 |
abhishekk | Should we have additional weekly sync up for policy refactoring ??? | 14:32 |
jokke_ | #link https://review.opendev.org/c/openstack/glance/+/802867 | 14:32 |
jokke_ | low potential for merge conflicts and quick reviews, thanks! ^^ | 14:32 |
abhishekk | I think we are getting close to 3rd milestone and we should sync to discuss blocker, progress once in a week > | 14:33 |
abhishekk | I will try to get lbragstad's time for the same | 14:33 |
jokke_ | #link https://review.opendev.org/c/openstack/glance_store/+/800227 quick bugfix for glance_store too before we hit final release deadline | 14:34 |
dansmith | abhishekk: I guess it feels like we have good momentum right now, and not many blockers | 14:34 |
dansmith | so I don't feel like we _need_ the sync up, but if you do, then I'm happy to participate | 14:34 |
abhishekk | dansmith, may be we should revisit this next week | 14:34 |
abhishekk | ack, thank you | 14:35 |
dansmith | sounds good | 14:35 |
jokke_ | #link https://review.opendev.org/c/openstack/glance/+/800101 rosmaita smcginnis stable could do with some love too | 14:35 |
abhishekk | cool, that's it from me today | 14:36 |
jokke_ | #link https://review.opendev.org/c/openstack/glance/+/800100 abhishekk rosmaita smcginnis another backport | 14:36 |
abhishekk | jokke_, ack | 14:36 |
rosmaita | :) | 14:36 |
abhishekk | If nothing else then we can wrap up and utilize remaining time in reviews :D | 14:37 |
pdeore | #link https://review.opendev.org/c/openstack/glance/+/775968 pending for reviews since quite a long time :) | 14:37 |
abhishekk | ack | 14:38 |
jokke_ | Also as the glance_store release deadline is the first one we're going to hit, would be great to make sure we get everything in soon what we want in there | 14:38 |
abhishekk | I take that as no | 14:38 |
jokke_ | just my 2 cents in your local currency | 14:39 |
abhishekk | jokke_, ack, thank you | 14:39 |
abhishekk | Thank you all, have a nice weekend | 14:39 |
rosmaita | ty | 14:39 |
jokke_ | TY | 14:39 |
abhishekk | Ty | 14:39 |
pdeore | Thanks!! | 14:39 |
abhishekk | #endmeeting | 14:40 |
opendevmeet | Meeting ended Thu Aug 5 14:40:01 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:40 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/glance/2021/glance.2021-08-05-14.00.html | 14:40 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/glance/2021/glance.2021-08-05-14.00.txt | 14:40 |
opendevmeet | Log: https://meetings.opendev.org/meetings/glance/2021/glance.2021-08-05-14.00.log.html | 14:40 |
*** akekane_ is now known as abhishekk | 16:01 | |
*** rpittau is now known as rpittau|afk | 16:41 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!