| mtaylor | salv-orlando_: thanks for the catch | 00:00 |
|---|---|---|
| salv-orlando_ | ok | 00:00 |
| *** dolphm has joined #openstack-meeting | 00:04 | |
| *** somik has quit IRC | 00:06 | |
| *** troytoman is now known as troytoman-away | 00:11 | |
| *** jakedahn_ has joined #openstack-meeting | 00:11 | |
| *** danwent has joined #openstack-meeting | 00:11 | |
| *** jakedahn has quit IRC | 00:14 | |
| *** jakedahn_ is now known as jakedahn | 00:14 | |
| *** ewindisch has quit IRC | 00:15 | |
| *** ewindisch_ is now known as ewindisch | 00:15 | |
| *** pballand has left #openstack-meeting | 00:17 | |
| *** salv-orlando_ has quit IRC | 00:17 | |
| *** dolphm has quit IRC | 00:22 | |
| *** salv-orlando_ has joined #openstack-meeting | 00:31 | |
| salv-orlando_ | anyone from the Cisco Openstack team online? | 00:31 |
| *** bhall has joined #openstack-meeting | 00:41 | |
| *** bhall has quit IRC | 00:42 | |
| *** bhall has joined #openstack-meeting | 00:42 | |
| *** bhall has quit IRC | 00:42 | |
| *** bhall has joined #openstack-meeting | 00:42 | |
| danwent | salv-orlando_: maybe ping netstack list? | 00:42 |
| salv-orlando_ | maybe... | 00:43 |
| danwent | salv-orlando_: btw, bhall will be pinging you witha quick patch for the API errors branch. there was an issue with a test he just recently added. | 00:43 |
| bhall | privmsg'd and emailed | 00:43 |
| danwent | thx | 00:43 |
| *** debo-os has joined #openstack-meeting | 00:51 | |
| *** sleepsonthefloo has quit IRC | 01:13 | |
| *** novas0x2a|laptop has quit IRC | 01:17 | |
| *** ohnoimdead has quit IRC | 01:21 | |
| *** gyee has quit IRC | 01:29 | |
| *** zns has joined #openstack-meeting | 01:30 | |
| *** bhall has quit IRC | 01:31 | |
| *** zns has quit IRC | 01:33 | |
| *** andrewbogott has quit IRC | 01:35 | |
| *** sarob has quit IRC | 01:35 | |
| *** jakedahn has quit IRC | 01:38 | |
| mtaylor | danwent: hey ... https://review.openstack.org/3386 | 01:42 |
| mtaylor | salv-orlando_: ^^ | 01:42 |
| salv-orlando_ | I'm here | 01:42 |
| mtaylor | danwent: that above is needed for your patch in to python-quantumclient to work | 01:42 |
| *** bencherian has joined #openstack-meeting | 01:43 | |
| mtaylor | (we're close to getting this bad boy done - isn't this fun?) | 01:43 |
| danwent | indeed :) | 01:43 |
| danwent | mtaylor, so lxml needs to be added to quantum-server but not quantum-client? | 01:43 |
| mtaylor | danwent: yeah - quantum-server uses it | 01:43 |
| salv-orlando_ | mtaylor: thanks we recently fixed lxml in pip-requires, but that patch should have really fixed setup.py as well | 01:43 |
| danwent | good catch, btw, i think we added it to pip-requires | 01:43 |
| mtaylor | salv-orlando_: ++ | 01:44 |
| danwent | will approve right now, hopefully salv can also click +2 | 01:44 |
| danwent | :) | 01:44 |
| mtaylor | thanks! | 01:44 |
| danwent | beat me to it salv! | 01:44 |
| danwent | ok, should be getting merged | 01:45 |
| danwent | mtaylor: did you see review from salv-orlando_ about tissue? | 01:46 |
| danwent | after that, i think we're ready to push the client split | 01:46 |
| mtaylor | yes - I'll have a new update for that in a sec | 01:47 |
| danwent | thx | 01:47 |
| salv-orlando_ | I'm still here for a +2 | 01:47 |
| *** zns has joined #openstack-meeting | 01:49 | |
| danwent | btw, salv, thanks for catching the tissue thing… missed that | 01:50 |
| salv-orlando_ | danwent: something to worry about (probably) unit tests in master fail with PLUGIN_DIR=quantum/plugins/openvswitch | 01:50 |
| salv-orlando_ | AttributeError: 'module' object has not attribute 'NotImplementedError' | 01:50 |
| danwent | hmm… i am seeing them pass for me. | 01:51 |
| danwent | can you send me more detailed output? | 01:51 |
| danwent | what is your HEAD? | 01:51 |
| danwent | I wonder if this is an issue that brad was seeing with different versions of library for http errors. | 01:52 |
| danwent | thanks for the heads up | 01:52 |
| salv-orlando_ | sure... I'll login into IRC from the PC were I do development | 01:52 |
| danwent | you can just email me as well. | 01:53 |
| danwent | also, might be helpful to know what distro + version you are running. | 01:53 |
| *** another-salv has joined #openstack-meeting | 01:54 | |
| danwent | two salvs! | 01:54 |
| another-salv | danwent: | 01:54 |
| another-salv | File "./quantum/plugins/openvswitch/run_tests.py", line 41, in <module> | 01:54 |
| another-salv | from quantum.api.api_common import OperationalStatus | 01:54 |
| another-salv | File "/home/salvatore/git/quantum-new/quantum/api/__init__.py", line 28, in <module> | 01:54 |
| another-salv | from quantum.api import attachments | 01:54 |
| another-salv | File "/home/salvatore/git/quantum-new/quantum/api/attachments.py", line 18, in <module> | 01:54 |
| another-salv | from quantum.api import api_common as common | 01:54 |
| another-salv | File "/home/salvatore/git/quantum-new/quantum/api/api_common.py", line 23, in <module> | 01:54 |
| another-salv | from quantum.api import faults | 01:54 |
| another-salv | File "/home/salvatore/git/quantum-new/quantum/api/faults.py", line 32, in <module> | 01:54 |
| another-salv | class QuantumHTTPError(webob.exc.HTTPClientError): | 01:54 |
| another-salv | File "/home/salvatore/git/quantum-new/quantum/api/faults.py", line 68, in QuantumHTTPError | 01:55 |
| another-salv | 'explanation': _NOTIMPLEMENTED_EXPL | 01:55 |
| *** oubiwann has quit IRC | 01:55 | |
| another-salv | last commit is:1dd7766dcadcd52ee0e9cd6c6e44362368167611 | 01:55 |
| danwent | hrm, are you running on natty or something else? | 01:56 |
| salv-orlando_ | oneiric | 01:56 |
| salv-orlando_ | what puzzles me is that this error appears only when PLUGIN_DIR points to openvswitch | 01:57 |
| danwent | strange… | 01:57 |
| danwent | I wonder if your install has an outdate version of the "common" code that is in the client repo? | 01:57 |
| danwent | if you reinstall from pip-requires, i'm guessing you'll get updated client code? | 01:58 |
| salv-orlando_ | uhm that might explain | 01:58 |
| danwent | i think it probably only happens when you run OVS, because the code that imports NotImplemented is an extension. Just a guess though. | 02:00 |
| salv-orlando_ | I found the issue... it was me being dumb. Basically I though the venv needed to be recreated, and I therefore deleted it before running the test. But since I'm dumb, I deleted .quantum-venv, which was the "old" folder, and not .venv | 02:01 |
| salv-orlando_ | still I don't get why it did not happen when running "standard" unit tests... | 02:01 |
| *** novas0x2a|laptop has joined #openstack-meeting | 02:02 | |
| *** novas0x2a|laptop has quit IRC | 02:02 | |
| *** anotherjesse has joined #openstack-meeting | 02:02 | |
| *** novas0x2a|laptop has joined #openstack-meeting | 02:02 | |
| *** dprince has joined #openstack-meeting | 02:03 | |
| danwent | after a quick glance, i don't either | 02:03 |
| salv-orlando_ | I think that it is not a high priority issue though. | 02:04 |
| danwent | yes, and a small fix we can push to milestone-proposed tomorrow | 02:06 |
| salv-orlando_ | I'll wait a few more minutes for the updated split patch from mtaylor. | 02:06 |
| danwent | ok, in the mean time, what are your thoughts on my comment about the filtering branch returning a pair, vs. using a dict passed by reference. | 02:06 |
| salv-orlando_ | Have a look here: https://review.openstack.org/#change,2968 | 02:07 |
| *** another-salv has left #openstack-meeting | 02:07 | |
| danwent | ah, sorry missed that. | 02:07 |
| salv-orlando_ | The last changeset basically leverages the fact the filters are passed by reference. | 02:08 |
| danwent | yup, see that. thanks. | 02:08 |
| salv-orlando_ | Should any problem arise with that while I'm sleeping, the previous changeset returns the pair | 02:08 |
| danwent | :) | 02:08 |
| mtaylor | salv-orlando_, danwent: so I'm hitting the NotImplemented thing above when I try to test the quantumclient code now | 02:08 |
| *** dprince has quit IRC | 02:08 | |
| danwent | mtaylor, do you need to update the version of quantum-client pulled in? | 02:09 |
| mtaylor | danwent: this is in the quantumclient tests :) | 02:09 |
| danwent | haey salv, why don't you head to bed. I can get bhall or someone else to be the second +2 once monty and I figure this out. | 02:09 |
| *** reed has joined #openstack-meeting | 02:09 | |
| mtaylor | danwent: if you grab your latest patch and run "tox -v -r -epy27" ... you'll see the same traceback from above | 02:10 |
| salv-orlando_ | Yes, that might be better. Talk to you in a bit, guys! | 02:10 |
| danwent | mtaylor: i think this is pretty easy. brad made a change to quantum.client after you pulled your repo, I think | 02:10 |
| danwent | let me check | 02:10 |
| mtaylor | danwent: ah, cool | 02:10 |
| *** salv-orlando_ has quit IRC | 02:11 | |
| danwent | https://github.com/openstack/quantum/commit/975d5a996bcf3e28c572e1c34274c4eab04b46e6 | 02:11 |
| danwent | changes to quantum/client/__init__.py and quantum/common/exceptions.py | 02:11 |
| danwent | repo change race condition :) | 02:12 |
| danwent | I should have noticed it during review | 02:12 |
| danwent | i can propose | 02:12 |
| mtaylor | danwent: ah - well, I think also I'm testing quantumclient against a non-split quantum server - which is also probably fun | 02:13 |
| *** dendro-afk is now known as dendrobates | 02:13 | |
| *** reed has quit IRC | 02:18 | |
| mtaylor | danwent: https://review.openstack.org/3387 | 02:19 |
| danwent | sure | 02:20 |
| mtaylor | danwent: w00t! | 02:20 |
| danwent | you win | 02:20 |
| mtaylor | danwent: if that patch goes in, then your patch can go in | 02:20 |
| danwent | ok, are you going to push both? | 02:20 |
| mtaylor | and then quantumclient is good | 02:20 |
| danwent | sweetness | 02:20 |
| mtaylor | well- you review mine, I'll review yours :) | 02:21 |
| *** martine has joined #openstack-meeting | 02:21 | |
| danwent | :) | 02:21 |
| mtaylor | oh - you know - I betcha we're going to need to squash them ... I don't think the first one will pass jenkins | 02:23 |
| mtaylor | https://review.openstack.org/#change,3379 | 02:25 |
| mtaylor | welp. I was wrong. :) | 02:26 |
| * mtaylor is going to learn to have more patience | 02:26 | |
| danwent | I was rushing to beat you to push a squashed commit, then i didn't need it :P | 02:27 |
| danwent | btw, tox always hangs when I run it (either that, or I am impatient) | 02:28 |
| mtaylor | ah - next time try tox -v | 02:29 |
| mtaylor | that's verbose mode | 02:29 |
| mtaylor | it's likely that you're impatient - it's building a virtualenv | 02:29 |
| *** jdurgin has quit IRC | 02:30 | |
| danwent | right you are :) | 02:30 |
| *** reed has joined #openstack-meeting | 02:31 | |
| danwent | btw, were you going to push something in response to Salv's question about using tissue? | 02:31 |
| mtaylor | danwent: ok. I have updated the patch (removing tissue for now, we don't have it fully working yet - we'll submit a patch to actually use it) | 02:33 |
| danwent | ok, sounds good. I will run tests, then +2 it. Will try to track down someone else to +2 as well, but it has been pretty heavily reviewed, so if needed, I can just approve it directly. | 02:34 |
| mtaylor | k. it is a big patch though - a proper 2 +2's is proably nice | 02:34 |
| danwent | indeed :) | 02:35 |
| *** heckj has quit IRC | 02:35 | |
| danwent | I want bhall to look through it anyway, so that should do | 02:35 |
| danwent | you should head out… i imagine it is getting late for you | 02:35 |
| *** bencherian has quit IRC | 02:38 | |
| *** dendrobates is now known as dendro-afk | 02:40 | |
| danwent | mtaylor: ok, i +2'd and ping brad | 02:42 |
| *** dendro-afk is now known as dendrobates | 02:42 | |
| mtaylor | danwent: don't shoot me - I found one more issue. sigh | 02:48 |
| *** bencherian has joined #openstack-meeting | 02:49 | |
| danwent | ok, no worries, it hasn't gone in yet. | 02:49 |
| danwent | and even if we find issues tomorrow, we can cherry-pick them to milestone-proposed | 02:49 |
| *** bencherian has quit IRC | 02:49 | |
| mtaylor | danwent: somehow I thought that we needed pep8 >= 0.6.3 - everything else is == 0.6.1 | 02:49 |
| mtaylor | danwent: check it one more time :( | 02:50 |
| danwent | our setup.py required >=0.6.1, not ==, does that matter? | 02:52 |
| *** martine has quit IRC | 02:52 | |
| mtaylor | danwent: not today - 0.6.1 is the latest | 02:52 |
| *** martine has joined #openstack-meeting | 02:52 | |
| danwent | k | 02:52 |
| mtaylor | danwent: (this is the issue - there is no 0.6.3 :) ) | 02:53 |
| danwent | ah, got it | 02:53 |
| danwent | ok, bhall said he will do second review tonight. unless there's a huge issue, I will push and assume we can fix any minor issues as part of milestone-proposed. | 02:54 |
| *** anotherjesse has quit IRC | 02:57 | |
| *** edgarmagana has quit IRC | 03:01 | |
| mtaylor | sweet | 03:05 |
| danwent | mtaylor: heading out for food. will be online later if anything pops up. thanks again for all your help getting quantum integrated into the CI process. | 03:06 |
| mtaylor | danwent: my pleasure! I have a few more non-urgent patches coming | 03:07 |
| *** adjohn has quit IRC | 03:07 | |
| danwent | great. ttyl | 03:08 |
| *** danwent has quit IRC | 03:08 | |
| *** novas0x2a|laptop has quit IRC | 03:09 | |
| *** jog0 has quit IRC | 03:16 | |
| *** edconzel_ has quit IRC | 03:26 | |
| *** martine has quit IRC | 03:29 | |
| *** debo-os has quit IRC | 03:41 | |
| *** martine has joined #openstack-meeting | 03:44 | |
| *** AlanClark has quit IRC | 03:45 | |
| *** martine has quit IRC | 03:50 | |
| *** danwent has joined #openstack-meeting | 03:50 | |
| *** ewindisch_ has joined #openstack-meeting | 03:54 | |
| *** mjfork has quit IRC | 03:57 | |
| *** sarob has joined #openstack-meeting | 04:07 | |
| *** oubiwann has joined #openstack-meeting | 04:19 | |
| *** sarob_ has joined #openstack-meeting | 04:24 | |
| *** sleepsonthefloo has joined #openstack-meeting | 04:26 | |
| *** sarob has quit IRC | 04:27 | |
| *** oubiwann has quit IRC | 04:40 | |
| *** sleepsonthefloo has quit IRC | 04:49 | |
| *** sleepsonthefloo has joined #openstack-meeting | 04:49 | |
| *** davlap has quit IRC | 06:01 | |
| *** reed has quit IRC | 06:03 | |
| *** zns1 has joined #openstack-meeting | 06:49 | |
| *** ewindisch_ has quit IRC | 06:50 | |
| *** ewindisch_ has joined #openstack-meeting | 06:50 | |
| *** zns has quit IRC | 06:51 | |
| *** byeager has quit IRC | 06:51 | |
| *** sleepsonthefloo has quit IRC | 06:57 | |
| *** novas0x2a|laptop has joined #openstack-meeting | 07:00 | |
| *** GheRivero has quit IRC | 07:04 | |
| *** ghe_ has joined #openstack-meeting | 07:04 | |
| *** yehudasa has quit IRC | 07:16 | |
| *** yehudasa has joined #openstack-meeting | 07:30 | |
| *** zns1 has quit IRC | 07:31 | |
| *** bmcconne has quit IRC | 07:38 | |
| *** salv-orlando has joined #openstack-meeting | 08:26 | |
| *** novas0x2a|lapto1 has joined #openstack-meeting | 08:29 | |
| *** novas0x2a|laptop has quit IRC | 08:30 | |
| *** ghe_ is now known as GheRivero | 08:39 | |
| *** zigo has joined #openstack-meeting | 09:10 | |
| *** derekh has joined #openstack-meeting | 09:39 | |
| *** ewindisch_ has quit IRC | 09:47 | |
| *** derekh has quit IRC | 09:47 | |
| *** derekh has joined #openstack-meeting | 09:47 | |
| *** danwent has quit IRC | 09:48 | |
| *** darraghb has joined #openstack-meeting | 09:54 | |
| *** ewindisch_ has joined #openstack-meeting | 10:05 | |
| *** novas0x2a|lapto1 has quit IRC | 10:30 | |
| *** novas0x2a|laptop has joined #openstack-meeting | 10:30 | |
| *** uvirtbot` has joined #openstack-meeting | 10:36 | |
| *** uvirtbot has quit IRC | 10:36 | |
| *** salv-orlando has left #openstack-meeting | 11:19 | |
| *** mjfork has joined #openstack-meeting | 11:51 | |
| *** mjfork has left #openstack-meeting | 11:56 | |
| *** GheRivero has quit IRC | 11:58 | |
| *** ghe_ has joined #openstack-meeting | 11:58 | |
| *** zigo has quit IRC | 12:00 | |
| *** novas0x2a|laptop has quit IRC | 12:30 | |
| *** markvoelker has joined #openstack-meeting | 12:38 | |
| *** dprince has joined #openstack-meeting | 13:12 | |
| *** zigo has joined #openstack-meeting | 13:28 | |
| *** dolphm has joined #openstack-meeting | 13:34 | |
| *** novas0x2a|laptop has joined #openstack-meeting | 13:34 | |
| *** derekh has quit IRC | 13:40 | |
| *** derekh has joined #openstack-meeting | 13:53 | |
| *** mattray has joined #openstack-meeting | 13:56 | |
| *** dolphm has quit IRC | 13:59 | |
| *** dolphm has joined #openstack-meeting | 13:59 | |
| *** dolphm has quit IRC | 14:03 | |
| *** ayoung has joined #openstack-meeting | 14:31 | |
| *** rkukura has joined #openstack-meeting | 14:36 | |
| *** rkukura has left #openstack-meeting | 14:36 | |
| *** dendrobates is now known as dendro-afk | 14:52 | |
| *** deshantm has joined #openstack-meeting | 14:54 | |
| *** mahmoh has joined #openstack-meeting | 15:00 | |
| *** mestery has joined #openstack-meeting | 15:04 | |
| *** mestery_ has quit IRC | 15:07 | |
| *** davlap has joined #openstack-meeting | 15:08 | |
| *** AlanClark has joined #openstack-meeting | 15:08 | |
| *** GheRivero has joined #openstack-meeting | 15:18 | |
| *** mattray1 has joined #openstack-meeting | 15:20 | |
| *** mattray has quit IRC | 15:21 | |
| *** reed has joined #openstack-meeting | 15:29 | |
| *** novas0x2a|laptop has quit IRC | 15:30 | |
| *** hggdh has quit IRC | 15:32 | |
| *** ke4qqq has quit IRC | 15:33 | |
| *** zigo has quit IRC | 15:33 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!