| *** xyang1 has quit IRC | 00:05 | |
| *** markvoelker has quit IRC | 00:35 | |
| *** markvoelker has joined #openstack-meeting-cp | 00:47 | |
| *** gouthamr has quit IRC | 01:05 | |
| *** diablo_rojo has quit IRC | 01:48 | |
| *** nhelgeson has quit IRC | 02:05 | |
| *** yamahata has quit IRC | 02:52 | |
| *** iyamahat_ has quit IRC | 02:52 | |
| *** yamahata has joined #openstack-meeting-cp | 03:17 | |
| *** pacol has joined #openstack-meeting-cp | 04:15 | |
| *** pacol has quit IRC | 04:16 | |
| *** felipemonteiro has joined #openstack-meeting-cp | 04:27 | |
| *** felipemonteiro has quit IRC | 05:01 | |
| *** gouthamr has joined #openstack-meeting-cp | 05:34 | |
| *** gouthamr has quit IRC | 07:22 | |
| *** markvoelker has quit IRC | 08:08 | |
| *** edmondsw has joined #openstack-meeting-cp | 09:16 | |
| *** edmondsw has quit IRC | 09:20 | |
| *** markvoelker has joined #openstack-meeting-cp | 10:09 | |
| *** iyamahat has joined #openstack-meeting-cp | 10:39 | |
| *** yamahata has quit IRC | 10:41 | |
| *** iyamahat has quit IRC | 10:42 | |
| *** markvoelker has quit IRC | 10:43 | |
| *** markvoelker has joined #openstack-meeting-cp | 11:41 | |
| *** markvoelker has quit IRC | 12:13 | |
| *** markvoelker has joined #openstack-meeting-cp | 12:32 | |
| *** deep-book-gk_ has joined #openstack-meeting-cp | 12:50 | |
| *** deep-book-gk_ has left #openstack-meeting-cp | 12:52 | |
| *** rarcea has joined #openstack-meeting-cp | 14:06 | |
| *** gouthamr has joined #openstack-meeting-cp | 14:37 | |
| *** felipemonteiro has joined #openstack-meeting-cp | 14:53 | |
| *** iyamahat has joined #openstack-meeting-cp | 14:54 | |
| *** felipemonteiro_ has joined #openstack-meeting-cp | 14:55 | |
| *** felipemonteiro has quit IRC | 14:59 | |
| *** mriedem has joined #openstack-meeting-cp | 15:53 | |
| ildikov | #startmeeting cinder-nova-api-changes | 16:00 |
|---|---|---|
| openstack | Meeting started Thu Jul 13 16:00:09 2017 UTC and is due to finish in 60 minutes. The chair is ildikov. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| *** openstack changes topic to " (Meeting topic: cinder-nova-api-changes)" | 16:00 | |
| openstack | The meeting name has been set to 'cinder_nova_api_changes' | 16:00 |
| ildikov | johnthetubaguy jaypipes e0ne jgriffith hemna mriedem patrickeast smcginnis diablo_rojo xyang1 raj_singh lyarwood jungleboyj stvnoyes | 16:00 |
| stvnoyes | o/ | 16:00 |
| mriedem | o/ | 16:01 |
| jungleboyj | Lurking. In two meetings at the moment. :-) | 16:01 |
| ildikov | let's wait a half minute and then we can start :) | 16:01 |
| smcginnis | Maybe I'm here, maybe I'm not. The world may never know. | 16:02 |
| ildikov | ok, let's dive in | 16:02 |
| ildikov | al the open reviews are here: https://review.openstack.org/#/q/topic:bp/cinder-new-attach-apis | 16:02 |
| ildikov | *all | 16:03 |
| ildikov | Cinder changes are merged | 16:03 |
| ildikov | we're discussing some live_migration related items on the review at the moment | 16:03 |
| stvnoyes | i am going thru matt's comments | 16:03 |
| ildikov | mriedem: stvnoyes: is there anything to discuss here to sort it out quicker? | 16:03 |
| stvnoyes | i think I understand his points | 16:03 |
| stvnoyes | so no need here unless Matt wants to clarify anything\ | 16:04 |
| ildikov | mriedem: is there anything for live_migrate to discuss here? | 16:05 |
| mriedem | i've only gone through the compute manager parts and pointed out 2 issues, | 16:05 |
| mriedem | and as stvnoyes said i think he gets it | 16:05 |
| ildikov | ok, sounds good | 16:05 |
| ildikov | moving on then | 16:06 |
| ildikov | swap_volume is annoyingly close at this point | 16:06 |
| mriedem | yes i'm working on an etherpad of focus areas to send to the ML | 16:07 |
| ildikov | mriedem: sounds great, thank you | 16:07 |
| ildikov | and we have the remove check_detach and attach patches besides the two we mentioned above already | 16:07 |
| ildikov | stvnoyes has Grenade running and started to work on the test already | 16:07 |
| ildikov | stvnoyes: anything we should discuss about that one? | 16:08 |
| stvnoyes | i am looking at the test I am going to do. attach a volume pre, and then detach post. The most obvious place to do that is in cinder resource.sh as that already has code to ssh into the guest to check the volume. anyone see any issues with that? | 16:09 |
| stvnoyes | vs doing it in nova's resource.sh | 16:09 |
| mriedem | i don't think we need to worry about sshing into the guest | 16:09 |
| stvnoyes | so no verification? that will make it simpler. then just attach/detach and see that it works? | 16:10 |
| mriedem | yes | 16:10 |
| stvnoyes | ok | 16:11 |
| mriedem | i think you have to do it in cinder's resource.sh because the cinder upgrade scripts run after the nova ones | 16:11 |
| mriedem | so the nova server instance will be created by the time the cinder resource.sh runs | 16:11 |
| stvnoyes | yep | 16:11 |
| mriedem | ah i see it already boots a server from volume https://github.com/openstack-dev/grenade/blob/master/projects/70_cinder/resources.sh#L122 | 16:11 |
| stvnoyes | yes | 16:12 |
| mriedem | and then on the post upgrade it deletes that server | 16:12 |
| stvnoyes | i i was going to add a volume to that bfv server in cinder | 16:12 |
| mriedem | it already does | 16:13 |
| mriedem | openstack server create --volume $id | 16:13 |
| mriedem | that's why an image isn't specified | 16:13 |
| mriedem | the image is used from the volume in the root disk | 16:13 |
| mriedem | openstack volume create --image $DEFAULT_IMAGE_NAME --size 1 $CINDER_VOL | 16:13 |
| stvnoyes | ok then i'll need to stop the server to detach the boot disk | 16:13 |
| mriedem | well, maybe this already covers what we needed to test | 16:14 |
| mriedem | you can't detach the boot disk i don't think, nova won't let you | 16:14 |
| stvnoyes | but it doesn't do a detach? | 16:14 |
| stvnoyes | the test that is or does that happen when the server is deleted? | 16:14 |
| mriedem | by default delete_on_termination is goign to be False, | 16:15 |
| smcginnis | Yeah, only way to detach a boot disk is to blow away the instance and create a new one. | 16:15 |
| stvnoyes | i was going to add a new volume pre, and then detach it post (on that bfv instance) | 16:15 |
| mriedem | so grenade first deletes the instance and then deletes the volume | 16:15 |
| mriedem | this is where we start dealing with that in the compute on instance delete https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2223 | 16:16 |
| mriedem | so we destroy the guest https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2263 | 16:16 |
| mriedem | we would detach the volume here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2295 | 16:17 |
| mriedem | which is just updating the cinder db state for the volume | 16:17 |
| smcginnis | stvnoyes: If you're looking at doing this with a separate volume (not the boot volume) then that should be fine. | 16:17 |
| mriedem | once that's done we get here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2336 | 16:18 |
| mriedem | bdm.delete_on_termination is False so we don't attempt to delete the volume | 16:18 |
| mriedem | so grenade deletes it | 16:18 |
| mriedem | so we have one flow covered already https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2285-L2296 | 16:18 |
| stvnoyes | I think Matt is saying a detach is implicit in the shutdown code which will get called by delete so we don't need to create a second volume | 16:19 |
| mriedem | the flow we do'nt have covered is the non-bfv case | 16:19 |
| mriedem | where you do | 16:19 |
| mriedem | 1. create server | 16:19 |
| mriedem | 2. create volume | 16:19 |
| mriedem | 3. attach volume on old side | 16:19 |
| mriedem | 4. detach volume on new side | 16:19 |
| mriedem | 5. delete server and volume | 16:19 |
| smcginnis | stvnoyes: Yep. Just if you were saying you wanted to explicitly test it in a test, then that could work with a non-boot vol. But implicitly, it should all get deleted in the end anyway. | 16:19 |
| mriedem | the nova resource script will create a server here https://github.com/openstack-dev/grenade/blob/master/projects/60_nova/resources.sh#L85 | 16:20 |
| mriedem | so we could create a 2nd volume in the cinder resource script to attach to that server | 16:20 |
| mriedem | it wouldn't be a bootable volume | 16:21 |
| mriedem | no ssh | 16:21 |
| mriedem | nothing like that | 16:21 |
| stvnoyes | ok, I got it. I will add something to cover the non-bfv case. I think I can just use the bfv server already in the cinder resource and add a volume to that. Or do you think it's important to add the disk to the nova non-bfv server? | 16:21 |
| mriedem | i think either is fine | 16:22 |
| mriedem | probably easier to contain in the single cinder resource script | 16:22 |
| stvnoyes | agree | 16:22 |
| mriedem | so right before this https://github.com/openstack-dev/grenade/blob/master/projects/70_cinder/resources.sh#L198 | 16:22 |
| mriedem | you'd detach the 2nd volume | 16:22 |
| mriedem | then server delete, then bootable volume delete | 16:22 |
| mriedem | easy peasy | 16:22 |
| ildikov | :) | 16:23 |
| ildikov | are we all in an agreement on this plan? | 16:26 |
| smcginnis | Ship it. | 16:26 |
| ildikov | or any further questions/aspects to discuss? | 16:26 |
| jungleboyj | :-) | 16:26 |
| stvnoyes | i'm good | 16:27 |
| ildikov | ok, sounds good then :) | 16:27 |
| ildikov | mriedem: any hints on who to start to or stop to annoy for reviews or what would be the best strategy to get this whole thing done in Pike? | 16:28 |
| mriedem | i'm working on it | 16:28 |
| ildikov | mriedem: or anything else you see uncovered? | 16:28 |
| mriedem | not right now | 16:28 |
| ildikov | ok, then I think we're good for today unless someone has something to bring up we haven't touched already | 16:29 |
| ildikov | mriedem: let me know if I can do anything to make some progress | 16:29 |
| stvnoyes | thanks all :-) | 16:30 |
| ildikov | mriedem: if I have to test quotas then I might end up testing quotas, just let me know :) | 16:30 |
| jungleboyj | Thanks ildikov | 16:30 |
| *** diablo_rojo has joined #openstack-meeting-cp | 16:31 | |
| ildikov | ok, that's all folks for today then | 16:31 |
| ildikov | thanks everyone! | 16:31 |
| smcginnis | o/ | 16:31 |
| johnthetubaguy | I am hoping I will get chance to look at those reviews! | 16:31 |
| ildikov | we are so very close, so thanks for all the efforts so far and let's make this happen! :) | 16:32 |
| ildikov | johnthetubaguy: hey :) | 16:32 |
| * johnthetubaguy waves | 16:32 | |
| ildikov | johnthetubaguy: I hope everything's good with you, we all missed you! | 16:33 |
| johnthetubaguy | not too bad, still trying to tie down my next OpenStack job, but hoping I am getting there | 16:33 |
| ildikov | johnthetubaguy: I hope for the best! Fingers crossed! | 16:34 |
| ildikov | johnthetubaguy: I guess there's not too much I can help with, but let me know if there would be! | 16:35 |
| ildikov | johnthetubaguy: it would also be great if you could take a look at the remaining reviews | 16:35 |
| johnthetubaguy | yeah, hoping to take a look at those again | 16:36 |
| johnthetubaguy | need to get by eye back in, I suspect | 16:36 |
| ildikov | if you have any questions feel free to ping me anytime | 16:36 |
| ildikov | otherwise the few of us taking care of these babies are very responsive in the reviews | 16:37 |
| ildikov | is there any questions/topics you would want to bring up now? | 16:37 |
| ildikov | I guess that's a no :) | 16:40 |
| ildikov | johnthetubaguy: I hope you checking in means I can say Welcome back! :) | 16:40 |
| ildikov | johnthetubaguy: and I also have my thoughts with you that job hunting goes well! | 16:41 |
| *** gouthamr has quit IRC | 16:41 | |
| *** gouthamr has joined #openstack-meeting-cp | 16:41 | |
| ildikov | alright, that's all for the meeting for today | 16:42 |
| ildikov | see you All next week here the latest! | 16:42 |
| mriedem | bye | 16:42 |
| *** mriedem has left #openstack-meeting-cp | 16:42 | |
| ildikov | #endmeeting | 16:42 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings" | 16:42 | |
| openstack | Meeting ended Thu Jul 13 16:42:41 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:42 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/cinder_nova_api_changes/2017/cinder_nova_api_changes.2017-07-13-16.00.html | 16:42 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/cinder_nova_api_changes/2017/cinder_nova_api_changes.2017-07-13-16.00.txt | 16:42 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/cinder_nova_api_changes/2017/cinder_nova_api_changes.2017-07-13-16.00.log.html | 16:42 |
| smcginnis | Thanks ildikov | 16:42 |
| *** iyamahat has quit IRC | 16:43 | |
| *** felipemonteiro_ has quit IRC | 16:51 | |
| *** iyamahat has joined #openstack-meeting-cp | 17:02 | |
| *** yamahata has joined #openstack-meeting-cp | 17:08 | |
| *** rarcea has quit IRC | 17:14 | |
| *** nhelgeson has joined #openstack-meeting-cp | 17:24 | |
| *** harlowja has quit IRC | 17:27 | |
| *** MarkBaker has quit IRC | 17:46 | |
| *** felipemonteiro has joined #openstack-meeting-cp | 18:03 | |
| *** felipemonteiro_ has joined #openstack-meeting-cp | 18:04 | |
| *** felipemonteiro has quit IRC | 18:08 | |
| *** harlowja has joined #openstack-meeting-cp | 18:54 | |
| *** diablo_rojo has quit IRC | 20:10 | |
| *** harlowja has quit IRC | 20:19 | |
| *** harlowja has joined #openstack-meeting-cp | 20:22 | |
| *** diablo_rojo has joined #openstack-meeting-cp | 20:26 | |
| *** gouthamr has quit IRC | 21:47 | |
| *** gouthamr has joined #openstack-meeting-cp | 21:49 | |
| *** iyamahat has quit IRC | 22:09 | |
| *** iyamahat has joined #openstack-meeting-cp | 22:09 | |
| *** gouthamr has quit IRC | 22:10 | |
| *** felipemonteiro_ has quit IRC | 22:27 | |
| *** iyamahat has quit IRC | 22:46 | |
| *** iyamahat has joined #openstack-meeting-cp | 22:49 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!