Thursday, 2018-10-11

*** yamahata has quit IRC00:40
*** yamahata has joined #openstack-meeting-500:56
*** mjturek has joined #openstack-meeting-500:57
*** slaweq has joined #openstack-meeting-501:11
*** slaweq has quit IRC01:15
*** roman_g has joined #openstack-meeting-504:07
*** skazi has quit IRC04:55
*** slaweq has joined #openstack-meeting-505:11
*** roman_g has quit IRC05:12
*** slaweq has quit IRC05:16
*** skazi has joined #openstack-meeting-505:45
*** lemko has joined #openstack-meeting-505:46
*** dims has quit IRC06:29
*** slaweq has joined #openstack-meeting-506:29
*** jamesgu has joined #openstack-meeting-506:30
*** dims has joined #openstack-meeting-506:33
*** slaweq has quit IRC06:34
*** dims has quit IRC06:38
*** dims has joined #openstack-meeting-506:39
*** slaweq has joined #openstack-meeting-506:41
*** slaweq has quit IRC06:46
*** slaweq has joined #openstack-meeting-506:50
*** roman_g has joined #openstack-meeting-506:50
*** slaweq has quit IRC07:03
*** slaweq has joined #openstack-meeting-507:05
*** ralonsoh has joined #openstack-meeting-507:29
*** roman_g has quit IRC07:47
*** roman_g has joined #openstack-meeting-508:23
*** skazi has quit IRC08:35
*** derekh has joined #openstack-meeting-508:42
*** yamahata has quit IRC08:57
*** skazi has joined #openstack-meeting-509:33
*** derekh has quit IRC12:00
*** derekh has joined #openstack-meeting-512:00
*** yamahata has joined #openstack-meeting-512:47
*** dims has quit IRC13:12
*** dims has joined #openstack-meeting-513:14
*** dims has quit IRC13:19
*** mjturek has joined #openstack-meeting-513:25
*** mjturek has quit IRC13:42
*** mjturek has joined #openstack-meeting-513:45
*** annp_ has joined #openstack-meeting-513:54
*** lujinluo has joined #openstack-meeting-513:56
lujinluo#startmeeting neutron_upgrades14:00
openstackMeeting started Thu Oct 11 14:00:21 2018 UTC and is due to finish in 60 minutes.  The chair is lujinluo. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
*** openstack changes topic to " (Meeting topic: neutron_upgrades)"14:00
openstackThe meeting name has been set to 'neutron_upgrades'14:00
lujinluoo/14:00
ralonsohhi14:00
*** mjturek has quit IRC14:00
lujinluohi ralonsoh!14:00
njohnstono/14:01
lujinluoo/ njohnston14:01
lujinluook, let's get started14:01
lujinluo#topic OVO14:01
*** openstack changes topic to "OVO (Meeting topic: neutron_upgrades)"14:01
lujinluo#link https://review.openstack.org/#/q/topic:bp/adopt-oslo-versioned-objects-for-db+status:open14:01
lujinluo#link https://review.openstack.org/#/c/608198/ NetworkRBAC in neutron/db/db_base_plugin_v2.py14:02
ralonsohI replied to njohnston14:02
ralonsohIMO, is almost almost ready14:03
ralonsohIt will depends on https://review.openstack.org/#/c/609691/14:03
ralonsohthe functional tests14:03
njohnstonjust added +114:04
ralonsohnjohnston thanks!!14:04
lujinluoack. i will review it today14:04
lujinluo#link https://review.openstack.org/#/c/608628/ Use NetworkRBAC OVO in neutron/db/external_net_db.py14:05
ralonsohfunctional tests in https://review.openstack.org/#/c/609692/14:05
ralonsohaddressed all comments in last commit14:06
*** mjturek has joined #openstack-meeting-514:07
njohnstonSorry I have not been active on that review; I'll try to take a pass later14:07
lujinluoawesome. by taking a quick look at the codes, i think they are generally fine. i will review it today as well.14:08
lujinluo(me neither. will try to get back on track this week, sorry :(14:08
lujinluonext two are functional tests of the previous two patches14:09
lujinluo#link https://review.openstack.org/#/c/609691/ functional tests of #link https://review.openstack.org/#/c/608198/14:09
lujinluo#link https://review.openstack.org/#/c/609692/ functional tests of #link https://review.openstack.org/#/c/608628/14:10
lujinluoI will review the four of them within this week!14:10
ralonsohthanks! no rush14:10
lujinluothanks for the great work ralonsoh!14:10
ralonsohlujinluo: no problem, that was a suggestion made by njohnston14:11
*** TuanVu has joined #openstack-meeting-514:11
lujinluothank you! njohnston14:11
* njohnston is very appreciative of ralonsoh's great work14:11
lujinluonext is port binding #link https://review.openstack.org/#/c/544206/14:11
lujinluoi addressed most of the comments from hongbin and manjeet, except for 2 left, which i do not think i will revise the codes, but i need to run some local tests to justify the changes14:12
lujinluoi will finish it this week too. then reviews are welcome :)14:13
njohnstonI do have one question14:13
*** TuanVu has quit IRC14:13
njohnstonYou turn on new engine facade in this change14:14
*** TuanVu has joined #openstack-meeting-514:14
lujinluoyes14:14
njohnstonThis is pre-empting the engine-facade section in the agenda I realize, but I wonder if that should be a separate change?  Or does it positively affect the functioning of what you're changing here?14:15
lujinluoyes, the changes made in that patch requires using new engine facade. let me find an example here14:16
lujinluohttps://review.openstack.org/#/c/544206/24/neutron/plugins/ml2/plugin.py@39914:18
njohnstonok14:19
*** TuanVu has quit IRC14:19
lujinluothis update() inside _process_port_binding() then __create_port_db() is inside a writer transaction14:19
njohnstonyep, that makes sense14:20
njohnstonok, cool, I am good to move on :-)14:20
lujinluogood!14:20
*** TuanVu has joined #openstack-meeting-514:20
lujinluolet's move to the next one14:20
lujinluo#link https://review.openstack.org/#/c/608638/14:21
lujinluoUse NetworkRBAC OVO in tests/unit/db/test_db_base_plugin_v2.py14:21
ralonsohlast comment already addressed14:21
*** dims has joined #openstack-meeting-514:22
lujinluogood job! and i will review it right after the meeting14:23
lujinluothank you so much for your work ralonsoh!!14:24
lujinluonext is the retry decorator changes in neutron-lib #link https://review.openstack.org/#/c/605365/14:24
lujinluoi replied to michel's concern but he has not replied yet14:25
njohnstonHe's right about it, but it is a transitional accomodation14:26
njohnstonwith a finite lifetime14:26
lujinluoyeah14:26
lujinluowill wait for a while before approaching him on irc14:27
lujinluo#link https://review.openstack.org/#/c/602497/ use ovo for L3HARouterAgentPortBinding in l3_hamode14:27
lujinluofor this patch, does zuul hang somewhere? or did i miss anything14:28
njohnstonhmm14:29
lujinluolet me try if recheck would help or not14:30
njohnstonit's parent has not merged https://review.openstack.org/#/c/607076/14:30
njohnstonso that is to be expected14:30
lujinluooh, got it14:31
lujinluothanks for the recheck14:31
njohnston:-)14:31
lujinluo#link https://review.openstack.org/#/c/507772/ network OVO14:32
lujinluoTuanVu: since you are here today, do you happen to have any updates on it?14:32
njohnstonlast time I looked at it I came away with the same questions you had posted lujinluo so I maintained my -114:33
TuanVuHi Luo and Nate14:33
njohnstonHi TuanVu!14:34
lujinluohi TuanVu!14:34
TuanVuI intended to update it this week but couldn't manage to have enough time14:34
TuanVuI will try to update it soon14:34
TuanVuthanks a lot for your kind help14:34
lujinluoack!14:35
njohnstonthanks14:35
lujinluothe rest of the patches are not updated since previous meeting. and let's give them some time14:35
lujinluo#topic engine facade14:36
*** openstack changes topic to "engine facade (Meeting topic: neutron_upgrades)"14:36
lujinluo#link https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/enginefacade-switch14:36
lujinluolast week, i said i have a local patch working on, but sadly i have not finished it :(14:36
lujinluoi will try to finish it this week and push for review14:36
lujinluo#topic open discussion14:37
*** openstack changes topic to "open discussion (Meeting topic: neutron_upgrades)"14:37
njohnstonAre there any other objects that we think we can switch to the new facade, on a per-object basis?14:37
njohnstonthe Agent object, for example?14:38
lujinluoi have not gone through the codes so i cannot tell for sure, but theoretically speaking for the objects that we have already converted, should be fine to switch on new facade14:38
njohnstonaccording to the tracking spreadsheet, work on that jas completed14:38
njohnstonI think I'll push up something to enable the new facade on that, and let's see how well it works14:39
lujinluogreat14:39
njohnstonif that works OK then we can move on Network and Router as next steps14:40
lujinluoyep!14:40
njohnston#action njohnston to push change that enables new engine facade for Agent object14:40
lujinluothanks!14:41
lujinluodoes anyone have anything else?14:41
lujinluoif not, i have one small favor i would like to ask14:42
ralonsohsure14:42
njohnstonok14:42
lujinluofirst i am sorry i was not active enough to track the changes last week, and i saw people actually added me as reviewers to those new patches14:42
lujinluobut that one goes to my previous company email, which i did not have access to..14:43
lujinluoi mean i dont have access anymore14:43
lujinluoso if possible.. please add the account with my gmail address, :)14:43
*** dims has quit IRC14:43
njohnstonok14:43
ralonsohok14:43
lujinluoi will also contact the admin ppl to see if they can remove the old account for good14:44
lujinluothanks! njohnston ralonsoh14:44
ralonsohthanks!14:44
njohnstonnp14:44
lujinluook, if that's it. let's call it a day :-)14:44
njohnstonI have one other thing14:44
lujinluosure14:44
njohnstonI am starting to play around with how best to implement baked qieries14:45
njohnstonI have a very WIP change here: https://review.openstack.org/60971514:45
lujinluois it the one we may need for all the joins?14:45
njohnstonit speeds up operations.  Basically it short cuts the process of constructing the text of the SQL query.  Especially for frequently invoked queries that never change it will be a significant speed boost.14:47
lujinluosounds very impressive14:47
njohnstonit was already implemented in ODL; check out https://review.openstack.org/#/c/591363/ for comparison14:48
*** dims has joined #openstack-meeting-514:48
lujinluogot it. will check on both patches. this will be a big performance gain in large scale systems14:49
njohnstonabsolutely14:50
*** annp_ has quit IRC14:51
lujinluoyeah, would be very interested to see how it works!14:52
njohnstonthat is all for me14:52
lujinluook if nothing else, let's call it a day!14:53
lujinluothanks everyone for joining14:53
lujinluohave a good day/night14:53
ralonsohbye14:53
lujinluoand hope to see you all next week!14:53
lujinluo#endmeeting14:53
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/"14:53
openstackMeeting ended Thu Oct 11 14:53:44 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:53
openstackMinutes:        http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-10-11-14.00.html14:53
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-10-11-14.00.txt14:53
openstackLog:            http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-10-11-14.00.log.html14:53
*** lujinluo has quit IRC15:03
*** mugsie has joined #openstack-meeting-515:23
*** roman_g has quit IRC15:24
*** roman_g has joined #openstack-meeting-515:26
*** mjturek has quit IRC15:51
*** lujinluo has joined #openstack-meeting-516:04
*** lujinluo has quit IRC16:24
*** skazi has quit IRC16:36
*** mjturek has joined #openstack-meeting-516:42
*** derekh has quit IRC16:59
*** mjturek has quit IRC17:01
*** TuanVu has quit IRC17:29
*** TuanVu has joined #openstack-meeting-517:29
*** TuanVu has quit IRC17:30
*** TuanVu has joined #openstack-meeting-517:30
*** TuanVu has quit IRC17:30
*** TuanVu has joined #openstack-meeting-517:31
*** TuanVu has quit IRC17:31
*** TuanVu has joined #openstack-meeting-517:32
*** TuanVu has quit IRC17:32
*** yamahata has quit IRC17:37
*** hongbin has joined #openstack-meeting-517:38
*** ianychoi has quit IRC17:41
*** zenirc369 has joined #openstack-meeting-517:46
*** zenirc369 has quit IRC17:51
*** skazi has joined #openstack-meeting-517:53
*** yamahata has joined #openstack-meeting-518:09
*** ralonsoh has quit IRC18:32
*** lemko has quit IRC21:46
*** hongbin has quit IRC23:04
*** yamahata has quit IRC23:37

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!