| *** felipemonteiro_ has joined #openstack-meeting-5 | 00:12 | |
| *** felipemonteiro_ has quit IRC | 00:26 | |
| *** yamahata has quit IRC | 01:07 | |
| *** ricolin has joined #openstack-meeting-5 | 02:17 | |
| *** roman_g has quit IRC | 03:06 | |
| *** slaweq has quit IRC | 03:53 | |
| *** yamahata has joined #openstack-meeting-5 | 04:08 | |
| *** slaweq has joined #openstack-meeting-5 | 04:11 | |
| *** slaweq has quit IRC | 04:16 | |
| *** nguyenhai has left #openstack-meeting-5 | 04:31 | |
| *** slaweq has joined #openstack-meeting-5 | 05:11 | |
| *** slaweq has quit IRC | 05:15 | |
| *** slaweq has joined #openstack-meeting-5 | 06:11 | |
| *** slaweq has quit IRC | 06:15 | |
| *** slaweq has joined #openstack-meeting-5 | 06:44 | |
| *** slaweq has quit IRC | 06:48 | |
| *** slaweq has joined #openstack-meeting-5 | 06:54 | |
| *** hoangcx has joined #openstack-meeting-5 | 08:08 | |
| *** hoangcx has left #openstack-meeting-5 | 08:08 | |
| *** roman_g has joined #openstack-meeting-5 | 08:22 | |
| *** derekh has joined #openstack-meeting-5 | 08:40 | |
| *** sgrasley has quit IRC | 09:11 | |
| *** sgrasley has joined #openstack-meeting-5 | 09:17 | |
| *** skazi has quit IRC | 10:34 | |
| *** skazi has joined #openstack-meeting-5 | 12:23 | |
| *** mjturek has joined #openstack-meeting-5 | 13:01 | |
| *** lujinluo has joined #openstack-meeting-5 | 13:38 | |
| *** jgu has joined #openstack-meeting-5 | 13:45 | |
| *** hongbin has joined #openstack-meeting-5 | 13:50 | |
| *** jgu has quit IRC | 13:50 | |
| *** njohnston has joined #openstack-meeting-5 | 13:54 | |
| *** TuanVu has joined #openstack-meeting-5 | 13:54 | |
| *** TuanVu has quit IRC | 13:56 | |
| *** TuanVu has joined #openstack-meeting-5 | 13:59 | |
| lujinluo | #startmeeting neutron_upgrades | 14:00 |
|---|---|---|
| openstack | Meeting started Thu Jun 28 14:00:18 2018 UTC and is due to finish in 60 minutes. The chair is lujinluo. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| *** openstack changes topic to " (Meeting topic: neutron_upgrades)" | 14:00 | |
| openstack | The meeting name has been set to 'neutron_upgrades' | 14:00 |
| lujinluo | Hi all! Long time no see | 14:00 |
| TuanVu | Hi Luo :D | 14:01 |
| TuanVu | great to see you | 14:01 |
| njohnston | Welcome back! | 14:01 |
| lujinluo | Thanks njohnston for taking over the duties for the past two weeks | 14:01 |
| njohnston | I am happy to have been of service. | 14:01 |
| *** GregWaines has joined #openstack-meeting-5 | 14:02 | |
| lujinluo | I read the logs of the past two meetings, it seems we have some AIs? njohnston | 14:02 |
| *** annp_ has joined #openstack-meeting-5 | 14:02 | |
| njohnston | Yes, 1 moment | 14:02 |
| njohnston | (I have to look them up) | 14:02 |
| lujinluo | sure | 14:03 |
| njohnston | So first one was to get core reviewers for https://review.openstack.org/#/c/565358/ | 14:04 |
| njohnston | I did reach out to a couple people | 14:04 |
| njohnston | so now it just needs to pass gate consistently | 14:05 |
| lujinluo | yeah, it is waiting for final check now | 14:05 |
| lujinluo | seems to get merged pretty soon | 14:05 |
| lujinluo | thanks! | 14:05 |
| *** hungpv has joined #openstack-meeting-5 | 14:05 | |
| njohnston | and second one we can check now, which is that the wiki page for this meeting seems quite out of date (refrences Pike in the future tense) | 14:06 |
| lujinluo | yes, i am aware of that too. #link https://wiki.openstack.org/wiki/Meetings/Neutron-Upgrades-Subteam there are too much out-of-date info | 14:06 |
| lujinluo | but i am curious why you said you do not have right to edit it njohnston ? | 14:06 |
| njohnston | I thought about updating it, but I did not feel I should without talking to you first, lujinluo. | 14:07 |
| njohnston | I had an issue with my openstack id, which I have since sorted out | 14:07 |
| lujinluo | i see. i thought it was some technical issues. but you are more than welcome to update it! njohnston | 14:07 |
| njohnston | I think that was all :-) | 14:08 |
| lujinluo | i will try to put the latest info tmr, but it would also be appreciated if you would help me with it too | 14:08 |
| lujinluo | as one person may miss something :-) | 14:08 |
| TuanVu | I'll also have a look | 14:09 |
| lujinluo | thanks TuanVu ! | 14:09 |
| TuanVu | so if you push a new patch, please add me as well | 14:09 |
| TuanVu | I'll try my best :) | 14:09 |
| lujinluo | wiki page does not involve any patches | 14:09 |
| lujinluo | anyone is free to edit after logging to openstack id | 14:09 |
| TuanVu | oh, thanks for this info | 14:10 |
| TuanVu | thank you, Luo | 14:10 |
| lujinluo | yeah, then let us jump to the ovo patches first | 14:10 |
| lujinluo | #topic OVO | 14:10 |
| *** openstack changes topic to "OVO (Meeting topic: neutron_upgrades)" | 14:10 | |
| lujinluo | #link https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db | 14:10 |
| lujinluo | #link https://review.openstack.org/#/c/549168/ Router OVO | 14:11 |
| lujinluo | it is still pretty red | 14:11 |
| lujinluo | hungpv: are you still trying to solve all the failures? | 14:11 |
| lujinluo | well, i think the author is not at the meeting right now. | 14:13 |
| lujinluo | maybe we should move to the next patch first | 14:13 |
| lujinluo | #link https://review.openstack.org/#/c/565358/ objects: don't refetch a non-list object field if it's None | 14:14 |
| lujinluo | this patch is so ready to go. hopefully we can see it merged within today :) | 14:14 |
| njohnston | another one waiting for the gate | 14:14 |
| *** hungpv_ has joined #openstack-meeting-5 | 14:14 | |
| *** hungpv has quit IRC | 14:15 | |
| lujinluo | njohnston: yeah, the gate seems to be slow | 14:15 |
| lujinluo | #link https://review.openstack.org/#/c/507772/ Network OVO | 14:16 |
| lujinluo | TuanVu: so I followed the recent comments about renamed type | 14:17 |
| *** TuanVu has quit IRC | 14:17 | |
| lujinluo | to make sure i am not missing anything. the status is that we have not figured a way to deal with it, right? | 14:17 |
| lujinluo | Ihar's suggestion is to add a compatible layer | 14:17 |
| lujinluo | i have not had time to review the latest codes | 14:18 |
| lujinluo | oops, Tuan is offline now..? | 14:18 |
| njohnston | I think that one is nearly ready to merge, slaweq just has a couple of notes | 14:18 |
| lujinluo | how about the issues mentioned by boden? | 14:19 |
| *** TuanVu has joined #openstack-meeting-5 | 14:19 | |
| TuanVu | sorry, there was something wrong with network connection | 14:19 |
| TuanVu | I'll provide answer for Slawek's comment soon | 14:19 |
| lujinluo | TuanVu: how about vmware-nsx's failures? | 14:19 |
| lujinluo | resulted from renames types | 14:20 |
| TuanVu | regarding to problem with vmware, as Ihar's comment, these changes are legit | 14:20 |
| TuanVu | boden will check more and provide update later | 14:20 |
| TuanVu | from vmware side | 14:20 |
| *** GregWaines has quit IRC | 14:21 | |
| lujinluo | i might be missing something here, but it looks to me Ihar's opinion is that we should change something on OVO side, to avoid those failures on customers' side. no? | 14:21 |
| lujinluo | consumers i mean | 14:22 |
| lujinluo | njohnston: i would like to hear your opinion | 14:23 |
| TuanVu | that's what he means by providing compatibility layer | 14:23 |
| TuanVu | but I think it makes the problem to be more complicated | 14:23 |
| TuanVu | why not doing the "right" thing right away instead of making a layer to mix between "right" and "not right"? | 14:25 |
| njohnston | It does make the change a bit more complicated, no doubt. The alternative is to make this change and then to lok through all networking projects and propose changes to each of them that will follow suit with this change. I think the compatibility layer is more graceful. | 14:25 |
| TuanVu | thanks for the comment, Nate | 14:26 |
| *** hungpv_ has quit IRC | 14:26 | |
| njohnston | Since you cannot dictate that another project changes something to match your change, either you do it yourself, or you make it so that they can keep functioning until they can make the needed change. | 14:26 |
| TuanVu | hmm | 14:27 |
| njohnston | Let's recheck the vmware-nsx test patch and see what the issues it sees are | 14:27 |
| lujinluo | yes, agree with njohnston . but i think what i am missing here is that is this compatibility layer included in the patch already or not? | 14:27 |
| TuanVu | so compatibility layer is a great option | 14:28 |
| TuanVu | not yet, Luo-san | 14:28 |
| lujinluo | which seems to me we do not have the compatibility layer yet | 14:28 |
| TuanVu | yeah | 14:28 |
| TuanVu | you're correct | 14:28 |
| lujinluo | njohnston: good point. we shall recheck vmware-nsx and then see if boden has any updates | 14:29 |
| njohnston | I just sent a recheck to https://review.openstack.org/574797/ | 14:29 |
| njohnston | which is the vmware-nsx test patch | 14:29 |
| njohnston | shall we note an #action on this? | 14:30 |
| lujinluo | #action to see the latest result of https://review.openstack.org/574797/ | 14:30 |
| lujinluo | #action lujinluo to check if bode has any updates on vmware-nsx side | 14:30 |
| lujinluo | let's move to next two patches | 14:31 |
| lujinluo | #link https://review.openstack.org/#/c/561834/ https://review.openstack.org/#/c/562489/ | 14:31 |
| lujinluo | these two are recently reviewed by manjeet | 14:31 |
| lujinluo | TuanVu: you may not have had time to work on them yet | 14:31 |
| lujinluo | oh, and one of them is reviewed by nate | 14:32 |
| *** jgu has joined #openstack-meeting-5 | 14:32 | |
| lujinluo | #link https://review.openstack.org/#/c/544206/ portbinding OVO | 14:33 |
| *** MarkBaker has quit IRC | 14:33 | |
| TuanVu | in last week IRC meeting, Nate had provided some suggestion for doing "join" | 14:33 |
| lujinluo | yeah, i was planning to have that discussion on open discussion part | 14:33 |
| lujinluo | i have some questions regarding that | 14:33 |
| TuanVu | however, as far as I remember, the details (eg: maybe a patch with example) haven't been decided yet | 14:33 |
| lujinluo | njohnston: yeah, so i think i did not fully understand what dan suggested | 14:34 |
| lujinluo | is he suggesting we should do 'joins' in a general way or we do them case-by-case? | 14:35 |
| *** annp_ has quit IRC | 14:35 | |
| *** jgu has left #openstack-meeting-5 | 14:35 | |
| njohnston | It seems to me that his suggestion works well for a specific type of join, where we are taking data from one object and adding a few fields from a second object | 14:35 |
| lujinluo | i see. i think we have other joins dealing with 3 tables | 14:36 |
| njohnston | After looking at how the code works in Nova, it did not look to me like it would provide other functions that joins have, like "show me only the records that are in both table 1 and table 2" | 14:36 |
| lujinluo | can his suggestion work on that situation as well? | 14:36 |
| njohnston | Not as well. | 14:36 |
| njohnston | So I think it is probably better to just rehome the joins into the objects. This has already been done in a number of places, for example: https://git.openstack.org/cgit/openstack/neutron/tree/neutron/objects/ports.py#n200 | 14:37 |
| njohnston | or https://git.openstack.org/cgit/openstack/neutron/tree/neutron/objects/router.py#n147 | 14:37 |
| njohnston | just a couple examples among many | 14:38 |
| lujinluo | yes, we did that before | 14:38 |
| lujinluo | it is kind of a historical reason as we could not find a good solution at that time | 14:38 |
| njohnston | I don't think there is a good solution unless you have deep knowledge of the transaction in question. | 14:39 |
| lujinluo | but last time when we had the discussion about whether we should continue doing that, Ihar said we should still try to find more ovo-like solutions and i agreed | 14:39 |
| lujinluo | but if we still could not find it, i do not oppose the idea of moving joins into objects | 14:39 |
| njohnston | I don't think we should hold up change based on this | 14:40 |
| lujinluo | although i do think that is the last we want to do | 14:40 |
| *** MarkBaker has joined #openstack-meeting-5 | 14:40 | |
| lujinluo | yes, i agree. | 14:40 |
| njohnston | I don't want to delay the neutron upgrade core deliverable, which is what OVO is a means to, just based on the purity of OVO | 14:41 |
| lujinluo | yeah, i understand that. | 14:41 |
| lujinluo | then let's just move joins to objects | 14:41 |
| njohnston | Once we get to the seamless upgrade that the OVO transition promises us, then we can revisit this. Maybe we will have had a better idea in the meantime. :-) | 14:41 |
| lujinluo | hopefully :) | 14:42 |
| njohnston | Just my own personal opinion :-) | 14:42 |
| lujinluo | sure, i do not want to block the delivery of ovo either. | 14:42 |
| lujinluo | let's add TODOs when moving joins then | 14:43 |
| lujinluo | to remind us of the debts! | 14:43 |
| TuanVu | thank you, Nate and Luo for the discussion | 14:43 |
| TuanVu | I got it | 14:43 |
| lujinluo | ok, let's move to the next one | 14:44 |
| lujinluo | #line https://review.openstack.org/#/c/544206/ portbinding ovo | 14:44 |
| lujinluo | this one is on me | 14:44 |
| lujinluo | i will rebase and address manjeet's comments tmr | 14:44 |
| lujinluo | but i still need to wait for Migeuls' patch as well | 14:45 |
| lujinluo | but if you feel like doing more reviews, welcome! | 14:45 |
| lujinluo | the rest of the patches are not touched yet | 14:45 |
| lujinluo | #open discussion | 14:45 |
| lujinluo | #topic open discussion | 14:46 |
| *** openstack changes topic to "open discussion (Meeting topic: neutron_upgrades)" | 14:46 | |
| lujinluo | (vacation ruined my brain | 14:46 |
| lujinluo | i have one thing that i would like to share | 14:46 |
| lujinluo | as some of you might have already know, i am leaving my current employeer | 14:47 |
| lujinluo | i have hand over most of my community and in-house duties to my colleagues, but i will continue working on neutron ovo | 14:47 |
| TuanVu | that's awesome, Luo :) | 14:48 |
| TuanVu | I'm very glad to know that | 14:48 |
| lujinluo | since i am going back to school to pursue a higher education, i will spend as much time as i can on ovo as i used to | 14:48 |
| njohnston | I hope it is a fantastic new adventure for you! Glad you will still be in the community. | 14:48 |
| lujinluo | but if at some point of time in the future that i think i will not be spending that efforts, i will let you and Miguel know | 14:49 |
| lujinluo | ok, that is all about what i want to share! | 14:49 |
| lujinluo | does anyone have anything else? | 14:50 |
| TuanVu | although it's sad to see you leave Fujitsu but at the same time, I'm very happy to know that you're about to have a new great adventure | 14:50 |
| lujinluo | thank you! TuanVu and njohnston | 14:50 |
| TuanVu | :) | 14:50 |
| TuanVu | regarding to Network OVO patch | 14:51 |
| TuanVu | compatibility layer | 14:51 |
| TuanVu | I don't understand what Ihar means by "'port_security' property that returns 'security' value" | 14:51 |
| TuanVu | and also "az_hints as string instead of a list of strings" | 14:52 |
| njohnston | I did not go back and research those references, but I assumed he was listing examples of previous measures taken for compatibility shim reasons. | 14:53 |
| TuanVu | yeah, I mean I'm not sure how to build the layer for the conversion | 14:53 |
| lujinluo | i have not looked at the codes yet, but i think it is similar to the methods of from_db_object(), where you switching port_security in ovo and security in db | 14:54 |
| njohnston | so right now vmware-nsx calls some function and expects to get back from that the data provided by sql alchemy, right? | 14:55 |
| njohnston | so keep that function and the arguents the same, and have the function call whatever OVO methods accomplish the same result | 14:55 |
| njohnston | that way the vmware-nsx code does not need to change | 14:55 |
| njohnston | You may want to mark that it is being left for compatibility reasons in a comment | 14:56 |
| njohnston | The same tactic has been used as functionality is migrated from neutron into neutron-lib | 14:56 |
| TuanVu | thank you very much, Nate and Luo | 14:57 |
| TuanVu | I will dig more | 14:57 |
| TuanVu | if there's any other concern, I'll let both of you know :) | 14:57 |
| lujinluo | no problem | 14:57 |
| lujinluo | ok i guess that's all for today | 14:58 |
| lujinluo | thank you guys! | 14:58 |
| njohnston | keep asking questions; you're really close to it TuanVu! | 14:58 |
| njohnston | Thanks all | 14:58 |
| lujinluo | see you next week | 14:58 |
| TuanVu | thanks a lot, Nate :) | 14:58 |
| TuanVu | see you guys soon :) | 14:58 |
| lujinluo | #endmeeting | 14:58 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 14:58 | |
| openstack | Meeting ended Thu Jun 28 14:58:33 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:58 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-06-28-14.00.html | 14:58 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-06-28-14.00.txt | 14:58 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-06-28-14.00.log.html | 14:58 |
| *** lujinluo has quit IRC | 14:58 | |
| *** TuanVu has quit IRC | 15:03 | |
| *** MarkBaker has quit IRC | 15:08 | |
| *** yamamoto has quit IRC | 15:12 | |
| *** yamamoto has joined #openstack-meeting-5 | 15:12 | |
| *** njohnston has left #openstack-meeting-5 | 15:19 | |
| *** MarkBaker has joined #openstack-meeting-5 | 15:21 | |
| *** slaweq has quit IRC | 16:06 | |
| *** slaweq has joined #openstack-meeting-5 | 16:25 | |
| *** yamahata has quit IRC | 16:54 | |
| *** derekh has quit IRC | 17:00 | |
| *** yamahata has joined #openstack-meeting-5 | 17:13 | |
| *** ricolin has quit IRC | 17:25 | |
| *** mjturek has quit IRC | 17:57 | |
| *** mjturek has joined #openstack-meeting-5 | 18:10 | |
| *** mjturek has quit IRC | 18:15 | |
| *** mjturek has joined #openstack-meeting-5 | 18:16 | |
| *** jgu has joined #openstack-meeting-5 | 19:07 | |
| *** jgu has quit IRC | 19:17 | |
| *** mjturek has quit IRC | 20:12 | |
| *** mjturek has joined #openstack-meeting-5 | 20:30 | |
| *** mjturek has quit IRC | 21:25 | |
| *** jgu has joined #openstack-meeting-5 | 21:38 | |
| *** jgu has joined #openstack-meeting-5 | 21:39 | |
| *** sgrasley has quit IRC | 21:51 | |
| *** sgrasley has joined #openstack-meeting-5 | 21:51 | |
| *** sgrasley has quit IRC | 21:54 | |
| *** mjturek has joined #openstack-meeting-5 | 21:58 | |
| *** mjturek has quit IRC | 22:01 | |
| *** hongbin has quit IRC | 22:16 | |
| *** jgu has quit IRC | 23:01 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!