| *** yamamoto has joined #openstack-meeting-5 | 01:14 | |
| *** markvoelker has joined #openstack-meeting-5 | 01:54 | |
| *** markvoelker has quit IRC | 02:02 | |
| *** markvoelker has joined #openstack-meeting-5 | 02:08 | |
| *** markvoelker has quit IRC | 02:14 | |
| *** markvoelker has joined #openstack-meeting-5 | 02:15 | |
| *** markvoelker has quit IRC | 02:19 | |
| *** slaweq has joined #openstack-meeting-5 | 02:26 | |
| *** slaweq has quit IRC | 02:31 | |
| *** yamahata has quit IRC | 02:35 | |
| *** slaweq has joined #openstack-meeting-5 | 03:11 | |
| *** slaweq has quit IRC | 03:16 | |
| *** ianychoi has quit IRC | 03:51 | |
| *** slaweq has joined #openstack-meeting-5 | 03:58 | |
| *** slaweq has quit IRC | 04:03 | |
| *** radeks__ has joined #openstack-meeting-5 | 04:11 | |
| *** slaweq has joined #openstack-meeting-5 | 04:26 | |
| *** slaweq has quit IRC | 04:31 | |
| *** skazi has joined #openstack-meeting-5 | 04:36 | |
| *** slaweq has joined #openstack-meeting-5 | 04:58 | |
| *** slaweq has quit IRC | 05:02 | |
| *** slaweq has joined #openstack-meeting-5 | 05:30 | |
| *** ricolin has joined #openstack-meeting-5 | 05:33 | |
| *** slaweq has quit IRC | 05:33 | |
| *** slaweq has joined #openstack-meeting-5 | 05:34 | |
| *** skazi has quit IRC | 05:37 | |
| *** slaweq has quit IRC | 05:39 | |
| *** markvoelker has joined #openstack-meeting-5 | 06:05 | |
| *** slaweq has joined #openstack-meeting-5 | 06:42 | |
| *** radeks__ has quit IRC | 06:43 | |
| *** slaweq has quit IRC | 06:46 | |
| *** radeks__ has joined #openstack-meeting-5 | 07:24 | |
| *** ianychoi has joined #openstack-meeting-5 | 07:32 | |
| *** markvoelker has quit IRC | 08:15 | |
| *** radeks__ has quit IRC | 08:19 | |
| *** radeks__ has joined #openstack-meeting-5 | 08:36 | |
| *** radeks__ has quit IRC | 08:41 | |
| *** derekh has joined #openstack-meeting-5 | 08:50 | |
| *** markvoelker has joined #openstack-meeting-5 | 09:04 | |
| *** slaweq has joined #openstack-meeting-5 | 09:06 | |
| *** slaweq has quit IRC | 09:10 | |
| *** ttx has quit IRC | 09:52 | |
| *** slaweq has joined #openstack-meeting-5 | 10:11 | |
| *** ttx has joined #openstack-meeting-5 | 10:11 | |
| *** radeks__ has joined #openstack-meeting-5 | 10:11 | |
| *** ttx has quit IRC | 10:14 | |
| *** ttx has joined #openstack-meeting-5 | 10:14 | |
| *** slaweq has quit IRC | 10:15 | |
| *** radeks__ has quit IRC | 10:17 | |
| *** radeks__ has joined #openstack-meeting-5 | 10:30 | |
| *** radeks_ has joined #openstack-meeting-5 | 10:32 | |
| *** radeks__ has quit IRC | 10:35 | |
| *** radeks_ has quit IRC | 10:55 | |
| *** markvoelker_ has joined #openstack-meeting-5 | 11:04 | |
| *** markvoelker has quit IRC | 11:06 | |
| *** ttx has quit IRC | 11:07 | |
| *** ttx has joined #openstack-meeting-5 | 11:08 | |
| *** markvoelker has joined #openstack-meeting-5 | 11:14 | |
| *** markvoelker_ has quit IRC | 11:15 | |
| *** ttx has quit IRC | 11:34 | |
| *** ttx has joined #openstack-meeting-5 | 11:35 | |
| *** yamamoto has quit IRC | 11:41 | |
| *** ttx has quit IRC | 11:47 | |
| *** ttx has joined #openstack-meeting-5 | 11:47 | |
| *** ttx has quit IRC | 11:51 | |
| *** ttx has joined #openstack-meeting-5 | 11:51 | |
| *** yamamoto has joined #openstack-meeting-5 | 12:41 | |
| *** yamamoto has quit IRC | 12:46 | |
| *** slaweq has joined #openstack-meeting-5 | 12:54 | |
| *** yamamoto has joined #openstack-meeting-5 | 12:56 | |
| *** slaweq has quit IRC | 12:58 | |
| *** slaweq has joined #openstack-meeting-5 | 13:10 | |
| *** slaweq has quit IRC | 13:15 | |
| *** markvoelker_ has joined #openstack-meeting-5 | 13:35 | |
| *** markvoelker has quit IRC | 13:36 | |
| *** markvoelker has joined #openstack-meeting-5 | 13:38 | |
| *** roman_g has joined #openstack-meeting-5 | 13:39 | |
| *** markvoelker_ has quit IRC | 13:40 | |
| *** lujinluo has joined #openstack-meeting-5 | 13:46 | |
| *** markvoelker has quit IRC | 13:52 | |
| *** slaweq has joined #openstack-meeting-5 | 13:53 | |
| *** hongbin has joined #openstack-meeting-5 | 13:56 | |
| *** slaweq has quit IRC | 13:57 | |
| *** TuanVu has joined #openstack-meeting-5 | 13:58 | |
| *** hungpv has joined #openstack-meeting-5 | 13:59 | |
| lujinluo | #startmeeting neutron_upgrades | 14:00 |
|---|---|---|
| openstack | Meeting started Thu May 31 14:00:07 2018 UTC and is due to finish in 60 minutes. The chair is lujinluo. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| *** openstack changes topic to " (Meeting topic: neutron_upgrades)" | 14:00 | |
| openstack | The meeting name has been set to 'neutron_upgrades' | 14:00 |
| lujinluo | o/ | 14:00 |
| TuanVu | Hi Luo-san | 14:00 |
| lujinluo | hi TuanVu ! | 14:00 |
| lujinluo | We do not have any AIs from last meeting | 14:01 |
| lujinluo | so jump into OVO patches | 14:01 |
| lujinluo | https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db | 14:01 |
| lujinluo | #topic OVO | 14:01 |
| *** openstack changes topic to "OVO (Meeting topic: neutron_upgrades)" | 14:01 | |
| TuanVu | ok | 14:01 |
| lujinluo | https://review.openstack.org/#/c/570244/ | 14:01 |
| lujinluo | this one is from Nate | 14:01 |
| njohnston | o/ | 14:01 |
| lujinluo | The codes look fine to me. but Zuul failed last time | 14:02 |
| lujinluo | hi njohnston | 14:02 |
| njohnston | There is an issue with the sphinx docs build job | 14:02 |
| lujinluo | let's wait for the result of Zuul and see how it goes | 14:02 |
| lujinluo | njohnston: does the latest patch solve it? | 14:02 |
| njohnston | I have https://review.openstack.org/#/c/571301/ to fix it, but I saw there was a discussion between boden and haleyb about whether it was the right approach. | 14:02 |
| njohnston | I rebased 570244 onto 571301 and the build-sphinx-docs job has already succeeded so I believe it will build | 14:03 |
| lujinluo | i see. from a rough review, i think it will fix it | 14:05 |
| njohnston | hopefully so :-) | 14:05 |
| lujinluo | yeah | 14:05 |
| lujinluo | next is https://review.openstack.org/#/c/507772/ | 14:06 |
| TuanVu | I’ve already left a comment about latest status on the patch | 14:06 |
| lujinluo | i think you have already fixed the RBAC issue? TuanVu | 14:06 |
| TuanVu | yes :) | 14:06 |
| lujinluo | good! i see. tempest is still failing | 14:07 |
| TuanVu | thanks to the help from both you and Ihar :) | 14:07 |
| TuanVu | yeah, I'm not sure how to fix it at this moment | 14:07 |
| TuanVu | so any suggestions are welcome | 14:07 |
| TuanVu | it looks like it's related to attach qos | 14:08 |
| lujinluo | are the failed tests related to qos policies? | 14:08 |
| TuanVu | yes, I think so | 14:08 |
| lujinluo | neutron_tempest_plugin.api.test_qos.RbacSharedQosPoliciesTest.test_network_presence_prevents_policy_rbac_policy_deletion [5.378070s] ... FAILED | 14:08 |
| lujinluo | also, slawek pointed potential failures of mtu | 14:10 |
| lujinluo | have you checked that as well? | 14:10 |
| TuanVu | yes, I've checked that | 14:10 |
| TuanVu | it looks like there's problem with getting mtu in: | 14:11 |
| TuanVu | https://review.openstack.org/#/c/507772/54/neutron/plugins/ml2/plugin.py | 14:11 |
| lujinluo | is it one of the 5 failed tests? | 14:11 |
| TuanVu | yes | 14:12 |
| TuanVu | neutron_tempest_plugin.api.test_trunk_negative.TrunkTestMtusJSON. test_add_subport_with_mtu_greater_than_trunk | 14:12 |
| TuanVu | & | 14:12 |
| TuanVu | test_create_trunk_with_mtu_smaller_than_subport | 14:12 |
| lujinluo | ok, i think i need a bit more time to catch up with the latest patch. will take a closer look rmt. but i understood the current status | 14:13 |
| TuanVu | thank you in advance, Luo-san :) | 14:13 |
| lujinluo | next https://review.openstack.org/#/c/565358/ | 14:14 |
| lujinluo | this one is from Ihar | 14:14 |
| lujinluo | and it is blocked by sphinx docs issue | 14:14 |
| lujinluo | we may need to recheck it after Nate's patch got merged | 14:15 |
| TuanVu | yeah, I think so | 14:16 |
| lujinluo | i have added more core reviewers to 571301. hopefully they will take time to review it | 14:16 |
| lujinluo | https://review.openstack.org/#/c/544206/ this one is on me | 14:16 |
| lujinluo | i have two remaining AIs for this patch: 1) reabse it on Migule's patch; 2) resolve the postgresql issue exposed last time | 14:17 |
| lujinluo | for 1) I plan to wait for Miguel's patch to get merged, https://review.openstack.org/#/c/414251/. and it is very close to be merged now | 14:18 |
| lujinluo | for 2) i need to talk to Ihar, because i could not find which test is deployed with postgresql as backend | 14:18 |
| lujinluo | if you know which one it is, or you know how i can find it out, please help me out | 14:19 |
| lujinluo | ok, i will try to catch ihar or Miguel or slawek tmr.. | 14:20 |
| lujinluo | https://review.openstack.org/#/c/537320/ this one is still on me.. | 14:21 |
| lujinluo | i rebased it to accommodate auto detect engine facade | 14:21 |
| lujinluo | but i have one tempest failure, which i believe is related to my change | 14:22 |
| lujinluo | i will work it out tmr | 14:22 |
| lujinluo | (tmr seems to be a tough day for me) | 14:22 |
| TuanVu | yeah | 14:22 |
| TuanVu | but please take it easy, Luo | 14:22 |
| lujinluo | TuanVu: haha, thanks! | 14:23 |
| TuanVu | :) | 14:23 |
| lujinluo | we do not have any updates of the remaining patches | 14:23 |
| lujinluo | does anyone want to address any of their patches? | 14:23 |
| hungpv | yeah | 14:23 |
| lujinluo | shoot | 14:23 |
| hungpv | i have a few questions, maybe basic ones, but you know I'm still noob :D | 14:24 |
| lujinluo | no problem at all. will try my best | 14:24 |
| hungpv | https://review.openstack.org/#/c/549168/8/neutron/tests/unit/extensions/test_l3_ext_gw_mode.py | 14:24 |
| hungpv | L149 self.context.session.flush() | 14:25 |
| hungpv | i'm not sure is this one necessary or not | 14:25 |
| lujinluo | after converting to OVO, we do not need it anymore. .flush() commits all the pending commits to the sessions, because after calling .add() all the commits are not actually commited, they are in pending state | 14:26 |
| hungpv | that's great! | 14:26 |
| lujinluo | while in OVO world, a create() is a commit to db | 14:26 |
| lujinluo | good. anything else you want to discuss? | 14:27 |
| hungpv | yes, and about create() function | 14:27 |
| lujinluo | sure | 14:27 |
| hungpv | i saw some patches rewrite it, not use the built-in one in base.py | 14:28 |
| hungpv | can you give some ideas about it? | 14:28 |
| hungpv | what situations we should do this one or other? | 14:28 |
| lujinluo | yeah, normally create() in base.py does the basic stuff. but for some OVO objects, they have special fields, which are not defined in base.py, then it'd better to rewrite | 14:29 |
| lujinluo | let me try to find an example here | 14:29 |
| lujinluo | https://github.com/openstack/neutron/blob/master/neutron/objects/ports.py#L344 | 14:30 |
| lujinluo | Port has QoS and security groups as extensions attaching to it | 14:31 |
| lujinluo | but QoS and security groups are loaded as synthetic field, thus you need to add additional methods to attach them | 14:31 |
| hungpv | i see | 14:32 |
| lujinluo | sorry QoS and security groups are NOT loaded as synthetic field | 14:32 |
| lujinluo | so it really depends on what object you are dealing with | 14:33 |
| hungpv | i've got your point | 14:34 |
| lujinluo | great! | 14:34 |
| lujinluo | anything else you want to discuss? | 14:35 |
| hungpv | yeah, one final question | 14:35 |
| lujinluo | sure | 14:35 |
| hungpv | L267 router.gw_port.mac_address) | 14:36 |
| hungpv | if I understand it, I see router db model calls mac _address of gw_port | 14:37 |
| hungpv | just sure how to convert it when dealing with router object | 14:37 |
| hungpv | can you shed me some light on it? thank you | 14:38 |
| lujinluo | hmm, i do not quit understand your question | 14:38 |
| lujinluo | do you mean you want to know how to deal with gw_port and router objects? | 14:38 |
| hungpv | yes, that's where I'm stuck right now | 14:39 |
| hungpv | thank you for quick understanding | 14:39 |
| lujinluo | as far as i recall, we may need to add port as a synthetic field of router's in order to proceed. but this is a bit tricky. can you try if we can call router.db_obj.gw_port to request gw_port from db model | 14:41 |
| lujinluo | just an idea though | 14:41 |
| lujinluo | can you point me to the patch? i can add one more task to my to-do list for tmr.. | 14:41 |
| hungpv | @luo-san: https://review.openstack.org/#/c/549168/ | 14:42 |
| njohnston | A reference to router.gw_port works on L269, so I would expect "router.gw_port['mac_address']" might have a chance of success. | 14:42 |
| hungpv | Thank you Nate, gonna try it out | 14:43 |
| lujinluo | yeah, worth a try | 14:43 |
| lujinluo | ok, i will review the patch tmr | 14:45 |
| hungpv | so nothing more from me. thank you | 14:45 |
| lujinluo | #topic open discussion | 14:45 |
| *** openstack changes topic to "open discussion (Meeting topic: neutron_upgrades)" | 14:45 | |
| hungpv | I'm prepare a new patch, and will update tmr for review | 14:45 |
| lujinluo | understood, please add us as reviewers | 14:45 |
| hungpv | yes, surely | 14:46 |
| lujinluo | does anyone have anything to talk about? | 14:46 |
| TuanVu | none from me | 14:46 |
| lujinluo | cool! now let us call it a day! | 14:47 |
| lujinluo | have a good night/day everyone | 14:47 |
| lujinluo | see you next week | 14:47 |
| lujinluo | #endmeeting | 14:47 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 14:47 | |
| openstack | Meeting ended Thu May 31 14:47:54 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:47 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-05-31-14.00.html | 14:47 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-05-31-14.00.txt | 14:47 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-05-31-14.00.log.html | 14:47 |
| TuanVu | see you later | 14:48 |
| TuanVu | bye :) | 14:48 |
| njohnston | o/ | 14:48 |
| hungpv | bye all | 14:48 |
| *** TuanVu has quit IRC | 14:48 | |
| *** vkmc_ has joined #openstack-meeting-5 | 15:06 | |
| *** lujinluo has quit IRC | 15:11 | |
| *** skazi has joined #openstack-meeting-5 | 15:13 | |
| *** skazi has quit IRC | 15:24 | |
| *** hungpv has quit IRC | 15:43 | |
| *** markvoelker has joined #openstack-meeting-5 | 16:11 | |
| *** ricolin has quit IRC | 16:12 | |
| *** derekh has quit IRC | 16:13 | |
| *** markvoelker has quit IRC | 16:24 | |
| *** amotoki has quit IRC | 16:35 | |
| *** amotoki has joined #openstack-meeting-5 | 16:37 | |
| *** slaweq has joined #openstack-meeting-5 | 17:11 | |
| *** vkmc_ has quit IRC | 17:15 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 17:15 | |
| *** slaweq has quit IRC | 17:16 | |
| *** felipemonteiro has quit IRC | 17:37 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 17:37 | |
| *** markvoelker has joined #openstack-meeting-5 | 17:39 | |
| *** yamahata has joined #openstack-meeting-5 | 17:50 | |
| *** markvoelker has quit IRC | 17:51 | |
| *** radeks_ has joined #openstack-meeting-5 | 18:25 | |
| *** slaweq has joined #openstack-meeting-5 | 18:50 | |
| *** slaweq has quit IRC | 18:54 | |
| *** radeks_ has quit IRC | 18:54 | |
| *** slaweq has joined #openstack-meeting-5 | 18:54 | |
| *** radeks_ has joined #openstack-meeting-5 | 18:55 | |
| *** radeks_ has quit IRC | 19:04 | |
| *** radeks_ has joined #openstack-meeting-5 | 19:24 | |
| *** radeks__ has joined #openstack-meeting-5 | 19:28 | |
| *** radeks_ has quit IRC | 19:30 | |
| *** mjturek has quit IRC | 20:15 | |
| *** skazi has joined #openstack-meeting-5 | 20:36 | |
| *** radeks__ has quit IRC | 20:39 | |
| *** skazi has quit IRC | 20:41 | |
| *** markvoelker has joined #openstack-meeting-5 | 20:51 | |
| *** slaweq has quit IRC | 21:19 | |
| *** slaweq has joined #openstack-meeting-5 | 21:20 | |
| *** slaweq has quit IRC | 21:24 | |
| *** markvoelker has quit IRC | 21:26 | |
| *** markvoelker has joined #openstack-meeting-5 | 21:26 | |
| *** markvoelker has quit IRC | 21:31 | |
| *** slaweq has joined #openstack-meeting-5 | 22:11 | |
| *** slaweq has quit IRC | 22:15 | |
| *** felipemonteiro has quit IRC | 22:33 | |
| *** ricolin has joined #openstack-meeting-5 | 22:39 | |
| *** hongbin has quit IRC | 22:41 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!