| *** markvoelker has joined #openstack-meeting-5 | 00:17 | |
| *** markvoelker has quit IRC | 00:24 | |
| *** ricolin has joined #openstack-meeting-5 | 01:20 | |
| *** mjturek has joined #openstack-meeting-5 | 01:31 | |
| *** iyamahat has quit IRC | 02:18 | |
| *** yamahata has quit IRC | 02:20 | |
| *** yamamoto has joined #openstack-meeting-5 | 03:38 | |
| *** slaweq has joined #openstack-meeting-5 | 04:34 | |
| *** slaweq has quit IRC | 04:39 | |
| *** slaweq has joined #openstack-meeting-5 | 05:34 | |
| *** slaweq has quit IRC | 05:39 | |
| *** yamahata has joined #openstack-meeting-5 | 05:50 | |
| *** mjturek has quit IRC | 06:01 | |
| *** yamamoto_ has joined #openstack-meeting-5 | 06:26 | |
| *** yamamoto has quit IRC | 06:30 | |
| *** slaweq has joined #openstack-meeting-5 | 06:34 | |
| *** slaweq has quit IRC | 06:39 | |
| *** slaweq has joined #openstack-meeting-5 | 06:55 | |
| *** slaweq has quit IRC | 06:59 | |
| *** slaweq has joined #openstack-meeting-5 | 07:55 | |
| *** slaweq has quit IRC | 08:00 | |
| *** slaweq has joined #openstack-meeting-5 | 08:13 | |
| *** iyamahat has joined #openstack-meeting-5 | 08:16 | |
| *** jbryce has quit IRC | 08:17 | |
| *** iyamahat_ has joined #openstack-meeting-5 | 08:19 | |
| *** iyamahat__ has joined #openstack-meeting-5 | 08:20 | |
| *** iyamahat has quit IRC | 08:21 | |
| *** iyamahat_ has quit IRC | 08:23 | |
| *** yamamoto has joined #openstack-meeting-5 | 08:57 | |
| *** yamamoto_ has quit IRC | 09:00 | |
| *** derekh has joined #openstack-meeting-5 | 09:10 | |
| *** MarkBaker has quit IRC | 09:24 | |
| *** iyamahat__ has quit IRC | 09:25 | |
| *** slaweq_ has joined #openstack-meeting-5 | 09:25 | |
| *** slaweq_ has quit IRC | 09:30 | |
| *** MarkBaker has joined #openstack-meeting-5 | 10:00 | |
| *** jbryce has joined #openstack-meeting-5 | 10:00 | |
| *** iyamahat has joined #openstack-meeting-5 | 10:23 | |
| *** iyamahat has quit IRC | 10:50 | |
| *** mattmceuen has quit IRC | 11:23 | |
| *** powerds0111 has quit IRC | 11:23 | |
| *** yamahata has quit IRC | 11:27 | |
| *** mjturek has joined #openstack-meeting-5 | 12:08 | |
| *** makowals has joined #openstack-meeting-5 | 12:12 | |
| *** mattmceuen has joined #openstack-meeting-5 | 13:19 | |
| *** powerds0111 has joined #openstack-meeting-5 | 13:19 | |
| *** MarkBaker has quit IRC | 13:41 | |
| *** TuanVu has joined #openstack-meeting-5 | 13:54 | |
| *** MarkBaker has joined #openstack-meeting-5 | 13:55 | |
| *** lujinluo has joined #openstack-meeting-5 | 13:58 | |
| *** ihrachys has joined #openstack-meeting-5 | 14:02 | |
| ihrachys | #startmeeting neutron_upgrades | 14:02 |
|---|---|---|
| openstack | Meeting started Thu Feb 8 14:02:23 2018 UTC and is due to finish in 60 minutes. The chair is ihrachys. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:02 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:02 |
| *** openstack changes topic to " (Meeting topic: neutron_upgrades)" | 14:02 | |
| openstack | The meeting name has been set to 'neutron_upgrades' | 14:02 |
| *** hungpv has joined #openstack-meeting-5 | 14:02 | |
| lujinluo | o/ | 14:02 |
| ihrachys | o/ | 14:02 |
| TuanVu | Hi Ihar | 14:02 |
| TuanVu | Hi Luo | 14:02 |
| hungpv | Hi guys | 14:03 |
| slaweq | hi | 14:03 |
| ihrachys | PSA: this week is RC1 (some time Friday) which should afaiu create stable/queens for neutron | 14:03 |
| TuanVu | Hi Slawek | 14:03 |
| ihrachys | after which we should be able to cautiously start merging Pike patches | 14:04 |
| ihrachys | sorry, I mean Rocky patches | 14:04 |
| ihrachys | of course, while final release is not shipped, the focus will be diverged to Queens matters | 14:04 |
| ihrachys | as some of you know, we have an OVO related issue in bgpvpn that is release blocker for them | 14:05 |
| ihrachys | https://launchpad.net/bugs/1746996 | 14:06 |
| openstack | Launchpad bug 1746996 in neutron "bagpipe: IPAllocation DB query failing, engine facade mismatch" [High,Confirmed] | 14:06 |
| ihrachys | it's a rather twisted issue. but basically, it boils down to bgpvpn using OVO objects in callback handlers that are issued from new engine facade subtransactions, so it fails rather spectacularly because it doesn't see models created by the callback caller in its session | 14:07 |
| ihrachys | and there is no clear cut way out of the issue. | 14:07 |
| ihrachys | one idea we are trying right now is switching bgpvpn objects to new facade, while leaving other objects on the old one for Queens | 14:08 |
| ihrachys | there is patch for bagpipe here: https://review.openstack.org/#/c/541513/ | 14:08 |
| ihrachys | but it would require neutron change: https://review.openstack.org/#/c/541512/ | 14:08 |
| ihrachys | and the latter is not ready for prime time, lots of unit tests were failing | 14:08 |
| ihrachys | I see lujinluo picked it up, thanks for that | 14:09 |
| lujinluo | ihrachys: it is still not in shape yet | 14:09 |
| ihrachys | yeah I know | 14:10 |
| ihrachys | so some questions about your changes | 14:10 |
| ihrachys | first, what's about subnetpool change to new_facade=True? https://review.openstack.org/#/c/541512/4..5/neutron/objects/subnetpool.py | 14:11 |
| lujinluo | one minute, finding the code snippets | 14:12 |
| ihrachys | there is also https://review.openstack.org/#/c/541512/4..5/neutron/db/db_base_plugin_v2.py that deals with subnetpool | 14:13 |
| lujinluo | sorry, the new_facade=True might be garbage code that i forgot to delete | 14:14 |
| lujinluo | as for the latter, it is because of this change https://review.openstack.org/#/c/541512/5/neutron/objects/base.py@319 | 14:15 |
| lujinluo | we need to refresh(db_obj) in case synthetic field changed | 14:15 |
| lujinluo | but if the session is not active, we ignored it then we miss the synthetic field change in db | 14:16 |
| ihrachys | shouldn't session be active at this point? | 14:16 |
| lujinluo | somehow no | 14:17 |
| lujinluo | neutron.tests.unit.db.test_db_base_plugin_v2.TestSubnetPoolsV2.test_allocate_any_subnet_with_prefixlen is the failed UT | 14:18 |
| lujinluo | http://logs.openstack.org/12/541512/4/check/openstack-tox-py27/15c63a0/testr_results.html.gz first one here | 14:18 |
| lujinluo | We missed to refresh the synthetic field (prefixes) of subnetpool | 14:20 |
| ihrachys | ok I guess prefixes are not reloaded in time. maybe we should put refresh in subnetpool object code, I will have a look | 14:20 |
| lujinluo | ok. that is basically the only failed UT I managed to mitigate, LOL | 14:21 |
| ihrachys | actually, maybe it's the decorator that should open subtransaction so that it always spans throughout func() AND refresh() | 14:21 |
| ihrachys | well that's still something. there are other valuable changes there where I missed model to obj_cls conversion | 14:22 |
| ihrachys | thanks for looking into it | 14:22 |
| ihrachys | I will take it back over today | 14:22 |
| ihrachys | I thought tmorin will help with that but he probably was busy | 14:22 |
| lujinluo | yes, although i have not fixed any other UTs, but during the debugging it seems that most of the UTs are about timing to commit changes | 14:23 |
| ihrachys | now to other, non-blocking patches | 14:23 |
| ihrachys | lujinluo, timing to commit? | 14:23 |
| lujinluo | i mean when to open and close transactions | 14:23 |
| *** MarkBaker has quit IRC | 14:24 | |
| lujinluo | also, i want to address that in the patch we are changing some autonested sessions to context.session, and i am not sure if that is the right thing to do | 14:25 |
| ihrachys | lujinluo, do you have an example of the latter? it's easier to follow with an example. | 14:25 |
| lujinluo | https://review.openstack.org/#/c/541512/5/neutron/objects/base.py@599 | 14:26 |
| lujinluo | here you go | 14:26 |
| ihrachys | right. what's the problem with that? | 14:26 |
| lujinluo | i think when we use autonested we are addressing the transaction inside transaction issue, but with this patch we lost that | 14:27 |
| ihrachys | you mean like independent rollback? | 14:27 |
| lujinluo | yes | 14:27 |
| ihrachys | I don't think we use it except in some places where it's explicit in the code (I believe ipam layer had rollback per ip allocation) | 14:28 |
| ihrachys | autonested just helps us to not care about whether caller opened a subtransaction already | 14:28 |
| ihrachys | begin(subtransactions=True) is afaik the same as autonested_transaction | 14:29 |
| lujinluo | ok, i see. then maybe we do not need to care about it | 14:29 |
| ihrachys | ok, moving to other patches | 14:30 |
| ihrachys | https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db | 14:30 |
| ihrachys | https://review.openstack.org/#/c/507772/ "Use Network OVO in db_base_plugin" | 14:30 |
| TuanVu | For this patch, the good news is: there’s just only 1 remaining failed unit test at this moment, which is: “test_get_objects_queries_constant” | 14:30 |
| ihrachys | there are 3 failures right now, all because of number of queries not scaling well | 14:30 |
| TuanVu | yes | 14:31 |
| TuanVu | I’m trying to find exactly where the number of queries is increased | 14:31 |
| *** hungpv has quit IRC | 14:32 | |
| *** zhipeng has joined #openstack-meeting-5 | 14:32 | |
| ihrachys | based on diff of queries in logs, it seems that's because of externalnetworks table fetch | 14:32 |
| TuanVu | thank you, Ihar | 14:33 |
| ihrachys | also networksecuritybindings is fetched twice | 14:33 |
| ihrachys | I guess once per network object | 14:33 |
| TuanVu | yes, I agree, but I still haven't found where it is increased | 14:33 |
| *** yamamoto has quit IRC | 14:34 | |
| ihrachys | afaiu ExternalNetwork is a type of one of synthetic fields of Network | 14:34 |
| *** hungpv has joined #openstack-meeting-5 | 14:34 | |
| TuanVu | correct | 14:34 |
| ihrachys | in theory, it should be eagerly fetched with network model because its relationship is lazy='joined' | 14:34 |
| TuanVu | yes | 14:35 |
| ihrachys | hm, I am looking at Network object from_db_object: https://review.openstack.org/#/c/507772/36/neutron/objects/network.py@326 | 14:36 |
| ihrachys | and I don't see where we would extract values for external from db model | 14:36 |
| ihrachys | hm, though maybe it's base class that is driving synthetic fields extraction, I am already not sure, it was so long time ago I wrote it :) | 14:37 |
| TuanVu | thanks for your suggestion, Ihar :) | 14:38 |
| ihrachys | this may actually be related to the same thing why you needed to catch InvalidRequestError here: https://review.openstack.org/#/c/507772/36/neutron/objects/base.py@320 | 14:38 |
| TuanVu | we'll check it deeper | 14:38 |
| ihrachys | if you don't refresh the relationship, maybe it refetches it somewhere else once per object returned. I think ultimately catching the error is not correct and we should make sure that the session is there for the time when refresh is issued | 14:39 |
| ihrachys | that boils down to what we discussed for that other patch adding support for new_engine | 14:39 |
| *** MarkBaker has joined #openstack-meeting-5 | 14:40 | |
| ihrachys | actually, that's a good patch to try my approach with subtransaction opened in decorator. if it works, it will probably fix the failure. | 14:40 |
| ihrachys | I will try it on your patch later. | 14:40 |
| TuanVu | thanks, we'll try to figure out way to handle it more properly | 14:40 |
| ihrachys | ok | 14:41 |
| ihrachys | https://review.openstack.org/#/c/521797/ "Use Router OVO in external_net_db" | 14:41 |
| ihrachys | this has pep8 issue, let me fix it quickly | 14:42 |
| ihrachys | done | 14:42 |
| ihrachys | apart from that, it seems fine | 14:42 |
| hungpv | Thanks | 14:43 |
| ihrachys | https://review.openstack.org/#/c/537320/ "Use Port OVO in neutron/db/external_net_db.py" | 14:43 |
| ihrachys | this patch is largely a variation on that other patch adding support for new_engine | 14:43 |
| ihrachys | so we'll need to rebase it on top of the patch at some point to be able to utilize the new engine feature | 14:44 |
| *** zhipeng has quit IRC | 14:44 | |
| ihrachys | it also has this InvalidRequestError exception handler that we'll probably try to avoid | 14:44 |
| ihrachys | seems like this patch will need to wait a bit for when those underlying issues are handled | 14:45 |
| lujinluo | yes, i will rebase this one on top of https://review.openstack.org/#/c/541512/ later when it is ready | 14:45 |
| ihrachys | right. it's not ready yet so no need to rebase right away | 14:45 |
| ihrachys | ok next is https://review.openstack.org/#/c/537325/ "Use Meter Label OVO in neutron/db/metering/metering_db.py" | 14:45 |
| ihrachys | I had a question there https://review.openstack.org/#/c/537325/4/neutron/db/l3_dvr_db.py@1077 | 14:46 |
| *** zhipeng has joined #openstack-meeting-5 | 14:46 | |
| ihrachys | not sure you had a chance to think about it | 14:46 |
| lujinluo | no... i will check tmr | 14:46 |
| *** yamamoto has joined #openstack-meeting-5 | 14:46 | |
| ihrachys | I personally hate those functions that try to support polymorphic argument types. seems convoluted. I wonder if it's too hard to switch all callers of is_distributed_router to OVO | 14:47 |
| *** hungpv has quit IRC | 14:47 | |
| ihrachys | ok let's move on | 14:48 |
| ihrachys | https://review.openstack.org/#/c/530182/ "Use Router OVO in l3_db" | 14:49 |
| ihrachys | the author is not responsive | 14:49 |
| ihrachys | if people feel like taking that over, I wouldn't mind :) | 14:49 |
| ihrachys | there are no more patches in the queue that would be worth looking at at this point | 14:51 |
| *** yamamoto has quit IRC | 14:51 | |
| ihrachys | anyone has a topic to discuss? | 14:53 |
| lujinluo | i have one thing | 14:53 |
| ihrachys | lujinluo, shoot | 14:53 |
| lujinluo | i will not be able to join the weekly meeting next week | 14:53 |
| lujinluo | as it is chinese new year eve | 14:53 |
| *** mjturek has quit IRC | 14:53 | |
| lujinluo | i won't have the mood to work, LOL | 14:53 |
| ihrachys | ok no problem. happy new year :) | 14:53 |
| lujinluo | thanks! | 14:54 |
| ihrachys | you are lucky, you have two of them! | 14:54 |
| lujinluo | LOL, yeah | 14:54 |
| lujinluo | i think this also applies to TuanVu ? right? | 14:54 |
| ihrachys | is it the same / similar for others? or is it just in your part of Asia? | 14:54 |
| lujinluo | you guys have public holiday on that day, no? | 14:55 |
| TuanVu | yes, I think so | 14:55 |
| ihrachys | I see. well then we will probably cancel the next meeting, and meet in 2 weeks | 14:55 |
| lujinluo | yeah, Vietnamese also celebrate lunar new year | 14:55 |
| ihrachys | enjoy the holiday! | 14:55 |
| lujinluo | thank you! | 14:55 |
| TuanVu | correct, the same with An-san and Hung-san | 14:56 |
| lujinluo | happy chinese new year of dog to you too ihrachys and TuanVu | 14:56 |
| TuanVu | thank you, Ihar and Luo :) | 14:56 |
| ihrachys | yay | 14:56 |
| ihrachys | *°*”˜˜”*°•.¸☆ ★ ☆¸.•°*”˜˜”*°•.¸☆ | 14:56 |
| ihrachys | ╔╗╔╦══╦═╦═╦╗╔╗ ★ ★ ★ | 14:56 |
| ihrachys | ║╚╝║══║═║═║╚╝║ ☆¸.•°*”˜˜”*°•.¸☆ | 14:56 |
| ihrachys | ║╔╗║╔╗║╔╣╔╩╗╔╝ ★ NEW YEAR ☆ | 14:56 |
| ihrachys | ╚╝╚╩╝╚╩╝╚╝═╚╝ ♥￥☆★☆★☆￥♥ ★☆❤♫❤♫❤ | 14:56 |
| ihrachys | .•*¨`*•..¸☼ ¸.•*¨`*•.♫❤♫❤♫❤ | 14:56 |
| TuanVu | happy chinese new year to you, too | 14:56 |
| TuanVu | :) | 14:56 |
| ihrachys | ok, thanks everyone for joining :) | 14:56 |
| ihrachys | #endmeeting | 14:56 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 14:56 | |
| openstack | Meeting ended Thu Feb 8 14:56:47 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:56 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-02-08-14.02.html | 14:56 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-02-08-14.02.txt | 14:56 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-02-08-14.02.log.html | 14:56 |
| TuanVu | @Ihar: awesome, haha :)) | 14:56 |
| lujinluo | ihrachys: amazing, haha | 14:57 |
| slaweq | nice :) | 14:57 |
| TuanVu | see you later, Slawek :) | 14:57 |
| ihrachys | slaweq, no holiday for you my European friend. :p | 14:57 |
| slaweq | ihrachys: yes, no holiday :( | 14:58 |
| slaweq | but fortunately I like what I'm doing :) | 14:58 |
| TuanVu | that's awesome, slawek :D | 14:58 |
| slaweq | thx TuanVu, see You | 14:59 |
| TuanVu | thank you, Ihar and Luo | 14:59 |
| TuanVu | see you guys soon :) | 15:00 |
| *** iyamahat has joined #openstack-meeting-5 | 15:00 | |
| *** yamahata has joined #openstack-meeting-5 | 15:02 | |
| *** lujinluo has quit IRC | 15:16 | |
| *** mjturek has joined #openstack-meeting-5 | 15:18 | |
| *** mjturek has quit IRC | 15:23 | |
| *** TuanVu has quit IRC | 15:31 | |
| *** yamamoto has joined #openstack-meeting-5 | 15:32 | |
| *** yamamoto has quit IRC | 15:37 | |
| *** yamamoto has joined #openstack-meeting-5 | 15:44 | |
| *** yamamoto has quit IRC | 15:44 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 15:45 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 15:46 | |
| *** MarkBaker has quit IRC | 15:48 | |
| *** felipemonteiro has quit IRC | 15:50 | |
| *** slaweq has quit IRC | 15:56 | |
| *** slaweq has joined #openstack-meeting-5 | 15:56 | |
| *** slaweq has quit IRC | 16:01 | |
| *** MarkBaker has joined #openstack-meeting-5 | 16:02 | |
| *** MarkBaker has quit IRC | 16:09 | |
| *** MarkBaker has joined #openstack-meeting-5 | 16:09 | |
| *** iyamahat has quit IRC | 16:22 | |
| *** zhipeng has quit IRC | 16:29 | |
| *** iyamahat has joined #openstack-meeting-5 | 16:31 | |
| *** yamamoto has joined #openstack-meeting-5 | 16:44 | |
| *** yamamoto has quit IRC | 17:02 | |
| *** slaweq has joined #openstack-meeting-5 | 17:04 | |
| *** felipemonteiro__ has joined #openstack-meeting-5 | 17:08 | |
| *** slaweq has quit IRC | 17:09 | |
| *** felipemonteiro_ has quit IRC | 17:12 | |
| *** derekh has quit IRC | 17:18 | |
| *** slaweq has joined #openstack-meeting-5 | 18:10 | |
| *** slaweq_ has joined #openstack-meeting-5 | 18:13 | |
| *** mjturek has joined #openstack-meeting-5 | 18:14 | |
| *** slaweq_ has quit IRC | 18:19 | |
| *** felipemonteiro__ has quit IRC | 18:34 | |
| *** felipemonteiro__ has joined #openstack-meeting-5 | 18:34 | |
| *** slaweq has quit IRC | 18:35 | |
| *** felipemonteiro__ has quit IRC | 18:36 | |
| *** slaweq has joined #openstack-meeting-5 | 18:56 | |
| *** slaweq has quit IRC | 19:01 | |
| *** slaweq has joined #openstack-meeting-5 | 19:14 | |
| *** slaweq has quit IRC | 19:17 | |
| *** cargonza has quit IRC | 19:25 | |
| *** srwilkers has quit IRC | 19:27 | |
| *** cargonza has joined #openstack-meeting-5 | 19:28 | |
| *** srwilkers has joined #openstack-meeting-5 | 19:31 | |
| *** slaweq has joined #openstack-meeting-5 | 19:43 | |
| *** ChanServ has quit IRC | 20:57 | |
| *** iyamahat has quit IRC | 21:16 | |
| *** yamahata has quit IRC | 21:16 | |
| *** ChanServ has joined #openstack-meeting-5 | 21:30 | |
| *** barjavel.freenode.net sets mode: +o ChanServ | 21:30 | |
| *** yamamoto has joined #openstack-meeting-5 | 21:32 | |
| *** slaweq has quit IRC | 21:51 | |
| *** ricolin has quit IRC | 21:57 | |
| *** mjturek has quit IRC | 22:10 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 22:10 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 22:20 | |
| *** felipemonteiro has quit IRC | 22:24 | |
| *** felipemonteiro_ has quit IRC | 22:55 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 22:56 | |
| *** felipemonteiro_ has quit IRC | 23:42 | |
| *** yamahata has joined #openstack-meeting-5 | 23:45 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!