| *** felipemonteiro__ has quit IRC | 00:11 | |
| *** ricolin has joined #openstack-meeting-5 | 01:39 | |
| *** tuanla____ has joined #openstack-meeting-5 | 01:46 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 02:00 | |
| *** felipemonteiro has quit IRC | 02:29 | |
| *** lamt` has quit IRC | 02:36 | |
| *** yamamoto has joined #openstack-meeting-5 | 02:37 | |
| *** tuanla____ has quit IRC | 03:19 | |
| *** tuanla____ has joined #openstack-meeting-5 | 03:20 | |
| *** iyamahat has quit IRC | 03:37 | |
| *** kei-ichi has quit IRC | 04:07 | |
| *** kei-ichi has joined #openstack-meeting-5 | 04:08 | |
| *** kei-ichi has quit IRC | 04:13 | |
| *** kei-ichi has joined #openstack-meeting-5 | 04:15 | |
| *** kei-ichi has quit IRC | 04:22 | |
| *** kei-ichi has joined #openstack-meeting-5 | 04:22 | |
| *** kei-ichi has quit IRC | 04:27 | |
| *** kei-ichi has joined #openstack-meeting-5 | 04:27 | |
| *** markvoelker has quit IRC | 04:57 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 05:33 | |
| *** felipemonteiro has quit IRC | 06:15 | |
| *** iyamahat has joined #openstack-meeting-5 | 06:46 | |
| *** markvoelker has joined #openstack-meeting-5 | 06:58 | |
| *** iyamahat has quit IRC | 07:22 | |
| *** markvoelker has quit IRC | 07:32 | |
| *** tuanla____ has quit IRC | 07:33 | |
| *** tuanla____ has joined #openstack-meeting-5 | 07:33 | |
| *** iyamahat has joined #openstack-meeting-5 | 07:37 | |
| *** slaweq has joined #openstack-meeting-5 | 07:50 | |
| *** markvoelker has joined #openstack-meeting-5 | 08:29 | |
| *** markvoelker has quit IRC | 09:03 | |
| *** derekh has joined #openstack-meeting-5 | 09:21 | |
| *** yamahata has quit IRC | 09:36 | |
| *** iyamahat has quit IRC | 09:36 | |
| *** markvoelker has joined #openstack-meeting-5 | 10:00 | |
| *** markvoelker has quit IRC | 10:33 | |
| *** tuanla____ has quit IRC | 10:37 | |
| *** beisner has quit IRC | 11:11 | |
| *** TheJulia has quit IRC | 11:11 | |
| *** beisner has joined #openstack-meeting-5 | 11:12 | |
| *** TheJulia has joined #openstack-meeting-5 | 11:12 | |
| *** markvoelker has joined #openstack-meeting-5 | 11:30 | |
| *** markvoelker has quit IRC | 12:04 | |
| *** kei-ichi has quit IRC | 12:18 | |
| *** kei-ichi has joined #openstack-meeting-5 | 12:19 | |
| *** makowals has quit IRC | 12:43 | |
| *** makowals has joined #openstack-meeting-5 | 12:54 | |
| *** coboluxx has joined #openstack-meeting-5 | 12:55 | |
| *** coboluxx has joined #openstack-meeting-5 | 12:55 | |
| *** makowals has quit IRC | 12:55 | |
| *** markvoelker has joined #openstack-meeting-5 | 13:01 | |
| *** zenirc369 has quit IRC | 13:11 | |
| *** markvoelker has quit IRC | 13:33 | |
| *** markvoelker has joined #openstack-meeting-5 | 13:33 | |
| *** makowals has joined #openstack-meeting-5 | 13:39 | |
| *** TuanVu has joined #openstack-meeting-5 | 13:46 | |
| *** makowals has quit IRC | 13:53 | |
| *** MarkBaker has joined #openstack-meeting-5 | 13:53 | |
| *** lujinluo has joined #openstack-meeting-5 | 13:53 | |
| *** yamamoto has quit IRC | 13:55 | |
| *** annp has joined #openstack-meeting-5 | 13:55 | |
| *** makowals has joined #openstack-meeting-5 | 13:59 | |
| *** hoangcx_ has joined #openstack-meeting-5 | 14:00 | |
| *** coboluxx is now known as coboluxx^AFK | 14:01 | |
| *** ihrachys has joined #openstack-meeting-5 | 14:02 | |
| ihrachys | #startmeeting neutron_upgrades | 14:02 |
|---|---|---|
| openstack | Meeting started Thu Feb 1 14:02:13 2018 UTC and is due to finish in 60 minutes. The chair is ihrachys. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:02 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:02 |
| *** openstack changes topic to " (Meeting topic: neutron_upgrades)" | 14:02 | |
| openstack | The meeting name has been set to 'neutron_upgrades' | 14:02 |
| lujinluo | o/ | 14:02 |
| ihrachys | hi lujinluo | 14:02 |
| lujinluo | hi ihrachys | 14:02 |
| TuanVu | Hi everybody | 14:02 |
| ihrachys | o/ TuanVu | 14:03 |
| ihrachys | we are in freeze mode for master right now, nothing except patches explicitly targeted for queens-rc1 and gate fixes land | 14:03 |
| ihrachys | also, the gate is afaik unstable | 14:04 |
| ihrachys | I was distracted by some pre-release activities and lagged on reviews for OVO, sorry for that | 14:04 |
| ihrachys | let's see what we have here though: https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db | 14:04 |
| ihrachys | first being https://review.openstack.org/#/c/506037/ "Part II of Integrate Port OVO" | 14:05 |
| ihrachys | I believe port work is stalled because of port bindings. or at least the plan was to get back to bindings and complete it first, correct? | 14:05 |
| lujinluo | correct | 14:05 |
| ihrachys | I don't see the revert of the revert proposed (at least not in the topic) | 14:06 |
| lujinluo | i was revising port binding locally, not ready for review yet | 14:06 |
| ihrachys | ok. do you have an idea what was wrong with postgres there? | 14:06 |
| lujinluo | sadly not yet. the postgresql backend devstack is not working properly | 14:07 |
| lujinluo | i need more time | 14:07 |
| ihrachys | sure | 14:07 |
| ihrachys | another issue there was mixed engine facades usage introduced by the patch | 14:08 |
| lujinluo | speaking of that, i found an old patch by ann to change ovo base to new engine facade | 14:08 |
| *** hungpv has joined #openstack-meeting-5 | 14:08 | |
| ihrachys | lujinluo, yeah there was one at some point. have a link handy? | 14:09 |
| lujinluo | would that be one of the options we can use to mitigate the incompatibility? | 14:09 |
| lujinluo | let me check | 14:09 |
| ihrachys | lujinluo, yeah, we either replace with new facade, or completely remove it from there, but the latter would require more changes, and probably better to be left for later, if at all done. | 14:10 |
| ihrachys | lujinluo, the problem to solve is that this is base class, so we would need to change it everywhere where OVO objects are used in one go. | 14:11 |
| lujinluo | https://review.openstack.org/#/c/403870/ this one | 14:11 |
| ihrachys | thanks | 14:11 |
| ihrachys | yeah that's the right path - what the patch attempts to do | 14:12 |
| ihrachys | lujinluo, are you going to respin the patch? | 14:12 |
| lujinluo | i think i need to check with Ann first, if she would continue or not | 14:12 |
| lujinluo | if not, i think i can respin it | 14:13 |
| *** hungpv has quit IRC | 14:13 | |
| ihrachys | yeah. I don't think she was working on the blueprint for awhile but better check | 14:13 |
| lujinluo | will add that to my to-do list ;) | 14:13 |
| *** makowals has quit IRC | 14:13 | |
| *** iyamahat has joined #openstack-meeting-5 | 14:14 | |
| ihrachys | mlavalle was also saying he will look into completion of engine facade switch blueprint, so maybe you could co-operate | 14:14 |
| ihrachys | and since you afaiu go to Dublin, you could hash out some details there | 14:14 |
| *** hungpv has joined #openstack-meeting-5 | 14:14 | |
| lujinluo | ok, thanks! i will check that with Miguel too | 14:15 |
| ihrachys | great | 14:16 |
| ihrachys | next is https://review.openstack.org/#/c/537325/ "Use Meter Label OVO in neutron/db/metering/metering_db.py" | 14:16 |
| *** makowals has joined #openstack-meeting-5 | 14:16 | |
| *** yamahata has joined #openstack-meeting-5 | 14:16 | |
| ihrachys | I believe that's one patch that I failed to review since last week (at least it's already in my todo list) | 14:17 |
| *** yamamoto has joined #openstack-meeting-5 | 14:17 | |
| lujinluo | yeah, you said you were afraid of fetching twice from db | 14:17 |
| ihrachys | you solved that I guess? | 14:18 |
| lujinluo | sadly no... | 14:18 |
| ihrachys | ok I will have a look, maybe it's just too complex to do it | 14:19 |
| lujinluo | maybe, but please take a look | 14:20 |
| ihrachys | ack | 14:21 |
| ihrachys | next is "Use Port OVO in neutron/db/external_net_db.py" https://review.openstack.org/#/c/537320/ | 14:21 |
| ihrachys | lujinluo, you are saying there get_objects don't explicitly use engine facade | 14:22 |
| ihrachys | but: https://github.com/openstack/neutron/blob/master/neutron/objects/base.py#L556 | 14:23 |
| lujinluo | yes, this is the old style db engine but it is not nested session. this is what confuses me | 14:24 |
| lujinluo | previously, it is nested transaction and new engine facade cannot co-exist, right? | 14:24 |
| ihrachys | it opens subtransaction using old method, using old facade | 14:24 |
| ihrachys | subtransactions=True == nested actually | 14:24 |
| ihrachys | it's just same thing written in a different way | 14:25 |
| lujinluo | i see. i will hold that patch back before we solve the co-existance issue | 14:25 |
| ihrachys | right. that's why it's so tricky to switch to new facade for OVO: if you change it in get_objects trying to fix it for e.g. Ports, you also change it for all other OVOs and need to switch to new facade in the same patch | 14:26 |
| ihrachys | we could probably do something smart like - put a tag on an object saying 'use new facade' | 14:26 |
| ihrachys | and then base class would do it just for this new object | 14:26 |
| ihrachys | and then switch them one by one | 14:26 |
| ihrachys | that would reduce the scope of each patch, easier to land then | 14:27 |
| ihrachys | what do you think | 14:27 |
| ihrachys | at some point when we switched everything we would remove the tag feature and use just the new one | 14:27 |
| ihrachys | tag == class attribute | 14:27 |
| *** slaweq has quit IRC | 14:27 | |
| lujinluo | hmm, i thought we would be changing base ovo to new engine facade once and for all, no? | 14:28 |
| *** slaweq has joined #openstack-meeting-5 | 14:28 | |
| ihrachys | lujinluo, well yes, but do we want to have a huge patch doing all the things at once (and struggle to merge it because of all conflicts and lack of reviews), or split it? | 14:29 |
| ihrachys | if we can do the migration piece by piece I think that would be a good thing | 14:29 |
| lujinluo | ihrachys: i see your point. | 14:30 |
| lujinluo | smaller patches are better | 14:30 |
| ihrachys | ok let's figure out if it's easy to do it this way. otherwise I suspect that the patch Ann had would need to rise in size quite a bit to cover for all new OVO usage we introduced since it was initially written | 14:31 |
| lujinluo | yeah, i will try the tag approach locally recent to see if it would work as we expect | 14:32 |
| ihrachys | as for the patch in question, I will have a look at whether those two methods indeed are called from new context. if so, we should be able to merge after freeze. | 14:32 |
| *** slaweq has quit IRC | 14:33 | |
| lujinluo | ok, thanks | 14:33 |
| ihrachys | next is https://review.openstack.org/#/c/521797/ "Use Router OVO in external_net_db" | 14:34 |
| *** hungpv has quit IRC | 14:34 | |
| ihrachys | based on latest comments, I guess I need to revisit test coverage there | 14:36 |
| ihrachys | next is https://review.openstack.org/#/c/507772/ "Use Network OVO in db_base_plugin" | 14:36 |
| TuanVu | I’m still fixing “queries_constant” unit tests. | 14:37 |
| TuanVu | After removing “reload shared attribute” parts (I thought this is the only place where it’s gone wrong), the tests are still failing. | 14:37 |
| TuanVu | 14:37 | |
| TuanVu | So at this moment, I’m trying to find other places where the number of queries is increased. | 14:37 |
| TuanVu | I just need more time to debug the code, so no question at this moment yet. | 14:37 |
| ihrachys | ack | 14:37 |
| ihrachys | yeah those queries counting tests are usually tricky | 14:38 |
| *** hungpv_ has joined #openstack-meeting-5 | 14:38 | |
| TuanVu | yes, hopefully I can solve it soon | 14:38 |
| TuanVu | if there's any problem, may I ask you via email, Ihar? | 14:39 |
| ihrachys | next is "Use Router OVO in l3_db" https://review.openstack.org/#/c/530182/ | 14:39 |
| ihrachys | this one still sits on pending comments | 14:39 |
| ihrachys | TuanVu, sure! | 14:39 |
| TuanVu | thank you in advance, Ihar :) | 14:39 |
| ihrachys | anyone knows xujun? | 14:39 |
| lujinluo | no | 14:40 |
| ihrachys | I've never seen xujun in irc | 14:40 |
| TuanVu | me either | 14:40 |
| hungpv_ | Maybe he's blocked in China? | 14:40 |
| lujinluo | hungpv_: well, I do not think China blocks IRC though | 14:41 |
| ihrachys | what do you mean blocked | 14:41 |
| lujinluo | like Google services | 14:41 |
| ihrachys | oh right, the Great Firewall | 14:41 |
| ihrachys | I asked xujun in gerrit whether she (he?) is going to respin it, or we could take it over | 14:42 |
| hungpv_ | I'm still working on it. If there's no update from them, maybe we'll take over? | 14:43 |
| ihrachys | other patches in the query are old / in conflicts. | 14:43 |
| ihrachys | hungpv_, the author respinned the patch two weeks ago | 14:45 |
| ihrachys | hungpv_, I think you could e.g. help them with suggestions as comments + upload your diff on top of their patch / in a parallel work-in-progress patch so that they can incorporate your changes / suggestions into their patch | 14:46 |
| hungpv_ | Yes, I'll be working more in this and give my update to their patch | 14:47 |
| ihrachys | ok | 14:48 |
| ihrachys | any other patches to discuss? | 14:48 |
| lujinluo | none from me | 14:48 |
| ihrachys | neither from me | 14:49 |
| TuanVu | Neither am I | 14:49 |
| ihrachys | I guess we can close the meeting then. thanks folks. | 14:50 |
| ihrachys | #endmeeting | 14:50 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 14:50 | |
| openstack | Meeting ended Thu Feb 1 14:50:19 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:50 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-02-01-14.02.html | 14:50 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-02-01-14.02.txt | 14:50 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2018/neutron_upgrades.2018-02-01-14.02.log.html | 14:50 |
| TuanVu | thank you guys | 14:50 |
| TuanVu | see you guys later | 14:50 |
| lujinluo | thanks! | 14:50 |
| *** hungpv has joined #openstack-meeting-5 | 14:50 | |
| *** hungpv_ has quit IRC | 14:51 | |
| *** slaweq has joined #openstack-meeting-5 | 14:53 | |
| *** hoangcx_ has quit IRC | 14:54 | |
| *** hungpv has quit IRC | 14:55 | |
| *** lujinluo has quit IRC | 15:04 | |
| *** vkmc_ has joined #openstack-meeting-5 | 15:08 | |
| *** lamt_ has joined #openstack-meeting-5 | 15:27 | |
| *** TuanVu has quit IRC | 15:29 | |
| *** slaweq_ has joined #openstack-meeting-5 | 15:34 | |
| *** slaweq_ has quit IRC | 15:38 | |
| *** annp has quit IRC | 15:57 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 16:08 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 16:09 | |
| *** ricolin has quit IRC | 16:10 | |
| *** slaweq has quit IRC | 16:13 | |
| *** felipemonteiro has quit IRC | 16:14 | |
| *** felipemonteiro_ has quit IRC | 16:30 | |
| *** iyamahat has quit IRC | 16:36 | |
| *** yamahata has quit IRC | 16:38 | |
| *** iyamahat has joined #openstack-meeting-5 | 17:17 | |
| *** yamahata has joined #openstack-meeting-5 | 17:27 | |
| *** derekh has quit IRC | 17:27 | |
| *** MarkBaker has quit IRC | 17:36 | |
| *** iyamahat has quit IRC | 17:52 | |
| *** iyamahat has joined #openstack-meeting-5 | 17:54 | |
| *** slaweq has joined #openstack-meeting-5 | 18:00 | |
| *** slaweq has quit IRC | 18:04 | |
| *** yamamoto has quit IRC | 18:17 | |
| *** vkmc_ has quit IRC | 18:25 | |
| *** slaweq has joined #openstack-meeting-5 | 18:32 | |
| *** slaweq has quit IRC | 18:38 | |
| *** slaweq has joined #openstack-meeting-5 | 18:52 | |
| *** slaweq has quit IRC | 18:56 | |
| *** yamamoto has joined #openstack-meeting-5 | 19:18 | |
| *** yamamoto has quit IRC | 19:29 | |
| *** slaweq has joined #openstack-meeting-5 | 19:42 | |
| *** slaweq_ has joined #openstack-meeting-5 | 19:42 | |
| *** slaweq has quit IRC | 19:46 | |
| *** slaweq_ has quit IRC | 19:47 | |
| *** iyamahat_ has joined #openstack-meeting-5 | 19:54 | |
| *** iyamahat has quit IRC | 19:56 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 20:00 | |
| *** slaweq has joined #openstack-meeting-5 | 20:08 | |
| *** slaweq_ has joined #openstack-meeting-5 | 20:09 | |
| *** slaweq_ has quit IRC | 20:14 | |
| *** slaweq_ has joined #openstack-meeting-5 | 20:41 | |
| *** slaweq has quit IRC | 20:41 | |
| *** slaweq_ has quit IRC | 20:45 | |
| *** slaweq has joined #openstack-meeting-5 | 20:48 | |
| *** yamahata has quit IRC | 21:06 | |
| *** iyamahat_ has quit IRC | 21:06 | |
| *** slaweq has quit IRC | 21:24 | |
| *** slaweq has joined #openstack-meeting-5 | 21:47 | |
| *** slaweq has quit IRC | 21:51 | |
| *** slaweq has joined #openstack-meeting-5 | 22:01 | |
| *** slaweq has quit IRC | 22:06 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 22:28 | |
| *** felipemonteiro has quit IRC | 22:32 | |
| *** iyamahat has joined #openstack-meeting-5 | 22:39 | |
| *** yamahata has joined #openstack-meeting-5 | 22:58 | |
| *** felipemonteiro_ has quit IRC | 23:18 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!