| *** makowals has joined #openstack-meeting-5 | 00:30 | |
| *** makowals has quit IRC | 01:00 | |
| *** makowals has joined #openstack-meeting-5 | 01:06 | |
| *** makowals has quit IRC | 02:13 | |
| *** iyamahat has quit IRC | 02:17 | |
| *** yamahata has quit IRC | 02:17 | |
| *** elynn has joined #openstack-meeting-5 | 02:19 | |
| *** makowals has joined #openstack-meeting-5 | 02:35 | |
| *** yamahata has joined #openstack-meeting-5 | 03:08 | |
| *** markvoelker has quit IRC | 03:09 | |
| *** ramishra has quit IRC | 03:21 | |
| *** ramishra has joined #openstack-meeting-5 | 03:23 | |
| *** ramishra has quit IRC | 03:32 | |
| *** ramishra has joined #openstack-meeting-5 | 03:34 | |
| *** Guest85080 has joined #openstack-meeting-5 | 04:02 | |
| *** Rockyg has joined #openstack-meeting-5 | 04:07 | |
| *** elynn has quit IRC | 04:11 | |
| *** Guest85080 is now known as amrith | 04:12 | |
| *** amrith- has joined #openstack-meeting-5 | 04:12 | |
| *** amrith- is now known as amrith | 04:13 | |
| *** amrith is now known as Guest30664 | 04:13 | |
| *** Guest30664 has quit IRC | 04:13 | |
| *** amrith- has joined #openstack-meeting-5 | 04:14 | |
| *** amrith- is now known as amrith | 04:16 | |
| *** ramishra has left #openstack-meeting-5 | 04:16 | |
| *** amrith has quit IRC | 04:52 | |
| *** amrith has joined #openstack-meeting-5 | 04:53 | |
| *** markvoelker has joined #openstack-meeting-5 | 05:10 | |
| *** markvoelker has quit IRC | 05:44 | |
| *** markvoelker has joined #openstack-meeting-5 | 06:01 | |
| *** markvoelker has quit IRC | 06:06 | |
| *** skazi has joined #openstack-meeting-5 | 06:56 | |
| *** markvoelker has joined #openstack-meeting-5 | 07:02 | |
| *** rarcea has joined #openstack-meeting-5 | 07:11 | |
| *** rarcea has quit IRC | 07:20 | |
| *** Rockyg has quit IRC | 07:24 | |
| *** rarcea has joined #openstack-meeting-5 | 07:27 | |
| *** markvoelker has quit IRC | 07:36 | |
| *** aarefiev_afk is now known as aarefiev | 07:43 | |
| *** skazi has quit IRC | 07:46 | |
| *** ralonsoh has joined #openstack-meeting-5 | 08:00 | |
| *** skazi has joined #openstack-meeting-5 | 08:30 | |
| *** markvoelker has joined #openstack-meeting-5 | 08:33 | |
| *** rarcea has quit IRC | 08:34 | |
| *** rarcea has joined #openstack-meeting-5 | 08:34 | |
| *** rarcea has quit IRC | 08:35 | |
| *** rarcea has joined #openstack-meeting-5 | 08:35 | |
| *** markvoelker has quit IRC | 09:07 | |
| *** yamahata has quit IRC | 09:51 | |
| *** iyamahat has joined #openstack-meeting-5 | 09:56 | |
| *** iyamahat has quit IRC | 09:56 | |
| *** markvoelker has joined #openstack-meeting-5 | 10:03 | |
| *** markvoelker has quit IRC | 10:37 | |
| *** markvoelker has joined #openstack-meeting-5 | 11:11 | |
| *** ralonsoh has quit IRC | 11:50 | |
| *** ralonsoh has joined #openstack-meeting-5 | 11:50 | |
| *** mattmceuen has joined #openstack-meeting-5 | 12:02 | |
| *** skazi has quit IRC | 12:10 | |
| *** mattmceuen has quit IRC | 12:40 | |
| *** markvoelker has quit IRC | 12:40 | |
| *** markvoelker has joined #openstack-meeting-5 | 12:52 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 13:43 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 13:44 | |
| *** mattmceuen has joined #openstack-meeting-5 | 13:48 | |
| *** felipemonteiro has quit IRC | 13:49 | |
| *** makowals has quit IRC | 13:54 | |
| *** lujinluo has joined #openstack-meeting-5 | 13:54 | |
| *** makowals has joined #openstack-meeting-5 | 13:57 | |
| *** ihrachys has joined #openstack-meeting-5 | 14:00 | |
| ihrachys | #startmeeting neutron_upgrades | 14:00 |
|---|---|---|
| openstack | Meeting started Thu Jul 20 14:00:55 2017 UTC and is due to finish in 60 minutes. The chair is ihrachys. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| *** openstack changes topic to " (Meeting topic: neutron_upgrades)" | 14:00 | |
| openstack | The meeting name has been set to 'neutron_upgrades' | 14:00 |
| * ihrachys waves at lujinluo | 14:01 | |
| ihrachys | we'll wait for a bit for manjeets | 14:01 |
| lujinluo | o/ | 14:01 |
| lujinluo | sure | 14:01 |
| ihrachys | hmmm | 14:03 |
| ihrachys | looks like Manjeet is struggling with the new time ;) | 14:03 |
| ihrachys | anyhow, let's walk through what we have | 14:03 |
| lujinluo | haha, sure | 14:04 |
| ihrachys | #topic Actions from previous week | 14:04 |
| *** openstack changes topic to "Actions from previous week (Meeting topic: neutron_upgrades)" | 14:04 | |
| ihrachys | this week we have 3 items | 14:04 |
| ihrachys | all on me | 14:04 |
| ihrachys | neither done :-x | 14:04 |
| lujinluo | :-x | 14:04 |
| ihrachys | first was "ihrachys to take over port binding level OVO" and I just started looking but didn't get to anything meaningful | 14:04 |
| ihrachys | second was "ihrachys to review CLI patch for data migration" and I haven't had a single look :-x | 14:05 |
| ihrachys | and second was "ihrachys to take a look at https://bugs.launchpad.net/neutron/+bug/1704000" | 14:05 |
| openstack | Launchpad bug 1704000 in neutron "Sometimes OVO unit tests clash on non-unique attributes" [High,In progress] - Assigned to Lujin Luo (luo-lujin) | 14:05 |
| ihrachys | for that, lujinluo took it over because he needs to do a similar fix for floating ip OVO | 14:05 |
| ihrachys | lujinluo, thanks for that :) | 14:05 |
| lujinluo | no problem. hmm, btw, it should be she ;) | 14:05 |
| ihrachys | oops sorry | 14:06 |
| lujinluo | haha, never mind | 14:06 |
| ihrachys | well that's an embarrassing assumption actually :) anyhow. | 14:06 |
| lujinluo | don't worry about that. it happens a lot.. ;) | 14:07 |
| ihrachys | yeah | 14:08 |
| ihrachys | #topic Gate breakages | 14:08 |
| *** openstack changes topic to "Gate breakages (Meeting topic: neutron_upgrades)" | 14:08 | |
| ihrachys | so one is on lujinluo that is the unique constraint failures | 14:08 |
| ihrachys | lujinluo, you mentioned in gerrit that it may not help with the bug though, or am I misread? | 14:08 |
| lujinluo | yes, it seems to be not related. but i am still trying to put them together | 14:09 |
| lujinluo | because how we deal with unique tuples | 14:09 |
| lujinluo | currently when unique tuples are found, we jump back to gent_random_object_fields() | 14:10 |
| *** manjeets_ has joined #openstack-meeting-5 | 14:10 | |
| lujinluo | but in RouterL3AgentBinding's case, the composite unique key is within update_object_fields() | 14:10 |
| lujinluo | so we will end up in a infinite loop | 14:11 |
| ihrachys | oh. but then how do tests work? I think we create all three objects from the generated fields, no? they would fail on creating the second one? | 14:11 |
| ihrachys | or maybe we don't really create all three?.. | 14:11 |
| lujinluo | the creation is in update_object_fields() and we do not have unique key check in it. i am trying to add it | 14:12 |
| ihrachys | ack | 14:13 |
| lujinluo | but even though i add the check in update_object_fields(), when we found the unique tuple in get_randon_object_fields(), it ends up in infinite loops generating random values. need to take closer look tmr | 14:13 |
| ihrachys | ok. if you feel that's a separate matter and not really related, we may remove Closes-Bug and have a fix just for your thing, no need to lump then | 14:15 |
| lujinluo | ok, got it. | 14:15 |
| ihrachys | speaking of other breakages triggered by OVO, we hit this in Red Hat CI for Pike: https://bugzilla.redhat.com/show_bug.cgi?id=1470784 | 14:16 |
| openstack | bugzilla.redhat.com bug 1470784 in openstack-neutron "The API test test_associate_floating_ip_with_port_from_another_tenant fails" [Unspecified,Assigned] - Assigned to ihrachys | 14:16 |
| ihrachys | since switch to IPAllocation OVO, we get this when retry is triggered: | 14:16 |
| ihrachys | 2017-07-13 15:20:51.064 85185 ERROR neutron.pecan_wsgi.hooks.translation FlushError: New instance <IPAllocation at 0x8b3f7d0> with identity key (<class 'neutron.db.models_v2.IPAllocation'>, ('2003::1:f816:3eff:fe3f:aa00', '8032a1cd-9236-4126-83fa-2f039ed2b890', 'c0542b84-bcd0-48e1-ace1-6da1f50246dc')) conflicts with persistent instance <IPAllocation at 0x89ac310> | 14:16 |
| ihrachys | I should report it in LP | 14:16 |
| ihrachys | I have a potential fix for that here: https://review.openstack.org/#/c/485328/ | 14:16 |
| ihrachys | there was a bug in the switching patch that was adding OVO object to sqlalchemy session to keep reference to the model, which obviously doesn't work | 14:17 |
| manjeets_ | I am also having a session.id expire issue with networkdhcpagentbinding ovo | 14:19 |
| manjeets_ | http://logs.openstack.org/52/370452/50/check/gate-neutron-python27-ubuntu-xenial/c1f6301/testr_results.html.gz | 14:19 |
| ihrachys | I am still to test the patch, but lujinluo I would like to see you eyeballing it since you polished the switch patch. I hope I don't break anything with the fix. | 14:19 |
| lujinluo | ihrachys, sure. will do | 14:20 |
| manjeets_ | I specified lazy in db model which fixed the constant_query_test but broke others | 14:20 |
| ihrachys | manjeets_, is it because your agent model is not fetched via relationship? | 14:20 |
| ihrachys | oh that's with lazy load? | 14:20 |
| ihrachys | (well it's not really lazy; whoever came up with the name for sqlalchemy is guilty as hell) | 14:21 |
| manjeets_ | for some reason when I specify lazy to subquery or joined it loses its session | 14:21 |
| manjeets_ | it fails while expunging because hash doesn't match with session id | 14:22 |
| manjeets_ | https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/orm/session.py#L1625 | 14:22 |
| manjeets_ | it just loses session_id not the entire session | 14:23 |
| ihrachys | manjeets_, do we hit the model with .expunge() in _detach_db_obj before this other call? | 14:24 |
| lujinluo | does this only happen in OVO patch? I think I have seen something similar but it happens to synthetic field. | 14:24 |
| ihrachys | lujinluo, it is synthetic I believe. an object-field loaded via load_synthetic_db_fields | 14:25 |
| ihrachys | right? | 14:25 |
| manjeets_ | something while loading synthetic field for second object | 14:25 |
| manjeets_ | https://github.com/openstack/neutron/blob/master/neutron/objects/base.py#L346 | 14:25 |
| lujinluo | yes, i think same place | 14:26 |
| manjeets_ | with in it it tries to load ovo and fails, on expunge | 14:26 |
| ihrachys | manjeets_, I would look at the order of all expunge calls. maybe we first expunge the binding (that will probably expunge linked agent model too?), then the agent model | 14:27 |
| manjeets_ | but db query gets the right db_objs | 14:27 |
| manjeets_ | afair, I think order was same when I add lazy with when I remove it, but not 100% sure will check today | 14:28 |
| ihrachys | manjeets_, do multiple bindings point to the same agent? | 14:30 |
| ihrachys | if so, then get_objects() will expunge those agents (via bindings) over and over? [I am not sure expunge traverse recursively though] | 14:30 |
| manjeets_ | no I was able to see two agents one for each network | 14:31 |
| manjeets_ | in the tests atleast | 14:31 |
| ihrachys | ok it doesn't seem like we can solve it during the meeting. :) | 14:32 |
| manjeets_ | once i check today I may hit on neutron channel today | 14:33 |
| manjeets_ | hit you** | 14:33 |
| ihrachys | ok, just pick a harder stick | 14:33 |
| ihrachys | :) | 14:33 |
| manjeets_ | lol | 14:33 |
| ihrachys | I need it, really. | 14:33 |
| ihrachys | haven't reviewed what I should have :) | 14:34 |
| ihrachys | #topic OVO patches | 14:34 |
| *** openstack changes topic to "OVO patches (Meeting topic: neutron_upgrades)" | 14:34 | |
| ihrachys | https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db | 14:34 |
| ihrachys | going top to bottom | 14:34 |
| ihrachys | https://review.openstack.org/#/c/466237/ is router-port to port relationship. I saw lujinluo was planning to look at a better place for .refresh so I put it to wip. | 14:35 |
| ihrachys | I hope that's fine | 14:35 |
| lujinluo | sure. too many .refresh() in that patch. | 14:35 |
| ihrachys | :) that's true. sqlalchemy is sometimes moody. | 14:35 |
| ihrachys | next is https://review.openstack.org/#/c/482722/ (Integrate ovo in type_vlan cleanup) | 14:36 |
| ihrachys | I think we wait for author reply on the suggestion to add test coverage | 14:36 |
| ihrachys | next is https://review.openstack.org/#/c/407868/ (Integration of (Distributed) Port Binding OVO) | 14:36 |
| lujinluo | hmm, i need a harder stick for this one too | 14:37 |
| ihrachys | manjeets_, you have work to do man | 14:37 |
| manjeets_ | i need that too, haven't completed what I should have | 14:37 |
| lujinluo | lol | 14:37 |
| ihrachys | lujinluo, but seriously, you do a lot of parallel things, no wonder some things may slip from time to time, it's totally cool :) | 14:38 |
| ihrachys | next is https://review.openstack.org/#/c/481972/ (FloatingIP to OVO) | 14:38 |
| ihrachys | I think it's good, just waits for resolution on generator for unique constraints fix | 14:38 |
| ihrachys | I will +2 when we solve the underlying on | 14:39 |
| ihrachys | *one | 14:39 |
| lujinluo | ack | 14:39 |
| ihrachys | next to discuss is https://review.openstack.org/#/c/424154/ (RouterPort OVO integration) | 14:39 |
| ihrachys | I see lujinluo respinned it | 14:40 |
| ihrachys | I will review | 14:40 |
| lujinluo | thanks! i am not sure how to deal with Port as a synthetic field so I used .db_obj | 14:41 |
| lujinluo | please review and comment | 14:41 |
| *** marst has joined #openstack-meeting-5 | 14:41 | |
| ihrachys | yeah, I see. btw those comments should probably be in the format of TODO(lujinluo) ...text... so that we can grep for TODO/name later | 14:41 |
| ihrachys | I will | 14:41 |
| lujinluo | ah, I see. will add them in next PS | 14:42 |
| ihrachys | next is network dhcp agent binding but I discussed that before | 14:42 |
| ihrachys | next is dvr mac address: https://review.openstack.org/#/c/304873/ | 14:42 |
| ihrachys | it has +2, need to get another one | 14:42 |
| ihrachys | probably from Kevin since he did review it in the past | 14:42 |
| ihrachys | woa, I continued the meeting in neutron channel lol | 14:48 |
| ihrachys | I am pathetic | 14:48 |
| ihrachys | anyhow | 14:48 |
| ihrachys | #topic Open discussion | 14:48 |
| *** openstack changes topic to "Open discussion (Meeting topic: neutron_upgrades)" | 14:48 | |
| ihrachys | note that we are approaching feature freeze dates at which point we may hit a temporary lock on new patch merges, usually taking about 2 weeks. | 14:48 |
| lujinluo | wow, i was waiting | 14:48 |
| ihrachys | lujinluo, I was wondering why no one replies :p | 14:49 |
| ihrachys | I think freeze is ~month from now | 14:49 |
| ihrachys | checking calendar | 14:49 |
| lujinluo | i think it is the last week of July | 14:49 |
| ihrachys | yeah, first RC is Aug 07 - Aug 11 | 14:49 |
| lujinluo | aha, bad memory :-x | 14:50 |
| ihrachys | well feature freeze is indeed the last week of July | 14:50 |
| ihrachys | but RC is one week later | 14:50 |
| ihrachys | some time there, we will be locked | 14:50 |
| *** yamamoto has joined #openstack-meeting-5 | 14:50 | |
| ihrachys | it's usually till RC that we have ability to cautiously land some patches | 14:50 |
| lujinluo | ok.. | 14:51 |
| ihrachys | ok let's wrap it up | 14:52 |
| ihrachys | thanks everyone | 14:52 |
| ihrachys | #endmeeting | 14:52 |
| lujinluo | thanks! | 14:52 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings" | 14:52 | |
| openstack | Meeting ended Thu Jul 20 14:52:30 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:52 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2017/neutron_upgrades.2017-07-20-14.00.html | 14:52 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/neutron_upgrades/2017/neutron_upgrades.2017-07-20-14.00.txt | 14:52 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/neutron_upgrades/2017/neutron_upgrades.2017-07-20-14.00.log.html | 14:52 |
| lujinluo | have a nice day ihrachys and manjeets_ | 14:52 |
| ihrachys | lujinluo, have a good rest | 14:53 |
| manjeets_ | thanks lujinluo gn | 14:53 |
| *** lujinluo has quit IRC | 14:53 | |
| *** manjeets_ has quit IRC | 14:54 | |
| *** yamamoto has quit IRC | 14:55 | |
| *** yamamoto has joined #openstack-meeting-5 | 14:57 | |
| *** vkmc_ has joined #openstack-meeting-5 | 15:01 | |
| *** yamamoto has quit IRC | 15:03 | |
| *** felipemonteiro_ has quit IRC | 15:11 | |
| *** tiendc has joined #openstack-meeting-5 | 15:30 | |
| *** Rockyg has joined #openstack-meeting-5 | 15:38 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 15:43 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 15:44 | |
| *** felipemonteiro has quit IRC | 15:48 | |
| *** tuanla_fujitsu has joined #openstack-meeting-5 | 15:50 | |
| *** tuanla__ has joined #openstack-meeting-5 | 15:50 | |
| *** hshiina has joined #openstack-meeting-5 | 15:59 | |
| TheJulia | #startmeeting ironic_bfv | 16:00 |
| openstack | Meeting started Thu Jul 20 16:00:38 2017 UTC and is due to finish in 60 minutes. The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| *** openstack changes topic to " (Meeting topic: ironic_bfv)" | 16:00 | |
| openstack | The meeting name has been set to 'ironic_bfv' | 16:00 |
| TheJulia | Who is here for a boot from volume meeting? | 16:00 |
| *** phuongnh has joined #openstack-meeting-5 | 16:00 | |
| hshiina | o/ | 16:01 |
| phuongnh | o/ | 16:01 |
| tiendc | o? | 16:01 |
| TheJulia | Greetings everyone | 16:01 |
| TheJulia | Our agenda, as always is on the wiki. | 16:02 |
| TheJulia | #link https://wiki.openstack.org/wiki/Meetings/Ironic-BFV | 16:02 |
| *** mjturek has joined #openstack-meeting-5 | 16:02 | |
| TheJulia | #topic Announcements/Reminders | 16:02 |
| *** openstack changes topic to "Announcements/Reminders (Meeting topic: ironic_bfv)" | 16:02 | |
| mjturek | o/ | 16:02 |
| TheJulia | #info Next week is Pike-3 and the feature freeze for nova. | 16:02 |
| *** dtantsur has joined #openstack-meeting-5 | 16:02 | |
| dtantsur | o/ | 16:03 |
| TheJulia | #info About an hour ago, we achieved a mostly successful tempest run, which only failed in cleaning up the node. More investigation required. | 16:03 |
| mjturek | \o/ | 16:03 |
| mjturek | that's awesome | 16:03 |
| hshiina | TheJulia: thank you for the work | 16:03 |
| TheJulia | #link http://logs.openstack.org/49/485349/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial/6a71f11/logs/ironic-bm-logs/node-0_console_2017-07-20-15:07:22.txt.gz | 16:04 |
| *** tuanla_fujitsu has quit IRC | 16:04 | |
| *** tuanla__ has quit IRC | 16:04 | |
| TheJulia | Anyone have any other updates before we move into current status? | 16:04 |
| mjturek | nothing from me | 16:05 |
| hshiina | i have nothing | 16:05 |
| TheJulia | Okay, moving on then | 16:05 |
| TheJulia | #topic Current Status | 16:05 |
| *** openstack changes topic to "Current Status (Meeting topic: ironic_bfv)" | 16:05 | |
| TheJulia | My apologies, I've not kept up with the ether pad this week, but I can enumerate our current status and where we need to focus on at the moment. | 16:06 |
| *** tuanla_fujitsu has joined #openstack-meeting-5 | 16:06 | |
| TheJulia | #link https://etherpad.openstack.org/p/Ironic-BFV | 16:06 |
| dtantsur | TheJulia: I wonder if it's going to be enough for Nova folks that most of the test has passed | 16:07 |
| TheJulia | #info Requested refactoring of the nova change has raised some issues. The code works, as seen in announcements, but the tests need to be updated. I've kind of noted it in that revision | 16:07 |
| hshiina | TheJulia: i will update the tests | 16:08 |
| TheJulia | #link https://review.openstack.org/#/c/215385/ | 16:08 |
| TheJulia | hshiina: it will likely be worth pinging mriedem as we have a structural conundrum there. | 16:09 |
| TheJulia | I can also try and start that discussion with him today | 16:10 |
| hshiina | TheJulia: thanks | 16:11 |
| TheJulia | Additionally, another patch was proposed https://review.openstack.org/#/c/485550/ which I suspect they are not going to be willing to take, but I can ask. | 16:11 |
| TheJulia | dtantsur: I'll update my notes on the nova rev and ping mriedem with the partial success | 16:12 |
| dtantsur | cool | 16:12 |
| dtantsur | yeah, I believe the result we have is good enough to proceed, but I may be wrong | 16:12 |
| TheJulia | The other thing that we need to work out is why the clean-up went sideways in the ironic conductor on the job that booted. | 16:12 |
| TheJulia | dtantsur: ditto, as long as we get the tests fixed. | 16:12 |
| TheJulia | s/fixed/sorted/ | 16:12 |
| TheJulia | since there is a conundrum there as well. | 16:13 |
| TheJulia | Other than that, I think the patches inside ironic are looking fairly good, minor fixes likely need to be addressed, but devstack/tempest are under review, and hopefully we can figure out the ironic problem fairly quickly and go from there. | 16:13 |
| TheJulia | I think we just figured out the plan for the next few days too :) | 16:14 |
| TheJulia | Any questions/comments/concerns? | 16:14 |
| mjturek | Do nova changes need more eyes on them? or do we just getting nova cores to look | 16:14 |
| mjturek | (I guess more eyes never hurts) | 16:14 |
| TheJulia | mjturek: more eyes would likely help, but we're fairly close to landing, just the requirement they placed upon us was a passing test run in CI, since the experimental gate change was pending :) | 16:15 |
| dtantsur | IIRC we have 2 patches, right? | 16:16 |
| dtantsur | what's up with the second one? | 16:16 |
| mjturek | cool cool, I'll try to help with the cleaning debugging as well | 16:16 |
| dtantsur | is it critical to merge it as well? | 16:16 |
| TheJulia | As I understand it, it is not critical to merge this cycle | 16:16 |
| TheJulia | hshiina: please correct me if I'm wrong | 16:17 |
| hshiina | I don't think it's critical | 16:17 |
| dtantsur | okay, so we mostly need to drag nova folks into reviewing and merging the first | 16:17 |
| TheJulia | dtantsur: yup, once we fix the unit tests | 16:18 |
| TheJulia | Turns out we can't mock a blockdevicevolumemapping object, you can only mock a blockdevicemapping with the tools, and you get back a list. so the code that works, fails testing because of object issues as one wraps the other | 16:19 |
| TheJulia | It is all spelled out in revision 24 thorough the current revision of the first nova patch. | 16:19 |
| TheJulia | of course, they may look at it and backpedal on how we got there which was to not hit the database again | 16:20 |
| TheJulia | Does anyone have anything to add to current status, or have I overwhelmed everyone with information? | 16:21 |
| * TheJulia hears crickets | 16:22 | |
| dtantsur | thanks for the update! | 16:22 |
| mjturek | lol, I'm good :) | 16:22 |
| jlvillal | o/ | 16:22 |
| TheJulia | \o jlvillal | 16:22 |
| TheJulia | Well, then, I guess it is Open Discussion time. | 16:23 |
| TheJulia | #topic Open Discussion | 16:23 |
| *** openstack changes topic to "Open Discussion (Meeting topic: ironic_bfv)" | 16:23 | |
| TheJulia | Do we have anything else to discuss this week? | 16:23 |
| mjturek | I forgot to add something to the agenda but I was hoping to discuss a comment from hshiina on one of my patches | 16:23 |
| mjturek | #link https://review.openstack.org/#/c/472856/8 | 16:24 |
| mjturek | "Isn't it necessary to remove the similar validation in storage interface" | 16:24 |
| mjturek | wondering if there's any reason not to | 16:24 |
| TheJulia | I'm thinking it should be kept | 16:25 |
| mjturek | just in case the code gets called independently? | 16:25 |
| TheJulia | yeah | 16:25 |
| mjturek | okay fair enough | 16:26 |
| TheJulia | say someone mucks with their configs, restarts the conductor, and calls node-validate | 16:26 |
| mjturek | oh - that's a good point | 16:27 |
| mjturek | well even then, wouldn't both the pxe interface and storage interface get validated? | 16:27 |
| TheJulia | pxe should as well, but the contract is the storage interface work for cinder had to use ipxe | 16:28 |
| mjturek | (I mean, validate get called on both those interfaces) | 16:28 |
| TheJulia | or it had to be enabled | 16:28 |
| TheJulia | but | 16:28 |
| TheJulia | at the same time, it is a different thing, if one has all virtual media drivers, then they don't need ipxe booting | 16:28 |
| TheJulia | dtantsur: thoughts? | 16:28 |
| * dtantsur looks | 16:29 | |
| dtantsur | interesting indeed, I wonder if it should somehow be a part of the boot interface.. | 16:30 |
| mjturek | dtantsur: so the change does make the validation part of the pxe boot interface, but I don't remove similar validation from the storage interface | 16:32 |
| dtantsur | ah, ok | 16:32 |
| dtantsur | yeah, I guess the storage interface cannot know if it's compatible with the boot interface | 16:32 |
| TheJulia | I sense possibly a little more pondering? | 16:33 |
| mjturek | yeaaah - I'm cool with having the discussion in the review! | 16:34 |
| TheJulia | Maybe put a TODO note to reconsider the check in the storage interface or remove it if necessary because of PXE boot? | 16:34 |
| mjturek | +1 | 16:34 |
| mjturek | sounds good to me | 16:34 |
| TheJulia | I imagine someone at some point is going to ask for it to be removed, or the logic adjusted, and we can easily re-evaluate then. | 16:35 |
| TheJulia | And if we have a note, then the history is documented, and it can be a easy decision. | 16:35 |
| hshiina | i'm fine with the idea | 16:36 |
| mjturek | very cool thanks TheJulia dtantsur hshiina :) | 16:36 |
| TheJulia | Okay, well if there is nothing else. I've already updated the nova revision with the latest comments, and mjturek we can begin digging through the logs to try and figure out what happened with the cleaning step. | 16:37 |
| mjturek | cool! | 16:37 |
| TheJulia | Okay, see everyone in #openstack-ironic | 16:38 |
| TheJulia | Thanks everyone! | 16:38 |
| hshiina | thanks | 16:38 |
| TheJulia | #endmeeting | 16:38 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings" | 16:38 | |
| openstack | Meeting ended Thu Jul 20 16:38:57 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:38 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/ironic_bfv/2017/ironic_bfv.2017-07-20-16.00.html | 16:39 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/ironic_bfv/2017/ironic_bfv.2017-07-20-16.00.txt | 16:39 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/ironic_bfv/2017/ironic_bfv.2017-07-20-16.00.log.html | 16:39 |
| *** dtantsur has left #openstack-meeting-5 | 16:39 | |
| tiendc | thanks | 16:40 |
| *** hshiina has left #openstack-meeting-5 | 16:40 | |
| phuongnh | thanks | 16:41 |
| *** tiendc has quit IRC | 16:41 | |
| *** phuongnh has quit IRC | 16:41 | |
| *** sshank has joined #openstack-meeting-5 | 16:48 | |
| *** ralonsoh has quit IRC | 17:02 | |
| *** felipemonteiro_ has quit IRC | 17:12 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 17:12 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 17:22 | |
| *** tuanla_fujitsu has quit IRC | 17:24 | |
| *** felipemonteiro has quit IRC | 17:26 | |
| *** vkmc_ has quit IRC | 17:30 | |
| *** yamahata has joined #openstack-meeting-5 | 17:53 | |
| *** krtaylor has quit IRC | 17:56 | |
| *** yamahata has quit IRC | 18:11 | |
| *** makowals has quit IRC | 18:12 | |
| *** Rockyg has quit IRC | 18:12 | |
| *** makowals has joined #openstack-meeting-5 | 18:21 | |
| *** makowals has quit IRC | 18:25 | |
| *** krtaylor has joined #openstack-meeting-5 | 18:28 | |
| *** yamahata has joined #openstack-meeting-5 | 18:47 | |
| *** sshank has quit IRC | 19:06 | |
| *** skazi has joined #openstack-meeting-5 | 19:23 | |
| *** skazi has quit IRC | 19:41 | |
| *** openstack has joined #openstack-meeting-5 | 20:00 | |
| *** ChanServ sets mode: +o openstack | 20:00 | |
| *** iyamahat has joined #openstack-meeting-5 | 20:07 | |
| *** iyamahat_ has joined #openstack-meeting-5 | 20:09 | |
| *** sshank has joined #openstack-meeting-5 | 20:10 | |
| *** iyamahat has quit IRC | 20:11 | |
| *** makowals has joined #openstack-meeting-5 | 20:12 | |
| *** makowals has quit IRC | 21:03 | |
| *** krtaylor has quit IRC | 21:07 | |
| *** yamamoto has joined #openstack-meeting-5 | 21:57 | |
| *** rarcea has quit IRC | 22:00 | |
| *** yamamoto has quit IRC | 22:00 | |
| *** felipemonteiro_ has quit IRC | 22:01 | |
| *** iyamahat__ has joined #openstack-meeting-5 | 22:02 | |
| *** iyamahat_ has quit IRC | 22:04 | |
| *** sshank has quit IRC | 22:08 | |
| *** marst has quit IRC | 22:19 | |
| *** sshank has joined #openstack-meeting-5 | 22:23 | |
| *** iyamahat_ has joined #openstack-meeting-5 | 22:42 | |
| *** iyamahat__ has quit IRC | 22:44 | |
| *** yamamoto has joined #openstack-meeting-5 | 23:01 | |
| *** yamamoto has quit IRC | 23:07 | |
| *** ihrachys has quit IRC | 23:10 | |
| *** sshank has quit IRC | 23:41 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!