Thursday, 2017-05-25

*** zenirc369 has joined #openstack-meeting-500:09
*** zenirc369 has quit IRC00:23
*** eanylin has joined #openstack-meeting-500:26
*** notmyname has quit IRC02:08
*** notmyname has joined #openstack-meeting-502:13
*** ricolin has joined #openstack-meeting-502:19
*** benj_ has quit IRC04:03
*** benj_ has joined #openstack-meeting-504:04
*** markvoelker has joined #openstack-meeting-504:13
*** zenirc369 has joined #openstack-meeting-504:44
*** markvoelker_ has joined #openstack-meeting-505:11
*** markvoelker has quit IRC05:14
*** markvoelker has joined #openstack-meeting-505:17
*** markvoel_ has joined #openstack-meeting-505:19
*** markvoelker has quit IRC05:19
*** markvoelker_ has quit IRC05:21
*** korzen has joined #openstack-meeting-505:52
*** markvoel_ has quit IRC05:53
*** markvoelker has joined #openstack-meeting-505:53
*** markvoelker has quit IRC05:54
*** markvoelker has joined #openstack-meeting-506:27
*** markvoelker has quit IRC06:32
*** ralonsoh has joined #openstack-meeting-506:55
*** markvoelker has joined #openstack-meeting-506:59
*** markvoelker has quit IRC07:03
*** markvoelker has joined #openstack-meeting-507:09
*** dixiaoli has joined #openstack-meeting-507:13
*** markvoelker has quit IRC07:14
*** markvoelker has joined #openstack-meeting-507:29
*** markvoelker has quit IRC07:37
*** markvoelker has joined #openstack-meeting-507:42
*** markvoelker has quit IRC07:49
*** LanceHaig has quit IRC08:06
*** LanceHaig has joined #openstack-meeting-508:15
*** LanceHaig has joined #openstack-meeting-508:15
*** markvoelker has joined #openstack-meeting-508:24
*** markvoelker has quit IRC08:30
*** markvoelker has joined #openstack-meeting-508:32
*** markvoelker has quit IRC08:40
*** derekh has joined #openstack-meeting-509:09
*** markvoelker has joined #openstack-meeting-509:16
*** markvoelker has quit IRC09:21
*** markvoelker has joined #openstack-meeting-509:54
*** markvoelker has quit IRC09:58
*** dixiaoli has quit IRC10:39
*** markvoelker has joined #openstack-meeting-510:47
*** markvoelker has quit IRC10:52
*** markvoelker has joined #openstack-meeting-510:55
*** markvoelker has quit IRC10:59
*** ricolin has quit IRC11:02
*** ricolin has joined #openstack-meeting-511:03
*** markvoelker has joined #openstack-meeting-511:14
*** markvoelker has quit IRC11:19
*** markvoelker has joined #openstack-meeting-511:29
*** markvoelker has quit IRC11:34
*** markvoelker has joined #openstack-meeting-512:00
*** markvoelker has quit IRC12:04
*** markvoelker has joined #openstack-meeting-512:11
*** markvoelker has quit IRC12:15
*** markvoelker has joined #openstack-meeting-512:17
*** markvoelker has quit IRC12:22
*** markvoelker has joined #openstack-meeting-512:56
*** korzen has quit IRC13:13
*** dixiaoli has joined #openstack-meeting-513:26
*** dixiaoli has quit IRC13:28
*** markvoelker has quit IRC13:33
*** eanylin has quit IRC13:37
*** eanylin has joined #openstack-meeting-513:51
*** markvoelker has joined #openstack-meeting-514:15
*** zenirc369 has quit IRC14:21
*** markvoelker has quit IRC14:23
*** felipemonteiro has joined #openstack-meeting-514:30
*** korzen has joined #openstack-meeting-514:52
*** markvoelker has joined #openstack-meeting-515:01
*** korzen has quit IRC15:02
*** marst_ has joined #openstack-meeting-515:05
*** derekh has quit IRC15:10
*** felipemonteiro has quit IRC15:14
*** hshiina has joined #openstack-meeting-515:48
*** tiendc has joined #openstack-meeting-515:52
*** phuongnh has joined #openstack-meeting-515:56
TheJuliao/16:00
TheJulia#startmeeting ironic_bfv16:01
openstackMeeting started Thu May 25 16:01:00 2017 UTC and is due to finish in 60 minutes.  The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot.16:01
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:01
*** openstack changes topic to " (Meeting topic: ironic_bfv)"16:01
openstackThe meeting name has been set to 'ironic_bfv'16:01
mjtureko/16:01
hshiinao/16:01
TheJuliaGreetings everyone!16:01
mjturekhey TheJulia :)16:01
TheJuliaAs always, our agenda for today is on our wiki page.16:01
TheJulia#link https://wiki.openstack.org/wiki/Meetings/Ironic-BFV#Agenda16:01
TheJulia#topic Announcements/Reminders16:02
*** openstack changes topic to "Announcements/Reminders (Meeting topic: ironic_bfv)"16:02
*** dtantsur has joined #openstack-meeting-516:02
dtantsuro/16:02
TheJuliaI have one announcement/ask today from myself, I'll potentially be in meetings on Thursday and wonder if someone would be willing to run this meeting next week if I'm unavailable.16:02
TheJuliao/ dtantsur16:03
mjturekI can run it!16:03
TheJuliamjturek: Awesome16:03
TheJulia#info mjturek has volunteered to run the next meeting if TheJulia is unavailable.16:03
TheJuliaAnyone have anything else?16:03
dtantsurthanks mjturek!16:03
mjtureknppp, I'll ping you TheJulia before to confirm16:04
TheJuliamjturek: excellent, Thanks!16:04
TheJuliaSo if nobody has anything else for annoucements, we can move on16:04
TheJulia#topic Current Status16:05
*** openstack changes topic to "Current Status (Meeting topic: ironic_bfv)"16:05
TheJulia#link https://etherpad.openstack.org/p/Ironic-BFV16:05
TheJuliaIt looks like we managed to get a few patches landed this week \o/16:05
mjturekso cinder driver has merged - thanks dtantsur and sambetts for the reviews16:05
dtantsurnp :)16:06
TheJuliahshiina: Regarding the status ether pad, I noticed you updated a patch or two.  When I went through the revisions about an hour ago, I noted their current state, so the ether pad may be slightly out of date for those revisions.16:07
hshiinasorry, i started rebasing a few patches.16:08
TheJuliamjturek: you indicated you only rebased and put a change in on the wire-in patch, I think I have some minor changes locally for that one as well, and I'll have to reconcile that and push it up16:08
TheJuliahshiina: no apologies necessary :)16:08
mjturekcool, yep I added 'cinder' to the default drivers list (and updated the commit message to indicate that). Tests were failing16:09
TheJuliaAnd mjturek has a few discussion items for the ipxe patch, so I guess we should move along. :)16:09
TheJuliaAwesome16:09
TheJuliaTime to discuss priorities?16:10
mjturekoh - I uploaded a follow up patch for the cinder driver as well16:10
TheJuliaI saw, thank you16:10
mjturektake a look, but I don't like that the detach_volumes signature is different than the base class :-\16:10
TheJulia#topic Planning/Priorities16:11
*** openstack changes topic to "Planning/Priorities (Meeting topic: ironic_bfv)"16:11
TheJuliaPriorities as I see them is the ipxe patch, the wire-in patch which I should be able to reconcile and get updated quickly, and then the deploy skip patch.  The last of which may be impacted by one of the discussion items.16:11
mjtureksounds good to me]16:12
hshiinasounds good to me, too16:12
TheJuliaSounds like we are in agreement.16:13
dtantsur++16:13
TheJuliaAnd with that, if nobody has anything else, then we should move on to discussion :)16:13
TheJulia#topic Discussion16:14
*** openstack changes topic to "Discussion (Meeting topic: ironic_bfv)"16:14
* TheJulia hands the microphone to mjturek 16:14
mjturekSo first item is on the wirein patch16:14
mjturekdtantsur mentioned that we should probably move the storage ops up from the driver level16:14
mjturekhttps://review.openstack.org/#/c/413324/20/ironic/drivers/modules/pxe.py@29116:15
dtantsuryeah16:15
mjturekseems like the right approach as the code will need to be in each deploy module the current way16:15
dtantsurotherwise we're doomed to copy-paste it16:15
mjturek:)16:15
dtantsurlike with networking, which is something vdrok wants to address16:15
mjturekI can volunteer to look into it as a followup, unless you'd like to address it in the patch TheJulia16:16
mjturek(or if there's a disagreement here - maybe there's a good reason for it being in the driver level?)16:17
dtantsurI'm fine with a follow-up, as long as it happens rather sooner than later (e.g. as the next patch in the chain)16:17
TheJuliaSo move any helpers into centralized helpers, and move the wire-in calls into the conductor?16:17
TheJuliaHave we identified where we would call the networking in the conductor?16:18
dtantsurnetworking is a separate thing, I guess. or do we want to solve both at once?16:18
* TheJulia feels like it would be best as a follow-up for the conductor part16:18
dtantsurI'm just suggesting that we don't place volume actions in the deploy drivers (or move it away soon)16:18
TheJuliaI feel like we are going to step on each other's feet if we don't have a basic agreement of how in place before we try and do it16:18
mjturekyeah I'd think we'd want to do it around the same spot as the networking16:19
mjturekmaybe vdrok has a plan there already, I can ask him16:19
dtantsurhe has a spec16:19
mjturekoh cool16:19
dtantsur#link https://review.openstack.org/#/c/468000/16:19
* dtantsur is not sure he can use #link here16:19
TheJuliaI guess, there're only two logic places for any of it to really go in the conductor16:19
TheJulia#link https://review.openstack.org/#/c/468000/16:20
TheJuliaI think anyone can, but we can look at the logs later to be sure :)16:20
TheJuliaI feel like the resolution is talk to vdrok, get on the same page, and determine the happy path from there.16:21
mjtureksounds good16:21
TheJuliaand well, read the spec too16:21
mjturek:)16:21
TheJuliaSo, your next item mjturek ?16:22
mjtureksure16:22
mjturek#link https://review.openstack.org/#/c/406290/25/ironic/drivers/modules/agent.py@39616:22
mjturekwhoops16:22
mjturekI swapped the links by accident :)16:23
mjturekhttps://review.openstack.org/#/c/413324/20/ironic/drivers/modules/pxe.py@29116:23
mjturekthis is the one wrt sanhook16:23
TheJuliaI just figured that out too, but the other item does kind of fit with-in the same topic in a way16:23
TheJuliain part16:23
mjturekyep true!16:23
TheJuliaAnyway!16:23
mjturekso I think Anton is correct about the separate sanhooks but I was wondering if people had more insight16:24
mjturekbasically, for multipath the ipxe documentation shows a single call for both paths16:24
mjturekwhile we're doing one sanhook call for each16:24
mjturekshould we be anticipating multipath here and doing the one call instead?16:25
dtantsurare there any reasons not to?16:25
mjturekhonestly I'm not sure. I would think there aren't any reasons not to, but not sure if it's worth the effort or not16:26
TheJuliaSo sanhook should be explicitly executed for each "device", a single device could be defined twice which would represent another path possible, but the OS has to handle that and all16:26
TheJuliahttps://review.openstack.org/#/c/413324/20/ironic/drivers/modules/ipxe_config.template <-- does sanhooks and a sanboot16:27
TheJuliamjturek: last I looked it didn't reference multiple paths16:27
TheJuliadtantsur: no reason not to, we should pass it if we can16:27
dtantsurack16:28
mjturekhmm okay16:30
TheJuliamjturek: so I'm not sure we have a good way of de-duplicating all of the possible paths.  Conceptually for us, they would be unique targets16:30
mjturekokay so basically the OS will handle it16:30
TheJuliathe OS is the only thing that can truly consolidate that back together by looking at data it gets via the connection and if it realizes it is a duplicate that is locked, or if it is a unique device16:31
TheJuliayeah16:31
* TheJulia gets out the "There be dragons here sign"16:31
mjturekfair enough :)16:31
* TheJulia makes a nice concrete foundation for the sign, so it stays around.16:31
mjturekhahaha, okay I'm cool on this then. I'll reply to Anton16:31
TheJuliaI'm feeling like ipxe also just may have added multipath iscsi in their docs....16:32
mjturekas in, they added it recently?16:32
TheJuliayes16:32
mjturekinteresting16:33
* dtantsur prepares his usual complain about ipxe versioning and releases16:33
* TheJulia gives dtantsur the ipxe soap box16:33
dtantsur:D16:33
mjtureklast modified 2017/03/26 so quite possible :-|16:33
TheJuliaYeah, I think I wrote that code late last year, so yeah16:34
TheJulia:(16:34
TheJuliaAnyway, we're in a catch-22 there, but the OS should be responsible for MPIO path management16:34
dtantsurI hope we won't start depending on the iPXE version from this march :)16:34
TheJuliaThe device should get locked anyway along one path16:34
mjturekyeaaaah, sounds reasonable to me16:34
mjturek:)16:34
TheJuliadtantsur: +^one_million16:35
TheJuliaIf the device is not locked, then the OS is either doing something stupid, or the storage is doing something stupid, and chaos can then ensue regardless because it would have on its own anyway.16:36
TheJulia(as in, in no way shape or form mpio safe)16:36
TheJuliaI _think_ we're good16:36
TheJuliaAnything else?16:37
mjturekI'm good16:38
dtantsurditto16:38
TheJulia#topic Open Discussion16:38
*** openstack changes topic to "Open Discussion (Meeting topic: ironic_bfv)"16:38
TheJuliaAnyone have anything for open discussion?16:38
hshiinai noticed cinder doesn't accept metadata with dict16:39
hshiinawhen ironic sets metadata in attach/detach16:39
hshiinawe need to change metadata not to use dict16:40
TheJuliato just be a string?16:40
mjturekhshiina: what should it be using?16:40
hshiinaTheJulia, yes16:40
dtantsurhshiina: I think you mean a non-nested dict, no? /me tries to remember the patch16:41
hshiinadtantsur, yes, non-nested16:41
mjturekhshiina: https://review.openstack.org/#/c/413324/20/ironic/drivers/modules/pxe.py@291 referring to connector?16:41
TheJuliamjturek: I think he is referring to the metadata post to the cinder api upon attachment16:42
TheJuliaof the extra metadata information, which I thought was listed as a dictionary :(16:43
TheJuliaEasy enough to look it up and double check cinder's api code16:43
mjtureksorry wrong link16:43
mjturek https://review.openstack.org/#/c/366197/47/ironic/drivers/modules/storage/cinder.py@32716:43
hshiinaironic creates metadata here: https://github.com/openstack/ironic/blob/767ed8002045defa0a3e982c22a0c4856796df7e/ironic/common/cinder.py#L42516:45
mjturekohhh got it16:45
mjturekthanks16:45
TheJuliahttp://git.openstack.org/cgit/openstack/ironic/tree/ironic/common/cinder.py#n31216:46
TheJuliahttps://developer.openstack.org/api-ref/block-storage/v3/index.html?expanded=create-metadata-for-volume-detail#create-metadata-for-volume16:47
TheJuliaso string of JSON I guess....16:47
*** skazi has quit IRC16:48
TheJuliahshiina: Could you create a patch to fix it for your testing?16:50
TheJuliaIt seems super simple, since we have the utilities to do it16:50
hshiinaTheJulia, i created an patch. https://review.openstack.org/#/c/467930/16:51
hshiinaThis issue is not critical. warning is always logged.16:52
hshiinai reported it to cinder: https://bugs.launchpad.net/cinder/+bug/169036316:53
openstackLaunchpad bug 1690363 in Cinder "Nested metadata to volume causes an internal server error" [Undecided,Fix released] - Assigned to luqitao (qtlu)16:53
hshiinaonly response code was fixed. cinder API doesn't accept nested metadata.16:53
TheJuliaokay16:53
TheJuliaThat makes sense then I guess16:54
TheJuliaThank you!16:54
mjturekcool16:54
TheJuliaWell if there is nothing else, we have six minutes left...16:54
TheJuliaWell, I'm taking the silence as it is time to call the meeting to an end16:55
TheJuliaThank you everyone!16:55
mjturekthanks all!16:55
mjturekttyl16:55
hshiinathank you16:55
TheJulia#endmeeting16:55
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings"16:55
openstackMeeting ended Thu May 25 16:55:46 2017 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:55
openstackMinutes:        http://eavesdrop.openstack.org/meetings/ironic_bfv/2017/ironic_bfv.2017-05-25-16.01.html16:55
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/ironic_bfv/2017/ironic_bfv.2017-05-25-16.01.txt16:55
openstackLog:            http://eavesdrop.openstack.org/meetings/ironic_bfv/2017/ironic_bfv.2017-05-25-16.01.log.html16:55
*** dtantsur has left #openstack-meeting-516:55
*** phuongnh has left #openstack-meeting-516:56
*** felipemonteiro has joined #openstack-meeting-516:58
*** tiendc has quit IRC16:59
*** ralonsoh has quit IRC17:01
*** hshiina has left #openstack-meeting-517:03
*** ricolin has quit IRC17:10
*** korzen has joined #openstack-meeting-517:22
*** korzen has quit IRC18:07
*** korzen has joined #openstack-meeting-518:23
*** felipemonteiro has quit IRC20:10
*** korzen has quit IRC20:13
*** markvoelker has quit IRC20:42
*** markvoelker has joined #openstack-meeting-520:56
*** markvoelker has quit IRC21:00
*** marst_ has quit IRC21:30
*** bzhao_ has joined #openstack-meeting-521:59
*** markvoelker has joined #openstack-meeting-522:05
*** markvoelker has quit IRC22:15
*** markvoelker has joined #openstack-meeting-522:16
*** markvoelker has quit IRC23:11
*** markvoelker has joined #openstack-meeting-523:44
*** markvoelker has quit IRC23:45

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!