*** macz_ has joined #openstack-meeting-3 | 00:15 | |
*** macz_ has quit IRC | 00:20 | |
*** artom has quit IRC | 00:28 | |
*** jamesmcarthur has quit IRC | 00:36 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 00:36 | |
*** jamesmcarthur has quit IRC | 00:41 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 00:49 | |
*** macz_ has joined #openstack-meeting-3 | 01:09 | |
*** macz_ has quit IRC | 01:14 | |
*** jamesmcarthur has quit IRC | 01:19 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 01:20 | |
*** jamesmcarthur has quit IRC | 01:24 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 01:43 | |
*** jamesmcarthur has quit IRC | 02:45 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 02:46 | |
*** jamesmcarthur has quit IRC | 02:51 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 03:14 | |
*** jamesmcarthur has quit IRC | 04:33 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 04:34 | |
*** jamesmcarthur has quit IRC | 04:37 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 04:37 | |
*** jamesmcarthur has quit IRC | 05:12 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 05:12 | |
*** jamesmcarthur has quit IRC | 05:16 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 05:47 | |
*** jamesmcarthur has quit IRC | 05:59 | |
*** slaweq has joined #openstack-meeting-3 | 06:35 | |
*** ralonsoh has joined #openstack-meeting-3 | 06:53 | |
*** e0ne has joined #openstack-meeting-3 | 07:24 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 07:38 | |
*** jamesmcarthur has quit IRC | 07:41 | |
*** tosky has joined #openstack-meeting-3 | 07:42 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 07:49 | |
*** jamesmcarthur has quit IRC | 08:43 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 08:44 | |
*** jamesmcarthur has quit IRC | 08:49 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 09:07 | |
*** jamesmcarthur has quit IRC | 09:12 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 10:20 | |
*** jamesmcarthur has quit IRC | 10:25 | |
*** belmoreira has joined #openstack-meeting-3 | 11:38 | |
*** raildo has joined #openstack-meeting-3 | 12:06 | |
*** artom has joined #openstack-meeting-3 | 12:34 | |
*** macz_ has joined #openstack-meeting-3 | 12:40 | |
*** macz_ has quit IRC | 12:45 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 12:45 | |
*** jamesmcarthur has quit IRC | 13:49 | |
*** jeremyfreudberg_ has joined #openstack-meeting-3 | 13:55 | |
jeremyfreudberg_ | #startmeeting sahara | 14:00 |
---|---|---|
openstack | Meeting started Thu Oct 15 14:00:33 2020 UTC and is due to finish in 60 minutes. The chair is jeremyfreudberg_. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
*** openstack changes topic to " (Meeting topic: sahara)" | 14:00 | |
openstack | The meeting name has been set to 'sahara' | 14:00 |
*** jeremyfreudberg_ is now known as jeremyfreudberg | 14:00 | |
*** jeremyfreudberg is now known as jeremyfreudberg_ | 14:01 | |
jeremyfreudberg_ | #chair jeremyfreudberg | 14:01 |
openstack | Warning: Nick not in channel: jeremyfreudberg | 14:01 |
openstack | Current chairs: jeremyfreudberg jeremyfreudberg_ | 14:01 |
*** jeremyfreudberg_ is now known as jeremyfreudberg | 14:01 | |
jeremyfreudberg | o/ | 14:01 |
jeremyfreudberg | tosky: are you around? | 14:04 |
tosky | hi! | 14:05 |
jeremyfreudberg | #topic open discussion | 14:05 |
*** openstack changes topic to "open discussion (Meeting topic: sahara)" | 14:05 | |
jeremyfreudberg | just want to say for the record that i worked on https://storyboard.openstack.org/#!/story/2008233 but the issue could not be reproduced | 14:06 |
*** jamesmcarthur has joined #openstack-meeting-3 | 14:06 | |
jeremyfreudberg | related to that, we lack any documentation about the necessary environment variables for devstack to clone sahara-plugin-* from stable branch vs master | 14:06 |
jeremyfreudberg | so i will document it when i find some time | 14:07 |
tosky | oh, good point | 14:07 |
jeremyfreudberg | yeah, it took me a minute to realize it | 14:09 |
tosky | I've noticed your comments, and I was kind of sure that was the result (no real bug) | 14:09 |
jeremyfreudberg | and i only realized it because master is python3-only but i was installing train on ubuntu 18 which is python2 | 14:09 |
jeremyfreudberg | anyway, we can wait for the user to come back any hopefully agree with my assessment | 14:10 |
jeremyfreudberg | *and | 14:10 |
jeremyfreudberg | okay, is there anything else we need to discuss | 14:12 |
jeremyfreudberg | anything about releases? | 14:12 |
tosky | it seems the requirements fixes in victoria haven't landed in the stable released version | 14:13 |
tosky | so we may do a follow-up soon-ish | 14:13 |
jeremyfreudberg | right | 14:13 |
jeremyfreudberg | okay, i guess we can close | 14:16 |
jeremyfreudberg | #endmeeting | 14:18 |
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 14:18 | |
tosky | there was also a request for a pike sahara image on the list | 14:18 |
openstack | Meeting ended Thu Oct 15 14:18:50 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:18 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/sahara/2020/sahara.2020-10-15-14.00.html | 14:18 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/sahara/2020/sahara.2020-10-15-14.00.txt | 14:18 |
openstack | Log: http://eavesdrop.openstack.org/meetings/sahara/2020/sahara.2020-10-15-14.00.log.html | 14:18 |
tosky | but I answered :) | 14:18 |
*** jeremyfreudberg has left #openstack-meeting-3 | 14:22 | |
*** macz_ has joined #openstack-meeting-3 | 14:28 | |
*** macz_ has quit IRC | 14:33 | |
*** macz_ has joined #openstack-meeting-3 | 15:01 | |
*** belmoreira has quit IRC | 15:18 | |
*** mlavalle has joined #openstack-meeting-3 | 15:22 | |
*** jamesmcarthur has quit IRC | 15:44 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 15:50 | |
*** jamesmcarthur has quit IRC | 15:50 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 15:50 | |
*** elod has joined #openstack-meeting-3 | 15:56 | |
*** jamesmcarthur has quit IRC | 15:57 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 15:57 | |
gibi | #startmeeting nova | 16:00 |
openstack | Meeting started Thu Oct 15 16:00:09 2020 UTC and is due to finish in 60 minutes. The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
*** openstack changes topic to " (Meeting topic: nova)" | 16:00 | |
openstack | The meeting name has been set to 'nova' | 16:00 |
gibi | o/ | 16:00 |
melwitt | o/ | 16:00 |
dansmith | o/ | 16:00 |
bauzas | \o | 16:00 |
elod | o/ | 16:01 |
gibi | lets get started | 16:01 |
gibi | #topic Bugs (stuck/critical) | 16:01 |
*** openstack changes topic to "Bugs (stuck/critical) (Meeting topic: nova)" | 16:01 | |
gibi | No critical bugs | 16:01 |
gibi | #link 6 new untriaged bugs (0 since the last meeting): https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New | 16:01 |
gibi | is there any specific bug we need to talk about? | 16:02 |
melwitt | I have a bug to bring up | 16:02 |
artom | o/ | 16:02 |
melwitt | https://bugs.launchpad.net/nova/+bug/1799298 is two years old but recently flagged as a security issue downstream, | 16:02 |
openstack | Launchpad bug 1799298 in OpenStack Compute (nova) rocky "Metadata API cross joining instance_metadata and instance_system_metadata" [Medium,Triaged] | 16:02 |
melwitt | just wanted to bring it to attention and ask for help in solving it as it does not look straightforward based on the past bug comments | 16:03 |
dansmith | we don't join those tables for pulling the instance, | 16:03 |
dansmith | and haven't since icehouse-ish | 16:04 |
dansmith | is this a query specifically that metadata uses that is still doing a join? | 16:04 |
melwitt | there is a query and they confirmed it's this one... and they said they also found it present in train | 16:05 |
gibi | reading the bug mriedem said that the instance password is needed from the system_metadata | 16:06 |
dansmith | right, but when we load an instance now, we actually query the instance, then query metadata, then sysmeta, and squash them together | 16:07 |
dansmith | that's what instances_fill_metadata() is | 16:07 |
melwitt | would this not do the join with system_metadata? https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L675 | 16:08 |
dansmith | so I'm wondering if there's a specific db api method that metadata uses to pull the instance, which is somehow letting those columns get into the initial query, but shouldn't? | 16:08 |
dansmith | melwitt: well, those are supposed to be treated differently down the stack, | 16:09 |
dansmith | they are for instance_get(), but my point is maybe this metadata-only query is bypassing that somehow | 16:09 |
melwitt | ack | 16:09 |
dansmith | anyway, we should probably not derail the meeting and can discuss in -nova | 16:10 |
melwitt | yep, thanks, at least there's some thread to pull now | 16:11 |
gibi | OK | 16:11 |
gibi | is there any other bug we need to talk about? | 16:11 |
gibi | #topic Release Planning | 16:12 |
*** openstack changes topic to "Release Planning (Meeting topic: nova)" | 16:12 | |
gibi | Victoria has been released | 16:12 |
gibi | Thank you all for your valuable contributions | 16:12 |
gibi | master is now fully open for Wallaby | 16:12 |
gibi | and we should focus on reviewing incoming specs and preparing for the PTG | 16:12 |
gibi | I will create the wallaby runway etherpad tomorrw | 16:13 |
gibi | anything else about Victoria or Wallaby? | 16:13 |
gibi | #topic Stable Branches | 16:14 |
*** openstack changes topic to "Stable Branches (Meeting topic: nova)" | 16:14 | |
gibi | elod left comments on the wiki ... | 16:14 |
gibi | "Victoria is now a fully normal stable branch, and the normal stable policy now applies." | 16:15 |
gibi | stable/stein will transition to Extended Maintenance in 2020-11-11 | 16:15 |
gibi | should prepare a final release from Stein | 16:15 |
gibi | consider which patches should be part of the final release | 16:15 |
gibi | current list of patches: https://etherpad.opendev.org/p/nova-stable-stein-em | 16:15 |
elod | yepp, that's all, actually, | 16:16 |
elod | I'll focus on Stein in the coming weeks | 16:16 |
gibi | thanks | 16:16 |
elod | let me know if you see any patch that should be definitely be part of the final release | 16:16 |
elod | np | 16:16 |
gibi | #topic Sub/related team Highlights | 16:17 |
*** openstack changes topic to "Sub/related team Highlights (Meeting topic: nova)" | 16:17 | |
gibi | skipping API as gmann cannot join today | 16:17 |
gibi | Libvirt (bauzas) | 16:17 |
gibi | I guess the silence means no news | 16:19 |
gibi | #topic PTG and Forum planning | 16:19 |
*** openstack changes topic to "PTG and Forum planning (Meeting topic: nova)" | 16:19 | |
gibi | Next week is Summit week: #link https://www.openstack.org/summit/2020/summit-schedule | 16:19 |
gibi | Week after next week is PTG # link https://etherpad.opendev.org/p/nova-wallaby-ptg | 16:20 |
gibi | is there anything we need to discuss regarding these events? | 16:21 |
gibi | I will focus my time on Fishbowls during next week | 16:21 |
gibi | #topic Open discussion | 16:22 |
*** openstack changes topic to "Open discussion (Meeting topic: nova)" | 16:22 | |
gibi | we have one topic from stephenfin | 16:22 |
gibi | (stephenfin) Specless BP approval for https://blueprints.launchpad.net/nova/+spec/compact-db-migrations-wallaby | 16:22 |
gibi | tl;dr: I want to go at least as far as Train, and then rework any Ussuri or Victoria migrations to use alembic. Initial cleanup work available at https://review.opendev.org/#/q/topic:bp/compact-db-migrations-wallaby | 16:22 |
gibi | can we approve this specless bp? | 16:23 |
dansmith | I suspect this will be a lot more work than it seems, | 16:24 |
artom | My paranoid nature is immediately skeptical of changing something as crucial as DB schema in stable releases | 16:24 |
gibi | artom: this compacts the old migration on master | 16:24 |
dansmith | as my experience from briefly touching alembic in glance is that the replicability of the schema stuff can get weird in things like unit tests | 16:24 |
dansmith | artom: right, not actually touching older releases, | 16:24 |
artom | Ah, sorry, *facepalm* | 16:25 |
dansmith | just squashing everything into state as of train | 16:25 |
melwitt | yeah, I made a note on the ptg etherpad but basically I know we've talked about this before, and IIRC the conclusion was it wouldn't be a good idea to convert everything to alembic. but I'd have to go see if I can find artifacts from those discussions | 16:25 |
gibi | dansmith: as far as I understand the current bp only propose the compaction not the alembic migration | 16:25 |
dansmith | gibi: yeah, but using alembic going forward right? | 16:25 |
dansmith | my point is just about converting all our db fixture stuff to alembic, multi-cells and all | 16:26 |
gibi | dansmith: this would enable to move to alembic, yes | 16:26 |
gibi | dansmith: but that move would be still a separate bp | 16:26 |
dansmith | I totally recognize the need to compact, but I want to make sure we're super sure that the schema ends the same as it is now, so I hope we'll be very diligent about approving that compaction only after lots of review | 16:26 |
bauzas | gibi: sorry, parenting urgent issue | 16:26 |
dansmith | gibi: ack, okay | 16:26 |
bauzas | gibi: nothing to report | 16:27 |
gibi | bauzas: OK, thanks | 16:27 |
dansmith | gibi: if the specless bp is just for the compaction, then that's fine with me | 16:27 |
gibi | dansmith: I do suggest to talk about the alembic plans during the PTG | 16:27 |
bauzas | I think there are two asks | 16:27 |
bauzas | #1 for packing DB upgrades | 16:28 |
artom | dansmith, we could do something with tests, I think. This stuff is supposed to be 100% deterministic, so... run the old uncompacted migrations, run the news one, starting the the exact same schema, and assert the resulting schema is the same? | 16:28 |
bauzas | #2 for using alembic | 16:28 |
bauzas | fwiw, #1 seems good to me, but for #2, meh | 16:28 |
dansmith | artom: yes | 16:28 |
artom | This wouldn't apply to data migrations, right? | 16:28 |
dansmith | artom: my point is, it's easy to say "the tests pass that used to pass, so they must be identical" and that's not enough, | 16:28 |
bauzas | actually, I have the same opinion than dansmith | 16:28 |
dansmith | artom: we need to make sure they emit the same schema | 16:28 |
dansmith | artom: this has nothing to do with data migrations | 16:29 |
artom | Ack | 16:29 |
artom | So, if we can have a one-time test that asserts the new thing results in the same schema as the old thing, I don't see why not | 16:30 |
dansmith | that's what I'm saying | 16:30 |
artom | That's what *I'm* saying ;) | 16:30 |
dansmith | literally diff the mysqldump from a run generated with the current, and compacted thing, and they should be zero | 16:30 |
bauzas | are we discussing about how to compacting the DB upgrades ? then yes ^ | 16:31 |
dansmith | bauzas: how to *verify* the compaction | 16:31 |
bauzas | how to verify* indeed, my bad | 16:32 |
gibi | I dont see any objection against approving stephenfin's bp with a comment that it only covers the compaction of the migrations and not the alembic move. | 16:32 |
bauzas | ++ | 16:32 |
gibi | do I see it right? | 16:32 |
bauzas | good luck tho | 16:32 |
bauzas | I don't think it will be simple | 16:32 |
bauzas | but meh | 16:32 |
dansmith | gibi: yes, just footnote that we should be super review-y on the compaction please | 16:33 |
gibi | dansmith: ack I will add that comment too | 16:33 |
gibi | nothing else on the agenda for toda | 16:34 |
gibi | y | 16:34 |
gibi | anything else in the room to discuss? | 16:34 |
* artom throws a small flat round object | 16:34 | |
gibi | what do you have there artom ? :) | 16:35 |
artom | A pun is what I have | 16:35 |
gibi | :D | 16:35 |
gibi | then thanks for joining today | 16:36 |
gibi | o/ | 16:36 |
gibi | #endmeeting | 16:36 |
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 16:36 | |
openstack | Meeting ended Thu Oct 15 16:36:37 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:36 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/nova/2020/nova.2020-10-15-16.00.html | 16:36 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/nova/2020/nova.2020-10-15-16.00.txt | 16:36 |
openstack | Log: http://eavesdrop.openstack.org/meetings/nova/2020/nova.2020-10-15-16.00.log.html | 16:36 |
elod | thanks o/ | 16:37 |
*** lpetrut has joined #openstack-meeting-3 | 16:44 | |
*** lpetrut has quit IRC | 16:59 | |
*** jamesmcarthur has quit IRC | 17:01 | |
*** elod has left #openstack-meeting-3 | 17:06 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 17:07 | |
*** Vadmacs has joined #openstack-meeting-3 | 18:16 | |
*** artom has quit IRC | 18:22 | |
*** artom has joined #openstack-meeting-3 | 18:22 | |
*** ralonsoh has quit IRC | 18:22 | |
*** jamesmcarthur has quit IRC | 18:31 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 18:39 | |
*** Vadmacs has quit IRC | 20:36 | |
*** jamesmcarthur has quit IRC | 21:05 | |
*** raildo has quit IRC | 21:13 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 21:15 | |
*** jamesmcarthur has quit IRC | 21:22 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 21:24 | |
*** jamesmcarthur has quit IRC | 21:25 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 21:25 | |
*** slaweq has quit IRC | 21:31 | |
*** jamesmcarthur has quit IRC | 21:48 | |
*** slaweq has joined #openstack-meeting-3 | 22:22 | |
*** slaweq has quit IRC | 22:38 | |
*** macz_ has quit IRC | 23:03 | |
*** mlavalle has quit IRC | 23:23 | |
*** tosky has quit IRC | 23:23 | |
*** jamesmcarthur has joined #openstack-meeting-3 | 23:46 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!