*** kragniz_ is now known as kragniz | 00:00 | |
*** markvoelker has joined #openstack-meeting-3 | 00:02 | |
*** markvoelker has quit IRC | 00:08 | |
*** markvoelker has joined #openstack-meeting-3 | 00:52 | |
*** etoews has joined #openstack-meeting-3 | 00:53 | |
*** etoews has quit IRC | 00:57 | |
*** markvoelker has quit IRC | 00:57 | |
*** bknudson has quit IRC | 01:07 | |
*** maurosr has quit IRC | 01:27 | |
*** zz_jgrimm has quit IRC | 01:27 | |
*** yamamoto_ has joined #openstack-meeting-3 | 01:28 | |
*** zz_jgrimm has joined #openstack-meeting-3 | 01:31 | |
*** maurosr has joined #openstack-meeting-3 | 01:32 | |
*** markvoelker has joined #openstack-meeting-3 | 01:54 | |
*** etoews has joined #openstack-meeting-3 | 01:54 | |
*** etoews has quit IRC | 01:58 | |
*** markvoelker has quit IRC | 01:58 | |
*** lazy_prince has quit IRC | 02:00 | |
*** etoews has joined #openstack-meeting-3 | 02:05 | |
*** etoews has quit IRC | 02:10 | |
*** ivar-laz_ has joined #openstack-meeting-3 | 02:21 | |
*** etoews has joined #openstack-meeting-3 | 02:24 | |
*** ivar-lazzaro has quit IRC | 02:24 | |
*** ivar-laz_ has quit IRC | 02:25 | |
*** etoews has quit IRC | 02:28 | |
*** amotoki has quit IRC | 02:38 | |
*** markvoelker has joined #openstack-meeting-3 | 02:55 | |
*** etoews has joined #openstack-meeting-3 | 02:56 | |
*** markvoelker has quit IRC | 03:01 | |
*** etoews has quit IRC | 03:02 | |
*** jaypipes has joined #openstack-meeting-3 | 03:10 | |
*** lazy_prince has joined #openstack-meeting-3 | 03:15 | |
*** amotoki has joined #openstack-meeting-3 | 03:37 | |
*** amotoki has quit IRC | 03:43 | |
*** amotoki has joined #openstack-meeting-3 | 03:49 | |
*** markvoelker has joined #openstack-meeting-3 | 03:57 | |
*** etoews has joined #openstack-meeting-3 | 03:59 | |
*** banix has quit IRC | 03:59 | |
*** markvoelker has quit IRC | 04:02 | |
*** etoews has quit IRC | 04:03 | |
*** qwebirc76596 has joined #openstack-meeting-3 | 04:33 | |
*** qwebirc76596 has quit IRC | 04:34 | |
*** markvoelker has joined #openstack-meeting-3 | 04:58 | |
*** markvoelker has quit IRC | 05:03 | |
*** markvoelker has joined #openstack-meeting-3 | 05:59 | |
*** markvoelker has quit IRC | 06:04 | |
*** thomasem has quit IRC | 06:20 | |
*** thomasem has joined #openstack-meeting-3 | 06:21 | |
*** thomasem has quit IRC | 06:22 | |
*** thomasem has joined #openstack-meeting-3 | 06:24 | |
*** marios_ has joined #openstack-meeting-3 | 06:27 | |
*** marios_ has quit IRC | 06:27 | |
*** stanzgy has joined #openstack-meeting-3 | 06:36 | |
*** lazy_prince has quit IRC | 06:49 | |
*** killer_prince has joined #openstack-meeting-3 | 06:50 | |
*** killer_prince is now known as lazy_prince | 06:50 | |
*** mageshgv has joined #openstack-meeting-3 | 07:00 | |
*** markvoelker has joined #openstack-meeting-3 | 07:01 | |
*** markvoelker has quit IRC | 07:06 | |
*** mrunge has joined #openstack-meeting-3 | 07:09 | |
*** sergef has joined #openstack-meeting-3 | 07:23 | |
*** sahid has joined #openstack-meeting-3 | 07:24 | |
*** mrunge has quit IRC | 07:56 | |
*** yamamoto_ has quit IRC | 07:57 | |
*** yamamoto_ has joined #openstack-meeting-3 | 07:58 | |
*** yamamoto_ has quit IRC | 08:00 | |
*** mrunge has joined #openstack-meeting-3 | 08:00 | |
*** markvoelker has joined #openstack-meeting-3 | 08:02 | |
*** markvoelker has quit IRC | 08:07 | |
*** kashyap has joined #openstack-meeting-3 | 08:07 | |
*** scheuran has joined #openstack-meeting-3 | 08:08 | |
*** jcoufal has joined #openstack-meeting-3 | 08:10 | |
*** gillllliard is now known as gilliard | 08:18 | |
*** wojdev has joined #openstack-meeting-3 | 08:36 | |
*** mageshgv has quit IRC | 08:39 | |
*** MaxV has joined #openstack-meeting-3 | 08:45 | |
*** amotoki_ has joined #openstack-meeting-3 | 08:56 | |
*** Longgeek has joined #openstack-meeting-3 | 09:00 | |
*** amotoki_ has quit IRC | 09:02 | |
*** matrohon has joined #openstack-meeting-3 | 09:02 | |
*** markvoelker has joined #openstack-meeting-3 | 09:03 | |
*** egallen has joined #openstack-meeting-3 | 09:05 | |
*** markvoelker has quit IRC | 09:08 | |
*** lazy_prince is now known as killer_prince | 09:12 | |
*** lsmola has joined #openstack-meeting-3 | 09:20 | |
*** salv-orlando has quit IRC | 09:22 | |
*** evgenyf has joined #openstack-meeting-3 | 09:24 | |
*** mrunge is now known as mrunge_brb | 09:26 | |
*** amotoki_ has joined #openstack-meeting-3 | 09:45 | |
*** yamamoto has joined #openstack-meeting-3 | 09:48 | |
*** mrunge_brb is now known as mrunge | 09:51 | |
*** etoews has joined #openstack-meeting-3 | 10:00 | |
*** belmoreira has joined #openstack-meeting-3 | 10:02 | |
*** markvoelker has joined #openstack-meeting-3 | 10:04 | |
*** etoews has quit IRC | 10:04 | |
*** mrmartin has joined #openstack-meeting-3 | 10:06 | |
*** markvoelker has quit IRC | 10:09 | |
*** pasha117 has joined #openstack-meeting-3 | 10:15 | |
*** evgenyf has quit IRC | 10:18 | |
*** pavel_bondar has quit IRC | 10:18 | |
*** killer_prince is now known as lazy_prince | 10:30 | |
*** yamamoto has quit IRC | 10:43 | |
*** yamamoto has joined #openstack-meeting-3 | 10:46 | |
*** amotoki_ has quit IRC | 10:52 | |
*** wojdev has quit IRC | 10:55 | |
*** amotoki_ has joined #openstack-meeting-3 | 10:58 | |
*** etoews has joined #openstack-meeting-3 | 11:00 | |
*** evgenyf has joined #openstack-meeting-3 | 11:02 | |
*** wojdev has joined #openstack-meeting-3 | 11:03 | |
*** amotoki_ has quit IRC | 11:03 | |
*** etoews has quit IRC | 11:05 | |
*** markvoelker has joined #openstack-meeting-3 | 11:05 | |
*** marios has quit IRC | 11:06 | |
*** markvoelker has quit IRC | 11:11 | |
*** salv-orlando has joined #openstack-meeting-3 | 11:12 | |
*** amotoki_ has joined #openstack-meeting-3 | 11:13 | |
*** salv-orlando has quit IRC | 11:14 | |
*** salv-orlando has joined #openstack-meeting-3 | 11:14 | |
*** marios has joined #openstack-meeting-3 | 11:16 | |
*** belmoreira has quit IRC | 11:23 | |
*** yamamoto has quit IRC | 11:29 | |
*** amotoki_ has quit IRC | 11:33 | |
*** wojdev has quit IRC | 11:34 | |
*** evgenyf has quit IRC | 11:36 | |
*** amotoki_ has joined #openstack-meeting-3 | 11:38 | |
*** amotoki_ has quit IRC | 11:40 | |
*** wojdev has joined #openstack-meeting-3 | 11:53 | |
*** etoews has joined #openstack-meeting-3 | 12:01 | |
*** amotoki_ has joined #openstack-meeting-3 | 12:04 | |
*** yamamoto has joined #openstack-meeting-3 | 12:05 | |
*** etoews has quit IRC | 12:05 | |
*** markvoelker has joined #openstack-meeting-3 | 12:08 | |
*** sahid has quit IRC | 12:10 | |
*** sahid has joined #openstack-meeting-3 | 12:11 | |
*** markvoelker has quit IRC | 12:12 | |
*** amotoki_ has quit IRC | 12:21 | |
*** amotoki_ has joined #openstack-meeting-3 | 12:23 | |
*** pavel_bondar has joined #openstack-meeting-3 | 12:25 | |
*** yamamoto has quit IRC | 12:28 | |
*** pasha117 has quit IRC | 12:28 | |
*** amotoki_ has quit IRC | 12:31 | |
*** amotoki_ has joined #openstack-meeting-3 | 12:31 | |
*** kbyrne has joined #openstack-meeting-3 | 12:37 | |
*** devvesa has joined #openstack-meeting-3 | 12:39 | |
*** amotoki_ has quit IRC | 12:39 | |
*** evgenyf has joined #openstack-meeting-3 | 12:49 | |
*** etoews has joined #openstack-meeting-3 | 12:50 | |
*** lazy_prince is now known as killer_prince | 13:03 | |
*** markvoelker has joined #openstack-meeting-3 | 13:09 | |
*** jcoufal_ has joined #openstack-meeting-3 | 13:10 | |
*** jcoufal has quit IRC | 13:13 | |
*** markvoelker has quit IRC | 13:14 | |
*** VW_ has joined #openstack-meeting-3 | 13:18 | |
*** coolsvap- is now known as coolsvap | 13:27 | |
*** zz_johnthetubagu is now known as johnthetubaguy | 13:27 | |
*** Longgeek has quit IRC | 13:32 | |
*** VW_ has quit IRC | 13:35 | |
*** VW_ has joined #openstack-meeting-3 | 13:35 | |
*** mrmartin has quit IRC | 13:35 | |
*** banix has joined #openstack-meeting-3 | 13:35 | |
*** wojdev has quit IRC | 13:42 | |
*** yamamoto has joined #openstack-meeting-3 | 13:43 | |
*** figleaf is now known as edleafe | 13:46 | |
*** mrmartin has joined #openstack-meeting-3 | 13:56 | |
*** banix has quit IRC | 13:58 | |
*** VW_ has quit IRC | 13:59 | |
*** VW_ has joined #openstack-meeting-3 | 14:04 | |
*** Guest59076 is now known as dansmith | 14:05 | |
*** dansmith is now known as Guest28456 | 14:06 | |
*** banix has joined #openstack-meeting-3 | 14:08 | |
*** salv-orlando has quit IRC | 14:08 | |
*** Guest28456 is now known as dansmith_ | 14:09 | |
*** salv-orlando has joined #openstack-meeting-3 | 14:09 | |
*** markvoelker has joined #openstack-meeting-3 | 14:10 | |
*** sandr8 has quit IRC | 14:11 | |
*** salv-orlando has quit IRC | 14:12 | |
*** salv-orlando has joined #openstack-meeting-3 | 14:13 | |
*** markvoelker has quit IRC | 14:15 | |
*** salv-orlando has quit IRC | 14:15 | |
*** Networkn3rd has joined #openstack-meeting-3 | 14:16 | |
*** wojdev has joined #openstack-meeting-3 | 14:17 | |
*** VW_ has quit IRC | 14:21 | |
*** VW_ has joined #openstack-meeting-3 | 14:22 | |
*** banix has quit IRC | 14:23 | |
*** wojdev has quit IRC | 14:27 | |
*** markvoelker has joined #openstack-meeting-3 | 14:28 | |
*** peristeri has joined #openstack-meeting-3 | 14:28 | |
*** banix has joined #openstack-meeting-3 | 14:32 | |
*** amotoki_ has joined #openstack-meeting-3 | 14:32 | |
*** banix has quit IRC | 14:32 | |
*** JeanBriceCombebi has joined #openstack-meeting-3 | 14:33 | |
*** Longgeek has joined #openstack-meeting-3 | 14:33 | |
*** markvoelker has quit IRC | 14:34 | |
*** JeanBriceCombebi has quit IRC | 14:37 | |
*** Longgeek has quit IRC | 14:40 | |
*** Longgeek has joined #openstack-meeting-3 | 14:40 | |
*** wojdev has joined #openstack-meeting-3 | 14:42 | |
*** amotoki_ has quit IRC | 14:48 | |
*** wojdev has quit IRC | 14:51 | |
*** wojdev has joined #openstack-meeting-3 | 14:52 | |
*** watanabe_isao has quit IRC | 14:55 | |
*** killer_prince is now known as lazy_prince | 14:56 | |
*** amotoki_ has joined #openstack-meeting-3 | 14:57 | |
*** amotoki_ has quit IRC | 14:59 | |
*** amotoki_ has joined #openstack-meeting-3 | 15:00 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 15:01 | |
*** amotoki_ has quit IRC | 15:03 | |
*** zz_jgrimm is now known as jgrimm | 15:04 | |
*** dansmith_ is now known as dansmith | 15:05 | |
*** gulic has joined #openstack-meeting-3 | 15:07 | |
*** thangp has joined #openstack-meeting-3 | 15:16 | |
*** marg7175 has joined #openstack-meeting-3 | 15:22 | |
*** marg7175 has quit IRC | 15:23 | |
*** marg7175 has joined #openstack-meeting-3 | 15:23 | |
*** thangp has quit IRC | 15:29 | |
*** nelsnelson has joined #openstack-meeting-3 | 15:30 | |
*** markvoelker has joined #openstack-meeting-3 | 15:31 | |
*** wojdev has quit IRC | 15:34 | |
*** markvoelker has quit IRC | 15:35 | |
*** JeanBriceCombebi has joined #openstack-meeting-3 | 15:44 | |
*** wojdev has joined #openstack-meeting-3 | 15:44 | |
*** yolanda has joined #openstack-meeting-3 | 15:53 | |
*** markvoelker has joined #openstack-meeting-3 | 15:53 | |
*** rcarrillocruz has joined #openstack-meeting-3 | 15:54 | |
*** wojdev has quit IRC | 15:54 | |
*** sarob has joined #openstack-meeting-3 | 15:56 | |
*** wojdev has joined #openstack-meeting-3 | 15:57 | |
*** banix has joined #openstack-meeting-3 | 15:57 | |
*** markvoelker has quit IRC | 15:58 | |
*** VW_ has quit IRC | 15:58 | |
*** CTtpollard has joined #openstack-meeting-3 | 16:00 | |
krotscheck | #startmeeting StoryBoard | 16:00 |
---|---|---|
openstack | Meeting started Mon Feb 16 16:00:33 2015 UTC and is due to finish in 60 minutes. The chair is krotscheck. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
*** openstack changes topic to " (Meeting topic: StoryBoard)" | 16:00 | |
openstack | The meeting name has been set to 'storyboard' | 16:00 |
krotscheck | Good morning everyone! | 16:00 |
yolanda | hi | 16:00 |
*** sarob has quit IRC | 16:00 | |
NikitaKonovalov | o/ | 16:00 |
krotscheck | Agenda: https://wiki.openstack.org/wiki/StoryBoard#Agenda | 16:00 |
krotscheck | Everyone say hi to gulic! | 16:01 |
*** david-lyle_afk is now known as david-lyle | 16:01 | |
yolanda | welcome gulic! :) | 16:01 |
gulic | hi :) | 16:01 |
NikitaKonovalov | hi | 16:01 |
nibalizer | gulic: welcome! | 16:01 |
krotscheck | We’ll let you do formal introduction thigns in the main channel, that way people not at the meeting can get to know more about you :) | 16:02 |
*** thangp has joined #openstack-meeting-3 | 16:02 | |
krotscheck | #topic Actions from Last Week | 16:02 |
*** openstack changes topic to "Actions from Last Week (Meeting topic: StoryBoard)" | 16:02 | |
krotscheck | rcarrillocruz: I saw your notification coverage change merge. | 16:02 |
krotscheck | So that’s done | 16:03 |
*** cawil1 has joined #openstack-meeting-3 | 16:03 | |
krotscheck | #topic Actions from last week: krotscheck) | 16:03 |
*** openstack changes topic to "Actions from last week: krotscheck) (Meeting topic: StoryBoard)" | 16:03 | |
krotscheck | Working on auth token verification made me incredibly angry at how our database wasn’t managing timestamps properly. | 16:03 |
krotscheck | So I fixed that. | 16:04 |
yolanda | did that change land? | 16:04 |
krotscheck | And then I fixed the timestamp auth check. | 16:04 |
krotscheck | I don’t think so, checking | 16:04 |
krotscheck | https://review.openstack.org/#/c/155083/ | 16:04 |
krotscheck | Turned out that while it was “understood” that all datetimes were in UTC, the datetime() object never had a timezone attached to it, which created lots of boilerplate around trying to align and guess timezones. | 16:05 |
krotscheck | So that got fixed. | 16:05 |
yolanda | ok, i need to review it | 16:05 |
NikitaKonovalov | great | 16:05 |
NikitaKonovalov | I'll also review | 16:05 |
krotscheck | Story about pagination controls: https://storyboard.openstack.org/#!/story/11 | 16:05 |
krotscheck | Story on autocomplete: https://storyboard.openstack.org/#!/story/2000163 | 16:06 |
krotscheck | Fix cron: Didn’t get around to it. | 16:06 |
krotscheck | #topic Actions from last week ( NikitaKonovalov ) | 16:06 |
*** openstack changes topic to "Actions from last week ( NikitaKonovalov ) (Meeting topic: StoryBoard)" | 16:06 | |
NikitaKonovalov | ok, I've been working on sessions | 16:06 |
krotscheck | I saw! That’s neat! | 16:07 |
NikitaKonovalov | and finally there is a patch with a session per request approach | 16:07 |
krotscheck | NikitaKonovalov: I don’t suppose you had the chance to do a before/after benchmark? | 16:07 |
NikitaKonovalov | there is also a comment about using a specific pecan hook | 16:07 |
NikitaKonovalov | looks like it will be handy | 16:07 |
krotscheck | TransactionHook, yes. | 16:07 |
NikitaKonovalov | as for testing, not yet | 16:07 |
NikitaKonovalov | but willdo | 16:08 |
krotscheck | You don’t ened to, I’m just curious. | 16:08 |
krotscheck | The fact that we can use the ORM linking inside storyboard now is enough for me :) | 16:08 |
NikitaKonovalov | I'm also curious, that's why still will do | 16:08 |
krotscheck | NikitaKonovalov: You got it. | 16:08 |
krotscheck | NikitaKonovalov: I’m guessing you didn’t have time to work on the accesstoken index? | 16:08 |
NikitaKonovalov | yep, no indexes still | 16:09 |
krotscheck | No worries. Anyone want to take that off NikitaKonovalov’s plate? | 16:09 |
NikitaKonovalov | but I'll switch to them after the session is done | 16:09 |
NikitaKonovalov | or someone can take that | 16:09 |
krotscheck | Well, it’s a super easy thing for someone who wants to get ATC status before the convention passes go out. | 16:10 |
yolanda | what needs to be done there? | 16:10 |
NikitaKonovalov | btw we can mark it as a "low hanging fruit" | 16:10 |
*** rcarrillocruz has quit IRC | 16:10 | |
krotscheck | yolanda: We need the mysql accesstoken table to index on the actual token column | 16:10 |
NikitaKonovalov | yolanda: there should be a migration to add index | 16:10 |
NikitaKonovalov | 1 file change | 16:10 |
yolanda | ok, i have my ATC badge but i can take it :) | 16:10 |
yolanda | do you have a story about it? | 16:10 |
NikitaKonovalov | let's see | 16:11 |
*** jgrimm is now known as zz_jgrimm | 16:11 | |
yolanda | np, or i just create one | 16:11 |
NikitaKonovalov | https://storyboard.openstack.org/#!/story/2000165 | 16:12 |
krotscheck | Cool, let’s move on. | 16:12 |
NikitaKonovalov | there it is | 16:12 |
yolanda | thx | 16:12 |
krotscheck | #topic Urgent Items: Foreign Keys! | 16:12 |
*** openstack changes topic to "Urgent Items: Foreign Keys! (Meeting topic: StoryBoard)" | 16:12 | |
krotscheck | NikitaKonovalov: the floor is yours. | 16:12 |
NikitaKonovalov | we've got a problem | 16:12 |
*** zz_jgrimm is now known as jgrimm | 16:12 | |
NikitaKonovalov | it is possible to create a comment for a story that does not exist | 16:13 |
NikitaKonovalov | which means that sqlalchemy declaration for a foreign key is not enough to enforce it | 16:13 |
NikitaKonovalov | without having a real foreign key in the db | 16:13 |
*** ricky1 has joined #openstack-meeting-3 | 16:13 | |
ricky1 | o/ | 16:14 |
NikitaKonovalov | and some time ago we droppped most of those | 16:14 |
krotscheck | That seems like a bug in SQLAlchemy | 16:14 |
NikitaKonovalov | krotscheck: probably | 16:14 |
jeblair | how would you create reference to it if you can't instantiate a story? | 16:14 |
NikitaKonovalov | I can try to roll back to 0.8 sqla and see how it works there | 16:15 |
NikitaKonovalov | jeblair: when creating a comment you do not need to instanciate a Story | 16:15 |
NikitaKonovalov | you just set story_id="whatever" and it works | 16:15 |
yolanda | so just manipulating the javascript should be enough? | 16:16 |
NikitaKonovalov | yep | 16:16 |
jeblair | that sounds like an input validation problem... normally i would expect an app to not only verify that the story existed, but also that the user had access to it, etc.... | 16:16 |
krotscheck | Ditto on that. | 16:16 |
NikitaKonovalov | we have options here, we may have our own validation for all foreign keys | 16:17 |
krotscheck | Honestly I don’t know enough about how SQLA handles FK columns itself internally to handle things like that, so without investigation I can’t really come up with an opinion on this. | 16:17 |
NikitaKonovalov | and it can be effective with new session management | 16:17 |
krotscheck | I recognize that it’s an important issue that needs to be addressed though | 16:17 |
NikitaKonovalov | or get the constraints back on db backend level | 16:18 |
jeblair | a pattern i usually use is for this sort of thing is: story.addComment(...); that makes it really hard to add a comment without a story | 16:18 |
NikitaKonovalov | jeblair: what we now have looks more like session.add(Comment(story_id=xyz, text="a new comment")) | 16:19 |
*** sreshetnyak has joined #openstack-meeting-3 | 16:20 | |
NikitaKonovalov | anyway I'll check older sqla versions first | 16:21 |
NikitaKonovalov | but most probably we need a good validation layer for that | 16:21 |
*** sreshetnyak has quit IRC | 16:21 | |
krotscheck | I feel like SQLA should be providing that, and if it’s not we should ping their channel for some guidance. | 16:22 |
*** sreshetnyak has joined #openstack-meeting-3 | 16:22 | |
NikitaKonovalov | krotscheck: agree, otherwise what's use of declaring constraints | 16:22 |
krotscheck | But I’ll leave it to NikitaKonovalov to figure it out. | 16:22 |
krotscheck | NikitaKonovalov: Exactly | 16:22 |
NikitaKonovalov | fine | 16:22 |
jeblair | related to the pattern i use... | 16:23 |
jeblair | i never set the id field directly either | 16:23 |
jeblair | i always associate two objects with each other using one of their relationships | 16:23 |
jeblair | which requires you always have the existing object loaded | 16:23 |
*** sarob has joined #openstack-meeting-3 | 16:24 | |
jeblair | so never: comment.story_id = story.id; but rather: comment.story = story; or: story.comments.append(comment) | 16:24 |
*** sarob_ has joined #openstack-meeting-3 | 16:24 | |
jeblair | (the story.addComment() method would do: comment=Comment(...); session.add(comment); self.comments.append(comment)) | 16:25 |
NikitaKonovalov | jeblair: I like that approach | 16:25 |
NikitaKonovalov | looks like it's time for a huge db_api refactoring | 16:25 |
* ricky1 hopes to find some time to read up a SQLA book on Safari | 16:26 | |
jeblair | #link http://git.openstack.org/cgit/stackforge/gertty/tree/gertty/db.py | 16:26 |
krotscheck | I feel like NikitaKonovalov’s the best qualified for that, since he’s doing something very similar in the python API library | 16:26 |
jeblair | that ^ shows the approach and mostly isn't terrible. maybe just a little. :) | 16:26 |
*** zigo has quit IRC | 16:26 | |
NikitaKonovalov | or I can ask aripinen to do that when he finishes refresh tokens and other stuff | 16:27 |
krotscheck | jeblair: We can improve on it :) | 16:27 |
*** lazy_prince is now known as killer_prince | 16:28 | |
krotscheck | NikitaKonovalov: Ok, so it can be either yours or his task, but if we’re going to dramatically change how the DB api works, do you think we’ll need a spec to set some general guidelines on how we do references? | 16:28 |
*** sarob has quit IRC | 16:28 | |
NikitaKonovalov | krotscheck: yes I can make a spec for that | 16:28 |
ricky1 | given the wide scope, i agree a spec would be good | 16:29 |
krotscheck | Well, do we need one? | 16:29 |
krotscheck | Ooookay, n/m. Spec it is. | 16:29 |
krotscheck | #action NikitaKonovalov Write a spec for DB APi refactor. | 16:30 |
NikitaKonovalov | fine | 16:30 |
krotscheck | Cool, moving on. | 16:30 |
krotscheck | No user feedback in the agenda, so we’ll skip that. | 16:31 |
*** zigo has joined #openstack-meeting-3 | 16:31 | |
krotscheck | #topic Discussion: Google Summer of Code. | 16:31 |
*** openstack changes topic to "Discussion: Google Summer of Code. (Meeting topic: StoryBoard)" | 16:31 | |
krotscheck | So, the OpenStack call for GSoC proposals just went out. | 16:31 |
* NikitaKonovalov needs to read through that | 16:31 | |
yolanda | yep, met oo | 16:31 |
krotscheck | And I figure StoryBoard could be a good candidate, if we can find a nice, independent feature chunk that we could put forward as a proposal. | 16:32 |
yolanda | oh , that sounds good | 16:32 |
krotscheck | Does anyone have any ideas? | 16:32 |
ricky1 | yolanda: you already spoke about HP Women Scholarship program | 16:33 |
ricky1 | not GSOC, but related in terms of getting someone to do SB stuff... | 16:33 |
yolanda | yes, gulic is going to take the file attachments feature | 16:33 |
krotscheck | ricky1: Yep, meet gulic :D | 16:33 |
yolanda | i talked with ttx and guli about that | 16:33 |
krotscheck | oooOOOoooo | 16:33 |
ricky1 | excellent! | 16:33 |
yolanda | guli=gulic.. i hate my keyboard | 16:33 |
* krotscheck likes file attachments. | 16:34 | |
NikitaKonovalov | file attachmets are also worth having a spec I think | 16:34 |
krotscheck | Yep. | 16:34 |
yolanda | yes, i was talking with ttx about that, we can work with gulic and she can define it | 16:34 |
yolanda | so ttx is not present today, he told he was flying | 16:35 |
krotscheck | That suggests a GSOC topic. We could build up some of the toolking which the UX team asked for into storyboard as a GSoC project. | 16:35 |
yolanda | but we can talk more about it this week | 16:35 |
* krotscheck tries to steer the conversation back to the meeting topic. | 16:35 | |
NikitaKonovalov | krotscheck: sounds good | 16:36 |
jeblair | krotscheck: that sounds like a great idea | 16:36 |
*** wojdev has quit IRC | 16:36 | |
krotscheck | I agree. Does anyone else have feature groupings? I’d like to put this forward to the lists in general to see if anyone else has ideas. | 16:37 |
* NikitaKonovalov needs to think more on that | 16:37 | |
krotscheck | Alright, we’ll keep it on the agenda for next week. Everyone ponder it. | 16:38 |
yolanda | yes, i need to think about it as well | 16:38 |
*** wojdev has joined #openstack-meeting-3 | 16:39 | |
krotscheck | #topic InProgress(krotscheck) | 16:39 |
*** openstack changes topic to "InProgress(krotscheck) (Meeting topic: StoryBoard)" | 16:39 | |
krotscheck | What I didn’t spend on datetime last week I spent on two things. | 16:39 |
krotscheck | The first was to fix all the problems in the webclient that made yolanda jump through ridiculous hoops to make user preferences work. | 16:40 |
yolanda | ep, my hoops weren't ridiculous :) | 16:40 |
krotscheck | That more or less starts here: https://review.openstack.org/#/c/155943/ | 16:40 |
yolanda | or they were ... | 16:40 |
krotscheck | yolanda: Yes, but they could be SO MUCH EASIER. | 16:40 |
yolanda | i like what you've done there | 16:41 |
krotscheck | The whole recursive link between user -> session -> resourcefactory -> user was ridiculous and unecessary. | 16:41 |
krotscheck | The other thing I worked on was email, which jeblair had raised some concerns with but I’m not really ready to discuss yet. | 16:42 |
krotscheck | But I should be ready by next week, so I’ll put that on the agenda. | 16:42 |
krotscheck | rcarrilocruz is not here, we’ll skip him. | 16:43 |
ricky1 | yeah | 16:43 |
ricky1 | ! | 16:43 |
krotscheck | Oh! | 16:43 |
ricky1 | bouncer is giving me grief, rcarrillocruz is in zombie... | 16:43 |
ricky1 | so | 16:43 |
krotscheck | Gotcha | 16:43 |
ricky1 | streaming! | 16:43 |
krotscheck | #topic InProgress(ricky1) | 16:43 |
*** openstack changes topic to "InProgress(ricky1) (Meeting topic: StoryBoard)" | 16:43 | |
ricky1 | i figured the reconnect thing | 16:43 |
ricky1 | https://review.openstack.org/#/c/143304/13/storyboard/streaming/consumer.py | 16:43 |
ricky1 | now, we create a queue when the websocket is opened and we set the attribute x-expires to 300000 | 16:44 |
ricky1 | that means if there's no consumer consuming it, it will be dead | 16:44 |
ricky1 | and put a 'reconnect' command to the SB WS protocol | 16:44 |
ricky1 | let's say our client connects to Tornado | 16:45 |
ricky1 | and subscribes to things like tasks or stories | 16:45 |
ricky1 | then suddenly connection drops | 16:45 |
ricky1 | the queue still is around keeping storing events | 16:45 |
*** wojdev has quit IRC | 16:45 | |
ricky1 | then the client can do in the next 5 minutes a 'reconnect <string>' and that gets bound to the previous queue, making all the undelivered messages to be sent on the WS ... | 16:45 |
*** sarob_ has quit IRC | 16:46 | |
ricky1 | the string thing i'm not sure what convention to follow, right now i'm thinking that we sent to the client the name of the rabbitmq queue name on connect | 16:46 |
*** absubram has joined #openstack-meeting-3 | 16:46 | |
ricky1 | so they can use later as the reconnect argument | 16:46 |
ricky1 | following that i will tackle the 'replay' command: to get events from an arbitrary date range, that will not go thru RabbitMQ, it will just be a DB lookup | 16:47 |
krotscheck | ricky1: When a client first makes a connection, can we 303 them to a different url that only goes to their queue? | 16:47 |
*** SridharRamaswamy has joined #openstack-meeting-3 | 16:47 | |
*** wojdev has joined #openstack-meeting-3 | 16:47 | |
krotscheck | i.e. Connect /v1/socket -> yay but it’s over here -> 303 /v1/socket/124lfdkskajlsfalkf | 16:47 |
ricky1 | websockets only use HTTP on handshake | 16:47 |
ricky1 | after that , you can't really use 303 or other HTTP verbs | 16:47 |
krotscheck | So we can’t redirect during the handshake? Suck. | 16:48 |
ricky1 | niet | 16:48 |
*** evgenyf has quit IRC | 16:48 | |
krotscheck | Ok, so do you have a solution, or do you want us to brainstorm something? | 16:49 |
ricky1 | the idea i had to prevent users to reconnect to queues that were not opened by themselves is to keep a dict/shelve of queue-names-connect strings | 16:50 |
ricky1 | i.e. you connect to SB Tornado, authenticate ok with your bearer token | 16:50 |
ricky1 | we send the client a string like 'queue-234234:connectstring' | 16:50 |
ricky1 | and that pair can be used later on by the client to reconnect | 16:50 |
ricky1 | what you think? | 16:50 |
krotscheck | That seems reasonably sane. Are there similar examples out there? | 16:51 |
*** SridharRamaswamy has quit IRC | 16:51 | |
*** SridharRamaswamy has joined #openstack-meeting-3 | 16:51 | |
ricky1 | not that i've found tbh, most rabbitmq->tornado examples use cookies to persist data | 16:51 |
ricky1 | that's also something we could pursue | 16:51 |
ricky1 | to put that 'session' on a cookie and client can send on reconnect? | 16:52 |
*** etoews has quit IRC | 16:52 | |
krotscheck | Also an option. | 16:53 |
*** etoews has joined #openstack-meeting-3 | 16:53 | |
ricky1 | otoh, doing cookies kind of leaves clients to always be browsers | 16:53 |
ricky1 | i'd like to have this feature to be browsers, CLI clients, etc | 16:53 |
krotscheck | Yeah, I think that disqualifies it. | 16:53 |
*** markvoelker has joined #openstack-meeting-3 | 16:54 | |
krotscheck | We need to move on to others, how about yo umove this to discussion for next week and present a list of options? | 16:54 |
*** mrmartin has quit IRC | 16:54 | |
ricky1 | sure | 16:54 |
ricky1 | makes sense | 16:54 |
krotscheck | #topic InProgress(yolanda) | 16:55 |
*** openstack changes topic to "InProgress(yolanda) (Meeting topic: StoryBoard)" | 16:55 | |
krotscheck | Yi! | 16:55 |
ricky1 | thx | 16:55 |
krotscheck | Hi! | 16:55 |
*** JeanBriceCombebi has quit IRC | 16:55 | |
yolanda | so... | 16:55 |
krotscheck | You have 5 minutes :) | 16:55 |
yolanda | integration tests | 16:55 |
yolanda | i started working on that | 16:55 |
yolanda | i create a tooling to start and stop backend for testing | 16:55 |
yolanda | https://review.openstack.org/155975 | 16:55 |
ricky1 | weee | 16:55 |
ricky1 | nice | 16:55 |
yolanda | and most important, i proposed some initial job https://review.openstack.org/156044 | 16:55 |
yolanda | but i need jeblair feedback on that, about zuul-cloner | 16:56 |
krotscheck | NICE | 16:56 |
jeblair | yolanda: i should be able to do that tomorrow! | 16:56 |
yolanda | ok, thx, i left some comments on the change | 16:56 |
yolanda | Ajaeger also reviewed the change | 16:56 |
yolanda | i set the tests as non-voting but seems that for gate, all tests need to pass | 16:56 |
yolanda | so we either rely on check-* at the moment, or we use some experimental pipeline | 16:57 |
yolanda | what do you think? | 16:57 |
jeblair | yolanda: just put the nonvoting job in check, then when you are ready to make it voting, add it to the gate in the same change | 16:57 |
yolanda | maybe just a check and we ensure that everything makes sense? | 16:57 |
yolanda | ok | 16:57 |
yolanda | and krotscheck, i created some initial POC for the integration tests, but i'm sure you can give better advice :) | 16:58 |
yolanda | https://review.openstack.org/156217 | 16:58 |
krotscheck | On it! | 16:58 |
yolanda | basically using protractor to test real api requests | 16:58 |
* krotscheck loves all the words in that sentence. | 16:58 | |
*** markvoelker has quit IRC | 16:59 | |
yolanda | i was reading a lot about TDD, karma and protractor this weekend on Safari | 16:59 |
krotscheck | Alright, we’re ready to wrap up. | 16:59 |
yolanda | i really love that subscription | 16:59 |
yolanda | ok, latest one | 16:59 |
yolanda | https://review.openstack.org/155242 | 16:59 |
yolanda | this needs another +2 ^ | 16:59 |
*** sarob has joined #openstack-meeting-3 | 16:59 | |
krotscheck | NikitaKonovalov: you’re on deck for htat. | 17:00 |
krotscheck | I’ve already _2’d it :) | 17:00 |
krotscheck | Thanks everyone! | 17:00 |
krotscheck | #endmeeting StoryBoard | 17:00 |
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings" | 17:00 | |
openstack | Meeting ended Mon Feb 16 17:00:14 2015 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 17:00 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/storyboard/2015/storyboard.2015-02-16-16.00.html | 17:00 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/storyboard/2015/storyboard.2015-02-16-16.00.txt | 17:00 |
openstack | Log: http://eavesdrop.openstack.org/meetings/storyboard/2015/storyboard.2015-02-16-16.00.log.html | 17:00 |
*** ricky1 has left #openstack-meeting-3 | 17:02 | |
*** scheuran has quit IRC | 17:06 | |
*** coolsvap is now known as coolsvap_ | 17:14 | |
*** sahid has quit IRC | 17:16 | |
*** wojdev has quit IRC | 17:17 | |
*** devvesa has quit IRC | 17:18 | |
*** yamamoto has quit IRC | 17:24 | |
*** etoews has quit IRC | 17:25 | |
*** nelsnelson has quit IRC | 17:25 | |
*** jtomasek has quit IRC | 17:25 | |
*** mtreinish has quit IRC | 17:25 | |
*** alazarev has quit IRC | 17:25 | |
*** gugl2 has quit IRC | 17:25 | |
*** JoshNang has quit IRC | 17:25 | |
*** SergeyLukjanov has quit IRC | 17:25 | |
*** notmyname has quit IRC | 17:25 | |
*** rharwood has quit IRC | 17:25 | |
*** MaxV has quit IRC | 17:29 | |
*** notmyname has joined #openstack-meeting-3 | 17:31 | |
*** etoews has joined #openstack-meeting-3 | 17:31 | |
*** nelsnelson has joined #openstack-meeting-3 | 17:31 | |
*** jtomasek has joined #openstack-meeting-3 | 17:31 | |
*** mtreinish has joined #openstack-meeting-3 | 17:31 | |
*** alazarev has joined #openstack-meeting-3 | 17:31 | |
*** gugl2 has joined #openstack-meeting-3 | 17:31 | |
*** JoshNang has joined #openstack-meeting-3 | 17:31 | |
*** SergeyLukjanov has joined #openstack-meeting-3 | 17:31 | |
*** rharwood has joined #openstack-meeting-3 | 17:31 | |
*** matrohon has quit IRC | 17:41 | |
*** johnthetubaguy is now known as zz_johnthetubagu | 17:45 | |
*** jrist has quit IRC | 17:46 | |
*** etoews_ has joined #openstack-meeting-3 | 17:52 | |
*** etoews has quit IRC | 17:55 | |
*** markvoelker has joined #openstack-meeting-3 | 17:56 | |
*** jcoufal_ has quit IRC | 17:57 | |
*** jrist has joined #openstack-meeting-3 | 17:59 | |
*** markvoelker has quit IRC | 18:01 | |
*** reed has joined #openstack-meeting-3 | 18:02 | |
*** sarob has quit IRC | 18:03 | |
*** amotoki_ has joined #openstack-meeting-3 | 18:04 | |
*** ivar-lazzaro has joined #openstack-meeting-3 | 18:05 | |
*** ivar-lazzaro has quit IRC | 18:06 | |
*** ivar-lazzaro has joined #openstack-meeting-3 | 18:07 | |
*** amotoki_ has quit IRC | 18:08 | |
*** marun has joined #openstack-meeting-3 | 18:17 | |
*** Youcef has joined #openstack-meeting-3 | 18:20 | |
*** yamamoto has joined #openstack-meeting-3 | 18:24 | |
*** coolsvap_ is now known as coolsvap | 18:25 | |
*** yamamoto has quit IRC | 18:29 | |
*** etoews_ has quit IRC | 18:33 | |
*** yolanda has left #openstack-meeting-3 | 18:34 | |
*** Youcef has quit IRC | 18:36 | |
*** nelsnelson has quit IRC | 18:46 | |
*** etoews has joined #openstack-meeting-3 | 18:47 | |
*** wojdev has joined #openstack-meeting-3 | 18:49 | |
*** mrmartin has joined #openstack-meeting-3 | 18:51 | |
*** SridharRamaswamy has quit IRC | 18:55 | |
*** markvoelker has joined #openstack-meeting-3 | 18:57 | |
*** VW_ has joined #openstack-meeting-3 | 18:58 | |
*** VW_ has quit IRC | 18:59 | |
*** markvoelker has quit IRC | 19:02 | |
*** VW_ has joined #openstack-meeting-3 | 19:03 | |
*** VW_ has quit IRC | 19:11 | |
*** Networkn3rd has quit IRC | 19:16 | |
*** Networkn3rd has joined #openstack-meeting-3 | 19:17 | |
*** egallen has quit IRC | 19:18 | |
*** etoews has quit IRC | 19:22 | |
*** Networkn_ has joined #openstack-meeting-3 | 19:23 | |
*** Networkn3rd has quit IRC | 19:27 | |
*** zz_johnthetubagu is now known as johnthetubaguy | 19:30 | |
*** coolsvap is now known as coolsvap_ | 19:31 | |
*** baoli has joined #openstack-meeting-3 | 19:32 | |
*** wojdev has quit IRC | 19:32 | |
*** etoews has joined #openstack-meeting-3 | 19:32 | |
*** belmoreira has joined #openstack-meeting-3 | 19:43 | |
*** MaxV has joined #openstack-meeting-3 | 19:45 | |
*** wojdev has joined #openstack-meeting-3 | 19:52 | |
*** MaxV has quit IRC | 19:57 | |
*** markvoelker has joined #openstack-meeting-3 | 19:58 | |
*** etoews_ has joined #openstack-meeting-3 | 19:59 | |
*** etoews has quit IRC | 20:00 | |
*** markvoelker has quit IRC | 20:03 | |
*** nelsnelson has joined #openstack-meeting-3 | 20:09 | |
*** nelsnelson has quit IRC | 20:10 | |
*** nelsnelson has joined #openstack-meeting-3 | 20:11 | |
*** wojdev has quit IRC | 20:15 | |
*** sarob has joined #openstack-meeting-3 | 20:22 | |
*** sarob has quit IRC | 20:27 | |
*** mrunge has quit IRC | 20:36 | |
*** jtomasek has quit IRC | 20:37 | |
*** yamamoto has joined #openstack-meeting-3 | 20:44 | |
*** banix has quit IRC | 20:47 | |
*** Longgeek has quit IRC | 20:48 | |
*** yamamoto has quit IRC | 20:49 | |
*** banix has joined #openstack-meeting-3 | 20:52 | |
*** Networkn_ has quit IRC | 20:52 | |
*** VW_ has joined #openstack-meeting-3 | 20:54 | |
*** dboik has joined #openstack-meeting-3 | 20:58 | |
*** markvoelker has joined #openstack-meeting-3 | 20:59 | |
*** watanabe_isao has joined #openstack-meeting-3 | 21:00 | |
*** devlaps has joined #openstack-meeting-3 | 21:01 | |
*** dboik has quit IRC | 21:04 | |
*** markvoelker has quit IRC | 21:04 | |
*** jtomasek has joined #openstack-meeting-3 | 21:05 | |
*** watanabe_isao has quit IRC | 21:07 | |
*** yamamoto has joined #openstack-meeting-3 | 21:07 | |
*** mrmartin has quit IRC | 21:09 | |
*** VW_ has quit IRC | 21:09 | |
*** jgrimm is now known as zz_jgrimm | 21:12 | |
*** bradjones has joined #openstack-meeting-3 | 21:13 | |
*** hichihara has joined #openstack-meeting-3 | 21:16 | |
*** yamamoto has quit IRC | 21:17 | |
*** yamamoto has joined #openstack-meeting-3 | 21:18 | |
*** marun has quit IRC | 21:28 | |
*** jcoufal has joined #openstack-meeting-3 | 21:29 | |
*** MaxV has joined #openstack-meeting-3 | 21:29 | |
*** narenhn has joined #openstack-meeting-3 | 21:34 | |
*** etoews_ has quit IRC | 21:58 | |
*** etoews has joined #openstack-meeting-3 | 21:59 | |
*** markvoelker has joined #openstack-meeting-3 | 22:01 | |
*** sergef has quit IRC | 22:02 | |
*** markvoelker has quit IRC | 22:05 | |
*** belmoreira has quit IRC | 22:07 | |
*** thangp has quit IRC | 22:08 | |
*** Longgeek has joined #openstack-meeting-3 | 22:08 | |
*** pjnaik1990_ has joined #openstack-meeting-3 | 22:15 | |
pjnaik1990_ | hello!! I have made few changes in the congress code, I am new to openstack.could anyone tell me how do I give the code for review | 22:16 |
*** jtomasek has quit IRC | 22:19 | |
*** sarob has joined #openstack-meeting-3 | 22:24 | |
*** marun has joined #openstack-meeting-3 | 22:26 | |
*** johnthetubaguy is now known as zz_johnthetubagu | 22:27 | |
*** sarob has quit IRC | 22:29 | |
*** marun has quit IRC | 22:30 | |
*** pjnaik1990_ has quit IRC | 22:35 | |
*** mattgriffin has joined #openstack-meeting-3 | 22:35 | |
*** Longgeek has quit IRC | 22:41 | |
*** absubram has quit IRC | 22:48 | |
*** marun has joined #openstack-meeting-3 | 22:48 | |
*** seizadi has joined #openstack-meeting-3 | 22:52 | |
*** peristeri has quit IRC | 22:54 | |
*** markvoelker has joined #openstack-meeting-3 | 23:02 | |
*** salv-orlando has joined #openstack-meeting-3 | 23:02 | |
*** markvoelker has quit IRC | 23:07 | |
*** watanabe_isao has joined #openstack-meeting-3 | 23:08 | |
*** baoli has quit IRC | 23:08 | |
*** MaxV_ has joined #openstack-meeting-3 | 23:14 | |
*** MaxV has quit IRC | 23:14 | |
*** MaxV_ has quit IRC | 23:23 | |
*** MaxV has joined #openstack-meeting-3 | 23:24 | |
*** MaxV has quit IRC | 23:24 | |
*** sarob has joined #openstack-meeting-3 | 23:26 | |
*** sarob has quit IRC | 23:31 | |
*** seizadi has quit IRC | 23:35 | |
*** mattgriffin has quit IRC | 23:47 | |
*** nelsnels_ has joined #openstack-meeting-3 | 23:54 | |
*** Yi has joined #openstack-meeting-3 | 23:54 | |
*** nelsnelson has quit IRC | 23:55 | |
*** jcoufal_ has joined #openstack-meeting-3 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!