| opendevreview | sue proposed openstack/masakari-monitors master: host monitor by consul https://review.opendev.org/c/openstack/masakari-monitors/+/785572 | 01:38 |
|---|---|---|
| opendevreview | sue proposed openstack/masakari-monitors master: host monitor by consul https://review.opendev.org/c/openstack/masakari-monitors/+/785572 | 02:21 |
| yoctozepto | #startmeeting masakari | 06:02 |
| opendevmeet | Meeting started Tue Aug 17 06:02:47 2021 UTC and is due to finish in 60 minutes. The chair is yoctozepto. Information about MeetBot at http://wiki.debian.org/MeetBot. | 06:02 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 06:02 |
| opendevmeet | The meeting name has been set to 'masakari' | 06:02 |
| yoctozepto | will be late (bad traffic) | 06:02 |
| jopdorp | Ok | 06:04 |
| suzhengwei | Take your time. Safety is the most important | 06:04 |
| yoctozepto | ok, I'm ready :-) | 06:16 |
| yoctozepto | #topic agenda | 06:17 |
| yoctozepto | * CI status | 06:17 |
| yoctozepto | * Important pending reviews (important bugfixes, backports) | 06:17 |
| yoctozepto | * Next release planning | 06:17 |
| yoctozepto | * Open discussion | 06:17 |
| yoctozepto | #topic CI status | 06:17 |
| yoctozepto | unfortunately, CI is broken on the masakari repo due to pip failing to reinstall libvirt-python | 06:17 |
| yoctozepto | other repos are green | 06:17 |
| yoctozepto | also, stable branches on masakari repo are green | 06:18 |
| yoctozepto | only the masakari repo master branch is red | 06:18 |
| yoctozepto | I will fix it later but there is no ultimate urgency at the moment | 06:18 |
| yoctozepto | #topic Important pending reviews (important bugfixes, backports) | 06:19 |
| yoctozepto | thanks suzhengwei for merging a chunk of those | 06:20 |
| yoctozepto | only one left for backports: https://review.opendev.org/q/(project:openstack/masakari+OR+project:openstack/masakari-monitors+OR+project:openstack/python-masakariclient+OR+project:openstack/masakari-dashboard)+status:open+-branch:master | 06:21 |
| yoctozepto | #topic Next release planning | 06:23 |
| yoctozepto | Xena's taking big steps, we are very close to client lib freeze | 06:23 |
| yoctozepto | (03 Sep) | 06:23 |
| yoctozepto | this week we are freezing non-client-libs, which, for some reason, includes openstacksdk, but I will be fighting to include masakari additions should they arrive :-) | 06:24 |
| yoctozepto | how are we with respect to new features? | 06:25 |
| yoctozepto | I did not have time this week yet | 06:26 |
| suzhengwei | I update the monitor driver by consul. It has a releasenote and doc descriptions. | 06:27 |
| yoctozepto | ok, great | 06:27 |
| suzhengwei | Some patches already has my +2. If you have time, please give a review. | 06:29 |
| suzhengwei | patches mainly about doc. | 06:29 |
| yoctozepto | mhm, yeah, I'll keep that one tabbed | 06:36 |
| yoctozepto | approved some others thanks to your +2 | 06:36 |
| yoctozepto | please take some time to respond to final comments on https://review.opendev.org/c/openstack/masakari-specs/+/734017 | 06:36 |
| yoctozepto | I think it's easy to merge it like tomorrow | 06:37 |
| yoctozepto | if you can't reproduce the image, then I guess we can just leave a comment that it has to be interpreted differently | 06:37 |
| suzhengwei | thanks | 06:37 |
| yoctozepto | ok, regarding specs themselveves, that's basically it | 06:38 |
| yoctozepto | I will have a look at the implementation of the consul-based monitor | 06:39 |
| yoctozepto | I saw you already refactored the driver, good | 06:39 |
| yoctozepto | and good job excavating that old commit https://review.opendev.org/c/openstack/masakari/+/518653 | 06:40 |
| yoctozepto | I somehow missed it when I was applying archeology on the proposals :-) | 06:41 |
| opendevreview | Merged openstack/masakari-monitors master: Remove conditionals for an ancient openstacksdk https://review.opendev.org/c/openstack/masakari-monitors/+/802800 | 06:41 |
| suzhengwei | https://review.opendev.org/q/topic:%22add-docs%22+(status:open%20OR%20status:open) | 06:42 |
| suzhengwei | I give +2 to one of them. | 06:43 |
| yoctozepto | yeah https://review.opendev.org/c/openstack/masakari-monitors/+/789248 | 06:43 |
| yoctozepto | it needs addressing my previous comments | 06:44 |
| yoctozepto | the basics are fine but we, e.g., should not be merging the autogenerated sample | 06:44 |
| yoctozepto | if you want to address them, then please go ahead; if not, I can take care of them | 06:45 |
| yoctozepto | still, thanks for rebasing :-) | 06:45 |
| yoctozepto | #topic Open discussion | 06:48 |
| yoctozepto | open to discuss anything | 06:48 |
| suzhengwei | Would some one give one guide to install pacemaker? | 06:50 |
| suzhengwei | I haven't seen it in the monitor doc. | 06:50 |
| yoctozepto | it was proposed long time ago in https://review.opendev.org/c/openstack/masakari-monitors/+/489095 | 06:52 |
| yoctozepto | in kolla ansible, the hacluster role provides pacemaker; it's what can be consulted for correctness as it works fine | 06:53 |
| yoctozepto | well, without any fencing at the moment | 06:53 |
| yoctozepto | but fine otherwise | 06:53 |
| suzhengwei | thanks | 06:54 |
| suzhengwei | I added my reviewer to it. | 06:54 |
| yoctozepto | thanks | 06:55 |
| suzhengwei | The commit is partly duplicates of what the doc is now. So I plan to recommit it based on current docs. | 06:55 |
| yoctozepto | yeah, that needs to be done | 06:56 |
| yoctozepto | thanks for undertaking this | 06:56 |
| yoctozepto | I have also seen new patchset from shenxinxin https://review.opendev.org/c/openstack/masakari/+/789460 | 06:58 |
| yoctozepto | but pep8 does not like it | 06:58 |
| shenxinxin | yes,I konw. I will update these days. | 06:59 |
| yoctozepto | please make sure all jobs pass (except for functional as they are broken at least at the moment - I will look for the best way to fix the gate) | 06:59 |
| yoctozepto | ok,thanks | 06:59 |
| yoctozepto | ok, everyone knows how to proceed | 06:59 |
| yoctozepto | thank you for meeting today | 07:00 |
| yoctozepto | #endmeeting | 07:00 |
| opendevmeet | Meeting ended Tue Aug 17 07:00:07 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 07:00 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/masakari/2021/masakari.2021-08-17-06.02.html | 07:00 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/masakari/2021/masakari.2021-08-17-06.02.txt | 07:00 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/masakari/2021/masakari.2021-08-17-06.02.log.html | 07:00 |
| opendevreview | Radosław Piliszek proposed openstack/python-masakariclient master: [CI] Run bandit https://review.opendev.org/c/openstack/python-masakariclient/+/791924 | 07:18 |
| opendevreview | Radosław Piliszek proposed openstack/masakari-dashboard master: [CI] Run bandit https://review.opendev.org/c/openstack/masakari-dashboard/+/791922 | 07:19 |
| yoctozepto | suzhengwei and others: I will release masakari repo stable branches today (well, at least propose to) to let release-based tools and deployments benefit from the api errors fix | 07:22 |
| yoctozepto | two changes ready to merge: | 07:36 |
| yoctozepto | https://review.opendev.org/c/openstack/python-masakariclient/+/791924 | 07:36 |
| yoctozepto | https://review.opendev.org/c/openstack/masakari-dashboard/+/791922 | 07:36 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/masakari-monitors master: [doc] Add config reference guide https://review.opendev.org/c/openstack/masakari-monitors/+/789248 | 07:38 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/masakari-monitors master: [doc] Add config reference guide https://review.opendev.org/c/openstack/masakari-monitors/+/789248 | 07:38 |
| opendevreview | Radosław Piliszek proposed openstack/masakari-monitors master: [doc] Add config reference guide https://review.opendev.org/c/openstack/masakari-monitors/+/789248 | 07:44 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/masakari-monitors master: [doc] Add config reference guide https://review.opendev.org/c/openstack/masakari-monitors/+/789248 | 08:25 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/masakari-monitors master: [doc] Add config reference guide https://review.opendev.org/c/openstack/masakari-monitors/+/789248 | 09:37 |
| opendevreview | Ye Haiyang proposed openstack/masakari-monitors master: [TrivialFix] Improve class names of monitors https://review.opendev.org/c/openstack/masakari-monitors/+/804840 | 10:10 |
| opendevreview | mitya-eremeev-2 proposed openstack/masakari master: Set "disabled reason" for compute service. https://review.opendev.org/c/openstack/masakari/+/800756 | 10:13 |
| opendevreview | Merged openstack/masakari-monitors master: [doc] Add config reference guide https://review.opendev.org/c/openstack/masakari-monitors/+/789248 | 12:15 |
| opendevreview | Radosław Piliszek proposed openstack/masakari master: Generate PDF documentation https://review.opendev.org/c/openstack/masakari/+/686357 | 16:43 |
| opendevreview | Radosław Piliszek proposed openstack/masakari-monitors master: Generate PDF documentation https://review.opendev.org/c/openstack/masakari-monitors/+/686364 | 17:48 |
| opendevreview | Radosław Piliszek proposed openstack/masakari-monitors master: Use some better linting https://review.opendev.org/c/openstack/masakari-monitors/+/804906 | 18:04 |
| opendevreview | Radosław Piliszek proposed openstack/masakari-monitors master: Use some better linting https://review.opendev.org/c/openstack/masakari-monitors/+/804906 | 18:22 |
| opendevreview | Radosław Piliszek proposed openstack/masakari-monitors master: Use libvirt-python from distro https://review.opendev.org/c/openstack/masakari-monitors/+/804913 | 18:53 |
| opendevreview | Radosław Piliszek proposed openstack/masakari master: [DNM] Test gate fix https://review.opendev.org/c/openstack/masakari/+/804914 | 18:57 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!