| *** oz_akan_ has quit IRC | 00:00 | |
| *** oz_akan__ has joined #openstack-marconi | 00:13 | |
| *** malini_afk is now known as malini | 00:58 | |
| peoplemerge | kgriffs|afk: flaper87|afk: sorry for slow uptake on x-msgpack ticket, day job demands ;) | 00:59 |
|---|---|---|
| *** malini is now known as malini_afk | 01:06 | |
| *** oz_akan__ has quit IRC | 01:14 | |
| *** oz_akan_ has joined #openstack-marconi | 01:14 | |
| *** oz_akan_ has quit IRC | 01:18 | |
| *** reed has quit IRC | 01:36 | |
| *** rossk has quit IRC | 01:43 | |
| *** nosnos has joined #openstack-marconi | 01:46 | |
| *** oz_akan_ has joined #openstack-marconi | 02:15 | |
| *** oz_akan_ has quit IRC | 02:19 | |
| *** prashanthr_ has joined #openstack-marconi | 02:24 | |
| *** prashanthr_ has quit IRC | 03:13 | |
| *** nosnos has quit IRC | 03:13 | |
| *** nosnos has joined #openstack-marconi | 03:13 | |
| *** oz_akan_ has joined #openstack-marconi | 03:16 | |
| *** nosnos has quit IRC | 03:17 | |
| *** oz_akan_ has quit IRC | 03:20 | |
| *** prashanthr_ has joined #openstack-marconi | 03:21 | |
| *** nosnos has joined #openstack-marconi | 03:31 | |
| *** nosnos has quit IRC | 03:39 | |
| *** nosnos has joined #openstack-marconi | 03:40 | |
| *** nosnos has quit IRC | 04:00 | |
| *** haomaiwang has joined #openstack-marconi | 04:01 | |
| *** vkmc has quit IRC | 04:13 | |
| *** oz_akan_ has joined #openstack-marconi | 04:16 | |
| *** haomaiwang has quit IRC | 04:17 | |
| *** haomaiwang has joined #openstack-marconi | 04:18 | |
| *** oz_akan_ has quit IRC | 04:21 | |
| *** nosnos has joined #openstack-marconi | 04:21 | |
| *** prashanthr_ has quit IRC | 04:22 | |
| *** haomaiw__ has joined #openstack-marconi | 04:34 | |
| *** haomaiwang has quit IRC | 04:36 | |
| *** prashanthr_ has joined #openstack-marconi | 04:55 | |
| *** AAzza_afk has quit IRC | 04:56 | |
| *** flwang has quit IRC | 05:03 | |
| *** AAzza_afk has joined #openstack-marconi | 05:03 | |
| *** AAzza_afk is now known as AAzza | 05:03 | |
| *** flwang has joined #openstack-marconi | 05:05 | |
| *** torgomatic has quit IRC | 05:15 | |
| *** wirehead_ has quit IRC | 05:15 | |
| *** mwagner_lap has quit IRC | 05:15 | |
| *** fifieldt_ has quit IRC | 05:15 | |
| *** ChanServ has quit IRC | 05:15 | |
| *** ovorp has quit IRC | 05:15 | |
| *** peoplemerge has quit IRC | 05:15 | |
| *** rektide has quit IRC | 05:15 | |
| *** ekarlso has quit IRC | 05:15 | |
| *** flaper87|afk has quit IRC | 05:15 | |
| *** Alex_Gaynor has quit IRC | 05:15 | |
| *** malini_afk has quit IRC | 05:15 | |
| *** dmitryme has quit IRC | 05:15 | |
| *** mgibert has quit IRC | 05:15 | |
| *** boris-42 has quit IRC | 05:15 | |
| *** sebasmagri has quit IRC | 05:15 | |
| *** prashanthr_ has quit IRC | 05:15 | |
| *** AAzza has quit IRC | 05:15 | |
| *** mkoderer has quit IRC | 05:15 | |
| *** stannie has quit IRC | 05:15 | |
| *** tmu has quit IRC | 05:15 | |
| *** jay-atl has quit IRC | 05:15 | |
| *** jraim has quit IRC | 05:15 | |
| *** VeggieMeat has quit IRC | 05:15 | |
| *** megan_w|afk has quit IRC | 05:15 | |
| *** openstackgerrit has quit IRC | 05:15 | |
| *** oz_akan has joined #openstack-marconi | 05:17 | |
| *** oz_akan has quit IRC | 05:21 | |
| *** AAzza has joined #openstack-marconi | 05:28 | |
| *** prashanthr_ has joined #openstack-marconi | 05:28 | |
| *** ovorp has joined #openstack-marconi | 05:28 | |
| *** openstackgerrit has joined #openstack-marconi | 05:28 | |
| *** jay-atl has joined #openstack-marconi | 05:28 | |
| *** malini_afk has joined #openstack-marconi | 05:28 | |
| *** stannie has joined #openstack-marconi | 05:28 | |
| *** mkoderer has joined #openstack-marconi | 05:28 | |
| *** jraim has joined #openstack-marconi | 05:28 | |
| *** mwagner_lap has joined #openstack-marconi | 05:28 | |
| *** fifieldt_ has joined #openstack-marconi | 05:28 | |
| *** torgomatic has joined #openstack-marconi | 05:28 | |
| *** wirehead_ has joined #openstack-marconi | 05:28 | |
| *** peoplemerge has joined #openstack-marconi | 05:28 | |
| *** rektide has joined #openstack-marconi | 05:28 | |
| *** ekarlso has joined #openstack-marconi | 05:28 | |
| *** boris-42 has joined #openstack-marconi | 05:28 | |
| *** mgibert has joined #openstack-marconi | 05:28 | |
| *** flaper87|afk has joined #openstack-marconi | 05:28 | |
| *** sebasmagri has joined #openstack-marconi | 05:28 | |
| *** Alex_Gaynor has joined #openstack-marconi | 05:28 | |
| *** ChanServ has joined #openstack-marconi | 05:28 | |
| *** dmitryme has joined #openstack-marconi | 05:28 | |
| *** megan_w|afk has joined #openstack-marconi | 05:28 | |
| *** VeggieMeat has joined #openstack-marconi | 05:28 | |
| *** tmu has joined #openstack-marconi | 05:28 | |
| *** dickson.freenode.net sets mode: +oo flaper87|afk ChanServ | 05:28 | |
| *** torgomatic has quit IRC | 05:28 | |
| *** wirehead_ has quit IRC | 05:28 | |
| *** mwagner_lap has quit IRC | 05:28 | |
| *** fifieldt_ has quit IRC | 05:28 | |
| *** ChanServ has quit IRC | 05:28 | |
| *** ovorp has quit IRC | 05:28 | |
| *** peoplemerge has quit IRC | 05:28 | |
| *** rektide has quit IRC | 05:28 | |
| *** ekarlso has quit IRC | 05:28 | |
| *** flaper87|afk has quit IRC | 05:28 | |
| *** Alex_Gaynor has quit IRC | 05:28 | |
| *** malini_afk has quit IRC | 05:28 | |
| *** dmitryme has quit IRC | 05:28 | |
| *** mgibert has quit IRC | 05:28 | |
| *** boris-42 has quit IRC | 05:28 | |
| *** sebasmagri has quit IRC | 05:28 | |
| *** prashanthr_ has quit IRC | 05:28 | |
| *** AAzza has quit IRC | 05:28 | |
| *** mkoderer has quit IRC | 05:28 | |
| *** stannie has quit IRC | 05:28 | |
| *** tmu has quit IRC | 05:28 | |
| *** jay-atl has quit IRC | 05:28 | |
| *** jraim has quit IRC | 05:28 | |
| *** VeggieMeat has quit IRC | 05:28 | |
| *** megan_w|afk has quit IRC | 05:28 | |
| *** openstackgerrit has quit IRC | 05:28 | |
| *** AAzza has joined #openstack-marconi | 05:34 | |
| *** prashanthr_ has joined #openstack-marconi | 05:34 | |
| *** ovorp has joined #openstack-marconi | 05:34 | |
| *** openstackgerrit has joined #openstack-marconi | 05:34 | |
| *** jay-atl has joined #openstack-marconi | 05:34 | |
| *** malini_afk has joined #openstack-marconi | 05:34 | |
| *** stannie has joined #openstack-marconi | 05:34 | |
| *** mkoderer has joined #openstack-marconi | 05:34 | |
| *** jraim has joined #openstack-marconi | 05:34 | |
| *** mwagner_lap has joined #openstack-marconi | 05:34 | |
| *** fifieldt_ has joined #openstack-marconi | 05:34 | |
| *** torgomatic has joined #openstack-marconi | 05:34 | |
| *** wirehead_ has joined #openstack-marconi | 05:34 | |
| *** peoplemerge has joined #openstack-marconi | 05:34 | |
| *** rektide has joined #openstack-marconi | 05:34 | |
| *** ekarlso has joined #openstack-marconi | 05:34 | |
| *** boris-42 has joined #openstack-marconi | 05:34 | |
| *** mgibert has joined #openstack-marconi | 05:34 | |
| *** flaper87|afk has joined #openstack-marconi | 05:34 | |
| *** sebasmagri has joined #openstack-marconi | 05:34 | |
| *** Alex_Gaynor has joined #openstack-marconi | 05:34 | |
| *** ChanServ has joined #openstack-marconi | 05:34 | |
| *** dmitryme has joined #openstack-marconi | 05:34 | |
| *** megan_w|afk has joined #openstack-marconi | 05:34 | |
| *** VeggieMeat has joined #openstack-marconi | 05:34 | |
| *** tmu has joined #openstack-marconi | 05:34 | |
| *** dickson.freenode.net sets mode: +oo flaper87|afk ChanServ | 05:34 | |
| *** goodes has joined #openstack-marconi | 05:43 | |
| *** haomaiw__ has quit IRC | 06:07 | |
| *** haomaiwang has joined #openstack-marconi | 06:08 | |
| *** haomai___ has joined #openstack-marconi | 06:10 | |
| *** haomaiwang has quit IRC | 06:14 | |
| *** oz_akan_ has joined #openstack-marconi | 06:17 | |
| *** oz_akan_ has quit IRC | 06:21 | |
| *** goodes has quit IRC | 06:32 | |
| *** haomai___ has quit IRC | 07:16 | |
| *** haomaiwang has joined #openstack-marconi | 07:16 | |
| *** oz_akan_ has joined #openstack-marconi | 07:18 | |
| *** goodes has joined #openstack-marconi | 07:22 | |
| *** oz_akan_ has quit IRC | 07:23 | |
| *** haomai___ has joined #openstack-marconi | 07:31 | |
| *** haomaiwang has quit IRC | 07:34 | |
| *** goodes has quit IRC | 07:41 | |
| *** prashanthr_ has quit IRC | 08:36 | |
| *** prashanthr_ has joined #openstack-marconi | 08:46 | |
| *** oz_akan_ has joined #openstack-marconi | 09:20 | |
| *** oz_akan_ has quit IRC | 09:24 | |
| *** prashanthr_ has quit IRC | 09:37 | |
| *** flaper87|afk is now known as flaper87 | 09:39 | |
| *** goodes has joined #openstack-marconi | 10:09 | |
| *** goodes has left #openstack-marconi | 10:26 | |
| *** flaper87 is now known as flaper87|afk | 10:31 | |
| *** oz_akan_ has joined #openstack-marconi | 10:38 | |
| *** oz_akan_ has quit IRC | 10:42 | |
| *** nosnos has quit IRC | 10:45 | |
| *** shivam_ has quit IRC | 11:04 | |
| *** fifieldt_ has quit IRC | 11:23 | |
| *** fifieldt_ has joined #openstack-marconi | 11:24 | |
| *** oz_akan_ has joined #openstack-marconi | 11:39 | |
| *** mwagner_lap has quit IRC | 11:42 | |
| *** oz_akan_ has quit IRC | 11:43 | |
| *** vkmc has joined #openstack-marconi | 11:48 | |
| *** vkmc has quit IRC | 11:48 | |
| *** vkmc has joined #openstack-marconi | 11:48 | |
| *** jamie_h has joined #openstack-marconi | 11:55 | |
| openstackgerrit | Alex Bettadapur proposed a change to openstack/marconi: Decoupled Unit Tests https://review.openstack.org/97534 | 12:00 |
| *** haomai___ has quit IRC | 12:01 | |
| *** haomaiwang has joined #openstack-marconi | 12:01 | |
| *** haomaiw__ has joined #openstack-marconi | 12:07 | |
| *** haomaiwang has quit IRC | 12:11 | |
| *** abettadapur has joined #openstack-marconi | 12:32 | |
| *** sriram has joined #openstack-marconi | 12:39 | |
| *** oz_akan_ has joined #openstack-marconi | 12:40 | |
| *** shivamshukla has joined #openstack-marconi | 12:41 | |
| *** sriram has quit IRC | 12:42 | |
| *** sriram has joined #openstack-marconi | 12:42 | |
| *** oz_akan_ has quit IRC | 12:44 | |
| *** oz_akan_ has joined #openstack-marconi | 12:49 | |
| *** oz_akan_ has quit IRC | 12:56 | |
| *** oz_akan_ has joined #openstack-marconi | 12:57 | |
| *** jchai has joined #openstack-marconi | 12:58 | |
| *** malini_afk is now known as malini | 12:59 | |
| *** malini has left #openstack-marconi | 13:02 | |
| sriram | good morning :) | 13:02 |
| abettadapur | good morning. how are you today? | 13:03 |
| vkmc | morning sriram, abettadapur :) | 13:03 |
| sriram | abettadapur: meh, not enough sleep again :/ | 13:04 |
| sriram | vkmc: good morning! :) | 13:04 |
| abettadapur | sriram: up too late? | 13:04 |
| sriram | abettadapur: yeah, needed to take care of some stuff. | 13:04 |
| vkmc | sriram, boo, hope you can take the weekend to recover all that sleep | 13:06 |
| sriram | vkmc: oh yes! I definitely plan to :) | 13:07 |
| *** ykaplan has joined #openstack-marconi | 13:15 | |
| *** Obulpathi has joined #openstack-marconi | 13:37 | |
| *** alcabrera|afk is now known as alcabrera | 13:38 | |
| *** jay-atl has quit IRC | 13:54 | |
| *** AAzza is now known as AAzza_afk | 13:58 | |
| peoplemerge | g'morning all! | 14:00 |
| *** ykaplan has quit IRC | 14:01 | |
| vkmc | morning peoplemerge | 14:02 |
| vkmc | ! | 14:02 |
| *** balajiiyer has joined #openstack-marconi | 14:03 | |
| alcabrera | good morning, everyone. :) | 14:03 |
| vkmc | good morning alcabrera :) | 14:05 |
| vkmc | happy friday \o/ | 14:05 |
| alcabrera | yay! | 14:06 |
| alcabrera | heya, vkmc. :) | 14:06 |
| peoplemerge | yay | 14:07 |
| alcabrera | oh yeah | 14:08 |
| alcabrera | so this is a thing: http://dogeon.org/ | 14:08 |
| alcabrera | application/dogeon | 14:08 |
| alcabrera | *content-type: application/dogeon | 14:08 |
| peoplemerge | lol | 14:10 |
| vkmc | lol | 14:11 |
| vkmc | let's remove json and use it instead | 14:11 |
| *** AAzza_afk is now known as AAzza | 14:11 | |
| sriram | alcabrera: hahaa | 14:11 |
| alcabrera | such "ttl" is 100 next "body" is such "implemented" is "all_in_doge" wow wow // message envelope of the future marconi | 14:13 |
| abettadapur | alcabrera: http://zachbruggeman.me/dogescript/ | 14:22 |
| alcabrera | oh my | 14:23 |
| alcabrera | JS what I needed, abettadapur | 14:23 |
| abettadapur | :d | 14:23 |
| abettadapur | :D | 14:23 |
| abettadapur | my favorite is the for loop | 14:23 |
| abettadapur | much very i as 1 next i smaller 3 next i more 1 | 14:24 |
| alcabrera | hahaha | 14:24 |
| alcabrera | shh this is more succinct than JS at times, much impressed | 14:25 |
| *** prashanthr_ has joined #openstack-marconi | 14:31 | |
| *** jamie_h has quit IRC | 14:51 | |
| *** jamie_h has joined #openstack-marconi | 14:51 | |
| *** alcabrera is now known as alcabrera|afk | 14:52 | |
| *** prashanthr_ has left #openstack-marconi | 14:55 | |
| *** jamie_h has quit IRC | 15:07 | |
| *** alcabrera|afk is now known as alcabrera | 15:09 | |
| *** jamie_h has joined #openstack-marconi | 15:11 | |
| AAzza | alcabrera: btw, i think i will absent next week, due to move from Norway to Ukraine and finishing all leftovers for master thesis in Ukraine. Probably will appear from time to time, but not promise to do another commit) | 15:17 |
| alcabrera | AAzza: thanks for letting me know, and I hope your move is a safe one! | 15:18 |
| alcabrera | best of luck on the master's thesis. :) | 15:18 |
| *** kgriffs|afk is now known as kgriffs | 15:19 | |
| AAzza | alcabrera: thanks, will do my best. if flaper87|afk will search for me, let him know) | 15:19 |
| alcabrera | will do | 15:19 |
| alcabrera | I'll pass this along and keep it in mind for next week | 15:19 |
| AAzza | alcabrera: :) anyway, I will try to tell him on Monday/Tuesday, so you can not to reserve too much space in your memory for this) | 15:22 |
| AAzza | alcabrera: have nice weekends) | 15:22 |
| *** openstackgerrit has quit IRC | 15:22 | |
| alcabrera | AAzza: thanks, and you too! :D | 15:22 |
| * alcabrera caches AAzza reminder -- 128 bytes consumed | 15:23 | |
| *** ykaplan has joined #openstack-marconi | 15:28 | |
| *** openstackgerrit has joined #openstack-marconi | 15:29 | |
| *** cpallares has joined #openstack-marconi | 15:31 | |
| *** jchai is now known as jchai_afk | 15:45 | |
| *** jay-atl has joined #openstack-marconi | 15:47 | |
| *** jchai_afk is now known as jchai | 15:47 | |
| *** openstackgerrit has quit IRC | 15:53 | |
| *** jchai is now known as jchai_afk | 15:59 | |
| *** reed has joined #openstack-marconi | 16:02 | |
| *** ykaplan has quit IRC | 16:07 | |
| *** rwsu has joined #openstack-marconi | 16:21 | |
| vkmc | hey alcabrera can I pick your brain about connection handling with a AMQP? | 16:25 |
| *** jchai_afk is now known as jchai | 16:25 | |
| alcabrera | vkmc: sure thing | 16:26 |
| vkmc | alcabrera, current supported storage backends require a connection step to start interacting | 16:28 |
| vkmc | alcabrera, in this case, I'm not sure if we can control the broker status | 16:29 |
| alcabrera | broker status, vkmc? What do you mean by that? | 16:30 |
| vkmc | alcabrera, if the broker is up and running you can send and receive messages directly, but if its not a connection error will be raised | 16:30 |
| alcabrera | ah | 16:30 |
| alcabrera | so then | 16:31 |
| vkmc | the broker is the server in AMQP, we only can manage the client | 16:31 |
| alcabrera | that's right | 16:31 |
| alcabrera | what if we use an auto-reconnect model | 16:31 |
| alcabrera | with exponential backoff | 16:31 |
| alcabrera | marconi-server side? | 16:32 |
| vkmc | how would that be? | 16:32 |
| alcabrera | if the broker is down, we can hope it won't be down for more than... say a minute? | 16:32 |
| alcabrera | we attempt to initiate a connection | 16:32 |
| alcabrera | if it succeeds, we continue | 16:32 |
| vkmc | sounds good | 16:32 |
| alcabrera | if it fails, we wait and retry a few times | 16:32 |
| alcabrera | it's how we handle mongodb, I believe | 16:32 |
| alcabrera | for all operations | 16:32 |
| vkmc | I think so too yeah | 16:33 |
| alcabrera | cool, but to circle around to your initial question | 16:33 |
| alcabrera | we have no control of the broker status. :) | 16:33 |
| vkmc | nice | 16:33 |
| vkmc | and regarding the client | 16:34 |
| vkmc | since it's a library I not sure if it makes sense to have an is_alive function | 16:35 |
| *** mwagner_lap has joined #openstack-marconi | 16:35 | |
| vkmc | but our API interface has one | 16:35 |
| alcabrera | hmmm | 16:36 |
| alcabrera | if it is possible to detect whether the amqp connection/broker is still there | 16:36 |
| vkmc | https://github.com/openstack/marconi/blob/master/marconi/queues/storage/base.py#L64 | 16:36 |
| alcabrera | I think it makes sense | 16:36 |
| *** openstackgerrit has joined #openstack-marconi | 16:36 | |
| alcabrera | e.g., if amqp_is_still_alive -> True else False | 16:36 |
| alcabrera | operators love this functionality, if we can provide it | 16:36 |
| vkmc | of course | 16:36 |
| vkmc | I'll check that out then | 16:37 |
| alcabrera | with mongodb, it's implemented by sending a ping command to the storage node | 16:37 |
| alcabrera | if that helps ^ | 16:37 |
| vkmc | it does, I think that behaves similarly here | 16:38 |
| alcabrera | cool | 16:40 |
| alcabrera | any other thoughts, vkmc? :) | 16:40 |
| vkmc | thanks alcabrera | 16:40 |
| vkmc | no :) | 16:41 |
| alcabrera | alright, thanks vkmc! :D | 16:42 |
| *** balajiiyer has quit IRC | 17:03 | |
| *** oz_akan_ has quit IRC | 17:09 | |
| *** oz_akan_ has joined #openstack-marconi | 17:10 | |
| *** oz_akan_ has quit IRC | 17:14 | |
| *** balajiiyer has joined #openstack-marconi | 17:17 | |
| *** balajiiyer1 has joined #openstack-marconi | 17:19 | |
| *** balajiiyer has quit IRC | 17:21 | |
| kgriffs | folks, I've got to run but I'll check back in a couple hours. | 17:23 |
| kgriffs | keep calm and message on | 17:23 |
| kgriffs | :D | 17:23 |
| *** stannie has quit IRC | 17:24 | |
| *** kgriffs is now known as kgriffs|afk | 17:24 | |
| *** AAzza is now known as AAzza_afk | 17:27 | |
| *** mwagner_lap has quit IRC | 17:31 | |
| vkmc | haha +1 kgriffs|afk | 17:32 |
| sriram | alcabrera: hey, could you have a look at https://review.openstack.org/#/c/97875/2? | 17:54 |
| sriram | marconi-bench is blocked due to this. | 17:55 |
| *** haomaiw__ has quit IRC | 17:59 | |
| *** haomaiwa_ has joined #openstack-marconi | 18:00 | |
| alcabrera | sriram: sure thing! | 18:00 |
| alcabrera | I'll give it a review in 10m. :) | 18:00 |
| sriram | thanks! | 18:00 |
| alcabrera | sriram: +2 | 18:05 |
| *** oz_akan_ has joined #openstack-marconi | 18:06 | |
| sriram | thanks alcabrera! :) | 18:07 |
| sriram | flaper87|afk, kgriffs|afk: https://review.openstack.org/#/c/97875/2 | 18:09 |
| *** cpallares has quit IRC | 18:23 | |
| *** balajiiyer1 has quit IRC | 18:25 | |
| *** jamie_h has quit IRC | 18:34 | |
| *** jamie_h has joined #openstack-marconi | 18:41 | |
| *** haomaiwa_ has quit IRC | 18:47 | |
| *** haomaiwang has joined #openstack-marconi | 18:47 | |
| *** jamie_h_ has joined #openstack-marconi | 18:48 | |
| *** oz_akan_ has quit IRC | 18:48 | |
| *** jamie_h has quit IRC | 18:48 | |
| *** oz_akan_ has joined #openstack-marconi | 18:49 | |
| tjanczuk_ | vkmc: What are you planning to do about listing queues and operations on queues in general in AMQP 1.0? As far as I know AMQP itself does not support listing queues. In case of Rabbit it has a separate HTTP-based management API that allows listing queues. | 18:50 |
| vkmc | tjanczuk_, hi! | 18:55 |
| vkmc | tjanczuk_, well, queues are not an entity in AMQP 1.0 | 18:56 |
| vkmc | tjanczuk_, they are just message attributes | 18:56 |
| vkmc | tjanczuk_, so queue operations shouldn't be available to the user | 18:57 |
| *** balajiiyer has joined #openstack-marconi | 18:57 | |
| *** abettadapur has quit IRC | 19:03 | |
| *** jay-atl has quit IRC | 19:14 | |
| tjanczuk_ | vkmc: so the AMQP 1.0 driver would not support any of the queue HTTP APIs (create/list/delete)? I think we are getting to the point where the intersection of the HTTP APIs supported by all drivers is only going to be message publish/mesasge receive ;) | 19:15 |
| *** kgriffs|afk is now known as kgriffs | 19:20 | |
| sriram | kgriffs: ping, could you have a look at https://review.openstack.org/#/c/97875/2 | 19:26 |
| kgriffs | yep | 19:26 |
| sriram | thanks kgriffs! | 19:26 |
| sriram | I have started work on conductor, i'm launching multi-processed subprocesses from the conductor for both the consumer and the producer. | 19:28 |
| kgriffs | sriram: ok, I only have one nit | 19:29 |
| kgriffs | and I blame HTTP, not you | 19:29 |
| sriram | oh, what is it? | 19:29 |
| kgriffs | or, whoever first decided to implement authentication over HTTP | 19:30 |
| kgriffs | :p | 19:30 |
| kgriffs | 401 Unauthorized *actually* means unauthenticated | 19:30 |
| sriram | yeah.. | 19:30 |
| kgriffs | basically, 403 should have been "Unauthorized" | 19:31 |
| kgriffs | and 401 should have been "Unauthenticated" | 19:31 |
| alcabrera | git blame http | 19:31 |
| kgriffs | anyway, what do you think about renaming the UnAuthorizedError exception to UnauthenticatedError? | 19:32 |
| kgriffs | we'd better leave "ForbiddenError" alone in any case, since changing it would only cause more confusion | 19:33 |
| sriram | hmm, sure I can but wont it be non-uniform? | 19:33 |
| kgriffs | good point. hmm. | 19:33 |
| kgriffs | wait... I got it. | 19:33 |
| kgriffs | How about "AuthError" | 19:34 |
| kgriffs | hmm, but then you still have forbidden | 19:34 |
| kgriffs | autherror sounds more like a generalization of the two... | 19:34 |
| * kgriffs continues thinking | 19:35 | |
| sriram | yeah, I think it might be better the way it is. | 19:35 |
| sriram | whatever else we do, would be some middleground between our planes of reasoning and the HTTP standard. | 19:36 |
| kgriffs | yep | 19:36 |
| kgriffs | <sigh> | 19:36 |
| sriram | we should maybe have a petition for better HTTP standards soon :) | 19:37 |
| kgriffs | sriram: what do you think about adding a human-friendly description string to each error in a followup patch? | 19:37 |
| sriram | kgriffs: sure | 19:38 |
| sriram | I'll do that. :) | 19:38 |
| sriram | brb | 19:38 |
| kgriffs | We would need to keep the description a little generic, since these errors will eventually be used for non-HTTP transport (be it websocket or something else) | 19:38 |
| *** sriram is now known as sriram_afk | 19:38 | |
| *** ykaplan has joined #openstack-marconi | 19:39 | |
| *** sriram_afk is now known as sriram | 19:39 | |
| sriram | kgriffs: good point! | 19:40 |
| kgriffs | ok, found one more nit | 19:40 |
| sriram | it makes sense for non-HTTP transport. | 19:40 |
| kgriffs | UnAuthorized ---> Unauthorized | 19:40 |
| kgriffs | otherwise, LGTM | 19:40 |
| kgriffs | btw, is there a test somewhere that ensures these errors are thrown? | 19:41 |
| kgriffs | s/thrown/raised | 19:41 |
| sriram | I looked around and didnt find anything that exactly verifies. | 19:41 |
| sriram | let me recheck. | 19:41 |
| kgriffs | I guess you could mock http.Client and do a test that iterates through HttpTransport.http_to_marconi, ensuring that when the client returns each status, the corresponding error class is raised | 19:43 |
| sriram | alright, I'll make those changes. | 19:45 |
| vkmc | tjanczuk_, yes it will require *a lot* of polishing | 19:53 |
| vkmc | tjanczuk_, flaper87 proposed some time ago the concept of topics | 19:53 |
| kgriffs | vkmc: right. I think the central idea was that a topic would be less of a concrete resource than a queue. As far as the implementation goes, they are already very light weight and we are adding lazy queue creation (automatically creating a queue when a message is first posted to it), so not being able to "delete" queues should be OK. | 19:56 |
| kgriffs | except | 19:56 |
| kgriffs | in the case of the mongo/redis drivers, we need to ensure that a queue record is really just a name attached to each message, and we only keep track of a separate "queue" record if there is metadata | 19:57 |
| vkmc | kgriffs, makes sense | 20:01 |
| *** jamie_h_ has quit IRC | 20:03 | |
| *** balajiiyer has quit IRC | 20:10 | |
| *** ykaplan has quit IRC | 20:31 | |
| *** sriram has quit IRC | 20:34 | |
| *** kgriffs is now known as kgriffs|afk | 20:36 | |
| *** kgriffs|afk is now known as kgriffs | 20:41 | |
| *** alcabrera is now known as alcabrera|afk | 20:42 | |
| *** jchai has quit IRC | 20:42 | |
| *** kgriffs is now known as kgriffs|afk | 20:42 | |
| *** Obulpathi has quit IRC | 21:10 | |
| *** kgriffs|afk is now known as kgriffs | 21:22 | |
| * peoplemerge is hoping to write some python today | 21:33 | |
| *** oz_akan_ has quit IRC | 21:56 | |
| *** oz_akan_ has joined #openstack-marconi | 21:56 | |
| *** flwang has quit IRC | 21:59 | |
| *** haomaiwang has quit IRC | 22:01 | |
| *** oz_akan_ has quit IRC | 22:06 | |
| *** flwang has joined #openstack-marconi | 22:29 | |
| openstackgerrit | Kurt Griffiths proposed a change to openstack/marconi: fix: Checking whether queue exists adds latency https://review.openstack.org/67978 | 23:41 |
| *** kgriffs is now known as kgriffs|afk | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!