| *** oz_akan_ has joined #openstack-marconi | 00:17 | |
| *** oz_akan_ has quit IRC | 00:21 | |
| vkmc | kgriffs|afk, Should 'Your first review' contain information about how to do a review... or about how to submit a patch to review? | 00:29 |
|---|---|---|
| vkmc | Currently is the latter | 00:29 |
| *** amitgandhi has joined #openstack-marconi | 00:53 | |
| *** kgriffs|afk is now known as kgriffs | 00:55 | |
| *** amitgandhi has quit IRC | 00:57 | |
| vkmc | kgriffs, ^^ | 01:10 |
| kgriffs | hmm, let me think | 01:10 |
| kgriffs | how to do a review. It should say something about how much we need and rely on everyone to help review code. It's the cheapest way to discover bugs | 01:11 |
| kgriffs | basically, I want new contributors to know what a good, thorough review i | 01:11 |
| kgriffs | is | 01:11 |
| kgriffs | and give them tips like, try to say something nice | 01:11 |
| vkmc | So... the idea is to provide tips on how to review code... not on how to submit code for review | 01:12 |
| kgriffs | talk about how a -1 is common just to flag a review as "here are some comments you should look at | 01:12 |
| kgriffs | vkmc: correct | 01:12 |
| vkmc | Something like this? https://wiki.openstack.org/wiki/ReviewChecklist | 01:12 |
| kgriffs | and if you are the patch author, respond to comments and then just use a score of "0" | 01:13 |
| vkmc | Cool :) | 01:13 |
| kgriffs | vkmc: yeah, that page is a good foundation. We should recommend they read that | 01:13 |
| kgriffs | and then give them more advice | 01:13 |
| kgriffs | :) | 01:14 |
| kgriffs | also, if there is anything unique to marconi, we should talk about that. | 01:14 |
| vkmc | Yeah... we can set it up so we have some content for Tuesday | 01:14 |
| kgriffs | it may take a few weeks of tweaking, and adding stuff as we think of it during our day-to-day work | 01:14 |
| vkmc | And continue polishing later | 01:15 |
| vkmc | Sure! | 01:15 |
| kgriffs | vkmc: sounds good, let's get a good start there. and then just keep thinking about it. be observant and when you notice things we do as a team and normally take for granted, let's document that | 01:15 |
| kgriffs | same goes for all of these docs, really | 01:15 |
| kgriffs | :) | 01:15 |
| vkmc | Will do! | 01:16 |
| kgriffs | just thought of one thing you can include | 01:16 |
| vkmc | And yeah... docs are hard to keep updated, but we can do it | 01:16 |
| kgriffs | the reviewer should check that if a patch is changing the API, the client should also be updated | 01:16 |
| vkmc | Good point | 01:17 |
| kgriffs | so, stuff like that. all the tribal knowledge needs to get documented | 01:18 |
| *** oz_akan_ has joined #openstack-marconi | 01:18 | |
| kgriffs | I want us to lead by example there | 01:18 |
| kgriffs | show other programs how to be more inclusive of "outsiders" | 01:18 |
| * kgriffs has all kinds of hidden agendas ;) | 01:18 | |
| vkmc | Yeah, in the end those little things are the most important | 01:18 |
| vkmc | +1 | 01:19 |
| *** oz_akan__ has joined #openstack-marconi | 01:19 | |
| vkmc | Is awesome that Marconi does that... it's a true open-source project :) | 01:20 |
| *** oz_akan_ has quit IRC | 01:22 | |
| *** oz_akan__ has quit IRC | 01:23 | |
| kgriffs | you need open minds to build an open cloud. :) | 01:31 |
| kgriffs | actually, let me rephrase | 01:31 |
| kgriffs | you need open arms to build an open cloud | 01:31 |
| vkmc | I vote for both! | 01:32 |
| *** shakamunyi has joined #openstack-marconi | 01:38 | |
| *** shakamunyi has quit IRC | 01:50 | |
| *** amitgandhi has joined #openstack-marconi | 01:54 | |
| *** amitgandhi has quit IRC | 01:59 | |
| *** oz_akan_ has joined #openstack-marconi | 02:20 | |
| *** oz_akan_ has quit IRC | 02:24 | |
| *** amitgandhi has joined #openstack-marconi | 02:55 | |
| *** amitgandhi has quit IRC | 02:59 | |
| *** reed has joined #openstack-marconi | 03:17 | |
| *** reed has quit IRC | 03:17 | |
| *** oz_akan_ has joined #openstack-marconi | 03:21 | |
| *** vkmc has quit IRC | 03:24 | |
| *** oz_akan_ has quit IRC | 03:25 | |
| *** oz_akan_ has joined #openstack-marconi | 03:25 | |
| *** oz_akan_ has quit IRC | 03:38 | |
| *** oz_akan_ has joined #openstack-marconi | 03:39 | |
| *** amitgandhi has joined #openstack-marconi | 03:55 | |
| *** oz_akan__ has joined #openstack-marconi | 03:58 | |
| *** amitgandhi has quit IRC | 04:00 | |
| *** oz_akan_ has quit IRC | 04:01 | |
| *** vkmc has joined #openstack-marconi | 04:23 | |
| *** amitgandhi has joined #openstack-marconi | 04:56 | |
| *** amitgandhi has quit IRC | 05:00 | |
| *** oz_akan__ has quit IRC | 05:14 | |
| *** oz_akan_ has joined #openstack-marconi | 05:45 | |
| *** oz_akan_ has quit IRC | 05:49 | |
| *** amitgandhi has joined #openstack-marconi | 05:57 | |
| *** amitgandhi has quit IRC | 06:02 | |
| *** oz_akan_ has joined #openstack-marconi | 06:46 | |
| *** oz_akan_ has quit IRC | 06:50 | |
| *** vkmc has quit IRC | 06:51 | |
| *** amitgandhi has joined #openstack-marconi | 06:58 | |
| *** amitgandhi has quit IRC | 07:02 | |
| *** kgriffs is now known as kgriffs|afk | 07:09 | |
| *** oz_akan_ has joined #openstack-marconi | 07:47 | |
| *** ykaplan has joined #openstack-marconi | 07:50 | |
| *** oz_akan_ has quit IRC | 07:51 | |
| *** amitgandhi has joined #openstack-marconi | 07:58 | |
| *** amitgandhi has quit IRC | 08:03 | |
| *** mkoderer has joined #openstack-marconi | 08:46 | |
| *** oz_akan_ has joined #openstack-marconi | 08:47 | |
| *** oz_akan_ has quit IRC | 08:52 | |
| *** amitgandhi has joined #openstack-marconi | 08:59 | |
| *** amitgandhi has quit IRC | 09:03 | |
| *** ykaplan has quit IRC | 09:47 | |
| *** oz_akan_ has joined #openstack-marconi | 09:48 | |
| *** oz_akan_ has quit IRC | 09:52 | |
| *** amitgandhi has joined #openstack-marconi | 10:00 | |
| *** amitgandhi has quit IRC | 10:04 | |
| *** ykaplan has joined #openstack-marconi | 10:27 | |
| *** oz_akan_ has joined #openstack-marconi | 10:49 | |
| *** oz_akan_ has quit IRC | 10:53 | |
| *** amitgandhi has joined #openstack-marconi | 11:01 | |
| *** amitgandhi has quit IRC | 11:05 | |
| *** AAzza has joined #openstack-marconi | 11:45 | |
| *** oz_akan_ has joined #openstack-marconi | 11:50 | |
| *** oz_akan_ has quit IRC | 11:54 | |
| *** amitgandhi has joined #openstack-marconi | 12:02 | |
| *** amitgandhi has quit IRC | 12:06 | |
| *** oz_akan_ has joined #openstack-marconi | 12:50 | |
| *** oz_akan_ has quit IRC | 12:55 | |
| *** amitgandhi has joined #openstack-marconi | 13:02 | |
| *** amitgandhi has quit IRC | 13:07 | |
| *** reed has joined #openstack-marconi | 13:25 | |
| *** AAzza has quit IRC | 13:28 | |
| *** AAzza has joined #openstack-marconi | 13:29 | |
| *** AAzza has quit IRC | 13:46 | |
| *** AAzza has joined #openstack-marconi | 14:00 | |
| *** amitgandhi has joined #openstack-marconi | 14:03 | |
| *** AAzza has quit IRC | 14:05 | |
| *** amitgandhi has quit IRC | 14:07 | |
| *** AAzza has joined #openstack-marconi | 14:12 | |
| *** AAzza has quit IRC | 14:16 | |
| *** vkmc has joined #openstack-marconi | 14:34 | |
| *** vkmc has quit IRC | 14:34 | |
| *** vkmc has joined #openstack-marconi | 14:34 | |
| *** haomaiwa_ has joined #openstack-marconi | 14:37 | |
| *** amitgandhi has joined #openstack-marconi | 15:04 | |
| *** amitgandhi has quit IRC | 15:08 | |
| *** mkoderer has quit IRC | 15:12 | |
| *** haomaiw__ has joined #openstack-marconi | 15:24 | |
| *** haomaiwa_ has quit IRC | 15:26 | |
| *** haomaiw__ has quit IRC | 15:30 | |
| *** ykaplan has quit IRC | 15:52 | |
| *** ykaplan has joined #openstack-marconi | 16:17 | |
| *** ykaplan has quit IRC | 16:45 | |
| *** amitgandhi has joined #openstack-marconi | 17:05 | |
| *** anamalagon has quit IRC | 17:07 | |
| *** amitgandhi has quit IRC | 17:10 | |
| *** jamie_h has joined #openstack-marconi | 17:44 | |
| *** amitgandhi has joined #openstack-marconi | 18:06 | |
| *** jamie_h_ has joined #openstack-marconi | 18:06 | |
| *** jamie_h has quit IRC | 18:09 | |
| *** amitgandhi has quit IRC | 18:11 | |
| *** kgriffs|afk is now known as kgriffs | 18:22 | |
| *** mkoderer has joined #openstack-marconi | 18:50 | |
| *** ykaplan has joined #openstack-marconi | 18:51 | |
| *** amitgandhi has joined #openstack-marconi | 19:07 | |
| *** jamie_h_ has quit IRC | 19:07 | |
| *** amitgandhi has quit IRC | 19:11 | |
| *** ykaplan has quit IRC | 19:19 | |
| *** kgriffs is now known as kgriffs|afk | 19:52 | |
| *** amitgandhi has joined #openstack-marconi | 20:08 | |
| *** amitgandhi has quit IRC | 20:12 | |
| *** amitgandhi has joined #openstack-marconi | 21:08 | |
| *** jmckind has joined #openstack-marconi | 21:12 | |
| *** jmckind has quit IRC | 21:13 | |
| *** amitgandhi has quit IRC | 21:13 | |
| *** reed has quit IRC | 21:41 | |
| *** amitgandhi has joined #openstack-marconi | 22:09 | |
| *** amitgandhi has quit IRC | 22:14 | |
| *** amitgandhi has joined #openstack-marconi | 23:10 | |
| *** amitgandhi has quit IRC | 23:15 | |
| *** balajiiyer has joined #openstack-marconi | 23:32 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!