*** malini_afk is now known as malini | 00:23 | |
*** reed has quit IRC | 00:33 | |
*** ayoung has quit IRC | 00:40 | |
*** oz_akan_ has joined #openstack-marconi | 00:44 | |
*** amitgandhi has joined #openstack-marconi | 00:46 | |
*** oz_akan_ has quit IRC | 00:51 | |
*** amitgandhi has quit IRC | 00:51 | |
*** oz_akan_ has joined #openstack-marconi | 00:51 | |
*** nosnos has joined #openstack-marconi | 01:03 | |
*** ayoung has joined #openstack-marconi | 01:17 | |
*** amitgandhi has joined #openstack-marconi | 01:18 | |
*** vkmc has quit IRC | 01:20 | |
*** oz_akan__ has joined #openstack-marconi | 01:58 | |
*** amit has joined #openstack-marconi | 02:00 | |
*** amit is now known as Guest62872 | 02:00 | |
*** oz_akan_ has quit IRC | 02:00 | |
*** amitgandhi has quit IRC | 02:04 | |
*** Guest62872 has quit IRC | 03:09 | |
*** oz_akan__ has quit IRC | 03:13 | |
*** oz_akan_ has joined #openstack-marconi | 03:14 | |
*** amitgandhi has joined #openstack-marconi | 03:15 | |
*** tedross has joined #openstack-marconi | 03:16 | |
*** amitgandhi has quit IRC | 03:25 | |
*** amitgandhi has joined #openstack-marconi | 03:26 | |
*** amitgandhi has quit IRC | 03:30 | |
*** malini is now known as malini_afk | 03:37 | |
*** oz_akan_ has quit IRC | 03:44 | |
*** tedross has quit IRC | 04:15 | |
*** oz_akan_ has joined #openstack-marconi | 04:15 | |
*** oz_akan_ has quit IRC | 04:20 | |
*** amitgandhi has joined #openstack-marconi | 04:26 | |
*** amitgandhi has quit IRC | 04:30 | |
*** amitgandhi has joined #openstack-marconi | 04:36 | |
*** amitgandhi has quit IRC | 04:40 | |
*** oz_akan_ has joined #openstack-marconi | 05:16 | |
*** oz_akan_ has quit IRC | 05:21 | |
*** amitgandhi has joined #openstack-marconi | 05:27 | |
*** amitgandhi has joined #openstack-marconi | 05:27 | |
*** amitgandhi has quit IRC | 05:32 | |
*** oz_akan_ has joined #openstack-marconi | 06:17 | |
*** oz_akan_ has quit IRC | 06:21 | |
*** amitgandhi has joined #openstack-marconi | 06:28 | |
*** amitgandhi has quit IRC | 06:32 | |
*** amitgandhi has joined #openstack-marconi | 06:38 | |
*** amitgandhi has quit IRC | 06:42 | |
*** oz_akan_ has joined #openstack-marconi | 07:18 | |
*** oz_akan_ has quit IRC | 07:22 | |
*** amitgandhi has joined #openstack-marconi | 07:28 | |
*** flaper87|afk is now known as flaper87 | 07:44 | |
*** oz_akan_ has joined #openstack-marconi | 08:18 | |
*** flaper87 is now known as flaper87|afk | 08:22 | |
*** oz_akan_ has quit IRC | 08:23 | |
*** amitgandhi has joined #openstack-marconi | 08:29 | |
*** flaper87|afk is now known as flaper87 | 08:32 | |
*** amitgandhi has quit IRC | 08:33 | |
*** amitgandhi has joined #openstack-marconi | 08:39 | |
*** amitgandhi has quit IRC | 08:44 | |
*** yassine has joined #openstack-marconi | 09:13 | |
*** amitgandhi has joined #openstack-marconi | 09:29 | |
*** amitgandhi has joined #openstack-marconi | 09:30 | |
*** amitgandhi has quit IRC | 09:34 | |
*** fifieldt has quit IRC | 10:10 | |
*** amitgandhi has joined #openstack-marconi | 10:30 | |
*** amitgandhi has quit IRC | 10:35 | |
*** amitgandhi has joined #openstack-marconi | 10:40 | |
*** amitgandhi has quit IRC | 10:45 | |
*** malini_afk is now known as malini | 10:58 | |
*** flaper87 is now known as flaper87|afk | 11:24 | |
*** amitgandhi has joined #openstack-marconi | 11:30 | |
*** tedross has joined #openstack-marconi | 12:12 | |
*** nosnos has quit IRC | 12:27 | |
*** amitgandhi has joined #openstack-marconi | 12:32 | |
*** flaper87|afk is now known as flaper87 | 12:35 | |
*** amitgandhi has quit IRC | 12:36 | |
*** kgriffs_afk is now known as kgriffs | 12:39 | |
*** amitgandhi has joined #openstack-marconi | 12:42 | |
flaper87 | kgriffs: amitgandhi good morning guys! | 12:43 |
---|---|---|
*** amitgandhi has quit IRC | 12:46 | |
*** tedross has quit IRC | 12:50 | |
*** whenry has quit IRC | 12:54 | |
kgriffs | flaper87: good afternoon! | 12:55 |
*** malini is now known as malini_afk | 13:04 | |
*** oz_akan_ has joined #openstack-marconi | 13:04 | |
*** oz_akan_ has quit IRC | 13:05 | |
*** oz_akan_ has joined #openstack-marconi | 13:05 | |
*** mpanetta has joined #openstack-marconi | 13:10 | |
*** amitgandhi has joined #openstack-marconi | 13:23 | |
openstackgerrit | Kurt Griffiths proposed a change to openstack/marconi: chore: Pass cache into drivers https://review.openstack.org/54445 | 13:38 |
*** amitgandhi has quit IRC | 13:47 | |
*** amitgandhi has joined #openstack-marconi | 13:47 | |
flaper87 | so much silence in here! | 14:07 |
*** jergerber has joined #openstack-marconi | 14:09 | |
* kgriffs watches a tumbleweed roll by | 14:10 | |
oz_akan_ | malini_afk: there? | 14:10 |
*** whenry has joined #openstack-marconi | 14:11 | |
* flaper87 prepared some bamboo slides for the summit! | 14:14 | |
* ametts wonders how information written on pieces of bamboo will get into the projector. | 14:15 | |
*** jcru has joined #openstack-marconi | 14:15 | |
flaper87 | ametts: mmmh, that's a good question. Isn't there an adapter for that? | 14:18 |
flaper87 | :D | 14:18 |
*** malini_afk is now known as malini | 14:18 | |
kgriffs | flaper87: yep, it's called an overhead projector | 14:19 |
flaper87 | LOOOL | 14:19 |
ametts | http://www.bhphotovideo.com/c/product/841314-REG/Wacom_ACK40401_Bamboo_Tablet_Wireless_Accessory.html | 14:20 |
ametts | Wireless, even! | 14:20 |
malini | oz_akan_: ping | 14:20 |
flaper87 | man, I didn't know wacom has a tablet | 14:20 |
flaper87 | aaaaaaanyway! | 14:21 |
kgriffs | protip: don't sudo ulimit on a mac | 14:27 |
kgriffs | flaper87, ametts: I'll be working on my own slides a little later today | 14:28 |
flaper87 | kgriffs: I did some work this morning, I'm keeping everything in the etherpad | 14:28 |
flaper87 | ametts: ^ | 14:28 |
mpanetta | kgriffs: Why don't sudo ulimit on a mac? | 14:31 |
flaper87 | kgriffs: LOL @ ulimit! I think I did that once, not sure if it broke anything, though. | 14:31 |
*** kgriffs is now known as kgriffs_afk | 14:44 | |
*** alcabrera has joined #openstack-marconi | 14:49 | |
alcabrera | Good morning! | 14:49 |
flaper87 | alcabrera: GOOOOOD MORNING! | 14:50 |
flaper87 | alcabrera: question, What do you think about proposing marconi-redis-storage as part of OPW? | 14:50 |
flaper87 | I know we kinda talk about this but, I was thinking about it a bit more and it may make sense after all | 14:51 |
flaper87 | plus, it'd be cool to ship an in-memory storage along with marconi | 14:51 |
alcabrera | +1 | 14:52 |
alcabrera | I'm in favor of it, and I'd be happy to serve as mentor on whoever took on the project. :D | 14:52 |
alcabrera | flaper87: ^ | 14:52 |
flaper87 | alcabrera: awesome, thanks a lot! | 14:53 |
alcabrera | flaper87: How did PyMilano go yesterday? :) | 14:54 |
alcabrera | flaper87: regarding https://review.openstack.org/#/c/52160/9/marconi/queues/storage/mongodb/catalogue.py (insert vs. update) | 15:00 |
alcabrera | The docs are out of date. :P | 15:00 |
*** cpallares has joined #openstack-marconi | 15:00 | |
alcabrera | I did mean for an update-on-existing behavior. | 15:00 |
flaper87 | alcabrera: ok, then, I'm cool with it! | 15:06 |
flaper87 | alcabrera: what confused me is that there's an 'update' method! | 15:07 |
flaper87 | why aren't you re-using the insert one instead ? | 15:07 |
alcabrera | I should probably merge the two at some point. :/ | 15:07 |
alcabrera | Probably soon. | 15:07 |
alcabrera | :P | 15:07 |
alcabrera | update is leftover from when I didn't realize how this should connect to the transport layer (PUT style) | 15:08 |
alcabrera | Soooo.'.. | 15:08 |
alcabrera | Hmmm | 15:08 |
alcabrera | I should probably make an upsert method! | 15:08 |
flaper87 | alcabrera: oooooooooooooooooooooooooooooooooooke! :) | 15:08 |
alcabrera | lemme take care of that now. Meanwhile... | 15:08 |
alcabrera | :D | 15:08 |
alcabrera | :D | 15:08 |
flaper87 | alcabrera: also, maybe multi=False is not necessary in the update since there's a unique index on PRIMARY_KEY | 15:09 |
alcabrera | Could you review this other one: https://review.openstack.org/#/c/50998/ | 15:09 |
alcabrera | +1 | 15:09 |
alcabrera | flaper87: oh! Just realized something. Hmm.... | 15:11 |
alcabrera | I don't think I want to merge insert/update, since I want to raise a QueueNotMapped if the entry doesn't exist on a PATCH. | 15:11 |
alcabrera | hmmm... | 15:12 |
* alcabrera thinks and open a pymongo console | 15:12 | |
flaper87 | hence the `if not res['updatedExisting']` | 15:13 |
alcabrera | yeah, I think I might be able to use that. :D | 15:13 |
flaper87 | :D | 15:13 |
alcabrera | I think that's why I want to keep the two separate - upsert creates the entry anyway. | 15:14 |
alcabrera | I don't want that to happen for a PATCH. | 15:14 |
alcabrera | Sooooo | 15:14 |
alcabrera | I can reuse a common body for the impl. | 15:14 |
alcabrera | But I want the update to continue raising, and to have upsert=False. | 15:14 |
malini | zyuan: I forgot to mention y'day..But I have the tsung stats test ready | 15:24 |
zyuan | malini: thanks! how you use a patch? a github branch, or a gerrit review? | 15:25 |
zyuan | malini: review is at https://review.openstack.org/#/c/50969/ | 15:25 |
malini | zyuan: you need to verify the perf before merging , rt? | 15:25 |
zyuan | yes | 15:26 |
*** ayoung has quit IRC | 15:26 | |
malini | hmm..I have a simple standalone cloud server running marconi..Its nothing fancy & doesnt have a replicaset etc. WIll tht be good enuf for testing ur patch ? | 15:27 |
zyuan | i think that's enough | 15:27 |
*** whenry has quit IRC | 15:27 | |
malini | ok..I'll give it a try , with & without ur patch | 15:27 |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: add catalogue storage driver for queues https://review.openstack.org/52160 | 15:28 |
alcabrera | flaper87: all feedback addressed. ^^ | 15:28 |
flaper87 | alcabrera: awesome, thanks a lot! | 15:40 |
alcabrera | np, thank you! :( | 15:40 |
alcabrera | ... | 15:40 |
alcabrera | :) | 15:40 |
alcabrera | ^ | 15:40 |
flaper87 | alcabrera: LGTM ;) | 15:43 |
alcabrera | w00t | 15:43 |
alcabrera | cpallares: I found some time to review your 'exceptions -> errors' patch. I left my comments inline. Glad to see you were able to make it past Jenkins! :D | 15:53 |
*** vkmc has joined #openstack-marconi | 15:54 | |
*** vkmc has quit IRC | 15:54 | |
*** vkmc has joined #openstack-marconi | 15:54 | |
alcabrera | Time to continue working on sharding~ | 15:55 |
cpallares | alcabrera: thanks! | 15:56 |
cpallares | alcabrera: I thought since there's another module from pymongo called errors, there would be name conflicts, so there wouldn't? | 15:57 |
alcabrera | cpallares: hmm... | 15:58 |
alcabrera | If the import is done as import pymongo | 15:58 |
alcabrera | then you'd have to do 'pymongo.errors' to access that one. | 15:58 |
alcabrera | There shouldn't be a name collision in that case, as a result of that. | 15:58 |
alcabrera | So there'd be 'marconi.queues.storage' => 'errors' and 'pymongo' => 'pymongo.errors' | 15:59 |
cpallares | alcabrera: I get you. | 15:59 |
alcabrera | Of course, the unit tests could prove me completely wrong. They know better. ;) | 15:59 |
openstackgerrit | Cindy Pallares proposed a change to openstack/marconi: Renamed "exceptions" module to "errors" https://review.openstack.org/54141 | 16:18 |
cpallares | Okay this one should be okay! | 16:18 |
cpallares | ...I hope. | 16:19 |
* alcabrera checks it out | 16:20 | |
alcabrera | cpallares: for this file (https://review.openstack.org/#/c/54141/8/marconi/proxy/storage/mongodb/catalogue.py) | 16:20 |
alcabrera | was just using 'errors' causing a problem? | 16:20 |
cpallares | alcabreara: No, actually it wasn't. I thought I had looked over the files. I'll check them again. | 16:22 |
alcabrera | cpallares: I noticed you removed all the other instances. This one caught my eye while reviewing. :) | 16:22 |
alcabrera | instances of 'exceptions -> X_errors' | 16:22 |
malini | zyuan: I tried with & without the patch & dont see significant improvement in stats | 16:27 |
malini | http://198.61.239.147:8000/log/20131030-1620/report.html - with patch | 16:27 |
malini | http://198.61.239.147:8000/log/20131030-1624/report.html - without patch | 16:27 |
cpallares | alcabreara: Mmm... I get a pep8 error redefinition of unused 'errors' from line 28 | 16:32 |
cpallares | alcabrera: but it passes in py27 | 16:33 |
alcabrera | hmmmmmm | 16:35 |
alcabrera | ahhh | 16:36 |
alcabrera | yeah | 16:36 |
alcabrera | that makes sense! | 16:36 |
alcabrera | Cool | 16:36 |
alcabrera | cpallares: thanks for investigating that. :D | 16:36 |
malini | flaper87: ping | 16:36 |
alcabrera | cpallares: +2'd | 16:36 |
cpallares | alcabrera: yay :D | 16:37 |
*** aniuskad has joined #openstack-marconi | 16:37 | |
alcabrera | cpallares: congrats! Once flaper87 and/or kgriffs_afk gets around to reviewing it, it should be merged in shortly. :) | 16:46 |
flaper87 | back | 17:00 |
flaper87 | sorry, I was in a meeting | 17:00 |
alcabrera | flaper87: wb! | 17:01 |
*** reed has joined #openstack-marconi | 17:02 | |
*** ayoung_ has joined #openstack-marconi | 17:09 | |
*** kgriffs_afk is now known as kgriffs | 17:10 | |
*** yassine has quit IRC | 17:10 | |
zyuan | malini: did you tried interleaving posting and stats? | 17:10 |
kgriffs | alcabrera: how's your patch coming? I am working on caching but want to wait and base mine on yours | 17:13 |
openstackgerrit | A change was merged to openstack/marconi: feat: add catalogue storage driver for queues https://review.openstack.org/52160 | 17:13 |
kgriffs | i mean, I am not waiting to implement, just to submit | 17:14 |
alcabrera | kgriffs: I'm almost through with the implementation. I just finished porting... | 17:16 |
alcabrera | ... the weighted select algorithm from the proxy. | 17:16 |
kgriffs | kewl | 17:16 |
alcabrera | I also finished putting together a means to convert from a python dict -> oslo.config.cfg.CONF. | 17:16 |
alcabrera | What's left is to unit test this thing! :D | 17:17 |
kgriffs | rock on | 17:17 |
flaper87 | cpallares: +2 ;) Thanks a lot! great first contribution! | 17:17 |
alcabrera | flaper87, kgriffs: The last patch left blocking the sharding development in the review queue is: https://review.openstack.org/#/c/50998/ | 17:17 |
alcabrera | Thanks for all your help reviewing those! | 17:18 |
alcabrera | cpallares: w00t - keep making marconi awesome! :D | 17:18 |
flaper87 | alcabrera: since that's the last one, kgriffs and I will charge you a fee for the review! | 17:18 |
alcabrera | flaper87: $3.50 | 17:18 |
flaper87 | alcabrera: small one, just a couple of thousand dollars | 17:18 |
alcabrera | D: | 17:18 |
flaper87 | each | 17:18 |
alcabrera | cocosettes? | 17:19 |
alcabrera | Maybe? | 17:19 |
alcabrera | I could do those. ;P | 17:19 |
flaper87 | alcabrera: Man, I got those! :D | 17:19 |
alcabrera | lol | 17:19 |
flaper87 | fvollero: sent me some! | 17:19 |
flaper87 | alcabrera: btw, did you find them there? | 17:19 |
kgriffs | I prefer bitcoin. Harder for the NSA to track. | 17:19 |
alcabrera | fvollero: maaan, you broke my bargain chip. :P | 17:19 |
* kgriffs looks over shoulder | 17:19 | |
kgriffs | alcabrera: fwi, that last patchset was just git cherry-pick sillyness I guess. I hadn't thought I'd changed anything. | 17:20 |
kgriffs | flaper87: TBH I haven't been following your cache patch as closely as I would like to lately. How is it looking? | 17:21 |
alcabrera | kgriffs: weird connection errors solved? | 17:21 |
flaper87 | kgriffs: I addressed the last comments so, hopefully, people will look at it very soon! | 17:21 |
kgriffs | alcabrera: yes. OS X Mavericks was just being retarded | 17:22 |
flaper87 | kgriffs: no changes to the API, though | 17:22 |
kgriffs | had a really low ulimit | 17:22 |
kgriffs | flaper87: cool, gtk | 17:22 |
kgriffs | I still want to help write backends for it. Things have just been so crazy lately. :p | 17:22 |
flaper87 | I don't think anyone is going to review it before the smmit, TBH! | 17:23 |
kgriffs | heh. probably not. | 17:23 |
alcabrera | It'll be nice to double down on the oslo.cache patch after that. | 17:24 |
alcabrera | Though I remember seeing a session in the Summit schedule... | 17:24 |
alcabrera | Something about better oslo-incubator structuring. | 17:24 |
alcabrera | That sounded relevant to the future of oslo.cache | 17:24 |
fvollero | flaper87: some of? | 17:25 |
fvollero | alcabrera: whaaat ? :) | 17:25 |
flaper87 | fvollero: cocosette chamo, cocosette! | 17:25 |
*** notmyname has quit IRC | 17:25 | |
*** notmyname has joined #openstack-marconi | 17:26 | |
alcabrera | brb | 17:32 |
*** alcabrera is now known as alcabrera|afk | 17:32 | |
flaper87 | alcabrera|afk: you come back here, NOW! | 17:33 |
*** ayoung_ has quit IRC | 17:35 | |
fvollero | flaper87: che, eso es un problema, ya la que tenia terminaron :) | 17:43 |
*** aniuskad has quit IRC | 17:44 | |
fvollero | flaper87: some bug i can fix to get again in sync with marconi? | 17:44 |
*** whenry has joined #openstack-marconi | 17:45 | |
flaper87 | fvollero: erm, lesseeeeeeeeeeeeeeeee | 17:46 |
flaper87 | alcabrera|afk: btw, me saying lessee is your fault! | 17:46 |
flaper87 | :D | 17:46 |
flaper87 | fvollero: https://bugs.launchpad.net/marconi/+bug/1245987 | 17:48 |
flaper87 | mpanetta: ^ | 17:48 |
* fvollero checks | 17:49 | |
flaper87 | kgriffs: https://review.openstack.org/#/c/50638/ | 17:49 |
flaper87 | O.O did I just drop that in here? | 17:49 |
flaper87 | did I really mentioned kgriffs in that message ? | 17:49 |
flaper87 | mention* | 17:50 |
kgriffs | :D | 17:54 |
kgriffs | ah yes, we need that client for the summit! | 17:54 |
kgriffs | as soon as I get my slides done and caching for sharding, I'll go into review mode | 17:54 |
*** vkmc has quit IRC | 17:56 | |
openstackgerrit | Cindy Pallares proposed a change to openstack/marconi: Renamed "exceptions" module to "errors" https://review.openstack.org/54141 | 18:01 |
*** amitgandhi has quit IRC | 18:03 | |
flaper87 | kgriffs: I just asked for a review there, don't pretend it'll work after it's merged! | 18:04 |
* flaper87 hides | 18:04 | |
openstackgerrit | A change was merged to openstack/python-marconiclient: Implement queue's API methods https://review.openstack.org/50638 | 18:07 |
kgriffs | flaper87: LOL | 18:11 |
kgriffs | I will take a look at the other patches ASAP | 18:12 |
flaper87 | kgriffs: cool, thanks a LOT! | 18:12 |
kgriffs | btw, here is the inspiration for the t-shirt: https://en.wikipedia.org/wiki/File:Coherer_Rcvr.jpg | 18:17 |
openstackgerrit | Cindy Pallares proposed a change to openstack/marconi: Renamed "exceptions" module to "errors" https://review.openstack.org/54141 | 18:23 |
*** alcabrera|afk is now known as alcabrera | 18:23 | |
alcabrera | let's see what I missed~ | 18:23 |
mpanetta | flaper87: What ya need? :) | 18:24 |
alcabrera | lol | 18:25 |
kgriffs | alcabrera: I've got caching ready, just waiting on your patch | 18:25 |
alcabrera | flaper87: leseeeee is *very* effective in communicating deliberation and ACKs. :D | 18:25 |
alcabrera | kgriffs: awesome! | 18:25 |
alcabrera | I'll share a WIP. | 18:25 |
kgriffs | let's make this real today | 18:25 |
flaper87 | mpanetta: erm money? | 18:26 |
flaper87 | mpanetta: :P | 18:26 |
flaper87 | mpanetta: fvollero is taking a bug you created | 18:26 |
mpanetta | Ah | 18:26 |
flaper87 | he may need more info | 18:26 |
mpanetta | Hmm zyuan looked at that one yesterday | 18:26 |
flaper87 | yup | 18:26 |
mpanetta | Ok | 18:26 |
flaper87 | not sure if you guys decided something | 18:26 |
mpanetta | I can give him what I gave zyuan | 18:26 |
kgriffs | flaper87: can you review this one soon? https://review.openstack.org/#/c/50998/ | 18:26 |
mpanetta | It is a weird bug | 18:26 |
flaper87 | kgriffs: looking | 18:27 |
kgriffs | brb (meeting) | 18:27 |
kgriffs | flaper87: thanks man. Rackspace is really keen on getting sharding in ASAP | 18:27 |
kgriffs | (albeit with high quality) | 18:27 |
kgriffs | :D | 18:27 |
mpanetta | I am going to go get food. | 18:29 |
mpanetta | I will bbiab | 18:29 |
alcabrera | kgriffs: about to post a WIP - writing a commit message. | 18:31 |
alcabrera | The WIp has the core logic but is missing the unit tests. | 18:31 |
alcabrera | *WIP | 18:31 |
kgriffs | kk | 18:31 |
kgriffs | WIP...WIP it good! | 18:31 |
*** amitgandhi has joined #openstack-marconi | 18:32 | |
malini | zyuan: ping | 18:33 |
zyuan | malini: ? | 18:33 |
malini | can you join the other channel? | 18:33 |
zyuan | it'm there | 18:33 |
zyuan | i'm | 18:34 |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: connect sharding manager to control drivers (WIP) https://review.openstack.org/54605 | 18:35 |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: integrate shard storage with transport https://review.openstack.org/50998 | 18:35 |
alcabrera | kgriffs: There's that WIP I promised, with possibly a rebase on the shard storage patch. :P | 18:35 |
alcabrera | kgriffs: lol about WIP puns. :P | 18:38 |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(health): make health API storage-aware https://review.openstack.org/53457 | 18:38 |
flaper87 | alcabrera: I think you need to rebase: https://review.openstack.org/#/c/50998/ | 18:40 |
flaper87 | with latest cpallares patch | 18:41 |
alcabrera | flaper87: I'll do that now! :) | 18:41 |
flaper87 | alcabrera: the patch is being merged | 18:41 |
flaper87 | :P | 18:41 |
alcabrera | I may have... tripped it up with the WIP sharding patch above. | 18:41 |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: integrate shard storage with transport https://review.openstack.org/50998 | 18:42 |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: connect sharding manager to control drivers (WIP) https://review.openstack.org/54605 | 18:43 |
alcabrera | flaper87: done! | 18:43 |
alcabrera | :D | 18:43 |
flaper87 | alcabrera: mmh, you sure? it still says it depends on your previous patch | 18:44 |
flaper87 | cpallares' patch hasn't landed yet | 18:44 |
flaper87 | Zuul is stil 'tasting' it | 18:45 |
flaper87 | still | 18:45 |
alcabrera | hmmm | 18:45 |
alcabrera | weird | 18:45 |
alcabrera | flaper87: hmmmm - it *should* depend on the catalogue storage driver. I'm confused. :x | 18:46 |
flaper87 | alcabrera: I meant to say that your patch will conflict with cpallares changes | 18:48 |
flaper87 | s/queues:// | 18:48 |
alcabrera | ahh | 18:48 |
alcabrera | I see. | 18:48 |
openstackgerrit | A change was merged to openstack/marconi: Renamed "exceptions" module to "errors" https://review.openstack.org/54141 | 18:48 |
alcabrera | There we go. | 18:48 |
alcabrera | Okay, I'll rebase now. | 18:49 |
flaper87 | mmh actually, I was wrong but it would conflict anyway | 18:49 |
flaper87 | :D | 18:49 |
alcabrera | :) | 18:49 |
alcabrera | yup, super conflict | 18:49 |
alcabrera | Fixing~ | 18:49 |
flaper87 | she was working on 2 patches but the one that got merged is the exceptions one | 18:49 |
flaper87 | anyway, we both were confused and right at the same time | 18:49 |
flaper87 | what a strange combination | 18:49 |
alcabrera | cool - only 2 files in conflict | 18:50 |
alcabrera | not bad | 18:50 |
cpallares | flaper87: haha | 18:50 |
cpallares | yay my patch merged :D | 18:50 |
flaper87 | cpallares: CONGRATS! | 18:50 |
flaper87 | you're officially a Marconi committer | 18:51 |
flaper87 | ok, gtg now! | 18:51 |
cpallares | :D | 18:51 |
flaper87 | may be back later! | 18:51 |
flaper87 | take care guys! | 18:51 |
cpallares | haha bye! | 18:51 |
*** flaper87 is now known as flaper87|afk | 18:52 | |
alcabrera | flaper87|afk: take care! :) | 18:52 |
alcabrera | cpallares: also, congrats! Happy to have you working with us. :) | 18:54 |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: integrate shard storage with transport https://review.openstack.org/50998 | 18:55 |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: connect sharding manager to control drivers (WIP) https://review.openstack.org/54605 | 18:56 |
alcabrera | flaper87|afk, kgriffs: all rebasing is complete. enjoy the patches. ;) | 18:57 |
kgriffs | thanks! | 18:57 |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: WIP: feat(health): make health API storage-aware https://review.openstack.org/53457 | 19:01 |
openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: WIP: feat(health): make health API storage-aware https://review.openstack.org/53457 | 19:13 |
*** vkmc has joined #openstack-marconi | 19:15 | |
*** malini is now known as malini_afk | 19:34 | |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: connect sharding manager to control drivers (WIP) https://review.openstack.org/54605 | 19:35 |
alcabrera | I need to learn the WIP command on 'git review' :P | 19:36 |
zyuan | alcabrera: which? | 19:39 |
*** ayoung_ has joined #openstack-marconi | 19:40 | |
alcabrera | zyuan: 'git review -D' | 19:42 |
alcabrera | I forget to do that every time I'm submitting a WIP. | 19:42 |
zyuan | cool | 19:44 |
zyuan | draft.... | 19:44 |
alcabrera | kgriffs: getting closer to green - I've replaced the SqliteShardedTest from Messages with a TODO(...) and am now working into the MongodbSharded test. | 19:55 |
kgriffs | w00t | 19:55 |
kgriffs | I have my patches rebased on the WIP, so should be easy to finalize now | 19:55 |
alcabrera | awesome! | 19:56 |
*** vkmc has quit IRC | 20:03 | |
alcabrera | Heading out. I'll be back in a little bit. | 20:23 |
*** alcabrera has quit IRC | 20:23 | |
*** mpanetta has quit IRC | 20:24 | |
*** alcabrera has joined #openstack-marconi | 20:46 | |
*** kgriffs is now known as kgriffs_afk | 20:51 | |
*** kgriffs_afk is now known as kgriffs | 20:54 | |
alcabrera | Heh, I found a catch-22 in the sharded unit tests. | 21:04 |
alcabrera | Shards need to be registered before queues are created, but queues are created when setUp is called. :P | 21:04 |
*** jergerber has quit IRC | 21:25 | |
alcabrera | kgriffs: ping | 21:31 |
kgriffs | o/ | 21:33 |
alcabrera | Requesting assistance around this catch-22. I'm thinking of placing a conditional block in the 'MessageBaseTest' that creates a few shards before queues are created. | 21:34 |
alcabrera | Thoughts? | 21:34 |
alcabrera | The condition being - sharded mode is active. | 21:35 |
* kgriffs is looking | 21:36 | |
alcabrera | tests/unit/queues/marconi/transport/wsgi/test_messages | 21:37 |
kgriffs | alcabrera: sorry, juggling multiple thought streams | 21:44 |
alcabrera | I think I've got a way to work it. | 21:44 |
alcabrera | kgriffs: thanks for looking - I've got some green going. :) | 21:44 |
kgriffs | ok, cool | 21:44 |
kgriffs | I guess the crux of the issue is the base class doesn't know about it's child classes | 21:45 |
kgriffs | so it doesn't know whether sharding is enabled | 21:45 |
kgriffs | s/it's/its | 21:46 |
kgriffs | in the child class you could create the shards before calling super's setup | 21:47 |
alcabrera | the issue I ran into there is that neither self.app or self.bootstrap exist at that point. | 21:48 |
kgriffs | ah | 21:48 |
alcabrera | I resolved this by creating the shards after those two exist, in one of the parent classes, IFF sharding is enabled, with appropriate tearDown if sharding is enabled. | 21:49 |
kgriffs | ok, based on the config INI? | 21:53 |
alcabrera | yup | 21:55 |
alcabrera | I've parsed the conf at that point, so I need if sharding is enabled or not, and what the uri of the DB is. | 21:55 |
alcabrera | s/need/know | 21:55 |
alcabrera | kgriffs: ^ | 21:55 |
kgriffs | cool beans | 21:57 |
*** oz_akan_ has quit IRC | 22:12 | |
alcabrera | I'm out for the night. Dinner calls~ :) | 22:15 |
alcabrera | Night guys. | 22:15 |
*** alcabrera has quit IRC | 22:15 | |
*** amitgandhi has quit IRC | 22:22 | |
*** amitgandhi has joined #openstack-marconi | 22:23 | |
*** amitgandhi has quit IRC | 22:27 | |
*** jcru has quit IRC | 22:58 | |
*** cpallares has quit IRC | 23:03 | |
*** amitgandhi has joined #openstack-marconi | 23:23 | |
*** amitgandhi has quit IRC | 23:30 | |
openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: feat: connect sharding manager to control drivers (WIP) https://review.openstack.org/54605 | 23:38 |
*** pquerna has quit IRC | 23:57 | |
*** pquerna has joined #openstack-marconi | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!