| *** nosnos has joined #openstack-marconi | 01:00 | |
| *** malini_afk is now known as malini | 01:53 | |
| *** malini is now known as malini_afk | 01:55 | |
| *** malini_afk is now known as malini | 01:56 | |
| *** amitgandhi has joined #openstack-marconi | 02:41 | |
| *** amitgandhi has quit IRC | 02:50 | |
| *** malini is now known as malini_afk | 03:36 | |
| *** nosnos has quit IRC | 05:36 | |
| *** nosnos_ has joined #openstack-marconi | 05:36 | |
| *** fifieldt_ has joined #openstack-marconi | 05:53 | |
| *** dafter has quit IRC | 06:26 | |
| *** dafter has joined #openstack-marconi | 06:26 | |
| *** dafter has quit IRC | 06:30 | |
| *** notmyname has quit IRC | 06:58 | |
| *** flaper87|afk is now known as flaper87 | 06:58 | |
| *** notmyname has joined #openstack-marconi | 06:59 | |
| *** nosnos has joined #openstack-marconi | 07:02 | |
| *** nosnos_ has quit IRC | 07:02 | |
| *** nosnos has quit IRC | 07:19 | |
| *** nosnos has joined #openstack-marconi | 07:20 | |
| *** ykaplan has joined #openstack-marconi | 07:46 | |
| *** flaper87 is now known as flaper87|afk | 08:03 | |
| *** yassine has joined #openstack-marconi | 08:12 | |
| *** ykaplan has quit IRC | 08:21 | |
| *** fifieldt_ has quit IRC | 08:26 | |
| *** flaper87|afk is now known as flaper87 | 08:27 | |
| *** ykaplan has joined #openstack-marconi | 08:27 | |
| *** fifieldt has joined #openstack-marconi | 08:41 | |
| *** ykaplan has quit IRC | 08:59 | |
| openstackgerrit | Flavio Percoco proposed a change to openstack/marconi: Use oslo.config directly instead of common.config https://review.openstack.org/49550 | 09:01 |
|---|---|---|
| *** ykaplan has joined #openstack-marconi | 09:05 | |
| openstackgerrit | A change was merged to openstack/marconi: chore: Designate semi-private "friend" helper methods as such https://review.openstack.org/49812 | 09:07 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Implement HTTP Transport https://review.openstack.org/49788 | 09:13 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Make the request object API aware https://review.openstack.org/49787 | 09:13 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/python-marconiclient: Split get_transport into 2 different functions https://review.openstack.org/49786 | 09:13 |
| *** reed has joined #openstack-marconi | 09:15 | |
| *** flaper87 is now known as flaper87|afk | 10:31 | |
| *** ykaplan has quit IRC | 11:13 | |
| *** ykaplan has joined #openstack-marconi | 11:28 | |
| *** flaper87|afk is now known as flaper87 | 11:32 | |
| *** tedross has joined #openstack-marconi | 11:38 | |
| *** fvollero|gone is now known as fvollero | 12:26 | |
| *** flaper87 is now known as flaper87|afk | 12:30 | |
| *** flaper87|afk is now known as flaper87 | 12:36 | |
| *** flaper87 is now known as flaper87|afk | 12:43 | |
| *** nosnos has quit IRC | 12:47 | |
| *** rustlebee is now known as russellb | 12:54 | |
| *** mpanetta has joined #openstack-marconi | 12:54 | |
| *** flaper87|afk is now known as flaper87 | 12:57 | |
| *** fifieldt has quit IRC | 13:06 | |
| *** oz_akan_ has joined #openstack-marconi | 13:08 | |
| *** alcabrera has joined #openstack-marconi | 13:16 | |
| *** amitgandhi has joined #openstack-marconi | 13:16 | |
| alcabrera | Good morning! | 13:19 |
| flaper87 | alcabrera: HEYYYY!!! | 13:20 |
| flaper87 | good morning | 13:20 |
| flaper87 | hope you had an amazing w/e | 13:20 |
| alcabrera | I was pretty awesome, flaper87. :D | 13:21 |
| alcabrera | Spent a lot of time with my wife and house mate playing Terraria 1.2. | 13:21 |
| alcabrera | *It | 13:22 |
| flaper87 | alcabrera: hehehe, cool!!! | 13:24 |
| alcabrera | I noticed you made several updates to rust-http. ;) | 13:26 |
| flaper87 | alcabrera: hahaha, yeah!! :D | 13:34 |
| flaper87 | alcabrera: didn't know you were following it | 13:34 |
| flaper87 | :P | 13:34 |
| flaper87 | I'm also struggling with the implementation of Select traits for the Timer | 13:34 |
| flaper87 | basically, I hack on other projects while rust compiles :P | 13:35 |
| flaper87 | and tests run | 13:35 |
| *** ykaplan has quit IRC | 13:36 | |
| *** malini_afk is now known as malini | 13:38 | |
| alcabrera | flaper87: reminds me of my c++ days. "Oh, you're compiling?" /me goes off to read tech articles | 13:38 |
| flaper87 | :P | 13:40 |
| flaper87 | yeah, basically that but with code | 13:40 |
| flaper87 | :D | 13:40 |
| alcabrera | :) | 13:41 |
| alcabrera | I took a moment to clean up marconi-redis Sunday morning. I got rid of *a lot* of unnecessary cruft, so it's just the queues-storage impl. and the test stub. | 13:41 |
| alcabrera | I've also added marconi as a req using the -f <URL#egg> style. | 13:41 |
| flaper87 | alcabrera: AWESOME, so, you could basically do: pip install marconi-redis-backend | 13:43 |
| flaper87 | and that will install marconi as well, then tweak the config and then: $ marconi-server | 13:43 |
| flaper87 | alcabrera: btw, I'd like to get the config patch merged ASAP | 13:45 |
| flaper87 | I'm afraid that patch will conflict a lot | 13:45 |
| flaper87 | with new patches | 13:46 |
| alcabrera | I'm looking into it. :) | 13:46 |
| flaper87 | alcabrera: AWESOME! | 13:47 |
| flaper87 | thanks a lot | 13:47 |
| alcabrera | I'm still 90% zombie this morning, haha. | 13:47 |
| flaper87 | ahahahha | 13:47 |
| flaper87 | need a coffee + nutella + 1kg of sugar | 13:47 |
| alcabrera | flaper87: "Use oslo.config directly instead of common.config"? | 13:47 |
| flaper87 | and add a redbull | 13:47 |
| flaper87 | alcabrera: yeah | 13:47 |
| flaper87 | that one | 13:47 |
| alcabrera | nooooo, that would kill me. :P | 13:47 |
| alcabrera | I've been avoiding sugars and starches lately - makes me feel more energized. :D | 13:48 |
| * alcabrera reviews | 13:49 | |
| flaper87 | alcabrera: LOL, sorry, I'll take sugars for ya then! | 13:50 |
| flaper87 | :S | 13:50 |
| flaper87 | :D | 13:51 |
| *** ykaplan has joined #openstack-marconi | 13:51 | |
| alcabrera | lol go ahead. :) | 13:52 |
| * alcabrera is reminded of cocosettes | 13:52 | |
| alcabrera | Which in turn reminds me of... | 13:52 |
| alcabrera | fvollero: Good morning! | 13:52 |
| alcabrera | flaper87: reviewed - +2'd | 13:55 |
| flaper87 | alcabrera: thank you sir, I now need kgriffs_afk bless | 13:56 |
| alcabrera | marconi/marconi-{queues, proxy}.conf and lots of oslo.config usage examples - lgtm. | 13:56 |
| * flaper87 is having SO much fun with the client | 13:56 | |
| flaper87 | it's nice to see how things start fitting together | 13:57 |
| flaper87 | alcabrera: next step is to rename marconi-server entry_point into marconi-queues | 13:57 |
| flaper87 | so we can get rid of that prog='marconi-queues' keyword | 13:57 |
| flaper87 | then, I'll get rid of the global instance | 13:57 |
| *** jcru has joined #openstack-marconi | 13:59 | |
| *** dafter has joined #openstack-marconi | 14:01 | |
| *** flaper87 is now known as flaper87|afk | 14:05 | |
| fvollero | alcabrera: Morning to you :) | 14:07 |
| *** dafter has quit IRC | 14:15 | |
| *** ayoung has joined #openstack-marconi | 14:18 | |
| *** kgriffs_afk is now known as kgriffs | 14:32 | |
| kgriffs | good afternoon/morning | 14:33 |
| kgriffs | o/ | 14:34 |
| alcabrera | kgriffs: o/ | 14:34 |
| kgriffs | I have a feeling today is going to be a busy day | 14:34 |
| alcabrera | very much so. | 14:34 |
| kgriffs | need some eyes on this | 14:41 |
| kgriffs | https://review.openstack.org/#/c/49378/6 | 14:41 |
| kgriffs | last breaking change | 14:41 |
| malini | kgriffs: looks like that patch cud use some functional tests | 14:43 |
| malini | want me to add one? | 14:43 |
| kgriffs | sure thing | 14:43 |
| kgriffs | i want to get this done today so we can lock down the API (finally) | 14:43 |
| zyuan | malini: you only need to add the testing with wrong client_id | 14:44 |
| zyuan | malini: because your functional tests starts with UUID, which works out of box | 14:44 |
| malini | yeap..I'll add a test that will use client-id = 1234 & expect a 400 back | 14:44 |
| *** ametts has joined #openstack-marconi | 14:44 | |
| *** alcabrera is now known as alcabrera|afk | 14:45 | |
| kgriffs | ametts: could you help review? https://review.openstack.org/#/c/49378/6 | 14:47 |
| ametts | ok | 14:49 |
| *** reed has quit IRC | 14:51 | |
| kgriffs | thanks! | 14:52 |
| *** flaper87|afk is now known as flaper87 | 14:58 | |
| flaper87 | MAAAAAAAAAAAAAAAAAAAAAAAAAAAAN, I'm alive | 14:58 |
| flaper87 | T_T | 14:58 |
| flaper87 | I got blocked out my VPN for a while | 14:58 |
| flaper87 | I had to take panic attack pills | 14:58 |
| flaper87 | and stuff | 14:58 |
| flaper87 | phew | 14:58 |
| flaper87 | so good to be on-line again | 14:58 |
| flaper87 | kgriffs: just to make that feeling true, could you help me getting https://review.openstack.org/#/c/49550/ in ? | 14:59 |
| flaper87 | ping world ? | 15:02 |
| * ametts hears everyone sing "We are the world..." in response to flaper87's ping | 15:10 | |
| flaper87 | ametts: LOOOL | 15:12 |
| kgriffs | flaper87: sure | 15:15 |
| flaper87 | kgriffs: I'm afraid that patch is conflict-prone | 15:15 |
| flaper87 | so, I'd like to see it landing asap | 15:16 |
| *** alcabrera|afk has quit IRC | 15:21 | |
| *** briancline has quit IRC | 15:23 | |
| zyuan | flaper87: can we reach it after done proxy? we are deploying. | 15:24 |
| *** alcabrera has joined #openstack-marconi | 15:25 | |
| flaper87 | zyuan: that patch shouldn't break existing patches - not 100% sure - I'm more concern about new patches than existing ones. | 15:26 |
| *** briancline has joined #openstack-marconi | 15:26 | |
| flaper87 | hope that makes sense | 15:26 |
| zyuan | flaper87: i wish it do not break existing conf files. we are deploying, you know... | 15:27 |
| flaper87 | zyuan: oooh gotcha. It doesn't, it uses the same config files and options as before | 15:28 |
| flaper87 | marconi-proxy.conf and marconi-queues.conf | 15:28 |
| flaper87 | no changes to the configuration params either | 15:28 |
| ametts | zyuan: In https://review.openstack.org/#/c/49378/6 I see changes to transport and sqlite driver. No changes are needed to mongo driver? Just making sure.... | 15:33 |
| zyuan | ametts: mongo works out-of-box. it recognize UUID | 15:33 |
| ametts | Ok - thx. | 15:33 |
| flaper87 | meeting in 10mins | 15:48 |
| flaper87 | kgriffs: zyuan alcabrera malini megan_w ametts amitgandhi ^ | 15:48 |
| kgriffs | yep | 15:52 |
| kgriffs | I totally forgot to send out the email until just now | 15:52 |
| * kgriffs ducks | 15:52 | |
| fvollero | Hola fellas | 15:56 |
| fvollero | flaper87: marconi meeting ? can i join as well ? | 15:56 |
| kgriffs | everyone's welcome! | 15:56 |
| kgriffs | #openstack-meeting-alt | 15:56 |
| * fvollero hug kgriffs | 15:56 | |
| flaper87 | fvollero: no, get the fuck out of here | 15:57 |
| * flaper87 hides | 15:57 | |
| flaper87 | fvollero: you're always welcome, d00d | 15:57 |
| * kgriffs dispatches sniper | 15:57 | |
| fvollero | flaper87: :P | 15:57 |
| *** yassine has quit IRC | 15:57 | |
| flaper87 | kgriffs: thing is that fvollero has something I want, something I wish I had here, something that comes from my land!!!! | 15:57 |
| flaper87 | and I'm hating him so bad because of that | 15:58 |
| flaper87 | :P | 15:58 |
| kgriffs | wow | 15:58 |
| fvollero | fellas, i'm working on the elasticsearch storage backend and a problem just pop out, how to garantee the FIFO on this storage, suggestion ? | 15:58 |
| fvollero | flaper87: Fuck man, i'll send it through Ceska Posta! | 15:58 |
| kgriffs | mtg | 16:02 |
| kgriffs | #openstack-meeting-alt | 16:02 |
| kgriffs | see you there! | 16:02 |
| *** tedross has quit IRC | 16:04 | |
| * alcabrera made it back from a deep dive debug session | 16:05 | |
| amitgandhi | did you find any treasures? | 16:06 |
| amitgandhi | oic =P | 16:07 |
| alcabrera | amitgandhi: yeah. | 16:07 |
| alcabrera | nginx doesn't accept headers containing '_' by default. | 16:07 |
| amitgandhi | strange | 16:07 |
| alcabrera | so... two discoveries. | 16:07 |
| alcabrera | 1) That^^ | 16:07 |
| alcabrera | 2) There's a bug in the proxy. | 16:07 |
| *** flaper87 is now known as flaper87|afk | 16:07 | |
| alcabrera | It doesn't cannonicalize headers before sending them to marconi-queues. | 16:08 |
| alcabrera | I have a patch in the works. | 16:08 |
| amitgandhi | ok | 16:08 |
| amitgandhi | thats where the missing projectid issue came into play? | 16:08 |
| amitgandhi | or clientid issue | 16:08 |
| *** flaper87|afk is now known as flaper87 | 16:09 | |
| alcabrera | both | 16:10 |
| alcabrera | flaper87: wb! | 16:10 |
| alcabrera | amitgandhi: ^ | 16:10 |
| flaper87 | ping ? | 16:10 |
| flaper87 | fvollero: now we're talking :D | 16:10 |
| flaper87 | fvollero: re ElasticSearch, there are no auto-increment there | 16:10 |
| *** jarret has joined #openstack-marconi | 16:10 | |
| flaper87 | fvollero: and the id generated is just a hash | 16:10 |
| flaper87 | fvollero: there's a trick you could use that basically increments the _version of the document | 16:10 |
| flaper87 | but I'm not very happy with the way that trick works | 16:10 |
| fvollero | flaper87: Uhm me neither | 16:11 |
| flaper87 | fvollero: btw, something really cool about ES is that it has a built-in ttl support per document | 16:11 |
| fvollero | flaper87: exactly | 16:11 |
| flaper87 | fvollero: I think you can take advantage of the built-in timestamp property | 16:11 |
| flaper87 | of the document | 16:11 |
| flaper87 | (for FIFO, I mean) | 16:11 |
| fvollero | flaper87: i was thinking about this as well, so that instead to set the ttl value and evict manually. | 16:11 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: bug: proxy headers aren't forwarded properly https://review.openstack.org/50129 | 16:12 |
| fvollero | flaper87: yeah, I thought about it, but later we need to do a query to the recent elements based on timestamp | 16:12 |
| alcabrera | flaper87, kgriffs: bug fix, tiny review. ^^ :) | 16:13 |
| kgriffs | kk | 16:15 |
| openstackgerrit | A change was merged to openstack/python-marconiclient: Create v1 package and move messages there https://review.openstack.org/48664 | 16:16 |
| flaper87 | fvollero: yeah, but that should be harmless, AFAIk, you can sort on that field | 16:16 |
| *** tedross has joined #openstack-marconi | 16:17 | |
| *** ykaplan has quit IRC | 16:34 | |
| oz_akan_ | alcabrera: uwsgi --fastrouter 127.0.0.1:3017 --fastrouter-use-code-string 0:mapper.py:get | 16:48 |
| oz_akan_ | uwsgi supports a py to decide where a request should be routed. | 16:49 |
| oz_akan_ | and it accepts a parameter | 16:49 |
| fvollero | flaper87: ok, going in that direction | 16:49 |
| oz_akan_ | http://uwsgi-docs.readthedocs.org/en/latest/Fastrouter.html | 16:50 |
| oz_akan_ | alcabrera: ^^ | 16:50 |
| alcabrera | oz_akan_: I remembered something about that, but it was too limiting for the general case. | 16:50 |
| alcabrera | oz_akan_: Not everyone will deploy a marconi-proxy using uwsgi. | 16:50 |
| *** acabrera has joined #openstack-marconi | 16:51 | |
| flaper87 | fvollero: double check the sort on timestamp think | 16:51 |
| flaper87 | I'm not 100000000% sure | 16:51 |
| oz_akan_ | alcabrera: not everything has to be modular :) | 16:52 |
| oz_akan_ | for sure I see our implementation of proxy is more capable | 16:53 |
| *** alcabrera has quit IRC | 16:54 | |
| *** acabrera is now known as alcabrera | 16:55 | |
| amitgandhi | alcabrera needs some reviews : https://review.openstack.org/50129 : kgriffs, zyuan, flaper87 | 17:05 |
| kgriffs | https://wiki.openstack.org/wiki/Marconi/Incubation/Graduation#To_Do | 17:05 |
| kgriffs | Updated | 17:06 |
| * flaper87 clicks on all those links | 17:06 | |
| flaper87 | I'll check those after dinner! | 17:06 |
| flaper87 | brb | 17:06 |
| *** tedross has quit IRC | 17:07 | |
| ametts | Did alcabrera really give himself a -1 on that patch?! | 17:08 |
| fvollero | flaper87: http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/mapping-timestamp-field.html | 17:08 |
| flaper87 | ametts: hahaha | 17:09 |
| flaper87 | ametts: I've -2 mines | 17:09 |
| alcabrera | lol | 17:09 |
| flaper87 | :P | 17:09 |
| ametts | Ah. He made a typo. Now I just look stupid for giving him a +1. | 17:09 |
| alcabrera | ametts: yeah, sometimes I catch issues on my own patches after stepping away. | 17:09 |
| flaper87 | fvollero: there you go | 17:09 |
| flaper87 | and it's not_analyzed | 17:09 |
| alcabrera | After working on the proxy, I've learned to do little things to make reviews easier for everyone. :D | 17:09 |
| flaper87 | btw, remeber to make all the fields not_analyzed | 17:10 |
| flaper87 | you don't need that for marconi | 17:10 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: bug: proxy headers aren't forwarded properly https://review.openstack.org/50129 | 17:10 |
| alcabrera | flaper87, kgriffs: fixed ^^ | 17:10 |
| alcabrera | ametts: thanks for the review. :) | 17:11 |
| ametts | +1'd again. Although I think you should lose points for inventing the world "canonicalize".... :) | 17:12 |
| ametts | s/world/word/ | 17:12 |
| alcabrera | ametts: lol, fair enough. I've seen it around, but it's not acknowledged by any dictionary. :P | 17:13 |
| *** tvb has joined #openstack-marconi | 17:14 | |
| *** tvb has quit IRC | 17:14 | |
| *** tvb has joined #openstack-marconi | 17:14 | |
| *** tvb is now known as dafter | 17:15 | |
| *** flaper87 is now known as flaper87|afk | 17:19 | |
| kgriffs | alcabrera: didn't we add a .headers to falcon that does that for you? | 17:21 |
| openstackgerrit | Alejandro Cabrera proposed a change to openstack/marconi: bug: proxy headers aren't forwarded properly https://review.openstack.org/50129 | 17:23 |
| *** tedross has joined #openstack-marconi | 17:23 | |
| kgriffs | actually, that would have been in 0.1.7 | 17:23 |
| kgriffs | did that every make it into global reqs? | 17:23 |
| alcabrera | kgriffs: not yet. :/ | 17:29 |
| alcabrera | I was just putting together a patch for openstack/requirements | 17:30 |
| alcabrera | to bump falcon up a version | 17:30 |
| alcabrera | kgriffs: zyuan just told me about ,headers, too. I've added a TODO on this patch to address that asap. | 17:30 |
| alcabrera | kgriffs, zyuan: https://review.openstack.org/50140 | 17:32 |
| alcabrera | Let's see if I can get that in now, since the Havana code freeze is over. | 17:32 |
| kgriffs | ok | 17:32 |
| alcabrera | If I can, I'll update the bug fix patch accordingly. | 17:33 |
| kgriffs | let's allow this bug fix patch to land for now | 17:33 |
| kgriffs | just make a note to update later | 17:33 |
| alcabrera | ah, alright. | 17:33 |
| kgriffs | btw, yours is a little faster since it uses list comprehension, not a generator | 17:33 |
| kgriffs | I am fixing that in falcon as we speak. :D | 17:33 |
| alcabrera | kgriffs: https://bugs.launchpad.net/marconi/+bug/1236484 | 17:34 |
| alcabrera | Sweet. :) | 17:34 |
| kgriffs | thanks! | 17:35 |
| fvollero | uhmmm | 17:41 |
| fvollero | how marconi 'assign' the ttl to the messages ? | 17:41 |
| *** dafter has quit IRC | 17:42 | |
| alcabrera | fvollero: When posting messages, the user specifies the TTL to use. Does that help? | 17:42 |
| *** dafter has joined #openstack-marconi | 17:42 | |
| *** dafter has quit IRC | 17:42 | |
| *** dafter has joined #openstack-marconi | 17:42 | |
| fvollero | alcabrera: nop :) | 17:42 |
| fvollero | alcabrera: i'm wondering in which format: day,seconds, ms, minutes,weeks ? | 17:43 |
| alcabrera | ooohh | 17:43 |
| alcabrera | seconds | 17:43 |
| fvollero | alcabrera: brilliant. | 17:43 |
| fvollero | alcabrera: it's taking shape the elastic search storage engine :) | 17:43 |
| alcabrera | fvollero: awesome! :D | 17:43 |
| alcabrera | make it a real thing. | 17:44 |
| kgriffs | flaper87|afk - https://review.openstack.org/#/c/50129/ | 17:44 |
| *** dafter has quit IRC | 17:46 | |
| kgriffs | zyuan: https://review.openstack.org/#/c/49378/ | 17:46 |
| kgriffs | one tiny change | 17:47 |
| *** dafter has joined #openstack-marconi | 17:48 | |
| *** dafter has quit IRC | 17:48 | |
| *** dafter has joined #openstack-marconi | 17:48 | |
| *** tvb|afk has joined #openstack-marconi | 17:49 | |
| *** tvb|afk has quit IRC | 17:49 | |
| *** tvb|afk has joined #openstack-marconi | 17:49 | |
| *** dafter has quit IRC | 17:53 | |
| *** tvb|afk has quit IRC | 17:53 | |
| zyuan | kgriffs: i see. wsgi/utils has no function directly talks to falcon objects yet. ok? | 17:54 |
| zyuan | i'm fine with that. | 17:54 |
| kgriffs | that's fine | 17:55 |
| zyuan | ok | 17:55 |
| *** dafter has joined #openstack-marconi | 17:55 | |
| kgriffs | You can pretty much cut-paste it over there | 17:55 |
| kgriffs | alcabrera: Blacklisting partition hosts that timeout? Does request raise an exception? | 17:57 |
| kgriffs | on a socket timeout? | 17:58 |
| alcabrera | kgriffs: No blacklisting yet. | 17:58 |
| alcabrera | kgriffs: also, requests will raise an exception if the socket times out. | 17:59 |
| kgriffs | ok, is there a bp somewhere for that? | 17:59 |
| openstackgerrit | A change was merged to openstack/marconi: bug: proxy headers aren't forwarded properly https://review.openstack.org/50129 | 17:59 |
| kgriffs | and are you handling the timeout exception? | 17:59 |
| alcabrera | kgriffs: there are no bug reports or blueprints for either one, and I'm handling neither. | 17:59 |
| kgriffs | oh oh | 17:59 |
| *** tvb|afk has joined #openstack-marconi | 17:59 | |
| alcabrera | yup | 17:59 |
| kgriffs | I'd say, add a bp for blacklisting (temporary) on timeout to queues | 17:59 |
| alcabrera | will do | 18:00 |
| kgriffs | and then ASAP add a try..except around those forwarded requests | 18:00 |
| kgriffs | (can return 500 to the client, I guess) | 18:00 |
| kgriffs | or... | 18:00 |
| alcabrera | matches my thoughts - HTTP 500 | 18:00 |
| kgriffs | just try another host | 18:00 |
| alcabrera | that seems reasonable, too | 18:01 |
| kgriffs | makes us look better if we "just work" ;D | 18:01 |
| alcabrera | I'll write up that bp, and then take a look at what I can make happen asap. :) | 18:01 |
| kgriffs | cool, thanks! | 18:01 |
| *** dafter has quit IRC | 18:01 | |
| kgriffs | did you see your patch got merged? | 18:02 |
| openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(api): Client-ID is now a real UUID https://review.openstack.org/49378 | 18:02 |
| openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(api): give validation resp a different title https://review.openstack.org/49837 | 18:02 |
| kgriffs | I made an executive decision | 18:02 |
| *** kgriffs is now known as kgriffs_afk | 18:03 | |
| alcabrera | kgriffs_afk: thanks! | 18:04 |
| alcabrera | kgriffs_afk: https://blueprints.launchpad.net/marconi/+spec/proxy-blacklist-nonresponsive-hosts | 18:05 |
| *** dafter has joined #openstack-marconi | 18:09 | |
| *** tvb|afk has quit IRC | 18:12 | |
| *** vkmc has joined #openstack-marconi | 18:17 | |
| *** vkmc has quit IRC | 18:17 | |
| *** vkmc has joined #openstack-marconi | 18:17 | |
| openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(api): Client-ID is now a real UUID https://review.openstack.org/49378 | 18:18 |
| zyuan | now fixed ^^ | 18:18 |
| amitgandhi | zyuan, kgriffs_afk: meeting | 18:31 |
| *** kgriffs_afk is now known as kgriffs | 18:33 | |
| openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(api): Client-ID as a real UUID https://review.openstack.org/49378 | 18:36 |
| zyuan | kgriffs: alcabrera ^^ | 18:41 |
| *** flaper87|afk is now known as flaper87 | 18:46 | |
| * flaper87 back | 18:49 | |
| flaper87 | I'll review the pending patches now | 18:49 |
| flaper87 | sorry for the delay guys | 18:49 |
| alcabrera | flaper87: no worries, and thanks! | 18:51 |
| *** zzs has joined #openstack-marconi | 18:52 | |
| flaper87 | zyuan: +2'd both | 18:58 |
| flaper87 | kgriffs: can I get your bless here? https://review.openstack.org/#/c/49550/ | 19:00 |
| openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(api): give validation resp a different title https://review.openstack.org/49837 | 19:01 |
| zyuan | flaper87: thanks | 19:01 |
| flaper87 | zyuan: I think you just broke the dependency chain with that last commit | 19:02 |
| flaper87 | :/ | 19:02 |
| *** oz_akan_ has quit IRC | 19:04 | |
| flaper87 | the last patch won't get merged unless the outdated commit it's depending on gets merged | 19:04 |
| kgriffs | flaper87: sure, I'll take a look at the oslo patch | 19:04 |
| kgriffs | oslo.config, I mean | 19:04 |
| flaper87 | kgriffs: thank you :D | 19:05 |
| zyuan | flaper87: yes. but i assume jekins can try merge... anyway, let me rebase. | 19:05 |
| openstackgerrit | Zhihao Yuan proposed a change to openstack/marconi: feat(api): Client-ID as a real UUID https://review.openstack.org/49378 | 19:06 |
| flaper87 | zyuan: it wont :( | 19:06 |
| flaper87 | if it depends on a patch, it doesn't even bother to try | 19:06 |
| flaper87 | zyuan: I'll +2 both again | 19:07 |
| flaper87 | thanks | 19:07 |
| flaper87 | ah no need for the last one | 19:07 |
| alcabrera | I'll be back later guys. :) | 19:08 |
| *** alcabrera has quit IRC | 19:08 | |
| kgriffs | zyuan: I think this is OK, but later I would like errors to be more specific, to help out the client developer | 19:10 |
| kgriffs | https://review.openstack.org/#/c/49837/4/marconi/queues/transport/wsgi/exceptions.py | 19:10 |
| kgriffs | I mean, it should say "Invalid header value" and then in the description state *which* header is invalid | 19:10 |
| kgriffs | or "Invalid query parameter" | 19:10 |
| kgriffs | etc. | 19:10 |
| kgriffs | I filed a bug just so we don't forget to revisit | 19:11 |
| kgriffs | https://bugs.launchpad.net/marconi/+bug/1236540 | 19:11 |
| zyuan | kgriffs: input validation is 1 layer, and the layer is higher than low level things like header or body | 19:11 |
| malini | did we have something change around queues marker recently? | 19:11 |
| zyuan | that's my understanding... | 19:11 |
| kgriffs | malini: I can't think of anything specific. | 19:12 |
| zyuan | kgriffs: the error message body raise from input validation has those information | 19:12 |
| kgriffs | or is this going through the proxy? | 19:12 |
| kgriffs | zyuan: gtk. I just want to take some time later to find everywhere we raise a 400 and make sure the response is consistent | 19:14 |
| malini | kgriffs: this is not thru proxy..I am doing a list queues with GET /v1/queues?marker=ZZZ, it is returning me queues with names starting with d etc. ( marker is the same as queue name, rt? ) | 19:15 |
| kgriffs | yeah | 19:15 |
| kgriffs | is the same | 19:15 |
| kgriffs | sounds like a bug to me | 19:16 |
| kgriffs | you would expect 204, right? | 19:16 |
| malini | kgriffs: yeap..This is my pdb o/p http://paste.openstack.org/show/48038/ | 19:17 |
| openstackgerrit | A change was merged to openstack/marconi: feat(api): give validation resp a different title https://review.openstack.org/49837 | 19:17 |
| malini | kgriffs: I'll open a new bug | 19:18 |
| *** dafter has quit IRC | 19:18 | |
| kgriffs | ok | 19:18 |
| kgriffs | I will work on it | 19:18 |
| openstackgerrit | A change was merged to openstack/marconi: feat(api): Client-ID as a real UUID https://review.openstack.org/49378 | 19:20 |
| zyuan | kgriffs: i think we discussed that | 19:20 |
| zyuan | it's not a bug... | 19:20 |
| zyuan | queue marker is explicit and may not exist | 19:21 |
| zyuan | the listing behaves like listing with prefix but it's not the purpose and can not be avoided | 19:21 |
| zyuan | the purpose is that if you delete a queue from the middle, the listing still works. | 19:22 |
| zyuan | malini: i hope you are not too surprised ^^ | 19:22 |
| malini | zyuan: yeap we discussed this & the decision was https://wiki.openstack.org/wiki/Marconi/specs/api/v1/responsecodes#List_Queues | 19:24 |
| malini | 'A marker always "exists" in the sense that we can always perform a range comparison with it. In other words, if you pass 'g' for the marker, Marconi will return all queue's whose names sort after 'g', lexicographically. If you pass a marker that sorts after all existing queues, you will receive "204 No Content" in response.' | 19:24 |
| malini | I was expecting a 204 for the marker=ZZZZ, but ended up getting queues with names starting d etc. | 19:25 |
| kgriffs | hah | 19:27 |
| kgriffs | nice catch malini | 19:27 |
| kgriffs | actually, something *did* change recently there | 19:28 |
| kgriffs | looks like a regression caused by joining the "project" and "queue" fields | 19:28 |
| kgriffs | (in the DB) | 19:28 |
| kgriffs | I have a repro | 19:28 |
| malini | cool..one of our functional tests was failing | 19:28 |
| kgriffs | nice | 19:28 |
| malini | test_get_queue_malformed_marker, if u want a repro | 19:29 |
| kgriffs | I added a test for that to the unit tests as well, to make sure it doesn't sneak by my again. :p | 19:29 |
| malini | gtg now..will chk back later | 19:29 |
| kgriffs | ttfn | 19:29 |
| *** malini is now known as malini_afk | 19:30 | |
| *** dafter has joined #openstack-marconi | 19:35 | |
| *** dafter has quit IRC | 19:35 | |
| *** dafter has joined #openstack-marconi | 19:35 | |
| *** vkmc_ has joined #openstack-marconi | 20:00 | |
| *** vkmc_ has quit IRC | 20:13 | |
| *** vkmc has quit IRC | 20:14 | |
| *** vkmc has joined #openstack-marconi | 20:15 | |
| *** vkmc has quit IRC | 20:15 | |
| *** vkmc has joined #openstack-marconi | 20:15 | |
| *** oz_akan_ has joined #openstack-marconi | 20:43 | |
| *** oz_akan_ has joined #openstack-marconi | 20:44 | |
| *** flaper87 has quit IRC | 20:48 | |
| *** flaper87 has joined #openstack-marconi | 20:52 | |
| *** flaper87 is now known as flaper87|afk | 21:02 | |
| *** malini_afk is now known as malini | 21:02 | |
| kgriffs | malini: o/ | 21:12 |
| malini | \o | 21:13 |
| kgriffs | hey, so about that bug | 21:15 |
| kgriffs | tuns out that Z sorts before 'q' | 21:16 |
| kgriffs | so, 'q' is greater than 'Z | 21:16 |
| malini | what abt 'z' ? | 21:17 |
| kgriffs | lowercase z is fine | 21:17 |
| malini | hmm..I was getting 200s with 'z' as well :( | 21:18 |
| kgriffs | uppercase sorts that way because in the character table, uppercase has lower integers than lowercase | 21:18 |
| kgriffs | malini: yes, I would expect that when there is more than one project ID | 21:18 |
| kgriffs | is that the case? | 21:18 |
| kgriffs | because.... | 21:18 |
| kgriffs | that is another bug I discovered | 21:18 |
| malini | I am getting a different set of queues with lower case 'z' | 21:19 |
| malini | But this time I get queues starting with 'U' | 21:20 |
| kgriffs | if I'm right, then those other queues actually belong to a different project than the one you asked for | 21:20 |
| kgriffs | I know for a fact there is a bug there. Whether there are others, is TBD | 21:21 |
| malini | this is the response with ?marker=zzz , http://paste.openstack.org/raw/48051/ | 21:21 |
| malini | it is probable that these are for a different project, since it looks like the Unit Tests create these q's | 21:22 |
| kgriffs | ok | 21:24 |
| kgriffs | let me finish this patch and then you can see if it fixes the problem | 21:24 |
| malini | ok | 21:24 |
| ekarlso | aloha :p | 21:24 |
| kgriffs | malini: btw, I found some big holes in the unit test for listing queues while doing this. | 21:25 |
| kgriffs | ekarlso: guten Tag! | 21:26 |
| malini | kgriffs: that is concerning :( we have coverage in functional tests, but we probably need to revisit all the API's if we are missing anything else | 21:26 |
| kgriffs | well, there wasn't a test anywhere detecting returning queues from the wrong project, for example | 21:27 |
| kgriffs | (I added it to the unit test) | 21:27 |
| kgriffs | (just now) | 21:27 |
| kgriffs | Also, the unit test was still attempting to "PUT" metadata when creating a queue | 21:27 |
| kgriffs | and not really checking that metadata was being returned in listings | 21:27 |
| malini | that must be a cruft from the old design.. | 21:28 |
| kgriffs | yep | 21:28 |
| malini | the functional tests do not validate the project id part either..will add that to my todo | 21:28 |
| kgriffs | sounds good | 21:28 |
| malini | Guess we'll need the project-id validation for other parts of our api as well | 21:29 |
| *** tedross has quit IRC | 21:33 | |
| *** notmyname has quit IRC | 21:34 | |
| *** zzs has quit IRC | 21:34 | |
| *** openstackgerrit has quit IRC | 21:34 | |
| *** notmyname has joined #openstack-marconi | 21:35 | |
| *** zzs has joined #openstack-marconi | 21:35 | |
| kgriffs | malini: ok, I am doing a final test on my fix | 21:35 |
| kgriffs | will be submitting shortly | 21:35 |
| kgriffs | did you ever create a bug for this? | 21:36 |
| malini | no..I will | 21:36 |
| malini | do it now | 21:36 |
| kgriffs | ok | 21:36 |
| malini | or wud you rather do it? since this is diff from the original one? | 21:36 |
| kgriffs | basically, the bug turned out to be that we would return queues from other projects instead of stopping at the end | 21:37 |
| kgriffs | i can do it | 21:37 |
| kgriffs | stand by | 21:37 |
| kgriffs | https://bugs.launchpad.net/marconi/+bug/1236605 | 21:39 |
| malini | kgriffs: does this potentially afect other listings as well ? like messages? | 21:41 |
| amitgandhi | do we have security tests, to ensure we cant get other user queues/messages | 21:41 |
| kgriffs | nope | 21:41 |
| kgriffs | message listing markers are independent of project ID | 21:42 |
| kgriffs | I mean, we are already explicitly checking project ID when listing messages | 21:42 |
| kgriffs | good thought, tho! | 21:43 |
| kgriffs | bugs do tend to cluster | 21:43 |
| malini | amitgandhi: we dont have security tests..but we need those & Ihave it in my todo list now | 21:45 |
| amitgandhi | cool | 21:45 |
| *** vkmc has quit IRC | 21:47 | |
| kgriffs | malini: https://review.openstack.org/#/c/50176/ | 21:51 |
| *** kgriffs is now known as kgriffs_afk | 22:01 | |
| amitgandhi | kgriffs: have you ever run into this issue installing marconi on mac osx | 22:14 |
| amitgandhi | Unknown distribution option: 'setup_requires' | 22:15 |
| amitgandhi | Unknown distribution option: 'pbr' | 22:15 |
| amitgandhi | i've been getting that lately when i try to run python setup.py develop | 22:15 |
| amitgandhi | on a fresh install of marconi in a venv | 22:15 |
| amitgandhi | hmm interesting | 22:19 |
| amitgandhi | after pip install d2to1 i get a diff error now for a bunch of other dists | 22:19 |
| mpanetta | Oh man... | 22:23 |
| mpanetta | I think alej knows that one. | 22:23 |
| mpanetta | dtry pip install --upgrade instead | 22:23 |
| mpanetta | *try | 22:23 |
| mpanetta | I think that is what I ended up doing. | 22:23 |
| mpanetta | amitgandhi: ^^ | 22:24 |
| *** jcru has quit IRC | 22:24 | |
| amitgandhi | what did you upgrade? | 22:25 |
| amitgandhi | ive tried pip install -U setuptools | 22:25 |
| mpanetta | It may have been d2to1 | 22:25 |
| mpanetta | it was either that or pbr, I had issues with both. | 22:26 |
| amitgandhi | when i installed d2to1 it got me around the pbr issue | 22:26 |
| amitgandhi | but now it doesnst know about entry_points, install_requires, etc | 22:26 |
| mpanetta | try reinstalling it with upgrade option. | 22:27 |
| amitgandhi | i did | 22:27 |
| amitgandhi | =/ | 22:27 |
| amitgandhi | after forcing an upgrade of setuptools... | 22:29 |
| amitgandhi | …im back to the pbr issue | 22:29 |
| mpanetta | Oh wonderful... | 22:29 |
| mpanetta | Cd to your marconi code and do pip install -U -r requirements.txt | 22:30 |
| mpanetta | That is another workaround we use at times... | 22:30 |
| amitgandhi | …is installing a bunch of stuff | 22:31 |
| amitgandhi | cool | 22:32 |
| amitgandhi | i think that worked | 22:32 |
| amitgandhi | you rock =) | 22:32 |
| mpanetta | yeah. Probably every single requirement. | 22:32 |
| mpanetta | Nah, I just listen :P | 22:32 |
| mpanetta | And ocasionally remember lol | 22:32 |
| amitgandhi | thanks for your help | 22:32 |
| mpanetta | No problem | 22:32 |
| *** amitgandhi has quit IRC | 22:33 | |
| *** mpanetta has quit IRC | 22:34 | |
| *** openstackgerrit has joined #openstack-marconi | 23:01 | |
| *** dafter has quit IRC | 23:05 | |
| *** vkmc has joined #openstack-marconi | 23:07 | |
| *** fifieldt has joined #openstack-marconi | 23:26 | |
| *** tedross has joined #openstack-marconi | 23:39 | |
| *** amitgandhi has joined #openstack-marconi | 23:42 | |
| *** zzs has left #openstack-marconi | 23:44 | |
| *** amitgandhi1 has joined #openstack-marconi | 23:47 | |
| *** amitgandhi has quit IRC | 23:47 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!